Re: [Mesa-dev] Trouble with missing git_sha1.h when building from a fresh tree

2016-06-24 Thread Chad Versace
On Thu 16 Jun 2016, Emil Velikov wrote: > On 16 June 2016 at 21:14, Haixia Shi wrote: > > Emil > > > > I looked at commit 3689ef32 which started the problem, and it seems that > > patch removed the line "touch git_sha1.h.tmp". Previously my workflow was > > "working" because

Re: [Mesa-dev] Trouble with missing git_sha1.h when building from a fresh tree

2016-06-16 Thread Emil Velikov
On 16 June 2016 at 21:14, Haixia Shi wrote: > Emil > > I looked at commit 3689ef32 which started the problem, and it seems that > patch removed the line "touch git_sha1.h.tmp". Previously my workflow was > "working" because the touch command ensures there's always going to be

Re: [Mesa-dev] Trouble with missing git_sha1.h when building from a fresh tree

2016-06-16 Thread Haixia Shi
Emil I looked at commit 3689ef32 which started the problem, and it seems that patch removed the line "touch git_sha1.h.tmp". Previously my workflow was "working" because the touch command ensures there's always going to be an empty header file. Was this intentional? For the new git_sha1.h rules,

Re: [Mesa-dev] Trouble with missing git_sha1.h when building from a fresh tree

2016-06-16 Thread Emil Velikov
On 16 June 2016 at 20:47, Emil Velikov wrote: > On 16 June 2016 at 20:42, Haixia Shi wrote: >> Bisect shows the problem started at commit >> 3689ef32afdafbb030069e560aac0e563fc29048 >> Author: Emil Velikov >> Date: Mon

Re: [Mesa-dev] Trouble with missing git_sha1.h when building from a fresh tree

2016-06-16 Thread Emil Velikov
On 16 June 2016 at 20:42, Haixia Shi wrote: > Bisect shows the problem started at commit > 3689ef32afdafbb030069e560aac0e563fc29048 > Author: Emil Velikov > Date: Mon May 30 12:32:05 2016 +0100 > > automake: rework the git_sha1.h rule, include

Re: [Mesa-dev] Trouble with missing git_sha1.h when building from a fresh tree

2016-06-16 Thread Emil Velikov
Hi Haixia Shi, On 16 June 2016 at 19:46, Haixia Shi wrote: > Posting a question in case someone already know the issue. > > I'm observing "missing git_sha1.h" errors sometime after Emil's git_sha1.h > patches by May 31st. This is not fixed at TOT with the latest patches on >

Re: [Mesa-dev] Trouble with missing git_sha1.h when building from a fresh tree

2016-06-16 Thread Haixia Shi
Bisect shows the problem started at commit 3689ef32afdafbb030069e560aac0e563fc29048 Author: Emil Velikov Date: Mon May 30 12:32:05 2016 +0100 automake: rework the git_sha1.h rule, include in tarball As we'll need the file in the release tarball, rework the

[Mesa-dev] Trouble with missing git_sha1.h when building from a fresh tree

2016-06-16 Thread Haixia Shi
Posting a question in case someone already know the issue. I'm observing "missing git_sha1.h" errors sometime after Emil's git_sha1.h patches by May 31st. This is not fixed at TOT with the latest patches on Makefile.am. The problem only happens if src/git_sha1.h doesn't exist already. I just