Re: [Mesa-dev] What does WIP really mean in an MR?

2019-07-02 Thread Eric Anholt
Eric Engestrom writes: > On Saturday, 2019-06-29 22:59:21 +0200, apinheiro wrote: >> >> On 29/6/19 2:30, Rob Clark wrote: >> > I had interpreted it as literally the "block the gitlab merge button" >> > option, ie. "I want to get feedback but it is not ready to merge and >> > I'll drop the WIP ta

Re: [Mesa-dev] What does WIP really mean in an MR?

2019-07-01 Thread Nanley Chery
On Sat, Jun 29, 2019 at 4:40 PM Eric Engestrom wrote: > > On Saturday, 2019-06-29 22:59:21 +0200, apinheiro wrote: > > > > On 29/6/19 2:30, Rob Clark wrote: > > > I had interpreted it as literally the "block the gitlab merge button" > > > option, ie. "I want to get feedback but it is not ready to

Re: [Mesa-dev] What does WIP really mean in an MR?

2019-06-29 Thread Eric Engestrom
On Saturday, 2019-06-29 22:59:21 +0200, apinheiro wrote: > > On 29/6/19 2:30, Rob Clark wrote: > > I had interpreted it as literally the "block the gitlab merge button" > > option, ie. "I want to get feedback but it is not ready to merge and > > I'll drop the WIP tag when I think it is".. > > >

Re: [Mesa-dev] What does WIP really mean in an MR?

2019-06-29 Thread apinheiro
On 29/6/19 2:30, Rob Clark wrote: I had interpreted it as literally the "block the gitlab merge button" option, ie. "I want to get feedback but it is not ready to merge and I'll drop the WIP tag when I think it is".. (comments inline) On Fri, Jun 28, 2019 at 5:12 PM Ian Romanick wrote: A

Re: [Mesa-dev] What does WIP really mean in an MR?

2019-06-28 Thread Rob Clark
I had interpreted it as literally the "block the gitlab merge button" option, ie. "I want to get feedback but it is not ready to merge and I'll drop the WIP tag when I think it is".. (comments inline) On Fri, Jun 28, 2019 at 5:12 PM Ian Romanick wrote: > > After a conversation yesterday with a c

[Mesa-dev] What does WIP really mean in an MR?

2019-06-28 Thread Ian Romanick
After a conversation yesterday with a couple of the other Intel devs, I've come to the conclusion that *everyone* interprets WIP to mean something different. I heard no less than four interpretations. * This series is good. It hasn't been reviewed, so don't click "merge." * This series has some