Re: [Mesa-dev] talloc (Was: Merge criteria for glsl2 branch)

2010-08-13 Thread Dave Airlie
On Fri, Aug 13, 2010 at 4:58 PM, Aras Pranckevicius a...@unity3d.com wrote: But I perceive talloc as different from all above: it's very low level and low weight library, providing very basic functionality, and upstream never showed interest for Windows portability. I'd really prefer to see

Re: [Mesa-dev] talloc (Was: Merge criteria for glsl2 branch)

2010-08-13 Thread Aras Pranckevicius
Like I said before, full port of talloc seems to be not needed for compiling on Visual C++; just drop in talloc.h talloc.c into the project and that's it. Same for Mac with Xcode. Be careful about LGPLv3 rules, If you are distributing anything linked with an LGPL library without

Re: [Mesa-dev] talloc (Was: Merge criteria for glsl2 branch)

2010-08-13 Thread José Fonseca
On Thu, 2010-08-12 at 14:46 -0700, Ian Romanick wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 José Fonseca wrote: OK. What about this: For GLUT, GLEW, LLVM and all other dependencies I'll just make a SDK with the binaries, with debug release, 32 64 bit, MinGW MSVC

Re: [Mesa-dev] talloc (Was: Merge criteria for glsl2 branch)

2010-08-13 Thread Aras Pranckevicius
I had to rename some tokens in order to avoid collisions with windows.h defines. Aras didn't mention this problem before. I mentioned this to Eric in private conversation, but on this list I only talked about talloc specific changes. Yeah, in the glsl2 parser some tokens clash with windows

Re: [Mesa-dev] talloc (Was: Merge criteria for glsl2 branch)

2010-08-12 Thread José Fonseca
On Wed, 2010-08-11 at 17:40 -0700, Dave Airlie wrote: On Thu, Aug 12, 2010 at 9:42 AM, José Fonseca jfons...@vmware.com wrote: On Wed, 2010-08-11 at 12:52 -0700, Ian Romanick wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 José Fonseca wrote: Could then Aras Pranckevicius's

Re: [Mesa-dev] talloc (Was: Merge criteria for glsl2 branch)

2010-08-12 Thread Dave Airlie
On Thu, Aug 12, 2010 at 9:00 PM, José Fonseca jfons...@vmware.com wrote: On Wed, 2010-08-11 at 17:40 -0700, Dave Airlie wrote: On Thu, Aug 12, 2010 at 9:42 AM, José Fonseca jfons...@vmware.com wrote: On Wed, 2010-08-11 at 12:52 -0700, Ian Romanick wrote: -BEGIN PGP SIGNED MESSAGE-

Re: [Mesa-dev] talloc (Was: Merge criteria for glsl2 branch)

2010-08-12 Thread José Fonseca
On Thu, 2010-08-12 at 04:10 -0700, Dave Airlie wrote: On Thu, Aug 12, 2010 at 9:00 PM, José Fonseca jfons...@vmware.com wrote: On Wed, 2010-08-11 at 17:40 -0700, Dave Airlie wrote: On Thu, Aug 12, 2010 at 9:42 AM, José Fonseca jfons...@vmware.com wrote: On Wed, 2010-08-11 at 12:52 -0700,

Re: [Mesa-dev] talloc (Was: Merge criteria for glsl2 branch)

2010-08-12 Thread Matt Turner
On Thu, Aug 12, 2010 at 7:00 AM, José Fonseca jfons...@vmware.com wrote: Really optimising for the wrong bunch of people here by dragging this stuff into mesa git. Many projects do this: they include the source of other projects, to make it easier to build without having to build all

Re: [Mesa-dev] talloc (Was: Merge criteria for glsl2 branch)

2010-08-12 Thread José Fonseca
On Thu, 2010-08-12 at 07:58 -0700, Matt Turner wrote: On Thu, Aug 12, 2010 at 7:00 AM, José Fonseca jfons...@vmware.com wrote: Really optimising for the wrong bunch of people here by dragging this stuff into mesa git. Many projects do this: they include the source of other projects, to

Re: [Mesa-dev] talloc (Was: Merge criteria for glsl2 branch)

2010-08-12 Thread Matt Turner
On Thu, Aug 12, 2010 at 11:27 AM, José Fonseca jfons...@vmware.com wrote: On Thu, 2010-08-12 at 07:58 -0700, Matt Turner wrote: On Thu, Aug 12, 2010 at 7:00 AM, José Fonseca jfons...@vmware.com wrote: Really optimising for the wrong bunch of people here by dragging this stuff into mesa git.

Re: [Mesa-dev] talloc (Was: Merge criteria for glsl2 branch)

2010-08-12 Thread José Fonseca
On Thu, 2010-08-12 at 08:33 -0700, Matt Turner wrote: On Thu, Aug 12, 2010 at 11:27 AM, José Fonseca jfons...@vmware.com wrote: On Thu, 2010-08-12 at 07:58 -0700, Matt Turner wrote: On Thu, Aug 12, 2010 at 7:00 AM, José Fonseca jfons...@vmware.com wrote: Really optimising for the wrong

Re: [Mesa-dev] talloc (Was: Merge criteria for glsl2 branch)

2010-08-11 Thread José Fonseca
On Tue, 2010-08-10 at 22:57 -0700, Aras Pranckevicius wrote: No, it's missing most of the API that talloc provides. Also, http://github.com/aras-p/glsl-optimizer/ ported it to windows. Could then Aras Pranckevicius's talloc port to windows be

Re: [Mesa-dev] talloc (Was: Merge criteria for glsl2 branch)

2010-08-11 Thread Ian Romanick
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 José Fonseca wrote: Could then Aras Pranckevicius's talloc port to windows be merged into glsl2 branch before glsl2 is merged into master? I think we learned our lesson with GLEW. Trying to keep a copy of an external dependency in our tree only

Re: [Mesa-dev] talloc (Was: Merge criteria for glsl2 branch)

2010-08-11 Thread Aras Pranckevicius
Could then Aras Pranckevicius's talloc port to windows be merged into glsl2 branch before glsl2 is merged into master? I think we learned our lesson with GLEW. Trying to keep a copy of an external dependency in our tree only leads to sadness. I have no intention to repeat that mistake.

Re: [Mesa-dev] talloc (Was: Merge criteria for glsl2 branch)

2010-08-11 Thread José Fonseca
On Wed, 2010-08-11 at 12:52 -0700, Ian Romanick wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 José Fonseca wrote: Could then Aras Pranckevicius's talloc port to windows be merged into glsl2 branch before glsl2 is merged into master? I think we learned our lesson with GLEW.

Re: [Mesa-dev] talloc (Was: Merge criteria for glsl2 branch)

2010-08-11 Thread José Fonseca
On Wed, 2010-08-11 at 13:18 -0700, Aras Pranckevicius wrote: Could then Aras Pranckevicius's talloc port to windows be merged into glsl2 branch before glsl2 is merged into master? I think we learned our lesson with GLEW. Trying to keep a

Re: [Mesa-dev] talloc (Was: Merge criteria for glsl2 branch)

2010-08-11 Thread Dave Airlie
On Thu, Aug 12, 2010 at 9:42 AM, José Fonseca jfons...@vmware.com wrote: On Wed, 2010-08-11 at 12:52 -0700, Ian Romanick wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 José Fonseca wrote: Could then Aras Pranckevicius's talloc port to windows be merged into glsl2 branch before glsl2

Re: [Mesa-dev] talloc (Was: Merge criteria for glsl2 branch)

2010-08-10 Thread José Fonseca
On Sun, 2010-08-01 at 10:19 -0700, Eric Anholt wrote: On Tue, 27 Jul 2010 21:32:57 +0100, José Fonseca jfons...@vmware.com wrote: On Wed, 2010-07-21 at 18:53 -0700, Ian Romanick wrote: As everyone knows, a group of us at Intel have been rewriting Mesa's GLSL compiler. The work started

Re: [Mesa-dev] talloc (Was: Merge criteria for glsl2 branch)

2010-08-10 Thread Aras Pranckevicius
No, it's missing most of the API that talloc provides. Also, http://github.com/aras-p/glsl-optimizer/ ported it to windows. Could then Aras Pranckevicius's talloc port to windows be merged into glsl2 branch before glsl2 is merged into master? First things first: I needed to make it

Re: [Mesa-dev] talloc (Was: Merge criteria for glsl2 branch)

2010-08-01 Thread Eric Anholt
On Tue, 27 Jul 2010 21:32:57 +0100, José Fonseca jfons...@vmware.com wrote: On Wed, 2010-07-21 at 18:53 -0700, Ian Romanick wrote: As everyone knows, a group of us at Intel have been rewriting Mesa's GLSL compiler. The work started out-of-tree as a stand alone compiler. We moved all of

[Mesa-dev] talloc (Was: Merge criteria for glsl2 branch)

2010-07-27 Thread José Fonseca
On Wed, 2010-07-21 at 18:53 -0700, Ian Romanick wrote: As everyone knows, a group of us at Intel have been rewriting Mesa's GLSL compiler. The work started out-of-tree as a stand alone compiler. We moved all of our work to the glsl2 branch in the Mesa tree as soon as we had some actual code