Re: [Mesa-dev] [PATCH] glsl: reuse main extension table to appropriate restrict extensions

On Mon, Jun 13, 2016 at 1:27 PM, Eric Engestrom wrote: > On Mon, Jun 13, 2016 at 09:39:39AM -0700, Nanley Chery wrote: >> You can add an entry to the end of the enum defined in extensions.h called >> "MESA_EXTENSION_COUNT" or similar. > > This is a good idea, but with

Re: [Mesa-dev] [PATCH] glsl: reuse main extension table to appropriate restrict extensions

On Mon, Jun 13, 2016 at 9:08 AM, Ilia Mirkin wrote: > On Mon, Jun 13, 2016 at 12:03 PM, Nanley Chery > wrote: > > > > > > On Sun, Jun 12, 2016 at 4:23 PM, Ilia Mirkin > wrote: > >> > >> Previously we were only restricting

Re: [Mesa-dev] [PATCH] glsl: reuse main extension table to appropriate restrict extensions

On Mon, Jun 13, 2016 at 09:39:39AM -0700, Nanley Chery wrote: > You can add an entry to the end of the enum defined in extensions.h called > "MESA_EXTENSION_COUNT" or similar. This is a good idea, but with one caveat: I've seen twice already bugs caused by people using ALL_CAPS counter entries

Re: [Mesa-dev] [PATCH] glsl: reuse main extension table to appropriate restrict extensions

On Mon, Jun 13, 2016 at 12:39 PM, Nanley Chery wrote: > > > On Mon, Jun 13, 2016 at 9:16 AM, Ilia Mirkin wrote: >> >> On Mon, Jun 13, 2016 at 12:11 PM, Emil Velikov >> wrote: >> > Hi Ilia, >> > >> > On 13 June 2016 at 00:23,

Re: [Mesa-dev] [PATCH] glsl: reuse main extension table to appropriate restrict extensions

On 13 June 2016 at 17:16, Ilia Mirkin wrote: > On Mon, Jun 13, 2016 at 12:11 PM, Emil Velikov > wrote: >> Hi Ilia, >> >> On 13 June 2016 at 00:23, Ilia Mirkin wrote: >> >>> @@ -81,6 +81,7 @@ MAIN_FILES = \ >>>

Re: [Mesa-dev] [PATCH] glsl: reuse main extension table to appropriate restrict extensions

On Mon, Jun 13, 2016 at 9:16 AM, Ilia Mirkin wrote: > On Mon, Jun 13, 2016 at 12:11 PM, Emil Velikov > wrote: > > Hi Ilia, > > > > On 13 June 2016 at 00:23, Ilia Mirkin wrote: > > > >> @@ -81,6 +81,7 @@ MAIN_FILES = \ > >>

Re: [Mesa-dev] [PATCH] glsl: reuse main extension table to appropriate restrict extensions

On Mon, Jun 13, 2016 at 12:08:24PM +0100, Eric Engestrom wrote: > > > diff --git a/src/mesa/main/extensions_table.c > > b/src/mesa/main/extensions_table.c > > new file mode 100644 > > index 000..1e37fbc > > --- /dev/null > > +++ b/src/mesa/main/extensions_table.c > > @@ -0,0 +1,51 @@ > > +/*

Re: [Mesa-dev] [PATCH] glsl: reuse main extension table to appropriate restrict extensions

On Mon, Jun 13, 2016 at 12:11 PM, Emil Velikov wrote: > Hi Ilia, > > On 13 June 2016 at 00:23, Ilia Mirkin wrote: > >> @@ -81,6 +81,7 @@ MAIN_FILES = \ >> main/execmem.c \ >> main/extensions.c \ >> main/extensions.h \ >> +

Re: [Mesa-dev] [PATCH] glsl: reuse main extension table to appropriate restrict extensions

Hi Ilia, On 13 June 2016 at 00:23, Ilia Mirkin wrote: > @@ -81,6 +81,7 @@ MAIN_FILES = \ > main/execmem.c \ > main/extensions.c \ > main/extensions.h \ > + main/extensions_table.c \ From a build perspective everything looks amazing. Thank you

Re: [Mesa-dev] [PATCH] glsl: reuse main extension table to appropriate restrict extensions

On Mon, Jun 13, 2016 at 12:03 PM, Nanley Chery wrote: > > > On Sun, Jun 12, 2016 at 4:23 PM, Ilia Mirkin wrote: >> >> Previously we were only restricting based on ES/non-ES-ness and whether >> the overall enable bit had been flipped on. However we

Re: [Mesa-dev] [PATCH] glsl: reuse main extension table to appropriate restrict extensions

On Sun, Jun 12, 2016 at 4:23 PM, Ilia Mirkin wrote: > Previously we were only restricting based on ES/non-ES-ness and whether > the overall enable bit had been flipped on. However we have been adding > more fine-grained restrictions, such as based on compat profiles, as >

Re: [Mesa-dev] [PATCH] glsl: reuse main extension table to appropriate restrict extensions

On Mon, Jun 13, 2016 at 12:08:24PM +0100, Eric Engestrom wrote: > static enum { extension_table_size = > ARRAY_SIZE(extension_table_for_size) }; Sorry, I don't know how that `static` snuck in here, but it obviously shouldn't be here. ___

Re: [Mesa-dev] [PATCH] glsl: reuse main extension table to appropriate restrict extensions

On Sun, Jun 12, 2016 at 07:23:41PM -0400, Ilia Mirkin wrote: > Previously we were only restricting based on ES/non-ES-ness and whether > the overall enable bit had been flipped on. However we have been adding > more fine-grained restrictions, such as based on compat profiles, as > well as specific