I've pushed this patch. I'll let somebody else review the other one.
Marek
On Thu, Oct 3, 2013 at 12:12 AM, Grigori Goronzy g...@chown.ath.cx wrote:
All texture instructions can use offsets, not just TXF. Offsets into
the literals array were wrong, too.
---
On 03.10.2013 00:12, Grigori Goronzy wrote:
All texture instructions can use offsets, not just TXF. Offsets into
the literals array were wrong, too.
BTW, I just noticed it now: this fixes the fs-textureOffset-2D piglit
test, which unfortunately does not appear to be part of any of the test
I don't understand. All piglit tests should be listed in all.tests. Is
it not the case with fs-textureOffset-2D?
Marek
On Thu, Oct 3, 2013 at 12:36 AM, Grigori Goronzy g...@chown.ath.cx wrote:
On 03.10.2013 00:12, Grigori Goronzy wrote:
All texture instructions can use offsets, not just TXF.
On 10/02/2013 04:20 PM, Marek Olšák wrote:
I don't understand. All piglit tests should be listed in all.tests. Is
it not the case with fs-textureOffset-2D?
I think that's a shader_runner test (file name is *.shader_test).
shader_runner tests aren't explicitly listed in all.tests. Instead some
That's news to me that all tests must be part of all.tests. You can
blame me for that, I thought there were others not being part of
all.tests, but the README indeed states all new tests must be part of
it. So maybe the only tests not added there are those I wrote :-).
Roland
Am 03.10.2013
On 10/02/2013 05:08 PM, Roland Scheidegger wrote:
That's news to me that all tests must be part of all.tests. You can
blame me for that, I thought there were others not being part of
all.tests, but the README indeed states all new tests must be part of
it. So maybe the only tests not added
On 10/02/2013 05:03 PM, Ian Romanick wrote:
On 10/02/2013 04:20 PM, Marek Olšák wrote:
I don't understand. All piglit tests should be listed in all.tests. Is
it not the case with fs-textureOffset-2D?
I think that's a shader_runner test (file name is *.shader_test).
shader_runner tests
Not all tests have to be part of all.tests, like the
framebuffer_blit_scaled ones, because they are more strict than the
spec mandates.
However generally, all tests that it makes sense to test regularly
should be listed in all.tests. I only use quick.tests, which is the
only way I use piglit. I
