Re: [Mesa-dev] [PATCH 1/2] radeonsi: Lock a mutex when checking scratch relocations.

On 21.04.2016 13:51, Bas Nieuwenhuizen wrote: We can use shaders from multiple contexts, and they were not otherwise locked yet. Ouch... I guess this is why compute scratch buffers used to be per-program? I'm still trying to wrap my head around the possible code paths here... are you sure

[Mesa-dev] [PATCH 5/5] i965: Write a scalar TCS backend that runs in SINGLE_PATCH mode.

Unlike most shader stages, the Hull Shader hardware makes us explicitly tell it how many threads to dispatch and manually configure the channel mask. One perk of this is that we have a lot of flexibility - we can run it in either SIMD4x2 or SIMD8 mode. Treating it as SIMD8 means that shaders

[Mesa-dev] [PATCH 4/5] i965: Rework the TCS passthrough shader to use NIR.

I'm about to implement a scalar TCS backend, and I'd rather not duplicate all of this code there. One change is that we now write the tessellation levels from all TCS threads, rather than just the first. This is pretty harmless, and was easier. The IF/ENDIF needed for that are gone; otherwise

[Mesa-dev] [PATCH 3/5] i965: Move TCS output indirect_offset.file check out a level.

I want to add another condition. Moving the indirect_offset.file check out a level should make this a little easier. Signed-off-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/brw_vec4_tcs.cpp | 88 -- 1 file changed, 46 insertions(+), 42

[Mesa-dev] [PATCH] i965: don't lower mod() in glsl ir

NIR will lower it in nir_opt_algebraic. Signed-off-by: Samuel Iglesias Gonsálvez --- src/mesa/drivers/dri/i965/brw_link.cpp | 1 - 1 file changed, 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/brw_link.cpp b/src/mesa/drivers/dri/i965/brw_link.cpp index

[Mesa-dev] [PATCH 2/5] i965: Mark URB reads as volatile.

They can be affected by URB writes. In the upcoming scalar TCS backend, this prevents read-modify-write cycles from being broken by CSE removing reads. Signed-off-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/brw_shader.cpp | 3 +++ 1 file changed, 3 insertions(+)

[Mesa-dev] [PATCH 1/5] i965: Make a few tessellation related functions non-static.

Also, move them to brw_shader.cpp so they're in a location for code used by both the vec4 and fs worlds. Signed-off-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/brw_shader.cpp | 47 ++ src/mesa/drivers/dri/i965/brw_shader.h | 4 +++

Re: [Mesa-dev] [PATCH 22/27] glsl: add helper for comparing arrays in varying packing pass

On 2016-03-31 21:57, Timothy Arceri wrote: --- src/compiler/glsl/lower_packed_varyings.cpp | 25 + 1 file changed, 25 insertions(+) diff --git a/src/compiler/glsl/lower_packed_varyings.cpp b/src/compiler/glsl/lower_packed_varyings.cpp index ad766bb..6e7a289 100644

Re: [Mesa-dev] [PATCH] egl: android: add dma-buf fd support

> On 20 April 2016 at 03:52, Rob Herring wrote: >> On Tue, Apr 19, 2016 at 8:03 PM, Emil Velikov >> wrote: >>> Looking at this patch and Varad's work >>> there a hunk missing here [1]. Did you not come across the issue in >>> question ? >> >> I don't

[Mesa-dev] [PATCH v2] nir/lower_double_ops: lower trunc()

From: Iago Toral Quiroga At least i965 hardware does not have native support for truncating doubles. v2: - Simplified the implementation significantly. - Fixed the else branch, that was not doing what we wanted. --- src/compiler/nir/nir.h | 1 +

[Mesa-dev] [PATCH 5/9] i965/gen6+: Add support for storing immediate data into a buffer

Signed-off-by: Jordan Justen --- src/mesa/drivers/dri/i965/brw_context.h | 4 +++ src/mesa/drivers/dri/i965/intel_batchbuffer.c | 45 +++ src/mesa/drivers/dri/i965/intel_reg.h | 1 + 3 files changed, 50 insertions(+) diff --git

[Mesa-dev] [PATCH 8/9] i965: Implement ARB_query_buffer_object for HSW+

Signed-off-by: Jordan Justen --- src/mesa/drivers/dri/i965/Makefile.sources | 1 + src/mesa/drivers/dri/i965/brw_context.c | 4 +- src/mesa/drivers/dri/i965/brw_context.h | 5 + src/mesa/drivers/dri/i965/brw_queryobj.c | 35 ++-

[Mesa-dev] [PATCH 6/9] i965/hsw+: Add support for copying a register

Signed-off-by: Jordan Justen --- src/mesa/drivers/dri/i965/brw_context.h | 2 ++ src/mesa/drivers/dri/i965/intel_batchbuffer.c | 15 +++ src/mesa/drivers/dri/i965/intel_reg.h | 1 + 3 files changed, 18 insertions(+) diff --git

[Mesa-dev] [PATCH 4/9] i965: Add MI_MATH reg defs for HSW+

Signed-off-by: Jordan Justen --- src/mesa/drivers/dri/i965/intel_reg.h | 38 +++ 1 file changed, 38 insertions(+) diff --git a/src/mesa/drivers/dri/i965/intel_reg.h b/src/mesa/drivers/dri/i965/intel_reg.h index 365c045..01b4358 100644

[Mesa-dev] [PATCH 1/9] i965: Use offset instead of index in brw_store_register_mem64

This matches the byte based offset of brw_load_register_mem*. The function is also move into intel_batchbuffer.c like brw_load_register_mem*. Signed-off-by: Jordan Justen --- src/mesa/drivers/dri/i965/brw_context.h| 2 +-

[Mesa-dev] [PATCH 2/9] squash: i965: Move brw_store_register_mem64 to intel_batchbuffer.c

--- src/mesa/drivers/dri/i965/brw_context.h | 4 +-- src/mesa/drivers/dri/i965/gen6_queryobj.c | 43 --- src/mesa/drivers/dri/i965/intel_batchbuffer.c | 37 +++ 3 files changed, 39 insertions(+), 45 deletions(-) diff --git

[Mesa-dev] [PATCH 7/9] i965/gen6+: Add load register immediate helper functions

Signed-off-by: Jordan Justen --- src/mesa/drivers/dri/i965/brw_context.h | 4 src/mesa/drivers/dri/i965/intel_batchbuffer.c | 32 +++ 2 files changed, 36 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_context.h

[Mesa-dev] [PATCH 3/9] i965: Add brw_store_register_mem32

Signed-off-by: Jordan Justen --- src/mesa/drivers/dri/i965/brw_context.h | 2 ++ src/mesa/drivers/dri/i965/intel_batchbuffer.c | 26 ++ 2 files changed, 28 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_context.h

[Mesa-dev] [PATCH 9/9] docs: Mark GL_ARB_query_buffer_object as done for i965/hsw+

Signed-off-by: Jordan Justen --- docs/GL3.txt | 2 +- docs/relnotes/11.3.0.html | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/docs/GL3.txt b/docs/GL3.txt index 6214f8d..63ebc67 100644 --- a/docs/GL3.txt +++ b/docs/GL3.txt @@ -201,7

[Mesa-dev] [PATCH 0/9] i965: Add ARB_query_buffer_object for HSW+

I sent out an update to the piglit 'qbo' test, which this series passes. I didn't test the Geometry, Tessellation or Compute queries. Jordan Justen (9): i965: Use offset instead of index in brw_store_register_mem64 squash: i965: Move brw_store_register_mem64 to intel_batchbuffer.c i965:

Re: [Mesa-dev] [PATCH 19/27] glsl: skip location and component packing validation on patch out

Acked-by: Edward O'Callaghan On 2016-03-31 21:57, Timothy Arceri wrote: These outputs have a separate location domain from per-vertex outputs and need to be handled separately. For now just skip validation so we don't invalidate valid shaders. ---

Re: [Mesa-dev] [PATCH 26/27] glsl: always enable ARB_enhanced_layouts in Core Profile

On Fri, Apr 22, 2016 at 12:46 AM, Timothy Arceri wrote: > On Thu, 2016-03-31 at 09:44 -0400, Ilia Mirkin wrote: >> Presumably you also want to remove the enable from Consts.Extensions? >> (mtypes.h) > > I left it there because I thought overriding would break without

Re: [Mesa-dev] [PATCH 2/2] radeonsi: Fix memory leak in error path.

Reviewed-by: Nicolai Hähnle On 21.04.2016 13:51, Bas Nieuwenhuizen wrote: Signed-off-by: Bas Nieuwenhuizen --- src/gallium/drivers/radeonsi/si_compute.c | 2 ++ 1 file changed, 2 insertions(+) diff --git

Re: [Mesa-dev] [PATCH 36/40] i965/blorp: Reconfigure base state address only if needed

On Saturday, April 16, 2016 4:43:04 PM PDT Topi Pohjolainen wrote: > Signed-off-by: Topi Pohjolainen > --- > src/mesa/drivers/dri/i965/brw_blorp.cpp | 3 ++- > src/mesa/drivers/dri/i965/gen6_blorp.cpp | 5 + > src/mesa/drivers/dri/i965/gen8_blorp.cpp | 4 +++- >

Re: [Mesa-dev] [PATCH 26/27] glsl: always enable ARB_enhanced_layouts in Core Profile

On Thu, 2016-03-31 at 09:44 -0400, Ilia Mirkin wrote: > Presumably you also want to remove the enable from Consts.Extensions? > (mtypes.h) I left it there because I thought overriding would break without it meaning people cant force enable it in compat profile. Not sure if that's important or

Re: [Mesa-dev] [PATCH 27/27] docs: mark ARB_enhanced_layouts as DONE

Acked-by: Edward O'Callaghan On 2016-03-31 21:58, Timothy Arceri wrote: --- docs/GL3.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/GL3.txt b/docs/GL3.txt index f6248da..ede8cf5 100644 --- a/docs/GL3.txt +++ b/docs/GL3.txt @@

Re: [Mesa-dev] [PATCH 02/27] glsl: allow component qualifier on varying inputs

Reviewed-by: Edward O'Callaghan On 2016-03-31 21:57, Timothy Arceri wrote: --- src/compiler/glsl/ast_type.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/src/compiler/glsl/ast_type.cpp b/src/compiler/glsl/ast_type.cpp index 30c9eff..de3fdcc 100644 ---

Re: [Mesa-dev] [PATCH] radeonsi: Add config parameter to si_shader_apply_scratch_relocs.

On Thu, Apr 21, 2016 at 06:28:15PM +0200, Bas Nieuwenhuizen wrote: > shader->config is not updated for compute kernels. > > Signed-off-by: Bas Nieuwenhuizen This fixes compute shaders that use scratch. Thanks. Reviewed-by: Tom Stellard >

[Mesa-dev] [PATCH 2/2] i965/blorp: Add support for 2x msaa

Suggested-by: Kenneth Graunke Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/brw_blorp_blit.cpp | 14 +++--- src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 5 ++--- 2 files changed, 9 insertions(+), 10 deletions(-)

[Mesa-dev] [PATCH 1/2] i965/blorp: Add support for encoding/decoding interleaved 2x msaa

Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/brw_blorp_blit.cpp | 44 +++- 1 file changed, 36 insertions(+), 8 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_blorp_blit.cpp

[Mesa-dev] [PATCH v2] swr: fix clang warnings

v2: use alternate logic version in swr_check_render_cond --- src/gallium/drivers/swr/swr_query.cpp | 2 +- src/gallium/drivers/swr/swr_shader.h | 8 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/gallium/drivers/swr/swr_query.cpp

Re: [Mesa-dev] [PATCH] nouveau: codegen: combineLd/St do not combine indirect loads

On Thu, Apr 21, 2016 at 11:40 AM, Hans de Goede wrote: > Hi, > > > On 21-04-16 17:09, Samuel Pitoiset wrote: >> >> >> >> On 04/21/2016 04:46 PM, Hans de Goede wrote: >>> >>> Hi, >>> >>> On 21-04-16 16:28, Ilia Mirkin wrote: On Thu, Apr 21, 2016 at 9:55 AM, Hans de

Re: [Mesa-dev] [PATCH] i965/build: Fix FTBFS due to incorrect variable initialisation

Hi Kai, On 21 April 2016 at 16:21, Kai Wasserbäch wrote: > Broken since b27c85c4c089109339fc37135d0a4d2574024632 > > Cc: Rob Herring > Cc: Emil Velikov > Signed-off-by: Kai Wasserbäch > --- > >

[Mesa-dev] [PATCH] radeonsi: Add config parameter to si_shader_apply_scratch_relocs.

shader->config is not updated for compute kernels. Signed-off-by: Bas Nieuwenhuizen --- src/gallium/drivers/radeonsi/si_compute.c | 2 +- src/gallium/drivers/radeonsi/si_shader.c| 3 ++- src/gallium/drivers/radeonsi/si_shader.h| 1 +

Re: [Mesa-dev] [PATCH] swr: fix clang warnings

On Thu, Apr 21, 2016 at 12:38 PM, Cherniak, Bruce wrote: >> >> On Apr 21, 2016, at 11:20 AM, Ilia Mirkin wrote: >> >> On Thu, Apr 21, 2016 at 12:17 PM, Tim Rowley >> wrote: >>> --- >>>

Re: [Mesa-dev] [PATCH mesa v2 3/3] nouveau: codegen: LOAD: Take src swizzle into account

[+radeon folk] Marek, Nicolai, Bas - please have a look at the doc change and let us know if you think this will cause a problem for radeon. Hans is solving the issue that he wants to swizzle the data loaded from the image/buffer/whatever before sticking it into the dst register. -ilia On

Re: [Mesa-dev] [PATCH 1/2] radeonsi: remove the shader parameter from si_set_ring_buffer

On Thu, Apr 21, 2016 at 5:58 PM, Marek Olšák wrote: > From: Marek Olšák > > not used anymore > > this is a follow-up to the RW buffer cleanup. Thanks. This series is Reviewed-by: Bas Nieuwenhuizen as well as patch 2 from the

Re: [Mesa-dev] [PATCH] swr: fix clang warnings

> > On Apr 21, 2016, at 11:20 AM, Ilia Mirkin wrote: > > On Thu, Apr 21, 2016 at 12:17 PM, Tim Rowley > wrote: >> --- >> src/gallium/drivers/swr/swr_query.cpp | 2 +- >> src/gallium/drivers/swr/swr_shader.h | 8 >> 2 files changed, 5

[Mesa-dev] [PATCH 2/2] radeonsi: simplify invalidation of RW buffer bindings

From: Marek Olšák this is a follow-up to the RW buffer cleanup. --- src/gallium/drivers/radeonsi/si_descriptors.c | 42 --- 1 file changed, 18 insertions(+), 24 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_descriptors.c

[Mesa-dev] [PATCH 1/2] radeonsi: remove the shader parameter from si_set_ring_buffer

From: Marek Olšák not used anymore this is a follow-up to the RW buffer cleanup. --- src/gallium/drivers/radeonsi/si_descriptors.c | 5 + src/gallium/drivers/radeonsi/si_state.h | 2 +- src/gallium/drivers/radeonsi/si_state_shaders.c | 19

Re: [Mesa-dev] [PATCH] swr: add PIPE_CAP_FRAMEBUFFER_NO_ATTACHMENT to get_param

Reviewed-by: Ilia Mirkin On Thu, Apr 21, 2016 at 12:17 PM, Tim Rowley wrote: > --- > src/gallium/drivers/swr/swr_screen.cpp | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/src/gallium/drivers/swr/swr_screen.cpp >

Re: [Mesa-dev] [PATCH 02/25] anv: remove unused dev_icd.json

On 21 April 2016 at 15:56, Jason Ekstrand wrote: > > On Apr 21, 2016 7:52 AM, "Erik Faye-Lund" wrote: >> >> On Thu, Apr 21, 2016 at 3:16 PM, Emil Velikov >> wrote: >> > From: Emil Velikov >> > >> >

[Mesa-dev] [PATCH] swr: add PIPE_CAP_FRAMEBUFFER_NO_ATTACHMENT to get_param

--- src/gallium/drivers/swr/swr_screen.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/drivers/swr/swr_screen.cpp b/src/gallium/drivers/swr/swr_screen.cpp index a0a6324..daee05a 100644 --- a/src/gallium/drivers/swr/swr_screen.cpp +++ b/src/gallium/drivers/swr/swr_screen.cpp

Re: [Mesa-dev] [PATCH] i965/fs: Readd opt_drop_redundant_mov_to_flags().

On Thu, Apr 21, 2016 at 1:15 AM, Iago Toral wrote: > On Wed, 2016-04-20 at 14:22 -0700, Matt Turner wrote: >> This reverts commit b449366587b5f3f64c6fb45fe22c39e4bc8a4309. >> >> I removed the pass thinking that it was now not useful, but that was not >> true. I believe I ran

Re: [Mesa-dev] [PATCH] include/GL: fix the interop header for a --disable-glx build

On 21-Apr-16 4:08 PM, Emil Velikov wrote: On 20 April 2016 at 16:52, Mircea Gherzan wrote: This header should not blindly include the GLX and should also conditionally define functions that use GLX parameters. The MESA_EGL_NO_X11_HEADERS macro is used to check if

Re: [Mesa-dev] [PATCH 4/4] radeonsi: Print a message when scratch allocation fails.

On 21.04.2016 09:14, Bas Nieuwenhuizen wrote: On Wed, Apr 20, 2016 at 8:33 AM, wrote: On 2016-04-20 11:46, Nicolai Hähnle wrote: On 19.04.2016 17:50, Bas Nieuwenhuizen wrote: Signed-off-by: Bas Nieuwenhuizen ---

[Mesa-dev] [PATCH] swr: fix clang warnings

--- src/gallium/drivers/swr/swr_query.cpp | 2 +- src/gallium/drivers/swr/swr_shader.h | 8 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/gallium/drivers/swr/swr_query.cpp b/src/gallium/drivers/swr/swr_query.cpp index e4b8b68..92a1a0b 100644 ---

Re: [Mesa-dev] [PATCH] swr: fix clang warnings

On Thu, Apr 21, 2016 at 12:17 PM, Tim Rowley wrote: > --- > src/gallium/drivers/swr/swr_query.cpp | 2 +- > src/gallium/drivers/swr/swr_shader.h | 8 > 2 files changed, 5 insertions(+), 5 deletions(-) > > diff --git a/src/gallium/drivers/swr/swr_query.cpp >

Re: [Mesa-dev] [PATCH 03/10] radeonsi: generalize si_set_constant_buffer

On 20.04.2016 10:47, Marek Olšák wrote: From: Marek Olšák this will be used in the next commit --- src/gallium/drivers/radeonsi/si_descriptors.c | 27 +-- 1 file changed, 17 insertions(+), 10 deletions(-) diff --git

Re: [Mesa-dev] [PATCH 12/13] i965/fs_surface_builder: Add a helper for converting GL to ISL formats

On Sat 16 Apr 2016, Jason Ekstrand wrote: > --- > .../drivers/dri/i965/brw_fs_surface_builder.cpp| 55 > ++ > 1 file changed, 55 insertions(+) Patch 12 is Reviewed-by: Chad Versace ___ mesa-dev mailing

Re: [Mesa-dev] [PATCH 11/13] i965/fs_surface_builder: Explicitly handle FORMAT_NONE in num_image_coordinates

On Sat 16 Apr 2016, Jason Ekstrand wrote: > Previously, we were relying on has_matching_typed_format returning true for > MESA_FORMAT_NONE which, in turn, relied on _mesa_get_format_bytes returning > 1 for MESA_FORMAT_NONE. When we switch to ISL, this behaviour will no > longer be something we

Re: [Mesa-dev] [PATCH 2/2] radeonsi: simplify invalidation of RW buffer bindings

On 21.04.2016 10:58, Marek Olšák wrote: From: Marek Olšák this is a follow-up to the RW buffer cleanup. Any chance you could squash this with the patch in the earlier series for better bisect-ability of the history? Either way, Reviewed-by: Nicolai Hähnle

Re: [Mesa-dev] [PATCH] include/GL: fix the interop header for a --disable-glx build

> > >> Drop the includes altogether, and forward declare the needed symbols. >> > > But then you end up with forward declarations of symbols that may not even > exist. > I guess you'll already have prototypes that will remain unresolved since if you're using GLX then you probably won't be linking

Re: [Mesa-dev] [PATCH 3/3] gallium/ddebug: Implement launch_grid.

On Thu, Apr 21, 2016 at 8:03 PM, Nicolai Hähnle wrote: > On 21.04.2016 10:42, Bas Nieuwenhuizen wrote: >> >> Does not implement dumping info. > > > Why not? I primarily wrote this series to make ddebug not crash when used with compute, so I haven't really looked at what It

Re: [Mesa-dev] [PATCH 02/10] radeonsi: make RW buffer descriptor array global, not per shader stage

On 21.04.2016 07:49, Bas Nieuwenhuizen wrote: On Wed, Apr 20, 2016 at 5:47 PM, Marek Olšák wrote: From: Marek Olšák --- src/gallium/drivers/radeonsi/si_descriptors.c | 50 +-- src/gallium/drivers/radeonsi/si_pipe.h|

Re: [Mesa-dev] [PATCH 14/13] i965/surface_state: Use libisl functions for image format lowering

On Sat 16 Apr 2016, Jason Ekstrand wrote: > This lets us delete some redundant code and keep all of the > image_load_store format lowering logic in one place: libisl. > --- > src/mesa/drivers/dri/i965/brw_context.h | 2 - > src/mesa/drivers/dri/i965/brw_surface_formats.c | 109 >

Re: [Mesa-dev] [PATCH] include/GL: fix the interop header for a --disable-glx build

On 21 April 2016 at 18:44, Mircea Gherzan wrote: >>> +#ifdef MESA_EGL_NO_X11_HEADERS >>> +#include >>> +#else >>> #include >>> +#endif >>> + >>> #include >>> >> Drop the includes altogether, and forward declare the needed symbols. > > > Why not use the

Re: [Mesa-dev] [PATCH 03/13] isl: Don't use designated initializers in the header

On Tue 19 Apr 2016, Jason Ekstrand wrote: > On Tue, Apr 19, 2016 at 8:12 PM, Jason Ekstrand > wrote: > FYI (for both of you), I've pushed the latest version of the series with > your review feedback here: > >

[Mesa-dev] [PATCH 2/2] radeonsi: Fix memory leak in error path.

Signed-off-by: Bas Nieuwenhuizen --- src/gallium/drivers/radeonsi/si_compute.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/gallium/drivers/radeonsi/si_compute.c b/src/gallium/drivers/radeonsi/si_compute.c index a99a985..29dbdd8 100644 ---

[Mesa-dev] [PATCH 1/2] radeonsi: Lock a mutex when checking scratch relocations.

We can use shaders from multiple contexts, and they were not otherwise locked yet. Signed-off-by: Bas Nieuwenhuizen --- src/gallium/drivers/radeonsi/si_compute.c | 20 src/gallium/drivers/radeonsi/si_state_shaders.c | 12 ++-- 2 files

Re: [Mesa-dev] [PATCH] include/GL: fix the interop header for a --disable-glx build

> > >> Drop the includes altogether, and forward declare the needed symbols. > But then you end up with forward declarations of symbols that may not even exist. > > Why not use the configure.ac-based approach suggested by Chuck? > > Few reasons come to mind: > > Not to mention that every user

Re: [Mesa-dev] [PATCH 2/3] gallium/ddebug: Support compute states.

On 21.04.2016 10:42, Bas Nieuwenhuizen wrote: Note that compute states have a different struct than the other shader states, so we cannot reuse the macro. Couldn't you still share bind and delete? This requires dealing with the possibility of not having TGSI, but that'll be useful for

Re: [Mesa-dev] [PATCH 10/10] radeonsi: decrease GS copy shader user SGPRs to 2

Nice cleanup. Patches 1, 3-10 are: Reviewed-by: Nicolai Hähnle On 20.04.2016 10:47, Marek Olšák wrote: From: Marek Olšák const buffers are no longer used since the clip plane const buffer was moved to RW buffers ---

Re: [Mesa-dev] [PATCH 13/13] i965/fs_surface_builder: Use isl instead of mesa for format info

On Sat 16 Apr 2016, Jason Ekstrand wrote: > --- > .../drivers/dri/i965/brw_fs_surface_builder.cpp| 118 > + > 1 file changed, 52 insertions(+), 66 deletions(-) > > diff --git a/src/mesa/drivers/dri/i965/brw_fs_surface_builder.cpp >

Re: [Mesa-dev] Mesa (master): 29 new commits

On 20.04.2016 23:02, Michel Dänzer wrote: On 21.04.2016 02:42, Marek Olšák wrote: On Thu, Apr 14, 2016 at 9:29 AM, Michel Dänzer wrote: On 14.04.2016 11:37, Michel Dänzer wrote: On 12.04.2016 21:33, Marek =?UNKNOWN?B?T2zFocOhaw==?= wrote: URL:

Re: [Mesa-dev] [PATCH 3/3] gallium/ddebug: Implement launch_grid.

On 21.04.2016 10:42, Bas Nieuwenhuizen wrote: Does not implement dumping info. Why not? Signed-off-by: Bas Nieuwenhuizen --- src/gallium/drivers/ddebug/dd_draw.c | 29 + 1 file changed, 29 insertions(+) diff --git

Re: [Mesa-dev] [PATCH 1/3] gallium/ddebug: Add passthrough for get_compute_param.

Reviewed-by: Nicolai Hähnle On 21.04.2016 10:42, Bas Nieuwenhuizen wrote: Signed-off-by: Bas Nieuwenhuizen --- src/gallium/drivers/ddebug/dd_screen.c | 12 1 file changed, 12 insertions(+) diff --git

Re: [Mesa-dev] [PATCH] gallium/radeon: implement randomized SDMA testing

Reviewed-by: Nicolai Hähnle On 20.04.2016 14:00, Marek Olšák wrote: From: Marek Olšák --- src/gallium/drivers/r600/r600_pipe.c | 3 + src/gallium/drivers/radeon/Makefile.sources | 1 +

[Mesa-dev] [Bug 94955] Uninitialized variables leads to random segfaults (valgrind log, apitrace attached)

https://bugs.freedesktop.org/show_bug.cgi?id=94955 --- Comment #10 from Bruce Cherniak --- Does the gallium llvm sampler fully support float textures? Both llvmpipe and OpenSWR generate the same sampler and fail identically. I'll attach the sampler ir, if it's useful.

[Mesa-dev] [Bug 94955] Uninitialized variables leads to random segfaults (valgrind log, apitrace attached)

https://bugs.freedesktop.org/show_bug.cgi?id=94955 --- Comment #11 from Bruce Cherniak --- Created attachment 123134 --> https://bugs.freedesktop.org/attachment.cgi?id=123134=edit tex_sample_func Here's the ir for the jit'd sampler. I forced "use_tex_func" so it

Re: [Mesa-dev] [PATCH] gallium/radeon: nuke the final pre LLVN 3.6 codepath

"LLVN" typo in the subject line. Apart from that, Reviewed-by: Nicolai Hähnle On 21.04.2016 08:37, Emil Velikov wrote: Missed with commit 100796c15c3 "gallium/radeon: drop support for LLVM 3.5" Cc: Marek Olšák Cc: Nicolai Hähnle

Re: [Mesa-dev] [PATCH v2 2/2] radeonsi: Enable loading into CE RAM.

For the series: Reviewed-by: Nicolai Hähnle On 21.04.2016 05:12, Bas Nieuwenhuizen wrote: We need to enable a bit in the CONTEXT_CONTROL packet for the loads to work. v2: Style issues. Signed-off-by: Bas Nieuwenhuizen ---

Re: [Mesa-dev] [PATCH 01/25] genxml: ship all the files needed in the tarball

On Thu, Apr 21, 2016 at 6:16 AM, Emil Velikov wrote: > From: Emil Velikov > > Signed-off-by: Emil Velikov > --- > src/intel/genxml/Makefile.am | 11 +++ > 1 file changed, 11 insertions(+) > > diff --git

Re: [Mesa-dev] [PATCH 02/25] anv: remove unused dev_icd.json

On Thu, Apr 21, 2016 at 8:56 AM, Emil Velikov wrote: > On 21 April 2016 at 15:56, Jason Ekstrand wrote: > > > > On Apr 21, 2016 7:52 AM, "Erik Faye-Lund" wrote: > >> > >> On Thu, Apr 21, 2016 at 3:16 PM, Emil Velikov

Re: [Mesa-dev] [PATCH 07/25] anv: add missing link against the math library

On Thu, Apr 21, 2016 at 6:16 AM, Emil Velikov wrote: > From: Emil Velikov > > Signed-off-by: Emil Velikov > --- > src/intel/vulkan/Makefile.am | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff

Re: [Mesa-dev] [PATCH 04/25] anv: tweak the LDFLAGS

On Thu, Apr 21, 2016 at 6:16 AM, Emil Velikov wrote: > From: Emil Velikov > > Copy/pasta from the rest of mesa, but namely. > Mmmm... pasta... Sounds tasty but probably not what you meant. > - The module should be shared only. > - We

Re: [Mesa-dev] [PATCH 05/25] anv: remove custom rule to install the intel_icd.json

On Thu, Apr 21, 2016 at 6:16 AM, Emil Velikov wrote: > From: Emil Velikov > > Autoconf already does the exact same thing as the manually written rule. > > Signed-off-by: Emil Velikov > --- > > IMHO we can/should

Re: [Mesa-dev] [PATCH] include/GL: fix the interop header for a --disable-glx build

On 21 April 2016 at 20:10, Chuck Atkins wrote: >>> >> Drop the includes altogether, and forward declare the needed symbols. >> >> >> But then you end up with forward declarations of symbols that may not even >> exist. > > > I guess you'll already have prototypes that

[Mesa-dev] [Bug 94955] Uninitialized variables leads to random segfaults (valgrind log, apitrace attached)

https://bugs.freedesktop.org/show_bug.cgi?id=94955 --- Comment #12 from Roland Scheidegger --- (In reply to Bruce Cherniak from comment #10) > Does the gallium llvm sampler fully support float textures? Both llvmpipe > and OpenSWR generate the same sampler and fail

Re: [Mesa-dev] [PATCH] i965: Fix clear code for ignoring colormask for XRGB formats on Gen9+.

On Thursday, April 21, 2016 10:00:57 AM PDT Iago Toral wrote: > On Wed, 2016-04-20 at 18:38 -0700, Kenneth Graunke wrote: > > In commit cda886a4851ab767fba40e8474d6fa8190347e4f, Neil made us stop > > advertising RGBX formats on Gen9+, as the hardware apparently no longer > > has working fast clear

[Mesa-dev] [PATCH v2] radeonsi: Lock a mutex when checking scratch relocations.

We can use shaders from multiple contexts, and they were not otherwise locked yet. v2: Fix the shader = NULL case. Signed-off-by: Bas Nieuwenhuizen --- src/gallium/drivers/radeonsi/si_compute.c | 20

[Mesa-dev] [PATCH] vid_enc: Fix resource leak on OMX_ErrorNone

From: Robert Foss Avoid leaking buffer allocated for task if an error has occured. Coverity id: 1213929 Signed-off-by: Robert Foss --- src/gallium/state_trackers/omx/vid_enc.c | 1 + 1 file changed, 1 insertion(+) diff --git

Re: [Mesa-dev] [PATCH 00/25] Vulkan (build et al.) fixes

I had a few comments here and there. In general Patches 2-3 should be dropped or replaced with a patch that adds a little documentation. 1, 4 - 16 are Acked-by: Jason Ekstrand I have no real opinion on 17-19 but they look fine as far as I'm concerned I'm not a fan of

Re: [Mesa-dev] [PATCH 20/25] anv: minor tweak in the generation script

On Thu, Apr 21, 2016 at 6:16 AM, Emil Velikov wrote: > From: Emil Velikov > > Rather than parsing through the same files (public headers) twice, tweak > the python script to create both files at the same time. > Yes, but it takes almost

Re: [Mesa-dev] [PATCH 24/25] anv: tweak libvulkan_intel.so link libraries

On Thu, Apr 21, 2016 at 6:16 AM, Emil Velikov wrote: > From: Emil Velikov > > I.e do not use -lfoo directly. > > Signed-off-by: Emil Velikov > --- > src/intel/vulkan/Makefile.am | 4 +++- > 1 file changed, 3

[Mesa-dev] [Bug 94955] Uninitialized variables leads to random segfaults (valgrind log, apitrace attached)

https://bugs.freedesktop.org/show_bug.cgi?id=94955 --- Comment #13 from Roland Scheidegger --- Actually it is crashing in sampling, but it's a different sampler. Looks like a TXF, there _might_ be a problem with mip level calculation as it hits a seldomly used path... --

[Mesa-dev] [PATCH] spirv_to_nir: Avoid out of bounds access to nir src array.

From: Robert Foss Avoid out of bounds access of the array 'src'. 'src' is passed along: nir_eval_const_opcode() evaluate_bitfield_insert() In evaluate_bitfield_insert() an access to src[3] is made if bit_size==32 wich it always will be due to the

Re: [Mesa-dev] [PATCH 03/10] radeonsi: generalize si_set_constant_buffer

On Thu, Apr 21, 2016 at 8:11 PM, Nicolai Hähnle wrote: > On 20.04.2016 10:47, Marek Olšák wrote: >> >> From: Marek Olšák >> >> this will be used in the next commit >> --- >> src/gallium/drivers/radeonsi/si_descriptors.c | 27 >>

[Mesa-dev] [Bug 94955] Uninitialized variables leads to random segfaults (valgrind log, apitrace attached)

https://bugs.freedesktop.org/show_bug.cgi?id=94955 --- Comment #18 from Roland Scheidegger --- (In reply to Bruce Cherniak from comment #16) > BTW, for my edification, what indicates it might be a bug in the mip level > calculation? That was just a guess as it hit the

Re: [Mesa-dev] [PATCH 24/25] anv: tweak libvulkan_intel.so link libraries

On 21 April 2016 at 23:05, Jason Ekstrand wrote: > On Thu, Apr 21, 2016 at 6:16 AM, Emil Velikov > wrote: >> >> From: Emil Velikov >> >> I.e do not use -lfoo directly. >> >> Signed-off-by: Emil Velikov

[Mesa-dev] [PATCH v2 10/11] swr: [rasterizer core] CompleteDrawContext changes for gcc

Add explicit inline and non-inline versions of CompleteDrawContext to make gcc happy. --- src/gallium/drivers/swr/rasterizer/core/threads.cpp | 15 +++ 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/src/gallium/drivers/swr/rasterizer/core/threads.cpp

[Mesa-dev] [PATCH v2 02/11] swr: [rasterizer fetch] Add support for fetching non-uniform component formats

For example, R10G10B10A2_UNORM. --- .../drivers/swr/rasterizer/jitter/fetch_jit.cpp| 190 - 1 file changed, 189 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/swr/rasterizer/jitter/fetch_jit.cpp b/src/gallium/drivers/swr/rasterizer/jitter/fetch_jit.cpp

Re: [Mesa-dev] [PATCH 24/25] anv: tweak libvulkan_intel.so link libraries

On Thu, Apr 21, 2016 at 5:04 PM, Emil Velikov wrote: > On 21 April 2016 at 23:05, Jason Ekstrand wrote: > > On Thu, Apr 21, 2016 at 6:16 AM, Emil Velikov > > wrote: > >> > >> From: Emil Velikov

[Mesa-dev] [PATCH v2 08/11] swr: [rasterizer scripts] Knob scripts tweaks

--- .../drivers/swr/rasterizer/scripts/knob_defs.py| 4 +++- .../rasterizer/scripts/templates/knobs.template| 25 +- 2 files changed, 27 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/swr/rasterizer/scripts/knob_defs.py

[Mesa-dev] [PATCH v2 09/11] swr: [rasterizer] Small cleanups

--- .../drivers/swr/rasterizer/core/frontend.cpp | 3 ++- src/gallium/drivers/swr/rasterizer/core/frontend.h | 2 +- src/gallium/drivers/swr/rasterizer/core/utils.cpp | 31 +++--- src/gallium/drivers/swr/rasterizer/core/utils.h| 3 ++-

[Mesa-dev] [Bug 94955] Uninitialized variables leads to random segfaults (valgrind log, apitrace attached)

https://bugs.freedesktop.org/show_bug.cgi?id=94955 --- Comment #15 from Bruce Cherniak --- Created attachment 123137 --> https://bugs.freedesktop.org/attachment.cgi?id=123137=edit partial gallium trace Attaching the gallium trace (at least up until the crash). I'm

[Mesa-dev] [PATCH v2 11/11] swr: [rasterizer memory] Constify load tiles

--- src/gallium/drivers/swr/rasterizer/memory/LoadTile.cpp | 12 +++- src/gallium/drivers/swr/swr_memory.h | 2 +- 2 files changed, 8 insertions(+), 6 deletions(-) diff --git a/src/gallium/drivers/swr/rasterizer/memory/LoadTile.cpp

Re: [Mesa-dev] [PATCH] egl: android: add dma-buf fd support

On 20 April 2016 at 03:52, Rob Herring wrote: > On Tue, Apr 19, 2016 at 8:03 PM, Emil Velikov > wrote: >> Hi Rob, >> >> Please bear in mind that there's a fair bit of comments, but before >> all don't mix refactoring and new code. Please ? > > Okay. >

[Mesa-dev] [Bug 94955] Uninitialized variables leads to random segfaults (valgrind log, apitrace attached)

https://bugs.freedesktop.org/show_bug.cgi?id=94955 --- Comment #14 from Bruce Cherniak --- Created attachment 123136 --> https://bugs.freedesktop.org/attachment.cgi?id=123136=edit gallivm_debug shaders (inline sampler) I got distracted trying to get tex func to dump

Re: [Mesa-dev] [PATCH 20/25] anv: minor tweak in the generation script

On 21 April 2016 at 22:50, Jason Ekstrand wrote: > On Thu, Apr 21, 2016 at 6:16 AM, Emil Velikov > wrote: >> >> From: Emil Velikov >> >> Rather than parsing through the same files (public headers) twice, tweak >> the

  1   2   3   >