[Mesa-dev] [PATCH] st/mesa: fix type confusion with reladdrs

2016-06-08 Thread Ilia Mirkin
The reality is that this doesn't matter, because we manually emit the ARL to the sampler reladdr, and those arguments don't get an extra load later, so it's effectively just a boolean. However having the types be wrong is confusing and could trigger very odd bugs should usage change down the line.

[Mesa-dev] [Bug 96408] [PERF] SSO: dirty all stages when only one is updated. Trigger extra validations.

2016-06-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=96408 Ilia Mirkin changed: What|Removed |Added CC|imir...@alum.mit.edu| -- You are

[Mesa-dev] [PATCH] nvc0: do not follow the push path for indexed draws

2016-06-08 Thread Samuel Pitoiset
This fixes a lot of flickering in The Talos Principle on Fermi+ (tested on both GF119 and GK106). My guess is that some indices and/or some vertex attributes are incorrectly set when emitting data directly into the command stream rather than uploading a user VBO. The NV50 driver also doesn't use

Re: [Mesa-dev] [PATCH 3/3] radeonsi: improve the computation and comment of scratch_waves

2016-06-08 Thread Nicolai Hähnle
For the series: Reviewed-by: Nicolai Hähnle On 08.06.2016 17:36, Marek Olšák wrote: From: Marek Olšák 2% isn't much. If you think the number should be decreased, please speak up. --- src/gallium/drivers/radeonsi/si_pipe.c | 22

[Mesa-dev] [PATCH 3/3] radeonsi: improve the computation and comment of scratch_waves

2016-06-08 Thread Marek Olšák
From: Marek Olšák 2% isn't much. If you think the number should be decreased, please speak up. --- src/gallium/drivers/radeonsi/si_pipe.c | 22 ++ 1 file changed, 18 insertions(+), 4 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_pipe.c

[Mesa-dev] [PATCH 1/3] radeonsi: enable scratch coalescing

2016-06-08 Thread Marek Olšák
From: Marek Olšák Latest LLVM git is required. --- src/gallium/drivers/radeonsi/si_shader.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_shader.c b/src/gallium/drivers/radeonsi/si_shader.c index

[Mesa-dev] [PATCH 2/3] radeonsi: print the number of spilled VGPRs

2016-06-08 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/radeonsi/si_shader.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_shader.c b/src/gallium/drivers/radeonsi/si_shader.c index 512db42..e563aec 100644 ---

Re: [Mesa-dev] [PATCH v6] swr: implement clipPlanes/clipVertex/clipDistance/cullDistance

2016-06-08 Thread Cherniak, Bruce
Reviewed-by: Bruce Cherniak > On Jun 8, 2016, at 9:59 AM, Tim Rowley wrote: > > v2: only load the clip vertex once > > v3: fix clip enable logic, add cullDistance > > v4: remove duplicate fields in vs jit key, fix test of clip fixup

Re: [Mesa-dev] [PATCH v2] st/mesa: directly compute level=0 texture size in st_finalize_texture

2016-06-08 Thread Brian Paul
On 06/07/2016 05:00 PM, Nicolai Hähnle wrote: From: Nicolai Hähnle The width0/height0/depth0 on stObj may not have been set at this point. Observed in a trace that set up levels 2..9 of a 2d texture, and set the base level to 2, with height 1. This made the guess logic

Re: [Mesa-dev] Mesa (master): st/mesa: use buffer usage history to set dirty flags for revalidation

2016-06-08 Thread Brian Paul
Ilia, this patch causes a regression in the piglit arb_uniform_buffer_object-rendering-dsa test with llvmpipe (at least). I haven't debugged it at all. -Brian On 06/07/2016 08:29 PM, Ilia Mirkin wrote: Module: Mesa Branch: master Commit: 6e6fd911da8a1d9cd62fe0a8a4cc0fb7bdccfe02 URL:

Re: [Mesa-dev] [PATCH] st/mesa: fix type confusion with reladdrs

2016-06-08 Thread Brian Paul
On 06/08/2016 09:34 AM, Ilia Mirkin wrote: The reality is that this doesn't matter, because we manually emit the ARL to the sampler reladdr, and those arguments don't get an extra load later, so it's effectively just a boolean. However having the types be wrong is confusing and could trigger

Re: [Mesa-dev] [PATCH] automake: get in-tree `make distclean' working again.

2016-06-08 Thread Eric Engestrom
On Wed, Jun 08, 2016 at 03:44:39PM +0100, Emil Velikov wrote: > From: Emil Velikov > > With earlier commit we've handled the `make distclean' out of tree > build, yet we failed to attribute that for in-tree builds the test > condition will return 1. Thus effectively

Re: [Mesa-dev] [PATCH] automake: get in-tree `make distclean' working again.

2016-06-08 Thread Andy Furniss
Emil Velikov wrote: From: Emil Velikov With earlier commit we've handled the `make distclean' out of tree build, yet we failed to attribute that for in-tree builds the test condition will return 1. Thus effectively the target will be considered as "failed". Fixes:

Re: [Mesa-dev] [Mesa-stable] [PATCH] st/mesa: use first image's dimensions when finalizing texture

2016-06-08 Thread Nicolai Hähnle
For the piglit test: Reviewed-by: Nicolai Hähnle On 06.06.2016 18:52, Brian Paul wrote: On 06/06/2016 10:05 AM, Ilia Mirkin wrote: On Mon, Jun 6, 2016 at 11:37 AM, Brian Paul wrote: On 06/05/2016 12:24 AM, Ilia Mirkin wrote: In the case where

[Mesa-dev] [PATCH v6] swr: implement clipPlanes/clipVertex/clipDistance/cullDistance

2016-06-08 Thread Tim Rowley
v2: only load the clip vertex once v3: fix clip enable logic, add cullDistance v4: remove duplicate fields in vs jit key, fix test of clip fixup needed v5: fix clipdistance linkage for slot!=0,4 v6: support clip+cull; passes most piglit clip (failures understood) --- docs/GL3.txt

Re: [Mesa-dev] [PATCH 00/12] RadeonSI: DCC mipmapping support & improvements

2016-06-08 Thread Marek Olšák
On Wed, Jun 8, 2016 at 2:34 PM, ⚛ <0xe2.0x9a.0...@gmail.com> wrote: > Hello > > Mesa 12.1.0-devel (git-8c3ecde) has rendering issues when running > "glxgears -samples N" with N >= 1 on R9 390. It was running ok > yesterday/previously. I reverted the problematic commit. Marek

Re: [Mesa-dev] [PATCH] mesa: expose ARB_compute_shader with compat profile

2016-06-08 Thread Samuel Pitoiset
On 06/08/2016 01:45 AM, Ian Romanick wrote: On 06/07/2016 04:28 PM, Nanley Chery wrote: On Wed, May 25, 2016 at 12:52:38PM -0700, Matt Turner wrote: On Wed, May 25, 2016 at 12:17 PM, Samuel Pitoiset wrote: This fixes use of compute shaders with some NVIDIA GL 4.3

[Mesa-dev] [PATCH] nv50: add missing draw_calls_indexed driver stat

2016-06-08 Thread Samuel Pitoiset
Spotted when glancing at the VBO push code. Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/nouveau/nv50/nv50_vbo.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/drivers/nouveau/nv50/nv50_vbo.c b/src/gallium/drivers/nouveau/nv50/nv50_vbo.c

Re: [Mesa-dev] [PATCH 2/5] glsl: Optionally lower TES gl_PatchVerticesIn to a uniform.

2016-06-08 Thread Alejandro Piñeiro
On 02/06/16 23:09, Kenneth Graunke wrote: > i965 has no special hardware for this, so we need to pass this value in > as a uniform (unless the TES is linked against a TCS, in which case the > linker can just replace this with a constant). > > Signed-off-by: Kenneth Graunke

Re: [Mesa-dev] [PATCH 4/5] glsl: Optionally lower TCS gl_PatchVerticesIn to a uniform.

2016-06-08 Thread Alejandro Piñeiro
On 02/06/16 23:09, Kenneth Graunke wrote: > i965 has no special hardware for this, so the best way to implement > this is to pass it in via a uniform. Is this comment accurate? On the next patch you implement the i965 bits, and you only do the lowering on gen8+, mentioning that you would like to

Re: [Mesa-dev] [PATCH 3/5] i965: Use a uniform for gl_PatchVerticesIn in the TES.

2016-06-08 Thread Alejandro Piñeiro
On 02/06/16 23:09, Kenneth Graunke wrote: > Fixes GL44-CTS.tessellation_shader.single.max_patch_vertices, > which uses gl_PatchVerticesIn in the TES, but doesn't link against > a TCS (which would allow the linker to lower it to a constant). Not sure if using different CTS releases but in my case

Re: [Mesa-dev] [PATCH] mesa: expose ARB_compute_shader with compat profile

2016-06-08 Thread Nanley Chery
On Tue, Jun 07, 2016 at 04:45:39PM -0700, Ian Romanick wrote: > On 06/07/2016 04:28 PM, Nanley Chery wrote: > > On Wed, May 25, 2016 at 12:52:38PM -0700, Matt Turner wrote: > >> On Wed, May 25, 2016 at 12:17 PM, Samuel Pitoiset > >> wrote: > >>> This fixes use of

Re: [Mesa-dev] [PATCH 3/5] i965: Use a uniform for gl_PatchVerticesIn in the TES.

2016-06-08 Thread Alejandro Piñeiro
On 08/06/16 19:45, Alejandro Piñeiro wrote: > On 02/06/16 23:09, Kenneth Graunke wrote: >> Fixes GL44-CTS.tessellation_shader.single.max_patch_vertices, >> which uses gl_PatchVerticesIn in the TES, but doesn't link against >> a TCS (which would allow the linker to lower it to a constant). > Not

Re: [Mesa-dev] [PATCH] mesa: Add a helper function for shared code in get_tex_rgba_{un}compressed

2016-06-08 Thread Anuj Phogat
On Mon, Dec 28, 2015 at 10:46 AM, Anuj Phogat wrote: > Signed-off-by: Anuj Phogat > --- > src/mesa/main/texgetimage.c | 83 > + > 1 file changed, 38 insertions(+), 45 deletions(-) > > diff --git

[Mesa-dev] [PATCH] i965/gen9: Don't change halign and valign to fit in fast copy blit

2016-06-08 Thread Anuj Phogat
An update in graphics specs has deleted the halign and valign fields from XY_FAST_COPY_BLT command. See mesa commit 97f0f91. Cc: Ben Widawsky Signed-off-by: Anuj Phogat --- src/mesa/drivers/dri/i965/brw_tex_layout.c | 6 ++ 1 file changed, 2

Re: [Mesa-dev] Mesa (master): st/mesa: use buffer usage history to set dirty flags for revalidation

2016-06-08 Thread Ilia Mirkin
Hm, that's odd. I guess the buffer usage doesn't get set properly? I won't be able to look at this until tonight at the earliest, feel free to revert the change in the meanwhile. -ilia On Wed, Jun 8, 2016 at 1:25 PM, Brian Paul wrote: > Ilia, this patch causes a regression

Re: [Mesa-dev] Mesa (master): st/mesa: use buffer usage history to set dirty flags for revalidation

2016-06-08 Thread Ilia Mirkin
Glancing at the code (I don't even have a piglit checkout here): static void set_ubo_binding(struct gl_context *ctx, ...) ... /* If this is a real buffer object, mark it has having been used * at some point as a UBO. */ if (size >= 0) bufObj->UsageHistory |=

[Mesa-dev] [PATCH 5/7] mesa: use new 64-bit checks instead of explicit double checks.

2016-06-08 Thread Dave Airlie
From: Dave Airlie This just moves to the new interfaces in advance of int64. Signed-off-by: Dave Airlie --- src/mesa/main/uniform_query.cpp | 8 src/mesa/program/ir_to_mesa.cpp | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff

[Mesa-dev] [PATCH 1/7] compiler/types: add 64-bitness queries.

2016-06-08 Thread Dave Airlie
From: Dave Airlie This adds an inline and type query for if a type is 64-bit. Fow now this is equivalent to double, but int64 will change this. Signed-off-by: Dave Airlie --- src/compiler/glsl_types.h | 13 + 1 file changed, 13

[Mesa-dev] [PATCH 6/7] st/glsl_to_tgsi: use enum glsl_base_type instead of unsigned

2016-06-08 Thread Dave Airlie
From: Dave Airlie This is just some better type safety that I noticed while working on 64-bit integer support. Signed-off-by: Dave Airlie --- src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 24 1 file changed, 12 insertions(+), 12

[Mesa-dev] [PATCH 7/7] st/glsl_to_tgsi: move to checking 64-bitness instead of double

2016-06-08 Thread Dave Airlie
From: Dave Airlie This uses the new types interfaces to check for 64-bit types, as futureproofing against int64 support. Signed-off-by: Dave Airlie --- src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 30 ++ 1 file changed, 14

[Mesa-dev] prep work for 64-bit integer support

2016-06-08 Thread Dave Airlie
While writing ARB_gpu_shader_int64 I realised I needed to change a lot of existing checks for doubles to 64bit, so I decided to do that as much in advance as possible. This adds a macro + interface to check if a type is 64-bit, which currently is only true for doubles, it then uses the new API in

[Mesa-dev] [PATCH 2/7] compiler: use 64bit check for sizing instead of double check.

2016-06-08 Thread Dave Airlie
From: Dave Airlie This just moves code to the new check in advance of int64 support. Signed-off-by: Dave Airlie --- src/compiler/glsl_types.cpp | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/compiler/glsl_types.cpp

[Mesa-dev] [PATCH 3/7] glsl: use new interfaces for 64-bit checks.

2016-06-08 Thread Dave Airlie
From: Dave Airlie This is just prep work for int64 support, changing places where 64-bit matters no doubles. Signed-off-by: Dave Airlie --- src/compiler/glsl/ast_to_hir.cpp| 4 ++-- src/compiler/glsl/link_uniform_initializers.cpp | 2

[Mesa-dev] [PATCH] glsl/types: rename is_dual_slot_double to is_dual_slot_64bit.

2016-06-08 Thread Dave Airlie
From: Dave Airlie In the future int64 support will have the same requirements. Signed-off-by: Dave Airlie --- src/compiler/glsl/ir_set_program_inouts.cpp| 4 ++-- src/compiler/glsl/linker.cpp | 4 ++-- src/compiler/glsl_types.h

Re: [Mesa-dev] [PATCH] mesa: Make TexSubImage check negative dimensions sooner.

2016-06-08 Thread Patrick Baggett
Sorry, didn't CC mesa-dev, trying again... On Wed, Jun 8, 2016 at 4:11 PM, Kenneth Graunke wrote: > Two dEQP tests expect INVALID_VALUE errors for negative width/height > parameters, but get INVALID_OPERATION because they haven't actually > created a destination image.

[Mesa-dev] [PATCH] mesa: Make TexSubImage check negative dimensions sooner.

2016-06-08 Thread Kenneth Graunke
Two dEQP tests expect INVALID_VALUE errors for negative width/height parameters, but get INVALID_OPERATION because they haven't actually created a destination image. This is arguably not a bug in Mesa, as there's no specified ordering of error conditions. However, it's also really easy to make

Re: [Mesa-dev] [PATCH 7/7] st/glsl_to_tgsi: move to checking 64-bitness instead of double

2016-06-08 Thread Ilia Mirkin
Series is Reviewed-by: Ilia Mirkin On Wed, Jun 8, 2016 at 5:15 PM, Dave Airlie wrote: > From: Dave Airlie > > This uses the new types interfaces to check for 64-bit types, > as futureproofing against int64 support. > >

Re: [Mesa-dev] [PATCH] glsl/types: rename is_dual_slot_double to is_dual_slot_64bit.

2016-06-08 Thread Ilia Mirkin
On Wed, Jun 8, 2016 at 5:51 PM, Dave Airlie wrote: > From: Dave Airlie > > In the future int64 support will have the same requirements. > > Signed-off-by: Dave Airlie > --- > src/compiler/glsl/ir_set_program_inouts.cpp| 4 ++-- >

Re: [Mesa-dev] Mesa (master): st/mesa: use buffer usage history to set dirty flags for revalidation

2016-06-08 Thread Fredrik Höglund
On Wednesday 08 June 2016, Ilia Mirkin wrote: > Glancing at the code (I don't even have a piglit checkout here): > > static void > set_ubo_binding(struct gl_context *ctx, ...) > ... >/* If this is a real buffer object, mark it has having been used > * at some point as a UBO. > */ >

Re: [Mesa-dev] [PATCH] isl: Replace bash generator with python generator

2016-06-08 Thread Dylan Baker
[snip] Quoting Jason Ekstrand (2016-06-08 16:20:33) > gen_format_layout.c.mako > > I made this comment in the office today but I think the mako here is simple > enough that we might be better off just putting it all in one file. > I know you're not a fan of separate templates, and if the

[Mesa-dev] [PATCH 23/23] gallivm/llvmpipe: add support for ARB_gpu_shader_int64.

2016-06-08 Thread Dave Airlie
From: Dave Airlie This enables 64-bit integer support in gallivm and llvmpipe. Signed-off-by: Dave Airlie --- src/gallium/auxiliary/gallivm/lp_bld_limits.h | 1 + src/gallium/auxiliary/gallivm/lp_bld_tgsi.c| 8 +-

[Mesa-dev] [PATCH 19/23] gallium/tgsi: add support for 64-bit integer immediates.

2016-06-08 Thread Dave Airlie
From: Dave Airlie This adds support to TGSI for 64-bit integer immediates. Signed-off-by: Dave Airlie --- src/gallium/auxiliary/tgsi/tgsi_dump.c | 14 ++ src/gallium/auxiliary/tgsi/tgsi_exec.c | 244 -

[Mesa-dev] [PATCH 18/23] gallium: add opcode and types for 64-bit integers.

2016-06-08 Thread Dave Airlie
From: Dave Airlie This just adds the basic support for 64-bit opcodes, and the new types. Signed-off-by: Dave Airlie --- src/gallium/auxiliary/tgsi/tgsi_info.c | 54 ++ src/gallium/auxiliary/tgsi/tgsi_info.h | 4 ++-

Re: [Mesa-dev] [PATCH] mesa: Add a helper function for shared code in get_tex_rgba_{un}compressed

2016-06-08 Thread Anuj Phogat
On Wed, Jun 8, 2016 at 3:34 PM, Brian Paul wrote: > On 06/08/2016 12:15 PM, Anuj Phogat wrote: >> >> On Mon, Dec 28, 2015 at 10:46 AM, Anuj Phogat >> wrote: >>> >>> Signed-off-by: Anuj Phogat >>> --- >>>

Re: [Mesa-dev] [PATCH 2/2] clover: fix getting struct args api size

2016-06-08 Thread Serge Martin
On Thursday 09 June 2016 00:47:27 Serge Martin wrote: > This fix getting the size of a struct arg. vec3 types still work ok. > Only buit-in args need to have power of two alignment, getTypeAllocSize > reports the correct size. M. I forgot to put V2 and to fix the commit message

Re: [Mesa-dev] [PATCH] radeonsi: Reinitialize all descriptors in CE preamble.

2016-06-08 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Mon, Jun 6, 2016 at 10:49 PM, Bas Nieuwenhuizen wrote: > This fixes a problem with the CE preamble and restoring only stuff in the > preamble when needed. > > To illustrate suppose we have two graphics IB's 1 and

[Mesa-dev] [PATCH 06/23] glsl/ast/ir: add 64-bit integer constant support

2016-06-08 Thread Dave Airlie
From: Dave Airlie This adds support for 64-bit integer constants to the parser, ast and ir. Signed-off-by: Dave Airlie --- src/compiler/glsl/ast.h | 4 src/compiler/glsl/ast_to_hir.cpp | 14 ++ src/compiler/glsl/glsl_lexer.ll

[Mesa-dev] [PATCH 12/23] glsl/ir_builder: add support for some 64-bit bitcasts.

2016-06-08 Thread Dave Airlie
From: Dave Airlie We need builder support to implement some of the builtins. Signed-off-by: Dave Airlie --- src/compiler/glsl/ir_builder.cpp | 24 src/compiler/glsl/ir_builder.h | 6 ++ 2 files changed, 30 insertions(+)

[Mesa-dev] [PATCH 07/23] glsl/varyings: add 64-bit integer support.

2016-06-08 Thread Dave Airlie
From: Dave Airlie This adds 64-bit ints to the link_varyings 64-bit support. Signed-off-by: Dave Airlie --- src/compiler/glsl/link_varyings.h | 8 1 file changed, 8 insertions(+) diff --git a/src/compiler/glsl/link_varyings.h

[Mesa-dev] [PATCH 22/23] tgsi/softpipe: enable ARB_gpu_shader_int64 support.

2016-06-08 Thread Dave Airlie
From: Dave Airlie This adds all the opcodes to tgsi_exec for softpipe to use. It also enables the cap. Signed-off-by: Dave Airlie --- src/gallium/auxiliary/tgsi/tgsi_exec.c | 104 + src/gallium/auxiliary/tgsi/tgsi_exec.h

[Mesa-dev] [PATCH 14/23] glsl/ast: add 64-bit integer support in some places.

2016-06-08 Thread Dave Airlie
From: Dave Airlie Just add support in two more places in ast parsing. Signed-off-by: Dave Airlie --- src/compiler/glsl/ast_to_hir.cpp | 5 + 1 file changed, 5 insertions(+) diff --git a/src/compiler/glsl/ast_to_hir.cpp

[Mesa-dev] [PATCH 17/23] gallium: add integer 64 capability.

2016-06-08 Thread Dave Airlie
From: Dave Airlie TODO: go back and fill this out to avoid warnings. Signed-off-by: Dave Airlie --- src/gallium/include/pipe/p_defines.h | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/include/pipe/p_defines.h

[Mesa-dev] [PATCH 13/23] glsl: add 64-bit integer support to some operations.

2016-06-08 Thread Dave Airlie
From: Dave Airlie This adds 64-bit integer support to some AST and IR operations where it is needed. Signed-off-by: Dave Airlie --- src/compiler/glsl/ast_to_hir.cpp | 12 ++-- src/compiler/glsl/ir_validate.cpp | 4 ++-- 2 files changed, 8

[Mesa-dev] [PATCH 08/23] glsl: add 64-bit integer support to uniform initialiser code

2016-06-08 Thread Dave Airlie
From: Dave Airlie Just add support to the double case, same code should work. Signed-off-by: Dave Airlie --- src/compiler/glsl/link_uniform_initializers.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

Re: [Mesa-dev] [PATCH] mesa: Add a helper function for shared code in get_tex_rgba_{un}compressed

2016-06-08 Thread Brian Paul
On 06/08/2016 12:15 PM, Anuj Phogat wrote: On Mon, Dec 28, 2015 at 10:46 AM, Anuj Phogat wrote: Signed-off-by: Anuj Phogat --- src/mesa/main/texgetimage.c | 83 + 1 file changed, 38 insertions(+), 45

[Mesa-dev] [PATCH 2/2] clover: fix getting struct args api size

2016-06-08 Thread Serge Martin
This fix getting the size of a struct arg. vec3 types still work ok. Only buit-in args need to have power of two alignment, getTypeAllocSize reports the correct size. --- src/gallium/state_trackers/clover/llvm/invocation.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

Re: [Mesa-dev] [PATCH] isl: Replace bash generator with python generator

2016-06-08 Thread Jason Ekstrand
On Jun 7, 2016 5:32 PM, "Dylan Baker" wrote: > > This replaces the current bash generator with a python based generator > using mako. It's quite fast and works with both python 2.7 and python > 3.5, and should work with 3.3+ and maybe even 3.2. > > It produces an almost

[Mesa-dev] [PATCH 20/23] st/glsl_to_tgsi: add support for 64-bit integers.

2016-06-08 Thread Dave Airlie
From: Dave Airlie This is incomplete in the conversions area. Signed-off-by: Dave Airlie --- src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 105 - 1 file changed, 87 insertions(+), 18 deletions(-) diff --git

[Mesa-dev] [PATCH 16/23] glsl: add 64-bit integer functions.

2016-06-08 Thread Dave Airlie
From: Dave Airlie These are all the allowed 64-bit functions from ARB_gpu_shader_int64 spec. Signed-off-by: Dave Airlie --- src/compiler/glsl/builtin_functions.cpp | 173 +++- 1 file changed, 170 insertions(+), 3 deletions(-)

[Mesa-dev] [PATCH 05/23] mesa: add support for 64-bit integer uniforms.

2016-06-08 Thread Dave Airlie
From: Dave Airlie This hooks up the API to the internals for 64-bit integer uniforms. Signed-off-by: Dave Airlie --- src/mesa/main/uniform_query.cpp | 60 +- src/mesa/main/uniforms.c| 170 +++- 2

[Mesa-dev] [PATCH 10/23] glsl: add 64-bit integer support for constant expressions

2016-06-08 Thread Dave Airlie
From: Dave Airlie This just adds the new operations and add 64-bit integer support to all the existing cases where it is needed. Signed-off-by: Dave Airlie --- src/compiler/glsl/ir_constant_expression.cpp | 324 +++ 1 file

[Mesa-dev] [PATCH 21/23] st/mesa: add support for enabling ARB_gpu_shader_int64.

2016-06-08 Thread Dave Airlie
From: Dave Airlie Signed-off-by: Dave Airlie --- src/mesa/state_tracker/st_extensions.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/src/mesa/state_tracker/st_extensions.c b/src/mesa/state_tracker/st_extensions.c index 13b0acc..b94a8cb

[Mesa-dev] [PATCH 02/23] mesa: add ARB_gpu_shader_int64 extension bits

2016-06-08 Thread Dave Airlie
From: Dave Airlie This just adds the usual boilerplate in mesa core. Signed-off-by: Dave Airlie --- src/mesa/main/extensions_table.h | 1 + src/mesa/main/mtypes.h | 1 + 2 files changed, 2 insertions(+) diff --git

[Mesa-dev] [PATCH 04/23] glsl: add basic arb_gpu_shader_int64 types

2016-06-08 Thread Dave Airlie
From: Dave Airlie This adds the builtins and the lexer support. To avoid too many warnings, it adds basic support to the type in a few other places in mesa, mostly in the trivial places. It also adds a query to be used later for if a type is an integer 32 or 64.

[Mesa-dev] [PATCH 15/23] glsl/varying_packing: add 64-bit integer support

2016-06-08 Thread Dave Airlie
From: Dave Airlie As for the double code, but using the 64-bit integer conversions. Signed-off-by: Dave Airlie --- src/compiler/glsl/lower_packed_varyings.cpp | 62 + 1 file changed, 62 insertions(+) diff --git

[Mesa-dev] [PATCH 11/23] glsl/ast: add 64-bit integer support to conversion functions

2016-06-08 Thread Dave Airlie
From: Dave Airlie This adds support to call the new operations on conversions. Signed-off-by: Dave Airlie --- src/compiler/glsl/ast_function.cpp | 75 ++ src/compiler/glsl/ast_to_hir.cpp | 20 ++ 2 files

[Mesa-dev] [PATCH 09/23] glsl/ir: add support for 64-bit integer conversions.

2016-06-08 Thread Dave Airlie
From: Dave Airlie This adds all the conversions in the world, I'm not 100% sure of all of these are needed, but add all of them and we can cut them down later. Signed-off-by: Dave Airlie --- src/compiler/glsl/ir.cpp | 82

[Mesa-dev] [PATCH 01/23] mapi: add support for ARB_gpu_shader_int64.

2016-06-08 Thread Dave Airlie
From: Dave Airlie Just add the boilerplate xml code. Signed-off-by: Dave Airlie --- src/mapi/glapi/gen/ARB_gpu_shader_int64.xml | 262 src/mapi/glapi/gen/Makefile.am | 1 + src/mapi/glapi/gen/gl_API.xml

[Mesa-dev] [rfc] ARB_gpu_shader_int64 support (softpipe/llvmpipe)

2016-06-08 Thread Dave Airlie
I started this quite a while back, and decided to spend some time on it again, since it's the basis for a bunch of the newer GL extensions. So this is my first pass at it, it's fairly complete, but it definitely is missing some pieces before it's finished. The patchset add core mesa, gallium,

[Mesa-dev] [PATCH 03/23] glsl: add arb_gpu_shader_int64 boilerplate.

2016-06-08 Thread Dave Airlie
From: Dave Airlie This just adds the basic boilerplate support. Signed-off-by: Dave Airlie --- src/compiler/glsl/glcpp/glcpp-parse.y| 3 +++ src/compiler/glsl/glsl_parser_extras.cpp | 1 + src/compiler/glsl/glsl_parser_extras.h | 7 +++ 3

Re: [Mesa-dev] [PATCH v2] st/va: ensure linear memory for dmabuf

2016-06-08 Thread Christian König
Am 08.06.2016 um 14:20 schrieb Julien Isorce: On 8 June 2016 at 09:16, Christian König > wrote: Am 02.06.2016 um 16:00 schrieb Julien Isorce: In order to do zero-copy between two different devices the memory

[Mesa-dev] in tree make distclean failing since mesa: automake: distclean git_sha1.h when building OOT

2016-06-08 Thread Andy Furniss
In tree build make distclean is failing for me since - b7f7ec78435771ab02f7d9a61bb1d4a11df720b8 is the first bad commit commit b7f7ec78435771ab02f7d9a61bb1d4a11df720b8 Author: Emil Velikov Date: Mon Jun 6 19:39:40 2016 +0100 mesa: automake: distclean

Re: [Mesa-dev] [PATCH v2] st/va: ensure linear memory for dmabuf

2016-06-08 Thread Christian König
Am 02.06.2016 um 16:00 schrieb Julien Isorce: In order to do zero-copy between two different devices the memory should not be tiled. This is currently no way to set pipe_resource template's flag from pipe_video_buffer template. So disabled_tiling is added. Choosed "disable" prefix so that

Re: [Mesa-dev] [PATCH] st/va: it is valid to release the VABuffer of an exported resource

2016-06-08 Thread Christian König
Am 02.06.2016 um 16:03 schrieb Julien Isorce: Signed-off-by: Julien Isorce Actually I'm not sure if that is correct. If you release the VABuffer of an exported resource you won't be able to properly close the handle with vlVaReleaseBufferHandle(). On the other hand

Re: [Mesa-dev] [PATCH] st/va: use proper temp pipe_video_buffer template

2016-06-08 Thread Christian König
Am 02.06.2016 um 16:03 schrieb Julien Isorce: Instead of changing the format on the existing template which makes error handling not nice and confuses coverity. CoverityID: 1337953 Signed-off-by: Julien Isorce Reviewed-by: Christian König

Re: [Mesa-dev] [PATCH v3] vl: implement luma key ring

2016-06-08 Thread Christian König
Am 07.06.2016 um 19:42 schrieb Nayan Deshmukh: Apply the luma key filter to the YCbCr values during the CSC conversion in video buffer shader. The initial values of max and min luma are set to opposite values to disable the filter initially and will be set when enabling it. Add extra parmeters

[Mesa-dev] [Bug 96408] [PERF] SSO: dirty all stages when only one is updated. Trigger extra validations.

2016-06-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=96408 --- Comment #2 from gregory.hain...@gmail.com --- Hum, when a new program is set, use_shader_program is called and the _NEW_PROGRAM flag will be set. use_shader_program() { if (*target != shProg) { /* Program is current, flush

[Mesa-dev] [PATCH v4 1/2] vl: Apply luma key filter before CSC conversion

2016-06-08 Thread Nayan Deshmukh
Apply the luma key filter to the YCbCr values during the CSC conversion in video buffer shader. The initial values of max and min luma are set to opposite values to disable the filter initially and will be set when enabling it. Add extra parmeters min and max luma for the luma

[Mesa-dev] [PATCH v4 2/2] st/vdpau: implement luma keyring

2016-06-08 Thread Nayan Deshmukh
Signed-off-by: Nayan Deshmukh --- src/gallium/state_trackers/vdpau/mixer.c | 45 ++-- src/gallium/state_trackers/vdpau/vdpau_private.h | 6 +++- 2 files changed, 39 insertions(+), 12 deletions(-) diff --git

Re: [Mesa-dev] [PATCH v4 2/2] st/vdpau: implement luma keyring

2016-06-08 Thread Michel Dänzer
AFAIK the term is "luma keying", not "luma keyring". -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast | Mesa and X developer ___ mesa-dev mailing list

[Mesa-dev] [PATCH v4] st/vdpau: implement luma keying

2016-06-08 Thread Nayan Deshmukh
Signed-off-by: Nayan Deshmukh --- src/gallium/state_trackers/vdpau/mixer.c | 45 ++-- src/gallium/state_trackers/vdpau/vdpau_private.h | 6 +++- 2 files changed, 39 insertions(+), 12 deletions(-) diff --git

Re: [Mesa-dev] [PATCH] st/va: it is valid to release the VABuffer of an exported resource

2016-06-08 Thread Julien Isorce
Hi Christian, Thx for the review. pipe_resource_reference(, NULL) will decrement reference counting (p_atomic_dec res->count). But the va surface still has the initial reference since it created that resource. So calling vaDestroyImage on a derived image will call VaDestroyBuffer but the

Re: [Mesa-dev] [PATCH v4 2/2] st/vdpau: implement luma keyring

2016-06-08 Thread Christian König
With the type fixed both patches are Reviewed-by: Christian König If there aren't any more objections I'm going to push the patches now. Regards, Christian. Am 08.06.2016 um 11:28 schrieb Michel Dänzer: AFAIK the term is "luma keying", not "luma keyring".

Re: [Mesa-dev] [PATCH] st/va: it is valid to release the VABuffer of an exported resource

2016-06-08 Thread Christian König
I'm clearly not deep enough into VA-API to judge if that is correct or not, but it sounds sane to me. So feel free to add an Acked-by: Christian König on the patch. Cheers, Christian. Am 08.06.2016 um 13:13 schrieb Julien Isorce: Hi Christian, Thx for the

Re: [Mesa-dev] [PATCH 00/12] RadeonSI: DCC mipmapping support & improvements

2016-06-08 Thread
Hello Mesa 12.1.0-devel (git-8c3ecde) has rendering issues when running "glxgears -samples N" with N >= 1 on R9 390. It was running ok yesterday/previously. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org

Re: [Mesa-dev] [PATCH v2] st/va: ensure linear memory for dmabuf

2016-06-08 Thread Julien Isorce
On 8 June 2016 at 09:16, Christian König wrote: > Am 02.06.2016 um 16:00 schrieb Julien Isorce: > >> In order to do zero-copy between two different devices >> the memory should not be tiled. >> >> This is currently no way to set pipe_resource template's flag >> from

Re: [Mesa-dev] [PATCH v2] glx: fix crash with bad fbconfig

2016-06-08 Thread Jeremy Huddleston Sequoia
> On Jun 7, 2016, at 03:25, Emil Velikov wrote: > > On 31 May 2016 at 10:53, Tapani Pälli wrote: >> From: Daniel Czarnowski >> >> GLX documentation states: >>glXCreateNewContext can generate the following

[Mesa-dev] [PATCH 4/7] glsl/link_varyings: switch to 64bit check instead of double.

2016-06-08 Thread Dave Airlie
From: Dave Airlie This is prep work for int64 support. Signed-off-by: Dave Airlie --- src/compiler/glsl/link_varyings.cpp | 2 +- src/compiler/glsl/link_varyings.h | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git

Re: [Mesa-dev] [PATCH] i965: Emit surface states for extra planes prior to gen8

2016-06-08 Thread Jason Ekstrand
On Jun 8, 2016 9:25 PM, "Kristian Høgsberg" wrote: > > On Wed, Jun 8, 2016 at 9:07 PM, Jason Ekstrand wrote: > > When Kristian implemented GL_TEXTURE_EXTERNAL_OES, he hooked it up for gen8 > > but not for gen7 or earlier. It all works, we just need to

Re: [Mesa-dev] [PATCH v2] st/va: ensure linear memory for dmabuf

2016-06-08 Thread Julien Isorce
To go back to "add a bind flag to struct pipe_video_buffer instead ", the alternative is to bring back the first version of the patch but according to the first review, it was duplication of bind flag between pipe_video_buffer and pipe_resource so it would require quite of big of refactoring

Re: [Mesa-dev] [PATCH v2] st/va: ensure linear memory for dmabuf

2016-06-08 Thread Christian König
Am 08.06.2016 um 15:53 schrieb Julien Isorce: To go back to "add a bind flag to struct pipe_video_buffer instead ", the alternative is to bring back the first version of the patch but according to the first review, it was duplication of bind flag between pipe_video_buffer and pipe_resource so

[Mesa-dev] [PATCH] i965: Emit surface states for extra planes prior to gen8

2016-06-08 Thread Jason Ekstrand
When Kristian implemented GL_TEXTURE_EXTERNAL_OES, he hooked it up for gen8 but not for gen7 or earlier. It all works, we just need to emit the states for the extra planes. Cc: "12.0" Cc: Kristian Høgsberg ---

[Mesa-dev] [PATCH] i965: Emit surface states for extra planes prior to gen8

2016-06-08 Thread Jason Ekstrand
When Kristian implemented GL_TEXTURE_EXTERNAL_OES, he hooked it up for gen8 but not for gen7 or earlier. It all works, we just need to emit the states for the extra planes. Cc: "12.0" Cc: Kristian Høgsberg ---

Re: [Mesa-dev] [PATCH] i965: Emit surface states for extra planes prior to gen8

2016-06-08 Thread Kristian Høgsberg
On Wed, Jun 8, 2016 at 9:07 PM, Jason Ekstrand wrote: > When Kristian implemented GL_TEXTURE_EXTERNAL_OES, he hooked it up for gen8 > but not for gen7 or earlier. It all works, we just need to emit the states > for the extra planes. Ah yes, thanks. Reviewed-by: Kristian

[Mesa-dev] [PATCH] glsl: fix max varyings count for ARB_enhanced_layouts

2016-06-08 Thread Timothy Arceri
Since this extension allows more than one varying to share a single location we can't just count the number of slots a varying takes and add it to the total. Instead we now reuse the reserved varyings bitfield to determine how many slots are reserved for explicit locations instead. ---

[Mesa-dev] [PATCH 1/2] mesa/gallium: Move u_bit_scan{, 64} from gallium to mesa.

2016-06-08 Thread Mathias . Froehlich
From: Mathias Fröhlich The functions are also useful for mesa. Introduce src/util/bitscan.{h,c}. Move ffs function implementations from src/mesa/main/imports.{h,c}. Move bit scan related functions from src/gallium/auxiliary/util/u_math.h. Merge platform handling with

[Mesa-dev] [PATCH 0/2] Move u_bit_scan from gallium to util.

2016-06-08 Thread Mathias . Froehlich
From: Mathias Fröhlich Hi all, I just put the two leading patches to move u_bit_scan from gallium to util. The architecture handling of ffs{,ll} is merged with what is available in the mesa/util directory. It compiles and works here and we should get slightly better

[Mesa-dev] [PATCH 2/2] mesa: Make use of u_bit_scan{,64}.

2016-06-08 Thread Mathias . Froehlich
From: Mathias Fröhlich Signed-off-by: Mathias Fröhlich --- src/mesa/main/arrayobj.c | 6 +++--- src/mesa/main/buffers.c | 4 ++-- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/mesa/main/arrayobj.c

Re: [Mesa-dev] [PATCH 4/5] glsl: Optionally lower TCS gl_PatchVerticesIn to a uniform.

2016-06-08 Thread Kenneth Graunke
On Wednesday, June 8, 2016 7:45:43 PM PDT Alejandro Piñeiro wrote: > On 02/06/16 23:09, Kenneth Graunke wrote: > > i965 has no special hardware for this, so the best way to implement > > this is to pass it in via a uniform. > > Is this comment accurate? On the next patch you implement the i965

  1   2   >