[Mesa-dev] [PATCH 3/3] radeonsi: try to hit direct hw MSAA resolve by changing micro mode in clear

From: Marek Olšák We could also do MSAA resolve in a compute shader like Vulkan and remove these workarounds. --- src/gallium/drivers/radeon/r600_pipe_common.h | 1 + src/gallium/drivers/radeon/r600_texture.c | 83 +++

[Mesa-dev] [PATCH 2/3] radeonsi: clarify the MSAA resolve limitation with scanout

From: Marek Olšák this is the correct hw requirement --- src/gallium/drivers/radeonsi/si_blit.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeonsi/si_blit.c b/src/gallium/drivers/radeonsi/si_blit.c index 60540f9..13e10de

Re: [Mesa-dev] [PATCH] glsl: reuse main extension table to appropriate restrict extensions

On Mon, Jun 13, 2016 at 12:11 PM, Emil Velikov wrote: > Hi Ilia, > > On 13 June 2016 at 00:23, Ilia Mirkin wrote: > >> @@ -81,6 +81,7 @@ MAIN_FILES = \ >> main/execmem.c \ >> main/extensions.c \ >> main/extensions.h \ >> +

Re: [Mesa-dev] [PATCH] glsl: reuse main extension table to appropriate restrict extensions

Hi Ilia, On 13 June 2016 at 00:23, Ilia Mirkin wrote: > @@ -81,6 +81,7 @@ MAIN_FILES = \ > main/execmem.c \ > main/extensions.c \ > main/extensions.h \ > + main/extensions_table.c \ From a build perspective everything looks amazing. Thank you

Re: [Mesa-dev] [PATCH] glsl: reuse main extension table to appropriate restrict extensions

On Mon, Jun 13, 2016 at 12:03 PM, Nanley Chery wrote: > > > On Sun, Jun 12, 2016 at 4:23 PM, Ilia Mirkin wrote: >> >> Previously we were only restricting based on ES/non-ES-ness and whether >> the overall enable bit had been flipped on. However we

Re: [Mesa-dev] [PATCH] glsl: reuse main extension table to appropriate restrict extensions

On Sun, Jun 12, 2016 at 4:23 PM, Ilia Mirkin wrote: > Previously we were only restricting based on ES/non-ES-ness and whether > the overall enable bit had been flipped on. However we have been adding > more fine-grained restrictions, such as based on compat profiles, as >

Re: [Mesa-dev] Mesa (master): st/mesa: use buffer usage history to set dirty flags for revalidation

On Mon, Jun 13, 2016 at 5:17 PM, Roland Scheidegger wrote: > Am 13.06.2016 um 14:53 schrieb Marek Olšák: >> On Mon, Jun 13, 2016 at 1:14 PM, Jose Fonseca wrote: >>> On 10/06/16 15:40, Roland Scheidegger wrote: Am 10.06.2016 um 12:38 schrieb

Re: [Mesa-dev] [PATCH] util: remove some assertions in util_resource_copy_region()

Reviewed-by: Ilia Mirkin On Mon, Jun 13, 2016 at 11:56 AM, Brian Paul wrote: > And update the comment. > Fixes piglit fbo-generatemipmap-formats GL_ARB_texture_compression. > --- > src/gallium/auxiliary/util/u_surface.c | 9 - > 1 file changed,

[Mesa-dev] [PATCH] util: remove some assertions in util_resource_copy_region()

And update the comment. Fixes piglit fbo-generatemipmap-formats GL_ARB_texture_compression. --- src/gallium/auxiliary/util/u_surface.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/src/gallium/auxiliary/util/u_surface.c b/src/gallium/auxiliary/util/u_surface.c

[Mesa-dev] [PATCH] llvmpipe: hack-fix bugs due to bogus bind flags

From: Roland Scheidegger The gallium contract would be that bind flags must indicate all possible bindings a resource might get used, but fact is the mesa state tracker does not set bind flags correctly, and this is more or less unfixable due to GL. This caused a bug with

Re: [Mesa-dev] [PATCH 00/64] i965: Start using ISL for filling out surface states

On 13 June 2016 at 16:10, Jason Ekstrand wrote: > > > On Mon, Jun 13, 2016 at 2:24 AM, Emil Velikov > wrote: >> >> On 11 June 2016 at 17:02, Jason Ekstrand wrote: >> >> > The next 20 patches or so are general ISL cleanups and

[Mesa-dev] [PATCH] fixup! isl: Add support for filling out surface states all the way back to gen4

Wire up the Android build Cc: Jason Ekstrand --- src/intel/isl/Android.mk | 60 1 file changed, 60 insertions(+) diff --git a/src/intel/isl/Android.mk b/src/intel/isl/Android.mk index 3134981..08b8c6d 100644 ---

[Mesa-dev] [PATCH] fixup! genxml: Add enough XML for gens 4, 4.5, and 5 to get SURFACE_STATE

Wire up the Android build Cc: Jason Ekstrand Cc: Mauro Rossi --- Mauro, can you please follow up with my earlier suggestion about reusing the autoconf rules from within the Android build. Duplicating all of them is getting a bit annoying. Thanks

Re: [Mesa-dev] [PATCH v2] nvc0/ir: clamp the UBO index for compute on Kepler

On Mon, Jun 13, 2016 at 11:13 AM, Samuel Pitoiset wrote: > We already check that the address is not "too far", but we should also > clamp the UBO index in order to avoid looking at the wrong place in the > driver cb. This is a pretty rare situation though. > > v2: clamp

Re: [Mesa-dev] Mesa (master): st/mesa: use buffer usage history to set dirty flags for revalidation

Am 13.06.2016 um 14:53 schrieb Marek Olšák: > On Mon, Jun 13, 2016 at 1:14 PM, Jose Fonseca wrote: >> On 10/06/16 15:40, Roland Scheidegger wrote: >>> >>> Am 10.06.2016 um 12:38 schrieb Marek Olšák: On Fri, Jun 10, 2016 at 6:19 AM, Roland Scheidegger

[Mesa-dev] [PATCH v2] nvc0/ir: clamp the UBO index for compute on Kepler

We already check that the address is not "too far", but we should also clamp the UBO index in order to avoid looking at the wrong place in the driver cb. This is a pretty rare situation though. v2: clamp the file index too Signed-off-by: Samuel Pitoiset Cc: "12.0"

Re: [Mesa-dev] [PATCH 00/64] i965: Start using ISL for filling out surface states

On Mon, Jun 13, 2016 at 2:24 AM, Emil Velikov wrote: > On 11 June 2016 at 17:02, Jason Ekstrand wrote: > > > The next 20 patches or so are general ISL cleanups and fixes. If no one > is > > too opposed, I'd like to back-port the whole pile to

Re: [Mesa-dev] [PATCH v3 2/6] mesa: add GL_EXT_window_rectangles state storage/retrieval functionality

With the dlist code, Reviewed-by: Brian Paul On 06/12/2016 12:36 AM, Ilia Mirkin wrote: Signed-off-by: Ilia Mirkin Reviewed-by: Brian Paul --- src/mesa/main/attrib.c | 7 ++ src/mesa/main/config.h | 7

Re: [Mesa-dev] [PATCH v3 3/6] gallium: add API for setting window rectangles

On 06/12/2016 12:36 AM, Ilia Mirkin wrote: Window rectangles apply to all framebuffer operations, either in inclusive or exclusive mode. They may also be specified as part of a blit operation. In exclusive mode, any fragment inside any of the specified rectangles will be discarded. In

Re: [Mesa-dev] [PATCH v3 4/6] gallium: add PIPE_CAP_MAX_WINDOW_RECTANGLES to all drivers

Reviewed-by: Brian Paul On 06/12/2016 12:36 AM, Ilia Mirkin wrote: This says how many window rectangles are supported by the implementation, although it may not exceed PIPE_MAX_WINDOW_RECTANGLES. Signed-off-by: Ilia Mirkin ---

Re: [Mesa-dev] [PATCH] swr: fix -march flag for AVX

On Mon, 2016-06-13 at 09:03 -0400, Chuck Atkins wrote: > > Maybe I'm the only one who finds it horrible to override -march > > from > > within project build systems.  It causes no end of problems with > > LTO, > > and results in objects being built inappropriately for the target > > as > >

Re: [Mesa-dev] [PATCH 28/64] isl/state: Don't use designated initializers for buffer surface state

On Mon, Jun 13, 2016 at 7:53 AM, Jason Ekstrand wrote: > > > On Mon, Jun 13, 2016 at 1:50 AM, Emil Velikov > wrote: > >> Hi Jason, >> >> Why do you remove the C99 initializer ? Anything wrong with using it ? >> > > Mostly readability and matching

Re: [Mesa-dev] [PATCH v3 3/6] gallium: add API for setting window rectangles

On Mon, Jun 13, 2016 at 10:45 AM, Brian Paul wrote: > On 06/12/2016 12:36 AM, Ilia Mirkin wrote: >> >> Window rectangles apply to all framebuffer operations, either in >> inclusive or exclusive mode. They may also be specified as part of a >> blit operation. >> >> In exclusive

Re: [Mesa-dev] [PATCH v2 1/2] vl: Fix trivial sign compare warnings

Hi Jan, On 10 June 2016 at 04:01, Jan Vesely wrote: > From: Jan Vesely > > v2: add whitepace fixes I've squashed a couple more and pushed the patch to master. Can you please check through the patchwork list [1] and ping/resend any outstanding

Re: [Mesa-dev] [PATCH v3 3/6] gallium: add API for setting window rectangles

On 06/13/2016 08:50 AM, Ilia Mirkin wrote: On Mon, Jun 13, 2016 at 10:45 AM, Brian Paul wrote: On 06/12/2016 12:36 AM, Ilia Mirkin wrote: Window rectangles apply to all framebuffer operations, either in inclusive or exclusive mode. They may also be specified as part of a

Re: [Mesa-dev] [PATCH 28/64] isl/state: Don't use designated initializers for buffer surface state

On Mon, Jun 13, 2016 at 1:50 AM, Emil Velikov wrote: > Hi Jason, > > Why do you remove the C99 initializer ? Anything wrong with using it ? > Mostly readability and matching what we did earlier with the other surface state struct. > > On 11 June 2016 at 17:02, Jason

Re: [Mesa-dev] [PATCH] swr: fix -march flag for AVX

> On Jun 12, 2016, at 3:56 AM, Steven Newbury wrote: > > On Fri, 2016-06-10 at 16:05 -0400, Ilia Mirkin wrote: >> On Fri, Jun 10, 2016 at 3:43 PM, Tim Rowley > om> wrote: >>> >>> Previously used core-avx-i was for ivybridge; >>> corei7-avx

Re: [Mesa-dev] [PATCH] nvc0/ir: clamp the UBO index for compute on Kepler

On Fri, Jun 3, 2016 at 7:28 AM, Samuel Pitoiset wrote: > We already check that the address is not "too far", but we should also > clamp the UBO index in order to avoid looking at the wrong place in the > driver cb. This is a pretty rare situation though. > >

Re: [Mesa-dev] [PATCH] nvc0/ir: clamp the UBO index for compute on Kepler

ping On 06/03/2016 01:28 PM, Samuel Pitoiset wrote: We already check that the address is not "too far", but we should also clamp the UBO index in order to avoid looking at the wrong place in the driver cb. This is a pretty rare situation though. Signed-off-by: Samuel Pitoiset

[Mesa-dev] [PATCH 2/4] Use correct names for dlopen()ed files on Cygwin

From: Yaakov Selkowitz Signed-off-by: Yaakov Selkowitz Reviewed-by: Jon Turney --- src/egl/drivers/dri2/egl_dri2.c| 2 ++ src/gallium/auxiliary/util/u_format_s3tc.c | 2 ++ src/glx/dri_common.c

[Mesa-dev] [PATCH 1/4] configure: Define _GNU_SOURCE for Cygwin as well

From: Yaakov Selkowitz Cygwin headers are now a bit more correct in handling feature test macros, so use _GNU_SOURCE when building for Cygwin, as well. (Notwithstanding f381c27c, we should probably have always been using _GNU_SOURCE, since asprintf() is used by mesa in

[Mesa-dev] [PATCH 3/4] configure: Don't require pthread-stubs on Cygwin

Commit 1f4869a2 unconditionally requires pthread-stubs. Unfortunately, the cleverness that pthread-stubs is doesn't work with PE/COFF, and historically Cygwin doesn't have a pthread-stubs.pc. Don't require pthread-stubs on Cygwin. Signed-off-by: Jon Turney ---

[Mesa-dev] [PATCH 4/4] Disable use of weak in threads_posix.h on Cygwin

Weak doesn't work the same on PE/COFF as on ELF, they are only weak references. Specifically, since nothing else pulls in the object which contains pthread_mutexattr_init() (and coming from the C library, that is the only thing that object contains), means that it ends up as 0 Signed-off-by: Jon

[Mesa-dev] [PATCH 0/4] Various Cygwin fixes

Jon Turney (2): configure: Don't require pthread-stubs on Cygwin Disable use of weak in threads_posix.h on Cygwin Yaakov Selkowitz (2): configure: Define _GNU_SOURCE for Cygwin as well Use correct names for dlopen()ed files on Cygwin configure.ac | 23

Re: [Mesa-dev] [Mesa-stable] [PATCH 2/2] anv/entrypoints: Rework #if guards

On 10 June 2016 at 21:18, Jason Ekstrand wrote: >> It should be possible (from a very quick look) since all the platform >> specifics arguments are pointers to the specific types. >> I think that may be better solution, but regardless if you opt for it or >> not > > > I'm

Re: [Mesa-dev] [PATCH v2 2/2] gallivm: Fix trivial sign warnings

On 13/06/16 14:12, Jan Vesely wrote: On Sat, 2016-06-11 at 17:38 +0100, Jose Fonseca wrote: On 10/06/16 04:01, Jan Vesely wrote: From: Jan Vesely v2: include whitespace fixes Signed-off-by: Jan Vesely ---

Re: [Mesa-dev] [PATCH v2 2/2] gallivm: Fix trivial sign warnings

On Sat, 2016-06-11 at 17:38 +0100, Jose Fonseca wrote: > On 10/06/16 04:01, Jan Vesely wrote: > > From: Jan Vesely > > > > v2: include whitespace fixes > > > > Signed-off-by: Jan Vesely > > --- > >   src/gallium/auxiliary/gallivm/lp_bld_conv.c

Re: [Mesa-dev] [PATCH] swr: fix -march flag for AVX

> > Maybe I'm the only one who finds it horrible to override -march from > within project build systems. It causes no end of problems with LTO, > and results in objects being built inappropriately for the target as > specified by the builder. > In general I would agree, yes, but I think swr is a

Re: [Mesa-dev] Mesa (master): st/mesa: use buffer usage history to set dirty flags for revalidation

On Mon, Jun 13, 2016 at 1:14 PM, Jose Fonseca wrote: > On 10/06/16 15:40, Roland Scheidegger wrote: >> >> Am 10.06.2016 um 12:38 schrieb Marek Olšák: >>> >>> On Fri, Jun 10, 2016 at 6:19 AM, Roland Scheidegger >>> wrote: Am 10.06.2016 um 05:14

Re: [Mesa-dev] [RFC 2/3] u_vbuf: add logic to use a limited number of vbufs

On Sat, Jun 11, 2016 at 9:21 PM, Christian Gmeiner wrote: > From: "Wladimir J. van der Laan" > > Make it possible to limit the number of vertex buffers as there exist > GPUs with less then 32 supported vertex buffers. > > Signed-off-by: Wladimir J.

[Mesa-dev] [Bug 95246] Segfault in glBindFramebuffer()

https://bugs.freedesktop.org/show_bug.cgi?id=95246 Daniel Scharrer changed: What|Removed |Added Resolution|--- |FIXED

[Mesa-dev] [GSoC lib soft float] Blog update

Hi, After a few weeks of coding, I wrote a new post on my blog ( https://hopetech.github.io/). I speak about the progress of my project, the difficulties encountered and the tools I use. Happy reading, Elie ___ mesa-dev mailing list

Re: [Mesa-dev] [PATCH] glsl: reuse main extension table to appropriate restrict extensions

On Mon, Jun 13, 2016 at 12:08:24PM +0100, Eric Engestrom wrote: > static enum { extension_table_size = > ARRAY_SIZE(extension_table_for_size) }; Sorry, I don't know how that `static` snuck in here, but it obviously shouldn't be here. ___

Re: [Mesa-dev] Mesa (master): st/mesa: use buffer usage history to set dirty flags for revalidation

On 10/06/16 15:40, Roland Scheidegger wrote: Am 10.06.2016 um 12:38 schrieb Marek Olšák: On Fri, Jun 10, 2016 at 6:19 AM, Roland Scheidegger wrote: Am 10.06.2016 um 05:14 schrieb Ilia Mirkin: On Thu, Jun 9, 2016 at 11:13 PM, Roland Scheidegger wrote:

Re: [Mesa-dev] [PATCH] glsl: reuse main extension table to appropriate restrict extensions

On Sun, Jun 12, 2016 at 07:23:41PM -0400, Ilia Mirkin wrote: > Previously we were only restricting based on ES/non-ES-ness and whether > the overall enable bit had been flipped on. However we have been adding > more fine-grained restrictions, such as based on compat profiles, as > well as specific

Re: [Mesa-dev] [PATCH v2] i965: Check return value of screen->image.loader->getBuffers

Please disregard this one. Forgot to add change log and update the subject with version suffix. Fixed and resent already. Sorry for the noise. On Mon, Jun 13, 2016 at 7:48 PM, Tomasz Figa wrote: > The images struct is an uninitialized local variable on the stack. If the >

[Mesa-dev] [PATCH v2] i965: Check return value of screen->image.loader->getBuffers (v2)

The images struct is an uninitialized local variable on the stack. If the callback returns 0, the struct might not have been updated and so should be considered uninitialized. Currently the code ignores the return value, which (depending on stack contents) might end up in reading a non-zero value

[Mesa-dev] [PATCH] glsl/builtin_variables: Populate MaxCombinedShaderStorageBlocks on GLSL 4.40

Built-in variable "MaxCombinedShaderStorageBlocks" was added to GLSL 4.40 revision 9. Section "1.2.1 Changes since revision 8 of GLSL version 4.40", page 3 of the PDF states: "Bug 11734: Add gl_MaxCombinedShaderOutputResources and mark gl_MaxCombinedImageUnitsAndFragmentOutputs as

[Mesa-dev] [PATCH v2] i965: Check return value of screen->image.loader->getBuffers

The images struct is an uninitialized local variable on the stack. If the callback returns 0, the struct might not have been updated and so should be considered uninitialized. Currently the code ignores the return value, which (depending on stack contents) might end up in reading a non-zero value

[Mesa-dev] [Bug 92877] Add support for libglvnd

https://bugs.freedesktop.org/show_bug.cgi?id=92877 AnAkkk changed: What|Removed |Added CC||anakin...@gmail.com --

Re: [Mesa-dev] [PATCH] llvmpipe: hack-fix bugs due to bogus bind flags

On 13/06/16 09:56, Roland Scheidegger wrote: Am 11.06.2016 um 18:41 schrieb Jose Fonseca: On 11/06/16 00:19, srol...@vmware.com wrote: From: Roland Scheidegger The gallium contract would be that bind flags must indicate all possible bindings a resource might get used, but

Re: [Mesa-dev] [PATCH] radeon: remove unnecessary checks

On 13.06.2016 03:19, Jakob Sinclair wrote: PIPE_SWIZZLE_X is always 0 and desc->swizzle is an unsigned char meaning that desc->swizzle can never be smaller then PIPE_SWIZZLE_X. Removing these checks doesn't change the code path at all because they would always give the same result. Issue

Re: [Mesa-dev] [RFC 3/3] u_vbuf: use single vertex buffer if needed

On 11.06.2016 21:21, Christian Gmeiner wrote: From: "Wladimir J. van der Laan" CONST, VERTEX and INSTANCE attributes into one vertex buffer if necessary due to hardware constraints. Signed-off-by: Wladimir J. van der Laan ---

Re: [Mesa-dev] [RFC 1/3] gallium: add PIPE_CAP_MAX_VERTEX_BUFFERS

Most drivers actually support 16. If you look at what various drivers return for (PIPE_SHADER_VERTEX, PIPE_SHADER_CAP_MAX_INPUTS), that's the number of vertex buffers, vertex elements, and vertex shader inputs they support. Marek On Sat, Jun 11, 2016 at 9:21 PM, Christian Gmeiner

Re: [Mesa-dev] [RFC 2/3] u_vbuf: add logic to use a limited number of vbufs

On 11.06.2016 21:21, Christian Gmeiner wrote: From: "Wladimir J. van der Laan" Make it possible to limit the number of vertex buffers as there exist GPUs with less then 32 supported vertex buffers. Signed-off-by: Wladimir J. van der Laan ---

Re: [Mesa-dev] [PATCH] gallium: add API for setting window rectangles

On 11.06.2016 21:14, Ilia Mirkin wrote: Window rectangles apply to all framebuffer operations, either in inclusive or exclusive mode. They may also be specified as part of a blit operation. In exclusive mode, any fragment inside any of the specified rectangles will be discarded. In inclusive

Re: [Mesa-dev] [PATCH 00/64] i965: Start using ISL for filling out surface states

On 11 June 2016 at 17:02, Jason Ekstrand wrote: > The next 20 patches or so are general ISL cleanups and fixes. If no one is > too opposed, I'd like to back-port the whole pile to 12.0. There are two > reasons for this: First, ISL is new and this is a substantial cleanup;

Re: [Mesa-dev] [PATCH] llvmpipe: hack-fix bugs due to bogus bind flags

Am 11.06.2016 um 18:41 schrieb Jose Fonseca: > On 11/06/16 00:19, srol...@vmware.com wrote: >> From: Roland Scheidegger >> >> The gallium contract would be that bind flags must indicate all possible >> bindings a resource might get used, but fact is the mesa state tracker >>

Re: [Mesa-dev] [PATCH 28/64] isl/state: Don't use designated initializers for buffer surface state

Hi Jason, Why do you remove the C99 initializer ? Anything wrong with using it ? On 11 June 2016 at 17:02, Jason Ekstrand wrote: > --- > src/intel/isl/isl_surface_state.c | 46 > +++ > 1 file changed, 23 insertions(+), 23 deletions(-)

[Mesa-dev] What is EGL_EXT_image_dma_buf_import image orientation as a GL texture?

Hi all, I was working on Weston when I noticed that the weston-simple-dmabuf-intel demo shows the window content in different orientations depending on whether it is composited with GL or directly scanned out. Obviously something is a miss. Then I went out to find what the orientation should be

Re: [Mesa-dev] [PATCH v3] st/va: ensure linear memory for dmabuf

Am 13.06.2016 um 10:12 schrieb Julien Isorce: In order to do zero-copy between two different devices the memory should not be tiled. Tested with GStreamer on a laptop that has 2 GPUs: 1- gstvaapidecode: HW decoding and dmabuf export with nouveau driver on Nvidia GPU. 2- glimagesink:

[Mesa-dev] [PATCH v3] st/va: ensure linear memory for dmabuf

In order to do zero-copy between two different devices the memory should not be tiled. Tested with GStreamer on a laptop that has 2 GPUs: 1- gstvaapidecode: HW decoding and dmabuf export with nouveau driver on Nvidia GPU. 2- glimagesink: EGLImage imports dmabuf on Intel GPU. TEST:

<    1   2