Re: [Mesa-dev] [PATCH 2/6] intel/isl: Fix up asserts in calc_phys_level0_extent_sa

2016-09-06 Thread Pohjolainen, Topi
On Fri, Sep 02, 2016 at 03:50:43PM -0700, Jason Ekstrand wrote: > First, compressed 1D textures should be allowed. There's nothing in the > Vulkan spec (or in GL as far as I can remember) that dissallows them. It > just waists a bit of vertical space because it's only one pixel tall. > >

[Mesa-dev] [PATCH] glsl: use hash instead of exec_list in copy propagation

2016-09-06 Thread Tapani Pälli
This change makes copy propagation pass faster. Complete link time spent in test case attached to bug 94477 goes down to ~400 secs from over 500 secs on my HSW machine. Does not fix the actual issue but brings down the total. No regressions seen in CI. Signed-off-by: Tapani Pälli

[Mesa-dev] [v2 2/6] i965: Replace boolean rb surface state setup argument with flags

2016-09-06 Thread Topi Pohjolainen
And add plumbing to provide it all the way to surface state emitter. This is not used yet but will be in subsequent patches to carry additional constraints. Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/brw_context.h | 2 +-

[Mesa-dev] [v2 6/6] i965/rbc: Allocate mcs directly

2016-09-06 Thread Topi Pohjolainen
such as we do for compressed msaa. In case of non-compressed simgle sampled buffers the allocation of mcs is deferred until there is actually a clear operation that needs the mcs. In case of render buffer compression the mcs buffer always needed and there is no real reason to defer the allocation.

[Mesa-dev] [Bug 97549] [SNB, BXT] up to 40% perf drop from "loader/dri3: Overhaul dri3_update_num_back" commit

2016-09-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97549 Michel Dänzer changed: What|Removed |Added Resolution|--- |FIXED

Re: [Mesa-dev] [PATCH] main: GL_RGB10_A2UI does not come with GL 3.0/EXT_texture_integer

2016-09-06 Thread Nicolai Hähnle
Reviewed-by: Nicolai Hähnle On 04.09.2016 02:24, Ilia Mirkin wrote: Add a separate extension check for that format. Prevents glTexImage from trying to find a matching format, which fails on drivers without support for this format. Fixes: sized-texture-format-channels

[Mesa-dev] [v2 1/6] i965/rbc: Allow integer formats as advertised in isl_format.c

2016-09-06 Thread Topi Pohjolainen
Blorp consults brw_is_color_fast_clear_compatible() to see if any restrictions apply for fast clear in addition to the capablities advertised in isl_format.c::format_info[]. On Gen8+ integer formats are backlisted for plain old fast clear but there is no reason why lossless compression shouldn't

[Mesa-dev] i965: Allocate mcs directly for lossless compressed

2016-09-06 Thread Topi Pohjolainen
This mini-series replaces patches 1-4/12 in "Hardware assisted layered clears". This is based on Jason's feedback and some offline discussion. Mostly it tackles tries to tackle cases where a render pass uses the same surface for both texturing and rendering. In case the surface suppors lossless

[Mesa-dev] [v2 3/6] i965: Track non-compressible sampling of renderbuffers

2016-09-06 Thread Topi Pohjolainen
Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/brw_context.c | 16 src/mesa/drivers/dri/i965/brw_context.h | 10 ++ src/mesa/drivers/dri/i965/brw_wm_surface_state.c | 12 ++-- 3 files changed, 36

[Mesa-dev] [v2 5/6] isl/gen8+: Allow 1D and 3D auxiliary surfaces

2016-09-06 Thread Topi Pohjolainen
Otherwise once mcs buffer gets allocated without delay for lossless compression (same as we do for msaa), assert starts to fire in piglit case: tex3d. The test uses depth of one which is in fact supported even now. v2 (Jason): Allow also 1D case as there is nothing in the specs

[Mesa-dev] [v2 4/6] i965/rbc: Set aux surface sampling engine according to rb settings

2016-09-06 Thread Topi Pohjolainen
Once mcs buffer gets allocated without delay for lossless compression (same as we do for msaa), one gets regression in: GL45-CTS.texture_barrier_ARB.same-texel-rw Setting the auxiliary surface for both sampling engine and data port seems to fix this. I haven't found any hardware documentation

Re: [Mesa-dev] [PATCH 4/4] radeonsi: skip redundant INDEX_TYPE writes

2016-09-06 Thread Nicolai Hähnle
For the series: Reviewed-by: Nicolai Hähnle On 06.09.2016 00:46, Marek Olšák wrote: From: Marek Olšák Ported from Vulkan. --- src/gallium/drivers/radeonsi/si_hw_context.c | 1 + src/gallium/drivers/radeonsi/si_pipe.h | 1 +

Re: [Mesa-dev] [PATCH 3/4] radeonsi: add more unlikely() uses into si_draw_vbo

2016-09-06 Thread Marek Olšák
On Tue, Sep 6, 2016 at 3:54 AM, Michel Dänzer wrote: > On 06/09/16 07:46 AM, Marek Olšák wrote: >> From: Marek Olšák > > Did you measure any significant performance boost with this change? I didn't measure anything. > Otherwise, using (un)likely can be

[Mesa-dev] [PATCH 0/3] Make eglExportDMABUFImageMESA return corresponding offset.

2016-09-06 Thread Chuanbo Weng
This patchset makes eglExportDMABUFImageMESA return corresponding offset of EGLImage instead of 0 on intel platfrom with classic dri driver(i965). Chuanbo Weng (3): dri: add offset attribute and bump version of EGLImage extensions. egl: return corresponding offset of EGLImage instead of 0.

[Mesa-dev] [PATCH 3/3] i965: implement querying __DRI_IMAGE_ATTRIB_OFFSET.

2016-09-06 Thread Chuanbo Weng
Implement querying this attribute in intelImageExtension and bump version of intelImageExtension. Signed-off-by: Chuanbo Weng --- src/mesa/drivers/dri/i965/intel_screen.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git

[Mesa-dev] [PATCH 2/3] egl: return corresponding offset of EGLImage instead of 0.

2016-09-06 Thread Chuanbo Weng
The offset should not always be 0. For example, if EGLImage is created from a 2D texture with EGL_GL_TEXTURE_LEVEL=1, then the offset should be the actual start of miplevel 1 in bo. Signed-off-by: Chuanbo Weng --- src/egl/drivers/dri2/egl_dri2.c | 12 +--- 1 file

[Mesa-dev] [PATCH 1/3] dri: add offset attribute and bump version of EGLImage extensions.

2016-09-06 Thread Chuanbo Weng
Offset is useful for buffer sharing with other components, so add it to queryImage attributes. Signed-off-by: Chuanbo Weng --- include/GL/internal/dri_interface.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/include/GL/internal/dri_interface.h

Re: [Mesa-dev] [PATCH v2] egl: return corresponding offset of EGLImage instead of 0.

2016-09-06 Thread Weng Chuanbo
Hi Emil, I have split out patches and sent out the patches. Please review them. Thanks! 2016-09-06 11:03 GMT+08:00 Weng Chuanbo : > Got it. Thanks for your patient explanation! > > 2016-09-06 1:14 GMT+08:00 Emil Velikov : > >> On 5

Re: [Mesa-dev] [PATCH 0/7] omx hevc decode support

2016-09-06 Thread Christian König
The whole series is Acked-by: Christian König . I tried to look closer into it, but I only have two hands and one head. Regards, Christian. Am 31.08.2016 um 15:51 schrieb Leo Liu: This set implements hevc decode for omx, it includes basic structures from h264

[Mesa-dev] [PATCH] gbm: fix potential NULL deref of mapImage/unmapImage.

2016-09-06 Thread Chuanbo Weng
The mapImage/unmapImage functions of DRIimage extension can be NULL, so we should add additional check for them. Cc: Signed-off-by: Chuanbo Weng --- src/gbm/backends/dri/gbm_dri.c | 5 +++-- 1 file changed, 3 insertions(+), 2

[Mesa-dev] [PATCH] gbm: fix potential NULL deref of mapImage/unmapImage.

2016-09-06 Thread Chuanbo Weng
The mapImage/unmapImage functions of DRIimage extension can be NULL, so we should add additional check for them. Cc: Signed-off-by: Chuanbo Weng --- src/gbm/backends/dri/gbm_dri.c | 5 +++-- 1 file changed, 3 insertions(+), 2

Re: [Mesa-dev] [PATCH] loader/dri3: Always use at least two back buffers

2016-09-06 Thread Michel Dänzer
On 06/09/16 03:14 PM, Michel Dänzer wrote: > On 06/09/16 01:59 PM, Jason Ekstrand wrote: >> On Sep 5, 2016 8:43 PM, "Michel Dänzer" > > wrote: >>> >>> On 06/09/16 12:08 PM, Jason Ekstrand wrote: On Mon, Sep 5, 2016 at 7:39 PM, Michel Dänzer

Re: [Mesa-dev] [PATCH] loader/dri3: Always use at least two back buffers

2016-09-06 Thread Michel Dänzer
On 06/09/16 01:59 PM, Jason Ekstrand wrote: > On Sep 5, 2016 8:43 PM, "Michel Dänzer" > wrote: >> >> On 06/09/16 12:08 PM, Jason Ekstrand wrote: >> > On Mon, Sep 5, 2016 at 7:39 PM, Michel Dänzer >>

Re: [Mesa-dev] [PATCH 1/3] nir/gcm: Call nir_metadata_preserve

2016-09-06 Thread Eric Anholt
Jason Ekstrand writes: > --- > src/compiler/nir/nir_opt_gcm.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/src/compiler/nir/nir_opt_gcm.c b/src/compiler/nir/nir_opt_gcm.c > index 84e32ef..02a9348 100644 > --- a/src/compiler/nir/nir_opt_gcm.c > +++

Re: [Mesa-dev] [PATCH 2/3] nir/gcm: Add value numbering support

2016-09-06 Thread Eric Anholt
Jason Ekstrand writes: > --- This seems fine, but the commit message needs some expansion. Questions I had: Does this help compared to an implementation with nir CSE already? Does nir CSE still get us anything that this doesn't? signature.asc Description: PGP

[Mesa-dev] [PATCH] st/va: enable vbr rate control for vaapi encode

2016-09-06 Thread boyuan.zhang
From: Boyuan Zhang This patch enables variable bit-rate for vaapi encoding. According to va.h, target bit-rate equals to maximum bit-rate multiplies by target_percentage. Signed-off-by: Boyuan Zhang --- src/gallium/state_trackers/va/config.c | 2 +-

Re: [Mesa-dev] [Piglit] Black screen / hang in piglit's spec@ext_texture_lod_bias@lodbias test on radionsi with ubuntu 16.04

2016-09-06 Thread Ilia Mirkin
[-piglit,+mesa-dev] On Tue, Sep 6, 2016 at 5:03 PM, Dan Kegel wrote: > Hi all, > happily running piglit on Ubuntu 16.04 with an AMD W600 card. No > system crashes so far :-) > But I do have an X hang. Black screen, test hung, but still available via > ssh. > > I looked in >

[Mesa-dev] [PATCH] mapi: add gl32.h to the list of GLES3 headers for installation

2016-09-06 Thread Ilia Mirkin
This was missed when I added the updated (and new) Khronos headers. Signed-off-by: Ilia Mirkin --- src/mapi/Makefile.am | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mapi/Makefile.am b/src/mapi/Makefile.am index 68a28a2..3b0a9de 100644 --- a/src/mapi/Makefile.am

[Mesa-dev] [PATCH] spirv/nir: Add support for OpAtomicLoad/Store

2016-09-06 Thread Lionel Landwerlin
Fixes new CTS tests : dEQP-VK.spirv_assembly.instruction.compute.opatomic.load dEQP-VK.spirv_assembly.instruction.compute.opatomic.store v2: don't handle images like ssbo/ubo (Jason) Signed-off-by: Lionel Landwerlin Cc: Jason Ekstrand

Re: [Mesa-dev] [PATCH 2/3] nir/gcm: Add value numbering support

2016-09-06 Thread Jason Ekstrand
On Sep 6, 2016 1:50 PM, "Eric Anholt" wrote: > > Jason Ekstrand writes: > > > --- > > This seems fine, but the commit message needs some expansion. Questions > I had: > > Does this help compared to an implementation with nir CSE already? Yes, value

Re: [Mesa-dev] [PATCH 1/3] nir/spirv: Swap the argument order for AtomicCompareExchange

2016-09-06 Thread Dave Airlie
For the series: Reviewed-by: Dave Airlie On 7 September 2016 at 08:17, Jason Ekstrand wrote: > SPIR-V has the two arguments in the opposite order from GLSL. NIR uses the > GLSL order so we had them backwards. > > Fixes

Re: [Mesa-dev] [PATCH 14/33] intel/blorp: Add an entrypoint for doing bit-for-bit copies

2016-09-06 Thread Nanley Chery
On Wed, Aug 31, 2016 at 02:22:33PM -0700, Jason Ekstrand wrote: > --- > src/intel/blorp/blorp.h | 10 > src/intel/blorp/blorp_blit.c | 133 > +++ > 2 files changed, 143 insertions(+) > > diff --git a/src/intel/blorp/blorp.h

[Mesa-dev] [PATCH] doc: fix typo of GALLIUM_HUD_TOGGLE_SIGNAL

2016-09-06 Thread Christoph Haag
From: Christoph Haag In the original commit message in 56a1c10 it was wrongly used too: - env GALLIUM_HUD_SIGNAL_TOGGLE: toggle visibility via signal --- docs/envvars.html | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/envvars.html

Re: [Mesa-dev] [PATCH 3/4] radeonsi: add more unlikely() uses into si_draw_vbo

2016-09-06 Thread Gustaw Smolarczyk
2016-09-06 3:56 GMT+02:00 Ilia Mirkin : > On Mon, Sep 5, 2016 at 9:54 PM, Michel Dänzer wrote: >> On 06/09/16 07:46 AM, Marek Olšák wrote: >>> From: Marek Olšák >> >> Did you measure any significant performance boost with this

Re: [Mesa-dev] [PATCH 3/4] radeonsi: add more unlikely() uses into si_draw_vbo

2016-09-06 Thread Marek Olšák
On Sep 6, 2016 12:03 PM, "Michel Dänzer" wrote: > > On 06/09/16 06:04 PM, Marek Olšák wrote: > > On Tue, Sep 6, 2016 at 3:54 AM, Michel Dänzer wrote: > >> On 06/09/16 07:46 AM, Marek Olšák wrote: > >>> From: Marek Olšák > >> > >> Did

Re: [Mesa-dev] [Piglit] [PATCH 1/2] egl: Add sanity test for EGL_EXT_device_query (v3)

2016-09-06 Thread Emil Velikov
[moving to mesa-dev, adding the EGL device spec authors for their input] On 5 September 2016 at 08:48, Mathias Fröhlich wrote: > On Friday, 2 September 2016 14:02:07 CEST Emil Velikov wrote: > >> On 2 September 2016 at 07:15, Mathias Fröhlich > >>

[Mesa-dev] [Bug 97608] Account request

2016-09-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97608 Bug ID: 97608 Summary: Account request Product: Mesa Version: git Hardware: Other OS: All Status: NEW Severity: normal Priority: medium

[Mesa-dev] [Bug 97260] [bisected] R9 290 low performance in Linux 4.7

2016-09-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97260 Kai changed: What|Removed |Added CC|k...@dev.carbon-project.org | --- Comment #43

[Mesa-dev] [Bug 97260] [bisected] R9 290 low performance in Linux 4.7

2016-09-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97260 --- Comment #44 from Jos van Wolput --- (In reply to Michel Dänzer from comment #39) > Anyway, please test the patch I attached to bug 97549. Fixed on my hardware, thanks! -- You are receiving this mail because: You

Re: [Mesa-dev] [PATCH 0/7] omx hevc decode support

2016-09-06 Thread Leo Liu
On 09/06/2016 05:25 AM, Christian König wrote: The whole series is Acked-by: Christian König . I tried to look closer into it, but I only have two hands and one head. I think you got more efficient hands:-) thanks for taking look. Regards, Leo Regards,

[Mesa-dev] [Bug 97608] Account request

2016-09-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97608 --- Comment #1 from Emil Velikov --- Fwiw I'm all for granting Serge commit access to mesa. He's got 30+ commits [1] mostly in clover - ranging from build fixes to few CL functionality. On the piglit side the numbers

[Mesa-dev] [Bug 97566] [dri3] The frame of a window and its open gl content are out of sync.

2016-09-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97566 Manuel Schneider changed: What|Removed |Added Component|Other

[Mesa-dev] [Bug 97260] [bisected] R9 290 low performance in Linux 4.7

2016-09-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97260 --- Comment #42 from Dieter Nützel --- Hello Kai et al., can you please retest with current Mesa git master (dc3bb5d). And let us know if R9 290 low performance regression is fixed for you, too? -- You are receiving this

[Mesa-dev] [Bug 97566] [dri3] The frame of a window and its open gl content are out of sync.

2016-09-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97566 Manuel Schneider changed: What|Removed |Added Version|unspecified |12.0 --

Re: [Mesa-dev] [PATCH 2/2] st/vdapu: use lanczos filter for scaling v4

2016-09-06 Thread Nayan Deshmukh
Hi Leo, I thought so. As Michel suggested present extension needs a linear buffer and he and Christian agreed that we should have a separate linear buffer for this. But I still don't understand the code in vl_winsys_dri3.c so I am not sure how this could be implemented. Regards, Nayan. On Tue,

Re: [Mesa-dev] [v2 6/6] i965/rbc: Allocate mcs directly

2016-09-06 Thread Jason Ekstrand
Reviewed-by: Jason Ekstrand On Tue, Sep 6, 2016 at 12:28 AM, Topi Pohjolainen < topi.pohjolai...@gmail.com> wrote: > such as we do for compressed msaa. In case of non-compressed simgle > sampled buffers the allocation of mcs is deferred until there is > actually a clear

Re: [Mesa-dev] [v2 2/6] i965: Replace boolean rb surface state setup argument with flags

2016-09-06 Thread Jason Ekstrand
Would I be too much of a pedant if I asked for uint32_t for flags? On Tue, Sep 6, 2016 at 12:28 AM, Topi Pohjolainen < topi.pohjolai...@gmail.com> wrote: > And add plumbing to provide it all the way to surface state emitter. > This is not used yet but will be in subsequent patches to carry >

Re: [Mesa-dev] [PATCH 4/6] intel/isl: Handle HiZ and CCS tiling more directly

2016-09-06 Thread Pohjolainen, Topi
On Fri, Sep 02, 2016 at 03:50:45PM -0700, Jason Ekstrand wrote: > The HiZ and CCS tiling formats are always used for HiZ and CCS surfaces > respectively. There's no reason why we should go through filter_tiling and > it's much easier to always get HiZ and CCS right if we just handle them >

Re: [Mesa-dev] [PATCH] android: fix a build issue with libmesa_st_mesa_32

2016-09-06 Thread Emil Velikov
On 6 September 2016 at 15:33, Chih-Wei Huang wrote: > 2016-08-29 16:52 GMT+08:00 Tapani Pälli : >> make sure nir_opcodes.h is in LOCAL_GENERATED_SOURCES otherwise >> build fails with: >> >> "In file included from >>

Re: [Mesa-dev] [v2 3/6] i965: Track non-compressible sampling of renderbuffers

2016-09-06 Thread Pohjolainen, Topi
On Tue, Sep 06, 2016 at 07:54:16AM -0700, Jason Ekstrand wrote: >On Tue, Sep 6, 2016 at 12:28 AM, Topi Pohjolainen ><[1]topi.pohjolai...@gmail.com> wrote: > > Signed-off-by: Topi Pohjolainen <[2]topi.pohjolai...@intel.com> > --- > src/mesa/drivers/dri/i965/brw_context.c

Re: [Mesa-dev] [PATCH 1/6] intel/isl: Add a format_supports_multisampling helper

2016-09-06 Thread Jason Ekstrand
On Sep 5, 2016 10:39 PM, "Pohjolainen, Topi" wrote: > > On Fri, Sep 02, 2016 at 03:50:42PM -0700, Jason Ekstrand wrote: > > --- > > src/intel/isl/isl.h| 2 ++ > > src/intel/isl/isl_format.c | 30 ++ > > src/intel/isl/isl_gen6.c |

Re: [Mesa-dev] [PATCH 09/10] st/vdpau: implement the new DMA-buf based interop

2016-09-06 Thread Ilia Mirkin
On Mon, Sep 5, 2016 at 2:48 AM, Michel Dänzer wrote: > On 05/09/16 04:37 AM, Ilia Mirkin wrote: >> On Tue, Mar 8, 2016 at 7:21 AM, Christian König >> wrote: >>> @@ -80,7 +82,7 @@ vlVdpOutputSurfaceCreate(VdpDevice device, >>> res_tmpl.depth0 = 1;

Re: [Mesa-dev] [PATCH] android: fix a build issue with libmesa_st_mesa_32

2016-09-06 Thread Chih-Wei Huang
2016-08-29 16:52 GMT+08:00 Tapani Pälli : > make sure nir_opcodes.h is in LOCAL_GENERATED_SOURCES otherwise > build fails with: > > "In file included from > external/mesa/src/mesa/state_tracker/st_glsl_to_nir.cpp:44: > external/mesa/src/compiler/nir/nir.h:42:10: fatal

Re: [Mesa-dev] [PATCH 4/6] intel/isl: Handle HiZ and CCS tiling more directly

2016-09-06 Thread Jason Ekstrand
On Tue, Sep 6, 2016 at 7:18 AM, Pohjolainen, Topi < topi.pohjolai...@gmail.com> wrote: > On Fri, Sep 02, 2016 at 03:50:45PM -0700, Jason Ekstrand wrote: > > The HiZ and CCS tiling formats are always used for HiZ and CCS surfaces > > respectively. There's no reason why we should go through

Re: [Mesa-dev] [v2 5/6] isl/gen8+: Allow 1D and 3D auxiliary surfaces

2016-09-06 Thread Jason Ekstrand
Reviewed-by: Jason Ekstrand On Tue, Sep 6, 2016 at 12:28 AM, Topi Pohjolainen < topi.pohjolai...@gmail.com> wrote: > Otherwise once mcs buffer gets allocated without delay for lossless > compression (same as we do for msaa), assert starts to fire in > piglit case: tex3d.

Re: [Mesa-dev] [PATCH 2/2] st/vdapu: use lanczos filter for scaling v4

2016-09-06 Thread Leo Liu
Hi Nayan, This quick hack was just to prove Christian's idea, and for your reference. I don't have multi GPU system, and only had a very brief test on single GPU, so it might be some difference on your multi GPU system. we have to dig more into it. Regards, Leo On 09/05/2016 03:51 AM, Nayan

Re: [Mesa-dev] [v2 3/6] i965: Track non-compressible sampling of renderbuffers

2016-09-06 Thread Jason Ekstrand
On Tue, Sep 6, 2016 at 8:16 AM, Pohjolainen, Topi < topi.pohjolai...@gmail.com> wrote: > On Tue, Sep 06, 2016 at 07:54:16AM -0700, Jason Ekstrand wrote: > >On Tue, Sep 6, 2016 at 12:28 AM, Topi Pohjolainen > ><[1]topi.pohjolai...@gmail.com> wrote: > > > > Signed-off-by: Topi

[Mesa-dev] [PATCH] gallium: fix clang warnings

2016-09-06 Thread Martina Kollarova
1. Variable 'hole' is uninitialized when used here [-Wuninitialized] 2. Comparison of constant -1 with expression of type 'unsigned int' is always false [-Wtautological-constant-out-of-range-compare] --- src/gallium/winsys/radeon/drm/radeon_drm_bo.c | 2 +-

Re: [Mesa-dev] [v2 3/6] i965: Track non-compressible sampling of renderbuffers

2016-09-06 Thread Jason Ekstrand
On Tue, Sep 6, 2016 at 12:28 AM, Topi Pohjolainen < topi.pohjolai...@gmail.com> wrote: > Signed-off-by: Topi Pohjolainen > --- > src/mesa/drivers/dri/i965/brw_context.c | 16 > src/mesa/drivers/dri/i965/brw_context.h | 10 ++

Re: [Mesa-dev] [v2 4/6] i965/rbc: Set aux surface sampling engine according to rb settings

2016-09-06 Thread Jason Ekstrand
On Tue, Sep 6, 2016 at 12:28 AM, Topi Pohjolainen < topi.pohjolai...@gmail.com> wrote: > Once mcs buffer gets allocated without delay for lossless > compression (same as we do for msaa), one gets regression in: > > GL45-CTS.texture_barrier_ARB.same-texel-rw > > Setting the auxiliary surface for

Re: [Mesa-dev] [PATCH] gallium: fix clang warnings

2016-09-06 Thread Nicolai Hähnle
On 06.09.2016 16:37, Martina Kollarova wrote: 1. Variable 'hole' is uninitialized when used here [-Wuninitialized] 2. Comparison of constant -1 with expression of type 'unsigned int' is always false [-Wtautological-constant-out-of-range-compare] ---

[Mesa-dev] [PATCH] spirv/nir: Add support for OpAtomicLoad/Store

2016-09-06 Thread Lionel Landwerlin
Fixes new CTS tests : dEQP-VK.spirv_assembly.instruction.compute.opatomic.load dEQP-VK.spirv_assembly.instruction.compute.opatomic.store Signed-off-by: Lionel Landwerlin Cc: Jason Ekstrand --- src/compiler/spirv/spirv_to_nir.c | 33

Re: [Mesa-dev] [PATCH 00/33] anv: Use blorp for most blits and clears

2016-09-06 Thread Nanley Chery
On Mon, Sep 05, 2016 at 09:38:59AM -0700, Jason Ekstrand wrote: > Everything is now reviewed. I've also sent two additional patches blorp > which, when placed prior to the anv patches, make the series > regression-free and they've been reviewed by Topi. > > Nanley, if you don't mind, I would

Re: [Mesa-dev] [PATCH] spirv/nir: Add support for OpAtomicLoad/Store

2016-09-06 Thread Jason Ekstrand
On Tue, Sep 6, 2016 at 9:16 AM, Lionel Landwerlin wrote: > Fixes new CTS tests : > > dEQP-VK.spirv_assembly.instruction.compute.opatomic.load > dEQP-VK.spirv_assembly.instruction.compute.opatomic.store > > Signed-off-by: Lionel Landwerlin >

[Mesa-dev] [Bug 97542] mesa-12.0.1 with llvm-3.9.0_rc3 - src/gallium/state_trackers/clover/llvm/invocation.cpp:212:75: error: no matching function for call to clang::CompilerInvocation::setLangDefault

2016-09-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97542 --- Comment #7 from Dennis Schridde --- (In reply to Daniel Exner from comment #6) > Well, I just wanted to bump llvm to the _released_ 3.9.0 and hit this bug > when trying to recompile mesa 12.0.2. > > Perhaps it should be

[Mesa-dev] [PATCH] vl/rbsp: match initial escaped bits with valid in the buffer

2016-09-06 Thread Leo Liu
Otherwise the check for the three byte will not make sense. Signed-off-by: Leo Liu --- src/gallium/auxiliary/vl/vl_rbsp.h | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/gallium/auxiliary/vl/vl_rbsp.h b/src/gallium/auxiliary/vl/vl_rbsp.h index

Re: [Mesa-dev] [PATCH 30/33] anv: Use blorp for CopyBuffer and UpdateBuffer

2016-09-06 Thread Anuj Phogat
On Sat, Sep 3, 2016 at 8:53 AM, Jason Ekstrand wrote: > > > On Fri, Sep 2, 2016 at 12:05 PM, Anuj Phogat wrote: >> >> On Wed, Aug 31, 2016 at 2:22 PM, Jason Ekstrand >> wrote: >> > --- >> > src/intel/vulkan/Makefile.sources |

[Mesa-dev] [PATCH 1/3] nir/gcm: Call nir_metadata_preserve

2016-09-06 Thread Jason Ekstrand
--- src/compiler/nir/nir_opt_gcm.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/compiler/nir/nir_opt_gcm.c b/src/compiler/nir/nir_opt_gcm.c index 84e32ef..02a9348 100644 --- a/src/compiler/nir/nir_opt_gcm.c +++ b/src/compiler/nir/nir_opt_gcm.c @@ -483,6 +483,9 @@

[Mesa-dev] [PATCH 0/3] nir: Add value number to GCM

2016-09-06 Thread Jason Ekstrand
This little series adds value numbering support to the global code motion pass. All of the patches have my name on them but most of the credit goes to Connor and his instruction set. The instruction set was originally written for GVN but we merged it a while ago because we can also use it for

Re: [Mesa-dev] [PATCH] glsl: use hash instead of exec_list in copy propagation

2016-09-06 Thread Eric Anholt
Tapani Pälli writes: > This change makes copy propagation pass faster. Complete link time > spent in test case attached to bug 94477 goes down to ~400 secs from > over 500 secs on my HSW machine. Does not fix the actual issue but > brings down the total. No regressions

Re: [Mesa-dev] [PATCH 09/10] st/vdpau: implement the new DMA-buf based interop

2016-09-06 Thread Christian König
Am 06.09.2016 um 16:23 schrieb Ilia Mirkin: On Mon, Sep 5, 2016 at 2:48 AM, Michel Dänzer wrote: On 05/09/16 04:37 AM, Ilia Mirkin wrote: On Tue, Mar 8, 2016 at 7:21 AM, Christian König wrote: @@ -80,7 +82,7 @@ vlVdpOutputSurfaceCreate(VdpDevice

[Mesa-dev] [Bug 97542] mesa-12.0.1 with llvm-3.9.0_rc3 - src/gallium/state_trackers/clover/llvm/invocation.cpp:212:75: error: no matching function for call to clang::CompilerInvocation::setLangDefault

2016-09-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97542 --- Comment #8 from Vedran Miletić --- (In reply to Dennis Schridde from comment #7) > Shouldn't ./configure check whether the installed version of LLVM is > supported? That's what Rust does. There are basically two options:

[Mesa-dev] [PATCH 3/3] i965/nir: Use GCM and GVN

2016-09-06 Thread Jason Ekstrand
--- src/mesa/drivers/dri/i965/brw_nir.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/drivers/dri/i965/brw_nir.c b/src/mesa/drivers/dri/i965/brw_nir.c index e8dafae..9071384 100644 --- a/src/mesa/drivers/dri/i965/brw_nir.c +++ b/src/mesa/drivers/dri/i965/brw_nir.c @@ -392,6 +392,7

[Mesa-dev] [PATCH 2/3] nir/gcm: Add value numbering support

2016-09-06 Thread Jason Ekstrand
--- src/compiler/nir/nir.h | 2 +- src/compiler/nir/nir_opt_gcm.c | 29 - 2 files changed, 25 insertions(+), 6 deletions(-) diff --git a/src/compiler/nir/nir.h b/src/compiler/nir/nir.h index c1cf940..ff7c422 100644 --- a/src/compiler/nir/nir.h +++

Re: [Mesa-dev] [v2 3/6] i965: Track non-compressible sampling of renderbuffers

2016-09-06 Thread Pohjolainen, Topi
On Tue, Sep 06, 2016 at 08:24:11AM -0700, Jason Ekstrand wrote: >On Tue, Sep 6, 2016 at 8:16 AM, Pohjolainen, Topi ><[1]topi.pohjolai...@gmail.com> wrote: > > On Tue, Sep 06, 2016 at 07:54:16AM -0700, Jason Ekstrand wrote: > >On Tue, Sep 6, 2016 at 12:28 AM, Topi Pohjolainen

Re: [Mesa-dev] [PATCH] glsl: use hash instead of exec_list in copy propagation

2016-09-06 Thread Jason Ekstrand
On Tue, Sep 6, 2016 at 11:14 AM, Eric Anholt wrote: > Tapani Pälli writes: > > > This change makes copy propagation pass faster. Complete link time > > spent in test case attached to bug 94477 goes down to ~400 secs from > > over 500 secs on my HSW

Re: [Mesa-dev] [Piglit] [PATCH 1/2] egl: Add sanity test for EGL_EXT_device_query (v3)

2016-09-06 Thread Mathias Fröhlich
Hi Emil, On Tuesday, 6 September 2016 12:29:01 CEST Emil Velikov wrote: > * SW EGL implementations - do we have any vendors/implementations > apart from Mesa ? I dont think so. But lets put that beside. The reason for me talking about swrast here was to fulfill that part of the

Re: [Mesa-dev] [Piglit] [PATCH 1/2] egl: Add sanity test for EGL_EXT_device_query (v3)

2016-09-06 Thread Kyle Brenneman
On 09/06/2016 05:29 AM, Emil Velikov wrote: * Interaction of ^^ with EGL device extension(s) - update existing extensions/introduce new ones ** Should EGL_EXT_device_enumeration expose one/multiple SW devices - no: we need alternative glvnd EGL interface for such cases - yes: implementing

Re: [Mesa-dev] [PATCH 09/10] st/vdpau: implement the new DMA-buf based interop

2016-09-06 Thread Christian König
Am 06.09.2016 um 21:05 schrieb Ilia Mirkin: On Tue, Sep 6, 2016 at 2:22 PM, Christian König wrote: Am 06.09.2016 um 16:23 schrieb Ilia Mirkin: On Mon, Sep 5, 2016 at 2:48 AM, Michel Dänzer wrote: On 05/09/16 04:37 AM, Ilia Mirkin wrote: On Tue,

Re: [Mesa-dev] [PATCH] glsl: Add a citation for uniform precision matching.

2016-09-06 Thread Eric Anholt
Kenneth Graunke writes: > Ian added this check in commit 259fc505454ea6a67aeacf6cdebf1398d9947759. > While reviewing the rules, I found a citation which spells this out > clearly, so I figured I'd send a patch to add it as a comment. > > Cc: i...@freedesktop.org >

Re: [Mesa-dev] [PATCH 4/6] EGL: Call the EGL_KHR_debug callback on errors.

2016-09-06 Thread Kyle Brenneman
The patch also changes _eglDebugReport so that it calls _eglInternalError at the end instead of _eglError. -Kyle On 09/06/2016 01:53 PM, Adam Jackson wrote: On Wed, 2016-07-06 at 10:33 -0600, Kyle Brenneman wrote: @@ -292,6 +292,24 @@ _eglError(EGLint errCode, const char *msg) return

Re: [Mesa-dev] [PATCH 09/10] st/vdpau: implement the new DMA-buf based interop

2016-09-06 Thread Ilia Mirkin
On Tue, Sep 6, 2016 at 2:22 PM, Christian König wrote: > Am 06.09.2016 um 16:23 schrieb Ilia Mirkin: >> >> On Mon, Sep 5, 2016 at 2:48 AM, Michel Dänzer wrote: >>> >>> On 05/09/16 04:37 AM, Ilia Mirkin wrote: On Tue, Mar 8, 2016 at 7:21 AM,

Re: [Mesa-dev] [PATCH 4/6] EGL: Call the EGL_KHR_debug callback on errors.

2016-09-06 Thread Adam Jackson
On Wed, 2016-07-06 at 10:33 -0600, Kyle Brenneman wrote: > @@ -292,6 +292,24 @@ _eglError(EGLint errCode, const char *msg) > return EGL_FALSE; >  } >   > +EGLBoolean > +_eglError(EGLint errCode, const char *msg) > +{ > +   if (errCode != EGL_SUCCESS) { > +  EGLint type; > +  if

Re: [Mesa-dev] [PATCH 07/12] i965/blorp: Instruct vertex fetcher to provide prim instance id

2016-09-06 Thread Kristian Høgsberg
On Thu, Sep 1, 2016 at 8:43 AM, Jason Ekstrand wrote: > On Aug 31, 2016 9:06 AM, "Topi Pohjolainen" > wrote: >> >> This will indicate target layer (Render Target Array Index) needed >> for layered clears. >> >> v2: Use 3DSTATE_VF_SGVS for gen8+

[Mesa-dev] [Bug 96770] include/GL/mesa_glinterop.h:62: error: redefinition of typedef ‘GLXContext’

2016-09-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=96770 --- Comment #2 from Vinson Lee --- (In reply to Emil Velikov from comment #1) > Yay, I broke things ;-) > > There's a couple of routes we can take: > - Bring back the EGL/GLX includes - I would strongly advice against

Re: [Mesa-dev] [PATCH] mapi: add gl32.h to the list of GLES3 headers for installation

2016-09-06 Thread Mark Janes
Reviewed-by: Mark Janes Tested-by: Mark Janes Ilia Mirkin writes: > This was missed when I added the updated (and new) Khronos headers. > > Signed-off-by: Ilia Mirkin > --- > src/mapi/Makefile.am | 1

Re: [Mesa-dev] [PATCH 1/2] st/va: enable dual instances encode by sync surface

2016-09-06 Thread Mark Thompson
Hi, This patch (applied as ) changes the meaning of vaSyncSurface() in a way I don't think is quite right. The way it is implemented appears to make vaSyncSurface() mean "given a surface with an

[Mesa-dev] [PATCH 2/3] nir/spirv: Use the correct sources for CompareExchange on images

2016-09-06 Thread Jason Ekstrand
The CompareExchange operation has two "Memory Semantics" parameters instead of one so the real arguments start at w[7] instead of w[6]. Signed-off-by: Jason Ekstrand Cc: "12.0" --- src/compiler/spirv/spirv_to_nir.c | 4 ++-- 1 file

[Mesa-dev] [PATCH 1/3] nir/spirv: Swap the argument order for AtomicCompareExchange

2016-09-06 Thread Jason Ekstrand
SPIR-V has the two arguments in the opposite order from GLSL. NIR uses the GLSL order so we had them backwards. Fixes dEQP-VK.spirv_assembly.instruction.compute.opatomic.compex Signed-off-by: Jason Ekstrand Cc: "12.0" ---

[Mesa-dev] [PATCH 3/3] nir/spirv: Use fill_common_atomic_sources for image atomics

2016-09-06 Thread Jason Ekstrand
We had two almost identical copies of this code and they were both broken but in different ways. The previous two commits fixed both of them. This one just unifies them so that it's easier to handle in the future. Signed-off-by: Jason Ekstrand ---

Re: [Mesa-dev] [PATCH] glsl: Add a citation for uniform precision matching.

2016-09-06 Thread Kenneth Graunke
On Tuesday, September 6, 2016 1:04:43 PM PDT Eric Anholt wrote: > Kenneth Graunke writes: > > > Ian added this check in commit 259fc505454ea6a67aeacf6cdebf1398d9947759. > > While reviewing the rules, I found a citation which spells this out > > clearly, so I figured I'd

[Mesa-dev] [PATCH] gbm: fix potential NULL deref of mapImage/unmapImage.

2016-09-06 Thread Chuanbo Weng
The mapImage/unmapImage functions of DRIimage extension can be NULL, so we should add additional check for them. Cc: Signed-off-by: Chuanbo Weng --- src/gbm/backends/dri/gbm_dri.c | 5 +++-- 1 file changed, 3 insertions(+), 2

Re: [Mesa-dev] [Mesa-stable] [PATCH] gbm: fix potential NULL deref of mapImage/unmapImage.

2016-09-06 Thread Weng, Chuanbo
Seems the e-mails are blocked before I subscribe mesa-stable. So after I subscribe mesa-stable, this e-mail appears in mesa-dev three times. -Original Message- From: mesa-stable [mailto:mesa-stable-boun...@lists.freedesktop.org] On Behalf Of Chuanbo Weng Sent: Tuesday, September 6, 2016

Re: [Mesa-dev] [PATCH 3/4] radeonsi: add more unlikely() uses into si_draw_vbo

2016-09-06 Thread Michel Dänzer
On 06/09/16 06:04 PM, Marek Olšák wrote: > On Tue, Sep 6, 2016 at 3:54 AM, Michel Dänzer wrote: >> On 06/09/16 07:46 AM, Marek Olšák wrote: >>> From: Marek Olšák >> >> Did you measure any significant performance boost with this change? > > I didn't

Re: [Mesa-dev] [Mesa-stable] [PATCH] gbm: fix potential NULL deref of mapImage/unmapImage.

2016-09-06 Thread Emil Velikov
Hi Chuanbo, On 6 September 2016 at 10:41, Weng, Chuanbo wrote: > Seems the e-mails are blocked before I subscribe mesa-stable. > So after I subscribe mesa-stable, this e-mail appears in mesa-dev three times. > Don't worry too much about things bouncing off mesa-stable.

Re: [Mesa-dev] [Mesa-announce] Mesa 12.0.2 release candidate

2016-09-06 Thread Emil Velikov
On 6 September 2016 at 08:15, Michel Dänzer wrote: > On 02/09/16 06:12 PM, Emil Velikov wrote: >> On 2 September 2016 at 03:26, Michel Dänzer wrote: >>> On 01/09/16 11:25 PM, Emil Velikov wrote: Hello list, The candidate for the Mesa 12.0.2

Re: [Mesa-dev] [PATCH 3/4] radeonsi: add more unlikely() uses into si_draw_vbo

2016-09-06 Thread Rob Clark
On Tue, Sep 6, 2016 at 8:23 PM, Michel Dänzer wrote: > On 06/09/16 08:33 PM, Marek Olšák wrote: >> On Sep 6, 2016 12:03 PM, "Michel Dänzer" > > wrote: >>> On 06/09/16 06:04 PM, Marek Olšák wrote: >>> > On Tue, Sep 6, 2016 at 3:54

[Mesa-dev] [PATCH] misc: move some member init into constructor initialisation lists

2016-09-06 Thread Jeremy Newton
This patch moves some member init into the class constructor initialisation lists. Rational: somewhat cleaner, better style, and considered to produce better performance. Note that I'm not exactly familiar with the patch submission project, or how to respond to mailing list threads. So, I

Re: [Mesa-dev] [PATCH] spirv/nir: Add support for OpAtomicLoad/Store

2016-09-06 Thread Jason Ekstrand
Wow, that was rather annoying... Still, I haven't got much better. Reviewed-by: Jason Ekstrand On Tue, Sep 6, 2016 at 1:44 PM, Lionel Landwerlin wrote: > Fixes new CTS tests : > > dEQP-VK.spirv_assembly.instruction.compute.opatomic.load >

Re: [Mesa-dev] [Piglit] Black screen / hang in piglit's spec@ext_texture_lod_bias@lodbias test on radionsi with ubuntu 16.04

2016-09-06 Thread Dan Kegel
Thanks, sorry for the noise. Filed https://bugs.freedesktop.org/show_bug.cgi?id=97618 - Dan On Tue, Sep 6, 2016 at 2:12 PM, Ilia Mirkin wrote: > [-piglit,+mesa-dev] > > On Tue, Sep 6, 2016 at 5:03 PM, Dan Kegel wrote: >> Hi all, >> happily running piglit

  1   2   >