Re: [Mesa-dev] [PATCH] [rfc] radv: add initial prime support.

2016-11-23 6:28 GMT+01:00 Dave Airlie : > From: Dave Airlie > > This is kind of a gross hacks, but vulkan doesn't specify anything > but it would be nice to let people with prime systems at least > see some stuff rendering for now. > > This creates a linear

[Mesa-dev] [PATCH] radv/si: fix optimal micro tile selection

From: Dave Airlie The same fix was posted for radeonsi, so port it here. Signed-off-by: Dave Airlie --- src/amd/vulkan/radv_image.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/src/amd/vulkan/radv_image.c

Re: [Mesa-dev] [PATCH 2/6] intel/blorp_blit: Split blorp blits if they are too large

On Tue, Nov 22, 2016 at 7:03 PM, Jordan Justen wrote: > We rename do_blorp_blit() to try_blorp_blit(), and add a return error > if the surface size for the blit is too large. Now, do_blorp_blit() is > rewritten to try to split the blit into smaller operations if >

[Mesa-dev] [PATCH 1/5] radv: add support for anisotropic filtering on SI-CI

Ported from radeonsi. Note that si_make_texture_descriptor() already sets img7 to the mask value referred to in the comment. --- src/amd/common/ac_nir_to_llvm.c | 31 +++ src/amd/vulkan/radv_device.c| 11 ++- 2 files changed, 33 insertions(+), 9

[Mesa-dev] [PATCH 2/5] radv: add support for VK_KHR_sampler_mirror_clamp_to_edge

radv_tex_wrap() already supports VK_SAMPLER_ADDRESS_MODE_MIRROR_CLAMP_TO_EDGE, so all that's needed is to advertise support for the extension. --- src/amd/vulkan/radv_device.c | 4 1 file changed, 4 insertions(+) diff --git a/src/amd/vulkan/radv_device.c b/src/amd/vulkan/radv_device.c index

Re: [Mesa-dev] [PATCH] radv: Don't generate radv_timestamp.h

On 24 November 2016 at 05:07, Bas Nieuwenhuizen wrote: > Not needed anymore. > > Signed-off-by: Bas Nieuwenhuizen Reviewed-by: Dave Airlie ___ mesa-dev mailing list

[Mesa-dev] [PATCH] radv: enable sample shading

From: Dave Airlie This calculates ps_iter_samples from the minSampleShading input Signed-off-by: Dave Airlie --- src/amd/vulkan/radv_device.c | 2 +- src/amd/vulkan/radv_pipeline.c | 6 -- 2 files changed, 5 insertions(+), 3 deletions(-) diff

Re: [Mesa-dev] [PATCH 4/4] swr: clear every layer of the attached surfaces

On Wed, Nov 23, 2016 at 3:32 PM, Rowley, Timothy O wrote: > Ah, didn’t notice that they were all shifted by arrayIndex. Fine to leave > the changes as they are, then. > > This series of four patches (or rather, the rebased versions in your repo) > are Reviewed-by: Tim

Re: [Mesa-dev] [PATCH] util: fix memory leak from the fragment shaders for SINT <-> UINT blits

Looks good. Reviewed-by: Brian Paul On Wed, Nov 23, 2016 at 6:33 PM, Charmaine Lee wrote: > This patch deletes those fragment shaders in util_blitter_destroy(). > --- > src/gallium/auxiliary/util/u_blitter.c | 2 +- > 1 file changed, 1 insertion(+),

[Mesa-dev] [PATCH 3/5] radv: add support for VK_AMD_negative_viewport_height

The driver already supports this extension in practice. --- src/amd/vulkan/radv_device.c | 4 1 file changed, 4 insertions(+) diff --git a/src/amd/vulkan/radv_device.c b/src/amd/vulkan/radv_device.c index 0d79eee..58484bd 100644 --- a/src/amd/vulkan/radv_device.c +++

[Mesa-dev] [PATCH 5/5] radv: use the marketing name in the deviceName string

This bumps the libdrm requirement to 2.4.72. --- configure.ac | 2 +- src/amd/vulkan/radv_radeon_winsys.h | 2 +- src/amd/vulkan/winsys/amdgpu/radv_amdgpu_winsys.c | 43 +-- 3 files changed, 26 insertions(+), 21 deletions(-)

[Mesa-dev] [PATCH 4/5] radv: add support for VK_AMD_draw_indirect_count

--- src/amd/vulkan/radv_cmd_buffer.c | 94 ++-- src/amd/vulkan/radv_device.c | 4 ++ 2 files changed, 84 insertions(+), 14 deletions(-) diff --git a/src/amd/vulkan/radv_cmd_buffer.c b/src/amd/vulkan/radv_cmd_buffer.c index 824f9d8..d1e4deb 100644 ---

[Mesa-dev] [PATCH 0/5] Random radv patches

These are some random patches for radv. The first adds support for anisotropic filtering on SI/CIK. Note that this patch has not been tested. Patches 2-4 add support for extensions; two of which are already supported in practice, and one that's trivial to implement. One thing I noticed is that

Re: [Mesa-dev] [PATCH 03/10] dri: extend fence extension to support native fd fences

Patches 1-3 are Reviewed-by: Chad Versace Tested-by: Chad Versace I tested them with Rafael's Piglit tests and my in-flight i965 patches. However, patch 4 causes one of Rafael's tests to segfault. I've replied to patch 4 separately.

[Mesa-dev] [PATCH] util: fix memory leak from the fragment shaders for SINT <-> UINT blits

This patch deletes those fragment shaders in util_blitter_destroy(). --- src/gallium/auxiliary/util/u_blitter.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/auxiliary/util/u_blitter.c b/src/gallium/auxiliary/util/u_blitter.c index 98b5421..45dc033 100644 ---

Re: [Mesa-dev] [PATCH] gdi: Add GALLIUM_TRACE and GALLIUM_RBUG to gdi

> -Original Message- > From: mesa-dev [mailto:mesa-dev-boun...@lists.freedesktop.org] On > Behalf Of Emil Velikov > Sent: Wednesday, November 23, 2016 11:37 AM > To: Kyriazis, George ; Jose Fonseca > > Cc: ML mesa-dev

Re: [Mesa-dev] [PATCH] radv: enable sample shading

On Wed, Nov 23, 2016 at 7:51 PM, Dave Airlie wrote: > From: Dave Airlie > > This calculates ps_iter_samples from the minSampleShading input > > Signed-off-by: Dave Airlie > --- > src/amd/vulkan/radv_device.c | 2 +- >

[Mesa-dev] [PATCH] radv: Simple inter stage shader optimization

Remove vs exports if the ps doesn't use them. Longer term we will probably want to do the optimizations between stages in nir, but this seems simple enough for the short term. Signed-off-by: Bas Nieuwenhuizen --- src/amd/common/ac_nir_to_llvm.c | 3 ++-

[Mesa-dev] [PATCH v2] gbm/drm: Pick the oldest available buffer in get_back_bo

Applications may query the back buffer age to efficiently perform partial updates. Generally the application will keep a fixed length damage history, and use this to calculate what needs to be redrawn based on the age of the back buffer it's about to render to. If presented with a buffer that has

[Mesa-dev] [PATCH 2/2] radv: fix flipped blits

From: Dave Airlie This fixes: dEQP-VK.api.copy_and_blit.blit_image.simple_tests.mirror* Signed-off-by: Dave Airlie --- src/amd/vulkan/radv_meta_blit.c | 168 ++-- 1 file changed, 111 insertions(+), 57 deletions(-)

[Mesa-dev] [PATCH 1/2] radv/meta: just local vars for src/dst subresources.

From: Dave Airlie This is just a cleanup before I rework this code to fix mirrored blits. Signed-off-by: Dave Airlie --- src/amd/vulkan/radv_meta_blit.c | 18 ++ 1 file changed, 10 insertions(+), 8 deletions(-) diff --git

Re: [Mesa-dev] [PATCH] radv/si: fix optimal micro tile selection

Ah yes, Reviewed-by: Edward O'Callaghan On 11/24/2016 11:04 AM, Dave Airlie wrote: > From: Dave Airlie > > The same fix was posted for radeonsi, so port it here. > > Signed-off-by: Dave Airlie > --- >

Re: [Mesa-dev] [PATCH 1/2] radv/meta: just local vars for src/dst subresources.

For the series: Reviewed-by: Bas Nieuwenhuizen On Thu, Nov 24, 2016 at 12:40 AM, Dave Airlie wrote: > From: Dave Airlie > > This is just a cleanup before I rework this code to fix mirrored > blits. > > Signed-off-by: Dave Airlie

[Mesa-dev] [PATCH 2/2] radv: set spi_baryc_cntl.pos_float_location to 0

From: Dave Airlie This fixes: dEQP-VK.pipeline.multisample_interpolation.offset_interpolate_at_sample_position.* This should probably be 2 when sample shading is enabled, but I'm not sure. Signed-off-by: Dave Airlie --- src/amd/vulkan/radv_cmd_buffer.c

[Mesa-dev] [PATCH 1/2] radv: force persample shading when required.

From: Dave Airlie We need to force persample shading when a) shader uses sample_id b) shader uses sample_position c) shader uses sample qualifier. Also since ps_iter_samples can now change independently of the rasterizer samples we need to move setting the regs more often.

Re: [Mesa-dev] [PATCH 04/10] egl: add EGL_ANDROID_native_fence_sync

On Fri 18 Nov 2016, Rob Clark wrote: > From: Rob Clark > > With fixes from Chad squashed in, plus fixes for issues that Rafael > found while writing piglit tests. > > Cc: Chad Versace > Cc: Rafael Antognolli >

Re: [Mesa-dev] [PATCH] i915: Add XRGB8888 format to intel_screen_make_configs

2016-11-24 7:01 GMT+08:00 Derek Foreman : > This is a copy of commit 536003c11e4cb1172c540932ce3cce06f03bf44e > except for i915. > > Original log for the i965 commit follows: > > Some application, such as drm backend of weston, uses XRGB config as > default. i965

[Mesa-dev] [PATCH] anv/gen7: only enable dual-source blending when there are dual-source factors

Apparently the hw wedges otherwise, as mentioned in i965 comments. Reported-by: Emmanuel Gil Peyrot Signed-off-by: Ilia Mirkin --- src/intel/vulkan/genX_pipeline.c | 36 +--- 1 file changed, 33 insertions(+), 3

[Mesa-dev] [PATCH] radv: fix texel fetch offset with 2d arrays.

From: Dave Airlie The code didn't limit the offsets to the number supplied, so if we expected 3 but only got 2 we were accessing undefined memory. This fixes random failures in: dEQP-VK.glsl.texture_functions.texelfetchoffset.sampler2darray_* Signed-off-by: Dave Airlie

Re: [Mesa-dev] [PATCH] radv: fix texel fetch offset with 2d arrays.

Reviewed-by: Bas Nieuwenhuizen On Thu, Nov 24, 2016 at 4:12 AM, Dave Airlie wrote: > From: Dave Airlie > > The code didn't limit the offsets to the number supplied, so > if we expected 3 but only got 2 we were accessing undefined

Re: [Mesa-dev] EGL/android: pbuffer implementation.

On Thu, Nov 24, 2016 at 12:00 PM, Tomasz Figa wrote: > Hi Zhifang, > > On Thu, Nov 24, 2016 at 11:39 AM, Long, Zhifang > wrote: >>> >> > @@ -353,6 +353,18 @@ droid_destroy_surface(_EGLDriver *drv, >>> >> _EGLDisplay *disp, _EGLSurface *surf) >>> >> >

[Mesa-dev] [PATCH 3/4] intel/aubinator: Wait to setup decoders until we parse the aub header

This requires that a few more state bits become global. --- src/intel/tools/aubinator.c | 51 + 1 file changed, 28 insertions(+), 23 deletions(-) diff --git a/src/intel/tools/aubinator.c b/src/intel/tools/aubinator.c index 276ea75..60aead8 100644 ---

[Mesa-dev] [PATCH 4/4] intel/aubinator: Pull useful information from the AUB header

This commit does two things. One is to pull useful and/or interesting information from the AUB file header and display it as a header above your decoded batches. Second, it is now capable of pulling the PCI ID from the AUB file comment left by intel_aubdump. This removes the need to use the

Re: [Mesa-dev] EGL/android: pbuffer implementation.

On Thu, Nov 24, 2016 at 12:18 PM, Long, Zhifang wrote: > Hi Tomasz, > > Got your requirement. So what you want is below behavior : > "droid_image_get_buffers() will not clear image_mask to 0, and only > set the bit when corresponding allocation succeed.

Re: [Mesa-dev] [v2 14/17] i965: Use ISL for CCS layouts

On Wed, Nov 23, 2016 at 01:10:59PM -0800, Jason Ekstrand wrote: >On Wed, Nov 23, 2016 at 1:16 AM, Topi Pohjolainen ><[1]topi.pohjolai...@gmail.com> wrote: > > One can now also delete intel_get_non_msrt_mcs_alignment(). > Signed-off-by: Topi Pohjolainen

[Mesa-dev] [Bug 98842] mesa 13.0.1 build broken under debian8

https://bugs.freedesktop.org/show_bug.cgi?id=98842 Bug ID: 98842 Summary: mesa 13.0.1 build broken under debian8 Product: Mesa Version: 13.0 Hardware: Other OS: All Status: NEW Severity: normal

Re: [Mesa-dev] [v2 11/17] i965: Track fast color clear state in level/layer granularity

On Wed, Nov 23, 2016 at 01:05:31PM -0800, Jason Ekstrand wrote: >On Wed, Nov 23, 2016 at 1:16 AM, Topi Pohjolainen ><[1]topi.pohjolai...@gmail.com> wrote: > > v2: Added intel_resolve_map_clear() into intel_miptree_release() > Signed-off-by: Topi Pohjolainen

Re: [Mesa-dev] EGL/android: pbuffer implementation.

Hi Zhifang, On Thu, Nov 24, 2016 at 11:39 AM, Long, Zhifang wrote: >> >> > @@ -353,6 +353,18 @@ droid_destroy_surface(_EGLDriver *drv, >> >> _EGLDisplay *disp, _EGLSurface *surf) >> >> >dri2_surf->window->common.decRef(_surf->window- >> >common); >> >> > } >>

Re: [Mesa-dev] [v2 08/17] i965: Add plumbing for fast clear layer/level details

On Wed, Nov 23, 2016 at 01:21:07PM -0800, Jason Ekstrand wrote: >On Wed, Nov 23, 2016 at 1:16 AM, Topi Pohjolainen ><[1]topi.pohjolai...@gmail.com> wrote: > > Until now fast clear has been supported only for non-layered and > non-mipmapped buffers. However, from gen8 onwards

[Mesa-dev] [st/omx/dec/h264] Handing negative POC

Hi , I have been working on an issue where the for a particular stream playback is stuttering and there are lot of frame drops. That particular stream has negative POC value and as POC value is treated/read as unsigned, the frame is getting flushed out of DBP at the end of GOP instead of at

Re: [Mesa-dev] [PATCH] i915: Add XRGB8888 format to intel_screen_make_configs

2016-11-24 13:29 GMT+08:00 Derek Foreman : > On 23/11/16 07:18 PM, Boyan Ding wrote: >> >> 2016-11-24 7:01 GMT+08:00 Derek Foreman : >>> >>> This is a copy of commit 536003c11e4cb1172c540932ce3cce06f03bf44e >>> except for i915. >>> >>> Original log

[Mesa-dev] [Bug 98714] Weird whitish spots and green stuff mostly on black.

https://bugs.freedesktop.org/show_bug.cgi?id=98714 --- Comment #3 from langk...@tomblog.de --- Same here with cities skylines launched from steam on opensuse tumbleweed with pontostroys mesa llvm git repo (Mesa-13.1~git20161122 x64, kde, amd fury x, amd fx 8350) it did not depend on the ingame

Re: [Mesa-dev] [PATCH] i915: Add XRGB8888 format to intel_screen_make_configs

On 23/11/16 07:18 PM, Boyan Ding wrote: 2016-11-24 7:01 GMT+08:00 Derek Foreman : This is a copy of commit 536003c11e4cb1172c540932ce3cce06f03bf44e except for i915. Original log for the i965 commit follows: Some application, such as drm backend of weston, uses

[Mesa-dev] [Bug 98714] Weird whitish spots and green stuff mostly on black.

https://bugs.freedesktop.org/show_bug.cgi?id=98714 --- Comment #4 from langk...@tomblog.de --- Created attachment 128176 --> https://bugs.freedesktop.org/attachment.cgi?id=128176=edit screenshot cities skylines -- You are receiving this mail because: You are the assignee for the bug. You are

[Mesa-dev] [Bug 98714] Weird whitish spots and green stuff mostly on black.

https://bugs.freedesktop.org/show_bug.cgi?id=98714 --- Comment #5 from langk...@tomblog.de --- Comment on attachment 128176 --> https://bugs.freedesktop.org/attachment.cgi?id=128176 screenshot cities skylines where now is white used to be walking citizens... -- You are receiving this mail

Re: [Mesa-dev] EGL/android: pbuffer implementation.

Hi Tomasz, Got your requirement. So what you want is below behavior : "droid_image_get_buffers() will not clear image_mask to 0, and only set the bit when corresponding allocation succeed. If some bit is not support, just silently ignore instead of directly

[Mesa-dev] [PATCH 2/3] aubdump: Set the application name

This will help with identifying aub files --- tools/aubdump.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/tools/aubdump.c b/tools/aubdump.c index b1c46e2..b207aef 100644 --- a/tools/aubdump.c +++ b/tools/aubdump.c @@ -184,14 +184,18 @@ gtt_size(void) static void

[Mesa-dev] [PATCH 3/3] aubdump: Add a PCI-ID= entry to the AUB file comment

--- tools/aubdump.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/tools/aubdump.c b/tools/aubdump.c index b207aef..6715a5d 100644 --- a/tools/aubdump.c +++ b/tools/aubdump.c @@ -185,10 +185,16 @@ static void write_header(void) { char app_name[8 * 4]; +

[Mesa-dev] [PATCH 1/3] Revert "aubdump: Bump the GTT size to 256MB"

This reverts commit c6191a41f6c858cbdd4280e9ffcc91170e87ebeb. It turns out that having a GTT that large causes the simulator massive headaches. --- tools/aubdump.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tools/aubdump.c b/tools/aubdump.c index 8904255..b1c46e2

[Mesa-dev] [PATCH 1/4] intel/aubinator: Trust the packet size in the header for SUBOPCODE_HEADER

We were reading from the "comment size" dword and incrementing by that amount. This never caused a problem because that field was always zero. However, experimenting with actual aub file comments indicates, the simulator seems to include the comment size in the packet size provided in the header.

[Mesa-dev] [PATCH 2/4] intel/aubinator: Rework handling of the --gen flag

This makes it just store the pci_id instead of a struct pointer --- src/intel/tools/aubinator.c | 36 1 file changed, 16 insertions(+), 20 deletions(-) diff --git a/src/intel/tools/aubinator.c b/src/intel/tools/aubinator.c index abade45..276ea75 100644 ---

Re: [Mesa-dev] [PATCH 1/2] radeonsi: add a debug flag that disables optimized shader variants

Thanks for this. The series is Reviewed-by: Nicolai Hähnle On 21.11.2016 22:41, Marek Olšák wrote: From: Marek Olšák --- src/gallium/drivers/radeon/r600_pipe_common.c | 1 + src/gallium/drivers/radeon/r600_pipe_common.h | 1 +

[Mesa-dev] [v2 12/17] i965: Restrict fast color clear on first slice only

Signed-off-by: Topi Pohjolainen Reviewed-by: Jason Ekstrand --- src/mesa/drivers/dri/i965/brw_blorp.c | 8 1 file changed, 8 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_blorp.c b/src/mesa/drivers/dri/i965/brw_blorp.c

[Mesa-dev] [v2 09/17] i965: Refactor check if color resolve is needed

Signed-off-by: Topi Pohjolainen Reviewed-by: Jason Ekstrand --- src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 43 +-- 1 file changed, 27 insertions(+), 16 deletions(-) diff --git

[Mesa-dev] [v2 17/17] i965: Enable fast clears for multi-lod

From: Ben Widawsky On SKL (also fast clear is used for level 0, layer 0): Manhattan 3.0: 3.88434% +/- 0.814659% Manhattan 3.0 off: 3.25542% +/- 0.101149% Trex: 3.43501% +/- 0.31223% Trex off: 4.13781% +/- 0.0993569% ON BDW:

[Mesa-dev] [v2 07/17] i965: Add interface for checking multiple slices if any is unresolved

Signed-off-by: Topi Pohjolainen Reviewed-by: Jason Ekstrand --- src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 8 src/mesa/drivers/dri/i965/intel_mipmap_tree.h | 5 + 2 files changed, 13 insertions(+) diff --git

[Mesa-dev] [v2 13/17] i965: Resolve non-compressed fast clears prior layered rendering

Signed-off-by: Topi Pohjolainen Reviewed-by: Jason Ekstrand --- src/mesa/drivers/dri/i965/brw_draw.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_draw.c

[Mesa-dev] [v2 04/17] i965: Provide slice details to color resolver

Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/brw_blorp.c | 15 +-- src/mesa/drivers/dri/i965/brw_blorp.h | 3 ++- src/mesa/drivers/dri/i965/brw_context.c | 14 +- src/mesa/drivers/dri/i965/intel_blit.c

[Mesa-dev] [v2 15/17] i965/gen8: Relax asserts prohibiting arrayed/mipmapped fast clears

Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/brw_blorp.c | 4 ++-- src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 23 +-- src/mesa/drivers/dri/i965/intel_mipmap_tree.h | 3 ++- 3 files changed, 17 insertions(+), 13

[Mesa-dev] [v2 16/17] i965: Allow single-sampled miptree to be resolved and shared

Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/intel_mipmap_tree.c b/src/mesa/drivers/dri/i965/intel_mipmap_tree.c index 1c8ce0d..d943f04

Re: [Mesa-dev] [PATCH] [rfc] radv: add initial prime support.

You are a star :D I'll test this out tonight On Wed, 23 Nov 2016 at 05:29 Dave Airlie wrote: > From: Dave Airlie > > This is kind of a gross hacks, but vulkan doesn't specify anything > but it would be nice to let people with prime systems at least > see

Re: [Mesa-dev] [PATCH] [rfc] radv: add initial prime support.

I think it would be good to keep the DRI_PRIME switch to allow for switching between anvil and radv, handy for testing / comparing / benchmarking both It seems that Vulkan automatically uses the first card listed in vulkaninfo (in my case it's the amdgpu card) with no way to select which is used,

[Mesa-dev] [v2 06/17] i965: Provide slice details to renderbuffer fast clear state tracker

This patch also introduces getter and setter for fast clear state preparing for tracking the state per slice. Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/brw_blorp.c | 3 +- src/mesa/drivers/dri/i965/brw_draw.c | 10 +++---

[Mesa-dev] [v2 14/17] i965: Use ISL for CCS layouts

One can now also delete intel_get_non_msrt_mcs_alignment(). Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 138 +++--- src/mesa/drivers/dri/i965/intel_mipmap_tree.h | 4 - 2 files changed, 38 insertions(+),

[Mesa-dev] [v2 02/17] i965/blorp: Skip redundant re-fast clear for non-compressed

Originally re-clears where skipped but when lossless compression was introduced the re-clears where errorneously enabled also for non-compressed fast clears. Signed-off-by: Topi Pohjolainen CC: Ben Widawsky CC: Kenneth Graunke

[Mesa-dev] [v2 10/17] i965: Move fast clear state enumeration into resolve map

Status is still tracked per miptree. Next patch will switch to resolve map per slice/level. Signed-off-by: Topi Pohjolainen Reviewed-by: Jason Ekstrand --- src/mesa/drivers/dri/i965/intel_mipmap_tree.h | 58 --

[Mesa-dev] [v2 01/17] i965: Refactor lossless compression state tracking

Essentially this moves fast clear state update away from surface state setup into brw_postdraw_set_buffers_need_resolve() that gets called just after draw submission. Calling intel_miptree_used_for_rendering() can be drop for gen6 and earlier as it is no-op. v2: Rebased on top current master

[Mesa-dev] [v2 05/17] i965: Split per miptree and per slice/level fast clear bits

Currently the status bits for fast clear include the flag telling if non-multisampled mcs buffer should be used at all. Once the state tracking is changed to follow individual levels/layers one still needs to have the mcs enabling information in the miptree. Therefore simply split it out to its

[Mesa-dev] [v2 11/17] i965: Track fast color clear state in level/layer granularity

v2: Added intel_resolve_map_clear() into intel_miptree_release() Signed-off-by: Topi Pohjolainen Reviewed-by: Jason Ekstrand (v1) --- src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 64 +++

[Mesa-dev] [v2] i965: Fast color clear for mipmapped and arrayed

This is a rebase on top recent changes by Jason and Lionel. While things have changed quite a bit in some of the patches they have mostly become clearer. Ben Widawsky (1): i965: Enable fast clears for multi-lod Topi Pohjolainen (16): i965: Refactor lossless compression state tracking

[Mesa-dev] [v2 08/17] i965: Add plumbing for fast clear layer/level details

Until now fast clear has been supported only for non-layered and non-mipmapped buffers. However, from gen8 onwards there is hardware support also for layered/mipmapped. Once this is enabled, fast clear operations target specific layer/level and call for the state to be tracked in the same

[Mesa-dev] [v2 03/17] i965: Add new interface for full color resolves

Upcoming patches will introduce fast clear in level/layer granularity like the driver does already for depth/hiz. This patch introduces equivalent full resolve option. Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/brw_context.c| 6 +++---

Re: [Mesa-dev] [PATCH 3/4] glsl: add gl_linked_shader::SourceChecksum

On 22.11.2016 02:20, Marek Olšák wrote: From: Marek Olšák for debugging --- src/compiler/glsl/linker.cpp | 8 src/mesa/main/mtypes.h | 1 + 2 files changed, 9 insertions(+) diff --git a/src/compiler/glsl/linker.cpp b/src/compiler/glsl/linker.cpp index

Re: [Mesa-dev] [PATCH] [rfc] radv: add initial prime support.

On 23.11.2016 06:28, Dave Airlie wrote: From: Dave Airlie This is kind of a gross hacks, but vulkan doesn't specify anything but it would be nice to let people with prime systems at least see some stuff rendering for now. This creates a linear shadow image in GART that

[Mesa-dev] [PATCH 02/14] glsl: merge layouts into the default one as the last step in interface blocks

Consider this example: " #version 150 core #extension GL_ARB_shading_language_420pack: require #extension GL_ARB_explicit_attrib_location: require layout(location=0) out vec4 o; layout(binding=2) layout(binding=3, std140) uniform U { vec4 a; } u[2];"

[Mesa-dev] [PATCH v5 00/14] deal with multiple appearances of the same layout-qualifier-name in a single declaration

In the case of layout-qualifier-names that can appear multiple times in different declarations of the same shader or, even, the same program, but that have to consistently hold the same value we are using the ast_layout_expression class which holds a list to store all the appearances to be able to

[Mesa-dev] [PATCH 07/14] glsl: assert on incoherent point mode layout-id-qualifier validation

The point mode value in an ast_type_qualifier can only be true if the flag is already set since this layout-id-qualifier can only be or not be present in a shader. Hence, it is useless to check for its value if the flag is already set. Just replaced with an assert. V2: assert instead of checking

[Mesa-dev] [PATCH 06/14] glsl: remove unneeded check for incompatible primitive types in GS

The validation of the default in layout qualifier already assures that we won't have 2 ast_gs_input_layout objects with different primitive type values. In fact, the validation already assures that we won't have 2 ast_gs_input_layout objects in the AST tree at all. The check for an error in the

[Mesa-dev] [PATCH 01/14] glsl: ignore all but the rightmost layout-qualifier-name

When a layout contains a duplicated layout-qualifier-name in a single declaration, only the last occurrence should be taken into account. From page 59 (page 65 of the PDF) of the GLSL 4.40 spec: " More than one layout qualifier may appear in a single declaration. Additionally, the same

[Mesa-dev] [PATCH 12/14] glsl: push layout-qualifier-name values from variable declarations to global

After the previous modifications in the merging of the layout-qualifier-name values, we no longer push the final value in a declaration to the global values. This regression happens because we don't call for merging on the right-most layout qualifier of a declaration which is also the overriding

[Mesa-dev] [PATCH 09/14] glsl: ignore all but the rightmost layout qualifier name from the rightmost layout qualifier

From page 46 (page 52 of the PDF) of the GLSL 4.20 spec: " More than one layout qualifier may appear in a single declaration. If the same layout-qualifier-name occurs in multiple layout qualifiers for the same declaration, the last one overrides the former ones." Consider this

[Mesa-dev] [PATCH 11/14] glsl: simplified error checking for duplicated layout-qualifiers

The GLSL parser has been simplified to check for the needed GL_ARB_shading_language_420pack extension just when merging the qualifiers in the proper cases. Reviewed-by: Timothy Arceri Signed-off-by: Andres Gomez ---

[Mesa-dev] [PATCH 13/14] Revert "glsl: geom shader max_vertices layout must match."

This reverts commit 4c863993780a11cea6f88fa0682796bee5794042. The commit was erroneous because the ast_layout_expression class was created to hold a list of values for a layout-qualifier-name which is allowed to appear in more than one expression in the same shader/program but not to hold

[Mesa-dev] [Bug 98831] Constantly increasing memory consumption in JavaFX applications

https://bugs.freedesktop.org/show_bug.cgi?id=98831 Bug ID: 98831 Summary: Constantly increasing memory consumption in JavaFX applications Product: Mesa Version: 12.0 Hardware: x86-64 (AMD64) OS: Linux (All)

Re: [Mesa-dev] [PATCH] glsl: Do not allow scalar types in vector relational functions

2016-11-07 20:27 GMT+08:00 Boyan Ding : > 2016-11-05 3:23 GMT+08:00 Matt Turner : >> On Sun, Oct 30, 2016 at 11:45 PM, Boyan Ding wrote: >>> According to OpenGL Shading Language 4.50 spec, Section 8.7 "Vector >>> Relational

[Mesa-dev] [PATCH 10/14] glsl: simplified ast_type_qualifier::merge_into_[in|out]_qualifier API

Since we modified the way in which multiple repetitions of the same layout-qualifier-name in a single declaration collapse into the ast_type_qualifier class, we can simplify the merge_into_[in|out]_qualifier APIs through removing the create_node parameter. Reviewed-by: Timothy Arceri

[Mesa-dev] [PATCH 08/14] glsl: refactor duplicated validations between 2 layout-qualifiers

Several layout-qualifier validations are duplicated in the merge_qualifier and validate_in_qualifier methods. We would rather have them refactored into single calls. Suggested by Timothy. Signed-off-by: Andres Gomez --- src/compiler/glsl/ast_type.cpp | 126

[Mesa-dev] [PATCH 04/14] glsl: split default in layout qualifier merge

Currently, the default in layout qualifier merge performs specific validation and merge. We want to split out the validation from the merge so they can be done independently. Additionally, for simplification, the direction of the validation and merge is changed so the ast_type_qualifier calling

[Mesa-dev] [PATCH 14/14] Revert "glsl: allow layout qualifier overrides with ARB_shading_language_420pack"

This reverts commit aaa69c79cd584db4d9c6ea7794e93d29f3d54572. The commit was erroneous because the ast_layout_expression class is meant to hold a list used for an after check that all the declared values for a layout-qualifier-name are consistent. Therefore, the check for the possibility of

[Mesa-dev] [PATCH 05/14] glsl: simplifies the merge of the default in layout qualifier

The merge into the default in layout qualifier duplicates a lot of code that can be reused from the generic merge method. Now, we use the generic merge method inside the specific merge for the default in layout qualifier. The generic merge method has been completed with some bits that were only

[Mesa-dev] [PATCH 03/14] glsl: split default out layout qualifier merge

Currently, the default out layout qualifier merge performs specific validation and merge. We want to split out the validation from the merge so they can be done independently. Additionally, for simplification, the direction of the validation and merge is changed so the ast_type_qualifier calling

Re: [Mesa-dev] [PATCH] scons: Recognize LLVM_CONFIG environment variable.

On 23 November 2016 at 01:23, Vinson Lee wrote: > Signed-off-by: Vinson Lee > --- > scons/llvm.py | 19 --- > 1 file changed, 12 insertions(+), 7 deletions(-) > > diff --git a/scons/llvm.py b/scons/llvm.py > index 977e47a..a27bf00

[Mesa-dev] [Bug 98831] Constantly increasing memory consumption in JavaFX applications

https://bugs.freedesktop.org/show_bug.cgi?id=98831 Itai changed: What|Removed |Added Attachment #128164|0 |1 is obsolete|

[Mesa-dev] [Bug 98831] Constantly increasing memory consumption in JavaFX applications

https://bugs.freedesktop.org/show_bug.cgi?id=98831 --- Comment #2 from Eero Tamminen --- Thanks for the bug! Which HW you have / with which Mesa drivers you tried this (Nouveau? Intel i965? swrast?)? Did it happen both with SW rendering & HW rendering? >

[Mesa-dev] [Bug 98831] Constantly increasing memory consumption in JavaFX applications

https://bugs.freedesktop.org/show_bug.cgi?id=98831 --- Comment #3 from Itai --- I'm running on Intel HD4000 graphics (i5-3210M integrated GPU). I believe I'm using the i965 driver, or whatever is the default on Debian systems. Here are what I believe to be the relevant lines

[Mesa-dev] [Bug 98831] Constantly increasing memory consumption in JavaFX applications

https://bugs.freedesktop.org/show_bug.cgi?id=98831 --- Comment #4 from Itai --- Replaying with Apitrace does not exhibit the problem. Additionally, it seems to perform altogether much better, hardly taxing my CPU, while the original seems to constantly use up a whole core

Re: [Mesa-dev] [PATCH v4 09/10] gallium: swr: Added swr build for windows

On Wed, Nov 23, 2016 at 10:20 AM, Kyriazis, George wrote: > Thanks Emil, > > One thing that I am clear about is: what is the difference between > Reviewed-by:, Acked-by:, etc. It sounds like they do the same thing, however > in the documentation they are worded as if

Re: [Mesa-dev] [PATCH] anv: fix enumeration of properties

On 23 November 2016 at 07:51, Iago Toral wrote: > Hey Emil, > > On Thu, 2016-10-06 at 14:12 +0100, Emil Velikov wrote: >> From: Emil Velikov >> >> Driver should enumerate only up-to min2(num_available, num_requested) >> properties and return

Re: [Mesa-dev] [PATCH v4 09/10] gallium: swr: Added swr build for windows

Thanks Emil, One thing that I am clear about is: what is the difference between Reviewed-by:, Acked-by:, etc. It sounds like they do the same thing, however in the documentation they are worded as if they mean different things. I will also suggest some edits and send out a diff for review.

Re: [Mesa-dev] [PATCH v4 09/10] gallium: swr: Added swr build for windows

> -Original Message- > From: mesa-dev [mailto:mesa-dev-boun...@lists.freedesktop.org] On > Behalf Of Emil Velikov > Sent: Wednesday, November 23, 2016 10:02 AM > To: Ilia Mirkin > Cc: Kyriazis, George ; ML mesa-dev

  1   2   >