Re: [Mesa-dev] [PATCH] mesa: Require mipmap completeness for glCopyImageSubData(), sometimes.

On Monday, February 27, 2017 4:54:37 AM PST Kenneth Graunke wrote: > This patch makes glCopyImageSubData require mipmap completeness when the > texture object's built-in sampler object has a mipmapping MinFilter. > > Fixes (on i965): >

Re: [Mesa-dev] [PATCH 2/2] ralloc: Delete autofree handling.

For the series: Reviewed-by: Marek Olšák Marek On Mon, Feb 27, 2017 at 1:23 PM, Kenneth Graunke wrote: > There was exactly one user of this, and I just removed it. > > It also accessed an implicit global context, with no locking. This > meant that

Re: [Mesa-dev] [PATCH mesa] egl/dri3: implement query surface hook

On 27 February 2017 at 05:53, Tapani Pälli wrote: This is a DRI3 version of a change made for DRI2 (4d6d4f939e0af4252e0b, "egl/dri2: implement query surface hook"), that fixed failures in dEQP-EGL.functional.resize.surface_size.grow and

Re: [Mesa-dev] [PATCH 2/2] gallium/u_queue: set num_threads correctly if not all threads start

Pushed the series. Thanks. Marek On Sun, Feb 26, 2017 at 1:44 AM, Grazvydas Ignotas wrote: > If i-th thread could not be created it means we have i threads, > not i+1, because we start from 0. > > Fixes: 404d0d5 "gallium/u_queue: add an option to have multiple worker >

[Mesa-dev] [Bug 99987] Mesa 13+ breaks Xvnc (and similar X servers)

https://bugs.freedesktop.org/show_bug.cgi?id=99987 Bug ID: 99987 Summary: Mesa 13+ breaks Xvnc (and similar X servers) Product: Mesa Version: unspecified Hardware: Other OS: All Status: NEW Severity:

Re: [Mesa-dev] [PATCH] nir: Delete unused arg in get_iteration

Some1 to review this patch? On 21/02/17 16:15, Elie Tournier wrote: nir_const_value is not needed in get_iteration Oops typo: nir_alu_instr is not needed in get_iteration Signed-off-by: Elie Tournier --- I don't have the git access. Please push it for me. BR, Elie

Re: [Mesa-dev] [PATCH 1/2] radeonsi: add support for an on-disk shader cache

On Mon, Feb 27, 2017 at 10:57 AM, Michel Dänzer wrote: > On 25/02/17 01:56 PM, Timothy Arceri wrote: >> On 24/02/17 21:02, Marek Olšák wrote: >>> On Fri, Feb 24, 2017 at 3:18 AM, Timothy Arceri >>> wrote: On 24/02/17 08:49, Timothy Arceri wrote:

[Mesa-dev] [PATCH] anv: add support for allocating more than 1 block of memory

Current Anv allocator assign memory in terms of a fixed block size. But there can be cases where this block is not enough for a memory request, and thus several blocks must be assigned in a row. This commit adds support for specifying how many blocks of memory must be assigned. This fixes a

Re: [Mesa-dev] [PATCH] r600: add amdgpuinfo to the llvm required module list

On Mon, 2017-02-27 at 12:54 +0100, Marc Dietrich wrote: > This fixes the build when mesa is build against a static libllvm and > consolidates the module collection a bit. > > Signed-off-by: Marc Dietrich > --- > configure.ac | 7 +++ > 1 file changed, 3 insertions(+), 4

[Mesa-dev] [PATCH 2/2] ralloc: Delete autofree handling.

There was exactly one user of this, and I just removed it. It also accessed an implicit global context, with no locking. This meant that it was only safe if all callers of ralloc_autofree_context() held the same lock...which is a pretty terrible thing for a utility library to impose.

[Mesa-dev] [PATCH 1/2] compiler: Free types in _mesa_glsl_release_types() rather than autofree.

Instead of using ralloc_autofree_context() to install an atexit() handler to ralloc_free(glsl_type::mem_ctx), we can simply free them from _mesa_glsl_release_types(). This is effectively the same, because _mesa_glsl_release_types() is called from _mesa_destroy_shader_compiler(), which is called

Re: [Mesa-dev] [PATCH 1/2] radeonsi: add support for an on-disk shader cache

Notice that git worries about collisions between the 7 char abbreviated sha1s in large repositories, and sometime have to use 10 or 12 chars, etc: https://github.com/blog/2288-git-2-11-has-been-released "This is exactly what happened in the Linux kernel repository; it now has over 5 million

[Mesa-dev] [PATCH] r600: add amdgpuinfo to the llvm required module list

This fixes the build when mesa is build against a static libllvm and consolidates the module collection a bit. Signed-off-by: Marc Dietrich --- configure.ac | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/configure.ac b/configure.ac index

Re: [Mesa-dev] question about container_of

Hi Julien, On 27 February 2017 at 12:08, Julien Isorce wrote: > Hi, > > Since 2012 commit ccff74971203b533bf16b46b49a9e61753f75e6c it is said: > "sample must be initialized, or else the result is undefined" in the > description of mesa/src/util/list.h::container_of . > >

Re: [Mesa-dev] [PATCH 0/6] r600g: r600_shader.c small cleanups

All r600g commits should have the "r600g:" prefix. Marek On Sun, Feb 26, 2017 at 9:31 PM, Constantine Charlamov wrote: > Initially I was trying to implement for r600 optimization like in the > d633e23192ef17207f4a6acd3009da3126aab395 commit for radeonsi, but failed >

Re: [Mesa-dev] [PATCH 1/2] compiler: Free types in _mesa_glsl_release_types() rather than autofree.

Does this fix the double free issue I've been seeing in shader-db? Regardless : Reviewed-by: Lionel Landwerlin On 27/02/17 12:23, Kenneth Graunke wrote: Instead of using ralloc_autofree_context() to install an atexit() handler to

Re: [Mesa-dev] [PATCH 2/2] ralloc: Delete autofree handling.

Reviewed-by: Lionel Landwerlin On 27/02/17 12:23, Kenneth Graunke wrote: There was exactly one user of this, and I just removed it. It also accessed an implicit global context, with no locking. This meant that it was only safe if all callers of

[Mesa-dev] question about container_of

Hi, Since 2012 commit ccff74971203b533bf16b46b49a9e61753f75e6c it is said: "sample must be initialized, or else the result is undefined" in the description of mesa/src/util/list.h::container_of . But I can find a few places where it is used without initializing that second parameter, i.e. like:

Re: [Mesa-dev] [PATCH 0/6] r600g: r600_shader.c small cleanups

Okay. Should I resend them? On 27.02.2017 16:32, Marek Olšák wrote: > All r600g commits should have the "r600g:" prefix. > > Marek > > On Sun, Feb 26, 2017 at 9:31 PM, Constantine Charlamov > wrote: >> Initially I was trying to implement for r600 optimization like in the >>

Re: [Mesa-dev] [PATCH] mesa/main: refactor sampler parameter error codepath

Reviewed-by: Marek Olšák Marek On Fri, Feb 24, 2017 at 12:42 PM, Samuel Pitoiset wrote: > This is similar to what we do in the texture error codepath. > While we are at it, update the specification comment with > latest GL 4.5 spec. > >

Re: [Mesa-dev] [PATCH v2] glsl: reject samplers not declared as uniform/function params earlier

Reviewed-by: Marek Olšák Marek On Fri, Feb 24, 2017 at 2:46 PM, Samuel Pitoiset wrote: > This improves consistency with image variables and atomic > counters which are already rejected the same way. > > Note that opaque variables can't be treated

Re: [Mesa-dev] [PATCH] i965: Move intel_resolve_map.[ch] from i965_compiler_FILES to i965_FILES

Reviewed-by: Lionel Landwerlin On 27/02/17 12:54, Kenneth Graunke wrote: I have no idea why these were part of the compiler files. They're miptree related code, and the compiler doesn't appear to use them. Signed-off-by: Kenneth Graunke

Re: [Mesa-dev] [PATCH] r600: add amdgpuinfo to the llvm required module list

On 27 February 2017 at 11:54, Marc Dietrich wrote: > This fixes the build when mesa is build against a static libllvm and > consolidates the module collection a bit. > > Signed-off-by: Marc Dietrich > --- > configure.ac | 7 +++ > 1 file changed, 3

[Mesa-dev] [PATCH] i965: Move intel_resolve_map.[ch] from i965_compiler_FILES to i965_FILES

I have no idea why these were part of the compiler files. They're miptree related code, and the compiler doesn't appear to use them. Signed-off-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/Makefile.sources | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)

[Mesa-dev] [PATCH] mesa: Require mipmap completeness for glCopyImageSubData(), sometimes.

This patch makes glCopyImageSubData require mipmap completeness when the texture object's built-in sampler object has a mipmapping MinFilter. Fixes (on i965): dEQP-GLES31.functional.debug.negative_coverage.*.buffer.copy_image_sub_data Signed-off-by: Kenneth Graunke ---

Re: [Mesa-dev] [PATCH mesa] docs: fix a few typos

Reviewed-by: Emil Velikov Nicely spotted, thanks. -Emil ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] mesa: Require mipmap completeness for glCopyImageSubData(), sometimes.

Sounds exactly like something which applications would get wrong (as the condition is indeed quite bizarre). At least, unlike using texelFetch with an incomplete texture (due to mipfilter again, even though that sampler state is unused with texelFetch) it is a honest error here... But if other

[Mesa-dev] [Bug 99985] RFE: gbm needs a man page

https://bugs.freedesktop.org/show_bug.cgi?id=99985 Bug ID: 99985 Summary: RFE: gbm needs a man page Product: Mesa Version: git Hardware: Other OS: All Status: NEW Severity: normal Priority:

[Mesa-dev] [Bug 99985] RFE: gbm needs a man page

https://bugs.freedesktop.org/show_bug.cgi?id=99985 --- Comment #1 from Emil Velikov --- This reminds me something that I've mentioned a while back: We really want to move the doxygen style documentation to the actual headers. Not to mention that we can add a Doxygen

Re: [Mesa-dev] [PATCH 6/6] radeon: remove unused radeon_elf_util.{c, h}

For the series: Reviewed-by: Marek Olšák Marek On Mon, Feb 27, 2017 at 1:49 AM, Timothy Arceri wrote: > We now use the shared code in AMD common instead. > --- > src/gallium/drivers/r600/evergreen_compute.c | 1 - >

Re: [Mesa-dev] [PATCH 8/8] r600/radeonsi:enableglsl/tgsion-diskcache

Am Sonntag, 26. Februar 2017, 17:24:13 CET schrieb Tobias Droste: > Mit freundlichen Grüßen > > Am Freitag, 24. Februar 2017, 11:25:24 CET schrieb Marc Dietrich: > > Am Donnerstag, 23. Februar 2017, 11:50:07 CET schrieb Emil Velikov: > > > On 23 February 2017 at 10:20, Marc Dietrich

Re: [Mesa-dev] [PATCH 0/6] r600g: r600_shader.c small cleanups

On Mon, Feb 27, 2017 at 2:38 PM, Constantine Charlamov wrote: > Okay. Should I resend them? If you don't get any more comments, yeah. Marek ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org

Re: [Mesa-dev] [PATCH 27/34] i965: Make CCS stride match kernel's expectations

On Mon, Feb 27, 2017 at 5:38 PM, Jason Ekstrand wrote: > On Mon, Feb 27, 2017 at 4:56 PM, Ben Widawsky wrote: > >> On 17-01-31 13:24:55, Jason Ekstrand wrote: >> >>> On Mon, Jan 23, 2017 at 10:21 PM, Ben Widawsky wrote: >>> >>> v2:

Re: [Mesa-dev] [PATCH 10/18] anv/cmd_buffer: Remove extra resolve for certain depth buffers

Let me make sure I understand this patch correctly: In the previous patch we made it so that we no longer unconditionally use HiZ for sampling so, when the image is in the general layout, we don't need a HiZ resolve because we are ignoring the HiZ buffer anyway. On Feb 27, 2017 5:22 PM, "Nanley

[Mesa-dev] [PATCH] gallium/radeon: Add libamd_common.a to TARGET_LIB_DEPS also for r600

From: Michel Dänzer Fixes build failure with --enable-opencl --enable-xvmc: make[4]: Entering directory '/home/daenzer/src/mesa-git/mesa/build-amd64/src/gallium/targets/xvmc' CXXLDlibXvMCgallium.la

[Mesa-dev] [PATCH shader-db 2/2] run: Make crash handler more robust against late crashes.

We might crash in the final eglTerminate and gbm_device_destroy functions, or atexit() handlers, at which point we've freed the current_shader_names array. We shouldn't access it. --- run.c | 17 +++-- 1 file changed, 11 insertions(+), 6 deletions(-) We're still crashing in atexit()

[Mesa-dev] [PATCH shader-db 1/2] run: Set current_shader_names[i] to NULL before freeing it.

current_shader_names[i] is set to shader_test[i].filename. Before we free that, we should NULL out the pointer (also indicating the current thread is done with this shader). That way, the crash handler won't print garbage when trying to list what threads were doing. --- run.c | 2 ++ 1 file

Re: [Mesa-dev] [PATCH shader-db 1/2] run: Set current_shader_names[i] to NULL before freeing it.

Both look good to me. Reviewed-by: Matt Turner ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 1/2] radeonsi: add support for an on-disk shader cache

On 27/02/17 23:20, Marek Olšák wrote: On Mon, Feb 27, 2017 at 10:57 AM, Michel Dänzer wrote: On 25/02/17 01:56 PM, Timothy Arceri wrote: On 24/02/17 21:02, Marek Olšák wrote: On Fri, Feb 24, 2017 at 3:18 AM, Timothy Arceri wrote: On 24/02/17

[Mesa-dev] [Bug 98502] Delay when starting firefox, thunderbird or chromium and dmesg spam

https://bugs.freedesktop.org/show_bug.cgi?id=98502 --- Comment #16 from Eugene Shalygin --- > Eugene if behaviour has changed across kernel versions... I'm confident that from 2014 and up to 4.10.0 on my Gentoo machine this was never the case. I don't

Re: [Mesa-dev] [PATCH 27/34] i965: Make CCS stride match kernel's expectations

On Mon, Feb 27, 2017 at 4:56 PM, Ben Widawsky wrote: > On 17-01-31 13:24:55, Jason Ekstrand wrote: > >> On Mon, Jan 23, 2017 at 10:21 PM, Ben Widawsky wrote: >> >> v2: Put the commit message as a comment (Topi) >>> >>> Cc: Topi Pohjolainen

Re: [Mesa-dev] [PATCH 0/6] r600g: r600_shader.c small cleanups

On 28.02.2017 05:19, Dave Airlie wrote: > On 27 February 2017 at 06:31, Constantine Charlamov > wrote: >> Initially I was trying to implement for r600 optimization like in > the d633e23192ef17207f4a6acd3009da3126aab395 commit for radeonsi, but failed > because I need to

Re: [Mesa-dev] [PATCH 0/6] r600g: r600_shader.c small cleanups

On 28.02.2017 05:38, Matt Turner wrote: > On Sun, Feb 26, 2017 at 12:31 PM, Constantine Charlamov > wrote: >> Initially I was trying to implement for r600 optimization like in the >> d633e23192ef17207f4a6acd3009da3126aab395 commit for radeonsi, but failed >> because I need

Re: [Mesa-dev] [PATCH 0/6] r600g: r600_shader.c small cleanups

On 28 February 2017 at 12:42, Constantine Charlamov wrote: > On 28.02.2017 05:19, Dave Airlie wrote: >> On 27 February 2017 at 06:31, Constantine Charlamov >> wrote: >> Initially I was trying to implement for r600 optimization like in >> the

Re: [Mesa-dev] [PATCH v2] dri: allow 16bit R/GR images to be exported via drm buffers

On 17-02-26 19:19:39, Emil Velikov wrote: On 11 January 2017 at 15:43, Ben Widawsky wrote: On 17-01-05 16:58:56, Rainer Hochecker wrote: From: Rainer Hochecker This allows eglCreateImageKHR to access P010 surfaces created by vaapi Signed-off-by:

Re: [Mesa-dev] [PATCH 4/4] radv: Don't allocate space for unused immutable samplers.

On 28 February 2017 at 09:08, Bas Nieuwenhuizen wrote: > Signed-off-by: Bas Nieuwenhuizen For the series Reviewed-by: Dave Airlie > --- > src/amd/vulkan/radv_descriptor_set.c | 23 ++- > 1 file changed,

[Mesa-dev] [PATCH 03/18] anv/cmd_buffer: Replace layout_to_hiz_usage()

Signed-off-by: Nanley Chery --- src/intel/vulkan/genX_cmd_buffer.c | 57 ++ 1 file changed, 15 insertions(+), 42 deletions(-) diff --git a/src/intel/vulkan/genX_cmd_buffer.c b/src/intel/vulkan/genX_cmd_buffer.c index

[Mesa-dev] [PATCH 00/18] anv: Remove the HiZ restriction on input attachments

Allow HiZ for input attachment-capable depth/stencil buffers. Do so without requiring sampling operations on such attachments to go through the HiZ buffer. Series sections: * Patch 1: Fix a bug. * Patch 2: Add a new layout to aux_usage function. * Patches 3-6: Refactor. * Patches 7-10: Don't

[Mesa-dev] [PATCH 02/18] anv/image: Add anv_layout_to_aux_usage()

This function supersedes layout_to_hiz_usage(). Signed-off-by: Nanley Chery --- src/intel/vulkan/anv_image.c | 149 + src/intel/vulkan/anv_private.h | 4 ++ 2 files changed, 153 insertions(+) diff --git

[Mesa-dev] [PATCH 05/18] anv/image: Remove extra dependency on HiZ-specific variable

surf_usage is only useful to image views that may use HiZ buffers. Storage image views don't use HiZ buffers. v2: Update commit message and add an assertion. Fixes: 055ff2ec521 ("anv: Replace anv_image_has_hiz() with ISL_AUX_USAGE_HIZ") Signed-off-by: Nanley Chery ---

[Mesa-dev] [Bug 98502] Delay when starting firefox, thunderbird or chromium and dmesg spam

https://bugs.freedesktop.org/show_bug.cgi?id=98502 --- Comment #17 from Eugene Shalygin --- To clarify: lspci was never waking up the dGPU. I assume that it was always reading the device config file. -- You are receiving this mail because: You are the

Re: [Mesa-dev] [PATCH 0/6] r600g: r600_shader.c small cleanups

On 27 February 2017 at 06:31, Constantine Charlamov wrote: > Initially I was trying to implement for r600 optimization like in the > d633e23192ef17207f4a6acd3009da3126aab395 commit for radeonsi, but failed > because I need to learn some more about GPUs internals. For another

Re: [Mesa-dev] [PATCH 27/34] i965: Make CCS stride match kernel's expectations

On 17-02-27 18:40:41, Jason Ekstrand wrote: On Mon, Feb 27, 2017 at 5:38 PM, Jason Ekstrand wrote: On Mon, Feb 27, 2017 at 4:56 PM, Ben Widawsky wrote: On 17-01-31 13:24:55, Jason Ekstrand wrote: On Mon, Jan 23, 2017 at 10:21 PM, Ben Widawsky

Re: [Mesa-dev] [r600g] Mesa git: undefined reference to `ac_shader_binary_config_start' and `ac_elf_read'

On Mon, Feb 27, 2017 at 10:25 PM, Dieter Nützel wrote: > Hello Timothy, > > after your latest commit I get this: > Same here... My standard mesa build enables both r600g/radeonsi and also does --enable-opencl which pulls LLVM/libelf into r600g for compute purposes. Looks

Re: [Mesa-dev] [PATCH 0/6] r600g: r600_shader.c small cleanups

On Sun, Feb 26, 2017 at 12:31 PM, Constantine Charlamov wrote: > Initially I was trying to implement for r600 optimization like in the > d633e23192ef17207f4a6acd3009da3126aab395 commit for radeonsi, but failed > because I need to learn some more about GPUs internals. For

Re: [Mesa-dev] [PATCH 34/34] i965: Handle compression modifier

On 17-01-31 13:40:01, Jason Ekstrand wrote: On Mon, Jan 23, 2017 at 10:21 PM, Ben Widawsky wrote: FINISHME: Use the kernel's final choice for the fb modifier bwidawsk@norris2:~/intel-gfx/kmscube (modifiers $) ~/scripts/measure_bandwidth.sh ./kmscube none Read bandwidth:

Re: [Mesa-dev] [PATCH 04/18] anv: Update the HiZ sampling helper

On Feb 27, 2017 5:20 PM, "Nanley Chery" wrote: Validate the inputs and actually verify that this image has a depth buffer. Signed-off-by: Nanley Chery --- src/intel/vulkan/anv_blorp.c | 1 + src/intel/vulkan/anv_image.c | 7 +++

Re: [Mesa-dev] [PATCH] r600: link against common ac library.

On 28/02/17 16:35, Dieter Nützel wrote: Ugh, Timothy's commit (4d0d813) was NOT enough, Are you sure? I can build OpenCL and nine without this patch. What do you mean by it was not enough? Did you get a build error? or something else? then with THIS I get the below and after reverting

Re: [Mesa-dev] [PATCH] r600: link against common ac library.

On 28/02/17 02:19 PM, Dieter Nützel wrote: > This one fixes --enable-opencl (apart from Timothy's 'fix' commit), but > NOT nine... > > Making all in targets/d3dadapter9 > make[4]: Entering directory '/opt/mesa/src/gallium/targets/d3dadapter9' > CXXLDd3dadapter9.la >

Re: [Mesa-dev] [PATCH 31/34] i965: Use partial resolves for CCS buffers being scanned out

On 17-01-31 13:37:25, Jason Ekstrand wrote: On Wed, Jan 25, 2017 at 10:39 AM, Pohjolainen, Topi < topi.pohjolai...@gmail.com> wrote: On Mon, Jan 23, 2017 at 10:21:54PM -0800, Ben Widawsky wrote: > On Gen9 hardware, the display engine is able to scanout a compressed > framebuffer by providing

Re: [Mesa-dev] [PATCH 31/34] i965: Use partial resolves for CCS buffers being scanned out

On 17-02-01 09:30:21, Topi Pohjolainen Topi Pohjolainen wrote: On Tue, Jan 31, 2017 at 01:37:25PM -0800, Jason Ekstrand wrote: On Wed, Jan 25, 2017 at 10:39 AM, Pohjolainen, Topi <[1]topi.pohjolai...@gmail.com> wrote: On Mon, Jan 23, 2017 at 10:21:54PM -0800, Ben Widawsky wrote:

Re: [Mesa-dev] [PATCH 08/18] anv/descriptor_set: Store aux usage of sampled image descriptors

Why store aux usage and not the just image layout? It doesn't really matter whether we call layout_to_aux_usage here or when we emit the binding tables. I'm just wondering why you made the choice this way. On Feb 27, 2017 5:20 PM, "Nanley Chery" wrote: Signed-off-by:

[Mesa-dev] [PATCH 11/18] anv: Store the user's VkAttachmentReference

We will be using the image layout. Store the full struct directly from the user. Signed-off-by: Nanley Chery --- src/intel/vulkan/anv_blorp.c | 24 src/intel/vulkan/anv_cmd_buffer.c | 4 ++-- src/intel/vulkan/anv_pass.c| 21

[Mesa-dev] [PATCH 12/18] anv/pass: Fix size of anv_render_pass:subpass_attachments

Don't allocate space for resolve attachments if the subpass has none. Signed-off-by: Nanley Chery --- src/intel/vulkan/anv_pass.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/intel/vulkan/anv_pass.c b/src/intel/vulkan/anv_pass.c index

[Mesa-dev] [PATCH 09/18] anv/cmd_buffer: Conditionally choose the sampled image surface state

Signed-off-by: Nanley Chery --- src/intel/vulkan/genX_cmd_buffer.c | 15 --- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/src/intel/vulkan/genX_cmd_buffer.c b/src/intel/vulkan/genX_cmd_buffer.c index 60230bf14b..2cb4468696 100644 ---

[Mesa-dev] [PATCH 16/18] anv/cmd_buffer: Add attachment transitioning functions

These are needed to transition input attachments. Signed-off-by: Nanley Chery --- src/intel/vulkan/genX_cmd_buffer.c | 85 ++ 1 file changed, 85 insertions(+) diff --git a/src/intel/vulkan/genX_cmd_buffer.c

[Mesa-dev] [PATCH 18/18] anv/image: Allow HiZ on input attachment-capable depth/stencil images

While an input attachment may only take on one of those two layouts, other depth/stencil attachments that use the same image may have HiZ-enabled layouts. Improves the average frame rate on a release candidate of a proprietary Vulkan benchmark by 9.94% over 3 runs on my SKL GT4. This causes the

[Mesa-dev] [PATCH 14/18] anv/cmd_buffer: Enable render pass awareness

Signed-off-by: Nanley Chery --- src/intel/vulkan/genX_cmd_buffer.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/src/intel/vulkan/genX_cmd_buffer.c b/src/intel/vulkan/genX_cmd_buffer.c index 1c31082136..b5eda3a13d 100644 ---

[Mesa-dev] [PATCH 15/18] anv/blorp: Encapsulate subpass id querying

Signed-off-by: Nanley Chery --- src/intel/vulkan/anv_blorp.c | 8 ++-- src/intel/vulkan/anv_private.h | 15 +++ 2 files changed, 17 insertions(+), 6 deletions(-) diff --git a/src/intel/vulkan/anv_blorp.c b/src/intel/vulkan/anv_blorp.c index

[Mesa-dev] [PATCH 07/18] anv/image: Create an additional surface state for sampling

This will be used to sample a depth input attachment without having to pass through the HiZ buffer. Signed-off-by: Nanley Chery --- src/intel/vulkan/anv_image.c | 22 +- src/intel/vulkan/anv_private.h | 6 ++ 2 files changed, 27

[Mesa-dev] [PATCH 13/18] anv/pass: Store subpass attachment reference list

We'll loop through this array when performing automatic layout transitions. Signed-off-by: Nanley Chery --- src/intel/vulkan/anv_pass.c| 6 +- src/intel/vulkan/anv_private.h | 7 +++ 2 files changed, 12 insertions(+), 1 deletion(-) diff --git

[Mesa-dev] [PATCH 10/18] anv/cmd_buffer: Remove extra resolve for certain depth buffers

Due to recent commits, the sampler now bypasses the auxiliary HiZ buffer when reading from a depth image subresource that is in the general layout. Remove this unneeded resolve. Signed-off-by: Nanley Chery --- src/intel/vulkan/genX_cmd_buffer.c | 17 +

[Mesa-dev] [PATCH 04/18] anv: Update the HiZ sampling helper

Validate the inputs and actually verify that this image has a depth buffer. Signed-off-by: Nanley Chery --- src/intel/vulkan/anv_blorp.c | 1 + src/intel/vulkan/anv_image.c | 7 +++ src/intel/vulkan/anv_private.h | 7 +-- 3 files changed, 9 insertions(+), 6

[Mesa-dev] [PATCH 01/18] anv/pass: Avoid accessing attachment array out of bounds

Cc: Signed-off-by: Nanley Chery --- src/intel/vulkan/anv_pass.c | 22 +- 1 file changed, 13 insertions(+), 9 deletions(-) diff --git a/src/intel/vulkan/anv_pass.c b/src/intel/vulkan/anv_pass.c index

[Mesa-dev] [PATCH 08/18] anv/descriptor_set: Store aux usage of sampled image descriptors

Signed-off-by: Nanley Chery --- src/intel/vulkan/anv_descriptor_set.c | 10 ++ src/intel/vulkan/anv_private.h| 5 + 2 files changed, 15 insertions(+) diff --git a/src/intel/vulkan/anv_descriptor_set.c b/src/intel/vulkan/anv_descriptor_set.c index

[Mesa-dev] [PATCH 06/18] anv/image: Simplify setup of HiZ sampler surface state

Signed-off-by: Nanley Chery --- src/intel/vulkan/anv_image.c | 31 +-- 1 file changed, 13 insertions(+), 18 deletions(-) diff --git a/src/intel/vulkan/anv_image.c b/src/intel/vulkan/anv_image.c index a17c398993..dd646a7027 100644 ---

[Mesa-dev] [PATCH 17/18] anv/cmd_buffer: Centralize automatic layout transitions

Signed-off-by: Nanley Chery --- src/intel/vulkan/genX_cmd_buffer.c | 54 +- 1 file changed, 12 insertions(+), 42 deletions(-) diff --git a/src/intel/vulkan/genX_cmd_buffer.c b/src/intel/vulkan/genX_cmd_buffer.c index

Re: [Mesa-dev] [PATCH] anv/image: Remove extra dependency on HiZ-specific variable

On Fri, Feb 24, 2017 at 06:02:16PM -0800, Jason Ekstrand wrote: > seems reasonable > > Reviewed-by: Jason Ekstrand > Thanks for the review! I've updated this patch a bit in the series I just sent out. -Nanley > On Wed, Feb 22, 2017 at 4:33 PM, Nanley Chery

Re: [Mesa-dev] [PATCH 1/2] radeonsi: add support for an on-disk shader cache

On 27/02/17 09:20 PM, Marek Olšák wrote: > On Mon, Feb 27, 2017 at 10:57 AM, Michel Dänzer wrote: >> On 25/02/17 01:56 PM, Timothy Arceri wrote: >>> On 24/02/17 21:02, Marek Olšák wrote: On Fri, Feb 24, 2017 at 3:18 AM, Timothy Arceri wrote:

[Mesa-dev] [r600g] Mesa git: undefined reference to `ac_shader_binary_config_start' and `ac_elf_read'

Hello Timothy, after your latest commit I get this: make[4]: Entering directory '/opt/mesa/src/gallium/targets/pipe-loader' CXXLDpipe_r600.la ../../../../src/gallium/drivers/r600/.libs/libr600.a(evergreen_compute.o): In function `r600_shader_binary_read_config':

Re: [Mesa-dev] [PATCH 03/18] anv/cmd_buffer: Replace layout_to_hiz_usage()

On Feb 27, 2017 5:21 PM, "Nanley Chery" wrote: Signed-off-by: Nanley Chery --- src/intel/vulkan/genX_cmd_buffer.c | 57 ++ 1 file changed, 15 insertions(+), 42 deletions(-) diff --git

Re: [Mesa-dev] [PATCH] r600: link against common ac library.

This one fixes --enable-opencl (apart from Timothy's 'fix' commit), but NOT nine... Making all in targets/d3dadapter9 make[4]: Entering directory '/opt/mesa/src/gallium/targets/d3dadapter9' CXXLDd3dadapter9.la

Re: [Mesa-dev] [PATCH] r600: link against common ac library.

Ugh, Timothy's commit (4d0d813) was NOT enough, then with THIS I get the below and after reverting THIS I'm set... [-] make[1]: Entering directory '/opt/mesa' make[1]: Nothing to be done for 'all-am'. make[1]: Leaving directory '/opt/mesa' -Dieter Am 28.02.2017 06:19, schrieb Dieter Nützel:

Re: [Mesa-dev] [PATCH 00/18] anv: Remove the HiZ restriction on input attachments

Did a read-through and, overall, this looks great. I made a few comments but they're fairly simple. One question though: Am I correct in thinking that we are still disabling HiZ for rendering when the image is in the general layout? I think it should be easy enough to change now but I didn't

Re: [Mesa-dev] [PATCH 1/2] radeonsi: add support for an on-disk shader cache

On 27/02/17 20:57, Michel Dänzer wrote: On 25/02/17 01:56 PM, Timothy Arceri wrote: On 24/02/17 21:02, Marek Olšák wrote: On Fri, Feb 24, 2017 at 3:18 AM, Timothy Arceri wrote: On 24/02/17 08:49, Timothy Arceri wrote: On 24/02/17 05:12, Marek Olšák wrote: On Thu,

Re: [Mesa-dev] [PATCH 01/18] anv/pass: Avoid accessing attachment array out of bounds

Reviewed-by: Jason Ekstrand On Feb 27, 2017 5:20 PM, "Nanley Chery" wrote: > Cc: > Signed-off-by: Nanley Chery > --- > src/intel/vulkan/anv_pass.c | 22 +- > 1 file

[Mesa-dev] [PATCH] r600: link against common ac library.

From: Dave Airlie This should fix the build. Signed-off-by: Dave Airlie --- src/gallium/drivers/r600/Automake.inc | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/drivers/r600/Automake.inc b/src/gallium/drivers/r600/Automake.inc index

Re: [Mesa-dev] [PATCH 14/18] anv/cmd_buffer: Enable render pass awareness

Thank you! I've been meaning to do this. That said, I think we need something in cmd_state_reset as well. On Feb 27, 2017 5:22 PM, "Nanley Chery" wrote: > Signed-off-by: Nanley Chery > --- > src/intel/vulkan/genX_cmd_buffer.c | 7 +++ > 1

Re: [Mesa-dev] [PATCH 13/18] anv/pass: Store subpass attachment reference list

On Feb 27, 2017 5:21 PM, "Nanley Chery" wrote: We'll loop through this array when performing automatic layout transitions. Signed-off-by: Nanley Chery --- src/intel/vulkan/anv_pass.c| 6 +- src/intel/vulkan/anv_private.h | 7 +++ 2

[Mesa-dev] [PATCH] radv: fix txs for sampler buffers

From: Dave Airlie I messed this up when I wrote it, this fixes: dEQP-VK.memory.pipeline_barrier.*uniform_texel_buffer.* Cc: "17.0" Signed-off-by: Dave Airlie --- src/amd/common/ac_nir_to_llvm.c | 2 +- 1 file changed,

Re: [Mesa-dev] [PATCH] gallium/radeon: Add libamd_common.a to TARGET_LIB_DEPS also for r600

I was worried this might break radeonsi if xvmc wasn't enabled but seems ok. Acked-by: Timothy Arceri On 28/02/17 17:37, Michel Dänzer wrote: From: Michel Dänzer Fixes build failure with --enable-opencl --enable-xvmc: make[4]: Entering

[Mesa-dev] [PATCH] Mesa: Fix performance query id check

In queryid_valid() fix handling of zero index. CC: Robert Bragg Signed-off-by: Juha-Pekka Heikkila --- src/mesa/main/performance_query.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/main/performance_query.c

Re: [Mesa-dev] [PATCH] glx/tests: Fix bash-specific code in dispatch-index-check

On Sun, Feb 26, 2017 at 7:51 AM, Eric Engestrom wrote: > On Friday, 2017-02-24 22:03:36 -0600, Aaron Watry wrote: > > Using <<< for variable redirection is bash-specific behavior. > > Ubuntu redirects sh -> dash, so this was erroring out. > > > > Also, the initial error that

Re: [Mesa-dev] [PATCH] nir: Delete unused arg in get_iteration

On Monday, 2017-02-27 14:22:55 +, Elie Tournier wrote: > Some1 to review this patch? Reviewed and pushed, thanks :) > > On 21/02/17 16:15, Elie Tournier wrote: > > nir_const_value is not needed in get_iteration > Oops typo: > nir_alu_instr is not needed in get_iteration ... and I only just

[Mesa-dev] [PATCH] r600g: fix build without opencl and static llvm libs

radeon_llvm_check was never called in the no-opencl case, which broke the llvm module list (amdgpuinfo was not included). As --enable-opencl always requires --enable-llvm, the test can be easily fixed. Signed-off-by: Marc Dietrich --- configure.ac | 2 +- 1 file changed, 1

Re: [Mesa-dev] [PATCH 6/6] radeon: remove unused radeon_elf_util.{c, h}

Hi Tim, Haven't looked at the code but it seems like we can drop On 27 February 2017 at 00:49, Timothy Arceri wrote: > We now use the shared code in AMD common instead. > --- > src/gallium/drivers/r600/evergreen_compute.c | 1 - >

Re: [Mesa-dev] [PATCH] r600g: fix build without opencl and static llvm libs

On 27 February 2017 at 15:35, Marc Dietrich wrote: > radeon_llvm_check was never called in the no-opencl case, which broke > the llvm module list (amdgpuinfo was not included). As --enable-opencl > always requires --enable-llvm, the test can be easily fixed. > > Signed-off-by:

[Mesa-dev] [Bug 99319] godot engine poor performance

https://bugs.freedesktop.org/show_bug.cgi?id=99319 --- Comment #8 from i9i7s...@gmail.com --- (In reply to Bas Nieuwenhuizen from comment #7) > I think this is actually fixed in Mesa git. I get 60 fps for the platformer > demo now. If it's really fixed, that's good. It would be interesting to

Re: [Mesa-dev] [PATCH] r600: add amdgpuinfo to the llvm requiredmodule list

On 27 February 2017 at 14:43, Marc Dietrich wrote: > Am Montag, 27. Februar 2017, 15:26:18 CET schrieb Jan Vesely: >> On Mon, 2017-02-27 at 12:54 +0100, Marc Dietrich wrote: >> > This fixes the build when mesa is build against a static libllvm and >> > consolidates the module

[Mesa-dev] [Bug 99856] OpenCL Hello world returns "unsupported call to function get_local_size"

https://bugs.freedesktop.org/show_bug.cgi?id=99856 --- Comment #17 from Jan Vesely --- (In reply to Henrique Dante de Almeida from comment #16) > Weird ! So was this a bug in IR source code ? more like a combination of llvm/libclc. the function would ideally be

  1   2   >