[Mesa-dev] [PATCH] mesa/glthread: add custom marshalling for ClearBufferfv()

This is one of the main causes of syncs in Civ6. --- src/mapi/glapi/gen/GL3x.xml | 2 +- src/mesa/main/marshal.c | 73 + src/mesa/main/marshal.h | 9 ++ 3 files changed, 83 insertions(+), 1 deletion(-) diff --git

Re: [Mesa-dev] [PATCH] anv: enable sampling from fast-cleared images on SKL

On Thu, 2017-03-23 at 11:09 -0700, Nanley Chery wrote: > On Thu, Mar 23, 2017 at 12:25:28PM +0100, Samuel Iglesias Gonsálvez > wrote: > > A resolve is not needed on Skylake in this case. We were forcing > > a resolve because we set the input_aux_usage to ISL_AUX_USAGE_NONE. > > > > Signed-off-by:

Re: [Mesa-dev] [PATCH v4 07/28] i965/fs: generalize the legalization d2x pass

On Thu, 2017-03-23 at 12:01 -0700, Francisco Jerez wrote: > Samuel Iglesias Gonsálvez writes: > > > On Wed, 2017-03-22 at 15:47 -0700, Francisco Jerez wrote: > > > Samuel Iglesias Gonsálvez writes: > > > > > > > Generalize it to lower any unsupported

Re: [Mesa-dev] [Mesa-stable] [PATCH] i965/fs: Don't emit SEL instructions for type-converting MOVs.

Samuel Iglesias Gonsálvez writes: > On Thu, 2017-03-23 at 13:50 -0700, Matt Turner wrote: >> SEL can only convert between a few integer types, which we basically >> never do. >> >> Fixes fs/vs-double-uniform-array-direct-indirect-non-uniform-control- >> flow >> Cc:

Re: [Mesa-dev] [PATCH] anv/query: handle out of host memory without crashing in compute_query_result()

Topi, could you review this one? This was introduced recently with the implementation of Queries in the Vulkan driver and since the CTS OOM tests have not landed yet Jenkins won't catch these issues for now. Iago On Wed, 2017-03-22 at 10:15 +0100, Iago Toral Quiroga wrote: > We don't need to

Re: [Mesa-dev] [PATCH v4 19/28] i965/vec4: fix SIMD-width lowering for VEC4_OPCODE_FROM_DOUBLE

On Thu, 2017-03-23 at 12:14 -0700, Francisco Jerez wrote: > Samuel Iglesias Gonsálvez writes: > > > On Wed, 2017-03-22 at 15:55 -0700, Francisco Jerez wrote: > > > Samuel Iglesias Gonsálvez writes: > > > > > > > Now the VEC4_OPCODE_FROM_DOUBLE's

Re: [Mesa-dev] [Mesa-stable] [PATCH] i965/fs: Don't emit SEL instructions for type-converting MOVs.

On Thu, 2017-03-23 at 13:50 -0700, Matt Turner wrote: > SEL can only convert between a few integer types, which we basically > never do. > > Fixes fs/vs-double-uniform-array-direct-indirect-non-uniform-control- > flow > Cc: mesa-sta...@lists.freedesktop.org I sent a similar but wrong patch

Re: [Mesa-dev] [PATCH] anv/query: handle out of host memory without crashing in compute_query_result()

On Wed, Mar 22, 2017 at 10:15:59AM +0100, Iago Toral Quiroga wrote: > We don't need to make the caller (CmdCopyQueryPoolResults) aware of the > problem since compute_query_result() only emits state. The caller is also > expected to hit OOM in this scenario right after calling this function, but >

Re: [Mesa-dev] [PATCH] anv/query: handle out of host memory without crashing in compute_query_result()

On Fri, Mar 24, 2017 at 09:12:21AM +0100, Iago Toral wrote: > Topi, could you review this one? > > This was introduced recently with the implementation of Queries in the > Vulkan driver and since the CTS OOM tests have not landed yet Jenkins > won't catch these issues for now. Yeah, sorry, I was

Re: [Mesa-dev] [PATCH 6/6] mesa: remove dd_function_table::BindProgram

With Timothy's comment on patch #3 addressed, the series is Reviewed-by: Nicolai Hähnle On 24.03.2017 00:42, Marek Olšák wrote: From: Marek Olšák --- src/mesa/drivers/common/driverfuncs.c | 1 - src/mesa/main/arbprogram.c| 3 --

[Mesa-dev] [PATCH 4/4] r600_state: check NULL return from r600_aligned_buffer_create

Signed-off-by: Julien Isorce --- src/gallium/drivers/r600/r600_state.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/src/gallium/drivers/r600/r600_state.c b/src/gallium/drivers/r600/r600_state.c index 6139bd2..9ca113a 100644 ---

[Mesa-dev] [PATCH 2/4] si_compute: check NULL return from u_upload_alloc

Signed-off-by: Julien Isorce --- src/gallium/drivers/radeonsi/si_compute.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/gallium/drivers/radeonsi/si_compute.c b/src/gallium/drivers/radeonsi/si_compute.c index 19a9189..e3ccc55 100644 ---

[Mesa-dev] [PATCH 3/4] st_cb_bitmap: check NULL return from u_upload_alloc

Signed-off-by: Julien Isorce --- src/mesa/state_tracker/st_cb_bitmap.c | 5 + 1 file changed, 5 insertions(+) diff --git a/src/mesa/state_tracker/st_cb_bitmap.c b/src/mesa/state_tracker/st_cb_bitmap.c index b2e2608..3ce190e 100644 ---

[Mesa-dev] [PATCH 1/4] r600_state_common: check NULL return from u_upload_alloc

Like done in si_state_draw.c::si_draw_vbo Signed-off-by: Julien Isorce --- src/gallium/drivers/r600/r600_state_common.c | 4 1 file changed, 4 insertions(+) diff --git a/src/gallium/drivers/r600/r600_state_common.c b/src/gallium/drivers/r600/r600_state_common.c index

Re: [Mesa-dev] [PATCH 1/4] r600_state_common: check NULL return from u_upload_alloc

1: Ack, thx. 2: u_upload_alloc can fail, i.e. set output param *ptr to NULL, for 2 reasons: alloc fails or map fails. For both there are already a fprintf/stderr, i.e., in radeon_create_bo and radeon_bo_do_map . It looks to me that in src/gallium/drivers/ it is a common usage to just avoid to

Re: [Mesa-dev] [PATCH 3/3] targets/va: export radeon winsys_create functions

On 24 March 2017 at 11:02, Nicolai Hähnle wrote: > On 24.03.2017 01:00, Marek Olšák wrote: >> >> From: Marek Olšák >> >> This should fix this radeonsi error: >> "mesa: for the -simplifycfg-sink-common option: may only occur zero or >> one >>times!"

Re: [Mesa-dev] [PATCH v2 1/2] mesa: make glFramebuffer* check immutable texture level bounds

Reviewed-by: Antia Puentes On jue, 2017-01-26 at 00:47 -0500, Ilia Mirkin wrote: > When a texture is immutable, we can't tack on extra levels > after-the-fact like we could with glTexImage. So check against that > level limit and return an error if it's surpassed. > > The

Re: [Mesa-dev] [PATCH v2 1/2] mesa: make glFramebuffer* check immutable texture level bounds

On mié, 2017-02-01 at 19:18 +0100, Antía Puentes wrote: > On mié, 2017-02-01 at 00:37 -0500, Ilia Mirkin wrote: > > On Tue, Jan 31, 2017 at 2:55 PM, Antía Puentes wrote: > > > > > > There was an update in the OpenGL ES 3.2 specification (November 3, > > > 2016) addressing

[Mesa-dev] [PATCH v4.1 07/28] i965/fs: generalize the legalization d2x pass

Generalize it to lower any unsupported narrower conversion. v2 (Curro): - Add supports_type_conversion() - Reuse existing intruction instead of cloning it. - Generalize d2x to narrower and equal size conversions. v3 (Curro): - Make supports_type_conversion() const and improve it. - Use

[Mesa-dev] [PATCH v4.1 17.5/28] i965/vec4: split VEC4_OPCODE_FROM_DOUBLE into one opcode per destination's type

This way we can set the destination type as double to all these new opcodes, avoiding any optimizer's confusion that was happening before. Signed-off-by: Samuel Iglesias Gonsálvez --- This patch is going to be placed just after patch 17. Please discard patch 19.

Re: [Mesa-dev] [PATCH 3/3] targets/va: export radeon winsys_create functions

On 24.03.2017 01:00, Marek Olšák wrote: From: Marek Olšák This should fix this radeonsi error: "mesa: for the -simplifycfg-sink-common option: may only occur zero or one times!" --- src/gallium/targets/va/va.sym | 2 ++ 1 file changed, 2 insertions(+) diff --git

Re: [Mesa-dev] [PATCH] mesa/glthread: add custom marshalling for ClearBufferfv()

On 24.03.2017 07:46, Timothy Arceri wrote: This is one of the main causes of syncs in Civ6. Reviewed-by: Nicolai Hähnle --- src/mapi/glapi/gen/GL3x.xml | 2 +- src/mesa/main/marshal.c | 73 + src/mesa/main/marshal.h

Re: [Mesa-dev] [PATCH 1/4] r600_state_common: check NULL return from u_upload_alloc

I generally like the patches in the series, thanks for that. Two points though: 1. The order of patches in series is usually general code before driver code, i.e. the st/cb_bitmap should come first. 2. I don't like having silent errors, as that could be confusing. In places where the error

Re: [Mesa-dev] [RFC libdrm 0/2] Replace the build system with meson

On 22/03/17 20:57, Dylan Baker wrote: Quoting Jose Fonseca (2017-03-22 10:59:10) On 17/03/17 02:28, Brian Paul wrote: [snip] Sure, I'd like to see one build system instead of two. Meson supports Windows so that's good. But the big issue is our automated build system. Replacing SCons with

Re: [Mesa-dev] [PATCH 3/4] st_cb_bitmap: check NULL return from u_upload_alloc

On 24.03.2017 12:08, Julien Isorce wrote: Signed-off-by: Julien Isorce --- src/mesa/state_tracker/st_cb_bitmap.c | 5 + 1 file changed, 5 insertions(+) diff --git a/src/mesa/state_tracker/st_cb_bitmap.c b/src/mesa/state_tracker/st_cb_bitmap.c index b2e2608..3ce190e

Re: [Mesa-dev] [RFC 00/12] anv: A first pass at VK_KHX_multiview

On Thu, 2017-03-23 at 14:28 +0100, Iago Toral wrote: > The proposed implementation makes sense to me, I looked through > patches > 1-8 and they all look good as well, so those are: Pateches 9, 19 and 12 are also: Reviewed-by: Iago Toral Quiroga I left some comments in patch

Re: [Mesa-dev] [RFC 11/12] anv/cmd_buffer: Emit instanced draws for multiple views

On Wed, 2017-03-22 at 21:01 -0700, Jason Ekstrand wrote: ---  src/intel/vulkan/anv_private.h |   6 ++  src/intel/vulkan/genX_cmd_buffer.c | 141 -  src/intel/vulkan/genX_pipeline.c   |  10 ++-  3 files changed, 152 insertions(+), 5 deletions(-) diff --git

[Mesa-dev] [PATCH] egl: Return error on try to create multiple surfaces from window. (v3)

According to the EGL 1.5 spec, section 3.5.1, page 34,35 on PDF eglCreateWindowSurface should set EGL_BAD_ALLOC if there is already surface for given window. Similarly it is written in EGL 1.4 spec, section 3.5.1, page 29 on PDF. v2: made it compilable(i'm porting it from other fork, so there was

Re: [Mesa-dev] [RFC libdrm 0/2] Replace the build system with meson

On 23/03/17 01:38, Rob Clark wrote: On Wed, Mar 22, 2017 at 9:18 PM, Jonathan Gray wrote: On Wed, Mar 22, 2017 at 01:10:14PM -0700, Dylan Baker wrote: On Wed, Mar 22, 2017 at 12:40 PM, Alex Deucher wrote: I guess I'm a little late to the party here,

Re: [Mesa-dev] [RFC libdrm 0/2] Replace the build system with meson

Quoting Colin Cross (2017-03-23 17:03:58) > On Thu, Mar 23, 2017 at 4:56 PM, Dylan Baker wrote: > > > > I'm hoping you can clarify a couple of questions I have about blueprint: > > 1) android is moving to blueprint from android.mk files? > > Yes, in a phased transition. We

Re: [Mesa-dev] [PATCH 1/4] vc4: Fix indenting in vc4_screen_get_param()

Lyude writes: > Signed-off-by: Lyude Reviewed-by: Eric Anholt signature.asc Description: PGP signature ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org

Re: [Mesa-dev] [PATCH 1/4] r600_state_common: check NULL return from u_upload_alloc

On 24.03.2017 13:11, Julien Isorce wrote: 1: Ack, thx. 2: u_upload_alloc can fail, i.e. set output param *ptr to NULL, for 2 reasons: alloc fails or map fails. For both there are already a fprintf/stderr, i.e., in radeon_create_bo and radeon_bo_do_map . It looks to me that in

Re: [Mesa-dev] [PATCH v2 1/2] mesa: make glFramebuffer* check immutable texture level bounds

Wait, so are we saying that my original patch is good? I've beyond-lost context on all this, but as I recall my original patch had some issues. As I don't have Khronos access to the bug in question, I'm not sure what the right thing is. The original patch applies this logic to

Re: [Mesa-dev] [RFC libdrm 0/2] Replace the build system with meson

> Another tool I heard good about but have not direct experience is > https://bazel.build . Any thoughts about it? Having looked a bit into it, it also is just a build system (albeit higher level than ninja or make). It doesn't do configure or install and working with system dependencies is

Re: [Mesa-dev] [PATCH 3/3] targets/va: export radeon winsys_create functions

On 24.03.2017 15:31, Marek Olšák wrote: On Fri, Mar 24, 2017 at 12:02 PM, Nicolai Hähnle wrote: On 24.03.2017 01:00, Marek Olšák wrote: From: Marek Olšák This should fix this radeonsi error: "mesa: for the -simplifycfg-sink-common option: may only

Re: [Mesa-dev] [PATCH 3/3] targets/va: export radeon winsys_create functions

On 24 March 2017 at 15:26, Marek Olšák wrote: > On Fri, Mar 24, 2017 at 4:09 PM, Emil Velikov > wrote: >> On 24 March 2017 at 14:42, Marek Olšák wrote: >>> On Fri, Mar 24, 2017 at 12:24 PM, Emil Velikov

Re: [Mesa-dev] [RFC libdrm 0/2] Replace the build system with meson

Dylan Baker writes: > [ Unknown signature status ] > Quoting Jose Fonseca (2017-03-24 06:42:18) >> >> I tend to disagree. While we can't avoid a transitory period, when we >> embark on another build system (Meson or something else) I think we >> should aim at 1) ensure

Re: [Mesa-dev] [PATCH 6/9] isl: Validate the calculated row pitch (v2)

On Thu 23 Mar 2017, Jason Ekstrand wrote: > On Wed, Mar 22, 2017 at 6:04 PM, Chad Versace > wrote: > > > Validate that isl_surf::row_pitch fits in the below bitfields, > > if applicable based on isl_surf::usage. > > > > RENDER_SURFACE_STATE::SurfacePitch > >

Re: [Mesa-dev] [RFC libdrm 0/2] Replace the build system with meson

Quoting Jose Fonseca (2017-03-24 06:42:18) > > I tend to disagree. While we can't avoid a transitory period, when we > embark on another build system (Meson or something else) I think we > should aim at 1) ensure such tool can indeed _completely_ replace at > least _one_ existing build

Re: [Mesa-dev] [RFC libdrm 0/2] Replace the build system with meson

On Mon, 20 Mar 2017, Matt Turner wrote: - dropping the Autotools will lead to OpenBSD and NetBSD having to write one from scratch, IIRC Solaris/FreeBSD and others are in similar boat. Solaris is a closed source operating system whose developers do not contribute to the project. We do not

Re: [Mesa-dev] [PATCH 6/9] isl: Validate the calculated row pitch (v2)

On Fri 24 Mar 2017, Emil Velikov wrote: > Hi Chad, > > On 23 March 2017 at 01:04, Chad Versace wrote: > > Validate that isl_surf::row_pitch fits in the below bitfields, > > if applicable based on isl_surf::usage. > > > > RENDER_SURFACE_STATE::SurfacePitch > >

Re: [Mesa-dev] [PATCH 6/9] isl: Validate the calculated row pitch (v2)

On 24 March 2017 at 18:02, Chad Versace wrote: > On Fri 24 Mar 2017, Emil Velikov wrote: >> Hi Chad, >> >> On 23 March 2017 at 01:04, Chad Versace wrote: >> > Validate that isl_surf::row_pitch fits in the below bitfields, >> > if applicable

Re: [Mesa-dev] [RFC libdrm 0/2] Replace the build system with meson

Hi, On 24 March 2017 at 17:51, Eric Anholt wrote: > Dylan Baker writes: >> I also think it's worth talking to Eric (who said he's porting X to meson), >> Daniel Stone (who has patches to port weston to meson), and Peter Hutterer >> (who >> has patches to

[Mesa-dev] [PATCH 3/3] st/wgl: Replace variable name hdc with hDrawDC

From: Neha Bhende Reviewed-by: Brian Paul --- src/gallium/state_trackers/wgl/stw_context.c | 16 src/gallium/state_trackers/wgl/stw_context.h | 4 ++-- 2 files changed, 10 insertions(+), 10 deletions(-) diff --git

[Mesa-dev] [PATCH 1/3] stw/wgl: add null context check in wglBindTexImageARB()

To avoid dereferencing a null pointer in case wglMakeCurrent() wasn't called. Found while debugging SWKOTOR game. Reviewed-by: Neha Bhende Reviewed-by: Charmaine Lee --- src/gallium/state_trackers/wgl/stw_ext_rendertexture.c | 6 ++ 1 file

[Mesa-dev] [PATCH 2/3] st/wgl: add support for WGL_ARB_make_current_read

This adds the wglMakeContextCurrentARB() and wglMakeContextCurrentARB() functions. --- src/gallium/state_trackers/wgl/stw_context.c | 77 ++ src/gallium/state_trackers/wgl/stw_context.h | 5 +- src/gallium/state_trackers/wgl/stw_ext_context.c | 15 +

Re: [Mesa-dev] [PATCH 2/8] genxml: Fix gen_zipped_file.py dependency

Patches 1 and 2 are pushed, with Emil's r-b. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [RFC libdrm 0/2] Replace the build system with meson

On Fri, Mar 24, 2017 at 6:42 AM, Jose Fonseca wrote: > On 23/03/17 01:38, Rob Clark wrote: >> >> On Wed, Mar 22, 2017 at 9:18 PM, Jonathan Gray wrote: >>> >>> On Wed, Mar 22, 2017 at 01:10:14PM -0700, Dylan Baker wrote: On Wed, Mar 22, 2017 at 12:40

[Mesa-dev] [PATCH 1/2] gallium/util: clean up stack frame printing

Prep work for next patch. Ideally 'struct debug_stack_frame' would be opaque, but it is embedded in a bunch of places. But at least we can treat it opaquely. Signed-off-by: Rob Clark --- src/gallium/auxiliary/util/u_debug_refcnt.c | 27 ---

[Mesa-dev] [PATCH 2/2] gallium/util: libunwind support

It's kinda sad that (a) we don't have debug_backtrace support on !X86 and that (b) we re-invent our own crude backtrace support in the first place. If available, use libunwind instead. The backtrace format is based on what xserver and weston use, since it is nice not to have to figure out a

Re: [Mesa-dev] [PATCH 4/8] genxml/gen8: Remove BLACK_LEVEL_CORRECTION_STATE

On Fri 24 Mar 2017, Jason Ekstrand wrote: > We've never used it, it only exists on gen8, and the name of the struct > contains piles of bad characters. > --- > src/intel/genxml/gen8.xml | 6 -- > 1 file changed, 6 deletions(-) > - wtf. Reviewed-by: Chad Versace

Re: [Mesa-dev] [PATCH 5/8] genxml/gen6: Remove a couple of bogus values

On Fri 24 Mar 2017, Jason Ekstrand wrote: > --- > src/intel/genxml/gen6.xml | 8 ++-- > 1 file changed, 2 insertions(+), 6 deletions(-) Thanks. I discovered these in writing my patches, but forgot to fix them. Reviewed-by: Chad Versace

Re: [Mesa-dev] [Mesa-stable] [PATCH] i965/fs: Don't emit SEL instructions for type-converting MOVs.

Matt Turner writes: > On Fri, Mar 24, 2017 at 12:06 AM, Francisco Jerez > wrote: >> Samuel Iglesias Gonsálvez writes: >> >>> On Thu, 2017-03-23 at 13:50 -0700, Matt Turner wrote: SEL can only convert between a few integer

Re: [Mesa-dev] [RFC libdrm 0/2] Replace the build system with meson

On Fri, Mar 24, 2017 at 12:44 PM, Jose Fonseca wrote: > On 24/03/17 19:10, Kristian Høgsberg wrote: >> >> On Fri, Mar 24, 2017 at 6:42 AM, Jose Fonseca wrote: >>> >>> On 23/03/17 01:38, Rob Clark wrote: On Wed, Mar 22, 2017 at 9:18 PM,

Re: [Mesa-dev] [RFC libdrm 0/2] Replace the build system with meson

On Tue 21 Mar 2017, Matt Turner wrote: > On Tue, Mar 21, 2017 at 10:16 AM, Emil Velikov > wrote: > > On 21 March 2017 at 15:57, Matt Turner wrote: > >> On Mon, Mar 20, 2017 at 12:39 PM, Emil Velikov > >> wrote: > >>> On

Re: [Mesa-dev] [RFC libdrm 0/2] Replace the build system with meson

On Fri, Mar 24, 2017 at 3:10 PM, Kristian Høgsberg wrote: > On Fri, Mar 24, 2017 at 6:42 AM, Jose Fonseca wrote: >> On 23/03/17 01:38, Rob Clark wrote: >>> >>> On Wed, Mar 22, 2017 at 9:18 PM, Jonathan Gray wrote: On Wed, Mar

[Mesa-dev] [PATCH 6/8] genxml: Replace "[N]" with "N"

--- src/intel/genxml/gen6.xml | 6 +++--- src/intel/genxml/gen7.xml | 12 ++-- src/intel/genxml/gen75.xml | 12 ++-- 3 files changed, 15 insertions(+), 15 deletions(-) diff --git a/src/intel/genxml/gen6.xml b/src/intel/genxml/gen6.xml index d77d158..8eef7bf 100644 ---

[Mesa-dev] [PATCH 7/8] genxml: Whitespace fixes

Some field names had extra spaces and some had places where we should have had a space but didn't. --- src/intel/genxml/gen6.xml | 16 src/intel/genxml/gen7.xml | 24 src/intel/genxml/gen75.xml | 22 +++--- src/intel/genxml/gen8.xml |

[Mesa-dev] [PATCH 3/8] genxml: Rename two MCS fields to Auxiliary Surface on gen7

This makes gen7 more consistent with gen8+ --- src/intel/genxml/gen7.xml | 4 ++-- src/intel/genxml/gen75.xml| 4 ++-- src/intel/isl/isl_surface_state.c | 7 +++ 3 files changed, 7 insertions(+), 8 deletions(-) diff --git a/src/intel/genxml/gen7.xml

[Mesa-dev] [PATCH 5/8] genxml/gen6: Remove a couple of bogus values

--- src/intel/genxml/gen6.xml | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/src/intel/genxml/gen6.xml b/src/intel/genxml/gen6.xml index da3f64d..d77d158 100644 --- a/src/intel/genxml/gen6.xml +++ b/src/intel/genxml/gen6.xml @@ -939,18 +939,14 @@ -

[Mesa-dev] [PATCH 1/8] genxml: Define GENXML_XML_FILES in Makefile.sources

From: Chad Versace The future header genX_bits.h will depend on GENXML_XML_FILES. --- src/intel/Makefile.genxml.am | 9 + src/intel/Makefile.sources | 10 ++ 2 files changed, 11 insertions(+), 8 deletions(-) diff --git a/src/intel/Makefile.genxml.am

[Mesa-dev] [PATCH 4/8] genxml/gen8: Remove BLACK_LEVEL_CORRECTION_STATE

We've never used it, it only exists on gen8, and the name of the struct contains piles of bad characters. --- src/intel/genxml/gen8.xml | 6 -- 1 file changed, 6 deletions(-) diff --git a/src/intel/genxml/gen8.xml b/src/intel/genxml/gen8.xml index f9899c6..193a183 100644 ---

[Mesa-dev] [PATCH 2/8] genxml: Fix gen_zipped_file.py dependency

From: Chad Versace The gen*_xml.h files depend on gen_zipped_file.py, not the gen*_pack.h files. --- src/intel/Makefile.genxml.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/intel/Makefile.genxml.am b/src/intel/Makefile.genxml.am index

[Mesa-dev] [PATCH 0/8] genxml: Add a _bits header

This series is a re-spin of some patches that Chad wrote to add a genX_bits.h header which contains functions for getting the number of bits in any given hardware state field. The first few patches are fixes for genxml. There were a bunch of places where the sanitized field names matched but not

Re: [Mesa-dev] [PATCH] i965: Remove pointless NULL check from Gen6 primitive counting code.

Reviewed-by: Matt Turner ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [RFC libdrm 0/2] Replace the build system with meson

On Fri, Mar 24, 2017 at 2:16 PM, Jose Fonseca wrote: > On 24/03/17 20:08, Kristian Høgsberg wrote: > >> On Fri, Mar 24, 2017 at 12:44 PM, Jose Fonseca >> wrote: >> >>> On 24/03/17 19:10, Kristian Høgsberg wrote: >>> On Fri, Mar 24, 2017 at

[Mesa-dev] [PATCH 8/8] genxml: New generated header genX_bits.h (v2)

From: Chad Versace genX_bits.h contains the sizes of bitfields in genxml instructions, structures, and registers. It also defines some functions to query those sizes. isl_surf_init() will use the new header to validate that requested pitches fit in their destination

Re: [Mesa-dev] [PATCH] i965: Fix symbolic size of next_offset[] array.

Reviewed-by: Matt Turner ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] anv: enable sampling from fast-cleared images on SKL

On Mar 23, 2017 11:00 PM, "Samuel Iglesias Gonsálvez" wrote: On Thu, 2017-03-23 at 11:09 -0700, Nanley Chery wrote: > On Thu, Mar 23, 2017 at 12:25:28PM +0100, Samuel Iglesias Gonsálvez > wrote: > > A resolve is not needed on Skylake in this case. We were forcing > > a

Re: [Mesa-dev] [RFC libdrm 0/2] Replace the build system with meson

On Fri, Mar 24, 2017 at 5:16 PM, Jose Fonseca wrote: > On 24/03/17 20:08, Kristian Høgsberg wrote: >> >> On Fri, Mar 24, 2017 at 12:44 PM, Jose Fonseca >> wrote: >>> >>> On 24/03/17 19:10, Kristian Høgsberg wrote: On Fri, Mar 24, 2017 at

[Mesa-dev] [PATCH v4 1/1] clover: use pipe_resource references

v2: buffers are created with one reference. v3: add pipe_resource reference to mapping object v4: rename to pres and drop inline initializers CC: "17.0 13.0" Signed-off-by: Jan Vesely --- resend to include mesa-dev ML sorry for

Re: [Mesa-dev] [RFC libdrm 0/2] Replace the build system with meson

On Tue 21 Mar 2017, Matt Turner wrote: > On Mon, Mar 20, 2017 at 12:39 PM, Emil Velikov > wrote: > > On 20 March 2017 at 18:30, Matt Turner wrote: > >> On Mon, Mar 20, 2017 at 6:55 AM, Emil Velikov > >> wrote: > >>>

Re: [Mesa-dev] [PATCH v4.1 07/28] i965/fs: generalize the legalization d2x pass

Samuel Iglesias Gonsálvez writes: > Generalize it to lower any unsupported narrower conversion. > > v2 (Curro): > - Add supports_type_conversion() > - Reuse existing intruction instead of cloning it. > - Generalize d2x to narrower and equal size conversions. > > v3 (Curro):

Re: [Mesa-dev] [RFC libdrm 0/2] Replace the build system with meson

On 24/03/17 19:10, Kristian Høgsberg wrote: On Fri, Mar 24, 2017 at 6:42 AM, Jose Fonseca wrote: On 23/03/17 01:38, Rob Clark wrote: On Wed, Mar 22, 2017 at 9:18 PM, Jonathan Gray wrote: On Wed, Mar 22, 2017 at 01:10:14PM -0700, Dylan Baker wrote: On

Re: [Mesa-dev] [PATCH 6/9] isl: Validate the calculated row pitch (v2)

On Fri, Mar 24, 2017 at 11:10 AM, Chad Versace wrote: > On Thu 23 Mar 2017, Jason Ekstrand wrote: > > On Wed, Mar 22, 2017 at 6:04 PM, Chad Versace > > wrote: > > > > > Validate that isl_surf::row_pitch fits in the below bitfields, > > > if

Re: [Mesa-dev] [RFC libdrm 0/2] Replace the build system with meson

On 24/03/17 20:08, Kristian Høgsberg wrote: On Fri, Mar 24, 2017 at 12:44 PM, Jose Fonseca wrote: On 24/03/17 19:10, Kristian Høgsberg wrote: On Fri, Mar 24, 2017 at 6:42 AM, Jose Fonseca wrote: On 23/03/17 01:38, Rob Clark wrote: On Wed, Mar

Re: [Mesa-dev] [PATCH] i965: Require Kernel 3.6 for Gen4-5 platforms.

On Wed, Mar 22, 2017 at 3:20 PM, Kenneth Graunke wrote: > We've already required Kernel 3.6 on Gen6+ since Mesa 9.2 (May 2013, > commit 92d2f5acfadea672417b6785710c9e8b7f605e41). It seems reasonable > to require it for Gen4-5 as well, bumping the requirement from 2.6.39. >

Re: [Mesa-dev] [Mesa-stable] [PATCH] i965/fs: Don't emit SEL instructions for type-converting MOVs.

On Fri, Mar 24, 2017 at 12:06 AM, Francisco Jerez wrote: > Samuel Iglesias Gonsálvez writes: > >> On Thu, 2017-03-23 at 13:50 -0700, Matt Turner wrote: >>> SEL can only convert between a few integer types, which we basically >>> never do. >>> >>>

[Mesa-dev] [Bug 99591] Segmentation fault when running vulkaninfo with RADV Radeon Vulkan driver

https://bugs.freedesktop.org/show_bug.cgi?id=99591 Luiz Angelo Daros de Luca changed: What|Removed |Added CC|

Re: [Mesa-dev] [PATCH 3/8] genxml: Rename two MCS fields to Auxiliary Surface on gen7

On Fri 24 Mar 2017, Jason Ekstrand wrote: > This makes gen7 more consistent with gen8+ > --- > src/intel/genxml/gen7.xml | 4 ++-- > src/intel/genxml/gen75.xml| 4 ++-- > src/intel/isl/isl_surface_state.c | 7 +++ > 3 files changed, 7 insertions(+), 8 deletions(-)

Re: [Mesa-dev] [RFC libdrm 0/2] Replace the build system with meson

Quoting Jose Fonseca (2017-03-24 14:16:13) > > Evaluating is one thing. Actually migrating is another. > > Brian already said he'd take a look and evaluate. And I'll help in what > I can. I agree we should all evaluate early. > > > But I don't think that the proposal of first migrate scons

[Mesa-dev] [PATCH v5 1/5] genxml: New generated header genX_bits.h (v5)

genX_bits.h contains the sizes of bitfields in genxml instructions, structures, and registers. It also defines some functions to query those sizes. isl_surf_init() will use the new header to validate that requested pitches fit in their destination bitfields. What's currently in genX_bits.h: -

[Mesa-dev] [PATCH v5 4/5] intel: Fix requests for exact surface row pitch (v2)

All callers of isl_surf_init() that set 'min_row_pitch' wanted to request an *exact* row pitch, as evidenced by nearby asserts, but isl lacked API for doing so. Now that isl has an API for that, update the code to use it. v2: Assert that isl_surf_init() succeeds because the callers assume it.

[Mesa-dev] [PATCH v5 2/5] isl: Validate the calculated row pitch (v4)

Validate that isl_surf::row_pitch fits in the below bitfields, if applicable based on isl_surf::usage. RENDER_SURFACE_STATE::SurfacePitch RENDER_SURFACE_STATE::AuxiliarySurfacePitch 3DSTATE_DEPTH_BUFFER::SurfacePitch 3DSTATE_HIER_DEPTH_BUFFER::SurfacePitch v2: -Add a Makefile

[Mesa-dev] [PATCH v5 5/5] isl: Drop unused isl_surf_init_info::min_pitch

Reviewed-by: Nanley Chery Reviewed-by: Anuj Phogat Reviewed-by: Jason Ekstrand --- src/intel/isl/isl.c | 13 +++-- src/intel/isl/isl.h | 3 --- 2 files changed, 3 insertions(+), 13 deletions(-) diff --git

Re: [Mesa-dev] [PATCH resend] mesa: Require mipmap completeness for glCopyImageSubData(), sometimes.

On Friday, March 24, 2017 6:05:36 PM PDT Roland Scheidegger wrote: > Am 24.03.2017 um 22:51 schrieb Kenneth Graunke: > > This patch makes glCopyImageSubData require mipmap completeness when the > > texture object's built-in sampler object has a mipmapping MinFilter. > > > > Fixes (on i965): > >

Re: [Mesa-dev] [PATCH] util/disk_cache: avoid making mesa subdir when cache dir is specified

I'm not sure this is a good idea. Adding an extra dir doesn't do much harm, on the other hand if MESA_GLSL_CACHE_DIR is not a newly create dir just for the cache we could run into problems. I think I'd rather leave this as is. On 25/03/17 10:06, Grazvydas Ignotas wrote: When

[Mesa-dev] [PATCH] st/mesa: move duplicated st_ws_framebuffer() function into header file

--- src/mesa/state_tracker/st_cb_fbo.h | 17 + src/mesa/state_tracker/st_cb_viewport.c | 15 +-- src/mesa/state_tracker/st_manager.c | 14 -- 3 files changed, 18 insertions(+), 28 deletions(-) diff --git a/src/mesa/state_tracker/st_cb_fbo.h

[Mesa-dev] [PATCH v5 10/18] drm/i915: Add engine reset count in get-reset-stats ioctl

Users/tests relying on the total reset count will start seeing a smaller number since most of the hangs can be handled by engine reset. Note that if reset engine x, context a running on engine y will be unaware and unaffected. To start the discussion, include just a total engine reset count. If

Re: [Mesa-dev] [PATCH] anv/cmd_buffer: Apply flush operations prior to executing secondaries

In Skia, we were running into a rendering bug where we would render to a VkImage and then immediately do another draw to a second VkImage sampling the first as a texture (with memory barrier in between). All our draws go through secondary command buffers. On certain hardware, the effects of draws

Re: [Mesa-dev] [PATCH] mesa: simplify code around 'variable_data' in marshal.c

This looks better. Thanks Brian. Reviewed-by: Timothy Arceri On 25/03/17 02:50, Brian Paul wrote: Remove needless pointer increments, unneeded vars, etc. Untested. Plus, fix a couple comments. --- src/mesa/main/marshal.c | 19 +++ 1 file changed, 7

Re: [Mesa-dev] [PATCH] tests/cache_test: mark arguments const

Pushed, Thanks! ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] util/disk_cache: don't deadlock on premature EOF

Pushed, Thanks! ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH v5 3/5] isl: Let isl_surf_init's caller set the exact row pitch (v2)

The caller does so by setting the new field isl_surf_init_info::row_pitch. v2: Validate the requested row_pitch. Reviewed-by: Jason Ekstrand (v2) --- src/intel/isl/isl.c | 14 +- src/intel/isl/isl.h | 6 ++ 2 files changed, 19 insertions(+), 1 deletion(-)

[Mesa-dev] [PATCH v5 0/5] isl: Fix requests for exact row pitch

All callers of isl_surf_init() that set 'min_pitch' wanted to request an *exact* row pitch, as evidenced by nearby asserts, but isl lacked API for doing so. This series fixes that by adding a field, isl_surf_init_info::row_pitch. This prepares for VK_MESAX_external_image_dma_buf, which requires

Re: [Mesa-dev] [PATCH 7/8] genxml: Whitespace fixes

Patches 6 and 7 are Reviewed-by: Chad Versace ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH] util/disk_cache: avoid making mesa subdir when cache dir is specified

When MESA_GLSL_CACHE_DIR is specified, we currently add a /mesa subdir even though the documentation and nearby comment in the code make no mention of it. Doesn't look useful too, remove. Signed-off-by: Grazvydas Ignotas --- src/compiler/glsl/tests/cache_test.c | 2 +-

[Mesa-dev] [PATCH] util/disk_cache: don't deadlock on premature EOF

If we get EOF earlier than expected, the current read loops will deadlock. This may easily happen if the disk cache gets corrupted. Fix it by using a helper function that handles EOF. Steps to reproduce (on a build with asserts disabled): $ glxgears $ find ~/.cache/mesa/ -type f -exec truncate -s

Re: [Mesa-dev] [RFC 11/12] anv/cmd_buffer: Emit instanced draws for multiple views

On Fri, Mar 24, 2017 at 5:53 AM, Iago Toral wrote: > On Wed, 2017-03-22 at 21:01 -0700, Jason Ekstrand wrote: > --- > src/intel/vulkan/anv_private.h | 6 ++ > src/intel/vulkan/genX_cmd_buffer.c | 141 > - >

[Mesa-dev] [PATCH] tests/cache_test: allow crossing mount points

When using an overlayfs system (like a Docker container), rmrf_local() fails because part of the files to be removed are in different mount points (layouts). And thus cache-test fails. Letting crossing mount points is not a big problem, specially because this is just for a test, not to be used in

  1   2   >