[Mesa-dev] [PATCH 0/2] anv/i965: remove copies of devinfo fields in brw_context

Hi, This is a bit of a cleanup, although it does add more lines than it removes :( We've copies of the device info fields in brw_context. Let's get rid of those and use the device info structure we have loaded at initalization. Cheers, Lionel Landwerlin (2): intel: common: break

Re: [Mesa-dev] [PATCH 02/30] i965/miptree: Rename the non_msrt_mcs functions to _ccs

On Tue, Jun 20, 2017 at 3:24 PM, Chad Versace wrote: > On Fri 16 Jun 2017, Jason Ekstrand wrote: > > While we're here, we also make the two support checks static since there > > are no users outside intel_mipmap_tree.c. > > --- > > src/mesa/drivers/dri/i965/brw_blorp.c

Re: [Mesa-dev] [PATCH] spirv: Work around the Doom shader bug

On 21 June 2017 at 08:11, Grazvydas Ignotas wrote: > On Tue, Jun 20, 2017 at 7:11 PM, Jason Ekstrand wrote: >> Doom shipped with a broken version of GLSLang which handles samplers as >> function arguments in a way that isn't spec-compliant. In

Re: [Mesa-dev] [PATCH 1/5] gallium: allow passing 'unsigned flags' to create_screen()

On 21/06/17 07:54 AM, Marek Olšák wrote: > From: Marek Olšák > > for drirc options [...] > diff --git a/src/gallium/include/state_tracker/drm_driver.h > b/src/gallium/include/state_tracker/drm_driver.h > index 88dda0a..4383276 100644 > ---

[Mesa-dev] FW: [PATCH v3 2/3] nir: Add a lowering pass for UYVY textures

Kristian, Thanks for reviewing. You are right. I had a swap in DRI formats which I have fixed in patch3. So the order is corrected here. -Original Message- From: Lin, Johnson Sent: Wednesday, June 21, 2017 11:24 AM To: mesa-dev@lists.freedesktop.org Cc: Lin, Johnson

[Mesa-dev] [PATCH 2/5] st/dri: get drirc options before creating pipe_screen

From: Marek Olšák dri_init_options_get_screen_flags will return the flags for create_screen(). --- src/gallium/state_trackers/dri/dri2.c | 17 - src/gallium/state_trackers/dri/dri_screen.c | 28 +---

[Mesa-dev] [PATCH 3/5] st/dri: add a drirc workaround for Rocket League

From: Marek Olšák This needs to be passed to gallium drivers. --- src/gallium/include/pipe/p_defines.h| 6 ++ src/gallium/state_trackers/dri/dri_screen.c | 5 + src/mesa/drivers/dri/common/drirc | 4

[Mesa-dev] [Bug 77449] Tracker bug for all bugs related to Steam titles

https://bugs.freedesktop.org/show_bug.cgi?id=77449 Bug 77449 depends on bug 98795, which changed state. Bug 98795 Summary: Rendering regression in radeonsi running mad max https://bugs.freedesktop.org/show_bug.cgi?id=98795 What|Removed |Added

[Mesa-dev] [PATCH 0/5] Gallium: Passing drirc options to create_screen() and fixing Rocket League

Hi, This series updates pipe loaders so that flags such as drirc options can be passed to create_screen(). I have compile-tested everything except clover. The first pipe_screen flag is a drirc option to fix incorrect grass rendering in Rocket League for radeonsi. Rocket League expects DirectX

[Mesa-dev] [PATCH 1/5] gallium: allow passing 'unsigned flags' to create_screen()

From: Marek Olšák for drirc options --- src/gallium/auxiliary/pipe-loader/pipe_loader.c| 4 +- src/gallium/auxiliary/pipe-loader/pipe_loader.h| 2 +- .../auxiliary/pipe-loader/pipe_loader_drm.c| 4 +- .../auxiliary/pipe-loader/pipe_loader_priv.h |

[Mesa-dev] [PATCH 5/5] radeonsi: implement the workaround for Rocket League - postponed TGSI kill

From: Marek Olšák Do KILL at the end of shaders so as not to break WQM. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=100070 --- src/gallium/drivers/radeon/r600_pipe_common.c | 5 + src/gallium/drivers/radeon/r600_pipe_common.h | 1 +

[Mesa-dev] [PATCH 4/5] gallium/radeon: pass create_screen flags to r600_common_screen_init

From: Marek Olšák --- src/gallium/auxiliary/target-helpers/drm_helper.h | 8 src/gallium/drivers/r300/r300_public.h| 2 +- src/gallium/drivers/r300/r300_screen.c| 2 +- src/gallium/drivers/r600/r600_pipe.c | 4 ++--

Re: [Mesa-dev] [PATCH 02/30] i965/miptree: Rename the non_msrt_mcs functions to _ccs

On Tue 20 Jun 2017, Jason Ekstrand wrote: > > > On Tue, Jun 20, 2017 at 3:24 PM, Chad Versace <[1]chadvers...@chromium.org> > wrote: > > On Fri 16 Jun 2017, Jason Ekstrand wrote: > > While we're here, we also make the two support checks static since there > > are no users outside

Re: [Mesa-dev] [PATCH 0/2] anv/i965: remove copies of devinfo fields in brw_context

Second patch was too large. You can find the branch here : https://github.com/djdeath/mesa/tree/drop-brw-is-has On 20/06/17 23:42, Lionel Landwerlin wrote: Hi, This is a bit of a cleanup, although it does add more lines than it removes :( We've copies of the device info fields in

Re: [Mesa-dev] [PATCH v2 2/3] nir: Add a lowering pass for UYVY textures

Thanks for the comments. I don't have a swap in other places in the patches. But I think your point is good, from the code that is a swap of U/V channels. I am suspecting there might be some bug somewhere else. Need to continue to investigate. -Original Message- From:

[Mesa-dev] [PATCH v3 3/3] i965/i915: Add UYVY as the supported format

Trigger the correct sampler options for it. Similar with YUYV --- src/intel/compiler/brw_compiler.h| 1 + src/intel/compiler/brw_nir.c | 1 + src/mesa/drivers/dri/i915/intel_screen.c | 9 ++--- src/mesa/drivers/dri/i965/brw_wm.c | 7 +++

[Mesa-dev] [PATCH v3 2/3] nir: Add a lowering pass for UYVY textures

Similar with support for YUYV but with byte order difference in sampler --- src/compiler/nir/nir.h | 1 + src/compiler/nir/nir_lower_tex.c | 18 ++ 2 files changed, 19 insertions(+) diff --git a/src/compiler/nir/nir.h b/src/compiler/nir/nir.h index

[Mesa-dev] [PATCH v3 1/3] dri: Add UYVY as available format

UYVY is diffrent with YUYV in byte order. YUYV is already declared in dri_interface.h, this CL add the difinitions for UYVY. Drivers can add UYVY as supported format --- include/GL/internal/dri_interface.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git

Re: [Mesa-dev] [PATCH 02/13] intel/blorp: Assert on gen7 fast-cleared subresource

On Tue, Jun 20, 2017 at 02:50:33PM -0700, Jason Ekstrand wrote: > On Tue, Jun 20, 2017 at 2:43 PM, Nanley Chery wrote: > > > On Mon, Jun 19, 2017 at 04:06:34PM -0700, Jason Ekstrand wrote: > > > On Tue, Jun 13, 2017 at 11:41 AM, Nanley Chery > > >

Re: [Mesa-dev] [PATCH] glsl: Fix indent in dump code

Reviewed-by: Ian Romanick On 03/06/2017 07:27 AM, Elie Tournier wrote: > From: Elie Tournier > > Signed-off-by: Elie Tournier > --- > On an other thread [1], we discovered than the GLSL compiler have some >

[Mesa-dev] [PATCH 1/2] intel: common: break has_hiz_and_separate_stencil into 2 flags

i965's brw_context needs to disable hiz under some debug flag, so break this in 2 so we can configure this at runtime. Signed-off-by: Lionel Landwerlin --- src/intel/common/gen_device_info.c | 12 src/intel/common/gen_device_info.h | 3

Re: [Mesa-dev] [PATCH 0/6] i965: Add RGBX, RGBA configs, even on gen9

On Tuesday, June 6, 2017 1:36:54 PM PDT Chad Versace wrote: > More patches to break your formats... again ;) > > The Android framework requires support for EGLConfigs with > HAL_PIXEL_FORMAT_RGBX_ and HAL_PIXEL_FORMAT_RGBA_. This prevents > Chrome OS from updating its Android drivers,

Re: [Mesa-dev] [PATCH 2/6] i965: Add a RGBX->RGBA fallback for glEGLImageTextureTarget2D()

On Wed, Jun 7, 2017 at 4:45 PM, Chad Versace wrote: > On Tue 06 Jun 2017, Daniel Stone wrote: > > Hi Chad, > > > > On 6 June 2017 at 21:36, Chad Versace wrote: > > > @@ -254,8 +255,22 @@ create_mt_for_dri_image(struct brw_context *brw, > > >

Re: [Mesa-dev] [PATCH 04/30] i965: Clamp clear colors to the representable range

On Fri 16 Jun 2017, Jason Ekstrand wrote: > Starting with Sky Lake, we can clear to arbitrary floats or integers. > Unfortunately, the hardware isn't particularly smart when it comes > sampling from that clear color. If the clear color is out of range for > the surface format, it will happily

[Mesa-dev] [PATCH v2] mesa: Add _mesa_format_fallback_rgba_to_rgbx()

From: Chad Versace The new function takes a mesa_format and, if the format is an alpha format with a non-alpha variant, returns the non-alpha format. Otherwise, it returns the original format. Example: input -> output // Fallback exists

Re: [Mesa-dev] [PATCH] st/mesa: fix assert to be simpler

Reviewed-by: Timothy Arceri On 20/06/17 15:51, Dave Airlie wrote: From: Dave Airlie I just noticed a warning with a non-debug build, but really this could all be one line, and I'm not even 100% the assert makes sense here. ---

Re: [Mesa-dev] [PATCH] st/mesa: fix assert to be simpler

Reviewed-by: Samuel Pitoiset On 06/20/2017 07:51 AM, Dave Airlie wrote: From: Dave Airlie I just noticed a warning with a non-debug build, but really this could all be one line, and I'm not even 100% the assert makes sense here. ---

Re: [Mesa-dev] [PATCH v1 2/7] etnaviv: Add return statement to etna_amode so compiler is happy

On 19 June 2017 at 20:52, Chad Versace wrote: > On Fri 16 Jun 2017, Christian Gmeiner wrote: >> 2017-06-16 14:54 GMT+02:00 Emil Velikov : >> > On 15 June 2017 at 21:47, Robert Foss wrote: >> >> From: Tomeu Vizoso

Re: [Mesa-dev] [PATCH] etnaviv: fix blend color for RB swapped rendertargets

Hi Christian, this one is a logical follow-up to my piglit fixes series. Since the other patches have landed, it would be nice if you could also land this one. Regards, Lucas Am Montag, den 05.06.2017, 21:11 +0200 schrieb Lucas Stach: > Same as with the colormasks, the blend color needs to be

Re: [Mesa-dev] [RFC PATCH] dri3: Sync after buffer swaps with glXSwapBuffers

On 06/20/2017 07:17 AM, Thomas Hellstrom wrote: On 06/20/2017 05:09 AM, Michel Dänzer wrote: On 20/06/17 03:00 AM, Thomas Hellstrom wrote: On 06/19/2017 07:44 PM, Thomas Hellstrom wrote: On 06/19/2017 07:26 PM, Eric Anholt wrote: Thomas Hellstrom writes: Applications

Re: [Mesa-dev] [RFC 00/22] DRI3 v1.1, ANV dmabuf

Hi Daniel, On 8 June 2017 at 19:43, Daniel Stone wrote: > Hi, > With full support for modifiers in DRIimage, this patch series adds > support for fully plumbing them through X11. A patchset proposing > an extension to DRI3 to support multiple planes and modifiers can > be

Re: [Mesa-dev] [PATCH v3 05/10] tgsi/text: parse _PRECISE modifier

On 16.06.2017 21:08, Karol Herbst wrote: v2: use str_match_no_case to fix _SAT_PRECISE detection Signed-off-by: Karol Herbst --- src/gallium/auxiliary/tgsi/tgsi_text.c | 17 ++--- 1 file changed, 14 insertions(+), 3 deletions(-) diff --git

Re: [Mesa-dev] [PATCH 2/2] gallium/vbuf: avoid segfault when we get invalid glDrawRangeElements()

For the series: Reviewed-by: Marek Olšák Marek On Tue, Jun 20, 2017 at 3:50 AM, Brian Paul wrote: > A common user error is to call glDrawRangeElements() with the 'end' > argument being one too large. If we use the vbuf module to translate > some vertex

Re: [Mesa-dev] [PATCH v3 05/10] tgsi/text: parse _PRECISE modifier

On Tue, Jun 20, 2017 at 12:22 PM, Nicolai Hähnle wrote: > On 16.06.2017 21:08, Karol Herbst wrote: >> >> v2: use str_match_no_case to fix _SAT_PRECISE detection >> >> Signed-off-by: Karol Herbst >> --- >> src/gallium/auxiliary/tgsi/tgsi_text.c | 17

Re: [Mesa-dev] [PATCH] radeonsi: set correct usage flag according to image access type

Reviewed-by: Marek Olšák Marek On Tue, Jun 20, 2017 at 10:24 AM, Samuel Pitoiset wrote: > Signed-off-by: Samuel Pitoiset > --- > src/gallium/drivers/radeonsi/si_descriptors.c | 4 +++- > 1 file changed, 3

Re: [Mesa-dev] [PATCH] st/mesa: fix assert to be simpler

Reviewed-by: Marek Olšák Marek On Tue, Jun 20, 2017 at 7:51 AM, Dave Airlie wrote: > From: Dave Airlie > > I just noticed a warning with a non-debug build, but really > this could all be one line, and I'm not even 100% the assert >

[Mesa-dev] [PATCH 1/2] i965: Disable access to CPU mmap for async access on non-LLC machines

If the user triggers an implicit batch flush while holding access to a CPU mapped buffer, that mmapping will be invalidated by the kernel for non-LLC devices. (The kernel when executing a batch will change the cache domain of the buffers in that batch, which for non-LLC CPU access will cause that

[Mesa-dev] [PATCH 2/2] i965: Track initial CPU domain for mappings

If we need to force a cache domain transition (e.g. a buffer was in the CPU domain and we want to access it via WC) then we need to trigger a clflush. This overrides the use of MAP_ASYNC as we call into the kernel to change domains on the whole object. v2: ASYNC cpu mmapings (on !llc) are not

Re: [Mesa-dev] [PATCH] winsys/amdgpu: fix a deadlock when waiting for submission_in_progress

On 19.06.2017 20:53, Marek Olšák wrote: From: Marek Olšák First this happens: 1) amdgpu_cs_flush (lock bo_fence_lock) -> amdgpu_add_fence_dependency -> os_wait_until_zero (wait for submission_in_progress) - WAITING 2) amdgpu_bo_create ->

[Mesa-dev] [PATCH] i965: Discard bo->map_count

Supposedly we were keeping a reference count for the number of users of a mapping so that we could use valgrind to detect access to the map outside of the valid section. However, we were incrementing the counter only when first creating the cached mapping but decrementing on every unmap. The

Re: [Mesa-dev] [PATCH] etnaviv: fix blend color for RB swapped rendertargets

Hi Lucas, > this one is a logical follow-up to my piglit fixes series. Since the > other patches have landed, it would be nice if you could also land this > one. > thanks for the gentle ping :) Will 'process' it in the evening (and will also have a look at the other open patches on the ml).

Re: [Mesa-dev] [PATCH v3 07/10] st/glsl_to_tgsi: don't optimize mul+add to mad if expression is precise

With Roland's suggestion, patches 6 & 7: Reviewed-by: Nicolai Hähnle On 16.06.2017 21:08, Karol Herbst wrote: Signed-off-by: Karol Herbst --- src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [Mesa-dev] [PATCH] etnaviv: fix blend color for RB swapped rendertargets

2017-06-20 15:28 GMT+02:00 Lucas Stach : > Am Dienstag, den 20.06.2017, 13:21 +0200 schrieb Christian Gmeiner: >> Hi Lucas, >> >> > this one is a logical follow-up to my piglit fixes series. Since the >> > other patches have landed, it would be nice if you could also land

Re: [Mesa-dev] [PATCH] etnaviv: fix blend color for RB swapped rendertargets

2017-06-05 21:11 GMT+02:00 Lucas Stach : > Same as with the colormasks, the blend color needs to be swizzled according > to the rendertarget format. > > Signed-off-by: Lucas Stach Reviewed-by: Christian Gmeiner greets -- Christian

Re: [Mesa-dev] [PATCH] [RFC] r600g: do not pick TGSI input registers at random

20.06.2017, 08:34, "Constantine Kharlamov" : > This was discussed on IRC, there was much confusion, and overall there was a > belief like the bug in some place other. A few minutes ago I was writing a > follow-up in mail because I'll have trouble replying today. > > And… for

Re: [Mesa-dev] [PATCH] st/dri: Add support for PIPE_FORMAT_RGBX8888_UNORM

On 19 June 2017 at 18:51, Lepton Wu wrote: > The original dri2_format_to_pipe_format function just misses case branch > for __DRI_IMAGE_FORMAT_XBGR. I discovered this when debugging one google > map crash inside emulator. > > Signed-off-by: Lepton Wu >

Re: [Mesa-dev] [PATCH mesa] mesa/format_info: use designated initialiser list

On 19 June 2017 at 22:39, Ian Romanick wrote: > On 06/19/2017 04:01 AM, Eric Engestrom wrote: >> Also, make that table const, since no-one is supposed to modify it anyway. > > I certainly like this, but I'm not sure we can use designated > initializers in common Mesa code

Re: [Mesa-dev] [PATCH mesa] egl: properly count configs

On 16 June 2017 at 00:55, Eric Engestrom wrote: > dri2_conf represents a similar config (which shouldn't be counted) > if its config has the ID EGL_DONT_CARE. > > Reported-by: Liu Zhiquan > Signed-off-by: Eric Engestrom > --- > >

Re: [Mesa-dev] [PATCH mesa 2/2] egl: turn one more boolean `int` into a `bool`

On 19 June 2017 at 00:49, Eric Engestrom wrote: > Same as the previous commit, but this one was split out because it's > a bit more complicated: this field is given as a pointer to a function, > so the function had to be changed as well, and the function was use in > a bunch of

Re: [Mesa-dev] [PATCH 10/15] i965/miptree: Add option to resolve offsets using isl_surf

On Fri, Jun 16, 2017 at 10:17:14AM -0700, Nanley Chery wrote: > On Tue, Jun 13, 2017 at 05:50:08PM +0300, Topi Pohjolainen wrote: > > Signed-off-by: Topi Pohjolainen > > --- > > src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 16 > > 1 file changed,

Re: [Mesa-dev] [PATCH 5/5] egl/android: Change order of EGLConfig generation

On 17 June 2017 at 03:37, Chad Versace wrote: > Many Android apps (such as Google's official NDK GLES2 example app), and > even portions the core framework code (such as SystemServiceManager in > Nougat), incorrectly choose their EGLConfig. They neglect to match the >

Re: [Mesa-dev] [PATCH] [RFC] r600g: do not pick TGSI input registers at random

Omg, nvm, it was a copy-paste error (the "input[i]"), I should've written a follow up mail. The real problem remains to be seen. Alright, later then. 20.06.2017, 10:04, "Constantine Kharlamov" : > 20.06.2017, 08:34, "Constantine Kharlamov" : >>  This was

[Mesa-dev] [PATCH] radeonsi: set correct usage flag according to image access type

Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/radeonsi/si_descriptors.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeonsi/si_descriptors.c b/src/gallium/drivers/radeonsi/si_descriptors.c index

Re: [Mesa-dev] [PATCH] st/dri: Add support for PIPE_FORMAT_RGBX8888_UNORM

Hi Lepton, On 19 June 2017 at 18:51, Lepton Wu wrote: > The original dri2_format_to_pipe_format function just misses case branch > for __DRI_IMAGE_FORMAT_XBGR. I discovered this when debugging one google > map crash inside emulator. > > Signed-off-by: Lepton Wu

Re: [Mesa-dev] [PATCH 4/4] egl/dri2: add image extension to swrast_core_extensions

On 19 June 2017 at 20:46, Chad Versace wrote: > On Thu 15 Jun 2017, Gurchetan Singh wrote: >> Emil, would you be fine with leaving the image extension in dri2.c but still >> adding it as a drisw extension? That solution would look like: >> >>

Re: [Mesa-dev] [PATCH v2 02/10] i965: Track initial CPU domain for mappings

Quoting Kenneth Graunke (2017-06-20 00:33:35) > On Monday, June 19, 2017 3:55:01 AM PDT Chris Wilson wrote: > > If we need to force a cache domain transition (e.g. a buffer was in the > > CPU domain and we want to access it via WC) then we need to trigger a > > clflush. This overrides the use of

Re: [Mesa-dev] [PATCH mesa 1/2] egl: turn boolean `int`s into `bool`s

On 19 June 2017 at 00:49, Eric Engestrom wrote: > Signed-off-by: Eric Engestrom Reviewed-by: Emil Velikov Couple of random thoughts below. > + bool invalidate_available; > + bool

Re: [Mesa-dev] [PATCH] egl/android: config id increase one by one

> -Original Message- > From: Emil Velikov [mailto:emil.l.veli...@gmail.com] > Sent: Thursday, June 15, 2017 9:59 PM > To: Liu, Zhiquan > Cc: ML mesa-dev ; Long, Zhifang > ; Rob Herring ;

Re: [Mesa-dev] [PATCH 2/5] egl/android: Declare 'const' the EGLConfig attribs template array

On 17 June 2017 at 03:37, Chad Versace wrote: > No behavioral change. Just a cleanup. > > Post-patch, we no longer modify the same array on each iteration of the > inner loop of droid_add_configs_for_visuals(). Instead, we just declare > the array as const inside the

Re: [Mesa-dev] [RFC] etnaviv: flush color cache and depth cache together before resolves

On Tue, May 30, 2017 at 12:50:07PM +0200, Philipp Zabel wrote: > Before resolving a rendertarget or a depth/stencil resource into a > texture, flush both the color cache and the depth cache together. > > It is unclear whether this is necessary for the following stall to > work properly, or

[Mesa-dev] dri3 flipping to fake front?

Michel, Eric, others Do you know what's stopping dri3 from flipping to the fake front instead of copying? Like below? The fake front will of course be "busy" until the server completes the present, but that doesn't really stop us from front rendering to it or reading from it if so desired?

[Mesa-dev] [PATCH] radeonsi: don't emit partial flushes at the end of IBs (v2)

From: Marek Olšák The kernel sort of does the same thing with fences. v2: do emit partial flushes on SI --- src/gallium/drivers/radeonsi/si_hw_context.c | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git

[Mesa-dev] [PATCH] mesa: simplify _mesa_IsVertexArray()

_mesa_lookup_vao() already returns NULL if id is zero. Signed-off-by: Samuel Pitoiset --- src/mesa/main/arrayobj.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/src/mesa/main/arrayobj.c b/src/mesa/main/arrayobj.c index

Re: [Mesa-dev] [RFC 01/22] RFC: egl/x11: Support DRI3 v1.1

Hi Daniel, Top-level comments Build POV: - Having the XCB_DRI3_.*_VERSION compile guards is Ok for now. But let's drop those as get a xcb release. We dont want to be in cases where Mesa is built w/o DRI3 1.1 support and one spends time debugging why "nothing works". Couple of ideas/questions

[Mesa-dev] [PATCH 0/1] Last i965/meta fix for my mega series

Hi, This fixes the texture decompression path for i965 that this uncommitted patch of mine broke: https://cgit.freedesktop.org/~mareko/mesa/commit/?h=mesa-cpu-optz=b7ae4ddc15507d13c7019426dd4800872e211600 It was the last blocker for pushing my mega patch series that decreases CPU overhead for

[Mesa-dev] [PATCH] meta: do the full FBO completeness check in decompress_texture_image

From: Marek Olšák _mesa_update_state will no longer recompute Width/Height if the framebuffer is complete. We now rely on the FBO completeness check to do it. The only code that needs to be fixed seems to be this one. --- src/mesa/drivers/common/meta.c | 5 + 1 file

Re: [Mesa-dev] [libdrm 4/4] etnaviv: support performance monitor requests

On Fri, Jun 09, 2017 at 12:27:37PM +0200, Christian Gmeiner wrote: > Add etna_cmd_stream_perf(..) to submit perform requests. > Userspace can submit pmrs via submit ioctl to sample perfmon > signals. Comment in-line. > Signed-off-by: Christian Gmeiner > --- >

Re: [Mesa-dev] [PATCH] etnaviv: fix blend color for RB swapped rendertargets

On Mon, Jun 05, 2017 at 09:11:02PM +0200, Lucas Stach wrote: > Same as with the colormasks, the blend color needs to be swizzled according > to the rendertarget format. Yes, indeed. Reviewed-by: Wladimir J. van der Laan > Signed-off-by: Lucas Stach > --- >

Re: [Mesa-dev] [libdrm 2/4] etnaviv: sync uapi header

On Fri, Jun 09, 2017 at 12:27:35PM +0200, Christian Gmeiner wrote: > Import the etnaviv header changes from kernel commits x > > The drm_etnaviv_gem_submit structure was extended to include performance > monitor requests. Also two new ioctls got added to readout performance > monitor domains

Re: [Mesa-dev] [PATCH mesa] mesa/format_info: use designated initialiser list

On 06/19/2017 03:39 PM, Ian Romanick wrote: On 06/19/2017 04:01 AM, Eric Engestrom wrote: Also, make that table const, since no-one is supposed to modify it anyway. I certainly like this, but I'm not sure we can use designated initializers in common Mesa code due to MSVC. Brian? They

[Mesa-dev] [PATCH] intel: compiler/i965: fix is_broxton checks

In 5f2fe9302c is_geminilake was introduced for the differenciate broxton from geminilake. Unfortunately I failed as verifying that is_broxton is throughout the code base to mean Gen9lp. Fixes: 5f2fe9302c ("intel: common: add flag to identify platforms by name") Signed-off-by: Lionel Landwerlin

Re: [Mesa-dev] [PATCH] etnaviv: fix blend color for RB swapped rendertargets

Am Dienstag, den 20.06.2017, 13:21 +0200 schrieb Christian Gmeiner: > Hi Lucas, > > > this one is a logical follow-up to my piglit fixes series. Since the > > other patches have landed, it would be nice if you could also land this > > one. > > > > thanks for the gentle ping :) Will 'process' it

Re: [Mesa-dev] [libdrm 3/4] etnaviv: add permon support

On Fri, Jun 09, 2017 at 12:27:36PM +0200, Christian Gmeiner wrote: > Query all domains and their signals and provide it this information > via struct etna_perfmon and the corresponding api functions. Comments in-line. > Signed-off-by: Christian Gmeiner > --- >

Re: [Mesa-dev] [PATCH] etnaviv: add rs-operations sw query

On Fri, Jun 09, 2017 at 12:34:49PM +0200, Christian Gmeiner wrote: > It could be useful to get the number of emited resolve operations when > doing driver optimizations. Nothing to add, seems useful and correct. (though RS operations are better than falling back on the software blit path -

Re: [Mesa-dev] [PATCH] spirv: Work around the Doom shader bug

On Tue, Jun 20, 2017 at 12:19 PM, Pierre-Loup A. Griffais < pgriff...@valvesoftware.com> wrote: > They gave us access to a build with the fix and I believe Dave confirmed > the fix was looking good by running it against a mainline build of radv. I > can't comment on what their planned timeline is

Re: [Mesa-dev] [PATCH] st/mesa: don't invoke st_convert_sampler for TBOs

This makes sense, it fixes the crash. Reviewed-by: Samuel Pitoiset On 06/20/2017 09:34 PM, Marek Olšák wrote: From: Marek Olšák --- This precedes: https://cgit.freedesktop.org/~mareko/mesa/log/?h=mesa-cpu-optz st_convert_sampler shouldn't be

Re: [Mesa-dev] [PATCH] radeonsi: use the correct LLVMTargetMachineRef in si_build_shader_variant

I have just tested this patch with Hero Siege, it still crashes. As you said, it's definitely a multithreading issue because it crashes differently all the time. Let me know if you need more information. On 06/19/2017 01:40 PM, Nicolai Hähnle wrote: From: Nicolai Hähnle

Re: [Mesa-dev] [PATCH 30/31] mesa: don't flag _NEW_PROGRAM_CONSTANTS for GLSL programs for st/mesa

You need to update _mesa_uniform_handle() as well because the handles won't be propagated if you don't do that. With that fixed, patch is: Reviewed-by: Samuel Pitoiset On 06/12/2017 06:55 PM, Marek Olšák wrote: From: Marek Olšák ---

Re: [Mesa-dev] [PATCH] spirv: Work around the Doom shader bug

They gave us access to a build with the fix and I believe Dave confirmed the fix was looking good by running it against a mainline build of radv. I can't comment on what their planned timeline is for releasing it or whether it's going to be released for sure, but it seems that title is going

Re: [Mesa-dev] [PATCH 11/24] st/mesa: sink and simplify texBaseFormat getting for sampler states

On 06/20/2017 09:30 PM, Marek Olšák wrote: On Tue, Jun 20, 2017 at 9:26 PM, Samuel Pitoiset wrote: _mesa_base_tex_image() returns NULL for bindless textures and this crashes. See below. Thanks. Is it a texture buffer object? st_convert_sampler will crash if it's

[Mesa-dev] [PATCH] st/mesa: don't invoke st_finalize_texture & st_convert_sampler for TBOs

From: Marek Olšák This is a v2 of the previous patch (v1 didn't skip st_finalize_texture). --- src/mesa/state_tracker/st_cb_texture.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/src/mesa/state_tracker/st_cb_texture.c

Re: [Mesa-dev] [PATCH 05/13] anv: Add and use color auxiliary buffer helpers

On Mon, Jun 19, 2017 at 05:03:51PM -0700, Jason Ekstrand wrote: > On Mon, Jun 19, 2017 at 4:46 PM, Nanley Chery wrote: > > > On Mon, Jun 19, 2017 at 04:16:32PM -0700, Jason Ekstrand wrote: > > > On Tue, Jun 13, 2017 at 11:41 AM, Nanley Chery > > >

[Mesa-dev] [PATCH 02/10] mesa: add KHR_no_error support for glStencilFuncSeparate()

Signed-off-by: Samuel Pitoiset --- src/mapi/glapi/gen/gl_API.xml | 2 +- src/mesa/main/stencil.c | 9 + src/mesa/main/stencil.h | 4 3 files changed, 14 insertions(+), 1 deletion(-) diff --git a/src/mapi/glapi/gen/gl_API.xml

[Mesa-dev] [PATCH 01/10] mesa: add stencil_func_separate() helper

Signed-off-by: Samuel Pitoiset --- src/mesa/main/stencil.c | 45 - 1 file changed, 28 insertions(+), 17 deletions(-) diff --git a/src/mesa/main/stencil.c b/src/mesa/main/stencil.c index b303bb7c13f..78a09072b29 100644 ---

[Mesa-dev] [PATCH] egl/android: Change order of EGLConfig generation (v2)

Many Android apps (such as Google's official NDK GLES2 example app), and even portions the core framework code (such as SystemServiceManager in Nougat), incorrectly choose their EGLConfig. They neglect to match the EGLConfig's EGL_NATIVE_VISUAL_ID against the window's native format, and instead

Re: [Mesa-dev] [PATCH 01/30] i965/miptree: Delete the layered rendering resolve

On Fri 16 Jun 2017, Jason Ekstrand wrote: > We never fast-clear more than the base slice (LOD 0, layer 0) anyway, so > layered rendering without a resolve is always perfectly safe. Should > this ever change in the future, we'll have to put some sort of resolve > back in but we can cross that

Re: [Mesa-dev] [PATCH 10/10] mesa: add KHR_no_error support for glStencilOp()

Series: Reviewed-by: Timothy Arceri On 21/06/17 07:18, Samuel Pitoiset wrote: Signed-off-by: Samuel Pitoiset --- src/mapi/glapi/gen/gl_API.xml | 2 +- src/mesa/main/stencil.c | 8 src/mesa/main/stencil.h | 2 ++ 3

Re: [Mesa-dev] [PATCH] intel: compiler/i965: fix is_broxton checks

On Tuesday, June 20, 2017 5:23:00 AM PDT Lionel Landwerlin wrote: > In 5f2fe9302c is_geminilake was introduced for the differenciate > broxton from geminilake. Unfortunately I failed as verifying that > is_broxton is throughout the code base to mean Gen9lp. > > Fixes: 5f2fe9302c ("intel: common:

Re: [Mesa-dev] [PATCH] spirv: Work around the Doom shader bug

I've been told by Pierre that there is an update, but it just hasn't been pushed out yet. He'd know better when it's supposed to be released. On Tue, Jun 20, 2017 at 9:11 AM, Jason Ekstrand wrote: > Doom shipped with a broken version of GLSLang which handles samplers as >

Re: [Mesa-dev] [PATCH] meta: do the full FBO completeness check in decompress_texture_image

This patch is Reviewed-by: Ian Romanick Tested-by: Ian Romanick On 06/20/2017 06:29 AM, Marek Olšák wrote: > From: Marek Olšák > > _mesa_update_state will no longer recompute Width/Height if the framebuffer > is

Re: [Mesa-dev] [PATCH] radeonsi: use the correct LLVMTargetMachineRef in si_build_shader_variant

On 06/20/2017 10:53 PM, Samuel Pitoiset wrote: I have just tested this patch with Hero Siege, it still crashes. As you said, it's definitely a multithreading issue because it crashes differently all the time. Let me know if you need more information. FWIW, "Peace, Death!" and "Riptale"

Re: [Mesa-dev] [PATCH 02/30] i965/miptree: Rename the non_msrt_mcs functions to _ccs

On Fri 16 Jun 2017, Jason Ekstrand wrote: > While we're here, we also make the two support checks static since there > are no users outside intel_mipmap_tree.c. > --- > src/mesa/drivers/dri/i965/brw_blorp.c | 2 +- > src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 45 >

Re: [Mesa-dev] [PATCH 11/24] st/mesa: sink and simplify texBaseFormat getting for sampler states

_mesa_base_tex_image() returns NULL for bindless textures and this crashes. See below. Thread 41 "OGL_Dispatch_3" received signal SIGSEGV, Segmentation fault. [Switching to Thread 0x7ffee973e700 (LWP 17264)] 0x7fffdfdf0b61 in st_convert_sampler (st=st@entry=0x9497ef0,

Re: [Mesa-dev] [PATCH] st/mesa: don't invoke st_convert_sampler for TBOs

Actually, this patch is not totally correct. st_finalize_texture() shouldn't be called for TBOs as well (otherwise we hit an assertion). Can you update the patch, please? Thanks! On 06/20/2017 09:34 PM, Marek Olšák wrote: From: Marek Olšák --- This precedes:

Re: [Mesa-dev] [PATCH 01/13] intel/blorp: Assert on subresource in surface_info_init

On Mon, Jun 19, 2017 at 04:05:04PM -0700, Jason Ekstrand wrote: > General comment: "Subresource" is not a term that we've historically used > outside of Vulkan. Maybe better to just say "intel/blorp: Assert that > levels and layers are in range" > Looks like I'll have to send out a V2, so I'll

Re: [Mesa-dev] [PATCH 02/13] intel/blorp: Assert on gen7 fast-cleared subresource

On Mon, Jun 19, 2017 at 04:06:34PM -0700, Jason Ekstrand wrote: > On Tue, Jun 13, 2017 at 11:41 AM, Nanley Chery > wrote: > > > Signed-off-by: Nanley Chery > > --- > > src/intel/blorp/blorp_clear.c | 4 > > 1 file changed, 4 insertions(+) >

Re: [Mesa-dev] [PATCH 11/24] st/mesa: sink and simplify texBaseFormat getting for sampler states

On Tue, Jun 20, 2017 at 9:26 PM, Samuel Pitoiset wrote: > _mesa_base_tex_image() returns NULL for bindless textures and this crashes. > See below. Thanks. Is it a texture buffer object? st_convert_sampler will crash if it's a texture buffer object. The standard sampler

Re: [Mesa-dev] [PATCH] i965: Resolve framebuffers before signaling the fence

Quoting Chad Versace (2017-06-20 18:08:14) > On Mon 19 Jun 2017, Chris Wilson wrote: > > Quoting Chad Versace (2017-06-19 19:42:16) > > > On Mon 12 Jun 2017, Chris Wilson wrote: > > > > brw_emit_mi_flush(brw); > > > > > > > > switch (fence->type) { > > > > @@ -335,6 +363,8 @@

Re: [Mesa-dev] [RFC 01/22] RFC: egl/x11: Support DRI3 v1.1

On Tue, Jun 20, 2017 at 8:18 AM, Daniel Stone wrote: > Hey Emil, > A few bits from me, since this is actually lfrb's code ... > > On 20 June 2017 at 15:19, Emil Velikov wrote: >> Top-level comments >> >> Build POV: >> - Having the

Re: [Mesa-dev] [PATCH] st/mesa: don't invoke st_finalize_texture & st_convert_sampler for TBOs

Yeah, looks good now, thanks! Reviewed-by: Samuel Pitoiset On 06/20/2017 10:04 PM, Marek Olšák wrote: From: Marek Olšák This is a v2 of the previous patch (v1 didn't skip st_finalize_texture). --- src/mesa/state_tracker/st_cb_texture.c | 10

  1   2   >