[Mesa-dev] [Bug 97957] Awful screen tearing in a separate X server with DRI3

https://bugs.freedesktop.org/show_bug.cgi?id=97957 --- Comment #21 from Marcin Mielniczuk --- Thanks for fixing! I had a similar problems when using the modesetting driver, I'll check if it's gone when this gets into a release. For completeness, I describe how the

[Mesa-dev] [PATCH] etnaviv: Clear lbl_usage array correctly

Fill the entire array instead of just a quarter. This avoids crashes with large shaders. (currently this never causes a problem because shaders larger than 2048/4 instructions are not supported by this driver on any hardware, but it will cause problems in the future) Signed-off-by: Wladimir J.

Re: [Mesa-dev] [PATCH] swr: fix transform feedback logic

On Jul 23, 2017, at 11:21 AM, Ilia Mirkin > wrote: On Sun, Jul 23, 2017 at 12:08 PM, George Kyriazis > wrote: The shader that is used to copy vertex data out of the vs/gs shaders to the

Re: [Mesa-dev] [PATCH] swr: fix transform feedback logic

On Jul 23, 2017, at 1:42 PM, Rowley, Timothy O > wrote: On Jul 23, 2017, at 11:08 AM, George Kyriazis > wrote: The shader that is used to copy vertex data out of the

Re: [Mesa-dev] [PATCH] swr: fix transform feedback logic

On Sun, Jul 23, 2017 at 12:08 PM, George Kyriazis wrote: > The shader that is used to copy vertex data out of the vs/gs shaders to > the user-specified buffer (streamout os SO shader) was not using the > correct offsets. > > Adjust the offsets that are used just for the

[Mesa-dev] [PATCH] swr: fix transform feedback logic

The shader that is used to copy vertex data out of the vs/gs shaders to the user-specified buffer (streamout os SO shader) was not using the correct offsets. Adjust the offsets that are used just for the SO shader: - Make sure that position is handled in the same special way as in the vs/gs

Re: [Mesa-dev] [PATCH] swr: fix transform feedback logic

> On Jul 23, 2017, at 11:08 AM, George Kyriazis > wrote: > > The shader that is used to copy vertex data out of the vs/gs shaders to > the user-specified buffer (streamout os SO shader) was not using the > correct offsets. > > Adjust the offsets that are used just

[Mesa-dev] [PATCH] amdgpu/addrlib: use initialization list in addrobject

Just a small patch to save a small amount of cycles, as it would be better to use the initialization list here. Bare with me if I sent this wrong, I don't typically use git-send-email. Mystro256 (1): amdgpu/addrlib: use initialization list in addrobject src/amd/addrlib/core/addrobject.cpp |

[Mesa-dev] [PATCH] amdgpu/addrlib: use initialization list in addrobject

--- src/amd/addrlib/core/addrobject.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/amd/addrlib/core/addrobject.cpp b/src/amd/addrlib/core/addrobject.cpp index dcdb1bf..ee2d9a9 100644 --- a/src/amd/addrlib/core/addrobject.cpp +++

Re: [Mesa-dev] [PATCH] swr: fix transform feedback logic

On Sun, Jul 23, 2017 at 12:27 PM, Kyriazis, George wrote: > > On Jul 23, 2017, at 11:21 AM, Ilia Mirkin wrote: > > On Sun, Jul 23, 2017 at 12:08 PM, George Kyriazis > wrote: > > The shader that is used to copy vertex

Re: [Mesa-dev] [PATCH] swr: fix transform feedback logic

On Jul 23, 2017, at 1:51 PM, Ilia Mirkin > wrote: On Sun, Jul 23, 2017 at 12:27 PM, Kyriazis, George > wrote: On Jul 23, 2017, at 11:21 AM, Ilia Mirkin

Re: [Mesa-dev] [PATCH] etnaviv: Clear lbl_usage array correctly

2017-07-23 13:24 GMT+02:00 Wladimir J. van der Laan : > Fill the entire array instead of just a quarter. This avoids > crashes with large shaders. > (currently this never causes a problem because shaders larger than 2048/4 > instructions are not supported by this driver on any

Re: [Mesa-dev] [PATCH 2/2] nv50/ir: improve POW lowering

This approach is generally right but implemented in the wrong place. This "lowerPOW" happens pre-ssa. What actually needs to happen is that this type of optimization is done at SSA time as part of ConstantFolding. And the fallback for POW should be implemented as part of the "legalize" step. That

Re: [Mesa-dev] [PATCH 7/7] i965: Drop non-LLC lunacy in the program cache code.

On Saturday, July 22, 2017 2:28:06 AM PDT Chris Wilson wrote: > Considering the prevalence of sse4.1, another candidate is > brw_get_buffer_subdata(), we could use a WC map there as well. Your thinking is...avoid polluting the CPU cache, since we're basically going to be reading a continuous

Re: [Mesa-dev] threaded opengl

On 24/07/17 10:44, Mike Lothian wrote: I think you also need to provide info on how much of a speed up it provides because some games are slower with glthread Providing the CPU and GPU combo used for testing would also be useful so it can be noted in the commit message. This would be useful

[Mesa-dev] [PATCH] radv: allow buffers to be shareable as well.

From: Dave Airlie Buffers should report dedicated flags as well, so report the same information for them as for images. (alternately we can turn dedicated off for buffers maybe?) Fixes CTS dEQP-VK.api.external.memory.opaque_fd.dedicated.buffer.info Fixes: b70829708a (radv:

[Mesa-dev] i965 use STD430 packing by default

shared (the default) and packed layouts are decided by the implementation. Currently we just pack them using the std140 layout. This change makes it so we use the slightly more compact std430 layout on i965. The number of changes in patch 4 is a little unfortunate however I decided this was

[Mesa-dev] [PATCH 1/5] compiler: move glsl_interface_packing enum to shader_enums.h

This allows us to drop the duplicate gl_uniform_block_packing enum. --- src/compiler/glsl/link_uniform_blocks.cpp | 11 +-- src/compiler/glsl_types.h | 9 ++--- src/compiler/shader_enums.h | 7 +++ src/mesa/main/mtypes.h| 11

Re: [Mesa-dev] [PATCH 1/2] egl/android: remove HAL_PIXEL_FORMAT_BGRA_8888 support

On Wed, Jul 12, 2017 at 1:34 AM, Rob Herring wrote: > On Tue, Jul 11, 2017 at 9:34 AM, Tomasz Figa wrote: >> On Tue, Jul 11, 2017 at 11:16 PM, Rob Herring wrote: >>> On Tue, Jul 11, 2017 at 8:27 AM, Emil Velikov

Re: [Mesa-dev] [PATCH 5/5] i965/clear: Don't perform redundant depth clears

I just remembered that we never merged these. IIRC, it's about 3% on Manhattan. On June 14, 2017 6:54:41 PM Jason Ekstrand wrote: We already have this little optimization for color clears. Now that we're actually tracking whether or not a slice has any fast-clear

Re: [Mesa-dev] [PATCH] radv: for external memory imports close the fd on import success

Reciewed-by: Jason Ekstrand On July 23, 2017 7:51:44 PM Dave Airlie wrote: From: Dave Airlie If we get an fd, we need to close it before returning. Fixes CTS test

[Mesa-dev] [PATCH 5/5] i965: enable STD430 packing by default on IVB+

--- src/mesa/drivers/dri/i965/brw_context.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_context.c b/src/mesa/drivers/dri/i965/brw_context.c index d0b22d4..426adfa 100644 --- a/src/mesa/drivers/dri/i965/brw_context.c +++

[Mesa-dev] [PATCH 4/5] glsl: pass UseSTD430AsDefaultPacking to where it will be used

Here we also make use of the UseSTD430AsDefaultPacking constant and call the new get_internal_ifc_packing() helper. --- src/compiler/glsl/ir_optimization.h | 2 +- src/compiler/glsl/link_uniform_blocks.cpp | 17 +++ src/compiler/glsl/link_uniforms.cpp | 50

[Mesa-dev] [PATCH 3/5] glsl: add get_internal_ifc_packing() type helper

This is used to avoid code duplication when selecting the packing type for shared and packed layouts. --- src/compiler/glsl_types.h | 21 + 1 file changed, 21 insertions(+) diff --git a/src/compiler/glsl_types.h b/src/compiler/glsl_types.h index f67465e..3c18f6c 100644 ---

[Mesa-dev] [PATCH 2/5] mesa: add UseSTD430AsDefaultPacking constant

This will be used to enable the STD430 layout as the default for UBOs and SSBOs with layouts of shared/packed rather than STD140. --- src/mesa/main/mtypes.h | 9 + 1 file changed, 9 insertions(+) diff --git a/src/mesa/main/mtypes.h b/src/mesa/main/mtypes.h index 4970329..751ff7c 100644

Re: [Mesa-dev] [PATCH 1/2] egl/android: remove HAL_PIXEL_FORMAT_BGRA_8888 support

On Mon, Jul 24, 2017 at 1:00 PM, Tomasz Figa wrote: > On Wed, Jul 12, 2017 at 1:34 AM, Rob Herring wrote: >> On Tue, Jul 11, 2017 at 9:34 AM, Tomasz Figa wrote: >>> On Tue, Jul 11, 2017 at 11:16 PM, Rob Herring wrote:

Re: [Mesa-dev] [PATCH] configure.ac: rework wayland-protocols handling

On Mon, 2017-07-24 at 01:27 +0300, Andres Gomez wrote: > This is: > > Reviewed-by: Andres Gomez Mmmm ... I hit the send button too quickly. Just wanted to mention that I share the same concerns than Daniel. Would it be up to me, I would not be adding the generated files in

Re: [Mesa-dev] [PATCH 2/2] egl: add linux-dmabuf-unstable-v1-protocol.c to "nodist"

I'll be pushing already 1/2 and keep this on hold to see whether we favor instead: https://lists.freedesktop.org/archives/mesa-dev/2017-July/163730.html On Thu, 2017-07-20 at 01:44 +0300, Andres Gomez wrote: > This fixes `make distcheck` > > > make[3]: *** No rule to make target > >

Re: [Mesa-dev] [PATCH 1/2] mesa: pass the 'caller' function to create_samplers()

On 21/07/17 22:42, Samuel Pitoiset wrote: To return GL_OUT_OF_MEMORY if NewSamplerObject fails. Signed-off-by: Samuel Pitoiset --- src/mesa/main/samplerobj.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/mesa/main/samplerobj.c

[Mesa-dev] [PATCH] radv: Handle VK_ATTACHMENT_UNUSED in color attachments.

This just sets them to INVALID COLOR, instead of shifting the attachments together. This also fixes a number of cases where we use it first and only then check if it is VK_ATTACHMENT_UNUSED. Signed-off-by: Bas Nieuwenhuizen Fixes: f4e499ec791 "radv: add initial non-conformant

Re: [Mesa-dev] [PATCH] egl/wayland: Fix linking libEGL_common.la

If I try and compile mesa with clang (even using ld.bfd) I get these errors: libtool: link: clang++ -m32 -fvisibility=hidden -Werror=pointer-arith -Werror=vla -O2 -march=native -pipe -Wall -fno-math-errno -fno-trapping-math -Qunused-arguments -O2 -march=native -pipe -fuse-ld=bfd -o glsl_compiler

Re: [Mesa-dev] Call for community testing: OpenGL multithreading is ready

~30% perfomance increase name= siyia ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] threaded opengl

sorry executable is "mb_warband_linux" start.sh or mb_warband.sh are local scripts to start the game so: ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [Bug 101867] Launch options window renders black in Feral Games in current Mesa trunk

https://bugs.freedesktop.org/show_bug.cgi?id=101867 Michel Dänzer changed: What|Removed |Added Attachment #132819|0 |1 is

Re: [Mesa-dev] [PATCH] configure.ac: rework wayland-protocols handling

This is: Reviewed-by: Andres Gomez On Fri, 2017-07-21 at 13:02 +0100, Emil Velikov wrote: > From: Emil Velikov > > At dist/distcheck time we need to ensure that all the files and their > respective dependencies are handled. > > At the moment

[Mesa-dev] [PATCH] radv: Don't segfault when exporting an image which hasn't been bound yet.

The image is set on Memory allocation already, but the image doesn't have to have the BindImageMemory called yet. Luckily, we know offset within a BO has to be 0 for dedicated allocations, so we can just use the dummy 0 in the address calaculations. Fixes CTS test

Re: [Mesa-dev] [PATCH 036/101] mesa: add delete_vertex_arrays() helper

On 22/07/17 03:39, Samuel Pitoiset wrote: Signed-off-by: Samuel Pitoiset --- src/mesa/main/arrayobj.c | 24 1 file changed, 16 insertions(+), 8 deletions(-) diff --git a/src/mesa/main/arrayobj.c b/src/mesa/main/arrayobj.c index

Re: [Mesa-dev] threaded opengl

I think you also need to provide info on how much of a speed up it provides because some games are slower with glthread On Mon, 24 Jul 2017 at 01:33 siyia wrote: > sorry executable is "mb_warband_linux" start.sh or mb_warband.sh are > local scripts to start the game so: >

Re: [Mesa-dev] [PATCH 2/2] mesa: return GL_OUT_OF_MEMORY if NewSamplerObject fails

please see the comment in patch 1. Otherwise 1-2 are: Reviewed-by: Timothy Arceri On 21/07/17 22:42, Samuel Pitoiset wrote: This is similar to other functions that create objects. Signed-off-by: Samuel Pitoiset ---

Re: [Mesa-dev] [PATCH] st/mesa: create framebuffer iface hash table per st manager

Can you explain in the comment how/why this fixes the crash? It's not obvious to me. Patch looks OK, AFAICT. Reviewed-by: Brian Paul On 07/23/2017 05:37 PM, Charmaine Lee wrote: With this patch, framebuffer interface hash table is created per state tracker manager.

Re: [Mesa-dev] [PATCH] egl/wayland: Fix linking libEGL_common.la

This is only an issue when using ld.gold, ld.bfd works fine which is probably why no one else has seen it. It only started being a problem when the dmabuff stuff landed and the makefiles were cleaned up I tried playing around with the dummy.cpp but I couldn't get it to trigger the c++ compiler

[Mesa-dev] [PATCH] st/mesa: create framebuffer iface hash table per st manager

With this patch, framebuffer interface hash table is created per state tracker manager. Fixes crash with steam. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=101876 Fixes: 5124bf98239 ("st/mesa: add destroy_drawable interface") Tested-by: Christoph Haag ---

Re: [Mesa-dev] [PATCH 043/101] mesa: add KHR_no_error support to glPrimitiveRestartIndex()

38-43: Reviewed-by: Timothy Arceri ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH] radv: for external memory imports close the fd on import success

From: Dave Airlie If we get an fd, we need to close it before returning. Fixes CTS test dEQP-VK.api.external.memory.opaque_fd.dedicated.device_only.import_multiple_times Fixes: b70829708a (radv: Implement VK_KHR_external_memory) Signed-off-by: Dave Airlie