Re: [Mesa-dev] [PATCH 11/29] anv/cmd_buffer: Add a mark_image_written helper

2018-01-13 Thread Jason Ekstrand
On Wed, Dec 13, 2017 at 4:46 PM, Nanley Chery wrote: > On Mon, Nov 27, 2017 at 07:06:01PM -0800, Jason Ekstrand wrote: > > Currently, this helper does nothing but we call it every place where an > > image is written through the render pipeline. This will allow us to > >

Re: [Mesa-dev] [Test Patch] Meson: ensure vdpau has proper symbols exposed

2018-01-13 Thread haagch+mesadev
This patch makes vdpau work here too on RX 480. vaapi has the same problem. I tried doing an analog patch and also had to set libva_version = ['1', '0', '0'] in src/gallium/state_trackers/va/meson.build because libva on arch only tries to call __vaDriverInit_1_0 on arch. The autotools makefile

[Mesa-dev] [PATCH 1/2] meson: set proper pkg-config version for libdrm_freedreno

2018-01-13 Thread Dylan Baker
Copy and paste error from exynos. Signed-off-by: Dylan Baker --- freedreno/meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/freedreno/meson.build b/freedreno/meson.build index b4035e1..de6a413 100644 --- a/freedreno/meson.build +++

Re: [Mesa-dev] [PATCH 4/7] report.py: Add option to only display the final summary

2018-01-13 Thread Dylan Baker
Quoting Ian Romanick (2018-01-12 12:06:58) > From: Ian Romanick > > This is useful for preparing data to go in a Mesa commit message. > > Signed-off-by: Ian Romanick > --- > report.py | 60

Re: [Mesa-dev] [PATCH 5/7] report.py: Add option to only display measurements that have changes

2018-01-13 Thread Dylan Baker
Quoting Ian Romanick (2018-01-12 12:06:59) > From: Ian Romanick > > This is useful for preparing data to go in a Mesa commit message. > > Signed-off-by: Ian Romanick > --- > report.py | 53

[Mesa-dev] [PATCH 0/2] Small fixes for the meson build

2018-01-13 Thread Dylan Baker
Here's a few things I've caught as I've started trying to add the meson build to our CI system. Dylan Baker (2): meson: set proper pkg-config version for libdrm_freedreno meson: set the minimum version correctly freedreno/meson.build | 2 +- meson.build | 2 +- 2 files changed, 2

Re: [Mesa-dev] [PATCH 11/29] anv/cmd_buffer: Add a mark_image_written helper

2018-01-13 Thread Jason Ekstrand
On Thu, Jan 11, 2018 at 5:14 PM, Nanley Chery wrote: > On Thu, Nov 30, 2017 at 06:20:51PM +0200, Pohjolainen, Topi wrote: > > On Mon, Nov 27, 2017 at 07:06:01PM -0800, Jason Ekstrand wrote: > > > Currently, this helper does nothing but we call it every place where an > > >

Re: [Mesa-dev] [PATCH 11/29] anv/cmd_buffer: Add a mark_image_written helper

2018-01-13 Thread Jason Ekstrand
On Sat, Jan 13, 2018 at 9:55 AM, Jason Ekstrand wrote: > On Wed, Dec 13, 2017 at 4:46 PM, Nanley Chery > wrote: > >> On Mon, Nov 27, 2017 at 07:06:01PM -0800, Jason Ekstrand wrote: >> > Currently, this helper does nothing but we call it every place

Re: [Mesa-dev] [PATCH 1/2] meson: Fix configuring dri glx with only gallium drivers

2018-01-13 Thread Dylan Baker
meson considers classic swrast to be a dri driver, I know it's not exactly accurate, but, at least for me, it made the build system easier to reason about. Quoting Adam Jackson (2018-01-12 09:06:37) > On Fri, 2018-01-12 at 13:18 +, Jon Turney wrote: > > 'meson -Ddri-drivers=

Re: [Mesa-dev] [PATCH 1/2] meson: Fix configuring dri glx with only gallium drivers

2018-01-13 Thread Dylan Baker
Maybe this is correct, but it makes me nervous treating with_gallium as equivalent to with_dri, since gallium drivers can be built dri-less (gallium-xlib, and some other configurations on windows). I think something like: with_glx = get_option('glx') if with_glx == 'auto' if with_dri

[Mesa-dev] [PATCH 2/2] meson: set the minimum version correctly

2018-01-13 Thread Dylan Baker
Currently we ask for 0.42, but we actually require 0.43 because we pass file objects as arguments to tests. If someone needs version 0.42 it wouldn't be hard, just a lot of replacing files() with strings. Signed-off-by: Dylan Baker --- meson.build | 2 +- 1 file

Re: [Mesa-dev] [PATCH 06/29] anv/image: Add a helper for determining when fast clears are supported

2018-01-13 Thread Jason Ekstrand
Sorry for all the list spam, but I'm sort of thinking out-loud and writing it on the list for all to read. I'm thinking that what we want this list to return is not a bool but an enum /* The ordering of this enum is important */ enum anv_fast_clear_support { ANV_FAST_CLEAR_NONE = 0,

Re: [Mesa-dev] [PATCH 01/10] mesa: Also track a remapped version of the color logic op

2018-01-13 Thread Jason Ekstrand
On January 12, 2018 14:56:26 "Ian Romanick" wrote: From: Ian Romanick With the exception of NVIDIA hardware, these are is the values that all hardware and Gallium want. The remapping is currently implemented in at least 6 places. This starts

[Mesa-dev] [Bug 104214] Dota crashes when switching from game to desktop

2018-01-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=104214 --- Comment #54 from Jason Ekstrand --- (In reply to Thomas Hellström from comment #53) > So IMHO we should try to write piglit tests for the areas where we know > there are remaining issues. That's a reasonable thing to

[Mesa-dev] [Bug 102891] [radv] glitches on rpcs3 emulator (green zones)

2018-01-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=102891 jdr...@gmail.com changed: What|Removed |Added Resolution|--- |FIXED Status|NEEDINFO

[Mesa-dev] [Bug 100430] [radv] graphical glitches on dolphin emulator

2018-01-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=100430 --- Comment #14 from jdr...@gmail.com --- Still present in 17.3.2 -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug.___ mesa-dev mailing

Re: [Mesa-dev] [PATCH 11/29] anv/cmd_buffer: Add a mark_image_written helper

2018-01-13 Thread Pohjolainen, Topi
On Thu, Jan 11, 2018 at 05:14:57PM -0800, Nanley Chery wrote: > On Thu, Nov 30, 2017 at 06:20:51PM +0200, Pohjolainen, Topi wrote: > > On Mon, Nov 27, 2017 at 07:06:01PM -0800, Jason Ekstrand wrote: > > > Currently, this helper does nothing but we call it every place where an > > > image is

[Mesa-dev] [Bug 104214] Dota crashes when switching from game to desktop

2018-01-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=104214 --- Comment #53 from Thomas Hellström --- (In reply to Jason Ekstrand from comment #51) > Can we write a piglit test or two that reproduces this bug? It would be > very good if had a nice self-contained test that we can

Re: [Mesa-dev] [PATCH 29/29] anv: Use blorp_ccs_ambiguate instead of fast-clears

2018-01-13 Thread Pohjolainen, Topi
On Mon, Nov 27, 2017 at 07:06:19PM -0800, Jason Ekstrand wrote: > Even though the blorp pass looks a bit on the sketchy side, the end > result in the Vulkan driver is very nice. Instead of having this weird > case where you do a fast clear and then maybe have to resolve, we just > do the

Re: [Mesa-dev] [Test Patch] Meson: ensure vdpau has proper symbolsexposed

2018-01-13 Thread Marc Dietrich
Hi Dylan, Am Donnerstag, 11. Januar 2018, 18:24:42 CET schrieb Dylan Baker: > Signed-off-by: Dylan Baker > --- > src/gallium/targets/vdpau/meson.build | 16 +--- > 1 file changed, 13 insertions(+), 3 deletions(-) this makes the symbol (and a few more)

[Mesa-dev] [PATCH v2] ac/nir: fix translation of nir_op_b2i for doubles

2018-01-13 Thread Timothy Arceri
V2: just zero-extend the 32-bit value. Fixes a number of int64 piglet tests, for example: generated_tests/spec/arb_gpu_shader_int64/execution/conversion/frag-conversion-explicit-bool-int64_t.shader_test --- src/amd/common/ac_nir_to_llvm.c | 12 +--- 1 file changed, 9 insertions(+), 3

Re: [Mesa-dev] [PATCH 2/2] ac: add doubles support to isign

2018-01-13 Thread Bas Nieuwenhuizen
Reviewed-by: Bas Nieuwenhuizen for the series. On Sun, Jan 14, 2018 at 12:09 AM, Timothy Arceri wrote: > Fixes a number of int64 piglit tests, for example: > >

[Mesa-dev] [PATCH 2/2] radv: Use the CS bo for other uploads too.

2018-01-13 Thread Bas Nieuwenhuizen
If an app keeps building and resetting the command buffers, most command buffers will have 1 CS bo and 1 upload bo. This merges them by allocating uploads from the end of the CS bo. On dota2, this goes from ~700 to ~400 BOs after the merging in the create_bo_list. Sadly no discernible

Re: [Mesa-dev] [PATCH] ac: remove ac_shader_variant_info::fs::output_mask

2018-01-13 Thread Timothy Arceri
Reviewed-by: Timothy Arceri On 13/01/18 00:21, Samuel Pitoiset wrote: Unused. Signed-off-by: Samuel Pitoiset --- src/amd/common/ac_nir_to_llvm.c | 2 -- src/amd/common/ac_nir_to_llvm.h | 1 - 2 files changed, 3 deletions(-) diff --git

Re: [Mesa-dev] [PATCH 13/29] anv/cmd_buffer: Rework aux tracking

2018-01-13 Thread Jason Ekstrand
On Fri, Jan 5, 2018 at 4:34 PM, Nanley Chery wrote: > On Mon, Nov 27, 2017 at 07:06:03PM -0800, Jason Ekstrand wrote: > > This makes us start tracking two bits per level for aux to describe both > > whether or not something is fast-cleared and whether or not it is > >

[Mesa-dev] [PATCH 2/2] ac: add doubles support to isign

2018-01-13 Thread Timothy Arceri
Fixes a number of int64 piglit tests, for example: generated_tests/spec/arb_gpu_shader_int64/execution/built-in-functions/fs-sign-i64vec2.shader_test --- src/amd/common/ac_nir_to_llvm.c | 25 ++--- 1 file changed, 18 insertions(+), 7 deletions(-) diff --git

Re: [Mesa-dev] [PATCH v2] ac/nir: fix translation of nir_op_b2i for doubles

2018-01-13 Thread Bas Nieuwenhuizen
Reviewed-by: Bas Nieuwenhuizen On Sat, Jan 13, 2018 at 11:52 PM, Timothy Arceri wrote: > V2: just zero-extend the 32-bit value. > > Fixes a number of int64 piglet tests, for example: > >

[Mesa-dev] [PATCH 1/2] ac: add i64_0 and i64_1 to llvm build context

2018-01-13 Thread Timothy Arceri
These will be used in the following patch. --- src/amd/common/ac_llvm_build.c | 2 ++ src/amd/common/ac_llvm_build.h | 2 ++ 2 files changed, 4 insertions(+) diff --git a/src/amd/common/ac_llvm_build.c b/src/amd/common/ac_llvm_build.c index f0a1788eaf..3467bba693 100644 ---

[Mesa-dev] [PATCH 1/2] radv: Add bo argument to upload functions.

2018-01-13 Thread Bas Nieuwenhuizen
--- src/amd/vulkan/radv_cmd_buffer.c | 37 +++-- src/amd/vulkan/radv_meta_buffer.c | 5 +++-- src/amd/vulkan/radv_private.h | 6 -- src/amd/vulkan/si_cmd_buffer.c| 5 +++-- 4 files changed, 33 insertions(+), 20 deletions(-) diff --git