Re: [Mesa-dev] [PATCH 08/17] loader: Fix compiler warnings about truncating the PCI ID path.

2018-02-13 Thread Eric Anholt
Ian Romanick writes: > On 02/10/2018 08:33 AM, Eric Anholt wrote: >> My build was producing: >> >> ../src/loader/loader.c:121:67: warning: ‘%1u’ directive output may be >> truncated writing between 1 and 3 bytes into a region of size 2 >> [-Wformat-truncation=] >> >>

[Mesa-dev] [Bug 105068] vulkaninfo gives an VK_ERROR_INITIALIZATION_FAILED

2018-02-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105068 --- Comment #2 from Pietro Pesci Feltri --- OpenGL renderer string: AMD BONAIRE (DRM 2.50.0 / 4.14.16-300.fc27.x86_64, LLVM 5.0.0) I changed the file /etc/default/gub to: cat /etc/default/grub GRUB_TIMEOUT=5

[Mesa-dev] [v5 PATCH 2/2] nir/spirv: add gl_spirv_validation method

2018-02-13 Thread Alejandro Piñeiro
ARB_gl_spirv adds the ability to use SPIR-V binaries, and a new method, glSpecializeShader. From OpenGL 4.6 spec, section 7.2.1 "Shader Specialization", error table: INVALID_VALUE is generated if does not name a valid entry point for . INVALID_VALUE is generated if any element

[Mesa-dev] [PATCH 1/2] spirv: add vtn_builder_create

2018-02-13 Thread Alejandro Piñeiro
Refactored from spirv_to_nir, in order to be reused later. --- src/compiler/spirv/spirv_to_nir.c | 48 ++- src/compiler/spirv/vtn_private.h | 4 2 files changed, 36 insertions(+), 16 deletions(-) diff --git a/src/compiler/spirv/spirv_to_nir.c

Re: [Mesa-dev] [PATCH 6/7] vulkan: Add new VK_MESA_query_timestamp extension

2018-02-13 Thread Lionel Landwerlin
On 13/02/18 00:20, Dylan Baker wrote: Quoting Keith Packard (2018-02-09 20:45:15) This extension adds a single function to query the current GPU timestamp, just like glGetInteger64v(GL_TIMESTAMP, ). This function is needed to complete the implementation of GOOGLE_display_timing, which needs to

Re: [Mesa-dev] How to know which exact llvm version to build/link against?

2018-02-13 Thread Eric Engestrom
On Tuesday, 2018-02-13 01:44:53 -0800, Andrew A. wrote: > On Wed, Feb 7, 2018 at 1:37 AM, Michel Dänzer wrote: > > For a non-current snapshot of Mesa Git master, one may have to find an > > LLVM SVN snapshot from around the same time. > > Just so I understand, a statement

[Mesa-dev] [PATCH] mesa: add glsl version query (v4)

2018-02-13 Thread Vadym Shovkoplias
Add support for GL_NUM_SHADING_LANGUAGE_VERSIONS and glGetStringi for GL_SHADING_LANGUAGE_VERSION v2: - Combine similar functionality into _mesa_get_shading_language_version() function. - Change GLSL version return mechanism. v3: - Add return of empty string for GLSL ver 1.10. - Move

Re: [Mesa-dev] How to know which exact llvm version to build/link against?

2018-02-13 Thread Andrew A.
On Wed, Feb 7, 2018 at 1:37 AM, Michel Dänzer wrote: > For a non-current snapshot of Mesa Git master, one may have to find an > LLVM SVN snapshot from around the same time. Just so I understand, a statement like "Try repro'ing the bug in svn commit x of mesa from last year"

Re: [Mesa-dev] [PATCH v4 02/12] meson: add libswdri and libswkmsdri tolink_with unconditionally

2018-02-13 Thread Marc Dietrich
Hi Dylan, Am Montag, 12. Februar 2018, 20:27:42 CET schrieb Dylan Baker: > Fixes: 6b4c7047d571 ("meson: build gallium nine state_tracker") > Signed-off-by: Dylan Baker > --- > src/gallium/targets/d3dadapter9/meson.build | 13 +++-- > 1 file changed, 3

[Mesa-dev] [Bug 104329] Vulkan app crashes GPU

2018-02-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=104329 Bas Nieuwenhuizen changed: What|Removed |Added Status|NEW |NEEDINFO

[Mesa-dev] [Bug 105068] vulkaninfo gives an VK_ERROR_INITIALIZATION_FAILED

2018-02-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105068 Bas Nieuwenhuizen changed: What|Removed |Added Status|NEW |NEEDINFO

Re: [Mesa-dev] Mesa 17.3.4 release candidate

2018-02-13 Thread James Legg
The conflict resolution on this commit has a typo, it should use (index + i) instead of (index + 1). ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH] ac/nir: Fix conflict resolution typo in handle_vs_input_decl

2018-02-13 Thread James Legg
Fixes ad764e365beb8a119369b97f5cb95fc7ea8c: "ac/nir: Use instance_rate_inputs per attribute, not per variable". CC: CC: Emil Velikov CC: Bas Nieuwenhuizen --- src/amd/common/ac_nir_to_llvm.c | 2 +- 1

[Mesa-dev] [PATCH] mesa: add missing switch case for EXTRA_VERSION_40 in check_extra()

2018-02-13 Thread Brian Paul
The EXTRA_VERSION_40 predicate is tested as part of extra_gl40_ARB_sample_shading but there was no switch case for it. --- src/mesa/main/get.c | 5 + 1 file changed, 5 insertions(+) diff --git a/src/mesa/main/get.c b/src/mesa/main/get.c index 2188017..57a2118 100644 --- a/src/mesa/main/get.c

Re: [Mesa-dev] [PATCH] tgsi: Recognize RET in main for tgsi_transform

2018-02-13 Thread Jose Fonseca
It looks good to me. Though I think it would be useful to track nesting of subroutines and other control flow separately, and throw a warning when we ignore RETs on the main subroutine that are not on the top-most level of the control flow stack. So it's easier to spot when that problem

Re: [Mesa-dev] [PATCH v4 02/12] meson: add libswdri and libswkmsdri tolink_with unconditionally

2018-02-13 Thread Eric Engestrom
On Tuesday, 2018-02-13 10:29:08 +0100, Marc Dietrich wrote: > Hi Dylan, > > Am Montag, 12. Februar 2018, 20:27:42 CET schrieb Dylan Baker: > > Fixes: 6b4c7047d571 ("meson: build gallium nine state_tracker") > > Signed-off-by: Dylan Baker > > --- > >

Re: [Mesa-dev] [PATCH 08/17] loader: Fix compiler warnings about truncating the PCI ID path.

2018-02-13 Thread Emil Velikov
On 10 February 2018 at 16:33, Eric Anholt wrote: > My build was producing: > > ../src/loader/loader.c:121:67: warning: ‘%1u’ directive output may be > truncated writing between 1 and 3 bytes into a region of size 2 > [-Wformat-truncation=] > > and we can avoid this careful

Re: [Mesa-dev] [PATCH v3 4/8] radeon/uvd:add uvd hevc enc hw ib implementation

2018-02-13 Thread James Zhu
On 2018-02-10 11:20 AM, Mark Thompson wrote: On 09/02/18 20:35, James Zhu wrote: Implement required IBs for UVD HEVC encode. Signed-off-by: James Zhu --- src/gallium/drivers/radeon/radeon_uvd_enc_1_1.c | 1115 +++ 1 file changed, 1115 insertions(+)

Re: [Mesa-dev] [PATCH 4/4] ac/nir: rename nir_to_llvm_context to radv_shader_context

2018-02-13 Thread Bas Nieuwenhuizen
Reviewed-by: Bas Nieuwenhuizen for the series. On Mon, Feb 12, 2018 at 12:57 PM, Samuel Pitoiset wrote: > There is still more to do in that area, but it's a good start. > > Signed-off-by: Samuel Pitoiset > --- >

[Mesa-dev] [PATCH v5 4/8] radeon/uvd:add uvd hevc enc hw ib implementation

2018-02-13 Thread James Zhu
Implement required IBs for UVD HEVC encode. Signed-off-by: James Zhu --- src/gallium/drivers/radeon/radeon_uvd_enc_1_1.c | 1132 +++ 1 file changed, 1132 insertions(+) create mode 100644 src/gallium/drivers/radeon/radeon_uvd_enc_1_1.c diff --git

Re: [Mesa-dev] [PATCH 08/17] loader: Fix compiler warnings about truncating the PCI ID path.

2018-02-13 Thread Eric Engestrom
On Saturday, 2018-02-10 16:33:01 +, Eric Anholt wrote: > My build was producing: > > ../src/loader/loader.c:121:67: warning: ‘%1u’ directive output may be > truncated writing between 1 and 3 bytes into a region of size 2 > [-Wformat-truncation=] > > and we can avoid this careful

Re: [Mesa-dev] [PATCH 09/16] vulkan/wsi: Add multiple planes to wsi_image_base

2018-02-13 Thread Daniel Stone
Hi Jason, This should be titled '... wsi_image', not '... wsi_image_base'. On 9 February 2018 at 23:43, Jason Ekstrand wrote: > diff --git a/src/vulkan/wsi/wsi_common_private.h > b/src/vulkan/wsi/wsi_common_private.h > index 503b2a0..c5002ec 100644 > ---

[Mesa-dev] [Bug 105068] vulkaninfo gives an VK_ERROR_INITIALIZATION_FAILED

2018-02-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105068 --- Comment #3 from Pietro Pesci Feltri --- BTW: uname -a Linux xx.dsl.cantv.net 4.14.16-300.fc27.x86_64 #1 SMP Wed Jan 31 19:24:27 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux On Tue, Feb 13, 2018 at 9:57 AM,

Re: [Mesa-dev] [PATCH 09/17] spirv: Silence compiler warning about undefined srcs[0]

2018-02-13 Thread Eric Engestrom
On Monday, 2018-02-12 13:52:23 -0800, Ian Romanick wrote: > On 02/10/2018 08:33 AM, Eric Anholt wrote: > > It doesn't know that elems >= 1. > > Does adding assume(elems >= 1) help? Indeed, I was going to reply this too; I think a number of "let's always initialise to shut the compiler up"

Re: [Mesa-dev] [PATCH] mesa: add glsl version query (v4)

2018-02-13 Thread Brian Paul
On 02/13/2018 05:07 AM, Vadym Shovkoplias wrote: Add support for GL_NUM_SHADING_LANGUAGE_VERSIONS and glGetStringi for GL_SHADING_LANGUAGE_VERSION v2: - Combine similar functionality into _mesa_get_shading_language_version() function. - Change GLSL version return mechanism. v3: -

Re: [Mesa-dev] [PATCH] ac/nir: Fix conflict resolution typo in handle_vs_input_decl

2018-02-13 Thread Bas Nieuwenhuizen
Reviewed-by: Bas Nieuwenhuizen On Tue, Feb 13, 2018 at 5:05 PM, James Legg wrote: > Fixes ad764e365beb8a119369b97f5cb95fc7ea8c: > "ac/nir: Use instance_rate_inputs per attribute, not per variable". > > CC:

Re: [Mesa-dev] [PATCH] mesa: add missing switch case for EXTRA_VERSION_40 in check_extra()

2018-02-13 Thread Eric Engestrom
On Tuesday, 2018-02-13 09:29:26 -0700, Brian Paul wrote: > The EXTRA_VERSION_40 predicate is tested as part of > extra_gl40_ARB_sample_shading but there was no switch case for it. Fixes: 77b440e42d8e7247c2295 "mesa: Add new functions and enums required by

[Mesa-dev] [PATCH] tgsi: Recognize RET in main for tgsi_transform

2018-02-13 Thread sroland
From: Roland Scheidegger Shaders coming from dx10 state trackers have a RET before the END. And the epilog needs to be placed before the RET (otherwise it will get ignored). Hence figure out if a RET is in main, in this case we'll place the epilog there rather than before the

[Mesa-dev] [PATCH v2] mesa: add glsl version query (v4)

2018-02-13 Thread Vadym Shovkoplias
Add support for GL_NUM_SHADING_LANGUAGE_VERSIONS and glGetStringi for GL_SHADING_LANGUAGE_VERSION v2: - Combine similar functionality into _mesa_get_shading_language_version() function. - Change GLSL version return mechanism. v3: - Add return of empty string for GLSL ver 1.10. - Move

Re: [Mesa-dev] [PATCH v2 0/8] The 2nd version for UVD HEVC encode

2018-02-13 Thread James Zhu
Hi Mark, Did you still encounter hung issue? If yes, could you share me with your play and transcode streams and command line, then I can try to reproduce at my side. Thanks & Best Regards! James Zhu On 2018-02-10 11:06 AM, Mark Thompson wrote: On 08/02/18 23:05, Mark Thompson wrote: On

Re: [Mesa-dev] [PATCH] tgsi: Recognize RET in main for tgsi_transform

2018-02-13 Thread Jose Fonseca
On 13/02/18 17:57, srol...@vmware.com wrote: From: Roland Scheidegger Shaders coming from dx10 state trackers have a RET before the END. And the epilog needs to be placed before the RET (otherwise it will get ignored). Hence figure out if a RET is in main, in this case

Re: [Mesa-dev] [PATCH] etnaviv: add useful information to BO import errors

2018-02-13 Thread Christian Gmeiner
2018-02-12 15:25 GMT+01:00 Lucas Stach : > From: Philipp Zabel > > Signed-off-by: Philipp Zabel Reviewed-by: Christian Gmeiner > --- > src/gallium/drivers/etnaviv/etnaviv_resource.c | 8

Re: [Mesa-dev] [PATCH 11/16] vulkan/wsi: Add modifiers support to wsi_create_native_image

2018-02-13 Thread Daniel Stone
Hi Jason, On 9 February 2018 at 23:43, Jason Ekstrand wrote: > + uint32_t image_modifier_count = 0, modifier_prop_count = 0; > + struct wsi_format_modifier_properties *modifier_props = NULL; > + uint64_t *image_modifiers = NULL; > + if (num_modifier_lists == 0) { >

Re: [Mesa-dev] [PATCH 1/3] etnaviv: add debug switch to disable single buffer feature

2018-02-13 Thread Christian Gmeiner
2018-02-06 10:36 GMT+01:00 Lucas Stach : > This feature has caused some trouble already. Add a debug switch to > allow users to quickly check if a specific issue is caused by this > feature. > > Signed-off-by: Lucas Stach Reviewed-by: Christian

[Mesa-dev] [PATCH 06/16] intel/icl: Do StateCacheInvalidation for indirect clear color

2018-02-13 Thread Anuj Phogat
StateCacheInvalidation is required on all gen7+ platforms. We don't need to update this check for every new gen h/w unless this requirement is changed. So, dropping the check for latest gen h/w. Signed-off-by: Anuj Phogat --- src/intel/blorp/blorp_genX_exec.h | 2 +- 1

[Mesa-dev] [PATCH 16/16] i965/icl: Add render target flush after uploading binding table

2018-02-13 Thread Anuj Phogat
From PIPE_CONTROL command description in gfxspecs: "Whenever a Binding Table Index (BTI) used by a Render Taget Message points to a different RENDER_SURFACE_STATE, SW must issue a Render Target Cache Flush by enabling this bit. When render target flush is set due to new association of BTI, PS

[Mesa-dev] [PATCH 14/16] i965/icl: Disable HiZ surface sampling

2018-02-13 Thread Anuj Phogat
On gen11+ AUX_HIZ is not a supported value for surfaces being sampled by the 3D sampler. Signed-off-by: Anuj Phogat --- src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git

Re: [Mesa-dev] [PATCH 00/16] Prepare to add Ice Lake (ICL) support

2018-02-13 Thread Anuj Phogat
This series is also available at: https://github.com/aphogat/mesa.git Branch: review On Tue, Feb 13, 2018 at 11:15 AM, Anuj Phogat wrote: > > This series prepares the driver to enable Ice Lake support > in i965 driver. It adds gen11.xml, wires up the build > infrastructure

Re: [Mesa-dev] [PATCH 12/16] anv/image: Separate modifiers from legacy scanout

2018-02-13 Thread Daniel Stone
Hi Jason, On 9 February 2018 at 23:43, Jason Ekstrand wrote: > - /* For images using modifiers, we require a dedicated allocation > - * and we set the BO tiling to match the tiling of the underlying > - * modifier. This is a bit unfortunate as

Re: [Mesa-dev] [PATCH 13/16] anv/image: Add support for modifiers for WSI

2018-02-13 Thread Daniel Stone
Hi Jason, On 9 February 2018 at 23:43, Jason Ekstrand wrote: > +static void > +get_wsi_format_modifier_properties_list(const struct anv_physical_device > *physical_device, > +VkFormat vk_format, > +

[Mesa-dev] [PATCH 04/16] intel/isl/icl: Add the maximum surface size limit

2018-02-13 Thread Anuj Phogat
Signed-off-by: Anuj Phogat --- src/intel/isl/isl.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/intel/isl/isl.c b/src/intel/isl/isl.c index 59f512fc05..c9873d96df 100644 --- a/src/intel/isl/isl.c +++ b/src/intel/isl/isl.c @@ -1483,7 +1483,7

[Mesa-dev] [PATCH 00/16] Prepare to add Ice Lake (ICL) support

2018-02-13 Thread Anuj Phogat
This series prepares the driver to enable Ice Lake support in i965 driver. It adds gen11.xml, wires up the build infrastructure and make ICL specific changes suggested by h/w documentation. This series carry about 50% of all the changes required to enable Ice Lake. I (or someone else in the team)

Re: [Mesa-dev] [PATCH v2] mesa: add glsl version query (v4)

2018-02-13 Thread Brian Paul
Looks good. I wrote a new piglit test to exercise this. I'll cc you on the review request for it. Thanks for your persistence on this! I'll re-test and push this soon. Reviewed-by: Brian Paul On 02/13/2018 11:10 AM, Vadym Shovkoplias wrote: Add support for

Re: [Mesa-dev] [PATCH 07/14] anv/cmd_buffer: Decide whether or not to HiZ clear up-front

2018-02-13 Thread Nanley Chery
On Mon, Feb 05, 2018 at 02:34:56PM -0800, Jason Ekstrand wrote: > This moves the decision out of begin_subpass and into BeginRenderPass > like the decision for color clears. We use a similar name for the > function for depth/stencil as for color even though no aux usage is > really getting

[Mesa-dev] [PATCH 02/16] intel/genxml/icl: Generate packing headers

2018-02-13 Thread Anuj Phogat
Signed-off-by: Anuj Phogat --- src/intel/Android.genxml.mk | 5 + src/intel/Makefile.sources| 3 ++- src/intel/genxml/genX_pack.h | 2 ++ src/intel/genxml/gen_macros.h | 3 +++ 4 files changed, 12 insertions(+), 1 deletion(-) diff --git

[Mesa-dev] [PATCH 15/16] i965/icl: Enable float blend optimization and Wa3DStateMode

2018-02-13 Thread Anuj Phogat
Signed-off-by: Anuj Phogat --- src/mesa/drivers/dri/i965/brw_state_upload.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/brw_state_upload.c b/src/mesa/drivers/dri/i965/brw_state_upload.c index 2c8c0f4b27..86c12e4d35 100644

[Mesa-dev] [PATCH 05/16] intel/isl/icl: Build and use gen11 surface state emit functions

2018-02-13 Thread Anuj Phogat
Signed-off-by: Anuj Phogat --- src/intel/Android.isl.mk | 20 src/intel/Makefile.isl.am | 4 src/intel/Makefile.sources | 4 src/intel/isl/isl.c| 3 +++ src/intel/isl/isl_priv.h | 3 +++ src/intel/isl/meson.build | 2 +- 6

[Mesa-dev] [PATCH 11/16] i965/icl: Update the assert in brw_memory_barrier()

2018-02-13 Thread Anuj Phogat
Nothing is changed here from gen10 to gen11. So, just update the assert. Signed-off-by: Anuj Phogat --- src/mesa/drivers/dri/i965/brw_program.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/brw_program.c

[Mesa-dev] [PATCH 13/16] i965/icl: Add assertions to check dispatch mode is SIMD8

2018-02-13 Thread Anuj Phogat
SIMD4x2 dispatch mode has been removed in GEN11. We're not using it anyways in Mesa. Adding few asserts to make it explicit. Signed-off-by: Anuj Phogat --- src/intel/blorp/blorp_genX_exec.h | 4 src/mesa/drivers/dri/i965/genX_state_upload.c | 5 + 2

[Mesa-dev] [PATCH 03/16] intel/genxml/icl: Update genx_bits header

2018-02-13 Thread Anuj Phogat
Signed-off-by: Anuj Phogat --- src/intel/genxml/gen_bits_header.py | 1 + 1 file changed, 1 insertion(+) diff --git a/src/intel/genxml/gen_bits_header.py b/src/intel/genxml/gen_bits_header.py index 1b3504073b..965a74ed89 100644 --- a/src/intel/genxml/gen_bits_header.py

[Mesa-dev] [PATCH 09/16] i965/icl: Update the comment for maximum number of threads per PSD

2018-02-13 Thread Anuj Phogat
Signed-off-by: Anuj Phogat --- src/intel/blorp/blorp_genX_exec.h | 9 + src/mesa/drivers/dri/i965/genX_state_upload.c | 9 + 2 files changed, 10 insertions(+), 8 deletions(-) diff --git a/src/intel/blorp/blorp_genX_exec.h

[Mesa-dev] [PATCH 08/16] i965/icl: Build and use gen11 functions for genxml state-upload and blorp

2018-02-13 Thread Anuj Phogat
Signed-off-by: Anuj Phogat --- src/mesa/drivers/dri/i965/Android.mk | 24 +++- src/mesa/drivers/dri/i965/Makefile.am| 6 +- src/mesa/drivers/dri/i965/Makefile.sources | 4 src/mesa/drivers/dri/i965/brw_blorp.c| 4

[Mesa-dev] [PATCH 07/16] i965/icl: Don't set ResetGatewayTimer

2018-02-13 Thread Anuj Phogat
This field is removed in gen11+ Signed-off-by: Anuj Phogat --- src/mesa/drivers/dri/i965/genX_state_upload.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/mesa/drivers/dri/i965/genX_state_upload.c b/src/mesa/drivers/dri/i965/genX_state_upload.c index

[Mesa-dev] [PATCH 12/16] i965/icl: Update switch statements

2018-02-13 Thread Anuj Phogat
Signed-off-by: Anuj Phogat --- src/mesa/drivers/dri/i965/brw_formatquery.c | 1 + src/mesa/drivers/dri/i965/intel_screen.c| 1 + 2 files changed, 2 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_formatquery.c b/src/mesa/drivers/dri/i965/brw_formatquery.c

[Mesa-dev] [PATCH 10/16] i965/icl: Define and use icl mocs settings

2018-02-13 Thread Anuj Phogat
Gen11 MOCS settings are duplicate of Gen10 MOCS settings. Signed-off-by: Anuj Phogat --- src/mesa/drivers/dri/i965/brw_state.h| 6 ++ src/mesa/drivers/dri/i965/brw_wm_surface_state.c | 2 ++ src/mesa/drivers/dri/i965/genX_state_upload.c| 4 +++- 3

Re: [Mesa-dev] [PATCH 08/14] anv/cmd_buffer: Iterate all subpass attachments when clearing

2018-02-13 Thread Nanley Chery
On Mon, Feb 05, 2018 at 02:34:57PM -0800, Jason Ekstrand wrote: > This unifies things a bit because we now handle depth and stencil at the > same time. It also ensures that clears happen for input attachments. As we discussed in another patch, clears are always guaranteed to happen for input

Re: [Mesa-dev] [PATCH 09/16] vulkan/wsi: Add multiple planes to wsi_image_base

2018-02-13 Thread Jason Ekstrand
On Tue, Feb 13, 2018 at 7:29 AM, Daniel Stone wrote: > Hi Jason, > This should be titled '... wsi_image', not '... wsi_image_base'. > Fixed. > On 9 February 2018 at 23:43, Jason Ekstrand wrote: > > diff --git a/src/vulkan/wsi/wsi_common_private.h >

Re: [Mesa-dev] [PATCH 11/16] vulkan/wsi: Add modifiers support to wsi_create_native_image

2018-02-13 Thread Jason Ekstrand
On Tue, Feb 13, 2018 at 10:27 AM, Daniel Stone wrote: > Hi Jason, > > On 9 February 2018 at 23:43, Jason Ekstrand wrote: > > + uint32_t image_modifier_count = 0, modifier_prop_count = 0; > > + struct wsi_format_modifier_properties *modifier_props

[Mesa-dev] [PATCH 05/31] swr/rast: Cleanup of mpPrivateContext in Builder

2018-02-13 Thread George Kyriazis
Provide access functions for mpPrivateContext in Builder. --- src/gallium/drivers/swr/rasterizer/jitter/builder.cpp | 3 ++- src/gallium/drivers/swr/rasterizer/jitter/builder.h | 10 ++ src/gallium/drivers/swr/rasterizer/jitter/fetch_jit.cpp | 5 +++-- 3 files changed, 15

[Mesa-dev] [PATCH 08/31] swr/rast: Clean up event types and remove BE events

2018-02-13 Thread George Kyriazis
Begin/End events not needed anymore. --- .../drivers/swr/rasterizer/archrast/archrast.cpp | 4 -- .../drivers/swr/rasterizer/archrast/events.proto | 76 -- 2 files changed, 80 deletions(-) diff --git a/src/gallium/drivers/swr/rasterizer/archrast/archrast.cpp

[Mesa-dev] [PATCH] ac: Use the renumbered const address space for LLVM 7.

2018-02-13 Thread Bas Nieuwenhuizen
The LLVM AMDGPU backend decided to renumber the constant address space --- src/amd/common/ac_llvm_build.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/amd/common/ac_llvm_build.h b/src/amd/common/ac_llvm_build.h index e78e9589cf..a4d80cd8b0 100644 ---

[Mesa-dev] [PATCH 01/31] swr/rast: Add missing parameter to a few gather functions

2018-02-13 Thread George Kyriazis
We now pass pDawContext as a default parameter --- src/gallium/drivers/swr/rasterizer/jitter/builder_mem.cpp | 12 ++-- src/gallium/drivers/swr/rasterizer/jitter/builder_mem.h | 10 +- 2 files changed, 11 insertions(+), 11 deletions(-) diff --git

[Mesa-dev] [PATCH 28/31] swr/rast: Add semantics for translating address

2018-02-13 Thread George Kyriazis
Added support for another full translation path in fetch jitter. --- src/gallium/drivers/swr/rasterizer/jitter/builder_mem.h | 1 + src/gallium/drivers/swr/rasterizer/jitter/fetch_jit.cpp | 4 2 files changed, 5 insertions(+) diff --git

[Mesa-dev] [PATCH 24/31] swr/rast: Make SIMDLib templated types easier to use

2018-02-13 Thread George Kyriazis
"typename SIMD_T::TypeName" --> "TypeName" --- .../drivers/swr/rasterizer/common/simdlib.hpp | 9 + src/gallium/drivers/swr/rasterizer/core/binner.cpp | 338 ++--- src/gallium/drivers/swr/rasterizer/core/binner.h | 18 +- src/gallium/drivers/swr/rasterizer/core/clip.h

[Mesa-dev] [PATCH 17/31] swr/rast: Misc cleanup

2018-02-13 Thread George Kyriazis
Together with correct detection of clipDistance NaNs when no cullDistance is set --- src/gallium/drivers/swr/rasterizer/core/clip.h| 2 +- src/gallium/drivers/swr/rasterizer/core/context.h | 26 src/gallium/drivers/swr/rasterizer/core/state.h | 81 +-- 3 files

[Mesa-dev] [PATCH 27/31] swr/rast: Fix SRL call with a non-immediate

2018-02-13 Thread George Kyriazis
Don't count on the compiler automagically converting an srli call to srl if the shift count isn't an immediate. --- src/gallium/drivers/swr/rasterizer/common/simdlib_128_avx.inl | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[Mesa-dev] [PATCH 11/31] swr/rast: Fix invalid number of attributes

2018-02-13 Thread George Kyriazis
Fix invalid number of attributes passed into tesselation PA. Needs to take into account any offsets from the shader. nnocuous issue, but removes an assert firing in debug. --- src/gallium/drivers/swr/rasterizer/core/frontend.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[Mesa-dev] [PATCH 25/31] swr/rast: Update/add comments

2018-02-13 Thread George Kyriazis
--- src/gallium/drivers/swr/rasterizer/core/api.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/swr/rasterizer/core/api.cpp b/src/gallium/drivers/swr/rasterizer/core/api.cpp index f45da96..99d3cd5 100644 ---

[Mesa-dev] [PATCH 07/31] swr/rast: Removed unused variable

2018-02-13 Thread George Kyriazis
Gets rid of zillions of unused variable warnings, made worse by templates. --- src/gallium/drivers/swr/rasterizer/core/backend.cpp | 2 -- src/gallium/drivers/swr/rasterizer/core/backend_impl.h | 3 --- src/gallium/drivers/swr/rasterizer/core/backend_sample.cpp | 2 --

[Mesa-dev] [PATCH 21/31] swr/rast: Fix bug related to passing AR handle

2018-02-13 Thread George Kyriazis
We were passing a garbage handle. Let's not do that. --- src/gallium/drivers/swr/rasterizer/core/api.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/swr/rasterizer/core/api.cpp b/src/gallium/drivers/swr/rasterizer/core/api.cpp index 5e27e4d..f45da96

[Mesa-dev] [PATCH 12/31] swr/rast: whitespace cleanup

2018-02-13 Thread George Kyriazis
--- .../drivers/swr/rasterizer/jitter/JitManager.h | 38 +++--- 1 file changed, 19 insertions(+), 19 deletions(-) diff --git a/src/gallium/drivers/swr/rasterizer/jitter/JitManager.h b/src/gallium/drivers/swr/rasterizer/jitter/JitManager.h index ddd6864..3660249 100644 ---

[Mesa-dev] [PATCH 23/31] swr/rast: Use right type for offset to next component

2018-02-13 Thread George Kyriazis
--- src/gallium/drivers/swr/rasterizer/jitter/builder_mem.cpp | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/gallium/drivers/swr/rasterizer/jitter/builder_mem.cpp b/src/gallium/drivers/swr/rasterizer/jitter/builder_mem.cpp index 491fb98..617cf33 100644 ---

[Mesa-dev] [PATCH 29/31] swr/rast: Consolidate archrast Draw events

2018-02-13 Thread George Kyriazis
Consolidate archrst draw events into single draw event with an attribute that represents the type of draw - Add handlers for new private proto versions of DrawInstancedEvent, DrawIndexedInstancedEvent, DrawInstancedSplitEvent, and DrawIndexedInstancedSplitEvent - Convert the draw events to

[Mesa-dev] [PATCH 30/31] swr/rast: Normalize path for debug metadata

2018-02-13 Thread George Kyriazis
in template gen_llvm.hpp --- src/gallium/drivers/swr/rasterizer/codegen/templates/gen_llvm.hpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/swr/rasterizer/codegen/templates/gen_llvm.hpp

[Mesa-dev] [PATCH 15/31] swr/rast: Fix avx version of GATHERPS

2018-02-13 Thread George Kyriazis
GEP was given the wrong type, and asserting. --- src/gallium/drivers/swr/rasterizer/jitter/builder_mem.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/swr/rasterizer/jitter/builder_mem.cpp b/src/gallium/drivers/swr/rasterizer/jitter/builder_mem.cpp

[Mesa-dev] [PATCH 18/31] swr/rast: Use llvm intrinsic masked gather

2018-02-13 Thread George Kyriazis
Use llvm intrinsic masked.gather instead of manual unroll for the cases where we have vector of pointers. Improves llvm IR debug experience by reducing a ton of IR to a single intrinsic call. Also seems to reduce overall stack use considerably. ---

Re: [Mesa-dev] [PATCH 6/7] vulkan: Add new VK_MESA_query_timestamp extension

2018-02-13 Thread Keith Packard
Lionel Landwerlin writes: > I'm assuming the correlation is done outside the vulkan driver? With a > clock_gettime() maybe? > > If that's the case, I'm afraid this will be highly inaccurate. > The kernel might execute other tasks when the ioctl() happens and that

[Mesa-dev] [PATCH 1/3] i965/gen10: Remove warning message.

2018-02-13 Thread Rafael Antognolli
Gen10 seems pretty stable so far, so there's no reason to keep this message. Signed-off-by: Rafael Antognolli Cc: Kenneth Graunke Cc: "18.0" mesa-sta...@lists.freedesktop.org --- src/mesa/drivers/dri/i965/brw_context.c | 7 --- 1 file

[Mesa-dev] [PATCH 2/3] anv/gen10: Remove warning message.

2018-02-13 Thread Rafael Antognolli
Gen10 seems pretty stable so far, remove "alpha support" message. Signed-off-by: Rafael Antognolli Cc: Jason Ekstrand Cc: "18.0" mesa-sta...@lists.freedesktop.org --- src/intel/vulkan/anv_device.c | 8 +++- 1 file changed, 3 insertions(+),

[Mesa-dev] [PATCH 3/3] docs: Add Cannonlake support to 18.0 release notes.

2018-02-13 Thread Rafael Antognolli
17.4 is actually 18.0. Signed-off-by: Rafael Antognolli Cc: "18.0" mesa-sta...@lists.freedesktop.org --- docs/relnotes/17.4.0.html | 1 + 1 file changed, 1 insertion(+) diff --git a/docs/relnotes/17.4.0.html b/docs/relnotes/17.4.0.html index

Re: [Mesa-dev] [PATCH 12/16] anv/image: Separate modifiers from legacy scanout

2018-02-13 Thread Jason Ekstrand
On Tue, Feb 13, 2018 at 10:48 AM, Daniel Stone wrote: > Hi Jason, > > On 9 February 2018 at 23:43, Jason Ekstrand wrote: > > - /* For images using modifiers, we require a dedicated > allocation > > - * and we set the BO tiling to

Re: [Mesa-dev] [PATCH 2/3] anv/gen10: Remove warning message.

2018-02-13 Thread Jason Ekstrand
Reviewed-by: Jason Ekstrand On Tue, Feb 13, 2018 at 1:51 PM, Rafael Antognolli < rafael.antogno...@intel.com> wrote: > Gen10 seems pretty stable so far, remove "alpha support" message. > > Signed-off-by: Rafael Antognolli > Cc: Jason Ekstrand

Re: [Mesa-dev] [PATCH 13/16] anv/image: Add support for modifiers for WSI

2018-02-13 Thread Jason Ekstrand
On Tue, Feb 13, 2018 at 10:55 AM, Daniel Stone wrote: > Hi Jason, > > On 9 February 2018 at 23:43, Jason Ekstrand wrote: > > +static void > > +get_wsi_format_modifier_properties_list(const struct > anv_physical_device *physical_device, > > +

[Mesa-dev] [PATCH 1.5/16] intel/genxml/icl: Add Cache Mode SubSlice Register to gen11.xml

2018-02-13 Thread Anuj Phogat
Signed-off-by: Anuj Phogat --- This patch will be squashed with [PATCH 01/16] src/intel/genxml/gen11.xml | 12 1 file changed, 12 insertions(+) diff --git a/src/intel/genxml/gen11.xml b/src/intel/genxml/gen11.xml index 2490b0e25b..84020f7015 100644 ---

[Mesa-dev] [PATCH 06/31] swr/rast: Separate RDTSC code from archrast

2018-02-13 Thread George Kyriazis
Renamed rdstc defines more appropriately --- src/gallium/drivers/swr/rasterizer/core/api.cpp| 40 .../drivers/swr/rasterizer/core/backend.cpp| 24 +- .../drivers/swr/rasterizer/core/backend_clear.cpp | 8 ++-- .../drivers/swr/rasterizer/core/backend_impl.h

[Mesa-dev] [PATCH 00/31] SWR-related rasterizer changes

2018-02-13 Thread George Kyriazis
Batch patchset of SWR rasterizer-related changes George Kyriazis (31): swr/rast: Add missing parameter to a few gather functions swr/rast: Cleanup knob definitions swr/rast: Don't include private context in gathers swr/rast: Remove some JIT debug code swr/rast: Cleanup of

[Mesa-dev] [PATCH 09/31] swr/rast: Separate event types to public and private

2018-02-13 Thread George Kyriazis
Split into two proto files and modify appropriate build rules for configure / scons / meson builds. There are private internal events (proxy) that communicate information from rasterizer to ArchRast. ArchRast can use these events to calculate a final answer and then emit other public events which

[Mesa-dev] [PATCH 03/31] swr/rast: Don't include private context in gathers

2018-02-13 Thread George Kyriazis
Move mpPrivateContext to compensate --- src/gallium/drivers/swr/rasterizer/jitter/builder.h | 4 src/gallium/drivers/swr/rasterizer/jitter/builder_mem.cpp | 14 +++--- src/gallium/drivers/swr/rasterizer/jitter/builder_mem.h | 10 +-

[Mesa-dev] [PATCH 22/31] swr/rast: Be more explicit when fetching next component

2018-02-13 Thread George Kyriazis
Use a new function to denote that we want to get offset to next component and hide the fact that GEP is used underneath. --- src/gallium/drivers/swr/rasterizer/jitter/builder_mem.cpp | 13 + src/gallium/drivers/swr/rasterizer/jitter/builder_mem.h | 2 ++ 2 files changed, 11

[Mesa-dev] [PATCH 20/31] swr/rast: Fix primitive replication issue in tesselation PA.

2018-02-13 Thread George Kyriazis
--- src/gallium/drivers/swr/rasterizer/core/frontend.cpp | 4 ++-- src/gallium/drivers/swr/rasterizer/core/pa.h | 1 + 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/swr/rasterizer/core/frontend.cpp

[Mesa-dev] [PATCH 04/31] swr/rast: Remove some JIT debug code

2018-02-13 Thread George Kyriazis
--- .../drivers/swr/rasterizer/jitter/JitManager.cpp | 45 -- 1 file changed, 45 deletions(-) diff --git a/src/gallium/drivers/swr/rasterizer/jitter/JitManager.cpp b/src/gallium/drivers/swr/rasterizer/jitter/JitManager.cpp index 7105766..8092c14 100644 ---

[Mesa-dev] [PATCH 14/31] swr/rast: More precise user clip distance interpolation

2018-02-13 Thread George Kyriazis
--- src/gallium/drivers/swr/rasterizer/core/backend_impl.h | 4 +++- src/gallium/drivers/swr/rasterizer/core/binner.cpp | 17 + 2 files changed, 4 insertions(+), 17 deletions(-) diff --git a/src/gallium/drivers/swr/rasterizer/core/backend_impl.h

[Mesa-dev] [PATCH 16/31] swr/rast: Renamed variable in vertexbufferstate

2018-02-13 Thread George Kyriazis
--- src/gallium/drivers/swr/rasterizer/core/state.h | 2 +- src/gallium/drivers/swr/rasterizer/jitter/fetch_jit.cpp | 10 ++ src/gallium/drivers/swr/swr_state.cpp | 2 +- 3 files changed, 8 insertions(+), 6 deletions(-) diff --git

[Mesa-dev] [PATCH 02/31] swr/rast: Cleanup knob definitions

2018-02-13 Thread George Kyriazis
Rename some of the categories and move some options around. --- .../drivers/swr/rasterizer/codegen/knob_defs.py| 90 ++ 1 file changed, 40 insertions(+), 50 deletions(-) diff --git a/src/gallium/drivers/swr/rasterizer/codegen/knob_defs.py

[Mesa-dev] [PATCH 10/31] swr/rast: Add clipper stats.

2018-02-13 Thread George Kyriazis
Clipper event is now: event ClipperEvent { uint32_t drawId; uint32_t trivialRejectCount; uint32_t trivialAcceptCount; uint32_t mustClipCount; }; --- .../drivers/swr/rasterizer/archrast/archrast.cpp | 18 +++--- .../drivers/swr/rasterizer/archrast/events.proto

Re: [Mesa-dev] [PATCH] swr: bump minimum supported LLVM version to 4.0

2018-02-13 Thread Dylan Baker
Quoting Andres Gomez (2018-02-13 14:42:57) [snip] > > -if with_amd_vk or with_gallium_radeonsi > +if with_amd_vk or with_gallium_radeonsi or with_gallium_swr >_llvm_version = '>= 4.0.0' > -elif with_gallium_opencl or with_gallium_swr or with_gallium_r600 > +elif with_gallium_opencl or

Re: [Mesa-dev] [PATCH 00/16] Prepare to add Ice Lake (ICL) support

2018-02-13 Thread Dylan Baker
For the build system changes: Reviewed-by: Dylan Baker I'm pretty sure that the autotools is correct, and the meson looks good. I think the android.mk is good, but I'm not really an expert on android.mk Dylan Quoting Anuj Phogat (2018-02-13 11:15:00) > This series prepares

Re: [Mesa-dev] [PATCH v2 0/8] The 2nd version for UVD HEVC encode

2018-02-13 Thread Mark Thompson
On 13/02/18 16:38, James Zhu wrote: > Hi Mark, > > Did you still encounter hung issue? > > If yes, could you share me with your play and transcode streams and command > line, > then I can try to reproduce at my side. > > Thanks & Best Regards! > > James Zhu Yes, it does still happen with the

[Mesa-dev] [PATCH 01/16] intel/genxml/icl: Add gen11.xml

2018-02-13 Thread Anuj Phogat
Signed-off-by: Anuj Phogat --- This patch adds a big xml file. So I couldn't send the patch to the list. Clamping down the patch so that reviewers can actually see what i'm doing in [PATCH 01/16 ]. The whole patch can be found in my 'review' branch on github.

[Mesa-dev] [PATCH] i965: Add ICL to test_eu_validate.cpp

2018-02-13 Thread Anuj Phogat
From: Matt Turner --- src/intel/compiler/test_eu_validate.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/src/intel/compiler/test_eu_validate.cpp b/src/intel/compiler/test_eu_validate.cpp index f6c2b35625..d987311ef8 100644 ---

  1   2   >