[Mesa-dev] [RFC 3/3] mesa: call DrawBuffer(s) driver hook in update_framebuffer for windows-system FB

From: Boyan Ding When draw buffers are changed on a bound framebuffer, DrawBuffer(s) hook should be called. However, it is missing in update_framebuffer with window-system framebuffer, in which FB's draw buffer state should match context state, potentially resulting in a

[Mesa-dev] [PATCH 2/3] mesa: drop the buffer mode param from the DrawBuffer driver function

No drivers used it. --- src/mesa/drivers/common/driverfuncs.c| 2 +- src/mesa/drivers/dri/i915/intel_buffers.c| 2 +- src/mesa/drivers/dri/i965/intel_buffers.c| 2 +- src/mesa/drivers/dri/nouveau/nouveau_state.c | 2 +- src/mesa/main/buffers.c | 7 ++-

[Mesa-dev] [PATCH 1/3] mesa: merge the driver functions DrawBuffers and DrawBuffer

The extra params we unused by the drivers that used DrawBuffers. --- src/mesa/drivers/common/driverfuncs.c| 1 - src/mesa/drivers/dri/nouveau/nouveau_state.c | 4 ++-- src/mesa/main/buffers.c | 8 ++-- src/mesa/main/dd.h | 2 --

Re: [Mesa-dev] [RFC 3/3] mesa: call DrawBuffer(s) driver hook in update_framebuffer for windows-system FB

On 14/04/18 14:45, Timothy Arceri wrote: From: Boyan Ding When draw buffers are changed on a bound framebuffer, DrawBuffer(s) hook should be called. However, it is missing in update_framebuffer with window-system framebuffer, in which FB's draw buffer state should

Re: [Mesa-dev] [PATCH] gallium: move ddebug, noop, rbug, trace to auxiliary to improve build times

While I can't reproduce this on my machine (running Arch), I can reproduce it on a machine running Ubuntu 16.04. I'll look into it more. Dylan Quoting Marek Olšák (2018-04-10 12:47:32) > cmake .. -G Ninja -DCMAKE_INSTALL_PREFIX=/usr/llvm/x86_64-linux-gnu > -DLLVM_TARGETS_TO_BUILD="X86;AMDGPU"

Re: [Mesa-dev] [PATCH 1/1] i965: Make sure the shadow buffers have enough space

On Friday, April 13, 2018 1:35:45 PM PDT Kenneth Graunke wrote: > On Monday, April 9, 2018 4:06:16 PM PDT James Xiong wrote: > > From: "Xiong, James" > > > > On non-LLC platforms, we malloc shadow batch/state buffers > > of the same sizes as our batch/state buffers' GEM

[Mesa-dev] [PATCH v2] i965: Fix shadow batches to be the same size as the real BO.

brw_bo_alloc may round up our allocation size to the next bucket size. In this case, we would malloc a shadow buffer that was the original intended size, but use bo->size (the larger size) for all of our checks. This could cause us to run off the end of the shadow buffer. v2: Actually use the

Re: [Mesa-dev] [PATCH 1/1] i965: Make sure the shadow buffers have enough space

On Fri, 13 Apr 2018 14:33:09 -0700 Kenneth Graunke wrote: > On Friday, April 13, 2018 2:08:40 PM PDT James Xiong wrote: > > On Fri, 13 Apr 2018 13:51:02 -0700 > > Kenneth Graunke wrote: > > > > > On Friday, April 13, 2018 1:35:45 PM PDT Kenneth

Re: [Mesa-dev] [PATCH 1/1] i965: Make sure the shadow buffers have enough space

On Monday, April 9, 2018 4:06:16 PM PDT James Xiong wrote: > From: "Xiong, James" > > On non-LLC platforms, we malloc shadow batch/state buffers > of the same sizes as our batch/state buffers' GEM allocations. > However the buffer allocator reuses similar-sized gem

Re: [Mesa-dev] [PATCH] gallium: move ddebug, noop, rbug, trace to auxiliary to improve build times

On 04/09/2018 02:27 PM, Marek Olšák wrote: > See: > https://cgit.freedesktop.org/mesa/mesa/commit/?id=f55d1f806e6b6c33af559de166d08ec8fa3ebe90 > This happens when mesa is built with rtti enabled and llvm is not. -Tom > Marek > > On Mon, Apr 9, 2018 at 5:08 PM, Dylan Baker

Re: [Mesa-dev] [PATCH] gallium: move ddebug, noop, rbug, trace to auxiliary to improve build times

Okay, I've figured it out. On my system RTTI is enabled by default, on ubuntu 16.04 RTTI is disabled. meson doesn't account for this in it's llvm module, because you would need to compile all C++ code with -fno-rtti to make it link reliably. short answer: add `-DLLVM_ENABLE_RTTI=1` to the cmake

Re: [Mesa-dev] [PATCH v2] i965: Fix shadow batches to be the same size as the real BO.

Reviewed-by: Lionel Landwerlin On 13/04/18 13:49, Kenneth Graunke wrote: brw_bo_alloc may round up our allocation size to the next bucket size. In this case, we would malloc a shadow buffer that was the original intended size, but use bo->size (the larger size)

[Mesa-dev] [AppVeyor] mesa master #7453 failed

Build mesa 7453 failed Commit 918b798668 by Marek Olšák on 4/5/2018 9:54 PM: radeonsi: make sure CP DMA is idle at the end of IBs Configure your notification preferences ___ mesa-dev mailing list

[Mesa-dev] [PATCH 40/45] swr/rast: minimize codegen redundant work

Move filtering of redundant codegen operations into gen scripts themselves --- .../drivers/swr/rasterizer/codegen/gen_archrast.py | 111 + .../drivers/swr/rasterizer/codegen/gen_backends.py | 97 +-- .../drivers/swr/rasterizer/codegen/gen_common.py | 131

[Mesa-dev] [PATCH 36/45] swr/rast: Type-check TemplateArgUnroller

Allows direct use of enum values in conversion to template args. --- src/gallium/drivers/swr/rasterizer/core/utils.h | 39 + 1 file changed, 21 insertions(+), 18 deletions(-) diff --git a/src/gallium/drivers/swr/rasterizer/core/utils.h

[Mesa-dev] [PATCH 16/45] swr/rast: Add some archrast counters

Hook up archrast counters for shader stats: instructions executed. --- .../drivers/swr/rasterizer/archrast/archrast.cpp | 4 +-- .../drivers/swr/rasterizer/archrast/events.proto | 30 ++ .../drivers/swr/rasterizer/core/backend.cpp| 1 +

[Mesa-dev] [PATCH 25/45] swr/rast: Enable generalized fetch jit

Enable generalized fetch jit with 8 or 16 wide SIMD target. Still some work needed to remove some simd8 double pumping for 16-wide target. Also removed unused non-gather load vertices path. --- .../drivers/swr/rasterizer/jitter/builder.cpp | 26 +-

[Mesa-dev] [PATCH 32/45] swr/rast: Fix alloca usage in jitter

Fix issue where temporary allocas were getting hoisted to function entry unnecessarily. We now explicitly mark temporary allocas and skip hoisting during the hoist pass. Shuold reduce stack usage. --- src/gallium/drivers/swr/rasterizer/jitter/builder.cpp | 17 +

[Mesa-dev] [PATCH 09/45] swr/rast: WIP builder rewrite.

Start removing avx2 macros for functionality that exists in llvm. --- src/gallium/drivers/swr/rasterizer/codegen/gen_llvm_ir_macros.py | 5 - src/gallium/drivers/swr/rasterizer/jitter/builder_misc.h | 9 - 2 files changed, 14 deletions(-) diff --git

[Mesa-dev] [PATCH 14/45] swr/rast: Add "Num Instructions Executed" stats intrinsic.

Added a SWR_SHADER_STATS structure which is passed to each shader. The stats pass will instrument the shader to populate this. --- src/gallium/drivers/swr/rasterizer/core/state.h | 28 ++--- 1 file changed, 21 insertions(+), 7 deletions(-) diff --git

[Mesa-dev] [PATCH 43/45] swr/rast: Optimize late/bindless JIT of samplers

Add per-worker thread private data to all shader calls Add per-worker sampler cache and jit context Add late LoadTexel JIT support Add per-worker-thread Sampler / LoadTexel JIT --- src/gallium/drivers/swr/rasterizer/core/api.cpp| 7 ++- src/gallium/drivers/swr/rasterizer/core/api.h | 47

[Mesa-dev] [PATCH 34/45] swr/rast: fix comment

--- src/gallium/drivers/swr/rasterizer/jitter/fetch_jit.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/swr/rasterizer/jitter/fetch_jit.cpp b/src/gallium/drivers/swr/rasterizer/jitter/fetch_jit.cpp index 8d659d0..cdfddf3 100644 ---

[Mesa-dev] [PATCH 44/45] swr/rast: Replace x86 VMOVMSK with llvm-only implementation

--- .../swr/rasterizer/codegen/gen_llvm_ir_macros.py | 1 - .../drivers/swr/rasterizer/jitter/builder_mem.cpp | 2 +- .../drivers/swr/rasterizer/jitter/builder_misc.cpp | 25 -- .../drivers/swr/rasterizer/jitter/builder_misc.h | 2 ++

[Mesa-dev] [PATCH 20/45] swr/rast: Start refactoring of builder/packetizer.

Move x86 intrinsic lowering to a separate pass. Builder now instantiates generic intrinsics for features not supported by llvm. The separate x86 lowering pass is responsible for lowering to valid x86 for the target SIMD architecture. Currently it's a port of existing code to get it up and running

[Mesa-dev] [PATCH 24/45] swr/rast: Add builder_gfx_mem.{h|cpp}

Needed to support full translation. Builder_gfx_mem will convert gfxptr_t from 64 bit int to regular pointer types for use by builder_mem. --- src/gallium/drivers/swr/Makefile.sources | 2 + src/gallium/drivers/swr/meson.build| 2 +

[Mesa-dev] [PATCH 42/45] swr/rast: Implement VROUND intrinsic in x86 lowering pass

--- .../rasterizer/jitter/functionpasses/lower_x86.cpp | 38 +- 1 file changed, 37 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/swr/rasterizer/jitter/functionpasses/lower_x86.cpp b/src/gallium/drivers/swr/rasterizer/jitter/functionpasses/lower_x86.cpp index

[Mesa-dev] [PATCH 22/45] swr/rast: Cleanup of JitManager convenience types

Small cleanup. Remove convenience types from JitManager and standardize on the Builder's convenience types. --- .../drivers/swr/rasterizer/jitter/JitManager.cpp | 19 --- .../drivers/swr/rasterizer/jitter/JitManager.h | 20

[Mesa-dev] [PATCH 30/45] swr/rast: Fix byte offset for non-indexed draws

--- src/gallium/drivers/swr/rasterizer/core/frontend.cpp | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/swr/rasterizer/core/frontend.cpp b/src/gallium/drivers/swr/rasterizer/core/frontend.cpp index 25d1073..2076859 100644 ---

[Mesa-dev] [PATCH 07/45] swr/rast: Changes to allow jitter to compile with LLVM5

--- src/gallium/drivers/swr/rasterizer/jitter/jit_pch.hpp | 18 +- 1 file changed, 17 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/swr/rasterizer/jitter/jit_pch.hpp b/src/gallium/drivers/swr/rasterizer/jitter/jit_pch.hpp index 031bced..b1d6076 100644 ---

[Mesa-dev] [PATCH 08/45] swr/rast: LLVM 6 fix

for getting masked gather intrinsic (also compatible with LLVM 4) --- src/gallium/drivers/swr/rasterizer/jitter/builder_mem.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/swr/rasterizer/jitter/builder_mem.cpp

[Mesa-dev] [PATCH 39/45] swr/rast: double-pump in x86 lowering pass

Add support for double-pumping a smaller SIMD width intrinsic. --- .../rasterizer/jitter/functionpasses/lower_x86.cpp | 30 ++ 1 file changed, 19 insertions(+), 11 deletions(-) diff --git a/src/gallium/drivers/swr/rasterizer/jitter/functionpasses/lower_x86.cpp

Re: [Mesa-dev] [PATCH i-g-t] [RFC] CONTRIBUTING: commit rights docs

On 2018-04-13 06:00 AM, Daniel Vetter wrote: > This tries to align with the X.org communities's long-standing > tradition of trying to be an inclusive community and handing out > commit rights fairly freely. > > We also tend to not revoke commit rights for people no longer > regularly active in a

Re: [Mesa-dev] [PATCH 1/1] i965: Make sure the shadow buffers have enough space

On Fri, 13 Apr 2018 13:51:02 -0700 Kenneth Graunke wrote: > On Friday, April 13, 2018 1:35:45 PM PDT Kenneth Graunke wrote: > > On Monday, April 9, 2018 4:06:16 PM PDT James Xiong wrote: > > > From: "Xiong, James" > > > > > > On non-LLC

[Mesa-dev] [PATCH 3/5] ddebug: add PIPE_OS_UNIX/LINUX checks to fix MSVC build

Don't include Unix headers or use Unix functions when building with MSVC. --- src/gallium/auxiliary/driver_ddebug/dd_draw.c | 5 + src/gallium/auxiliary/driver_ddebug/dd_util.h | 9 +++-- 2 files changed, 12 insertions(+), 2 deletions(-) diff --git

[Mesa-dev] [PATCH 4/5] gallium/util: put (void) in a few function signatures

To match the header file. --- src/gallium/auxiliary/util/u_network.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/gallium/auxiliary/util/u_network.c b/src/gallium/auxiliary/util/u_network.c index e74293b..89395f5 100644 --- a/src/gallium/auxiliary/util/u_network.c

[Mesa-dev] [PATCH 5/5] gallium/osmesa: link with winsock2 library on Windows

To fix the MSVC build. The build broke because we started to compile the ddebug code on Windows after the mtypes.h changes. Building ddebug caused us to also use the u_network.c code for the first time. --- src/gallium/targets/osmesa/SConscript | 3 +++ 1 file changed, 3 insertions(+) diff

[Mesa-dev] [PATCH 2/5] mesa: protect #include of unistd.h with _MSV_VER check

unistd.h is unix only. --- src/mesa/program/program_lexer.l | 4 1 file changed, 4 insertions(+) diff --git a/src/mesa/program/program_lexer.l b/src/mesa/program/program_lexer.l index 13eb902..c4973fd 100644 --- a/src/mesa/program/program_lexer.l +++ b/src/mesa/program/program_lexer.l @@

[Mesa-dev] [PATCH 1/5] mesa: remove unused 'i' in dimensions_error_check()

--- src/mesa/main/texgetimage.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/mesa/main/texgetimage.c b/src/mesa/main/texgetimage.c index 69521c5..0ab9ed4 100644 --- a/src/mesa/main/texgetimage.c +++ b/src/mesa/main/texgetimage.c @@ -913,7 +913,6 @@ dimensions_error_check(struct

[Mesa-dev] [PATCH] i965: Fix shadow batches to be the same size as the real BO.

brw_bo_alloc may round up our allocation size to the next bucket size. In this case, we would malloc a shadow buffer that was the original intended size, but use bo->size (the larger size) for all of our checks. This could cause us to run off the end of the shadow buffer. Reported-by: James

Re: [Mesa-dev] [PATCH] radv: fix radv_layout_dcc_compressed() when image doesn't have DCC

Hi Samuel, When this patch is applied directly to the 18.0 branch, I get a mesa compile error: radv_image.c:1175:9: error: implicit declaration of function ‘radv_image_has_dcc’; did you mean ‘radv_image_alloc_dcc’? Is there another patch that this is dependent on? -Mark Samuel Pitoiset

[Mesa-dev] [Bug 106039] Undefined version strings in pc files with meson build

https://bugs.freedesktop.org/show_bug.cgi?id=106039 Bug ID: 106039 Summary: Undefined version strings in pc files with meson build Product: Mesa Version: 18.0 Hardware: Other OS: All Status: NEW Severity:

Re: [Mesa-dev] [PATCH 1/1] i965: Make sure the shadow buffers have enough space

On Friday, April 13, 2018 2:08:40 PM PDT James Xiong wrote: > On Fri, 13 Apr 2018 13:51:02 -0700 > Kenneth Graunke wrote: > > > On Friday, April 13, 2018 1:35:45 PM PDT Kenneth Graunke wrote: > > > On Monday, April 9, 2018 4:06:16 PM PDT James Xiong wrote: > > > > From:

Re: [Mesa-dev] [PATCH 07/17] radeonsi: skip DCC render feedback checking if color writes are disabled

The crashes should be fixed in mesa/master. Marek On Thu, Apr 12, 2018 at 9:17 PM, Timothy Arceri wrote: > On 13/04/18 10:45, Timothy Arceri wrote: > >> This change cause around 20+ piglit crashes on my Polaris. >> >> e.g

[Mesa-dev] [PATCH 00/10] radv: various changes in the DCC/FMASK/CMASK codepath

Hi, This series mostly cleans up the DCC/FMASK/CMASK codepath. This also adds some little improvements that shouldn't impact performance because reducing the number of fast-clear eliminate passes doesn't matter much. DCC for MSAA textures is more complicated than expected because it seems like

[Mesa-dev] [PATCH 02/10] radv: handle DCC image transitions before CMASK/FMASK transitions

Mostly because DCC implies a fast-clear eliminate and we should be able to skip some DCC decompressions by setting a predicate like for CMASK and FMASK. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_cmd_buffer.c | 10 +- 1 file changed, 5

[Mesa-dev] [PATCH 01/10] radv: disable prediction only if it has been enabled

When decompressing DCC we don't enable it, so it's useless to disable it. This reduces the number of prediction packets sent to the GPU when performing color decompression passes. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_meta_fast_clear.c | 2 +- 1 file

Re: [Mesa-dev] [PATCH 3/3] glsl: #undef THIS macro to fix MSVC build

For the series, Reviewed-by: Neha Bhende Regards, Neha From: Brian Paul Sent: Friday, April 13, 2018 9:03:41 AM To: mesa-dev@lists.freedesktop.org Cc: Charmaine Lee; Neha Bhende Subject: [PATCH 3/3] glsl: #undef THIS

Re: [Mesa-dev] [PATCH 07/10] radv: Support allocating variable size descriptor sets.

Patches 3-7 are: Reviewed-by: Samuel Pitoiset On 04/12/2018 01:44 AM, Bas Nieuwenhuizen wrote: --- src/amd/vulkan/radv_descriptor_set.c | 21 + 1 file changed, 17 insertions(+), 4 deletions(-) diff --git a/src/amd/vulkan/radv_descriptor_set.c

Re: [Mesa-dev] [PATCH 02/10] radv: Keep a global BO list for VkMemory.

Reviewed-by: Samuel Pitoiset We should remove some radv_cs_add_buffer() calls and re-enable local BOs to reduce overhead, but this can be done later. Make sure to check the system submission path. On 04/12/2018 01:44 AM, Bas Nieuwenhuizen wrote: With update after

[Mesa-dev] [PATCH 07/10] radv: merge radv_handle_{dcc, cmask}_image_transition() functions

Into radv_handle_color_image_transition(). Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_cmd_buffer.c | 58 ++-- 1 file changed, 17 insertions(+), 41 deletions(-) diff --git a/src/amd/vulkan/radv_cmd_buffer.c

[Mesa-dev] [PATCH 04/10] radv: clean up radv_handle_image_transition() a bit

Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_cmd_buffer.c | 31 --- 1 file changed, 20 insertions(+), 11 deletions(-) diff --git a/src/amd/vulkan/radv_cmd_buffer.c b/src/amd/vulkan/radv_cmd_buffer.c index 270dcd5a9e..a74bad1981

[Mesa-dev] [PATCH 05/10] radv: make radv_initialise_cmask() static

Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_cmd_buffer.c | 4 ++-- src/amd/vulkan/radv_private.h| 2 -- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/src/amd/vulkan/radv_cmd_buffer.c b/src/amd/vulkan/radv_cmd_buffer.c index

[Mesa-dev] [PATCH 08/10] radv: handle CMASK/FMASK transitions only if DCC is disabled

DCC implies a fast-clear eliminate, so I think this sounds reasonable. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_cmd_buffer.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/amd/vulkan/radv_cmd_buffer.c

[Mesa-dev] [PATCH 10/10] radv: clean up radv_decompress_resolve_subpass_src()

To handle the source color image transitions in the same place. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_meta_resolve.c | 17 +++-- 1 file changed, 7 insertions(+), 10 deletions(-) diff --git a/src/amd/vulkan/radv_meta_resolve.c

[Mesa-dev] [PATCH 06/10] radv: add radv_init_color_image_metadata() helper

In order to separate initialization from decompression. In the future, that will allow us to init DCC/FMASK/CMASK in one shot. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_cmd_buffer.c | 51 +--- 1 file changed, 41 insertions(+),

[Mesa-dev] [PATCH 03/10] radv: add radv_handle_color_image_transition() helper

To handle CMASK, FMASK and DCC transitions in the same place. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_cmd_buffer.c | 34 +++- 1 file changed, 25 insertions(+), 9 deletions(-) diff --git a/src/amd/vulkan/radv_cmd_buffer.c

[Mesa-dev] [PATCH 09/10] radv: don't fast-clear eliminate after resolving a subpass with compute

That looks useless, and I think radv_handle_image_transition() will do a fast-clear eliminate because it's called after the resolve. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_meta_resolve_cs.c | 14 -- 1 file changed, 14 deletions(-) diff

Re: [Mesa-dev] [PATCH 08/10] spirv: Add support for VK_EXT_descriptor_indexing uniform indexing caps.

On 04/12/2018 01:44 AM, Bas Nieuwenhuizen wrote: --- src/compiler/shader_info.h| 1 + src/compiler/spirv/spirv_to_nir.c | 6 ++ 2 files changed, 7 insertions(+) diff --git a/src/compiler/shader_info.h b/src/compiler/shader_info.h index ababe520b2d..c8128fea01b 100644 ---

Re: [Mesa-dev] [PATCH 08/10] spirv: Add support for VK_EXT_descriptor_indexing uniform indexing caps.

On Fri, Apr 13, 2018 at 8:06 PM, Samuel Pitoiset wrote: > > > On 04/12/2018 01:44 AM, Bas Nieuwenhuizen wrote: >> >> --- >> src/compiler/shader_info.h| 1 + >> src/compiler/spirv/spirv_to_nir.c | 6 ++ >> 2 files changed, 7 insertions(+) >> >> diff --git

Re: [Mesa-dev] [PATCH] mesa: Include unistd.h in program_lexer

Reviewed-by: Lionel Landwerlin On 13/04/18 10:18, Dylan Baker wrote: Which was previously provided implicitly by mtypes.h CC: Marek Olšák CC: Mark Janes Fixes: 43d66c8c2d4d3d4dee1309856b6ce6c5393682e5

[Mesa-dev] [PATCH 03/45] swr/rast: Use blend context struct to pass params

Stuff parameters into a blend context struct before passing down through the PFN_BLEND_JIT_FUNC function pointer. Needed for stat changes. --- .../drivers/swr/rasterizer/core/backend_impl.h | 44 ++- src/gallium/drivers/swr/rasterizer/core/state.h| 17 ++--

[Mesa-dev] [PATCH 00/45] OpenSWR driver misc changes

Lots of SWR-specifc changes, including: - work for 16-wide simd operation across all avx flavors - separate avx instrinsics into a separate x86 lowering pass - stats work - misc other cleanup George Kyriazis (45): swr/rast: Add some instructions to jitter swr/rast: Introduce JIT_MEM_CLIENT

[Mesa-dev] [PATCH 01/45] swr/rast: Add some instructions to jitter

VPHADDD, PMAXUD, PMINUD --- .../drivers/swr/rasterizer/codegen/gen_llvm_ir_macros.py | 1 + src/gallium/drivers/swr/rasterizer/jitter/builder_misc.cpp | 12 src/gallium/drivers/swr/rasterizer/jitter/builder_misc.h | 2 ++ 3 files changed, 15 insertions(+) diff --git

[Mesa-dev] [PATCH 02/45] swr/rast: Introduce JIT_MEM_CLIENT

Help assist with usage tracking of memory accesses --- .../drivers/swr/rasterizer/jitter/builder_mem.cpp | 58 ++ .../drivers/swr/rasterizer/jitter/builder_mem.h| 47 -- .../drivers/swr/rasterizer/jitter/fetch_jit.cpp| 6 +-- 3 files changed, 71

[Mesa-dev] [PATCH 04/45] swr/rast: Add debug type info for i128

Help support debug info in 16 wide shaders. --- src/gallium/drivers/swr/rasterizer/jitter/JitManager.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/drivers/swr/rasterizer/jitter/JitManager.cpp b/src/gallium/drivers/swr/rasterizer/jitter/JitManager.cpp index 0cefa43..bfb1d2e

[Mesa-dev] [PATCH 06/45] swr/rast: Add some archrast stats

Add stats for degenerate and backfacing primitive counts Wire archrast stats for alpha blend and alpha test. pass value to jitter, upon return have archrast event increment a value --- .../drivers/swr/rasterizer/archrast/archrast.cpp | 35 +-

[Mesa-dev] [PATCH 19/45] swr/rast: Simplify #define usage in gen source file

Removed preprocessor defines from structures passed to LLVM jitted code. The python scripts do not understand the preprocessor defines and ignores them. So for fields that are compiled out due to a preprocessor define the LLVM script accounts for them anyway because it doesn't know what the

[Mesa-dev] [PATCH 29/45] swr/rast: Add support for setting optimization level

for JIT compilation --- .../drivers/swr/rasterizer/codegen/knob_defs.py| 35 ++ .../swr/rasterizer/common/simdlib_512_emu.inl | 2 +- src/gallium/drivers/swr/rasterizer/core/state.h| 13 .../drivers/swr/rasterizer/jitter/JitManager.cpp | 10 +--

[Mesa-dev] [PATCH 05/45] swr/rast: Silence some unused variable warnings

--- src/gallium/drivers/swr/rasterizer/jitter/fetch_jit.cpp | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/swr/rasterizer/jitter/fetch_jit.cpp b/src/gallium/drivers/swr/rasterizer/jitter/fetch_jit.cpp index 5feb5fa..1ee6691 100644 ---

Re: [Mesa-dev] [PATCH] mesa: Include unistd.h in program_lexer

Reviewed-by: Marek Olšák Marek On Fri, Apr 13, 2018 at 1:18 PM, Dylan Baker wrote: > Which was previously provided implicitly by mtypes.h > > CC: Marek Olšák > CC: Mark Janes > Fixes:

Re: [Mesa-dev] [PATCH 10/10] radv: Enable VK_EXT_descriptor_indexing.

Patches 9-10 are: Reviewed-by: Samuel Pitoiset On 04/12/2018 01:44 AM, Bas Nieuwenhuizen wrote: This adds everything except non-uniform indexing, which needs a bit more work and testing. --- src/amd/vulkan/radv_device.c | 39 +++

[Mesa-dev] [PATCH 12/45] swr/rast: Permute work for simd16

Fix slow permutes in PA tri lists under SIMD16 emulation on AVX Added missing permute (interlane, immediate) to SIMDLIB --- .../drivers/swr/rasterizer/common/simd16intrin.h | 1 + .../drivers/swr/rasterizer/common/simdintrin.h | 1 + .../swr/rasterizer/common/simdlib_256_avx.inl |

[Mesa-dev] [PATCH 10/45] swr/rast: Add autogen of helper llvm intrinsics.

Replace sqrt, maskload, fp min/max, cttz, ctlz with llvm equivalent. Replace AVX maskedstore intrinsic with LLVM intrinsic. Add helper llvm macros for stacksave, stackrestore, popcnt. --- src/gallium/drivers/swr/Makefile.am| 8 ++ src/gallium/drivers/swr/SConscript

[Mesa-dev] [PATCH 41/45] swr/rast: Refactor to improve code sharing.

--- .../drivers/swr/rasterizer/jitter/fetch_jit.cpp| 79 ++ 1 file changed, 36 insertions(+), 43 deletions(-) diff --git a/src/gallium/drivers/swr/rasterizer/jitter/fetch_jit.cpp b/src/gallium/drivers/swr/rasterizer/jitter/fetch_jit.cpp index 767866f..af97b83 100644 ---

[Mesa-dev] [PATCH 28/45] swr/rast: Adding translate call to builder_gfx_mem.

--- src/gallium/drivers/swr/rasterizer/jitter/builder_gfx_mem.cpp | 5 + src/gallium/drivers/swr/rasterizer/jitter/builder_gfx_mem.h | 2 ++ 2 files changed, 7 insertions(+) diff --git a/src/gallium/drivers/swr/rasterizer/jitter/builder_gfx_mem.cpp

[Mesa-dev] [PATCH 37/45] swr/rast: Add shader stats infrastructure (WIP)

--- .../drivers/swr/rasterizer/archrast/archrast.cpp | 64 +++-- .../drivers/swr/rasterizer/archrast/events.proto | 65 -- .../swr/rasterizer/archrast/events_private.proto | 30 ++ .../drivers/swr/rasterizer/jitter/builder.h| 23

[Mesa-dev] [PATCH 27/45] swr/rast: Fix codegen for typedef types

--- src/gallium/drivers/swr/rasterizer/codegen/gen_llvm_types.py | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/drivers/swr/rasterizer/codegen/gen_llvm_types.py b/src/gallium/drivers/swr/rasterizer/codegen/gen_llvm_types.py index a127976..d8863c0 100644 ---

[Mesa-dev] [PATCH 21/45] swr/rast: Lower PERMD and PERMPS to x86.

Add support for providing an emulation callback function for arch/width combinations that don't map cleanly to an x86 intrinsic. --- .../drivers/swr/rasterizer/jitter/builder_mem.cpp | 8 +-- .../drivers/swr/rasterizer/jitter/builder_misc.cpp | 70 --

[Mesa-dev] [PATCH 45/45] swr/rast: Fix VGATHERPD lowering

Also Implement VHSUBPS in x86 lowering pass. --- .../rasterizer/jitter/functionpasses/lower_x86.cpp | 82 ++ 1 file changed, 69 insertions(+), 13 deletions(-) diff --git a/src/gallium/drivers/swr/rasterizer/jitter/functionpasses/lower_x86.cpp

[Mesa-dev] [PATCH 11/45] swr/rast: WIP builder rewrite (2)

Finish up the remaining explicit intrinsic uses. At this point all explicit Intrinsic::getDeclaration() usage has been replaced with auto generated macros generated with gen_llvm_ir_macros.py. Going forward, make sure to only use the intrinsics here, adding new ones as needed. Next step is to

[Mesa-dev] [PATCH 35/45] swr/rast: Add vgather to x86 lowering pass.

Add support for generic VGATHERPD intrinsic in x86 lowering pass. --- .../rasterizer/jitter/functionpasses/lower_x86.cpp | 85 +++--- 1 file changed, 76 insertions(+), 9 deletions(-) diff --git a/src/gallium/drivers/swr/rasterizer/jitter/functionpasses/lower_x86.cpp

[Mesa-dev] [PATCH 26/45] swr: add x86 lowering pass to fragment shader

Needed because soem FP paths (namely stipple) use gather intrinsics that now need to be lowered to x86. --- src/gallium/drivers/swr/swr_shader.cpp | 7 +++ 1 file changed, 7 insertions(+) diff --git a/src/gallium/drivers/swr/swr_shader.cpp b/src/gallium/drivers/swr/swr_shader.cpp index

[Mesa-dev] [PATCH 13/45] swr/rast: Add MEM_ADD helper function to Builder.

mem[offset] += value This function will be heavily used by all stats intrinsics. --- src/gallium/drivers/swr/rasterizer/jitter/builder_mem.cpp | 7 +++ src/gallium/drivers/swr/rasterizer/jitter/builder_mem.h | 2 ++ 2 files changed, 9 insertions(+) diff --git

[Mesa-dev] [PATCH 17/45] swr/rast: Fix name mangling for LLVM pow intrinsic

--- src/gallium/drivers/swr/rasterizer/codegen/gen_llvm_ir_macros.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/swr/rasterizer/codegen/gen_llvm_ir_macros.py b/src/gallium/drivers/swr/rasterizer/codegen/gen_llvm_ir_macros.py index 0245584..324f24a

[Mesa-dev] [PATCH] mesa: Include unistd.h in program_lexer

Which was previously provided implicitly by mtypes.h CC: Marek Olšák CC: Mark Janes Fixes: 43d66c8c2d4d3d4dee1309856b6ce6c5393682e5 ("mesa: include mtypes.h less") Signed-off-by: Dylan Baker ---

[Mesa-dev] [Bug 100629] No mans sky renders white screen under wine in linux

https://bugs.freedesktop.org/show_bug.cgi?id=100629 --- Comment #6 from Matteo Bruni --- Notice that No Man's Sky is an OpenGL game so Wine should have no effect on the game requiring compatibility profile or not. -- You are receiving this mail because: You are the QA

[Mesa-dev] [PATCH 33/45] swr/rast: add cvt instructions in x86 lowering pass

Support generic VCVTPD2PS and VCVTPH2PS in x86 lowering pass. --- .../swr/rasterizer/codegen/gen_llvm_ir_macros.py | 70 -- .../drivers/swr/rasterizer/jitter/builder_mem.cpp | 14 - .../drivers/swr/rasterizer/jitter/builder_mem.h| 3 -

[Mesa-dev] [PATCH 31/45] swr/rast: Change gfx pointers to gfxptr_t

Changing type to gfxptr for indices and related changes to fetch and mem builder code. --- .../swr/rasterizer/codegen/gen_llvm_ir_macros.py | 4 +- src/gallium/drivers/swr/rasterizer/core/api.cpp| 8 +- src/gallium/drivers/swr/rasterizer/core/context.h | 2 +-

[Mesa-dev] [PATCH 15/45] swr/rast: Code cleanup

Removing some code that doesn't seem to do anything meaningful. --- src/gallium/drivers/swr/rasterizer/jitter/fetch_jit.cpp | 9 + 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/src/gallium/drivers/swr/rasterizer/jitter/fetch_jit.cpp

[Mesa-dev] [PATCH 38/45] swr/rast: Fix 64bit float loads in x86 lowering pass

--- .../drivers/swr/rasterizer/jitter/builder_mem.cpp | 39 +- .../drivers/swr/rasterizer/jitter/fetch_jit.cpp| 31 + 2 files changed, 25 insertions(+), 45 deletions(-) diff --git a/src/gallium/drivers/swr/rasterizer/jitter/builder_mem.cpp

[Mesa-dev] [PATCH 18/45] swr/rast: Move CallPrint() to a separate file

Needed work for jit code debug. --- src/gallium/drivers/swr/Makefile.sources | 3 +- src/gallium/drivers/swr/meson.build| 1 + .../drivers/swr/rasterizer/jitter/builder_misc.cpp | 22 +- .../rasterizer/jitter/shader_lib/DebugOutput.cpp | 51

[Mesa-dev] [PATCH 23/45] swr/rast: Lower VGATHERPS and VGATHERPS_16 to x86.

Some more work to do before we can support simultaneous 8-wide and 16-wide and remove the VGATHERPS_16 version. --- .../drivers/swr/rasterizer/jitter/builder_mem.cpp | 69 +- 1 file changed, 2 insertions(+), 67 deletions(-) diff --git

Re: [Mesa-dev] [PATCH 1/3] radeonsi: implement mechanism for IBs without partial flushes at the end (v6)

Ping On Fri, Apr 6, 2018 at 10:31 PM, Marek Olšák wrote: > From: Marek Olšák > > (This patch doesn't enable the behavior. It will be enabled in a later > commit.) > > Draw calls from multiple IBs can be executed in parallel. > > v2: do emit partial

[Mesa-dev] [AppVeyor] mesa master #7459 completed

Build mesa 7459 completed Commit 6a519a157b by Brian Paul on 4/13/2018 9:34 PM: gallium/osmesa: link with winsock2 library on Windows\n\nTo fix the MSVC build. The build broke because we started to compile\nthe ddebug code on Windows after the mtypes.h

[Mesa-dev] [Bug 106039] Undefined version strings in pc files with meson build

https://bugs.freedesktop.org/show_bug.cgi?id=106039 Dylan Baker changed: What|Removed |Added CC|

Re: [Mesa-dev] [PATCH 4/5] gallium/util: put (void) in a few function signatures

For patches 1 - 4: Reviewed-by: Marek Olšák Marek On Fri, Apr 13, 2018 at 5:35 PM, Brian Paul wrote: > To match the header file. > --- > src/gallium/auxiliary/util/u_network.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git

Re: [Mesa-dev] [PATCH 5/5] gallium/osmesa: link with winsock2 library on Windows

For the series, Reviewed-by: Charmaine Lee From: Brian Paul Sent: Friday, April 13, 2018 2:35:37 PM To: mesa-dev@lists.freedesktop.org Cc: Charmaine Lee; Neha Bhende Subject: [PATCH 5/5] gallium/osmesa: link

[Mesa-dev] [Bug 100629] No mans sky renders white screen under wine in linux

https://bugs.freedesktop.org/show_bug.cgi?id=100629 --- Comment #7 from Timothy Arceri --- (In reply to Matteo Bruni from comment #6) > Notice that No Man's Sky is an OpenGL game so Wine should have no effect on > the game requiring compatibility profile or not. In that

Re: [Mesa-dev] [PATCH] gallium: move ddebug, noop, rbug, trace to auxiliary to improve build times

On Fri, Apr 13, 2018 at 5:26 PM, Dylan Baker wrote: > Okay, I've figured it out. On my system RTTI is enabled by default, on > ubuntu > 16.04 RTTI is disabled. meson doesn't account for this in it's llvm module, > because you would need to compile all C++ code with -fno-rtti

Re: [Mesa-dev] [PATCH] gallium: move ddebug, noop, rbug, trace to auxiliary to improve build times

Quoting Marek Olšák (2018-04-13 15:33:02) > On Fri, Apr 13, 2018 at 5:26 PM, Dylan Baker wrote: > > Okay, I've figured it out. On my system RTTI is enabled by default, on > ubuntu > 16.04 RTTI is disabled. meson doesn't account for this in it's llvm > module, >

  1   2   3   >