On 21/08/18 11:42, Vadym Shovkoplias wrote:
> Hi Timothy, Alejandro,
>
> Thanks for the review comments!
> I'd just like to mention that the same approach is already used
> in link_varyings.cpp file in
> function cross_validate_outputs_to_inputs(). Here is a code snippet:
>
> if
Thanks!
Reviewed-by: Samuel Pitoiset
On 8/22/18 3:19 AM, Marek Olšák wrote:
From: Marek Olšák
---
src/amd/common/ac_llvm_build.h| 6 ++
src/amd/common/ac_nir_to_llvm.c | 4
src/gallium/drivers/radeonsi/si_shader_internal.h | 5 -
3
Hi Michel,
On Thu, Aug 16, 2018 at 6:43 PM Michel Dänzer wrote:
>
> On 2018-08-16 11:34 AM, Tomasz Figa wrote:
> > If there is no last fence, due to no rendering happening yet, just
> > create a new signaled fence and return it, to match the expectations of
> > the EGL sync fence API.
> >
> >
On 08/21/2018 09:28 PM, Marek Olšák wrote:
> On Tue, Aug 21, 2018 at 8:02 PM Sagar Ghuge wrote:
>>
>> _mesa_set_enable() and _mesa_IsEnabled() extended to accept new two
>> tokens GL_DEPTH_CLAMP_NEAR_AMD and GL_DEPTH_CLAMP_FAR_AMD.
>>
>> Signed-off-by: Sagar Ghuge
>> ---
>>
https://bugs.freedesktop.org/show_bug.cgi?id=107610
--- Comment #7 from Samuel Pitoiset ---
Thanks for trace, apparently the issue can't be reproduced with mesa 18.1.6 so
it's likely a regression.
--
You are receiving this mail because:
You are the assignee for the bug.
You are the QA Contact
In the GL_MESA_framebuffer_flip_y implementation
_mesa_is_winsys_fbo checks were replaced with
FlipY checks. rb->Name is also used to determine
if a buffer is winsys.
---
src/mesa/drivers/dri/i965/brw_blorp.c| 20 +---
src/mesa/drivers/dri/i965/intel_pixel_read.c | 4
On Wed, Aug 22, 2018 at 3:09 PM Jason Ekstrand wrote:
>
> Two questions:
>
> 1) Have you grep'd through the rest of i965 looking for Name to make sure
> you got them all?
Yes, I have. I believe that I got them all now.
> 2) Have you had a chance to run it through our CI system?
No I
On 23/08/18 09:57, Timothy Arceri wrote:
On 22/08/18 20:34, Samuel Pitoiset wrote:
Otherwise, nir_lower_clip_cull_distance_arrays might report
wrong number of output clips/culls because it relies on
shader output variables and some of them might be dead.
This fixes a rendering issue with
On 22/08/18 20:34, Samuel Pitoiset wrote:
Otherwise, nir_lower_clip_cull_distance_arrays might report
wrong number of output clips/culls because it relies on
shader output variables and some of them might be dead.
This fixes a rendering issue with Dolphin and Super Mario
Sunshine.
Fixes:
Reviewed-by: Marek Olšák
Marek
On Wed, Aug 22, 2018 at 4:00 PM Sagar Ghuge wrote:
>
> Add some basic types and storage for the AMD_depth_clamp_separate
> extension.
>
> v2: 1) Drop unnecessary definition (Marek Olsak)
> 2) Expose extension in compatibility profile (Marek Olsak)
>
>
Without this patch mesa doesn't compile:
In file included from ../mesa-/src/amd/addrlib/addrinterface.cpp:39:
../mesa-/src/util/macros.h:29:10: fatal error: c99_compat.h: No such file
or directory
#include "c99_compat.h"
^~
compilation terminated.
Signed-off-by:
https://bugs.freedesktop.org/show_bug.cgi?id=107457
Bug 107457 depends on bug 107359, which changed state.
Bug 107359 Summary: [Regression] [bisected] [OpenGL CTS] [SKL,BDW]
KHR-GL46.texture_barrier*-texels,
GTF-GL46.gtf21.GL2FixedTests.buffer_corners.buffer_corners, and
On 08/22/2018 04:31 PM, Marek Olšák wrote:
> On Wed, Aug 22, 2018 at 5:52 PM Sagar Ghuge wrote:
>>
>> Enable _mesa_PushAttrib() and _mesa_PopAttrib() to handle
>> GL_DEPTH_CLAMP_NEAR_AMD and GL_DEPTH_CLAMP_FAR_AMD tokens.
>>
>> Remove DepthClamp, because DepthClampNear + DepthClampFar replaces
Reviewed-by: Marek Olšák
Marek
On Wed, Aug 22, 2018 at 4:32 PM Sagar Ghuge wrote:
>
> _mesa_set_enable() and _mesa_IsEnabled() extended to accept new two
> tokens GL_DEPTH_CLAMP_NEAR_AMD and GL_DEPTH_CLAMP_FAR_AMD.
>
> v2: Remove unnecessary parentheses (Marek Olsak)
>
> Signed-off-by: Sagar
On 21/08/18 19:42, Vadym Shovkoplias wrote:
Hi Timothy, Alejandro,
Thanks for the review comments!
I'd just like to mention that the same approach is already used
in link_varyings.cpp file in
function cross_validate_outputs_to_inputs(). Here is a code snippet:
if (*input->data.used *&&
Quoting Gurchetan Singh (2018-08-22 16:08:33)
> Without this, I get:
>
> > platform_surfaceless.c:38:10: fatal error: 'loader.h' file not found
> > #include "loader.h"
> > ^~
> > 1 error generated.
>
> Fixes: 108d257a16859898f5ce02f4759c5c58f9b8c050 ("meson: build libEGL")
>
>
On Thu, Aug 23, 2018 at 1:44 AM Emil Velikov wrote:
>
> Hi Tomasz,
>
> On 21 August 2018 at 14:54, Tomasz Figa wrote:
> > Hi Emil,
> >
> > On Tue, Aug 14, 2018 at 2:05 AM Emil Velikov
> > wrote:
> >>
> >> From: Emil Velikov
> >>
> >> Unlike the other platforms, here we aim do guess if the
https://bugs.freedesktop.org/show_bug.cgi?id=106980
--- Comment #7 from Samuel Pitoiset ---
The crash on GFX8 should be fixed with
https://cgit.freedesktop.org/mesa/mesa/commit/?id=4c43ec461de4f122d5d6566361d064c816e4ef69
Next step is to test with GFX9.
--
You are receiving this mail because:
https://bugs.freedesktop.org/show_bug.cgi?id=106980
Samuel Pitoiset changed:
What|Removed |Added
Summary|Basemark GPU vulkan |Basemark GPU vulkan
On Tue, Aug 21, 2018 at 3:27 AM Tapani Pälli wrote:
> Signed-off-by: Tapani Pälli
> ---
> src/intel/vulkan/vk_format_info.h | 43
> +++
> 1 file changed, 43 insertions(+)
>
> diff --git a/src/intel/vulkan/vk_format_info.h
>
On Tue, Aug 21, 2018 at 3:27 AM Tapani Pälli wrote:
> When adding YUV support, we need to figure out implementation-defined
> external format identifier.
>
> Signed-off-by: Tapani Pälli
> ---
> src/intel/vulkan/anv_android.c | 99
> ++
> 1 file changed,
I picked up a bunch of the pieces from wayland's version:
https://gitlab.freedesktop.org/wayland/wayland/blob/master/CONTRIBUTING.md
The weston one is fairly similar. Then I rather massively trimmed it
down since in reality libdrm is a bit a dumping ground with very few
real rules. The commit
https://bugs.freedesktop.org/show_bug.cgi?id=101247
--- Comment #2 from vadym ---
Patch: https://patchwork.freedesktop.org/patch/245518/
--
You are receiving this mail because:
You are the assignee for the bug.___
mesa-dev mailing list
Tapani, this is causing some new regressions in OpenGLES CTS:
https://bugs.freedesktop.org/show_bug.cgi?id=107658
On Thu, 2018-08-02 at 14:14 +0300, Tapani Pälli wrote:
> Signed-off-by: Tapani Pälli
> ---
> src/mesa/drivers/dri/i965/intel_extensions.c | 1 +
> 1 file changed, 1 insertion(+)
>
https://bugs.freedesktop.org/show_bug.cgi?id=106980
--- Comment #6 from Samuel Pitoiset ---
The following patch fixes a crash on GFX8:
https://patchwork.freedesktop.org/series/48560/
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the
This fixes a crash in build_tex_intrinsic() when trying to
launch the Basemark GPU benchmark on GFX8. It looks like
there is still something wrong because some frames are black.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=106980
CC: 18.2
Signed-off-by: Samuel Pitoiset
---
Read-only variables could be considered inherently invariant and precise
since no expression in shader affects them.
Explicitly marking them as such is unnecessary and can cause issues,
e.g. uniform marked as invariant may require the same uniform in other
stage to be invariant too but uniforms
On 22.08.2018 15:20, Andres Gomez wrote:
Tapani, this is causing some new regressions in OpenGLES CTS:
https://bugs.freedesktop.org/show_bug.cgi?id=107658
OK will check, I did not realize CTS had some more tests on this than dEQP.
On Thu, 2018-08-02 at 14:14 +0300, Tapani Pälli wrote:
On 22 August 2018 at 13:09, Mathieu Bridon wrote:
> The script was being run directly as an executable, and it has a
> Python 2 shebang.
Please drop the execute bit and shebang - be that with this or a separate patch.
As-is the patch is:
Reviewed-by: Emil Velikov
-Emil
https://bugs.freedesktop.org/show_bug.cgi?id=107477
--- Comment #3 from Clément Guérin ---
Created attachment 141244
--> https://bugs.freedesktop.org/attachment.cgi?id=141244=edit
GTA 5 RADV_DEBUG log
Here's the log attached as requested.
--
You are receiving this mail because:
You are the
Hi,
My request for an account was NAK'd by the i965 maintainer. As such, I
will post a v2 with the update to release notes requested and I hope
Plamena can push that for me.
Best Regards,
-Kevin Rogovin
On Tue, Aug 21, 2018 at 12:39 PM Emil Velikov
wrote:
> Hi Kevin,
>
> On 20 August 2018
From: Kevin Rogovin
The main purpose for having NV_fragment_shader_interlock
extension is because that extension is also for GLES31 while
the ARB extension is for GL only.
v2: Add to review notes (requested by Emil Velikov)
Reviewed-by: Plamena Manolova
---
docs/relnotes/18.3.0.html
Add some basic types and storage for the AMD_depth_clamp_separate
extension.
v2: 1) Drop unnecessary definition (Marek Olsak)
2) Expose extension in compatibility profile (Marek Olsak)
Signed-off-by: Sagar Ghuge
---
src/mesa/main/extensions_table.h | 1 +
src/mesa/main/mtypes.h |
_mesa_set_enable() and _mesa_IsEnabled() extended to accept new two
tokens GL_DEPTH_CLAMP_NEAR_AMD and GL_DEPTH_CLAMP_FAR_AMD.
v2: Remove unnecessary parentheses (Marek Olsak)
Signed-off-by: Sagar Ghuge
---
src/mesa/main/enable.c | 36
1 file changed, 36
I admit to always being confused by depth, but:
On Wed, Aug 22, 2018, 16:23 Sagar Ghuge wrote:
> Gen >= 9 have ability to control clamping of depth values separately at
> near and far plane.
>
> z_w is clamped to the range [min(n,f), 0] if clamping at near plane is
> enabled, [0, max(n,f)] if
Quoting Kai Wasserbäch (2018-08-22 14:23:07)
> Hey Mariusz,
> Mariusz Ceier wrote on 8/22/18 10:16 PM:
> > Without this patch mesa doesn't compile:
> >
> > In file included from ../mesa-/src/amd/addrlib/addrinterface.cpp:39:
> > ../mesa-/src/util/macros.h:29:10: fatal error: c99_compat.h:
Without this patch mesa doesn't compile:
In file included from ../mesa-/src/amd/addrlib/addrinterface.cpp:39:
../mesa-/src/util/macros.h:29:10: fatal error: c99_compat.h: No such file
or directory
#include "c99_compat.h"
^~
compilation terminated.
Fixes 15ca5ce99a
Two questions:
1) Have you grep'd through the rest of i965 looking for Name to make sure
you got them all?
2) Have you had a chance to run it through our CI system?
On Wed, Aug 22, 2018 at 5:00 PM Fritz Koenig wrote:
> In the GL_MESA_framebuffer_flip_y implementation
> _mesa_is_winsys_fbo
Haven't tested this, but we do include loader.h
in platform_android.c
Fixes: c5ec1556859b7d33637c9fad13d3473c7b2f9eb3 ("meson: wire up egl/android")
---
src/egl/meson.build | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/egl/meson.build b/src/egl/meson.build
index 9c0b6b4b4a..06922c6c3c
Without this, I get:
> platform_surfaceless.c:38:10: fatal error: 'loader.h' file not found
> #include "loader.h"
> ^~
> 1 error generated.
Fixes: 108d257a16859898f5ce02f4759c5c58f9b8c050 ("meson: build libEGL")
v2: Split up patches, modify commit message (Dylan)
---
On 08/21/2018 05:02 PM, Sagar Ghuge wrote:
> Gen >= 9 have ability to control clamping of depth values separately at
> near and far plane.
>
> z_w is clamped to the range [min(n,f), 0] if clamping at near plane is
> enabled, [0, max(n,f)] if clamping at far plane is enabled and [min(n,f)
>
Hey Mariusz,
Mariusz Ceier wrote on 8/22/18 10:16 PM:
> Without this patch mesa doesn't compile:
>
> In file included from ../mesa-/src/amd/addrlib/addrinterface.cpp:39:
> ../mesa-/src/util/macros.h:29:10: fatal error: c99_compat.h: No such file
> or directory
> #include "c99_compat.h"
On Tue, Aug 21, 2018 at 1:05 AM, Bas Nieuwenhuizen
wrote:
> Reviewed-by: Bas Nieuwenhuizen
>
> Did you have access to push?
Yeah, just pushed everything.
Gražvydas
>
> On Mon, Aug 20, 2018 at 11:40 PM, Grazvydas Ignotas wrote:
>> For 32bit build. Trivial.
>> ---
>>
Oh, ok, no problem ;) I just sent v2.
On 22 August 2018 at 21:44, Dylan Baker wrote:
> Quoting Kai Wasserbäch (2018-08-22 14:23:07)
>> Hey Mariusz,
>> Mariusz Ceier wrote on 8/22/18 10:16 PM:
>> > Without this patch mesa doesn't compile:
>> >
>> > In file included from
Enable _mesa_PushAttrib() and _mesa_PopAttrib() to handle
GL_DEPTH_CLAMP_NEAR_AMD and GL_DEPTH_CLAMP_FAR_AMD tokens.
Remove DepthClamp, because DepthClampNear + DepthClampFar replaces it,
as suggested by Marek Olsak.
Driver that enables AMD_depth_clamp_separate will only ever look at
On Wed, Aug 22, 2018 at 5:35 PM Fritz Koenig wrote:
> On Wed, Aug 22, 2018 at 3:09 PM Jason Ekstrand
> wrote:
> >
> > Two questions:
> >
> > 1) Have you grep'd through the rest of i965 looking for Name to make
> sure you got them all?
>
> Yes, I have. I believe that I got them all now.
>
> >
Gen >= 9 have ability to control clamping of depth values separately at
near and far plane.
z_w is clamped to the range [min(n,f), 0] if clamping at near plane is
enabled, [0, max(n,f)] if clamping at far plane is enabled and [min(n,f)
max(n,f)] if clamping at both plane is enabled.
v2: 1) Use
I sent a minor comment on patch 6. The rest of the series is
Reviewed-by: Ian Romanick
On 08/21/2018 05:02 PM, Sagar Ghuge wrote:
> This patch series implements AMD_depth_clamp_separate extension.
> Previously I sent patches for comments and based on Ian and Marek's
> suggestions, I did some
Please ignore this patch. Subject contains extra bracket.
I will resend the patch.
On 08/22/2018 12:54 PM, Sagar Ghuge wrote:
> Add some basic types and storage for the AMD_depth_clamp_separate
> extension.
>
> v2: 1) Drop unnecessary definition (Marek Olsak)
> 2) Expose extension in
From: Marek Olšák
The extension was exposed but not the functions.
This fixes:
dEQP-GLES31.functional.debug.negative_coverage.get_error.buffer.readn_pixels
dEQP-GLES31.functional.debug.negative_coverage.get_error.state.get_nuniformfv
On Wed, Aug 22, 2018 at 5:52 PM Sagar Ghuge wrote:
>
> Enable _mesa_PushAttrib() and _mesa_PopAttrib() to handle
> GL_DEPTH_CLAMP_NEAR_AMD and GL_DEPTH_CLAMP_FAR_AMD tokens.
>
> Remove DepthClamp, because DepthClampNear + DepthClampFar replaces it,
> as suggested by Marek Olsak.
>
> Driver that
I agree that this comment is obsolete now. I'll update the patch, thanks!
On Wed, Aug 22, 2018 at 12:09 PM, Alejandro Piñeiro
wrote:
> On 21/08/18 11:42, Vadym Shovkoplias wrote:
>
> Hi Timothy, Alejandro,
>
> Thanks for the review comments!
> I'd just like to mention that the same approach is
On Wed, 22 Aug 2018 at 11:51, Daniel Vetter wrote:
> +See the gitlab project owners for contact details of the libdrm maintainers.
Think this should be 'See MAINTAINERS' ... ?
The rest looks good to me, though I would encourage linking to
Patchwork so people can find patches from others, as
On Wed, Aug 22, 2018 at 1:08 PM, Eric Engestrom
wrote:
> On Wednesday, 2018-08-22 12:51:39 +0200, Daniel Vetter wrote:
>> I picked up a bunch of the pieces from wayland's version:
>>
>> https://gitlab.freedesktop.org/wayland/wayland/blob/master/CONTRIBUTING.md
>>
>> The weston one is fairly
Otherwise, nir_lower_clip_cull_distance_arrays might report
wrong number of output clips/culls because it relies on
shader output variables and some of them might be dead.
This fixes a rendering issue with Dolphin and Super Mario
Sunshine.
Fixes: b0c643d8f5 ("spirv: Use NIR per-member
https://bugs.freedesktop.org/show_bug.cgi?id=107610
Samuel Pitoiset changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|---
The script was being run directly as an executable, and it has a
Python 2 shebang.
---
src/gallium/targets/dri/meson.build | 1 +
src/gallium/targets/va/meson.build| 1 +
src/gallium/targets/vdpau/meson.build | 1 +
src/gallium/targets/xvmc/meson.build | 1 +
From Section 4.3.4 (Inputs) of the GLSL 1.50 spec:
"Only the input variables that are actually read need to be written
by the previous stage; it is allowed to have superfluous
declarations of input variables."
Fixes:
* interstage-multiple-shader-objects.shader_test
v2:
https://bugs.freedesktop.org/show_bug.cgi?id=107610
--- Comment #8 from Samuel Pitoiset ---
https://patchwork.freedesktop.org/series/48549/
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the
On Wed, Aug 22, 2018 at 12:55 PM, Daniel Stone wrote:
> On Wed, 22 Aug 2018 at 11:51, Daniel Vetter wrote:
>> +See the gitlab project owners for contact details of the libdrm maintainers.
>
> Think this should be 'See MAINTAINERS' ... ?
Hm right. Originally it was, but then I got a bit confused
On Wednesday, 2018-08-22 13:10:42 +0200, Daniel Vetter wrote:
> On Wed, Aug 22, 2018 at 1:08 PM, Eric Engestrom
> wrote:
> > On Wednesday, 2018-08-22 12:51:39 +0200, Daniel Vetter wrote:
> >> I picked up a bunch of the pieces from wayland's version:
> >>
> >>
And pushed.
Thanks!
On 21/08/2018 04:43, He, Yunchao wrote:
Thanks for your review, Lionel.
With the help from Clayton Craft to run the CI, this patch can pass CI:
http://otc-mesa-ci.jf.intel.com/job/Richard_Yunchao/1/
Regards
Yunchao
-Original Message-
From: Landwerlin, Lionel G
On Wednesday, 2018-08-22 12:51:39 +0200, Daniel Vetter wrote:
> I picked up a bunch of the pieces from wayland's version:
>
> https://gitlab.freedesktop.org/wayland/wayland/blob/master/CONTRIBUTING.md
>
> The weston one is fairly similar. Then I rather massively trimmed it
> down since in
On Wed, Aug 22, 2018 at 1:07 PM, Daniel Vetter wrote:
> On Wed, Aug 22, 2018 at 12:55 PM, Daniel Stone wrote:
>> On Wed, 22 Aug 2018 at 11:51, Daniel Vetter wrote:
>>> +See the gitlab project owners for contact details of the libdrm
>>> maintainers.
>>
>> Think this should be 'See MAINTAINERS'
On Tue, Aug 21, 2018 at 3:27 AM Tapani Pälli wrote:
> v2: add support for non-image buffers (AHARDWAREBUFFER_FORMAT_BLOB)
> v3: properly handle usage bits when creating from image
>
> Signed-off-by: Tapani Pälli
> ---
> src/intel/vulkan/anv_android.c | 149
>
I just learned I was supposed to send this :)
Reviewed-by: Mathieu Bridon
On Fri, 2018-08-17 at 11:07 -0700, Dylan Baker wrote:
> v2: - explicitly decode the output of subprocesses
> - handle bytes and string types consistently rather than relying
> on
> python 2's coercion for bytes
Hello list,
The forth release candidate for the Mesa 18.2.0 is now available.
As per the issue tracker [1] we still have a number of outstanding bugs
blocking the release.
[1] https://bugs.freedesktop.org/show_bug.cgi?id=107457
Currently we have:
- 18 queued
- 3 nominated (outstanding)
-
On Wednesday, 2018-08-22 16:42:26 +0200, Mathieu Bridon wrote:
> On Wed, 2018-08-22 at 15:17 +0100, Emil Velikov wrote:
> > On 22 August 2018 at 13:09, Mathieu Bridon
> > wrote:
> > > The script was being run directly as an executable, and it has a
> > > Python 2 shebang.
> >
> > Please drop the
On 22 August 2018 at 15:42, Mathieu Bridon wrote:
> On Wed, 2018-08-22 at 15:17 +0100, Emil Velikov wrote:
>> On 22 August 2018 at 13:09, Mathieu Bridon
>> wrote:
>> > The script was being run directly as an executable, and it has a
>> > Python 2 shebang.
>>
>> Please drop the execute bit and
On Wednesday, 2018-08-22 16:18:20 +0100, Emil Velikov wrote:
> On 22 August 2018 at 15:42, Mathieu Bridon wrote:
> > On Wed, 2018-08-22 at 15:17 +0100, Emil Velikov wrote:
> >> On 22 August 2018 at 13:09, Mathieu Bridon
> >> wrote:
> >> > The script was being run directly as an executable, and
Kai Wasserbäch wrote on 8/22/18 5:19 PM:
> Hey Marek,
> Marek Olšák wrote on 8/22/18 3:13 AM:
>> Get you send me a "git fetch" line that I can use to download your patches?
>
> sure. I rebased them on top of the current master and pushed the five patches
> to
> a new branch
On Tue, Aug 21, 2018 at 3:28 AM Tapani Pälli wrote:
> Since we don't know the exact format at creation time, some initialization
> is done only when bound with memory in vkBindImageMemory.
>
> v2: demand dedicated allocation in vkGetImageMemoryRequirements2 if
> image has external format
>
>
Thanks! I was going to push these today if someone didn't give me an r-b, but I
wanted to give people proper time.
Dylan
Quoting Mathieu Bridon (2018-08-22 07:35:39)
> I just learned I was supposed to send this :)
>
> Reviewed-by: Mathieu Bridon
>
> On Fri, 2018-08-17 at 11:07 -0700, Dylan
On Wed, Aug 22, 2018 at 12:54 AM Tapani Pälli
wrote:
>
>
> On 21.08.2018 11:27, Tapani Pälli wrote:
> > v2: have separate memory properties for android, set usage
> > flags for buffers correctly
> >
> > Signed-off-by: Tapani Pälli
> > ---
> > src/intel/vulkan/anv_formats.c | 71
>
https://bugs.freedesktop.org/show_bug.cgi?id=107654
Brian Paul changed:
What|Removed |Added
Assignee|mesa-dev@lists.freedesktop. |sitewranglers@lists.freedes
On Wed, 2018-08-22 at 15:17 +0100, Emil Velikov wrote:
> On 22 August 2018 at 13:09, Mathieu Bridon
> wrote:
> > The script was being run directly as an executable, and it has a
> > Python 2 shebang.
>
> Please drop the execute bit and shebang - be that with this or a
> separate patch.
That
On 21 August 2018 at 11:35, Juan A. Suarez Romero wrote:
> Cc: Dylan Baker
> Cc: Eric Engestrom
> ---
With the Fixes tag (thank Eric) and trivial clarification on the question below:
Reviewed-by: Emil Velikov
> .travis.yml | 24 ++--
> 1 file changed, 10 insertions(+),
On Mon, Aug 20, 2018 at 6:41 PM Caio Marcelo de Oliveira Filho <
caio.olive...@intel.com> wrote:
> On Sat, Jul 28, 2018 at 10:44:36PM -0700, Jason Ekstrand wrote:
> > This pass doesn't really do much now because nir_lower_vars_to_ssa can
> > already see through structures and considers them to be
Reviewed-by: Mathieu Bridon
On Fri, 2018-08-17 at 11:07 -0700, Dylan Baker wrote:
> ---
> src/compiler/glsl/tests/meson.build | 11 ---
> 1 file changed, 8 insertions(+), 3 deletions(-)
>
> diff --git a/src/compiler/glsl/tests/meson.build
> b/src/compiler/glsl/tests/meson.build
> index
Hey Marek,
Marek Olšák wrote on 8/22/18 3:13 AM:
> Get you send me a "git fetch" line that I can use to download your patches?
sure. I rebased them on top of the current master and pushed the five patches to
a new branch fix-warnings2-addrlibv2 on the FDO GitLab. Find the pull request
for that
I think this would be correct to do and would fix the bug at hand but there
may be other bugs lurking deeper. In particular, if you have multiple
shaders for the same stage that share some global variables and get linked
together, I think you could run into the same issue only with a read-write
On Mon, Aug 20, 2018 at 7:57 PM Caio Marcelo de Oliveira Filho <
caio.olive...@intel.com> wrote:
> On Sat, Jul 28, 2018 at 10:44:38PM -0700, Jason Ekstrand wrote:
> > Shader-db results on Kaby Lake:
> >
> > total instructions in shared programs: 15177605 -> 15177605 (0.00%)
> >
Hi Tomasz,
On 21 August 2018 at 14:54, Tomasz Figa wrote:
> Hi Emil,
>
> On Tue, Aug 14, 2018 at 2:05 AM Emil Velikov wrote:
>>
>> From: Emil Velikov
>>
>> Unlike the other platforms, here we aim do guess if the device that we
>> somewhat arbitrarily picked, is supported or not.
>>
>> It seems
On Wed, 2018-08-22 at 16:18 +0100, Emil Velikov wrote:
> On 22 August 2018 at 15:42, Mathieu Bridon
> wrote:
> > On Wed, 2018-08-22 at 15:17 +0100, Emil Velikov wrote:
> > > On 22 August 2018 at 13:09, Mathieu Bridon
> > > wrote:
> > > > The script was being run directly as an executable, and it
Since the script is never executed directly, but launched by Meson as an
argument to the Python interpreter, those are not needed any more.
In addition, they are the reason this script was missed when I moved the
Meson buildsystem to Python 3, so removing them helps avoiding future
confusion.
---
---
src/util/tests/vma/vma_random_test.cpp | 8
1 file changed, 8 insertions(+)
diff --git a/src/util/tests/vma/vma_random_test.cpp
b/src/util/tests/vma/vma_random_test.cpp
index 1f194fcdf92..9246176cbf2 100644
--- a/src/util/tests/vma/vma_random_test.cpp
+++
Reviewed-by: Eric Anholt
---
src/gallium/meson.build | 6 ++
src/gallium/winsys/sw/gdi/meson.build | 27 +++
2 files changed, 33 insertions(+)
create mode 100644 src/gallium/winsys/sw/gdi/meson.build
diff --git a/src/gallium/meson.build
This mirrors the haiku build which uses a platform.
v2: - Fix some rebase problems
Signed-off-by: Dylan Baker
Reviewed-by: Eric Anholt
---
meson.build | 8 ++--
meson_options.txt | 1 +
2 files changed, 7 insertions(+), 2 deletions(-)
diff --git a/meson.build b/meson.build
index
Because we provide a copy if MSVC doesn't, and we need it to make flex
do what we want.
---
src/compiler/glsl/glcpp/meson.build | 14 --
1 file changed, 12 insertions(+), 2 deletions(-)
diff --git a/src/compiler/glsl/glcpp/meson.build
b/src/compiler/glsl/glcpp/meson.build
index
For Windows
Signed-off-by: Dylan Baker
Reviewed-by: Eric Anholt
---
meson.build| 2 +-
subprojects/expat.wrap | 10 ++
2 files changed, 11 insertions(+), 1 deletion(-)
create mode 100644 subprojects/expat.wrap
diff --git a/meson.build b/meson.build
index
To help windows build
Signed-off-by: Dylan Baker
Reviewed-by: Eric Anholt
---
meson.build | 2 +-
subprojects/zlib.wrap | 10 ++
2 files changed, 11 insertions(+), 1 deletion(-)
create mode 100644 subprojects/zlib.wrap
diff --git a/meson.build b/meson.build
index
Which will allow meson to build a shared glapi build with mingw.
Signed-off-by: Dylan Baker
Reviewed-by: Eric Anholt
---
src/mapi/glapi/glapi.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/mapi/glapi/glapi.h b/src/mapi/glapi/glapi.h
index d5d4e0a03a6..cbdef2e4c5a
---
appveyor.yml | 1 +
1 file changed, 1 insertion(+)
diff --git a/appveyor.yml b/appveyor.yml
index 2c45f534ec3..2cb520b9604 100644
--- a/appveyor.yml
+++ b/appveyor.yml
@@ -36,6 +36,7 @@ clone_depth: 100
cache:
- llvm-5.0.1-msvc2015-mtd.7z
- subprojects\packagecache
+-
On Thu, Aug 16, 2018 at 12:30 AM Thomas Helland
wrote:
> 2018-08-15 23:56 GMT+02:00 Caio Marcelo de Oliveira Filho
> :
> > ---
> > src/util/u_dynarray.h | 9 +
> > 1 file changed, 9 insertions(+)
> >
> > diff --git a/src/util/u_dynarray.h b/src/util/u_dynarray.h
> > index
There's seems to be nothing in the GLSL (ES) specifications that diallow
redeclaring a variable as both 'precise' and 'invariant' in the same
statement. But the way the parse-rules are structured this fails to
parse, because this is handled in single_declaration, which has an
exhaustive list of
On Tue, Aug 21, 2018 at 8:09 PM Caio Marcelo de Oliveira Filho <
caio.olive...@intel.com> wrote:
> On Tue, Aug 21, 2018 at 06:15:20PM -0500, Jason Ekstrand wrote:
> > On Tue, Aug 21, 2018 at 5:55 PM Caio Marcelo de Oliveira Filho <
> > caio.olive...@intel.com> wrote:
> >
> > > Hi,
> > >
> > > On
On Tue, Aug 21, 2018 at 7:49 PM Caio Marcelo de Oliveira Filho <
caio.olive...@intel.com> wrote:
> On Sat, Jul 28, 2018 at 10:44:41PM -0700, Jason Ekstrand wrote:
> > This peephole optimization looks for a series of load/store_deref or
> > copy_deref instructions that copy an array from one
Hi all,
Pardon for dropping in so late. I've seems to have missed this.
On 24 July 2018 at 14:24, Martin Fuzzey wrote:
> Hi Thomasz,
>
> thanks for your reply
>
> On 21/07/18 04:27, Tomasz Figa wrote:
>>
>>
>> As you noticed, this adds back the dependency on gralloc handle
>> structure.
---
src/gallium/drivers/swr/meson.build | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/gallium/drivers/swr/meson.build
b/src/gallium/drivers/swr/meson.build
index b95c8bc1bf8..ec4d80e4bb2 100644
--- a/src/gallium/drivers/swr/meson.build
+++
v2: - set so_version to '' (only affects windows)
- always set lib prefix to 'lib', even on msvc
---
src/gallium/state_trackers/osmesa/meson.build | 12 ++--
src/gallium/targets/osmesa/meson.build| 11 ++-
2 files changed, 20 insertions(+), 3 deletions(-)
diff --git
1 - 100 of 158 matches
Mail list logo
