[Mesa-dev] [PATCH] docs: update 18.3 and add 19.x cycles for the release calendar

2018-12-17 Thread Andres Gomez
Cc: Dylan Baker Cc: Juan A. Suarez Cc: Emil Velikov Signed-off-by: Andres Gomez --- docs/release-calendar.html | 118 - 1 file changed, 116 insertions(+), 2 deletions(-) diff --git a/docs/release-calendar.html b/docs/release-calendar.html index

Re: [Mesa-dev] [PATCH] WIP: meson: allow building DRI loaders without a DRI driver

2018-12-17 Thread Dylan Baker
Quoting Emil Velikov (2018-12-17 11:10:00) > On Fri, 14 Dec 2018 at 17:57, Dylan Baker wrote: > > > > Quoting Emil Velikov (2018-12-13 08:15:57) > > > From: Emil Velikov > > > > > > Reasonably often people will want to build the loader w/o any drivers. > > > Be that debugging an issue in the

Re: [Mesa-dev] last call for autotools

2018-12-17 Thread Marek Olšák
On Mon, Dec 17, 2018 at 1:18 PM Eric Anholt wrote: > Eero Tamminen writes: > > > Hi, > > > > On 17.12.2018 8.08, Marek Olšák wrote: > > [...] > >> I think one of the serious usability issues is that environment > >> variables such as CFLAGS, CXXFLAGS, LDFLAGS, and PKG_CONFIG_PATH are > not > >>

Re: [Mesa-dev] [PATCH] freedreno/ir3: Make imageStore use num components from image format

2018-12-17 Thread Ilia Mirkin
Note that the format may not be known. I suspect that falls into your "default" case. On Mon, Dec 17, 2018 at 3:41 PM Eduardo Lima Mitev wrote: > > emit_intrinsic_store_image() is always using 4 components when > collecting registers for the value. When image has less than > 4 components (e.g,

Re: [Mesa-dev] MR: NIR: Partial redundancy elimination for compares

2018-12-17 Thread Ilia Mirkin
On Mon, Dec 17, 2018 at 5:05 PM Ian Romanick wrote: > > https://gitlab.freedesktop.org/mesa/mesa/merge_requests/22 > > This series adds a new optimization pass that tries to replace code > sequences like > > if (x < y) { > z = y - x; > ... > } > > with a sequence like > > t = x - y; > if

Re: [Mesa-dev] PSA: Please send MRs to the mailing list

2018-12-17 Thread Ian Romanick
On 12/16/18 4:54 PM, Ilia Mirkin wrote: > A diffstat would also be nice as it would better inform people reading > emails whether they need to care or not. That's a good idea. I tagged the message that I just sent with MR: to make it more obvious that it's for a merge request. I saw Jason's

Re: [Mesa-dev] last call for autotools

2018-12-17 Thread Dylan Baker
Quoting Marek Olšák (2018-12-17 12:25:29) > On Mon, Dec 17, 2018 at 1:18 PM Eric Anholt wrote: > > Eero Tamminen writes: > > > Hi, > > > > On 17.12.2018 8.08, Marek Olšák wrote: > > [...] > >> I think one of the serious usability issues is that environment > >>

Re: [Mesa-dev] [PATCH mesa] drop autotools

2018-12-17 Thread Andres Gomez
On Mon, 2018-12-17 at 19:51 +0100, Bas Nieuwenhuizen wrote: > On Mon, Dec 17, 2018 at 6:33 PM Juan A. Suarez Romero > wrote: > > > > On Mon, 2018-12-03 at 10:21 +, Eric Engestrom wrote: > > > Cc: Emil Velikov > > > Cc: Andres Gomez > > > Cc: Juan A. Suarez Romero > > > Cc: Dylan Baker >

Re: [Mesa-dev] [PATCH 10/12] virgl: modify how we handle GL_MAP_FLUSH_EXPLICIT_BIT

2018-12-17 Thread Gurchetan Singh
On Tue, Dec 11, 2018 at 2:49 PM Elie Tournier wrote: > On Mon, Dec 10, 2018 at 10:20:36AM -0800, Gurchetan Singh wrote: > > Previously, we ignored the the glUnmap(..) operation and > > flushed before we flush the cbuf. Now, let's just flush > > the data when we unmap. > > > > Neither method is

[Mesa-dev] [PATCH] radv: Work around non-renderable 128bpp compressed 3d textures on GFX9.

2018-12-17 Thread Bas Nieuwenhuizen
Exactly what title says, the new addrlib does not allow the above with certain dimensions that the CTS seems to hit. Work around it by not allowing the app to render to it via compat with other 128bpp formats and do not render to it ourselves during copies. Fixes: 776b9113656 "amd/addrlib:

Re: [Mesa-dev] [PATCH 1/2] bin/get-pick-list.sh: rework handing of sha nominations

2018-12-17 Thread Andres Gomez
On Mon, 2018-12-17 at 18:36 +, Emil Velikov wrote: > On Mon, 17 Dec 2018 at 18:14, Andres Gomez wrote: > > > > On Mon, 2018-12-17 at 16:43 +, Emil Velikov wrote: > > > Currently our is_sha_nomination does: > > > - folds any whitespace, attempting to extract sha-like information > > > -

[Mesa-dev] [PATCH] meson: Fix typo.

2018-12-17 Thread Vinson Lee
Fixes: 6b4c7047d571 ("meson: build gallium nine state_tracker") Signed-off-by: Vinson Lee --- meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meson.build b/meson.build index fe647f682c1c..d0f4b7e51f44 100644 --- a/meson.build +++ b/meson.build @@ -619,7 +619,7 @@

Re: [Mesa-dev] [PATCH 01/38] ac: add various helpers for float16/int16/int8

2018-12-17 Thread Marek Olšák
On Fri, Dec 7, 2018 at 12:22 PM Rhys Perry wrote: > Signed-off-by: Rhys Perry > --- > src/amd/common/ac_llvm_build.c | 123 ++-- > src/amd/common/ac_llvm_build.h | 22 +- > src/amd/common/ac_nir_to_llvm.c | 30 > 3 files changed, 154 insertions(+),

Re: [Mesa-dev] MR: NIR: Partial redundancy elimination for compares

2018-12-17 Thread Ian Romanick
I was really hoping to avoid having review discussion for a patch series on both the mailing list and the MR, but I guess that ship has sailed. On 12/17/18 2:39 PM, Roland Scheidegger wrote: > Am 17.12.18 um 23:27 schrieb Roland Scheidegger: >> Am 17.12.18 um 23:07 schrieb Ilia Mirkin: >>> On

[Mesa-dev] [PATCH 1/3] radeonsi: remove unrequired param in si_nir_scan_tess_ctrl()

2018-12-17 Thread Timothy Arceri
--- src/gallium/drivers/radeonsi/si_shader.h| 1 - src/gallium/drivers/radeonsi/si_shader_nir.c| 1 - src/gallium/drivers/radeonsi/si_state_shaders.c | 2 +- 3 files changed, 1 insertion(+), 3 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_shader.h

[Mesa-dev] [PATCH 2/3] ac/nir_to_llvm: add ac_are_tessfactors_def_in_all_invocs()

2018-12-17 Thread Timothy Arceri
The following patch will use this with the radeonsi NIR backend but I've added it to ac so we can use it with RADV in future. This is a NIR implementation of the tgsi function tgsi_scan_tess_ctrl(). --- src/amd/common/ac_nir_to_llvm.c | 161

[Mesa-dev] [PATCH 3/3] radeonsi: make use of ac_are_tessfactors_def_in_all_invocs()

2018-12-17 Thread Timothy Arceri
--- src/gallium/drivers/radeonsi/si_shader_nir.c | 10 ++ 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_shader_nir.c b/src/gallium/drivers/radeonsi/si_shader_nir.c index b81bea00b8..931d41245d 100644 ---

Re: [Mesa-dev] [PATCH 12/28] util: add fp64 -> fp32 conversion support for RTNE and RTZ rounding modes

2018-12-17 Thread Matt Turner
On Mon, Dec 10, 2018 at 11:25 AM Samuel Iglesias Gonsálvez wrote: > > On 07/12/2018 03:03, Matt Turner wrote: > > On Wed, Dec 5, 2018 at 7:56 AM Samuel Iglesias Gonsálvez > > wrote: > >> > >> Signed-off-by: Samuel Iglesias Gonsálvez > >> --- > >> src/util/Makefile.sources | 2 + > >>

[Mesa-dev] [Bug 109082] meson lmsensors check fails but always returns true

2018-12-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109082 Bug ID: 109082 Summary: meson lmsensors check fails but always returns true Product: Mesa Version: git Hardware: x86-64 (AMD64) OS: Linux (All) Status: NEW

Re: [Mesa-dev] MR: NIR: Partial redundancy elimination for compares

2018-12-17 Thread Roland Scheidegger
Am 17.12.18 um 23:07 schrieb Ilia Mirkin: > On Mon, Dec 17, 2018 at 5:05 PM Ian Romanick wrote: >> >>

Re: [Mesa-dev] [PATCH] WIP: meson: allow building DRI loaders without a DRI driver

2018-12-17 Thread Matt Turner
On Mon, Dec 17, 2018 at 2:12 PM Emil Velikov wrote: > Additionally, distributions build latest loader and use it with DRI1 > era drivers. I'm curious if there are distributions that still ships the DRI1 drivers. Do you know which, if any, do? ___

Re: [Mesa-dev] MR: NIR: Partial redundancy elimination for compares

2018-12-17 Thread Roland Scheidegger
Am 17.12.18 um 23:27 schrieb Roland Scheidegger: > Am 17.12.18 um 23:07 schrieb Ilia Mirkin: >> On Mon, Dec 17, 2018 at 5:05 PM Ian Romanick wrote: >>> >>>

Re: [Mesa-dev] [PATCH] WIP: meson: allow building DRI loaders without a DRI driver

2018-12-17 Thread Tobias Klausmann
On 17.12.18 23:16, Dylan Baker wrote: Quoting Tobias Klausmann (2018-12-17 14:05:13) On 17.12.18 20:33, Dylan Baker wrote: Quoting Emil Velikov (2018-12-17 11:10:00) On Fri, 14 Dec 2018 at 17:57, Dylan Baker wrote: Quoting Emil Velikov (2018-12-13 08:15:57) From: Emil Velikov Reasonably

[Mesa-dev] Two MRs related to NIR copy_prop_vars

2018-12-17 Thread Caio Marcelo de Oliveira Filho
Hi, nir: properly find the entry to keep in copy_prop_vars https://gitlab.freedesktop.org/mesa/mesa/merge_requests/23 Fixes https://bugs.freedesktop.org/show_bug.cgi?id=108624. nir: properly clear the entry sources in copy_prop_vars https://gitlab.freedesktop.org/mesa/mesa/merge_requests/24

[Mesa-dev] [Bug 108946] High memory usage in Black Mesa

2018-12-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108946 --- Comment #12 from MGG --- Hey, the new beta version has dramatically reduced the memory usage! Nice work there! Please, don't forget to give us the extra info about the problem/bug you found in order to close this ticket (in case there it

Re: [Mesa-dev] [PATCH 03/18] glx: meson: build src/glx only with -Dglx=dri

2018-12-17 Thread Emil Velikov
On Fri, 14 Dec 2018 at 17:13, Dylan Baker wrote: > > Quoting Emil Velikov (2018-12-13 08:05:52) > > From: Emil Velikov > > > > The library is the dri capable one, push the check src/meson.build, > > instead of the current partial handling in src/glx/meson.build. > > > > Fixes: a47c525f328

Re: [Mesa-dev] [PATCH 1/6] st/mesa: Drop dead 'passthrough_fs' field.

2018-12-17 Thread Ilia Mirkin
Reviewed-by: Ilia Mirkin On Mon, Dec 17, 2018 at 1:37 PM Kenneth Graunke wrote: > > Dead since 2015 (commit 5142564734bd68f165b02e29e384ebbcf91cce38). > --- > src/mesa/state_tracker/st_context.h | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/src/mesa/state_tracker/st_context.h >

Re: [Mesa-dev] [PATCH] WIP: meson: allow building DRI loaders without a DRI driver

2018-12-17 Thread Emil Velikov
On Fri, 14 Dec 2018 at 17:57, Dylan Baker wrote: > > Quoting Emil Velikov (2018-12-13 08:15:57) > > From: Emil Velikov > > > > Reasonably often people will want to build the loader w/o any drivers. > > Be that debugging an issue in the former, distribution bundle or other. > > > > Currently

Re: [Mesa-dev] [PATCH 18/18] travis: meson: port gallium build combinations over

2018-12-17 Thread Dylan Baker
Quoting Emil Velikov (2018-12-17 11:03:32) > On Fri, 14 Dec 2018 at 17:53, Dylan Baker wrote: > > > > Quoting Emil Velikov (2018-12-13 08:06:07) > > > From: Emil Velikov > > > > > > This commit adds a number of build combos: > > > > > > - Gallium Drivers {SWR, RadeonSI, Others) > > > Each one

Re: [Mesa-dev] [PATCH 1/2] bin/get-pick-list.sh: rework handing of sha nominations

2018-12-17 Thread Emil Velikov
On Mon, 17 Dec 2018 at 18:14, Andres Gomez wrote: > > On Mon, 2018-12-17 at 16:43 +, Emil Velikov wrote: > > Currently our is_sha_nomination does: > > - folds any whitespace, attempting to extract sha-like information > > - checks that at least one of the shas has landed > > > > Split it in

Re: [Mesa-dev] [PATCH 18/18] travis: meson: port gallium build combinations over

2018-12-17 Thread Emil Velikov
On Fri, 14 Dec 2018 at 17:53, Dylan Baker wrote: > > Quoting Emil Velikov (2018-12-13 08:06:07) > > From: Emil Velikov > > > > This commit adds a number of build combos: > > > > - Gallium Drivers {SWR, RadeonSI, Others) > > Each one has different LLVM requirements. Building SWR alone is twice >

[Mesa-dev] [Bug 109062] meson incorrectly handles/reports libdrm_$foo

2018-12-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109062 --- Comment #7 from Dylan Baker --- but if the time difference is negligible then thats a fair trade for a better error message :) -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the

Re: [Mesa-dev] Suggestions for improving meson-based builds

2018-12-17 Thread Dylan Baker
Quoting Ilia Mirkin (2018-12-16 11:48:52) > Hello all, > > There has been some discussion of late about dropping autotools or > making it a second-class citizen. I firmly believe such discussions > are premature. > > I've had a chance to try meson recently. First off, I'd like to > commend the

Re: [Mesa-dev] [PATCH v3] anv: support VkExternalFormatANDROID in vkCreateSamplerYcbcrConversion

2018-12-17 Thread Lionel Landwerlin
On 14/12/2018 12:05, Tapani Pälli wrote: + + /* The Vulkan 1.1.95 spec says "When creating an external format conversion, +* the value of components if ignored." +*/ + if (ext_format) { + conversion->mapping[0] = pCreateInfo->components.r; + conversion->mapping[1] =

Re: [Mesa-dev] [PATCH] i965: Don't override subslice count to 4 on Gen11.

2018-12-17 Thread Anuj Phogat
On Fri, Dec 14, 2018 at 3:59 PM Kenneth Graunke wrote: > > Gen9-10 have fewer than 4 subslices per slice, so they need this to be > rounded up. Gen11 isn't documented as needing this hack, and it can > also have more than 4 subslices, so the hack actually can break things. > --- >

[Mesa-dev] [PATCH 5/6] st/nir: Gather info after applying lowering FS variant features

2018-12-17 Thread Kenneth Graunke
DrawPixels lowering, for example, adds new varyings that need to be accounted for in inputs_read. The earlier info gathering at link time cannot account for this. --- src/mesa/state_tracker/st_program.c | 4 1 file changed, 4 insertions(+) diff --git a/src/mesa/state_tracker/st_program.c

[Mesa-dev] [PATCH 2/6] st/mesa: Drop !passColor optimization in drawpixels shaders.

2018-12-17 Thread Kenneth Graunke
The glDrawPixels passthrough vertex shader copies position and texcoord vertex attributes to varying outputs. It also optionally copies a third gl_Color attribute, which sometimes is unnecessary. Until now, we've compiled separate variants of the shader, one of which does this extra copy, and

[Mesa-dev] [PATCH 4/6] st/mesa: Combine the DrawPixels and Bitmap passthrough VS programs.

2018-12-17 Thread Kenneth Graunke
They're now identical, so we can just compile it once. --- src/mesa/state_tracker/st_cb_bitmap.c | 27 +-- src/mesa/state_tracker/st_cb_drawpixels.c | 20 - src/mesa/state_tracker/st_cb_drawpixels.h | 3 +++ src/mesa/state_tracker/st_context.h | 5

[Mesa-dev] [PATCH 6/6] st/nir: Drop unused gl_program parameter in VS input handling helper.

2018-12-17 Thread Kenneth Graunke
Nobody uses this, so let's drop it. This makes the helper callable from places without a gl_program. --- src/mesa/state_tracker/st_glsl_to_nir.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/mesa/state_tracker/st_glsl_to_nir.cpp

[Mesa-dev] [PATCH 3/6] st/mesa: Don't open code the drawpixels vertex shader.

2018-12-17 Thread Kenneth Graunke
Now that we always copy color, we can just use the util function. --- src/mesa/state_tracker/st_cb_drawpixels.c | 38 +++ 1 file changed, 11 insertions(+), 27 deletions(-) diff --git a/src/mesa/state_tracker/st_cb_drawpixels.c b/src/mesa/state_tracker/st_cb_drawpixels.c

[Mesa-dev] [PATCH 1/6] st/mesa: Drop dead 'passthrough_fs' field.

2018-12-17 Thread Kenneth Graunke
Dead since 2015 (commit 5142564734bd68f165b02e29e384ebbcf91cce38). --- src/mesa/state_tracker/st_context.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/mesa/state_tracker/st_context.h b/src/mesa/state_tracker/st_context.h index 95133c7020f..78e962dec00 100644 ---

Re: [Mesa-dev] [PATCH mesa] drop autotools

2018-12-17 Thread Bas Nieuwenhuizen
On Mon, Dec 17, 2018 at 6:33 PM Juan A. Suarez Romero wrote: > > On Mon, 2018-12-03 at 10:21 +, Eric Engestrom wrote: > > Cc: Emil Velikov > > Cc: Andres Gomez > > Cc: Juan A. Suarez Romero > > Cc: Dylan Baker > > Signed-off-by: Eric Engestrom > > --- > > This patch depends on the

Re: [Mesa-dev] PSA: Please send MRs to the mailing list

2018-12-17 Thread Eric Anholt
Jason Ekstrand writes: > I don't know if it was actually in the doc that Jordan wrote up but it's > courteous of you to send a quick e-mail to the mailing list when you create > a new MR so that people who aren't regularly trolling the list of MRs are > at least aware that it exists. Of the 20

[Mesa-dev] [PATCH] freedreno/ir3: Make imageStore use num components from image format

2018-12-17 Thread Eduardo Lima Mitev
emit_intrinsic_store_image() is always using 4 components when collecting registers for the value. When image has less than 4 components (e.g, r32f, r32i, r32ui) this results in extra mov instructions. This patch uses the actual number of components from the image format. For example, in a

Re: [Mesa-dev] PSA: Please send MRs to the mailing list

2018-12-17 Thread Jason Ekstrand
On Mon, Dec 17, 2018 at 2:13 PM Jason Ekstrand wrote: > On Mon, Dec 17, 2018 at 1:53 PM Eric Anholt wrote: > >> Jason Ekstrand writes: >> >> > I don't know if it was actually in the doc that Jordan wrote up but it's >> > courteous of you to send a quick e-mail to the mailing list when you >>

Re: [Mesa-dev] last call for autotools

2018-12-17 Thread Eric Anholt
Eero Tamminen writes: > Hi, > > On 17.12.2018 8.08, Marek Olšák wrote: > [...] >> I think one of the serious usability issues is that environment >> variables such as CFLAGS, CXXFLAGS, LDFLAGS, and PKG_CONFIG_PATH are not >> saved by meson for future reconfigures. > > I don't know what Meson

[Mesa-dev] [Bug 109062] meson incorrectly handles/reports libdrm_$foo

2018-12-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109062 --- Comment #5 from Emil Velikov --- On my 3+ y/o laptop shows virtually no difference in runtime between the following two commands. pkg-config --libs "libdrm >= 2.4.20" "libdrm_nouveau >= 2.4.20" pkg-config --libs "libdrm_nouveau >= 2.4.20"

[Mesa-dev] [Bug 109062] meson incorrectly handles/reports libdrm_$foo

2018-12-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109062 --- Comment #6 from Dylan Baker --- that's not the right comparison though. Meson doesn't support querying two dependencies at the same time, that's something that only pkg-config can do (you can't do that with windows find-a-dll, mac's

[Mesa-dev] [Bug 109075] radv: New D3D boolean optimizations cause GPU hang in Witcher 3

2018-12-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109075 --- Comment #1 from var...@protonmail.com --- Polaris 30 (RX 590, 4.20 and latest firmware), DXVK 0.94 Latest mesa-git built against llvm 7.0.1 This line also seems to break Overwatch, resulting in a black login screen. Commenting out the line

Re: [Mesa-dev] [PATCH] WIP: meson: allow building DRI loaders without a DRI driver

2018-12-17 Thread Tobias Klausmann
On 17.12.18 20:33, Dylan Baker wrote: Quoting Emil Velikov (2018-12-17 11:10:00) On Fri, 14 Dec 2018 at 17:57, Dylan Baker wrote: Quoting Emil Velikov (2018-12-13 08:15:57) From: Emil Velikov Reasonably often people will want to build the loader w/o any drivers. Be that debugging an issue

[Mesa-dev] MR: NIR: Partial redundancy elimination for compares

2018-12-17 Thread Ian Romanick
https://gitlab.freedesktop.org/mesa/mesa/merge_requests/22 This series adds a new optimization pass that tries to replace code sequences like if (x < y) { z = y - x; ... } with a sequence like t = x - y; if (t < 0) { z = -t; ... } On architectures where the subtract can

Re: [Mesa-dev] [PATCH mesa] drop autotools

2018-12-17 Thread Juan A. Suarez Romero
On Mon, 2018-12-03 at 10:21 +, Eric Engestrom wrote: > Cc: Emil Velikov > Cc: Andres Gomez > Cc: Juan A. Suarez Romero > Cc: Dylan Baker > Signed-off-by: Eric Engestrom > --- > This patch depends on the releasing procedure in docs/releasing.html to > be updated to not rely on autotools

Re: [Mesa-dev] [PATCH v5] anv/android: add GetAndroidHardwareBufferPropertiesANDROID

2018-12-17 Thread Lionel Landwerlin
On 14/12/2018 11:53, Tapani Pälli wrote: + if (desc.usage & AHARDWAREBUFFER_USAGE_GPU_DATA_BUFFER) + tiling = VK_IMAGE_TILING_LINEAR; + + p->formatFeatures = + anv_get_image_format_features(>info, p->format, +anv_format, VK_IMAGE_TILING_OPTIMAL);

Re: [Mesa-dev] [PATCH 03/18] glx: meson: build src/glx only with -Dglx=dri

2018-12-17 Thread Dylan Baker
Quoting Emil Velikov (2018-12-17 10:58:11) > On Fri, 14 Dec 2018 at 17:13, Dylan Baker wrote: > > > > Quoting Emil Velikov (2018-12-13 08:05:52) > > > From: Emil Velikov > > > > > > The library is the dri capable one, push the check src/meson.build, > > > instead of the current partial handling

Re: [Mesa-dev] [PATCH 1/2] bin/get-pick-list.sh: rework handing of sha nominations

2018-12-17 Thread Andres Gomez
On Mon, 2018-12-17 at 16:43 +, Emil Velikov wrote: > Currently our is_sha_nomination does: > - folds any whitespace, attempting to extract sha-like information > - checks that at least one of the shas has landed > > Split it in two and do sha-like validation first. > > This way, commits

Re: [Mesa-dev] PSA: Please send MRs to the mailing list

2018-12-17 Thread Jason Ekstrand
On Mon, Dec 17, 2018 at 1:53 PM Eric Anholt wrote: > Jason Ekstrand writes: > > > I don't know if it was actually in the doc that Jordan wrote up but it's > > courteous of you to send a quick e-mail to the mailing list when you > create > > a new MR so that people who aren't regularly trolling

Re: [Mesa-dev] [PATCH] WIP: meson: allow building DRI loaders without a DRI driver

2018-12-17 Thread Dylan Baker
Quoting Tobias Klausmann (2018-12-17 14:05:13) > > On 17.12.18 20:33, Dylan Baker wrote: > > Quoting Emil Velikov (2018-12-17 11:10:00) > >> On Fri, 14 Dec 2018 at 17:57, Dylan Baker wrote: > >>> Quoting Emil Velikov (2018-12-13 08:15:57) > From: Emil Velikov > > Reasonably often

Re: [Mesa-dev] [PATCH 4/4] nir: link time opt duplicate varyings

2018-12-17 Thread Jason Ekstrand
On Mon, Dec 10, 2018 at 10:28 PM Timothy Arceri wrote: > If we are outputting the same value to more than one output > component rewrite the inputs to read from a single component. > > This will allow the duplicate varying components to be optimised > away by the existing opts. > > shader-db

[Mesa-dev] [PATCH 3/7] nir/lower_io_arrays_to_elements: Look at derefs for modes

2018-12-17 Thread Jason Ekstrand
This is instead of looking all the way back to the variable which may not exist for all derefs. This makes this code properly ignore casts with modes other than the mode[s] we care about (where casts aren't allowed). --- src/compiler/nir/nir_lower_io_arrays_to_elements.c | 13 - 1

[Mesa-dev] [PATCH 6/7] nir/copy_prop_vars: Get modes directly from derefs

2018-12-17 Thread Jason Ekstrand
Instead of going all the way back to the variable, just look at the deref. The modes are guaranteed to be the same by nir_validate whenever the variable can be found. This fixes apply_barrier_for_modes for derefs that don't have an accessible variable. ---

[Mesa-dev] [PATCH 7/7] nir/dead_write_vars: Get modes directly from derefs

2018-12-17 Thread Jason Ekstrand
Instead of going all the way back to the variable, just look at the deref. The modes are guaranteed to be the same by nir_validate whenever the variable can be found. This fixes clear_unused_for_modes for derefs that don't have an accessible variable. ---

[Mesa-dev] [PATCH 5/7] nir/lower_wpos_center: Look at derefs for modes

2018-12-17 Thread Jason Ekstrand
This is instead of looking all the way back to the variable which may not exist for all derefs. This makes this code properly ignore casts with modes other than the mode[s] we care about (where casts aren't allowed). --- src/compiler/nir/nir_lower_wpos_center.c | 6 -- 1 file changed, 4

[Mesa-dev] [PATCH 2/7] nir/linking_helpers: Look at derefs for modes

2018-12-17 Thread Jason Ekstrand
This is instead of looking all the way back to the variable which may not exist for all derefs. This makes this code properly ignore casts with modes other than the mode[s] we care about (where casts aren't allowed). --- src/compiler/nir/nir_linking_helpers.c | 23 +++ 1 file

[Mesa-dev] [PATCH 4/7] nir/lower_io_to_scalar: Look at derefs for modes

2018-12-17 Thread Jason Ekstrand
This is instead of looking all the way back to the variable which may not exist for all derefs. This makes this code properly ignore casts with modes other than the mode[s] we care about (where casts aren't allowed). --- src/compiler/nir/nir_lower_io_to_scalar.c | 9 ++--- 1 file changed, 6

[Mesa-dev] [PATCH 1/7] nir/propagate_invariant: Skip unknown vars

2018-12-17 Thread Jason Ekstrand
If we can't find the variable from the deref, just assume it isn't invariant and continue on. This can happen if, for instance, we're writing to a deref that points into an SSBO. --- src/compiler/nir/nir_propagate_invariant.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[Mesa-dev] [PATCH 0/7] nir: Prepare various passes for cast derefs

2018-12-17 Thread Jason Ekstrand
In order to be able to use derefs for UBOs and SSBOs and actually pass them through optimizations, various things need to be fixed up to properly handle casts. Because casts are only going to be allowed on UBOs, SSBOs, and maybe shared variables at present, most of the time it's as simple as

[Mesa-dev] [Bug 109075] radv: New D3D boolean optimizations cause GPU hang in Witcher 3

2018-12-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109075 --- Comment #4 from Timothy Arceri --- It looks like the '1.0@32' part of the search is failing. It also seems this is the only opt that looks for a constant in the whole file. Everything else looks for variables or ops e.g. 'a@32', 'bcsel@32'

Re: [Mesa-dev] [PATCH v2 29/29] nir/algebraic: Add some optimizations for D3D-style Booleans

2018-12-17 Thread Timothy Arceri
On 7/12/18 6:45 am, Jason Ekstrand wrote: D3D Booleans use a 32-bit 0/-1 representation. Because this previously matched NIR exactly, we didn't have to really optimize for it. Now that we have 1-bit Booleans, we need some specific optimizations to chew through the D3D12-style Booleans.

Re: [Mesa-dev] [PATCH 7/7] nir/dead_write_vars: Get modes directly from derefs

2018-12-17 Thread Timothy Arceri
Series: Reviewed-by: Timothy Arceri On 18/12/18 3:44 pm, Jason Ekstrand wrote: Instead of going all the way back to the variable, just look at the deref. The modes are guaranteed to be the same by nir_validate whenever the variable can be found. This fixes clear_unused_for_modes for derefs

[Mesa-dev] [Bug 109075] radv: New D3D boolean optimizations cause GPU hang in Witcher 3

2018-12-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109075 --- Comment #2 from Jason Ekstrand --- This is really weird because, of all the optimizations in that commit, that is the one that's NOT new. It wasn't in that exact form but we definitely had that optimization before my 1-bit booleans series.

[Mesa-dev] [Bug 109075] radv: New D3D boolean optimizations cause GPU hang in Witcher 3

2018-12-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109075 --- Comment #3 from Timothy Arceri --- Maybe getting stuck in a infinite loop? There is a loop exit condition in the witcher where the optimise the following: /* preds: block_3 */ vec2 32 ssa_114 = vec2

Re: [Mesa-dev] [PATCH 26/38] ac/nir: implement 8 and 16 bit ac_build_imsb

2018-12-17 Thread Marek Olšák
On Fri, Dec 7, 2018 at 12:23 PM Rhys Perry wrote: > Signed-off-by: Rhys Perry > --- > src/amd/common/ac_llvm_build.c | 4 > 1 file changed, 4 insertions(+) > > diff --git a/src/amd/common/ac_llvm_build.c > b/src/amd/common/ac_llvm_build.c > index 0123f3e31d..2172d81f8b 100644 > ---

Re: [Mesa-dev] [PATCH 35/38] ac,radv: run LLVM's SLP vectorizer

2018-12-17 Thread Marek Olšák
Can you remove AC_TM_SLP_VECTORIZE and run the pass unconditionally on >= gfx9? Thanks, Marek On Fri, Dec 7, 2018 at 12:23 PM Rhys Perry wrote: > Signed-off-by: Rhys Perry > --- > src/amd/common/ac_llvm_util.c | 9 ++--- > src/amd/common/ac_llvm_util.h | 1 + >

Re: [Mesa-dev] [PATCH 0/5] Fixueps for ppc64 and gnu hurd

2018-12-17 Thread Stuart Young
Hi Dylan, Can't speak on Timo's behalf, but looking at the build logs for 18.3.0 (which is patched with these patches), it built fine on ppc64el (Little Endian PPC64), but hurd is having issues, tho it looks like it's not directly related to the patch you provided. Seems like the issue is that

Re: [Mesa-dev] [PATCH 0/5] Fixueps for ppc64 and gnu hurd

2018-12-17 Thread Timo Aaltonen
On 18.12.2018 7.52, Stuart Young wrote: > Hi Dylan, > > Can't speak on Timo's behalf, but looking at the build logs for 18.3.0 > (which is patched with these patches), it built fine on ppc64el (Little > Endian PPC64), but hurd is having issues, tho it looks like it's not > directly related to the

[Mesa-dev] [PATCH 1/2] bin/get-pick-list.sh: rework handing of sha nominations

2018-12-17 Thread Emil Velikov
Currently our is_sha_nomination does: - folds any whitespace, attempting to extract sha-like information - checks that at least one of the shas has landed Split it in two and do sha-like validation first. This way, commits with mesa-stable and sha nominations will feature the fixes/revert/etc

[Mesa-dev] [PATCH 2/2] bin/get-pick-list.sh: warn when commit lists invalid sha

2018-12-17 Thread Emil Velikov
From: Emil Velikov We had cases where people would list old/invalid sha in the commit. Add a trivial checker to catch those and throw a warning. CC: Andres Gomez CC: Juan A. Suarez CC: Dylan Baker CC: mesa-sta...@lists.freedesktop.org Signed-off-by: Emil Velikov --- bin/get-pick-list.sh |

[Mesa-dev] [PATCH] anv: Bump the patch version to 96

2018-12-17 Thread Jason Ekstrand
--- src/intel/vulkan/anv_extensions.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/intel/vulkan/anv_extensions.py b/src/intel/vulkan/anv_extensions.py index b6269d0047a..a0bf4127002 100644 --- a/src/intel/vulkan/anv_extensions.py +++

Re: [Mesa-dev] [PATCH] anv: Bump the patch version to 96

2018-12-17 Thread Lionel Landwerlin
Reviewed-by: Lionel Landwerlin On 17/12/2018 16:49, Jason Ekstrand wrote: --- src/intel/vulkan/anv_extensions.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/intel/vulkan/anv_extensions.py b/src/intel/vulkan/anv_extensions.py index b6269d0047a..a0bf4127002 100644

Re: [Mesa-dev] last call for autotools

2018-12-17 Thread Jason Ekstrand
On Mon, Dec 17, 2018 at 8:54 AM Eero Tamminen wrote: > Hi, > > On 17.12.2018 8.08, Marek Olšák wrote: > [...] > > I think one of the serious usability issues is that environment > > variables such as CFLAGS, CXXFLAGS, LDFLAGS, and PKG_CONFIG_PATH are not > > saved by meson for future

[Mesa-dev] [Bug 109062] meson incorrectly handles/reports libdrm_$foo

2018-12-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109062 --- Comment #4 from Dylan Baker --- That's going to increase the number of calls to pkg-config considerably. If we take this approach please check the changes in the time it takes to run an initial meson; I have a feeling it could be bad. The

Re: [Mesa-dev] [PATCH 0/5] Fixueps for ppc64 and gnu hurd

2018-12-17 Thread Dylan Baker
Quoting Timo Aaltonen (2018-12-05 03:56:54) > On 4.12.2018 23.52, Dylan Baker wrote: > > This little series is aimed at fixing problems reported by fedora and debian > > when using meson, there's a couple of patches in here for fixing ppc64 > > detection > > (tested without llvm), and a couple

[Mesa-dev] [Bug 109071] meson --wipe results in Exception: "FileNotFoundError: [Errno 2] No such file or directory"

2018-12-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109071 Dylan Baker changed: What|Removed |Added Assignee|mesa-dev@lists.freedesktop. |baker.dyla...@gmail.com

Re: [Mesa-dev] last call for autotools

2018-12-17 Thread Dylan Baker
Quoting Gert Wollny (2018-12-16 03:57:48) > Am Freitag, den 14.12.2018, 13:11 +0100 schrieb Gert Wollny: > > Am Freitag, den 14.12.2018, 01:19 -0500 schrieb Ilia Mirkin: > > > I have to say that the user experience for autotools is WAY better > > > than for meson. As a concrete example, I had a

[Mesa-dev] [Bug 108946] High memory usage in Black Mesa

2018-12-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108946 --- Comment #11 from void...@gmail.com --- On December 17, we pushed new beta into public-beta branch. That's major ToGL layer rework, which should address memory issues with open-source Mesa drivers. The actual issue is much deeper than one

Re: [Mesa-dev] last call for autotools

2018-12-17 Thread Dylan Baker
Quoting Kai Wasserbäch (2018-12-17 07:48:38) > Hey Dylan, > Dylan Baker wrote on 11.12.18 00:10: > > Meson 0.49.0 has been out for a couple of days now, and I'd like to make the > > final call for autotools. My patch is so massive that it's a huge pain to > > send > > to the list, the latest

[Mesa-dev] [PATCH] etnaviv: Consolidate buffer references from framebuffers

2018-12-17 Thread Tomeu Vizoso
We were leaking surfaces because the references taken in etna_set_framebuffer_state weren't being released on context destroy. Instead of just directly releasing those references in etna_context_destroy, use the util_copy_framebuffer_state helper. Take the chance to remove the duplicated buffer

Re: [Mesa-dev] [PATCH] nir/constant_folding: Fix source bit size logic

2018-12-17 Thread Juan A. Suarez Romero
On Thu, 2018-12-06 at 14:36 -0600, Jason Ekstrand wrote: > Instead of looking at input_sizes[i] which contains the number of > components for each source, we look at the bit size of input_types[i]. > This fixes a regression in the 1-bit boolean series though I have no > idea how we haven't seen it

Re: [Mesa-dev] [PATCH] nir/constant_folding: fix incorrect bit-size check

2018-12-17 Thread Juan A. Suarez Romero
On Wed, 2018-10-31 at 12:18 +0100, Iago Toral Quiroga wrote: > nir_alu_type_get_type_size takes a type as parameter and we were > passing a bit-size instead, which did what we wanted by accident, > since a bit-size of zero matches nir_type_invalid, which has a > size of 0 too. > --- While this

Re: [Mesa-dev] [PATCH 01/25] r600: remove redundant semicolon

2018-12-17 Thread Gert Wollny
Reviewed-By: Gert Wollny Am Donnerstag, den 06.12.2018, 15:00 +0100 schrieb Nicolai Hähnle: > From: Nicolai Hähnle > > --- > src/gallium/drivers/r600/sb/sb_ir.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/gallium/drivers/r600/sb/sb_ir.h >

Re: [Mesa-dev] [PATCH] etnaviv: Consolidate buffer references from framebuffers

2018-12-17 Thread Christian Gmeiner
Am Mo., 17. Dez. 2018 um 09:56 Uhr schrieb Tomeu Vizoso : > > We were leaking surfaces because the references taken in > etna_set_framebuffer_state weren't being released on context destroy. > > Instead of just directly releasing those references in > etna_context_destroy, use the

[Mesa-dev] [Bug 109075] radv: New D3D boolean optimizations cause GPU hang in Witcher 3

2018-12-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109075 Bug ID: 109075 Summary: radv: New D3D boolean optimizations cause GPU hang in Witcher 3 Product: Mesa Version: git Hardware: Other OS: All

Re: [Mesa-dev] [PATCH 2/2] ac: split 16-bit ssbo loads that may not be dword aligned

2018-12-17 Thread Juan A. Suarez Romero
On Thu, 2018-12-13 at 17:06 +, Rhys Perry wrote: > Fixes: 7e7ee826982 ('ac: add support for 16bit buffer loads') > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108114 > Signed-off-by: Rhys Perry This patch is a candidate for 18.2 stable, as 7e7ee826982 ('ac: add support for 16bit

Re: [Mesa-dev] Suggestions for improving meson-based builds

2018-12-17 Thread Ilia Mirkin
On Mon, Dec 17, 2018 at 6:59 AM Lionel Landwerlin wrote: > > On 17/12/2018 00:33, Jason Ekstrand wrote: > > On Sun, Dec 16, 2018 at 1:49 PM Ilia Mirkin wrote: >> >> 1. Build creation command recovery. With autotools, "head config.log" >> will tell you how you configured it. This is important

Re: [Mesa-dev] Suggestions for improving meson-based builds

2018-12-17 Thread Lionel Landwerlin
On 17/12/2018 12:04, Ilia Mirkin wrote: On Mon, Dec 17, 2018 at 6:59 AM Lionel Landwerlin wrote: On 17/12/2018 00:33, Jason Ekstrand wrote: On Sun, Dec 16, 2018 at 1:49 PM Ilia Mirkin wrote: 1. Build creation command recovery. With autotools, "head config.log" will tell you how you

[Mesa-dev] [Bug 109062] meson incorrectly handles/reports libdrm_$foo

2018-12-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109062 --- Comment #2 from Emil Velikov --- How about something like the following pseudo code. AFAICT it should produce the correct output. req_libdrm=... req_libdrm_foo=... req_libdrm_bar=... foreach driver : gallium-drivers // or drivers in

Re: [Mesa-dev] Suggestions for improving meson-based builds

2018-12-17 Thread Lionel Landwerlin
On 17/12/2018 00:33, Jason Ekstrand wrote: On Sun, Dec 16, 2018 at 1:49 PM Ilia Mirkin > wrote: 1. Build creation command recovery. With autotools, "head config.log" will tell you how you configured it. This is important when things get screwed up, and

[Mesa-dev] [Bug 109062] meson incorrectly handles/reports libdrm_$foo

2018-12-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109062 --- Comment #3 from Eric Engestrom --- (In reply to Emil Velikov from comment #2) > How about something like the following pseudo code. [...] >dep_libdrm_$driver = dependency(libdrm >= req_libdrm_$driver, >

[Mesa-dev] [Bug 108114] [vulkancts] new VK_KHR_16bit_storage tests fail.

2018-12-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108114 Samuel Pitoiset changed: What|Removed |Added Resolution|--- |FIXED Status|NEW

[Mesa-dev] [Bug 108275] Breaking out of loop creates broken code on RADV

2018-12-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108275 Samuel Pitoiset changed: What|Removed |Added Resolution|--- |FIXED Status|NEW

  1   2   >