[Mesa-dev] [PATCH] st/glsl_to_nir: fix incorrect arrary access

2019-03-01 Thread Timothy Arceri
This fixes a segfault when we try to access the array using a -1 when the array wasn't allocated in the first place. Before 7536af670b75 we would just access a pre-allocated array that was also load/stored to/from the shader cache. But now the cache will no longer allocate these arrays if they

Re: [Mesa-dev] [PATCH] RFC: Workaround for pthread_setaffinity_np() seccomp filtering

2019-03-01 Thread Eero Tamminen
Hi, On 1.3.2019 11.12, Michel Dänzer wrote: On 2019-02-28 8:41 p.m., Marek Olšák wrote: On Thu, Feb 28, 2019 at 1:37 PM Eero Tamminen Why distro versions of Qemu filter sched_setaffinity() syscall? (https://bugs.launchpad.net/ubuntu/+source/qemu/+bug/1815889) Daniel Berrange (berrange)

Re: [Mesa-dev] [PATCH] RFC: Workaround for pthread_setaffinity_np() seccomp filtering

2019-03-01 Thread Mathias Fröhlich
On Friday, 1 March 2019 12:15:08 CET Eero Tamminen wrote: > Hi, > > On 1.3.2019 11.12, Michel Dänzer wrote: > > On 2019-02-28 8:41 p.m., Marek Olšák wrote: > >>> On Thu, Feb 28, 2019 at 1:37 PM Eero Tamminen > Why distro versions of Qemu filter sched_setaffinity() syscall? > >>> > >>>

Re: [Mesa-dev] [PATCH v4 34/40] intel/compiler: validate region restrictions for half-float conversions

2019-03-01 Thread Iago Toral
On Fri, 2019-03-01 at 09:39 +0100, Iago Toral wrote: > On Thu, 2019-02-28 at 09:54 -0800, Francisco Jerez wrote: > > Iago Toral writes: > > > > > On Wed, 2019-02-27 at 13:47 -0800, Francisco Jerez wrote: > > > > Iago Toral writes: > > > > > > > > > On Tue, 2019-02-26 at 14:54 -0800, Francisco

[Mesa-dev] [Bug 109807] Add more granular multiarch usage for Mesa Vulkan overlay JSON manifest

2019-03-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109807 Jason Ekstrand changed: What|Removed |Added CC|ja...@jlekstrand.net| -- You are receiving this mail

[Mesa-dev] Should piglit drop bugzilla and move to using gitlab issues?

2019-03-01 Thread Jordan Justen
I guess piglit makes very light usage of bugzilla. Would it be simpler to just use gitlab issues in the piglit gitlab project? -Jordan ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] Should piglit drop bugzilla and move to using gitlab issues?

2019-03-01 Thread Dylan Baker
Quoting Jordan Justen (2019-03-01 12:22:18) > I guess piglit makes very light usage of bugzilla. Would it be simpler > to just use gitlab issues in the piglit gitlab project? > > -Jordan I think we should, anecdotally it seems like there are more spam bugs against piglit than real bugs anyway.

Re: [Mesa-dev] 2019 X.Org Board of Directors Elections Nomination period is NOW

2019-03-01 Thread Wentland, Harry
The nomination period is now closed. We'll announce nominees March 7. Note also that the membership deadline is March 7. If you haven't signed-up to be a member and would like to do so there's only 6 more days left. Harry On 2019-02-14 5:27 p.m., Wentland, Harry wrote: > Since we haven't seen

[Mesa-dev] Piglit gitlab merge requests enabled - Re: GitLab migration of Piglit

2019-03-01 Thread Jordan Justen
On 2019-02-20 07:36:48, Den wrote: > > Given the discussion below, I think we'll make piglit a sub-project of > > mesa.  Those who need commit access to piglit but not mesa can be > > added directly to the piglit project. > > Hi list. > > Since piglit was also moved to the gitlab, same with

Re: [Mesa-dev] Should piglit drop bugzilla and move to using gitlab issues?

2019-03-01 Thread Kenneth Graunke
On Friday, March 1, 2019 1:30:48 PM PST Dylan Baker wrote: > Quoting Jordan Justen (2019-03-01 12:22:18) > > I guess piglit makes very light usage of bugzilla. Would it be simpler > > to just use gitlab issues in the piglit gitlab project? > > > > -Jordan > > I think we should, anecdotally it

Re: [Mesa-dev] [Piglit] Piglit gitlab merge requests enabled - Re: GitLab migration of Piglit

2019-03-01 Thread Dylan Baker
Quoting Jordan Justen (2019-03-01 12:16:57) > On 2019-02-20 07:36:48, Den wrote: > > > Given the discussion below, I think we'll make piglit a sub-project of > > > mesa.  Those who need commit access to piglit but not mesa can be > > > added directly to the piglit project. > > > > Hi list. > >

Re: [Mesa-dev] [PATCH 1/3] gallium: add pipe_grid_info::last_block

2019-03-01 Thread Liu, Leo
Series are: Acked-by: Leo Liu On 2/27/19 5:19 PM, Marek Olšák wrote: > From: Marek Olšák > > The OpenMAX state tracker will use this. > > RadeonSI is adapted to use pipe_grid_info::last_block instead of its > internal state. > --- > src/gallium/auxiliary/util/u_screen.c | 3 +++ >

[Mesa-dev] [Bug 109805] GPU hangs with error VM_CONTEXT1_PROTECTION_FAULT_STATUS

2019-03-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109805 --- Comment #3 from Samuel Pitoiset --- Random GPU hangs are really hard to fix. Can you reproduce the problem with export RADV_DEBUG=zerovram,nodcc,nohiz,nofastclears ? Also, LLVM 7 is quite old, I would recommend to upgrade, although VM

[Mesa-dev] [PATCH] radv: only load 2-dwords for vertex buffers when robustness is disabled

2019-03-01 Thread Samuel Pitoiset
This patch requires the typed vertex fetches series. Totals from affected shaders: SGPRS: 445574 -> 452638 (1.59 %) VGPRS: 373392 -> 370436 (-0.79 %) Spilled SGPRs: 77 -> 14 (-81.82 %) Spilled VGPRs: 0 -> 0 (0.00 %) Code Size: 14162288 -> 14413036 (1.77 %) bytes Max Waves: 11 -> 120509 (0.43

Re: [Mesa-dev] [PATCH 2/2] st/mesa: Invalidate the gallium array atom only if needed.

2019-03-01 Thread Brian Paul
The series looks OK to me. Reviewed-by: Brian Paul On 02/28/2019 11:18 PM, mathias.froehl...@gmx.net wrote: From: Mathias Fröhlich Now that the buffer object usage history tracks if it is being used as vertex buffer object, we can restrict setting the ST_NEW_VERTEX_ARRAYS bit to dirty on

Re: [Mesa-dev] [PATCH] gallium/util: Fix off-by-one in box intersection

2019-03-01 Thread Gurchetan Singh
On Thu, Feb 28, 2019 at 8:15 PM Roland Scheidegger wrote: > > Am 01.03.19 um 00:28 schrieb Gurchetan Singh: > > On Thu, Feb 28, 2019 at 12:39 AM Boris Brezillon > > wrote: > >> > >> Hello Gurchetan, > >> > >> On Wed, 27 Feb 2019 10:34:26 -0800 > >> Gurchetan Singh wrote: > >> > >>> On Mon, Feb

[Mesa-dev] [PATCH] rav: use 32_AR instead of 32_ABGR when alpha coverage is required

2019-03-01 Thread Samuel Pitoiset
This export format is faster. Seems to improve performance in Wreckfest. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_pipeline.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/amd/vulkan/radv_pipeline.c b/src/amd/vulkan/radv_pipeline.c index

[Mesa-dev] [PATCH] gallium/u_transfer_helper: do not call resource_create(..) directly

2019-03-01 Thread Christian Gmeiner
Use u_transfer_helper_resource_create(..) instead which uses the resource_create(..) function specified in u_transfer_vtbl. Signed-off-by: Christian Gmeiner --- src/gallium/auxiliary/util/u_transfer_helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[Mesa-dev] [Bug 109807] Add more granular multiarch usage for Mesa Vulkan overlay JSON manifest

2019-03-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109807 Bug ID: 109807 Summary: Add more granular multiarch usage for Mesa Vulkan overlay JSON manifest Product: Mesa Version: git Hardware: All OS: All

Re: [Mesa-dev] [PATCH] RFC: Workaround for pthread_setaffinity_np() seccomp filtering

2019-03-01 Thread Marek Olšák
FYI, starting with AMD Ryzen, multithreaded apps and libs pretty much have to change thread affinity to get good performance out of multithreading. Marek On Thu, Feb 28, 2019, 11:41 AM Marek Olšák wrote: > On Thu, Feb 28, 2019 at 11:13 AM Marc-André Lureau < > marcandre.lur...@gmail.com>

Re: [Mesa-dev] [PATCH v4 34/40] intel/compiler: validate region restrictions for half-float conversions

2019-03-01 Thread Francisco Jerez
Iago Toral writes: > On Fri, 2019-03-01 at 09:39 +0100, Iago Toral wrote: >> On Thu, 2019-02-28 at 09:54 -0800, Francisco Jerez wrote: >> > Iago Toral writes: >> > >> > > On Wed, 2019-02-27 at 13:47 -0800, Francisco Jerez wrote: >> > > > Iago Toral writes: >> > > > >> > > > > On Tue,

[Mesa-dev] [Bug 109810] nir_opt_copy_prop_vars.c:454: error: unknown field ‘ssa’ specified in initializer

2019-03-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109810 --- Comment #1 from Caio Marcelo de Oliveira Filho --- I suspect this is https://gcc.gnu.org/bugzilla/show_bug.cgi?id=10676. In our struct we have a nested union that's unnamed. The tested GCC misses that somehow. struct value { bool

Re: [Mesa-dev] [PATCH v4 34/40] intel/compiler: validate region restrictions for half-float conversions

2019-03-01 Thread Francisco Jerez
Iago Toral writes: > On Thu, 2019-02-28 at 09:54 -0800, Francisco Jerez wrote: >> Iago Toral writes: >> >> > On Wed, 2019-02-27 at 13:47 -0800, Francisco Jerez wrote: >> > > Iago Toral writes: >> > > >> > > > On Tue, 2019-02-26 at 14:54 -0800, Francisco Jerez wrote: >> > > > > Iago Toral

[Mesa-dev] [Bug 109810] nir_opt_copy_prop_vars.c:454: error: unknown field ‘ssa’ specified in initializer

2019-03-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109810 Bug ID: 109810 Summary: nir_opt_copy_prop_vars.c:454: error: unknown field ‘ssa’ specified in initializer Product: Mesa Version: git Hardware: x86-64 (AMD64)

Re: [Mesa-dev] [PATCH v4 34/40] intel/compiler: validate region restrictions for half-float conversions

2019-03-01 Thread Iago Toral
On Thu, 2019-02-28 at 09:54 -0800, Francisco Jerez wrote: > Iago Toral writes: > > > On Wed, 2019-02-27 at 13:47 -0800, Francisco Jerez wrote: > > > Iago Toral writes: > > > > > > > On Tue, 2019-02-26 at 14:54 -0800, Francisco Jerez wrote: > > > > > Iago Toral Quiroga writes: > > > > > > > >

Re: [Mesa-dev] [PATCH] RFC: Workaround for pthread_setaffinity_np() seccomp filtering

2019-03-01 Thread Michel Dänzer
On 2019-02-28 8:41 p.m., Marek Olšák wrote: > On Thu, Feb 28, 2019 at 11:13 AM Marc-André Lureau < > marcandre.lur...@gmail.com> wrote: >> On Thu, Feb 28, 2019 at 1:37 PM Eero Tamminen >> wrote: >>> >>> Why distro versions of Qemu filter sched_setaffinity() syscall? >> >>

[Mesa-dev] [Bug 109805] GPU hangs with error VM_CONTEXT1_PROTECTION_FAULT_STATUS

2019-03-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109805 Michel Dänzer changed: What|Removed |Added Component|Mesa core |Drivers/Vulkan/radeon --- Comment #2

Re: [Mesa-dev] [PATCH 1/2] radeonsi: always use compute rings for clover on CI and newer (v2)

2019-03-01 Thread Marek Olšák
On Thu, Feb 28, 2019 at 4:44 AM Jan Vesely wrote: > On Tue, 2019-02-26 at 18:34 -0500, Marek Olšák wrote: > > I ran a simple test verifying that compute is working properly on the > > compute ring. > > I guess this was not on raven? With his patch I no loner see gfx > timeout but the apps still

Re: [Mesa-dev] [PATCH] panfrost/midgard: Don't force constant on VLUT

2019-03-01 Thread Tomeu Vizoso
Cannot really review this myself, but: Tested-by: Tomeu Vizoso Thanks! Tomeu On Wed, 27 Feb 2019 at 04:36, Alyssa Rosenzweig wrote: > > Previously, we forced a #0 inline constant tacked on for the lut > instructions to mirror the blob's behaviour, which caused some > suboptimal codegen due

Re: [Mesa-dev] [PATCH] panfrost: Flush with offscreen rendering

2019-03-01 Thread Tomeu Vizoso
Reviewed-by: Tomeu Vizoso Thanks, Tomeu On Wed, 27 Feb 2019 at 04:44, Alyssa Rosenzweig wrote: > > This special-case was needlessly added and breaks purely offscreen > rendering (when there is no scanout involved). > > Signed-off-by: Alyssa Rosenzweig > --- >

Re: [Mesa-dev] [PATCH 0/3] panfrost: Begin panfrost_job abstraction

2019-03-01 Thread Tomeu Vizoso
On Wed, 27 Feb 2019 at 01:56, Alyssa Rosenzweig wrote: > > In an effort to cleanup the codebase and prepare for more complex FBO > usecases, this patch series begins the slow refactor towards > jobs/batches, rather than shoving all state into panfrost_context and > hoping it works. We use some

Re: [Mesa-dev] [PATCH 1/2] panfrost/midgard: Promote smul to vmul

2019-03-01 Thread Tomeu Vizoso
Cannot really review this myself, but: Tested-by: Tomeu Vizoso Thanks! On Wed, 27 Feb 2019 at 06:49, Alyssa Rosenzweig wrote: > > smul comes first in the pipeline, before vmul. Until we have a full > instruction scheduler, it's better to have vmul prioritized to maximize > bundle size. > >

Re: [Mesa-dev] [PATCH 2/2] panfrost/midgard: Preview for data hazards

2019-03-01 Thread Tomeu Vizoso
Cannot really review this myself, but: Tested-by: Tomeu Vizoso Thanks! On Wed, 27 Feb 2019 at 06:49, Alyssa Rosenzweig wrote: > > If a selected unit causes a data hazard, the whole block gets cut short. > So, we preview for data hazards _while_ selecting units. > > Signed-off-by: Alyssa

Re: [Mesa-dev] [PATCH 0/5] RadeonSI: Displayable DCC for Ravens

2019-03-01 Thread Alex Deucher
On Fri, Mar 1, 2019 at 10:11 AM Mike Lothian wrote: > > Hi > > What do you mean by kernel driver version? It doesn't seem to match up > with a kernel version or a DC Version It's not the DC version or the kernel version. There is a drm interface to get the drm driver version so that userspace

Re: [Mesa-dev] [PATCH 0/5] RadeonSI: Displayable DCC for Ravens

2019-03-01 Thread Mike Lothian
Thanks, I notice your 5.2-wip is version 3.30.0, so I'll wait until it's updated before testing Cheers Mike On Fri, 1 Mar 2019 at 15:17, Alex Deucher wrote: > > On Fri, Mar 1, 2019 at 10:11 AM Mike Lothian wrote: > > > > Hi > > > > What do you mean by kernel driver version? It doesn't seem to

Re: [Mesa-dev] [PATCH] gallium/util: Fix off-by-one in box intersection

2019-03-01 Thread Eric Anholt
Boris Brezillon writes: > From: Daniel Stone > > pipe_boxes are x/y + width/height, rather than x0/y0 -> x1/y1. This > means that (x+width) is not included in the box. > > The box intersection check was seemingly written for inclusive regions, > and would falsely assert that adjacent boxes

[Mesa-dev] [Bug 109532] ir_variable has maximum access out of bounds -- but it's not out of bounds

2019-03-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109532 --- Comment #51 from asimiklit --- We have one more answer from Piers Daniell: "We discussed this in the OpenGL/ES working group meeting and agreed that eliminating unused elements from the interface block array is not desirable. There

Re: [Mesa-dev] [PATCH 0/5] RadeonSI: Displayable DCC for Ravens

2019-03-01 Thread Mike Lothian
Hi What do you mean by kernel driver version? It doesn't seem to match up with a kernel version or a DC Version Cheers Mike On Thu, 28 Feb 2019 at 21:20, Marek Olšák wrote: > > Hi, > > This series enables DCC for scanout on Ravens. > > It requires kernel driver version >= 3.31.0 and my