Re: [Mesa-dev] [PATCH] i965: Always use Y-tiled buffers on SKL+

2016-04-20 Thread Pohjolainen, Topi
On Thu, Apr 21, 2016 at 08:03:02AM +0300, Pohjolainen, Topi wrote: > On Wed, Apr 20, 2016 at 09:49:02PM -0700, Ben Widawsky wrote: > > From: Ben Widawsky > > > > Starting with Skylake, the display engine is capable of scanning out from > > Y-tiled buffers. As such,

Re: [Mesa-dev] [PATCH] i965: Always use Y-tiled buffers on SKL+

2016-04-20 Thread Kenneth Graunke
On Wednesday, April 20, 2016 9:49:02 PM PDT Ben Widawsky wrote: > From: Ben Widawsky > > Starting with Skylake, the display engine is capable of scanning out from > Y-tiled buffers. As such, we can and should use Y-tiling for better efficiency. > This also has the

Re: [Mesa-dev] [PATCH] i965: Always use Y-tiled buffers on SKL+

2016-04-20 Thread Pohjolainen, Topi
On Wed, Apr 20, 2016 at 09:49:02PM -0700, Ben Widawsky wrote: > From: Ben Widawsky > > Starting with Skylake, the display engine is capable of scanning out from > Y-tiled buffers. As such, we can and should use Y-tiling for better > efficiency. > This also has the

Re: [Mesa-dev] i965: Support for gen8/9 blorp

2016-04-20 Thread Kenneth Graunke
On Saturday, April 16, 2016 4:42:28 PM PDT Topi Pohjolainen wrote: > This series adds blorp pipeline upload support for gen8 and gen9, > switches over to blorp blits (except for 2X and 16X msaa which don't > have support in blorp yet) and finally re-introduces blorp clears > for gen6-9. This makes

[Mesa-dev] [PATCH] i965: Always use Y-tiled buffers on SKL+

2016-04-20 Thread Ben Widawsky
From: Ben Widawsky Starting with Skylake, the display engine is capable of scanning out from Y-tiled buffers. As such, we can and should use Y-tiling for better efficiency. This also has the added benefit of being able to fast clear the winsys buffer. Note that the

Re: [Mesa-dev] [PATCH 24/40] i965/meta: Expose fast clear rectangle calculation

2016-04-20 Thread Kenneth Graunke
On Thursday, April 21, 2016 7:14:58 AM PDT Pohjolainen, Topi wrote: > On Wed, Apr 20, 2016 at 09:06:57PM -0700, Kenneth Graunke wrote: > > On Saturday, April 16, 2016 4:42:52 PM PDT Topi Pohjolainen wrote: > > > Signed-off-by: Topi Pohjolainen > > > --- > > >

Re: [Mesa-dev] [PATCH 24/40] i965/meta: Expose fast clear rectangle calculation

2016-04-20 Thread Pohjolainen, Topi
On Wed, Apr 20, 2016 at 09:06:57PM -0700, Kenneth Graunke wrote: > On Saturday, April 16, 2016 4:42:52 PM PDT Topi Pohjolainen wrote: > > Signed-off-by: Topi Pohjolainen > > --- > > src/mesa/drivers/dri/i965/brw_meta_fast_clear.c | 44 + > +--- > >

Re: [Mesa-dev] [PATCH 24/40] i965/meta: Expose fast clear rectangle calculation

2016-04-20 Thread Kenneth Graunke
On Saturday, April 16, 2016 4:42:52 PM PDT Topi Pohjolainen wrote: > Signed-off-by: Topi Pohjolainen > --- > src/mesa/drivers/dri/i965/brw_meta_fast_clear.c | 44 + +--- > src/mesa/drivers/dri/i965/brw_meta_util.h | 8 + > 2 files

Re: [Mesa-dev] Mesa (master): 29 new commits

2016-04-20 Thread Michel Dänzer
On 21.04.2016 02:42, Marek Olšák wrote: > On Thu, Apr 14, 2016 at 9:29 AM, Michel Dänzer wrote: >> On 14.04.2016 11:37, Michel Dänzer wrote: >>> On 12.04.2016 21:33, Marek =?UNKNOWN?B?T2zFocOhaw==?= wrote: URL:

[Mesa-dev] [PATCH 2/2] gallivm: add support for dynamic indexed texture size queries. (v2)

2016-04-20 Thread Dave Airlie
From: Dave Airlie This adds support for indirect samplers to the texture size query. v2: use first active sampler unit. Signed-off-by: Dave Airlie --- src/gallium/auxiliary/gallivm/lp_bld_sample.h | 2 ++

[Mesa-dev] [PATCH 1/2] [rfc] gallivm/llvmpipe dynamic samplers support. (v2)

2016-04-20 Thread Dave Airlie
From: Dave Airlie This is a first attempt at adding support for dynamic indexing of samplers to llvmpipe. This is needed for ARB_gpu_shader5 support. This uses the sampler function generator to generate functions for all samplers, then uses if statements to pick which one to

[Mesa-dev] llvmpipe dynamic samplers attempt 2

2016-04-20 Thread Dave Airlie
I've tried to use the exec mask to work out which sampler we should be using, this still fails the two tests concerned, maybe I'm doing something silly. Dave. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org

Re: [Mesa-dev] [PATCH] glsl: Relax GLSL 1.10 float suffix error to a warning.

2016-04-20 Thread Ian Romanick
On 04/20/2016 07:03 PM, Ian Romanick wrote: > On 04/20/2016 12:29 PM, Matt Turner wrote: >> Float suffixes are allowed in all subsequent GLSL specifications, and >> it's obvious what the user meant if they specify one. Accept it with a >> warning to avoid breaking applications, like Planeshift. >

Re: [Mesa-dev] [PATCH] glsl: Relax GLSL 1.10 float suffix error to a warning.

2016-04-20 Thread Ian Romanick
On 04/20/2016 12:29 PM, Matt Turner wrote: > Float suffixes are allowed in all subsequent GLSL specifications, and > it's obvious what the user meant if they specify one. Accept it with a > warning to avoid breaking applications, like Planeshift. Did we ever figure out if Planeshift still uses F

Re: [Mesa-dev] [PATCH] i965: Fix clear code for ignoring colormask for XRGB formats on Gen9+.

2016-04-20 Thread Ben Widawsky
On Wed, Apr 20, 2016 at 06:38:32PM -0700, Kenneth Graunke wrote: > In commit cda886a4851ab767fba40e8474d6fa8190347e4f, Neil made us stop > advertising RGBX formats on Gen9+, as the hardware apparently no longer > has working fast clear support for those formats. Instead, we just > fall back to

Re: [Mesa-dev] [PATCH] glsl: Relax GLSL 1.10 float suffix error to a warning.

2016-04-20 Thread Kenneth Graunke
On Wednesday, April 20, 2016 12:29:23 PM PDT Matt Turner wrote: > Float suffixes are allowed in all subsequent GLSL specifications, and > it's obvious what the user meant if they specify one. Accept it with a > warning to avoid breaking applications, like Planeshift. > --- >

Re: [Mesa-dev] [PATCH] mesa/st: add support for NIR as possible driver IR

2016-04-20 Thread Eric Anholt
Rob Clark writes: > diff --git a/src/mesa/state_tracker/st_glsl_to_nir.cpp > b/src/mesa/state_tracker/st_glsl_to_nir.cpp > new file mode 100644 > index 000..c15c537 > --- /dev/null > +++ b/src/mesa/state_tracker/st_glsl_to_nir.cpp > +static void >

[Mesa-dev] [PATCH] i965: Fix clear code for ignoring colormask for XRGB formats on Gen9+.

2016-04-20 Thread Kenneth Graunke
In commit cda886a4851ab767fba40e8474d6fa8190347e4f, Neil made us stop advertising RGBX formats on Gen9+, as the hardware apparently no longer has working fast clear support for those formats. Instead, we just fall back to RGBA formats, and use SCS to override alpha to 1.0. This is fine, but had

Re: [Mesa-dev] [PATCH] mesa/st: add nir pass for lowering builtin uniforms

2016-04-20 Thread Eric Anholt
Rob Clark writes: > From: Rob Clark > > Signed-off-by: Rob Clark > --- > src/mesa/Makefile.sources | 2 + > src/mesa/state_tracker/st_nir.h | 31 >

[Mesa-dev] draw_buffer_enum_to_bitmask returns wrong answer in certain cases

2016-04-20 Thread Gurchetan Singh
When the draw_buffer_enum_to_bitmask function is called while Mesa is in it's meta state, the wrong GLbitfield is returned sometimes for OpenGL ES contexts. This is because the _mesa_meta_begin function makes the ctx->API always equal to the desktop GL during the meta state. In the case of

Re: [Mesa-dev] [PATCH v2] st/dri: add 32-bit RGBX/RGBA formats

2016-04-20 Thread Eric Anholt
Rob Herring writes: > Add support for 32-bit RGBX/RGBA formats which are preferred for Android. > > Signed-off-by: Rob Herring > --- > v2: > - Rebase to current master after introduction of new > dri2_format_to_pipe_format function. Still gets my r-b.

[Mesa-dev] [PATCH] gallivm: fix bogus argument order to lp_build_sample_mipmap function

2016-04-20 Thread sroland
From: Roland Scheidegger Screwed up since 0753b135f6e83b171d8a1b08aea967374f3542bc. (Only an issue with different min/mag filters, and then only in some cases, which is probably why it went unnoticed for quite a while. The effect should have simply been nearest mip filter

Re: [Mesa-dev] [PATCH 2/2] radeonsi: Enable loading into CE RAM.

2016-04-20 Thread Nicolai Hähnle
On 20.04.2016 18:49, Bas Nieuwenhuizen wrote: We need to enable a bit in the CONTEXT_CONTROL packet for the loads to work. Signed-off-by: Bas Nieuwenhuizen --- src/gallium/drivers/radeonsi/si_descriptors.c | 6 ++ src/gallium/drivers/radeonsi/si_hw_context.c |

Re: [Mesa-dev] [PATCH 1/2] radeonsi: Use defines for CONTEXT_CONTROL instead of magic values.

2016-04-20 Thread Nicolai Hähnle
On 20.04.2016 18:49, Bas Nieuwenhuizen wrote: I have no source for the actual name of these fields, as these are not in the kernel headers. I hope they are clear though. Signed-off-by: Bas Nieuwenhuizen --- src/gallium/drivers/radeonsi/si_state.c | 4 ++--

[Mesa-dev] [PATCH v2] swr: fix memory leaks from vs/fs compilation

2016-04-20 Thread Tim Rowley
v2: varient -> variant --- src/gallium/drivers/swr/swr_shader.cpp | 41 -- src/gallium/drivers/swr/swr_state.cpp | 6 ++--- src/gallium/drivers/swr/swr_state.h| 17 -- 3 files changed, 41 insertions(+), 23 deletions(-) diff --git

Re: [Mesa-dev] [PATCH] swr: fix memory leaks from vs/fs compilation

2016-04-20 Thread Ilia Mirkin
On Wed, Apr 20, 2016 at 8:31 PM, Tim Rowley wrote: > --- > src/gallium/drivers/swr/swr_shader.cpp | 41 > -- > src/gallium/drivers/swr/swr_state.cpp | 6 ++--- > src/gallium/drivers/swr/swr_state.h| 17 -- > 3 files

[Mesa-dev] [PATCH] swr: fix memory leaks from vs/fs compilation

2016-04-20 Thread Tim Rowley
--- src/gallium/drivers/swr/swr_shader.cpp | 41 -- src/gallium/drivers/swr/swr_state.cpp | 6 ++--- src/gallium/drivers/swr/swr_state.h| 17 -- 3 files changed, 41 insertions(+), 23 deletions(-) diff --git

[Mesa-dev] [PATCH 2/2] radeonsi: Enable loading into CE RAM.

2016-04-20 Thread Bas Nieuwenhuizen
We need to enable a bit in the CONTEXT_CONTROL packet for the loads to work. Signed-off-by: Bas Nieuwenhuizen --- src/gallium/drivers/radeonsi/si_descriptors.c | 6 ++ src/gallium/drivers/radeonsi/si_hw_context.c | 5 + src/gallium/drivers/radeonsi/si_state.h

[Mesa-dev] [PATCH 1/2] radeonsi: Use defines for CONTEXT_CONTROL instead of magic values.

2016-04-20 Thread Bas Nieuwenhuizen
I have no source for the actual name of these fields, as these are not in the kernel headers. I hope they are clear though. Signed-off-by: Bas Nieuwenhuizen --- src/gallium/drivers/radeonsi/si_state.c | 4 ++-- src/gallium/drivers/radeonsi/sid.h | 3 +++ 2 files

[Mesa-dev] [Bug 95005] Unreal engine demos segfault after shader compilation error with OpenGL 4.3

2016-04-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=95005 --- Comment #7 from Ilia Mirkin --- (In reply to Christoph Haag from comment #6) > 32283 @2 glLinkProgram(program = 3071) > 32283: warning: link failed > 32283: warning: error: vertex shader output `out_TEXCOORD0' declared

[Mesa-dev] [PATCH v2] st/dri: add 32-bit RGBX/RGBA formats

2016-04-20 Thread Rob Herring
Add support for 32-bit RGBX/RGBA formats which are preferred for Android. Signed-off-by: Rob Herring --- v2: - Rebase to current master after introduction of new dri2_format_to_pipe_format function. src/gallium/state_trackers/dri/dri2.c | 6 ++

Re: [Mesa-dev] [PATCH] include/GL: fix the interop header for a --disable-glx build

2016-04-20 Thread Mircea Gherzan
On 20-Apr-16 6:59 PM, Sinclair Yeh wrote: Minor comment below. Either way: Reviewed-by: Sinclair Yeh On Wed, Apr 20, 2016 at 05:52:17PM +0200, Mircea Gherzan wrote: This header should not blindly include the GLX and should also conditionally define functions that use GLX

Re: [Mesa-dev] [PATCH 5/4] eglinfo: Restore eglTerminate

2016-04-20 Thread Alex Deucher
On Wed, Apr 20, 2016 at 4:55 PM, Adam Jackson wrote: > Signed-off-by: Adam Jackson Reviewed-by: Alex Deucher > --- > src/egl/opengl/eglinfo.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/src/egl/opengl/eglinfo.c

[Mesa-dev] [PATCH] i965/fs: Readd opt_drop_redundant_mov_to_flags().

2016-04-20 Thread Matt Turner
This reverts commit b449366587b5f3f64c6fb45fe22c39e4bc8a4309. I removed the pass thinking that it was now not useful, but that was not true. I believe I ran shader-db on HSW and saw no results, but HSW does not use the unlit centroid workaround code and as a result does not emit redundant

[Mesa-dev] [Bug 95005] Unreal engine demos segfault after shader compilation error with OpenGL 4.3

2016-04-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=95005 --- Comment #6 from Christoph Haag --- Just FYI: the patch from comment 1 helps for the (very) old unreal demos that can be downloaded from the unreal wiki, but the current unreal engine has a similar (something with

Re: [Mesa-dev] [PATCH 2/2] gk110/ir: use separate signed expressions for dst/src with IMUL32I

2016-04-20 Thread Samuel Pitoiset
On 04/20/2016 10:13 PM, Ilia Mirkin wrote: On Wed, Apr 20, 2016 at 3:14 PM, Samuel Pitoiset wrote: On 04/20/2016 07:47 PM, Ilia Mirkin wrote: Presumably you'd want to touch up the non-limm side of this as well? Although TBH, I can't really think of a time when

[Mesa-dev] [PATCH 5/4] eglinfo: Restore eglTerminate

2016-04-20 Thread Adam Jackson
Signed-off-by: Adam Jackson --- src/egl/opengl/eglinfo.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/egl/opengl/eglinfo.c b/src/egl/opengl/eglinfo.c index 75d9fe5..f7da372 100644 --- a/src/egl/opengl/eglinfo.c +++ b/src/egl/opengl/eglinfo.c @@ -178,6 +178,7 @@

[Mesa-dev] [Bug 95038] atomic_add and atomic_or cause a OpenCL crashes

2016-04-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=95038 ros...@gmail.com changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

Re: [Mesa-dev] [PATCH demos 3/4] eglinfo: Factor out a "probe one display" function

2016-04-20 Thread Eric Anholt
Adam Jackson writes: > Signed-off-by: Adam Jackson > --- > src/egl/opengl/eglinfo.c | 29 ++--- > 1 file changed, 18 insertions(+), 11 deletions(-) > > diff --git a/src/egl/opengl/eglinfo.c b/src/egl/opengl/eglinfo.c > index

Re: [Mesa-dev] [PATCH 4/7] gk110/ir: add emission for OP_SUEAU, OP_SUBFM and OP_SUCLAMP

2016-04-20 Thread Ilia Mirkin
On Wed, Apr 20, 2016 at 4:41 PM, Samuel Pitoiset wrote: > > > On 04/20/2016 10:35 PM, Ilia Mirkin wrote: >> >> On Wed, Apr 20, 2016 at 4:25 PM, Samuel Pitoiset >> wrote: >>> >>> Signed-off-by: Samuel Pitoiset >>>

Re: [Mesa-dev] [PATCH 4/7] gk110/ir: add emission for OP_SUEAU, OP_SUBFM and OP_SUCLAMP

2016-04-20 Thread Samuel Pitoiset
On 04/20/2016 10:35 PM, Ilia Mirkin wrote: On Wed, Apr 20, 2016 at 4:25 PM, Samuel Pitoiset wrote: Signed-off-by: Samuel Pitoiset --- .../drivers/nouveau/codegen/nv50_ir_emit_gk110.cpp | 87 ++ 1 file changed, 87

Re: [Mesa-dev] [PATCH 7/7] nvc0: expose GLSL version 420 on GK110

2016-04-20 Thread Ilia Mirkin
Reviewed-by: Ilia Mirkin Same comment re GK20A. On Wed, Apr 20, 2016 at 4:25 PM, Samuel Pitoiset wrote: > Signed-off-by: Samuel Pitoiset > --- > src/gallium/drivers/nouveau/nvc0/nvc0_screen.c | 2 +- > 1 file

Re: [Mesa-dev] [PATCH 6/7] nvc0: enable ARB_shader_image_load_store on GK110

2016-04-20 Thread Ilia Mirkin
Reviewed-by: Ilia Mirkin Might also want to see what happens on GK20A. Should Just Work (tm). On Wed, Apr 20, 2016 at 4:25 PM, Samuel Pitoiset wrote: > This exposes 8 images for all shader types. > > Signed-off-by: Samuel Pitoiset

Re: [Mesa-dev] [PATCH 5/7] gk110/ir: add emission for VSHL

2016-04-20 Thread Ilia Mirkin
Reviewed-by: Ilia Mirkin On Wed, Apr 20, 2016 at 4:25 PM, Samuel Pitoiset wrote: > Signed-off-by: Samuel Pitoiset > --- > .../drivers/nouveau/codegen/nv50_ir_emit_gk110.cpp | 58 > ++ > 1 file

Re: [Mesa-dev] [PATCH 4/7] gk110/ir: add emission for OP_SUEAU, OP_SUBFM and OP_SUCLAMP

2016-04-20 Thread Ilia Mirkin
On Wed, Apr 20, 2016 at 4:25 PM, Samuel Pitoiset wrote: > Signed-off-by: Samuel Pitoiset > --- > .../drivers/nouveau/codegen/nv50_ir_emit_gk110.cpp | 87 > ++ > 1 file changed, 87 insertions(+) > > diff --git

[Mesa-dev] [Bug 95038] atomic_add and atomic_or cause a OpenCL crashes

2016-04-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=95038 --- Comment #1 from Aaron Watry --- Are the atomic_add/atomic_or operations causing the crash operating against local or global memory? Last I checked, I think that atomics for r600g-based cards were only implemented in LLVM

[Mesa-dev] [PATCH] winsys/amdgpu: fix preamble IB size

2016-04-20 Thread Thomas Hindoe Paaboel Andersen
The missing break caused the IB size to be overwritten with the size of IB_CONST. This was introduced in: 7201230582e060aa2eb79c825d3188b437ef7bb8 --- src/gallium/winsys/amdgpu/drm/amdgpu_cs.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/winsys/amdgpu/drm/amdgpu_cs.c

Re: [Mesa-dev] [PATCH 3/7] gk110/ir: add emission for OP_SULDB and OP_SUSTx

2016-04-20 Thread Ilia Mirkin
On Wed, Apr 20, 2016 at 4:25 PM, Samuel Pitoiset wrote: > Signed-off-by: Samuel Pitoiset > --- > .../drivers/nouveau/codegen/nv50_ir_emit_gk110.cpp | 153 > + > 1 file changed, 153 insertions(+) > > diff --git

Re: [Mesa-dev] [PATCH 2/7] gk110/ir: add emission for OP_MADSP

2016-04-20 Thread Ilia Mirkin
Reviewed-by: Ilia Mirkin On Wed, Apr 20, 2016 at 4:25 PM, Samuel Pitoiset wrote: > Signed-off-by: Samuel Pitoiset > --- > .../drivers/nouveau/codegen/nv50_ir_emit_gk110.cpp | 23 > ++ > 1 file

Re: [Mesa-dev] [PATCH 1/7] gk110/ir: add emission for OP_PERMT

2016-04-20 Thread Ilia Mirkin
Reviewed-by: Ilia Mirkin On Wed, Apr 20, 2016 at 4:25 PM, Samuel Pitoiset wrote: > Signed-off-by: Samuel Pitoiset > --- > src/gallium/drivers/nouveau/codegen/nv50_ir_emit_gk110.cpp | 12 > 1 file changed,

[Mesa-dev] [PATCH 4/7] gk110/ir: add emission for OP_SUEAU, OP_SUBFM and OP_SUCLAMP

2016-04-20 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- .../drivers/nouveau/codegen/nv50_ir_emit_gk110.cpp | 87 ++ 1 file changed, 87 insertions(+) diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_emit_gk110.cpp

[Mesa-dev] [PATCH 1/7] gk110/ir: add emission for OP_PERMT

2016-04-20 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/nouveau/codegen/nv50_ir_emit_gk110.cpp | 12 1 file changed, 12 insertions(+) diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_emit_gk110.cpp

[Mesa-dev] [PATCH 7/7] nvc0: expose GLSL version 420 on GK110

2016-04-20 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/nouveau/nvc0/nvc0_screen.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/nouveau/nvc0/nvc0_screen.c b/src/gallium/drivers/nouveau/nvc0/nvc0_screen.c index f8d74d5..c017f4f

[Mesa-dev] [PATCH 3/7] gk110/ir: add emission for OP_SULDB and OP_SUSTx

2016-04-20 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- .../drivers/nouveau/codegen/nv50_ir_emit_gk110.cpp | 153 + 1 file changed, 153 insertions(+) diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_emit_gk110.cpp

[Mesa-dev] [PATCH 2/7] gk110/ir: add emission for OP_MADSP

2016-04-20 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- .../drivers/nouveau/codegen/nv50_ir_emit_gk110.cpp | 23 ++ 1 file changed, 23 insertions(+) diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_emit_gk110.cpp

[Mesa-dev] [PATCH 6/7] nvc0: enable ARB_shader_image_load_store on GK110

2016-04-20 Thread Samuel Pitoiset
This exposes 8 images for all shader types. Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/nouveau/nvc0/nvc0_screen.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/nouveau/nvc0/nvc0_screen.c

[Mesa-dev] [PATCH 0/7] nvc0: ARB_shader_image_load_store/size on GK110

2016-04-20 Thread Samuel Pitoiset
Hi, This series is based on the previous one for GK104. Between GK104 and GK110 only the ISA has changed. This adds code emission for all instructions that are needed to support surfaces/images. I have exactly the same passrate for both deqp and piglit as GK104. Please review, Thanks! Samuel

[Mesa-dev] [PATCH 5/7] gk110/ir: add emission for VSHL

2016-04-20 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- .../drivers/nouveau/codegen/nv50_ir_emit_gk110.cpp | 58 ++ 1 file changed, 58 insertions(+) diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_emit_gk110.cpp

Re: [Mesa-dev] [PATCH demos 4/4] eglinfo: Add EXT_platform_* awareness

2016-04-20 Thread Alex Deucher
On Wed, Apr 20, 2016 at 4:10 PM, Adam Jackson wrote: > Signed-off-by: Adam Jackson Series is: Reviewed-by: Alex Deucher > --- > src/egl/opengl/eglinfo.c | 41 +++-- > 1 file changed, 35

Re: [Mesa-dev] [PATCH] gk110/ir: do not overwrite def value with zero for EXCH ops

2016-04-20 Thread Ilia Mirkin
Reviewed-by: Ilia Mirkin On Wed, Apr 20, 2016 at 1:47 PM, Samuel Pitoiset wrote: > This is only valid for other atomic operations (including CAS). This > fixes an invalid opcode error from dmesg. While we are it, make sure > to initialize global

Re: [Mesa-dev] [PATCH 2/4] st/mesa: check return value of begin/end_query

2016-04-20 Thread Samuel Pitoiset
On 04/20/2016 09:37 PM, Nicolai Hähnle wrote: On 20.04.2016 11:13, Samuel Pitoiset wrote: On 04/20/2016 05:43 PM, Nicolai Hähnle wrote: From: Nicolai Hähnle They can only indicate out of memory conditions, since the other error conditions are caught earlier. ---

Re: [Mesa-dev] [PATCH 2/2] gk110/ir: use separate signed expressions for dst/src with IMUL32I

2016-04-20 Thread Ilia Mirkin
On Wed, Apr 20, 2016 at 3:14 PM, Samuel Pitoiset wrote: > > > On 04/20/2016 07:47 PM, Ilia Mirkin wrote: >> >> Presumably you'd want to touch up the non-limm side of this as well? >> Although TBH, I can't really think of a time when it'd matter. I think >> you're pretty

[Mesa-dev] [PATCH demos 3/4] eglinfo: Factor out a "probe one display" function

2016-04-20 Thread Adam Jackson
Signed-off-by: Adam Jackson --- src/egl/opengl/eglinfo.c | 29 ++--- 1 file changed, 18 insertions(+), 11 deletions(-) diff --git a/src/egl/opengl/eglinfo.c b/src/egl/opengl/eglinfo.c index b044eaa..875e407 100644 --- a/src/egl/opengl/eglinfo.c +++

[Mesa-dev] [PATCH demos 2/4] eglinfo: Print client extensions first

2016-04-20 Thread Adam Jackson
These are independent of the display, and I want to iterate over those. Signed-off-by: Adam Jackson --- src/egl/opengl/eglinfo.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/egl/opengl/eglinfo.c b/src/egl/opengl/eglinfo.c index ca22df2..b044eaa

[Mesa-dev] [PATCH demos 4/4] eglinfo: Add EXT_platform_* awareness

2016-04-20 Thread Adam Jackson
Signed-off-by: Adam Jackson --- src/egl/opengl/eglinfo.c | 41 +++-- 1 file changed, 35 insertions(+), 6 deletions(-) diff --git a/src/egl/opengl/eglinfo.c b/src/egl/opengl/eglinfo.c index 875e407..75d9fe5 100644 ---

[Mesa-dev] [PATCH demos 1/4] eglinfo: Note when an EGLConfig is streams-compatible

2016-04-20 Thread Adam Jackson
Signed-off-by: Adam Jackson --- src/egl/opengl/eglinfo.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/egl/opengl/eglinfo.c b/src/egl/opengl/eglinfo.c index 1f79fef..ca22df2 100644 --- a/src/egl/opengl/eglinfo.c +++ b/src/egl/opengl/eglinfo.c @@ -93,6 +93,8 @@

Re: [Mesa-dev] [PATCH] glsl: Relax GLSL 1.10 float suffix error to a warning.

2016-04-20 Thread Matt Turner
On Wed, Apr 20, 2016 at 12:48 PM, Lars Hamre wrote: > I am fine with this, it would be nice if we could modify the following > piglit tests to pass when a warning is emitted: >

Re: [Mesa-dev] [PATCH] glsl: Relax GLSL 1.10 float suffix error to a warning.

2016-04-20 Thread Roland Scheidegger
Am 20.04.2016 um 21:29 schrieb Matt Turner: > Float suffixes are allowed in all subsequent GLSL specifications, and > it's obvious what the user meant if they specify one. Accept it with a > warning to avoid breaking applications, like Planeshift. > --- > src/compiler/glsl/glsl_lexer.ll | 4 ++--

Re: [Mesa-dev] [PATCH] glsl: Relax GLSL 1.10 float suffix error to a warning.

2016-04-20 Thread Lars Hamre
I am fine with this, it would be nice if we could modify the following piglit tests to pass when a warning is emitted: https://cgit.freedesktop.org/piglit/tree/tests/spec/glsl-1.10/compiler/literals/invalid-float-suffix-capital-f.vert

Re: [Mesa-dev] [PATCH 2/4] st/mesa: check return value of begin/end_query

2016-04-20 Thread Nicolai Hähnle
On 20.04.2016 11:13, Samuel Pitoiset wrote: On 04/20/2016 05:43 PM, Nicolai Hähnle wrote: From: Nicolai Hähnle They can only indicate out of memory conditions, since the other error conditions are caught earlier. --- src/mesa/state_tracker/st_cb_queryobj.c | 55

[Mesa-dev] [PATCH] glsl: Relax GLSL 1.10 float suffix error to a warning.

2016-04-20 Thread Matt Turner
Float suffixes are allowed in all subsequent GLSL specifications, and it's obvious what the user meant if they specify one. Accept it with a warning to avoid breaking applications, like Planeshift. --- src/compiler/glsl/glsl_lexer.ll | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff

Re: [Mesa-dev] [PATCH 1/2] winsys/amdgpu: adjust IB size based on buffer wait time

2016-04-20 Thread Marek Olšák
On Wed, Apr 20, 2016 at 8:18 PM, Grigori Goronzy wrote: > On 2016-04-20 02:20, Nicolai Hähnle wrote: >> >> This is just a slight massaging of the patch you sent previously. What >> happened to the discussion we had about how to do this properly? >> > > This already provides

[Mesa-dev] [Bug 95036] make check egl-symbols-check regression

2016-04-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=95036 Vinson Lee changed: What|Removed |Added Keywords||bisected

Re: [Mesa-dev] [PATCH 2/2] gk110/ir: use separate signed expressions for dst/src with IMUL32I

2016-04-20 Thread Samuel Pitoiset
On 04/20/2016 07:47 PM, Ilia Mirkin wrote: Presumably you'd want to touch up the non-limm side of this as well? Although TBH, I can't really think of a time when it'd matter. I think you're pretty much guaranteed to have stype == dtype for mul's. Maybe I'm wrong? Well, the non-limm part is

Re: [Mesa-dev] [PATCH v2 4/4] i965: Properly handle integer types in opt_vector_float().

2016-04-20 Thread Matt Turner
On Tue, Apr 19, 2016 at 12:44 PM, Matt Turner wrote: > On Mon, Apr 18, 2016 at 11:52 PM, Kenneth Graunke > wrote: >> Previously, opt_vector_float() always interpreted MOV sources as >> floating point, and always created a MOV with a F-type destination.

Re: [Mesa-dev] [PATCH] gk110/ir: do not overwrite def value with zero for EXCH ops

2016-04-20 Thread Samuel Pitoiset
On 04/20/2016 07:49 PM, Ilia Mirkin wrote: The SM20/SM30 logic does this for exch || cas. Are you *sure* this shouldn't be the same? It's pretty silly to do a CAS without a dst, but it's definitely possible (through DCE). Yeah, I'm sure. It's definitely not the same logic between gk104 and

[Mesa-dev] [Bug 95038] atomic_add and atomic_or cause a OpenCL crashes

2016-04-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=95038 Bug ID: 95038 Summary: atomic_add and atomic_or cause a OpenCL crashes Product: Mesa Version: 11.2 Hardware: x86-64 (AMD64) OS: Linux (All) Status: NEW

[Mesa-dev] [PATCH] gallium/radeon: implement randomized SDMA testing

2016-04-20 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/r600/r600_pipe.c | 3 + src/gallium/drivers/radeon/Makefile.sources | 1 + src/gallium/drivers/radeon/r600_pipe_common.c | 2 + src/gallium/drivers/radeon/r600_pipe_common.h | 5 +

Re: [Mesa-dev] [PATCH 00/18] anv: Switch to a new emit macro

2016-04-20 Thread Jason Ekstrand
On Wed, Apr 20, 2016 at 11:38 AM, Kristian Høgsberg wrote: > On Mon, Apr 18, 2016 at 5:10 PM, Jason Ekstrand > wrote: > > The first patch in this series adds a short style guide for the Vulkan > > driver. The rest adds a new emit macro and updates the

Re: [Mesa-dev] [PATCH 00/18] anv: Switch to a new emit macro

2016-04-20 Thread Kristian Høgsberg
On Mon, Apr 18, 2016 at 5:10 PM, Jason Ekstrand wrote: > The first patch in this series adds a short style guide for the Vulkan > driver. The rest adds a new emit macro and updates the entire driver to > use it and, while we're there, makes the style more consistent. > >

[Mesa-dev] [Bug 95036] make check egl-symbols-check regression

2016-04-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=95036 Bug ID: 95036 Summary: make check egl-symbols-check regression Product: Mesa Version: git Hardware: x86-64 (AMD64) OS: Linux (All) Status: NEW Keywords:

Re: [Mesa-dev] [PATCH 1/2] winsys/amdgpu: adjust IB size based on buffer wait time

2016-04-20 Thread Grigori Goronzy
On 2016-04-20 02:20, Nicolai Hähnle wrote: This is just a slight massaging of the patch you sent previously. What happened to the discussion we had about how to do this properly? This already provides good value as-is and it is (IMHO) reasonably clean, so why not include it for the time

[Mesa-dev] [Bug 94291] llvmpipe tests fail if built on skylake i7-6700k

2016-04-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=94291 --- Comment #10 from Timo Aaltonen --- Oh, I didn't know they were subvariants :) I've dropped them from our llvm-3.8 for now at least.. -- You are receiving this mail because: You are the assignee for the bug. You are

Re: [Mesa-dev] [PATCH] anv: fix build without Wayland platform

2016-04-20 Thread Jason Ekstrand
Pushed. Thanks! On Sat, Apr 16, 2016 at 1:48 PM, Marcin Ślusarz wrote: > > --- > src/intel/vulkan/Makefile.am | 9 + > src/intel/vulkan/anv_private.h | 3 --- > 2 files changed, 5 insertions(+), 7 deletions(-) > > diff --git a/src/intel/vulkan/Makefile.am

Re: [Mesa-dev] [PATCH] anv: fix building on i686 with -mcpu=generic

2016-04-20 Thread Jason Ekstrand
Pushed! On Sat, Apr 16, 2016 at 9:52 PM, Jason Ekstrand wrote: > Reviewed-by: Jason Ekstrand > On Apr 16, 2016 12:50 PM, "Laurent Carlier" wrote: > >> mcpu=generic doesn't enable sse2, and anvil definitly needs it >> --- >>

Re: [Mesa-dev] [PATCH] gk110/ir: do not overwrite def value with zero for EXCH ops

2016-04-20 Thread Ilia Mirkin
The SM20/SM30 logic does this for exch || cas. Are you *sure* this shouldn't be the same? It's pretty silly to do a CAS without a dst, but it's definitely possible (through DCE). On Wed, Apr 20, 2016 at 1:47 PM, Samuel Pitoiset wrote: > This is only valid for other

[Mesa-dev] [PATCH] gk110/ir: do not overwrite def value with zero for EXCH ops

2016-04-20 Thread Samuel Pitoiset
This is only valid for other atomic operations (including CAS). This fixes an invalid opcode error from dmesg. While we are it, make sure to initialize global addr to 0 for other atomic operations. Signed-off-by: Samuel Pitoiset Cc: "11.1 11.2"

Re: [Mesa-dev] [PATCH 2/2] gk110/ir: use separate signed expressions for dst/src with IMUL32I

2016-04-20 Thread Ilia Mirkin
Presumably you'd want to touch up the non-limm side of this as well? Although TBH, I can't really think of a time when it'd matter. I think you're pretty much guaranteed to have stype == dtype for mul's. Maybe I'm wrong? -ilia On Wed, Apr 20, 2016 at 1:06 PM, Samuel Pitoiset

Re: [Mesa-dev] [PATCH 1/2] gk110/ir: make use of IMUL32I for all immediates

2016-04-20 Thread Ilia Mirkin
Reviewed-by: Ilia Mirkin On Wed, Apr 20, 2016 at 1:06 PM, Samuel Pitoiset wrote: > Signed-off-by: Samuel Pitoiset > Cc: "11.1 11.2" > --- >

Re: [Mesa-dev] Mesa (master): 29 new commits

2016-04-20 Thread Marek Olšák
On Thu, Apr 14, 2016 at 9:29 AM, Michel Dänzer wrote: > On 14.04.2016 11:37, Michel Dänzer wrote: >> On 12.04.2016 21:33, Marek =?UNKNOWN?B?T2zFocOhaw==?= wrote: >>> >>> URL: >>> http://cgit.freedesktop.org/mesa/mesa/commit/?id=5a4b74d1ba2c156766a7a5dbfef099c7db5d6694 >>>

Re: [Mesa-dev] [PATCH 4/4] radeon: handle query buffer allocation and mapping failures

2016-04-20 Thread Marek Olšák
For patches 1,3,4: Reviewed-by: Marek Olšák Marek On Wed, Apr 20, 2016 at 5:43 PM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=94984 > --- >

[Mesa-dev] [Bug 95035] Gallium OSMesa driver is far from being thread-safe

2016-04-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=95035 Bug ID: 95035 Summary: Gallium OSMesa driver is far from being thread-safe Product: Mesa Version: 11.2 Hardware: Other OS: All Status: NEW Severity:

[Mesa-dev] [PATCH 2/2] gk110/ir: use separate signed expressions for dst/src with IMUL32I

2016-04-20 Thread Samuel Pitoiset
Forcing the destination type to be signed when the source is signed is not totally correct. Signed-off-by: Samuel Pitoiset Cc: "11.1 11.2" --- src/gallium/drivers/nouveau/codegen/nv50_ir_emit_gk110.cpp | 4 +++- 1 file changed, 3

[Mesa-dev] [PATCH 1/2] gk110/ir: make use of IMUL32I for all immediates

2016-04-20 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset Cc: "11.1 11.2" --- src/gallium/drivers/nouveau/codegen/nv50_ir_emit_gk110.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [Mesa-dev] [PATCH] include/GL: fix the interop header for a --disable-glx build

2016-04-20 Thread Sinclair Yeh
Minor comment below. Either way: Reviewed-by: Sinclair Yeh On Wed, Apr 20, 2016 at 05:52:17PM +0200, Mircea Gherzan wrote: > This header should not blindly include the GLX and should also > conditionally define functions that use GLX parameters. The > MESA_EGL_NO_X11_HEADERS

Re: [Mesa-dev] [PATCH] include/GL: fix the interop header for a --disable-glx build

2016-04-20 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Wed, Apr 20, 2016 at 5:52 PM, Mircea Gherzan wrote: > This header should not blindly include the GLX and should also > conditionally define functions that use GLX parameters. The > MESA_EGL_NO_X11_HEADERS macro is

Re: [Mesa-dev] [PATCH 0/3] Support for Android RGBX/RGBA formats

2016-04-20 Thread Eric Anholt
Rob Herring writes: > The RGBX/RGBA pixel formats used in the Android EGL don't get configs > created due to the missing formats in the DRI state tracker. This series > adds the necessary formats for configs and DRI images. Support in GBM is > also added as it will be needed

Re: [Mesa-dev] [PATCH 2/4] st/mesa: check return value of begin/end_query

2016-04-20 Thread Samuel Pitoiset
On 04/20/2016 05:43 PM, Nicolai Hähnle wrote: From: Nicolai Hähnle They can only indicate out of memory conditions, since the other error conditions are caught earlier. --- src/mesa/state_tracker/st_cb_queryobj.c | 55 - 1 file

Re: [Mesa-dev] [PATCH 1/4] gallium: add bool return to pipe_context::end_query

2016-04-20 Thread Samuel Pitoiset
Yeah, this makes sense. Reviewed-by: Samuel Pitoiset On 04/20/2016 05:43 PM, Nicolai Hähnle wrote: From: Nicolai Hähnle Even when begin_query succeeds, there can still be failures in query handling. For example for radeon, additional

Re: [Mesa-dev] [PATCH] st/mesa: Use correct size for compute CAPs.

2016-04-20 Thread Samuel Pitoiset
Reviewed-by: Samuel Pitoiset On 04/20/2016 03:35 PM, Bas Nieuwenhuizen wrote: Some CAPs are stored as 64-bit value while Mesa stores the related constant as 32-bit value. Signed-off-by: Bas Nieuwenhuizen ---

  1   2   >