Re: [Mesa-dev] Patchwork review process (efficiency) questions

2016-06-03 Thread Timothy Arceri
On Fri, 2016-06-03 at 13:12 +0200, ⚛ wrote: > Hello > > Situation: Looking at the content displayed by the web browser for > URL > http://patchwork.freedesktop.org/project/mesa/series and sub-pages > accessible via the links. > > The following questions are troubling me: > > - How does a patch s

Re: [Mesa-dev] [PATCH v1.1 2/2] clover: fix getting scalar args api size

2016-06-03 Thread Francisco Jerez
Serge Martin writes: > This fix getting the size of a struct arg. vec3 types still work ok. > Only buit-in args need to have power of two alignment, getTypeAllocSize > reports the correct size. > Is there any guarantee that the alloc size of the type will match what the CL API expects? (which is

Re: [Mesa-dev] [PATCH 1/2] clover: assert struct argument is compiled usably

2016-06-03 Thread Francisco Jerez
Serge Martin writes: > From: Vedran Miletić > > Make sure that a struct argument did not get compiled into a pointer > type with the byval attribute. If we try to handle the pointer with > byval, we end up with the pointer size instead of the struct size. > Ugh, is that a bug in the code below?

Re: [Mesa-dev] [PATCH v3] clover: Update OpenCL version string to match OpenGL

2016-06-03 Thread Emil Velikov
On 3 June 2016 at 17:58, Vedran Miletić wrote: > On 06/03/2016 06:32 PM, Emil Velikov wrote: >> >> Not sure who much the MESA>Mesa change matters, so I'll leave that to >> others. >> > > Could break some applications that check for it. I doubt many do, and if > they do I would suggest to make the

Re: [Mesa-dev] CI job for Android builds

2016-06-03 Thread Emil Velikov
On 4 June 2016 at 01:33, Rob Herring wrote: > On Fri, Jun 3, 2016 at 7:19 PM, Emil Velikov wrote: >> On 17 May 2016 at 23:29, Rob Herring wrote: >>> On Tue, May 17, 2016 at 5:21 PM, Rob Clark wrote: On Tue, May 17, 2016 at 6:14 PM, Jose Fonseca wrote: > On 17/05/16 22:43, Rob Clark wr

Re: [Mesa-dev] [PATCH 00/10] R600: Cache flush fixes and cleanup v2

2016-06-03 Thread Dave Airlie
On 4 Jun 2016 9:28 AM, "Dieter Nützel" wrote: > > Am 01.06.2016 20:57, schrieb Marek Olšák: >> >> Hi, >> >> This is version 2 of the previous series. This time it's been tested!! >> >> Tested cards: >> - RV670 >> - RV730 >> - EG/REDWOOD >> - CAYMAN > > > [-] > > >> More testing may be needed, espe

Re: [Mesa-dev] CI job for Android builds

2016-06-03 Thread Rob Herring
On Fri, Jun 3, 2016 at 7:19 PM, Emil Velikov wrote: > On 17 May 2016 at 23:29, Rob Herring wrote: >> On Tue, May 17, 2016 at 5:21 PM, Rob Clark wrote: >>> On Tue, May 17, 2016 at 6:14 PM, Jose Fonseca wrote: On 17/05/16 22:43, Rob Clark wrote: > > On Tue, May 17, 2016 at 5:13 PM, R

Re: [Mesa-dev] CI job for Android builds

2016-06-03 Thread Emil Velikov
On 17 May 2016 at 23:29, Rob Herring wrote: > On Tue, May 17, 2016 at 5:21 PM, Rob Clark wrote: >> On Tue, May 17, 2016 at 6:14 PM, Jose Fonseca wrote: >>> On 17/05/16 22:43, Rob Clark wrote: On Tue, May 17, 2016 at 5:13 PM, Rob Herring wrote: > > I'm in the process of se

[Mesa-dev] [PATCH] egl: android: don't add the image loader extension for !render_node

2016-06-03 Thread Emil Velikov
With earlier commit we introduced support for render_node devices, which was couples with the use of the image loader extension. As the work was inspired by egl/wayland we (erroneously) added the extension for the !render_node path as well. That works for wayland, as the implementations of the DR

Re: [Mesa-dev] [PATCH] anv: add the X related and Wayland CFLAGS to VULKAN_ENTRYPOINT_CPPFLAGS

2016-06-03 Thread Tobias Klausmann
On 04.06.2016 01:22, Emil Velikov wrote: From: Emil Velikov Otherwise we might fail to find the headers in some scenarios. Cc: Tobias Klausmann Reported-by: Tobias Klausmann Signed-off-by: Emil Velikov --- src/intel/vulkan/Makefile.am | 2 ++ 1 file changed, 2 insertions(+) diff --git

Re: [Mesa-dev] [PATCH] anv/copy: Account for the anv_surface.offset when creating a blit2d_surf

2016-06-03 Thread Nanley Chery
On Thu, Jun 02, 2016 at 05:05:09PM -0700, Nanley Chery wrote: > On Thu, Jun 02, 2016 at 04:27:26PM -0700, Jason Ekstrand wrote: > > This was causing problems if the user tried to copy to/from the stencil > > portion of a combined depth/stencil image. > > > > Signed-off-by: Jason Ekstrand > > Cc:

Re: [Mesa-dev] [PATCH 00/10] R600: Cache flush fixes and cleanup v2

2016-06-03 Thread Dieter Nützel
Am 01.06.2016 20:57, schrieb Marek Olšák: Hi, This is version 2 of the previous series. This time it's been tested!! Tested cards: - RV670 - RV730 - EG/REDWOOD - CAYMAN [-] More testing may be needed, especially testing on GPUs not listed above. Tested-by: Dieter Nützel NI/Turks XT (Rad

[Mesa-dev] [PATCH] anv: add the X related and Wayland CFLAGS to VULKAN_ENTRYPOINT_CPPFLAGS

2016-06-03 Thread Emil Velikov
From: Emil Velikov Otherwise we might fail to find the headers in some scenarios. Cc: Tobias Klausmann Reported-by: Tobias Klausmann Signed-off-by: Emil Velikov --- src/intel/vulkan/Makefile.am | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/intel/vulkan/Makefile.am b/src/intel/vul

[Mesa-dev] [PATCH] glsl: initialise pointer to NULL

2016-06-03 Thread Jakob Sinclair
Could cause issues if you tried to read from an uninitialised pointer. This just initalises the pointer to null to avoid that being a problem. Discovered by Coverity. CID: 1343616 Signed-off-by: Jakob Sinclair --- src/compiler/glsl/glsl_parser_extras.cpp | 1 + 1 file changed, 1 insertion(+) d

Re: [Mesa-dev] [PATCH] anv: supply necessary headers to the generator

2016-06-03 Thread Tobias Klausmann
On 04.06.2016 00:54, Emil Velikov wrote: On 3 June 2016 at 23:03, Tobias Klausmann wrote: With header in uncommen (non-system findable places) the build fails, use the already found places to include those headers. Are you sure about this ? What exactly is your build setup/config (in-tree/ou

Re: [Mesa-dev] [PATCH] anv: supply necessary headers to the generator

2016-06-03 Thread Emil Velikov
On 3 June 2016 at 23:03, Tobias Klausmann wrote: > With header in uncommen (non-system findable places) the build fails, use > the already found places to include those headers. > Are you sure about this ? What exactly is your build setup/config (in-tree/out-of-tree) what error message are you get

Re: [Mesa-dev] [PATCH 2/6] nir/info: Get rid of uses_interp_var_at_offset

2016-06-03 Thread Kenneth Graunke
On Wednesday, June 1, 2016 8:56:54 PM PDT Jason Ekstrand wrote: > We were using this briefly in the i965 driver to trigger recompiles but we > haven't been using it since we switched to the NIR y-transform lowering > pass. > > Signed-off-by: Jason Ekstrand > --- > src/compiler/glsl/glsl_to_nir.c

[Mesa-dev] [Bug 95346] Stellaris - Black/super dark planets

2016-06-03 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=95346 Grazvydas Ignotas changed: What|Removed |Added CC||nota...@gmail.com --- Comment #10 fr

[Mesa-dev] [PATCH] anv: supply necessary headers to the generator

2016-06-03 Thread Tobias Klausmann
With header in uncommen (non-system findable places) the build fails, use the already found places to include those headers. Signed-off-by: Tobias Klausmann --- src/intel/vulkan/Makefile.am | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/intel/vulkan/Makefile.am b/s

Re: [Mesa-dev] [PATCH] glsl: geom shader max_vertices layout must match.

2016-06-03 Thread Dave Airlie
On 4 June 2016 at 03:39, Alejandro Piñeiro wrote: > On 03/06/16 02:46, Dave Airlie wrote: >> From: Dave Airlie >> >> "all geometry shader output vertex count declarations in a >> program must declare the same count." > > This spec quote lacks context. As far as I see it comes from GLSL 4.5 > spec

Re: [Mesa-dev] [PATCH] Revert "i965/fs: Allow scalar source regions on SNB math instructions."

2016-06-03 Thread Matt Turner
Acked-by: Matt Turner At least I wasn't going crazy :) ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH] Revert "i965/fs: Allow scalar source regions on SNB math instructions."

2016-06-03 Thread Francisco Jerez
This reverts commit c1107cec44ab030c7fcc97c67baa12df1cc9d7b5. Apparently the hardware spec text I quoted in the commit message was outright lying about scalar source math being supported on SNB, the hardware seems to load 32 contiguous bits of data for each channel regardless of the regioning mode.

Re: [Mesa-dev] [PATCH v2] i965: Fix point size with tessellation/geometry shaders in GLES.

2016-06-03 Thread Ilia Mirkin
On Fri, Jun 3, 2016 at 4:08 AM, Kenneth Graunke wrote: > Our previous code worked for desktop GL, and ES without geometry or > tessellation shaders. But those features require fancier point size > handling. Fortunately, we can use one rule for all APIs. > > Fixes a number of dEQP tests with EXT_

Re: [Mesa-dev] [PATCH] radeonsi: fix images with level > 0

2016-06-03 Thread Bas Nieuwenhuizen
Reviewed-by: Bas Nieuwenhuizen On Fri, Jun 3, 2016 at 7:20 PM, Marek Olšák wrote: > From: Marek Olšák > > This should fix spec@arb_shader_image_load_store@level. > > Broken by: > Commit: 95c5bbae66af3ca1f805d94f6fe8d8e4ba2c9c43 > radeonsi: set some image descriptor fields at bind time >

[Mesa-dev] [Bug 96358] SSO: wrong interface validation between GS and VS (regresion due to latest gles 3.1)

2016-06-03 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=96358 --- Comment #2 from Ilia Mirkin --- (In reply to gregory.hainaut from comment #1) > Note I just took the commit from a git blame. It seems the code replace an > older function. But I don't know if the older function was broken too. The previous

[Mesa-dev] [Bug 96358] SSO: wrong interface validation between GS and VS (regresion due to latest gles 3.1)

2016-06-03 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=96358 gregory.hain...@gmail.com changed: What|Removed |Added CC||i...@freedesktop.org --- Comm

[Mesa-dev] [Bug 96358] SSO: wrong interface validation between GS and VS (regresion due to latest gles 3.1)

2016-06-03 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=96358 Bug ID: 96358 Summary: SSO: wrong interface validation between GS and VS (regresion due to latest gles 3.1) Product: Mesa Version: git Hardware: Other OS: A

[Mesa-dev] [Bug 95529] [regression, bisected] Image corruption in Chrome

2016-06-03 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=95529 --- Comment #4 from Vladislav Egorov --- I tested it again, and d8d029f indeed leads to unrecoverable lock-ups of the whole system with radeonsi in Chrome. Also, on radeonsi after d8d029f I'm getting a lot of GPU faults in dmesg: [64145.940528] r

Re: [Mesa-dev] [PATCH] spirv: Avoid out of bounds access to nir src array.

2016-06-03 Thread Jason Ekstrand
On Jun 3, 2016 11:29 AM, "Kenneth Graunke" wrote: > > On Friday, June 3, 2016 10:28:34 AM PDT Jason Ekstrand wrote: > > On Jun 3, 2016 8:43 AM, wrote: > > > > > > From: Robert Foss > > > > > > Avoid out of bounds access of the array 'src'. > > > > > > 'src' is passed along: > > > nir_eval_co

Re: [Mesa-dev] [PATCH] spirv: Avoid out of bounds access to nir src array.

2016-06-03 Thread Kenneth Graunke
On Friday, June 3, 2016 10:28:34 AM PDT Jason Ekstrand wrote: > On Jun 3, 2016 8:43 AM, wrote: > > > > From: Robert Foss > > > > Avoid out of bounds access of the array 'src'. > > > > 'src' is passed along: > > nir_eval_const_opcode() > > evaluate_bitfield_insert() > > > > In evaluate_bit

Re: [Mesa-dev] [PATCH v2] i965: Fix point size with tessellation/geometry shaders in GLES.

2016-06-03 Thread Kenneth Graunke
On Friday, June 3, 2016 10:13:37 AM PDT Michael Schellenberger Costa wrote: > Hi Kenneth, > > Am 03.06.2016 um 10:08 schrieb Kenneth Graunke: > > Our previous code worked for desktop GL, and ES without geometry or > > tessellation shaders. But those features require fancier point size > > handlin

[Mesa-dev] [PATCH 1/3] docs/devinfo: Add closing paragraph tag

2016-06-03 Thread Nanley Chery
From: Nanley Chery Signed-off-by: Nanley Chery --- docs/devinfo.html | 1 + 1 file changed, 1 insertion(+) diff --git a/docs/devinfo.html b/docs/devinfo.html index 8ebf80f..70141ae 100644 --- a/docs/devinfo.html +++ b/docs/devinfo.html @@ -703,6 +703,7 @@ To add a new GL extension to Mesa you

[Mesa-dev] [PATCH 2/3] docs/devinfo: Update bullet in stale extension guide

2016-06-03 Thread Nanley Chery
From: Nanley Chery Signed-off-by: Nanley Chery --- docs/devinfo.html | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/devinfo.html b/docs/devinfo.html index 70141ae..f5d23ab 100644 --- a/docs/devinfo.html +++ b/docs/devinfo.html @@ -686,7 +686,7 @@ To add a new GL extens

[Mesa-dev] [PATCH 3/3] docs/devinfo: Expound on helpful extension tips

2016-06-03 Thread Nanley Chery
From: Nanley Chery Signed-off-by: Nanley Chery --- docs/devinfo.html | 7 +++ 1 file changed, 7 insertions(+) diff --git a/docs/devinfo.html b/docs/devinfo.html index f5d23ab..489d263 100644 --- a/docs/devinfo.html +++ b/docs/devinfo.html @@ -684,6 +684,8 @@ To add a new GL extension to Me

Re: [Mesa-dev] [PATCH] glsl: geom shader max_vertices layout must match.

2016-06-03 Thread Alejandro Piñeiro
On 03/06/16 02:46, Dave Airlie wrote: > From: Dave Airlie > > "all geometry shader output vertex count declarations in a > program must declare the same count." This spec quote lacks context. As far as I see it comes from GLSL 4.5 spec, "4.4.2.3 Geometry Outputs". > > Fixes: > GL45-CTS.geometry_

[Mesa-dev] [PATCH v2] swr: fix provoking vertex

2016-06-03 Thread Tim Rowley
Use rasterizer provoking vertex API. Fix rasterizer provoking vertex for tristrips and quad list/strips. v2: make provoking vertex tables static const --- .../drivers/swr/rasterizer/core/frontend.cpp | 38 -- src/gallium/drivers/swr/swr_draw.cpp | 30 +

Re: [Mesa-dev] [PATCH] spirv: Avoid out of bounds access to nir src array.

2016-06-03 Thread Robert Foss
Alright, I'll mark this as rejected in patchwork. On 2016-06-03 01:28 PM, Jason Ekstrand wrote: None of the Opcode's evaluated as specialization constants have four sources so this will never be a problem. Hence the assert on the next line. I think we should just mark this as a false positive.

Re: [Mesa-dev] [PATCH] swr: fix provoking vertex

2016-06-03 Thread Brian Paul
On 06/03/2016 10:52 AM, Tim Rowley wrote: Use rasterizer provoking vertex API. Fix rasterizer provoking vertex for tristrips and quad list/strips. --- .../drivers/swr/rasterizer/core/frontend.cpp | 38 -- src/gallium/drivers/swr/swr_draw.cpp | 30 ++

Re: [Mesa-dev] [PATCH] spirv: Avoid out of bounds access to nir src array.

2016-06-03 Thread Jason Ekstrand
On Jun 3, 2016 8:43 AM, wrote: > > From: Robert Foss > > Avoid out of bounds access of the array 'src'. > > 'src' is passed along: > nir_eval_const_opcode() > evaluate_bitfield_insert() > > In evaluate_bitfield_insert() an access to src[3] is made > if bit_size==32 wich it always will be

Re: [Mesa-dev] [PATCH 4/4] radeonsi: force non-displayable tiling based on surface dimensions

2016-06-03 Thread Marek Olšák
On Fri, Jun 3, 2016 at 5:18 PM, Gustaw Smolarczyk wrote: > 2016-06-03 12:52 GMT+02:00 Marek Olšák : >> From: Marek Olšák >> >> Simply ignore the "scanout" flag if the surface dimensions are unlikely >> to be used by DCE. >> >> This enables DCC for all X pixmaps that are not on the list of display

Re: [Mesa-dev] Patchwork review process (efficiency) questions

2016-06-03 Thread
On Fri, Jun 3, 2016 at 6:32 PM, Patrick Baggett wrote: > While I agree with the principle of what you're saying (the process > can be improved, etc.), being extremely sarcastic and condescending is > not the best way to effect change. Can you please point out which part of the *1st* message in th

[Mesa-dev] [PATCH] radeonsi: fix images with level > 0

2016-06-03 Thread Marek Olšák
From: Marek Olšák This should fix spec@arb_shader_image_load_store@level. Broken by: Commit: 95c5bbae66af3ca1f805d94f6fe8d8e4ba2c9c43 radeonsi: set some image descriptor fields at bind time Not tested because I'm on LLVM 3.8 right now. --- src/gallium/drivers/radeonsi/si_descriptors.c

Re: [Mesa-dev] Patchwork review process (efficiency) questions

2016-06-03 Thread Rob Clark
On Fri, Jun 3, 2016 at 1:05 PM, Alejandro Piñeiro wrote: > On 03/06/16 18:45, Patrick Baggett wrote: >>> I will point out a couple notes/observations: >>> >>> Kernel (drm/dri-devel), xorg, and other related projects use the same >>> process, and a lot of us do (or at least at some point have) been

[Mesa-dev] [PATCH 1/9] radeonsi: move enabled_mask out of si_descriptors

2016-06-03 Thread Nicolai Hähnle
From: Nicolai Hähnle This mask is irrelevant for the generic descriptor set handling, and having it outside simplifies subsequent changes slightly. --- src/gallium/drivers/radeonsi/si_blit.c| 4 +-- src/gallium/drivers/radeonsi/si_descriptors.c | 50 +-- src/gall

[Mesa-dev] [PATCH 8/9] radeonsi: move si_descriptors into a per-context array

2016-06-03 Thread Nicolai Hähnle
From: Nicolai Hähnle --- src/gallium/drivers/radeonsi/si_descriptors.c | 220 -- src/gallium/drivers/radeonsi/si_pipe.h| 2 +- src/gallium/drivers/radeonsi/si_state.h | 27 +++- 3 files changed, 166 insertions(+), 83 deletions(-) diff --git a/src/gallium

Re: [Mesa-dev] Patchwork review process (efficiency) questions

2016-06-03 Thread Alejandro Piñeiro
On 03/06/16 18:45, Patrick Baggett wrote: >> I will point out a couple notes/observations: >> >> Kernel (drm/dri-devel), xorg, and other related projects use the same >> process, and a lot of us do (or at least at some point have) been >> active in 2 or more of these. >> >> Also, I have seen/used s

[Mesa-dev] [PATCH 4/9] radeonsi: pass shader stage to si_set_shader_image

2016-06-03 Thread Nicolai Hähnle
From: Nicolai Hähnle --- src/gallium/drivers/radeonsi/si_descriptors.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_descriptors.c b/src/gallium/drivers/radeonsi/si_descriptors.c index 301781b..b3ba7d4 100644 --- a/src/gallium/dri

[Mesa-dev] [PATCH 2/9] radeonsi: move descriptor set begin_new_cs handling into a separate function

2016-06-03 Thread Nicolai Hähnle
From: Nicolai Hähnle --- src/gallium/drivers/radeonsi/si_descriptors.c | 36 +++ 1 file changed, 15 insertions(+), 21 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_descriptors.c b/src/gallium/drivers/radeonsi/si_descriptors.c index e24281b..b076052 100644 --

[Mesa-dev] [PATCH 5/9] radeonsi: add si_set_rw_buffer to be used for internal descriptors

2016-06-03 Thread Nicolai Hähnle
From: Nicolai Hähnle So that callers outside of si_descriptors.c need to worry less about the details of descriptor handling. --- src/gallium/drivers/radeonsi/si_descriptors.c | 15 ++- src/gallium/drivers/radeonsi/si_state.c | 9 +++-- src/gallium/drivers/radeonsi/si_stat

[Mesa-dev] [PATCH 7/9] radeonsi: pass shader stage to si_disable_shader_image

2016-06-03 Thread Nicolai Hähnle
From: Nicolai Hähnle --- src/gallium/drivers/radeonsi/si_descriptors.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_descriptors.c b/src/gallium/drivers/radeonsi/si_descriptors.c index 184839d..2d688aa 100644 --- a/src/gallium/d

[Mesa-dev] [PATCH 9/9] radeonsi: keep track of dirty descriptor sets

2016-06-03 Thread Nicolai Hähnle
From: Nicolai Hähnle Reduces CPU load for draw calls that change none or few of the descriptors. --- src/gallium/drivers/radeonsi/si_descriptors.c | 39 --- src/gallium/drivers/radeonsi/si_pipe.h| 1 + 2 files changed, 36 insertions(+), 4 deletions(-) diff --git

[Mesa-dev] [PATCH 6/9] radeonsi: access descriptor sets via local variables

2016-06-03 Thread Nicolai Hähnle
From: Nicolai Hähnle This will simplify moving them to a per-context array. --- src/gallium/drivers/radeonsi/si_descriptors.c | 72 +++ 1 file changed, 41 insertions(+), 31 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_descriptors.c b/src/gallium/drivers/rad

[Mesa-dev] [PATCH 0/9] radeonsi: speed up no-op descriptor uploads

2016-06-03 Thread Nicolai Hähnle
Hi, it is quite common that few or even no descriptors (except for vertex buffers) change between draw calls, but the function call overhead and branchiness of the code that is involved in figuring out that nothing changes takes a surprising amount of time, as measured by perf. The end goal of th

[Mesa-dev] [PATCH 3/9] radeonsi: pass shader stage to si_set_sampler_view

2016-06-03 Thread Nicolai Hähnle
From: Nicolai Hähnle --- src/gallium/drivers/radeonsi/si_descriptors.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_descriptors.c b/src/gallium/drivers/radeonsi/si_descriptors.c index b076052..301781b 100644 --- a/src/gallium/drive

Re: [Mesa-dev] [PATCH v3] clover: Update OpenCL version string to match OpenGL

2016-06-03 Thread Jan Vesely
On Fri, 2016-06-03 at 18:58 +0200, Vedran Miletić wrote: > On 06/03/2016 06:32 PM, Emil Velikov wrote: > > > > Not sure who much the MESA>Mesa change matters, so I'll leave that > > to others. > > > Could break some applications that check for it. I doubt many do, and > if  > they do I would sugg

Re: [Mesa-dev] [PATCH v3] clover: Update OpenCL version string to match OpenGL

2016-06-03 Thread Vedran Miletić
On 06/03/2016 06:32 PM, Emil Velikov wrote: Not sure who much the MESA>Mesa change matters, so I'll leave that to others. Could break some applications that check for it. I doubt many do, and if they do I would suggest to make the change before Clover becomes popular, in hope this will be th

[Mesa-dev] [PATCH] swr: fix provoking vertex

2016-06-03 Thread Tim Rowley
Use rasterizer provoking vertex API. Fix rasterizer provoking vertex for tristrips and quad list/strips. --- .../drivers/swr/rasterizer/core/frontend.cpp | 38 -- src/gallium/drivers/swr/swr_draw.cpp | 30 + src/gallium/drivers/swr/swr_scree

Re: [Mesa-dev] Patchwork review process (efficiency) questions

2016-06-03 Thread Patrick Baggett
> I will point out a couple notes/observations: > > Kernel (drm/dri-devel), xorg, and other related projects use the same > process, and a lot of us do (or at least at some point have) been > active in 2 or more of these. > > Also, I have seen/used some other processes (gerrit, github pulls, > etc)

Re: [Mesa-dev] Patchwork review process (efficiency) questions

2016-06-03 Thread Rob Clark
On Fri, Jun 3, 2016 at 11:49 AM, ⚛ <0xe2.0x9a.0...@gmail.com> wrote: > On Fri, Jun 3, 2016 at 2:08 PM, Nicolai Hähnle wrote: >> On 03.06.2016 13:12, wrote: >>> >>> Situation: Looking at the content displayed by the web browser for URL >>> http://patchwork.freedesktop.org/project/mesa/series and su

Re: [Mesa-dev] Patchwork review process (efficiency) questions

2016-06-03 Thread Ilia Mirkin
On Fri, Jun 3, 2016 at 12:17 PM, ⚛ <0xe2.0x9a.0...@gmail.com> wrote: > On Fri, Jun 3, 2016 at 5:54 PM, Ilia Mirkin wrote: >> On Fri, Jun 3, 2016 at 11:49 AM, ⚛ <0xe2.0x9a.0...@gmail.com> wrote: >>> On Fri, Jun 3, 2016 at 2:08 PM, Nicolai Hähnle wrote: On 03.06.2016 13:12, wrote: > >

Re: [Mesa-dev] [PATCH v3] clover: Update OpenCL version string to match OpenGL

2016-06-03 Thread Emil Velikov
On 3 June 2016 at 17:23, Vedran Miletić wrote: > Change MESA into Mesa in CL_PLATFORM_VERSION and CL_DEVICE_VERSION. For > both, append git version suffix from git_sha1.h if available. > > Original idea from Giuseppe Bilotta . > --- > src/gallium/state_trackers/clover/api/device.cpp | 7 ++-

[Mesa-dev] [PATCH v3] clover: Update OpenCL version string to match OpenGL

2016-06-03 Thread Vedran Miletić
Change MESA into Mesa in CL_PLATFORM_VERSION and CL_DEVICE_VERSION. For both, append git version suffix from git_sha1.h if available. Original idea from Giuseppe Bilotta . --- src/gallium/state_trackers/clover/api/device.cpp | 7 ++- src/gallium/state_trackers/clover/api/platform.cpp | 7 ++

Re: [Mesa-dev] Patchwork review process (efficiency) questions

2016-06-03 Thread
On Fri, Jun 3, 2016 at 5:54 PM, Ilia Mirkin wrote: > On Fri, Jun 3, 2016 at 11:49 AM, ⚛ <0xe2.0x9a.0...@gmail.com> wrote: >> On Fri, Jun 3, 2016 at 2:08 PM, Nicolai Hähnle wrote: >>> On 03.06.2016 13:12, wrote: Situation: Looking at the content displayed by the web browser for URL

Re: [Mesa-dev] [PATCH] i965: don't use NumLayers for 3D textures.

2016-06-03 Thread Eduardo Lima Mitev
Reviewed-by: Eduardo Lima Mitev On 06/03/2016 04:34 AM, Dave Airlie wrote: > From: Dave Airlie > > For 3D textures we shouldn't be using NumLayers, we need > to get it from the depth. > > This fixes: > GL45-CTS.geometry_shader.layered_framebuffer.clear_call_support > > Signed-off-by: Dave Air

[Mesa-dev] [PATCH v2] clover: Update OpenCL version string to match OpenGL

2016-06-03 Thread Vedran Miletić
Change MESA into Mesa in CL_PLATFORM_VERSION and CL_DEVICE_VERSION. For both, append git version suffix if available. Original idea from Giuseppe Bilotta . --- src/gallium/state_trackers/clover/api/device.cpp | 6 +- src/gallium/state_trackers/clover/api/platform.cpp | 7 ++- 2 files ch

Re: [Mesa-dev] [PATCH 2/2] nvc0: fix memory barrier flag handling

2016-06-03 Thread Samuel Pitoiset
Reviewed-by: Samuel Pitoiset On 06/03/2016 08:25 AM, Ilia Mirkin wrote: Signed-off-by: Ilia Mirkin Cc: "12.0" --- src/gallium/drivers/nouveau/nvc0/nvc0_context.c | 25 - 1 file changed, 16 insertions(+), 9 deletions(-) diff --git a/src/gallium/drivers/nouveau/nvc0/nv

Re: [Mesa-dev] Patchwork review process (efficiency) questions

2016-06-03 Thread Rob Clark
On Fri, Jun 3, 2016 at 11:11 AM, Emil Velikov wrote: > On 3 June 2016 at 13:10, Rob Clark wrote: >> On Fri, Jun 3, 2016 at 7:12 AM, ⚛ <0xe2.0x9a.0...@gmail.com> wrote: >>> Hello >>> >>> Situation: Looking at the content displayed by the web browser for URL >>> http://patchwork.freedesktop.org/pro

Re: [Mesa-dev] Patchwork review process (efficiency) questions

2016-06-03 Thread Ilia Mirkin
On Fri, Jun 3, 2016 at 11:49 AM, ⚛ <0xe2.0x9a.0...@gmail.com> wrote: > On Fri, Jun 3, 2016 at 2:08 PM, Nicolai Hähnle wrote: >> On 03.06.2016 13:12, wrote: >>> >>> Situation: Looking at the content displayed by the web browser for URL >>> http://patchwork.freedesktop.org/project/mesa/series and su

Re: [Mesa-dev] Patchwork review process (efficiency) questions

2016-06-03 Thread
On Fri, Jun 3, 2016 at 2:08 PM, Nicolai Hähnle wrote: > On 03.06.2016 13:12, wrote: >> >> Situation: Looking at the content displayed by the web browser for URL >> http://patchwork.freedesktop.org/project/mesa/series and sub-pages >> accessible via the links. > > > Patchwork isn't really central t

[Mesa-dev] [PATCH] clover: Update OpenCL version string to match OpenGL

2016-06-03 Thread vedran
From: Vedran Miletić Change MESA into Mesa and add git version suffix if available. Original idea from Giuseppe Bilotta . --- src/gallium/state_trackers/clover/api/platform.cpp | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/gallium/state_trackers/clover/api/platfo

[Mesa-dev] [PATCH] spirv: Avoid out of bounds access to nir src array.

2016-06-03 Thread robert . foss
From: Robert Foss Avoid out of bounds access of the array 'src'. 'src' is passed along: nir_eval_const_opcode() evaluate_bitfield_insert() In evaluate_bitfield_insert() an access to src[3] is made if bit_size==32 wich it always will be due to the assert(bit_size == 32) on spirv_to_nir.c

Re: [Mesa-dev] [PATCH 4/4] radeonsi: force non-displayable tiling based on surface dimensions

2016-06-03 Thread Gustaw Smolarczyk
2016-06-03 12:52 GMT+02:00 Marek Olšák : > From: Marek Olšák > > Simply ignore the "scanout" flag if the surface dimensions are unlikely > to be used by DCE. > > This enables DCC for all X pixmaps that are not on the list of displayable > dimensions. > > Also ignore the "scanout" flag for non-2D,

[Mesa-dev] [PATCH 2/2] radeonsi: add a performance tweak for 4 SE parts

2016-06-03 Thread Marek Olšák
From: Marek Olšák Ported from Vulkan. --- src/gallium/drivers/radeonsi/si_state_draw.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/src/gallium/drivers/radeonsi/si_state_draw.c b/src/gallium/drivers/radeonsi/si_state_draw.c index c2d9a2f..f43d56e 100644 --- a/src/gallium/dri

[Mesa-dev] [PATCH 1/2] radeonsi: simplify PRIMGROUP_SIZE computation for tessellation

2016-06-03 Thread Marek Olšák
From: Marek Olšák Ported from Vulkan. --- src/gallium/drivers/radeonsi/si_state_draw.c | 11 +-- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_state_draw.c b/src/gallium/drivers/radeonsi/si_state_draw.c index c7590cb..c2d9a2f 100644 --- a/

Re: [Mesa-dev] [PATCH] radeonsi: set descriptor dirty mask on shader buffer unbind

2016-06-03 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Fri, Jun 3, 2016 at 3:20 PM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > Found randomly while skimming the code. This might have caused VM faults in > robustness tests. > > Cc: 12.0 > --- > src/gallium/drivers/radeonsi/si_descriptors.c | 1 + > 1 file c

Re: [Mesa-dev] Patchwork review process (efficiency) questions

2016-06-03 Thread Emil Velikov
On 3 June 2016 at 13:10, Rob Clark wrote: > On Fri, Jun 3, 2016 at 7:12 AM, ⚛ <0xe2.0x9a.0...@gmail.com> wrote: >> Hello >> >> Situation: Looking at the content displayed by the web browser for URL >> http://patchwork.freedesktop.org/project/mesa/series and sub-pages >> accessible via the links. >

Re: [Mesa-dev] Mesa (master): Revert "egl: Check if API is supported when using eglBindAPI."

2016-06-03 Thread Marek Olšák
On Fri, Jun 3, 2016 at 4:33 PM, Dieter Nützel wrote: > Am 03.06.2016 11:47, schrieb Michel Dänzer: >> >> On 03.06.2016 18:34, Marek =?UNKNOWN?B?T2zFocOhaw==?= wrote: >>> >>> Module: Mesa >>> Branch: master >>> Commit: 8c361e84ad010552a42593fad4130befc58e9a6a >>> URL: >>> http://cgit.freedesktop.or

Re: [Mesa-dev] Mesa (master): Revert "egl: Check if API is supported when using eglBindAPI."

2016-06-03 Thread Dieter Nützel
Am 03.06.2016 11:47, schrieb Michel Dänzer: On 03.06.2016 18:34, Marek =?UNKNOWN?B?T2zFocOhaw==?= wrote: Module: Mesa Branch: master Commit: 8c361e84ad010552a42593fad4130befc58e9a6a URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=8c361e84ad010552a42593fad4130befc58e9a6a Author: Marek

[Mesa-dev] [PATCH] radeonsi: set descriptor dirty mask on shader buffer unbind

2016-06-03 Thread Nicolai Hähnle
From: Nicolai Hähnle Found randomly while skimming the code. This might have caused VM faults in robustness tests. Cc: 12.0 --- src/gallium/drivers/radeonsi/si_descriptors.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/drivers/radeonsi/si_descriptors.c b/src/gallium/drivers

Re: [Mesa-dev] tilers and out-of-order rendering..

2016-06-03 Thread Rob Clark
Ok, so I had a really evil thought that I wanted to bounce off people.. it's a quite different approach from the more obvious one discussed below (and which I've already started implementing) Basically, idea is to have a wrapper pipe driver, similar to ddebug/rbug/trace/etc, which re-orders draw

Re: [Mesa-dev] [PATCH v2] st/mesa: fix resource leak in try_pbo_readpixels

2016-06-03 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Fri, Jun 3, 2016 at 2:13 PM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > Found by inspection after seeing > https://bugs.freedesktop.org/show_bug.cgi?id=96343 > --- > src/mesa/state_tracker/st_cb_readpixels.c | 2 +- > 1 file changed, 1 insertion(+), 1 d

[Mesa-dev] [PATCH v2] st/mesa: fix resource leak in try_pbo_readpixels

2016-06-03 Thread Nicolai Hähnle
From: Nicolai Hähnle Found by inspection after seeing https://bugs.freedesktop.org/show_bug.cgi?id=96343 --- src/mesa/state_tracker/st_cb_readpixels.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/state_tracker/st_cb_readpixels.c b/src/mesa/state_tracker/st_cb_rea

Re: [Mesa-dev] Patchwork review process (efficiency) questions

2016-06-03 Thread Rob Clark
On Fri, Jun 3, 2016 at 7:12 AM, ⚛ <0xe2.0x9a.0...@gmail.com> wrote: > Hello > > Situation: Looking at the content displayed by the web browser for URL > http://patchwork.freedesktop.org/project/mesa/series and sub-pages > accessible via the links. > > The following questions are troubling me: > > -

Re: [Mesa-dev] Patchwork review process (efficiency) questions

2016-06-03 Thread Nicolai Hähnle
On 03.06.2016 13:12, ⚛ wrote: Situation: Looking at the content displayed by the web browser for URL http://patchwork.freedesktop.org/project/mesa/series and sub-pages accessible via the links. Patchwork isn't really central to most people's workflow as far as I understand it. Most of your que

Re: [Mesa-dev] [PATCH 2/2] nvc0: fix memory barrier flag handling

2016-06-03 Thread Samuel Pitoiset
On 06/03/2016 10:29 AM, Samuel Pitoiset wrote: This doesn't seem crazy, but it will require testing I would say. Especially, arb_shader_image_load_store-host-mem-barrier which makes use of different barriers with images. I have just tested on GK106, no regression with that test. But I will

[Mesa-dev] [PATCH] nvc0/ir: clamp the UBO index for compute on Kepler

2016-06-03 Thread Samuel Pitoiset
We already check that the address is not "too far", but we should also clamp the UBO index in order to avoid looking at the wrong place in the driver cb. This is a pretty rare situation though. Signed-off-by: Samuel Pitoiset Cc: "12.0" --- src/gallium/drivers/nouveau/codegen/nv50_ir_lowering_nv

[Mesa-dev] Patchwork review process (efficiency) questions

2016-06-03 Thread
Hello Situation: Looking at the content displayed by the web browser for URL http://patchwork.freedesktop.org/project/mesa/series and sub-pages accessible via the links. The following questions are troubling me: - How does a patch submitter know when a reviewer will take a look at the patch? - W

[Mesa-dev] [PATCH 4/4] radeonsi: force non-displayable tiling based on surface dimensions

2016-06-03 Thread Marek Olšák
From: Marek Olšák Simply ignore the "scanout" flag if the surface dimensions are unlikely to be used by DCE. This enables DCC for all X pixmaps that are not on the list of displayable dimensions. Also ignore the "scanout" flag for non-2D, non-color, and AA surfaces. Any suggestions how to redu

[Mesa-dev] [PATCH 3/4] gallium/radeon: add support for sharing textures with DCC between processes

2016-06-03 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/radeon/r600_pipe_common.h | 4 src/gallium/drivers/radeon/r600_texture.c | 16 +++--- src/gallium/drivers/radeonsi/si_state.c | 32 ++- 3 files changed, 48 insertions(+), 4 deletions(-) diff --git a/src/ga

[Mesa-dev] [PATCH 1/4] gallium/radeon: don't re-set BO metadata after CMASK deallocation

2016-06-03 Thread Marek Olšák
From: Marek Olšák CMASK has no effect on metadata, because it's not sharable. --- src/gallium/drivers/radeon/r600_texture.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/gallium/drivers/radeon/r600_texture.c b/src/gallium/drivers/radeon/r600_texture.c index bf6cfe8..71758c4 100644 ---

[Mesa-dev] [PATCH 0/4] RadeonSI: Enable DCC for X mipmaps and other shared textures

2016-06-03 Thread Marek Olšák
We can save some bandwidth and power with this. It also enables fast clear for some windowed apps on Stoney. If you update radeonsi_dri.so but not restart X while using DRI3, X won't be able to display drawables correctly. (e.g. firefox will display garbage) Please review. Marek __

[Mesa-dev] [PATCH 2/4] gallium/radeon: don't discard DCC if an external user can write to it

2016-06-03 Thread Marek Olšák
From: Marek Olšák We don't import textures with DCC now, but soon we will. --- src/gallium/drivers/radeon/r600_pipe_common.h | 2 +- src/gallium/drivers/radeon/r600_texture.c | 31 +++ 2 files changed, 23 insertions(+), 10 deletions(-) diff --git a/src/gallium/drive

[Mesa-dev] [Bug 96309] Request for new account

2016-06-03 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=96309 Martin Peres changed: What|Removed |Added QA Contact||mesa-dev@lists.freedesktop.

Re: [Mesa-dev] Mesa (master): Revert "egl: Check if API is supported when using eglBindAPI."

2016-06-03 Thread Michel Dänzer
On 03.06.2016 18:34, Marek =?UNKNOWN?B?T2zFocOhaw==?= wrote: > Module: Mesa > Branch: master > Commit: 8c361e84ad010552a42593fad4130befc58e9a6a > URL: > http://cgit.freedesktop.org/mesa/mesa/commit/?id=8c361e84ad010552a42593fad4130befc58e9a6a > > Author: Marek Olšák > Date: Fri Jun 3 11:25

Re: [Mesa-dev] [PATCH] st/mesa: fix dirty flags for atoms that can depend on mutable objects

2016-06-03 Thread Marek Olšák
On Fri, Jun 3, 2016 at 2:31 AM, Ilia Mirkin wrote: > Both textures and buffers can have their underlying resources > reallocated with a glTexImage*() or glBufferData(). Atoms that reference > these need to be notified that a change to the underlying resource has > occurred in order to be recreated

Re: [Mesa-dev] [PATCH] egl: Check if API is supported when using eglBindAPI.

2016-06-03 Thread Marek Olšák
I've reverted this commit, because it breaks Glamor with current and older X servers. Marek On Tue, May 31, 2016 at 6:32 PM, Plamena Manolova wrote: > According to the EGL specifications before binding an API > we must check whether it's supported first. If not eglBindAPI > should return EGL_FAL

Re: [Mesa-dev] [PATCH 2/2] nvc0: fix memory barrier flag handling

2016-06-03 Thread Samuel Pitoiset
This doesn't seem crazy, but it will require testing I would say. Especially, arb_shader_image_load_store-host-mem-barrier which makes use of different barriers with images. On 06/03/2016 08:25 AM, Ilia Mirkin wrote: Signed-off-by: Ilia Mirkin Cc: "12.0" --- src/gallium/drivers/nouveau/nvc

Re: [Mesa-dev] [PATCH 1/2] nvc0: mark bound buffer range valid

2016-06-03 Thread Samuel Pitoiset
All this code duplication is... sad but heh?! :) I guess it would be, at least, easy to refactor nvc0_validate_buffers() and nvc0_compute_validate_buffers(). Reviewed-by: Samuel Pitoiset On 06/03/2016 08:25 AM, Ilia Mirkin wrote: Signed-off-by: Ilia Mirkin Cc: "12.0" --- src/gallium/driv

[Mesa-dev] [PATCH v2] i965: Fix point size with tessellation/geometry shaders in GLES.

2016-06-03 Thread Kenneth Graunke
Our previous code worked for desktop GL, and ES without geometry or tessellation shaders. But those features require fancier point size handling. Fortunately, we can use one rule for all APIs. Fixes a number of dEQP tests with EXT_tessellation_shader enabled: dEQP-GLES31.functional.tessellation_

Re: [Mesa-dev] [PATCH] mesa/readpix: clamp SNORM properly

2016-06-03 Thread Eduardo Lima Mitev
Patch looks good. I don't have the CTS test accessible, so I couldn't confirm myself that it is fixed. If that's confirmed, patch is: Reviewed-by: Eduardo Lima Mitev Left a few long-line nitpicks below. Eduardo On 05/10/2016 05:59 AM, Dave Airlie wrote: > From: Dave Airlie > > The clamping c

  1   2   >