Re: [Mesa-dev] [PATCH v2 02/31] i965/blorp: Expose the shader cache through function pointers

2016-08-28 Thread Pohjolainen, Topi
On Fri, Aug 26, 2016 at 06:58:27PM -0700, Jason Ekstrand wrote: > This sanitizes blorp's access to the i965 driver's shader cache by patching > it through the blorp_context. When we start using blorp in Vulkan, we will > simply have to implement such a caching interface in the Vulkan driver. > >

Re: [Mesa-dev] [PATCH 2/3] mesa: Handle OES_texture_view tokens

2016-08-28 Thread Francesco Ansanelli
I dropped this patch and replaced with another one. Thanks Francesco 2016-08-28 22:38 GMT+02:00 Chris Forbes : > This patch isn't right. These enum values are the same as the desktop > version, so your new cases will never actually be used. > > On Mon, Aug 29, 2016 at 2:24 AM,

Re: [Mesa-dev] GL_OES_texture_view RFC

2016-08-28 Thread Francesco Ansanelli
Thanks for your feedback. I've addressed your concerns in the version 2 of patches. Francesco 2016-08-28 16:42 GMT+02:00 Ilia Mirkin : > The most important part of this exercise is to get tests up and running. > Unfortunately there are none in dEQP. I think the simplest

Re: [Mesa-dev] [PATCH 02/13] nir: limit copy propagation inside loops

2016-08-28 Thread Connor Abbott
On Mon, Aug 29, 2016 at 12:54 AM, Timothy Arceri wrote: > Don't do copy propagation inside loops until after we try > unrolling them. > > This helps avoid propagating everything to the phis which > makes loop unrolling more difficult. > > For example without this: >

Re: [Mesa-dev] [PATCH 06/31] i965/blorp: Use gen6_upload_urb

2016-08-28 Thread Pohjolainen, Topi
On Fri, Aug 19, 2016 at 09:55:43AM -0700, Jason Ekstrand wrote: > --- > src/mesa/drivers/dri/i965/genX_blorp_exec.c | 6 ++ > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/src/mesa/drivers/dri/i965/genX_blorp_exec.c > b/src/mesa/drivers/dri/i965/genX_blorp_exec.c > index

[Mesa-dev] [PATCH 1/3] glapi: add GL_OES_texture_view

2016-08-28 Thread Francesco Ansanelli
Signed-off-by: Francesco Ansanelli --- src/mapi/glapi/gen/es_EXT.xml | 15 +++ src/mesa/main/extensions_table.h|1 + src/mesa/main/mtypes.h |1 + src/mesa/main/tests/dispatch_sanity.cpp |3 +++ 4 files changed, 20

[Mesa-dev] [PATCH 3/3] mesa: implement GL_OES_texture_view (V2)

2016-08-28 Thread Francesco Ansanelli
XXX still need to figure how to treat the removed VIEW_CLASS* and formats. V2: drop the oes suffix in messages (Ilia Mirkin) Signed-off-by: Francesco Ansanelli --- src/mesa/main/textureview.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff

[Mesa-dev] [PATCH 2/3] mesa: Add and use _mesa_has_texture_view helper(v2)

2016-08-28 Thread Francesco Ansanelli
V2:use the same tokens of the desktop version (Ilia Mirkin, Chris Forbes) Signed-off-by: Francesco Ansanelli --- src/mesa/main/context.h |7 +++ src/mesa/main/texparam.c | 22 ++ 2 files changed, 17 insertions(+), 12 deletions(-) diff --git

Re: [Mesa-dev] [PATCH] i965/hsw: Enable ARB_ES3_1_compatibility extension

2016-08-28 Thread Samuel Iglesias Gonsálvez
Reviewed-by: Samuel Iglesias Gonsálvez On 27/08/16 23:18, Jordan Justen wrote: > Signed-off-by: Jordan Justen > Acked-by: Kenneth Graunke > --- > docs/features.txt| 2 +- >

Re: [Mesa-dev] [PATCH] android: fix build issues with genxml, isl

2016-08-28 Thread kalyan kondapally
Ya, things build for me too now. Thanks. Br, Kalyan On Sun, Aug 28, 2016 at 10:05 PM, Tapani Pälli wrote: > Nice work, now things build fine! > > Reviewed-by: Tapani Pälli > > On 08/28/2016 03:51 AM, Mauro Rossi wrote: >> >> Hi Emil, Jason,

Re: [Mesa-dev] [PATCH] android: fix build issues with genxml, isl

2016-08-28 Thread Tapani Pälli
Nice work, now things build fine! Reviewed-by: Tapani Pälli On 08/28/2016 03:51 AM, Mauro Rossi wrote: Hi Emil, Jason, Tapani, this weekend I had planned to check mesa-dev with marshmallow-x86 and nougat-x86,builds, so here you can find the port to android of commit

Re: [Mesa-dev] [PATCH 03/13] nir: Add a loop analysis pass

2016-08-28 Thread Timothy Arceri
This patch should be: From: Thomas Helland Seem to have lost the author during rebasing. Fixed locally. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH 13/13] i965: use nir unrolling for scalar backend

2016-08-28 Thread Timothy Arceri
--- src/compiler/glsl/glsl_parser_extras.cpp | 12 +++- src/compiler/nir/nir_metadata.c | 2 ++ src/mesa/drivers/dri/i965/brw_compiler.c | 6 +- src/mesa/drivers/dri/i965/brw_nir.c | 4 4 files changed, 18 insertions(+), 6 deletions(-) diff --git

[Mesa-dev] [PATCH 10/13] nir: add helper for cloning loops

2016-08-28 Thread Timothy Arceri
--- src/compiler/nir/nir.h | 3 +++ src/compiler/nir/nir_clone.c | 64 +++- 2 files changed, 60 insertions(+), 7 deletions(-) diff --git a/src/compiler/nir/nir.h b/src/compiler/nir/nir.h index 0ab3ebc..9083bd0 100644 --- a/src/compiler/nir/nir.h +++

[Mesa-dev] [PATCH 12/13] nir: add a loop unrolling pass

2016-08-28 Thread Timothy Arceri
--- src/compiler/Makefile.sources | 1 + src/compiler/nir/nir.h | 2 + src/compiler/nir/nir_opt_loop_unroll.c | 394 + 3 files changed, 397 insertions(+) create mode 100644 src/compiler/nir/nir_opt_loop_unroll.c diff --git

[Mesa-dev] [PATCH 09/13] nir: create helper for fixing phi srcs when cloning

2016-08-28 Thread Timothy Arceri
This will be useful for fixing phi srcs when cloning a loop body during loop unrolling. --- src/compiler/nir/nir_clone.c | 36 +--- 1 file changed, 21 insertions(+), 15 deletions(-) diff --git a/src/compiler/nir/nir_clone.c b/src/compiler/nir/nir_clone.c index

[Mesa-dev] [PATCH 04/13] nir: add is_simple_for_loop() helper

2016-08-28 Thread Timothy Arceri
This will be used by the loop unroll and lcssa passes. Reviewed-by: Thomas Helland --- src/compiler/nir/nir.h | 8 1 file changed, 8 insertions(+) diff --git a/src/compiler/nir/nir.h b/src/compiler/nir/nir.h index 491859e..0ddd4e2 100644 ---

[Mesa-dev] [PATCH 11/13] nir: make cleanup_cf_node() accessable externally

2016-08-28 Thread Timothy Arceri
We also allow unlinking of jumps to be skipped, this will be useful for removing loops once they have been unrolled. --- src/compiler/nir/nir_control_flow.c | 23 ++- src/compiler/nir/nir_control_flow.h | 4 2 files changed, 18 insertions(+), 9 deletions(-) diff --git

[Mesa-dev] [PATCH 07/13] nir: create nir_opt_remove_phi() helper

2016-08-28 Thread Timothy Arceri
This will be useful for cleaning up phis when unrolling loops. --- src/compiler/nir/nir.h | 1 + src/compiler/nir/nir_opt_remove_phis.c | 94 +++--- 2 files changed, 53 insertions(+), 42 deletions(-) diff --git a/src/compiler/nir/nir.h

[Mesa-dev] [PATCH 08/13] nir: add control flow helpers for loop unrolling

2016-08-28 Thread Timothy Arceri
This makes stitch_blocks() available for use else where, and adds a new helper that extracts a cf list without worrying about validation. --- src/compiler/nir/nir_control_flow.c | 34 -- src/compiler/nir/nir_control_flow.h | 5 + 2 files changed, 37

[Mesa-dev] [PATCH 05/13] nir: Add a LCSAA-pass

2016-08-28 Thread Timothy Arceri
From: Thomas Helland V2: Do a "depth first search" to convert to LCSSA V3: Small comment fixup V4: Rebase, adapt to removal of function overloads V5: Rebase, adapt to relocation of nir to compiler/nir Still need to adapt to potential if-uses Work around

[Mesa-dev] [PATCH 06/13] nir: don't count removal of lcssa_phi as progress

2016-08-28 Thread Timothy Arceri
--- src/compiler/nir/nir_opt_remove_phis.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/compiler/nir/nir_opt_remove_phis.c b/src/compiler/nir/nir_opt_remove_phis.c index ee92fbe..6d9e0ff 100644 --- a/src/compiler/nir/nir_opt_remove_phis.c +++

[Mesa-dev] [PATCH 03/13] nir: Add a loop analysis pass

2016-08-28 Thread Timothy Arceri
This pass detects induction variables and calculates the trip count of loops to be used for loop unrolling. I've removed support for float induction values for now, for the simple reason that they don't appear in my shader-db collection, and so I don't see it as common enough that we want to

[Mesa-dev] [PATCH 02/13] nir: limit copy propagation inside loops

2016-08-28 Thread Timothy Arceri
Don't do copy propagation inside loops until after we try unrolling them. This helps avoid propagating everything to the phis which makes loop unrolling more difficult. For example without this: loop { block block_1: /* preds: block_0 block_4 */ vec1 32 ssa_10 = phi

[Mesa-dev] V2 Simple loop unrolling in NIR

2016-08-28 Thread Timothy Arceri
V2: Bunch of tidy ups from feedback and things I noticed after sending the RFC. This series does the equivalent of the simple unroll in GLSL IR. The main difference is that currently it unrolls everything with an iteration count < 32, the GLSL IR pass also tries to limit unrolling based on the

[Mesa-dev] [PATCH 01/13] i965: use nir_lower_indirect_derefs() for GLSL

2016-08-28 Thread Timothy Arceri
This moves the nir_lower_indirect_derefs() call into brw_preprocess_nir() so thats is called by both OpenGL and Vulkan and removes that call to the old GLSL IR pass lower_variable_index_to_cond_assign() We want to do this pass in nir to be able to move loop unrolling to nir. There is a increase

Re: [Mesa-dev] [PATCH 3/3] isl: add support for Android libmesa_isl static library

2016-08-28 Thread Tapani Pälli
On 08/26/2016 02:51 PM, Mauro Rossi wrote: 2016-08-26 12:27 GMT+02:00 Tapani Pälli >: Hi; This is patch is causing build issues for me, how was this tested? Hi, thanks for highlighting the issue, My patch was tested and

Re: [Mesa-dev] [PATCH] android: fix build issues with genxml, isl

2016-08-28 Thread Tapani Pälli
On 08/28/2016 03:51 AM, Mauro Rossi wrote: Hi Emil, Jason, Tapani, this weekend I had planned to check mesa-dev with marshmallow-x86 and nougat-x86,builds, so here you can find the port to android of commit bebc1a1d995e33f173ea207848bcddd81f6dd19a Built successfully and tested on

Re: [Mesa-dev] [PATCH] automake: egl: Android: Add libEGL dependencies

2016-08-28 Thread Tapani Pälli
On 08/26/2016 03:58 PM, Emil Velikov wrote: On 26 August 2016 at 08:50, Tapani Pälli wrote: Reviewed-by: Tapani Pälli What happened with my suggestion about getting things fixed as opposed to adding tape over things, namely these thread [1]

[Mesa-dev] [Bug 97525] [VDPAU]: artifacts when trying video sharpening and noise-reduction before CSC

2016-08-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97525 Bug ID: 97525 Summary: [VDPAU]: artifacts when trying video sharpening and noise-reduction before CSC Product: Mesa Version: unspecified Hardware: Other

Re: [Mesa-dev] [PATCH] Update Khronos-supplied headers to r33100

2016-08-28 Thread Edward O'Callaghan
On 08/29/2016 03:18 AM, Ilia Mirkin wrote: > On Sun, Aug 28, 2016 at 1:10 PM, Ilia Mirkin wrote: >> As retrieved from opengl.org and khronos.org. Maintained the APPLE hack >> in GL/glext.h manually. Added gl32.h. >> >> Signed-off-by: Ilia Mirkin

Re: [Mesa-dev] [PATCH] radeonsi: add support for cull distances. (v1.1)

2016-08-28 Thread Edward O'Callaghan
On 08/29/2016 12:16 PM, Dave Airlie wrote: > From: Dave Airlie > > This should be all that is required for cull distances to work > on radeonsi. > > v1.1: whitespace cleanup, add docs fix clipdist_mask usage. > > Signed-off-by: Dave Airlie

Re: [Mesa-dev] [PATCH] glsl: initialise pointer to NULL

2016-08-28 Thread Kenneth Graunke
On Monday, August 29, 2016 12:03:47 PM PDT Timothy Arceri wrote: > Fixes uninitialised warning and covery defect. > > Cc: Kenneth Graunke > --- > src/compiler/glsl/lower_blend_equation_advanced.cpp | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

[Mesa-dev] [PATCH] radeonsi: add support for cull distances. (v1.1)

2016-08-28 Thread Dave Airlie
From: Dave Airlie This should be all that is required for cull distances to work on radeonsi. v1.1: whitespace cleanup, add docs fix clipdist_mask usage. Signed-off-by: Dave Airlie --- docs/features.txt | 2 +-

[Mesa-dev] [Bug 97260] [bisected] R9 290 low performance in Linux 4.7

2016-08-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97260 --- Comment #35 from Michel Dänzer --- (In reply to Clésio Luiz from comment #32) > The package xserver-xorg-video-ati from his PPA is from 08/24 though. That doesn't matter; Mesa does, and it looks like it should have my

[Mesa-dev] [PATCH] spirv: replace assert with unreachable

2016-08-28 Thread Timothy Arceri
Fixes uninitialised warning for coord_components. --- src/compiler/spirv/spirv_to_nir.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/compiler/spirv/spirv_to_nir.c b/src/compiler/spirv/spirv_to_nir.c index ca404d8..fda38f9 100644 --- a/src/compiler/spirv/spirv_to_nir.c

[Mesa-dev] [PATCH 4/7] glsl: add core plumbing for GL_ANDROID_extension_pack_es31a

2016-08-28 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin --- src/compiler/glsl/glsl_parser_extras.cpp | 57 +++- src/compiler/glsl/glsl_parser_extras.h | 2 ++ src/mesa/main/extensions_table.h | 2 ++ src/mesa/main/mtypes.h | 1 + 4 files

[Mesa-dev] [PATCH 6/7] mesa: add a GLES3.2 enums section, and expose new MS line width params

2016-08-28 Thread Ilia Mirkin
This also exposes them for ARB_ES3_2_compatibility. Signed-off-by: Ilia Mirkin --- src/mesa/main/context.h | 10 ++ src/mesa/main/get.c | 26 -- src/mesa/main/get_hash_generator.py | 12

[Mesa-dev] [PATCH 7/7] mesa: introduce glPrimitiveBoundingBoxARB entrypoint

2016-08-28 Thread Ilia Mirkin
This requires a bit of rejiggering, since normally ES entrypoints alias core ones, not vice-versa. Signed-off-by: Ilia Mirkin --- src/mapi/glapi/gen/es_EXT.xml | 19 - src/mapi/glapi/gen/gl_API.xml | 37 +

[Mesa-dev] [PATCH 2/7] mapi: don't forget to expose GetPointerv in GL ES 3.2

2016-08-28 Thread Ilia Mirkin
I left this out of my previous commit that went around enabling all of the other ES 3.2 entrypoints. Signed-off-by: Ilia Mirkin --- src/mapi/glapi/gen/gl_API.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mapi/glapi/gen/gl_API.xml

[Mesa-dev] [PATCH 1/7] main: add KHR_robustness to ES 3.2 extension requirements

2016-08-28 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin --- src/mesa/main/version.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/main/version.c b/src/mesa/main/version.c index cfc1638..85ec9de 100644 --- a/src/mesa/main/version.c +++ b/src/mesa/main/version.c @@ -531,6 +531,7 @@

[Mesa-dev] [PATCH 3/7] glsl: expose max atomic counter/buffer consts for tess in ES 3.2

2016-08-28 Thread Ilia Mirkin
Curiously OES/EXT_tessellation_shader leave these out, while ES 3.2 adds them in. Signed-off-by: Ilia Mirkin --- src/compiler/glsl/builtin_variables.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/compiler/glsl/builtin_variables.cpp

[Mesa-dev] [PATCH 0/7] Core ES 3.2 + AEP left-overs

2016-08-28 Thread Ilia Mirkin
While we're waiting for the tessellation patches to land, I went ahead and implemented what's necessary for ES 3.2 (and ARB_ES3_2_compatibility) along with AEP. It's not that much. These apply on top of my bounding box patches. You can find a full tree here:

[Mesa-dev] [PATCH 5/7] mesa: introduce MS variants of line width min/max/granularity

2016-08-28 Thread Ilia Mirkin
These are exposed in ES 3.2. However this moves all st/mesa to clamping on the MS variants. But for now the MS variants are initialized to the AA values. Signed-off-by: Ilia Mirkin --- src/mesa/drivers/dri/i965/brw_context.c | 5 + src/mesa/main/context.c

[Mesa-dev] [PATCH] glsl: initialise pointer to NULL

2016-08-28 Thread Timothy Arceri
Fixes uninitialised warning and covery defect. Cc: Kenneth Graunke --- src/compiler/glsl/lower_blend_equation_advanced.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/compiler/glsl/lower_blend_equation_advanced.cpp

Re: [Mesa-dev] [PATCH] loader/dri3: Overhaul dri3_update_num_back

2016-08-28 Thread Michel Dänzer
On 28/08/16 03:03 AM, Dieter Nützel wrote: > Am 25.08.2016 11:09, schrieb Michel Dänzer: >> On 24/08/16 06:35 AM, Eric Anholt wrote: >>> Michel Dänzer writes: On 20/08/16 04:42 AM, Eric Anholt wrote: > Michel Dänzer writes: > >> From:

Re: [Mesa-dev] [PATCH] android: fix build issues with genxml, isl

2016-08-28 Thread Mauro Rossi
> While you're at it, I've got another build-breaking branch here: > > https://cgit.freedesktop.org/~jekstrand/mesa/log/?h=wip/blorp-vulkan > > It's almost reviewed so I'll be pushing soon. If you could provide a > squash-in, that would be great. > > --Jason Hi Jason, here it is, built

Re: [Mesa-dev] [PATCH 05/13] nouveau: Enable EXT_texture_env_dot3 on NV10 and NV20

2016-08-28 Thread Ilia Mirkin
On Sun, Aug 28, 2016 at 9:05 PM, Ian Romanick wrote: > On 08/28/2016 08:56 AM, Ilia Mirkin wrote: >> FWIW this fails for GL_DOT3_RGBA_EXT but works for GL_DOT3_RGB_EXT >> [according to glean's texCombine test]. (I suspect the existing > > Looking at the test results... any

Re: [Mesa-dev] [Mesa-stable] [PATCH] main: add missing EXTRA_END in OES_sample_variables get check

2016-08-28 Thread Ian Romanick
Reviewed-by: Ian Romanick On 08/28/2016 04:22 PM, Ilia Mirkin wrote: > Fixes: 3002296cb68 (mesa: add GL_OES_shader_multisample_interpolation support) > Signed-off-by: Ilia Mirkin > Cc: > --- >

Re: [Mesa-dev] [PATCH 05/13] nouveau: Enable EXT_texture_env_dot3 on NV10 and NV20

2016-08-28 Thread Ian Romanick
On 08/28/2016 08:56 AM, Ilia Mirkin wrote: > FWIW this fails for GL_DOT3_RGBA_EXT but works for GL_DOT3_RGB_EXT > [according to glean's texCombine test]. (I suspect the existing Looking at the test results... any idea what it's actually doing? Ignoring alpha and using 1.0? Using garbage? Other?

Re: [Mesa-dev] [PATCH 1/4] mesa: add scaffolding for OES/EXT_primitive_bounding_box

2016-08-28 Thread Ian Romanick
Series is Reviewed-by: Ian Romanick On 08/28/2016 11:32 AM, Ilia Mirkin wrote: > Signed-off-by: Ilia Mirkin > --- > src/compiler/glsl/glsl_parser_extras.cpp | 2 ++ > src/compiler/glsl/glsl_parser_extras.h | 4 +++ >

Re: [Mesa-dev] [PATCH 1/2] compiler: add printable values for cull distance varyings.

2016-08-28 Thread Edward O'Callaghan
Patches 1&2 are, Reviewed-by: Edward O'Callaghan On 08/29/2016 10:22 AM, Dave Airlie wrote: > From: Dave Airlie > > We need these for spir-v/nir shaders. > > Signed-off-by: Dave Airlie > --- > src/compiler/shader_enums.c |

[Mesa-dev] [PATCH 2/2] spirv: translate cull distance semantic.

2016-08-28 Thread Dave Airlie
From: Dave Airlie This just translates to the correct cull distance slot. Signed-off-by: Dave Airlie --- src/compiler/spirv/vtn_variables.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/compiler/spirv/vtn_variables.c

[Mesa-dev] [PATCH 1/2] compiler: add printable values for cull distance varyings.

2016-08-28 Thread Dave Airlie
From: Dave Airlie We need these for spir-v/nir shaders. Signed-off-by: Dave Airlie --- src/compiler/shader_enums.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/compiler/shader_enums.c b/src/compiler/shader_enums.c index 00261d1..97c5b30

Re: [Mesa-dev] [PATCH] radeonsi: Don't use global variables for tess lds

2016-08-28 Thread Edward O'Callaghan
Missing Signoff-by line but otherwise with that fix, Reviewed-By: Edward O'Callaghan On 08/27/2016 05:52 AM, Tom Stellard wrote: > We were allocating global variables for the maximum LDS size > which made the compiler think we were using all of LDS, which > isn't

Re: [Mesa-dev] [PATCH] st/clover: Define __OPENCL_VERSION__ on the device side

2016-08-28 Thread Edward O'Callaghan
On 08/29/2016 12:42 AM, Niels Ole Salscheider wrote: > This is required by the OpenCL standard. > > Signed-off-by: Niels Ole Salscheider Reviewed-by: Edward O'Callaghan > --- >

Re: [Mesa-dev] [PATCH] mesa: add EXT_texture_cube_map_array support

2016-08-28 Thread Ian Romanick
I had intended to do this, but I forgot. Thanks. Reviewed-by: Ian Romanick On 08/27/2016 03:05 PM, Ilia Mirkin wrote: > This is identical to OES_texture_cube_map_array support. dEQP has tests > which use this extension. Also it is part of AEP. > > Signed-off-by: Ilia

Re: [Mesa-dev] [PATCH] mesa: remove OES_shader_io_blocks enable

2016-08-28 Thread Ian Romanick
Reviewed-by: Ian Romanick On 08/27/2016 02:20 PM, Ilia Mirkin wrote: > This extension should just be available whenever ES 3.1 is available. > With the new extension verification infrastructure, it will only be > enable-able on a #version 310 es shader, rendering the

[Mesa-dev] [PATCH] main: add missing EXTRA_END in OES_sample_variables get check

2016-08-28 Thread Ilia Mirkin
Fixes: 3002296cb68 (mesa: add GL_OES_shader_multisample_interpolation support) Signed-off-by: Ilia Mirkin Cc: --- src/mesa/main/get.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/main/get.c b/src/mesa/main/get.c index

Re: [Mesa-dev] [PATCH] main: use KHR_blend_equation_advanced enable for ES 3.2 availability

2016-08-28 Thread Jason Ekstrand
Rb On Aug 28, 2016 11:40 AM, "Ilia Mirkin" wrote: > Signed-off-by: Ilia Mirkin > --- > src/mesa/main/version.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/mesa/main/version.c b/src/mesa/main/version.c > index

Re: [Mesa-dev] [PATCH 2/3] mesa: Handle OES_texture_view tokens

2016-08-28 Thread Chris Forbes
This patch isn't right. These enum values are the same as the desktop version, so your new cases will never actually be used. On Mon, Aug 29, 2016 at 2:24 AM, Francesco Ansanelli wrote: > Signed-off-by: Francesco Ansanelli > --- >

Re: [Mesa-dev] [PATCH 2/2] clover: Use device cap to query pointer size instead of hardcoded 32bits

2016-08-28 Thread Francisco Jerez
Jan Vesely writes: > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=97513 > Signed-off-by: Jan Vesely Reviewed-by: Francisco Jerez > --- > src/gallium/state_trackers/clover/api/device.cpp | 2 +- >

[Mesa-dev] [PATCH] main: use KHR_blend_equation_advanced enable for ES 3.2 availability

2016-08-28 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin --- src/mesa/main/version.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/main/version.c b/src/mesa/main/version.c index 2aa96d5..cfc1638 100644 --- a/src/mesa/main/version.c +++ b/src/mesa/main/version.c @@ -530,7

[Mesa-dev] [PATCH 2/4] mesa: add support for GL_PRIMITIVE_BOUNDING_BOX storage and query

2016-08-28 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin --- src/mesa/main/bbox.c | 19 +++ src/mesa/main/get.c | 28 src/mesa/main/get_hash_params.py | 3 +++ src/mesa/main/mtypes.h | 7 +++ 4 files changed, 57

[Mesa-dev] [PATCH 1/4] mesa: add scaffolding for OES/EXT_primitive_bounding_box

2016-08-28 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin --- src/compiler/glsl/glsl_parser_extras.cpp | 2 ++ src/compiler/glsl/glsl_parser_extras.h | 4 +++ src/mapi/glapi/gen/es_EXT.xml| 49 src/mapi/glapi/gen/gl_genexec.py | 1 +

[Mesa-dev] [PATCH 4/4] st/mesa: provide the null implementation of bounding box outputs in tcs

2016-08-28 Thread Ilia Mirkin
Until hardware appears (in a gallium driver) that can make use of the TCS-outputted gl_BoundingBox, we just request that the variable gets assigned as a regular patch variable. Signed-off-by: Ilia Mirkin --- Note that this passes all "*bounding_box*" tests in

[Mesa-dev] [PATCH 3/4] glsl: add gl_BoundingBox and associated varying slots

2016-08-28 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin --- src/compiler/glsl/builtin_variables.cpp | 12 src/compiler/glsl/ir_set_program_inouts.cpp | 4 +++- src/compiler/shader_enums.c | 2 ++ src/compiler/shader_enums.h | 4

[Mesa-dev] [PATCH v2 1/2] gallium: add cap to export device pointer size

2016-08-28 Thread Jan Vesely
v2: document the new cap Signed-off-by: Jan Vesely --- src/gallium/docs/source/screen.rst | 1 + src/gallium/drivers/ilo/ilo_screen.c | 6 ++ src/gallium/drivers/nouveau/nv50/nv50_screen.c | 2 ++ src/gallium/drivers/nouveau/nvc0/nvc0_screen.c |

Re: [Mesa-dev] [PATCH 1/2] gallium: add cap to export device pointer size

2016-08-28 Thread Jan Vesely
On Sun, 2016-08-28 at 13:16 -0400, Ilia Mirkin wrote: > Please add documentation for this new cap in > src/gallium/docs/source/screen.rst . What is this supposed to > represent btw? All G80+ GPUs operate in a 40-bit virtual address > space, but pre-fermi there's no ability to get a compute shader

Re: [Mesa-dev] [PATCH] Update Khronos-supplied headers to r33100

2016-08-28 Thread Ilia Mirkin
On Sun, Aug 28, 2016 at 1:10 PM, Ilia Mirkin wrote: > As retrieved from opengl.org and khronos.org. Maintained the APPLE hack > in GL/glext.h manually. Added gl32.h. > > Signed-off-by: Ilia Mirkin > --- > > I want this for OES_viewport_array, as well

Re: [Mesa-dev] [PATCH 1/2] gallium: add cap to export device pointer size

2016-08-28 Thread Ilia Mirkin
Please add documentation for this new cap in src/gallium/docs/source/screen.rst . What is this supposed to represent btw? All G80+ GPUs operate in a 40-bit virtual address space, but pre-fermi there's no ability to get a compute shader to access more than a 32-bit window at a time (actually 16

[Mesa-dev] [PATCH 2/2] clover: Use device cap to query pointer size instead of hardcoded 32bits

2016-08-28 Thread Jan Vesely
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=97513 Signed-off-by: Jan Vesely --- src/gallium/state_trackers/clover/api/device.cpp | 2 +- src/gallium/state_trackers/clover/core/device.cpp | 6 ++ src/gallium/state_trackers/clover/core/device.hpp | 1 + 3

[Mesa-dev] [PATCH 1/2] gallium: add cap to export device pointer size

2016-08-28 Thread Jan Vesely
Signed-off-by: Jan Vesely --- src/gallium/drivers/ilo/ilo_screen.c | 6 ++ src/gallium/drivers/nouveau/nv50/nv50_screen.c | 2 ++ src/gallium/drivers/nouveau/nvc0/nvc0_screen.c | 2 ++ src/gallium/drivers/radeon/r600_pipe_common.c | 8

Re: [Mesa-dev] [PATCH 05/13] nouveau: Enable EXT_texture_env_dot3 on NV10 and NV20

2016-08-28 Thread Ilia Mirkin
FWIW this fails for GL_DOT3_RGBA_EXT but works for GL_DOT3_RGB_EXT [according to glean's texCombine test]. (I suspect the existing GL_DOT3_RGBA/RGB had a similar behavior.) I'm testing in a slightly unsupported environment - the NV25 graph class running on a NV34 (GeForce FX 5200), but I think

[Mesa-dev] [Bug 97516] GLX_OML_swap_method not fully supported

2016-08-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97516 Fabian Maurer changed: What|Removed |Added CC||dark.shad...@web.de

[Mesa-dev] [Bug 97516] GLX_OML_swap_method not fully supported

2016-08-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97516 Bug ID: 97516 Summary: GLX_OML_swap_method not fully supported Product: Mesa Version: git Hardware: x86-64 (AMD64) OS: Linux (All) Status: NEW Severity:

[Mesa-dev] [PATCH] st/clover: Define __OPENCL_VERSION__ on the device side

2016-08-28 Thread Niels Ole Salscheider
This is required by the OpenCL standard. Signed-off-by: Niels Ole Salscheider --- src/gallium/state_trackers/clover/llvm/invocation.cpp | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/gallium/state_trackers/clover/llvm/invocation.cpp

Re: [Mesa-dev] GL_OES_texture_view RFC

2016-08-28 Thread Ilia Mirkin
The most important part of this exercise is to get tests up and running. Unfortunately there are none in dEQP. I think the simplest path would be to get the existing ones to build as gles31 as well as GL. Check the blend func extended tests to see how that is done. Overall feedback: - are you

[Mesa-dev] GL_OES_texture_view RFC

2016-08-28 Thread Francesco Ansanelli
Hi list, I tried to figure how this extension could be hooked-up. I fear last patch is a bit an hack because we may want to add also the EXT one... But this could be figured later. In any case, please review. Cheers, Francesco ___ mesa-dev mailing

[Mesa-dev] [PATCH 3/3] mesa: implement GL_OES_texture_view

2016-08-28 Thread Francesco Ansanelli
XXX still need to figure how to treat the removed VIEW_CLASS* and formats. Signed-off-by: Francesco Ansanelli --- src/mesa/main/textureview.c | 69 +-- 1 file changed, 41 insertions(+), 28 deletions(-) diff --git

[Mesa-dev] [PATCH 1/3] glapi: add GL_OES_texture_view

2016-08-28 Thread Francesco Ansanelli
Signed-off-by: Francesco Ansanelli --- src/mapi/glapi/gen/es_EXT.xml | 15 +++ src/mesa/main/extensions_table.h|1 + src/mesa/main/mtypes.h |1 + src/mesa/main/tests/dispatch_sanity.cpp |3 +++ 4 files changed, 20

[Mesa-dev] [PATCH 2/3] mesa: Handle OES_texture_view tokens

2016-08-28 Thread Francesco Ansanelli
Signed-off-by: Francesco Ansanelli --- src/mesa/main/texparam.c | 48 ++ 1 file changed, 48 insertions(+) diff --git a/src/mesa/main/texparam.c b/src/mesa/main/texparam.c index bdd3fcb..4dd97b1 100644 ---

Re: [Mesa-dev] [PATCH 1/2] r600g: Avoid duplicated initialization of TGSI_OPCODE_DFMA

2016-08-28 Thread Rhys Kidd
On Saturday, August 27, 2016, Jan Vesely wrote: > On Sat, 2016-08-27 at 12:05 -0400, Rhys Kidd wrote: > > As reported by Clang, TGSI_OPCODE_DFMA (defined magic number 118) is > > currently initialized twice for Cayman and Evergreen. > > When Jan Vesely added double

[Mesa-dev] [Bug 97260] [bisected] R9 290 low performance in Linux 4.7

2016-08-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97260 --- Comment #34 from nadro-li...@wp.pl --- Sorry for a wrong information in my previous post, it looks like I had problems with 'forced vblank_mode to 1' in some apps. I downloaded fresh kernel 4.8rc3 from Ubuntu Kernel PPA + Mesa from Padoka PPA

[Mesa-dev] [Bug 97260] [bisected] R9 290 low performance in Linux 4.7

2016-08-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97260 --- Comment #33 from nadro-li...@wp.pl --- I didn't test mesa with provided patch, but I always run games with vblank_mode=0 (most of the time via game menu options -> Vsync disabled) and DRI3 enabled, so it looks like provided mesa patch will