Re: [Mesa-dev] [PATCH 3/3] anv/x11: Destroy Present event context when destroying swapchain v2

Seems reasonable. I think you know more of what you're doing here than I do anyway. Acked-by: Jason Ekstrand On Fri, Jul 29, 2016 at 2:52 AM, Michel Dänzer wrote: > From: Michel Dänzer > > Without this, the X server may

Re: [Mesa-dev] [PATCH] loader/dri3: Overhaul dri3_update_num_back

On Wed, Aug 31, 2016 at 7:00 PM, Michel Dänzer wrote: > On 31/08/16 11:21 PM, Jason Ekstrand wrote: > > On Aug 19, 2016 12:07 AM, "Michel Dänzer" > > wrote: > >> From: Michel Dänzer >

Re: [Mesa-dev] [PATCH 03/12] isl/gen8+: Allow 3D auxiliary surfaces

On Wed, Aug 31, 2016 at 05:41:24PM -0700, Jason Ekstrand wrote: >On Wed, Aug 31, 2016 at 8:17 AM, Topi Pohjolainen ><[1]topi.pohjolai...@intel.com> wrote: > > Otherwise once mcs buffer gets allocated without delay for > lossless compression (same as we do for msaa), assert

Re: [Mesa-dev] [PATCH 02/12] i965/rbc: Set aux surface unconditionally for sampling engine

On Wed, Aug 31, 2016 at 05:39:07PM -0700, Jason Ekstrand wrote: >On Wed, Aug 31, 2016 at 8:17 AM, Topi Pohjolainen ><[1]topi.pohjolai...@intel.com> wrote: > > Once mcs buffer gets allocated without delay for lossless > compression (same as we do for msaa), one gets regression

Re: [Mesa-dev] [PATCH 5/7] mesa: introduce MS variants of line width min/max/granularity

On Wed, Aug 31, 2016 at 11:02 PM, Ilia Mirkin wrote: > On Wed, Aug 31, 2016 at 10:32 PM, Ian Romanick wrote: >> On 08/28/2016 07:10 PM, Ilia Mirkin wrote: >>> These are exposed in ES 3.2. However this moves all st/mesa to clamping >>> on the MS

[Mesa-dev] [PATCH 08/12] isl: Make MSAA pixel scaling function public

This will be used in the next commit. Signed-off-by: Nanley Chery --- src/intel/isl/isl.c | 2 +- src/intel/isl/isl.h | 4 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/src/intel/isl/isl.c b/src/intel/isl/isl.c index 1664dbf..811760a 100644 ---

[Mesa-dev] [PATCH 01/12] isl: Correct a comment in the isl_format enum

HiZ is not a color surface, but an auxiliary depth surface. Signed-off-by: Nanley Chery --- src/intel/isl/isl.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/intel/isl/isl.h b/src/intel/isl/isl.h index 5e56f28..507b342 100644 ---

[Mesa-dev] [PATCH 06/12] anv: Move BindImageMemory to anv_image.c

From: Jason Ekstrand Signed-off-by: Nanley Chery --- src/intel/vulkan/anv_device.c | 20 src/intel/vulkan/anv_image.c | 20 2 files changed, 20 insertions(+), 20 deletions(-) diff --git

[Mesa-dev] [PATCH 07/12] anv/image: Memset hiz surfaces to 0 when binding memory

From: Jason Ekstrand Nanley Chery (amend): - Change memset value from 0xff to 0 (a defined value for HiZ). Signed-off-by: Nanley Chery --- src/intel/vulkan/anv_image.c | 18 +- 1 file changed, 17 insertions(+), 1 deletion(-)

[Mesa-dev] [PATCH 09/12] anv/cmd_buffer: Add code for performing HZ operations

From: Jason Ekstrand Nanley Chery: (rebase) - Resolve conflicts with the new anv_batch_emit macro (amend) - Update commit title - Combine all HZ operations into one function - Add code for performing HiZ resolve operations - Add proper stencil and multisampling

[Mesa-dev] [PATCH 05/12] anv: Allocate hiz surface

From: Chad Versace Nanley Chery: (rebase) - Use isl_surf_get_hiz_surf() (amend) - Only add a HiZ surface onto a depth/stencil attachment - Add comment above HiZ surface addition - Hide HiZ behind INTEL_VK_HIZ prior to BDW - Remove DISABLE_AUX_BIT instead of

[Mesa-dev] [PATCH 02/12] isl: Update isl_surf_get_hiz_surf()

Modify extents and dimensions to match the PRMs more closely. Along with being able to create the correct 3D surface this enables us to avoid working with multisampled compressed textures. Signed-off-by: Nanley Chery --- src/intel/isl/isl.c | 39

[Mesa-dev] [PATCH 12/12] anv/TODO: Update the HiZ task

Signed-off-by: Nanley Chery --- src/intel/vulkan/TODO | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/intel/vulkan/TODO b/src/intel/vulkan/TODO index 8fac370..ef2408d 100644 --- a/src/intel/vulkan/TODO +++ b/src/intel/vulkan/TODO @@ -19,7 +19,7

[Mesa-dev] [PATCH 00/12] anv: Implement HiZ for simple render passes

This series enables Hierarchical depth buffer rendering and fast depth clears for render passes with a single subpass running on platforms BDW+. Platforms pre-BDW can test this feature with an environment variable. The FPS of some demos are roughly estimated to increase by as much as ~50% on a SKL

[Mesa-dev] [PATCH 03/12] anv: Add anv_image::hiz_surface

From: Chad Versace Unused. Nanley Chery (amend): - Remove wip! tag Signed-off-by: Nanley Chery --- src/intel/vulkan/anv_private.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/intel/vulkan/anv_private.h

[Mesa-dev] [PATCH 11/12] genX/cmd_buffer: Enable fast depth clears

Provides an FPS increase of ~30% on the Sascha triangle and multisampling demos. Clears that happen within a render pass via vkCmdClearAttachments are safe even if the clear color changes. This is because the meta implementation does not use LOAD_OP_CLEAR which avoids any conflicts with

[Mesa-dev] [PATCH 10/12] genX/cmd_buffer: Enable rendering to HiZ

From: Chad Versace Nanley Chery: (rebase) - Resolve conflicts with new anv_batch_emit macro (amend) - Remove wip! tag and handle a QPitch TODO - Emit 3DSTATE_HIER_DEPTH_BUFFER on pre-BDW systems - Only use HiZ for single-subpass renderpasses - Emit the HiZ

[Mesa-dev] [PATCH 04/12] anv: Add func anv_image_has_hiz()

From: Chad Versace Nanley Chery (amend): - Remove wip! tag Signed-off-by: Nanley Chery --- src/intel/vulkan/anv_private.h | 10 ++ 1 file changed, 10 insertions(+) diff --git a/src/intel/vulkan/anv_private.h

Re: [Mesa-dev] [PATCH 2/2] st/vdapu: use lanczos filter for scaling v4

On 31/08/16 06:53 PM, Nayan Deshmukh wrote: > Hi Christian, > > You missed a few things in the merge. I will send in the updated patch. > > I looked at the code in vl_winsys.c and vl_winsys3.c and also > at the code in presentation.c where delayed rendering is used. I was trying > to compile

Re: [Mesa-dev] [PATCH 5/7] mesa: introduce MS variants of line width min/max/granularity

On Wed, Aug 31, 2016 at 10:32 PM, Ian Romanick wrote: > On 08/28/2016 07:10 PM, Ilia Mirkin wrote: >> These are exposed in ES 3.2. However this moves all st/mesa to clamping >> on the MS variants. But for now the MS variants are initialized to the >> AA values. > > Do you

Re: [Mesa-dev] [PATCH 4/7] glsl: add core plumbing for GL_ANDROID_extension_pack_es31a

On Wed, Aug 31, 2016 at 10:28 PM, Ian Romanick wrote: > I'm not sure how I feel about this change. I had also been thinking > about adding AEP support after the rest of 3.2 was complete. I had > imagined that adding it would look something like adding code to >

Re: [Mesa-dev] [PATCH 7/7] mesa: introduce glPrimitiveBoundingBoxARB entrypoint

This patch is Reviewed-by: Ian Romanick On 08/28/2016 07:10 PM, Ilia Mirkin wrote: > This requires a bit of rejiggering, since normally ES entrypoints alias > core ones, not vice-versa. > > Signed-off-by: Ilia Mirkin > --- >

Re: [Mesa-dev] [PATCH 5/7] mesa: introduce MS variants of line width min/max/granularity

On 08/28/2016 07:10 PM, Ilia Mirkin wrote: > These are exposed in ES 3.2. However this moves all st/mesa to clamping > on the MS variants. But for now the MS variants are initialized to the > AA values. Do you know where these are in the spec? I'm not familiar with these. > Signed-off-by: Ilia

Re: [Mesa-dev] [PATCH 4/7] glsl: add core plumbing for GL_ANDROID_extension_pack_es31a

I'm not sure how I feel about this change. I had also been thinking about adding AEP support after the rest of 3.2 was complete. I had imagined that adding it would look something like adding code to _mesa_glsl_process_extension that would call _mesa_glsl_process_extension for each of the

Re: [Mesa-dev] [PATCH 6/7] mesa: add a GLES3.2 enums section, and expose new MS line width params

On 08/29/2016 11:24 AM, Ilia Mirkin wrote: > On Sun, Aug 28, 2016 at 10:10 PM, Ilia Mirkin wrote: >> This also exposes them for ARB_ES3_2_compatibility. >> >> Signed-off-by: Ilia Mirkin >> --- >> src/mesa/main/context.h | 10 ++ >>

Re: [Mesa-dev] [PATCH] glsl: Only force varyings to be flat when varying packing.

On Wed, 2016-08-31 at 16:40 -0700, Kenneth Graunke wrote: > Varying packing would like to mark certain variables as flat. > This works as long as both sides of the interfaces are changed > accordingly. > > For tessellation shaders, we disable varying packing, so this > requirement doesn't exist.  

Re: [Mesa-dev] [PATCH] loader/dri3: Overhaul dri3_update_num_back

On 31/08/16 11:21 PM, Jason Ekstrand wrote: > On Aug 19, 2016 12:07 AM, "Michel Dänzer" > wrote: >> From: Michel Dänzer > >> >> Always use 3 buffers when flipping. With only 2 buffers, we have

Re: [Mesa-dev] [PATCH 3/7] glsl: expose max atomic counter/buffer consts for tess in ES 3.2

Patches 1 through 3 are Reviewed-by: Ian Romanick On 08/28/2016 07:10 PM, Ilia Mirkin wrote: > Curiously OES/EXT_tessellation_shader leave these out, while ES 3.2 adds > them in. > > Signed-off-by: Ilia Mirkin > --- >

[Mesa-dev] [Bug 97549] [SNB, BXT] up to 40% perf drop from "loader/dri3: Overhaul dri3_update_num_back" commit

https://bugs.freedesktop.org/show_bug.cgi?id=97549 --- Comment #1 from Michel Dänzer --- Please attach the corresponding Xorg log file. It would also be interesting to know which path dri3_update_num_back takes before and after the change for each affected test. -- You are

Re: [Mesa-dev] [PATCH 03/12] isl/gen8+: Allow 3D auxiliary surfaces

On Wed, Aug 31, 2016 at 8:17 AM, Topi Pohjolainen < topi.pohjolai...@intel.com> wrote: > Otherwise once mcs buffer gets allocated without delay for > lossless compression (same as we do for msaa), assert starts > to fire in piglit case: tex3d. The test uses depth of one > which is in fact

Re: [Mesa-dev] [PATCH 02/12] i965/rbc: Set aux surface unconditionally for sampling engine

On Wed, Aug 31, 2016 at 8:17 AM, Topi Pohjolainen < topi.pohjolai...@intel.com> wrote: > Once mcs buffer gets allocated without delay for lossless > compression (same as we do for msaa), one gets regression in: > > GL45-CTS.texture_barrier_ARB.same-texel-rw > > Setting the auxiliary surface for

Re: [Mesa-dev] [PATCH mesa v2] Introduce .editorconfig

Jose Fonseca writes: > Thanks for the update. > > Reviewed-by: Jose Fonseca > > If you need and there's no outstanding objections, I can push this > change for you. I've gone ahead and pushed it now. Seems like we've had plenty of discussion time,

[Mesa-dev] [PATCH] glsl: Only force varyings to be flat when varying packing.

Varying packing would like to mark certain variables as flat. This works as long as both sides of the interfaces are changed accordingly. For tessellation shaders, we disable varying packing, so this requirement doesn't exist. Several CTS tests use separable TCS and TES programs, and this ends

Re: [Mesa-dev] [PATCH 26/33] anv: Use blorp to implement VkBlitImage

On Wed, Aug 31, 2016 at 2:22 PM, Jason Ekstrand wrote: > --- > src/intel/vulkan/Makefile.sources | 1 - > src/intel/vulkan/anv_blorp.c | 144 > src/intel/vulkan/anv_meta.c | 7 - > src/intel/vulkan/anv_meta.h | 3 - >

Re: [Mesa-dev] [PATCH 6/6] nvc0: reduce the initial code segment size to 512KB

This all seems reasonable. Series is Reviewed-by: Ilia Mirkin On Wed, Aug 31, 2016 at 4:52 PM, Samuel Pitoiset wrote: > Signed-off-by: Samuel Pitoiset > --- > src/gallium/drivers/nouveau/nvc0/nvc0_screen.c | 2 +- >

Re: [Mesa-dev] [PATCH 3/6] nvc0: add nvc0_screen_resize_text_area() helper

On Wed, Aug 31, 2016 at 4:52 PM, Samuel Pitoiset wrote: > This function will be helpful for resizing the code segment > area when we need to evict all shaders. > > Signed-off-by: Samuel Pitoiset > --- >

Re: [Mesa-dev] [PATCH 3/6] nvc0: add nvc0_screen_resize_text_area() helper

On 08/31/2016 11:31 PM, Ilia Mirkin wrote: On Wed, Aug 31, 2016 at 4:52 PM, Samuel Pitoiset wrote: This function will be helpful for resizing the code segment area when we need to evict all shaders. Signed-off-by: Samuel Pitoiset ---

Re: [Mesa-dev] [PATCH 3/6] nvc0: add nvc0_screen_resize_text_area() helper

On Wed, Aug 31, 2016 at 4:52 PM, Samuel Pitoiset wrote: > This function will be helpful for resizing the code segment > area when we need to evict all shaders. > > Signed-off-by: Samuel Pitoiset > --- >

[Mesa-dev] [PATCH 21/33] anv/pipeline: Roll compute_urb_partition into emit_urb_setup

--- src/intel/vulkan/anv_pipeline.c | 142 - src/intel/vulkan/anv_private.h| 3 - src/intel/vulkan/genX_pipeline_util.h | 146 -- 3 files changed, 138 insertions(+), 153 deletions(-) diff --git

[Mesa-dev] [PATCH 33/33] anv: Use blorp for doing MSAA resolves

--- src/intel/vulkan/Makefile.sources | 1 - src/intel/vulkan/anv_blorp.c| 121 + src/intel/vulkan/anv_meta.c | 7 - src/intel/vulkan/anv_meta.h | 3 - src/intel/vulkan/anv_meta_resolve.c | 870 5 files changed, 121

[Mesa-dev] [PATCH 28/33] anv: Use blorp for CopyBufferToImage

--- src/intel/vulkan/anv_blorp.c | 16 + src/intel/vulkan/anv_meta_copy.c | 125 --- 2 files changed, 16 insertions(+), 125 deletions(-) diff --git a/src/intel/vulkan/anv_blorp.c b/src/intel/vulkan/anv_blorp.c index a838b55..5fa6699 100644 ---

[Mesa-dev] [PATCH 26/33] anv: Use blorp to implement VkBlitImage

--- src/intel/vulkan/Makefile.sources | 1 - src/intel/vulkan/anv_blorp.c | 144 src/intel/vulkan/anv_meta.c | 7 - src/intel/vulkan/anv_meta.h | 3 - src/intel/vulkan/anv_meta_blit.c | 739 -- 5 files changed, 144

[Mesa-dev] [PATCH 30/33] anv: Use blorp for CopyBuffer and UpdateBuffer

--- src/intel/vulkan/Makefile.sources | 1 - src/intel/vulkan/anv_blorp.c | 184 ++ src/intel/vulkan/anv_meta_copy.c | 180 - 3 files changed, 184 insertions(+), 181 deletions(-) delete mode 100644

[Mesa-dev] [PATCH 16/33] intel/blorp: Add support for clearing R9G9B9E5 surfaces

--- src/intel/blorp/blorp_clear.c | 8 1 file changed, 8 insertions(+) diff --git a/src/intel/blorp/blorp_clear.c b/src/intel/blorp/blorp_clear.c index 831c8ed..b0be50b 100644 --- a/src/intel/blorp/blorp_clear.c +++ b/src/intel/blorp/blorp_clear.c @@ -23,6 +23,9 @@ #include

[Mesa-dev] [PATCH 19/33] intel/blorp: Rework alloc_binding_table

The original blorp_alloc_binding_table helper was supposed to return the binding table offset and map along with the surface state maps. This isn't quite what we want, however. What we really want is the binding table offsets, surface state offsets, and surface state maps. In the GL driver, the

[Mesa-dev] [PATCH 32/33] anv: Use blorp for ClearColorImage

--- src/intel/vulkan/anv_blorp.c | 60 +++ src/intel/vulkan/anv_meta_clear.c | 21 -- 2 files changed, 60 insertions(+), 21 deletions(-) diff --git a/src/intel/vulkan/anv_blorp.c b/src/intel/vulkan/anv_blorp.c index e2b6672..bd4638d 100644 ---

[Mesa-dev] [PATCH 31/33] anv: Delete meta_blit2d

Everything that we were once using the blit2d framework for is now done with blorp. --- src/intel/vulkan/Makefile.sources |1 - src/intel/vulkan/anv_meta.c|7 - src/intel/vulkan/anv_meta.h| 38 - src/intel/vulkan/anv_meta_blit2d.c | 1544

[Mesa-dev] [PATCH 22/33] anv: Generalize emit_urb_setup

--- src/intel/vulkan/anv_genX.h | 6 src/intel/vulkan/genX_pipeline_util.h | 59 +++ 2 files changed, 45 insertions(+), 20 deletions(-) diff --git a/src/intel/vulkan/anv_genX.h b/src/intel/vulkan/anv_genX.h index bfec1ae..ccf4357 100644 ---

[Mesa-dev] [PATCH 03/33] intel/blorp: Take a destination swizzle in blorp_blit

--- src/intel/blorp/blorp.h | 2 +- src/intel/blorp/blorp_blit.c | 3 ++- src/mesa/drivers/dri/i965/brw_blorp.c | 1 + 3 files changed, 4 insertions(+), 2 deletions(-) diff --git a/src/intel/blorp/blorp.h b/src/intel/blorp/blorp.h index c06e1cb..c1e93fd 100644 ---

[Mesa-dev] [PATCH 17/33] intel/blorp: Make color_write_disable const and optional

--- src/intel/blorp/blorp.h | 2 +- src/intel/blorp/blorp_clear.c | 12 +++- 2 files changed, 8 insertions(+), 6 deletions(-) diff --git a/src/intel/blorp/blorp.h b/src/intel/blorp/blorp.h index 6574124..6242530 100644 --- a/src/intel/blorp/blorp.h +++ b/src/intel/blorp/blorp.h @@

[Mesa-dev] [PATCH 27/33] anv: Use blorp for CopyImageToBuffer

--- src/intel/vulkan/anv_blorp.c | 134 +++ src/intel/vulkan/anv_meta_copy.c | 16 - 2 files changed, 134 insertions(+), 16 deletions(-) diff --git a/src/intel/vulkan/anv_blorp.c b/src/intel/vulkan/anv_blorp.c index 5d715fc..a838b55 100644 ---

[Mesa-dev] [PATCH 02/33] intel/blorp: Take an isl_swizzle instead of a SWIZZLE

--- src/intel/blorp/blorp.h | 2 +- src/intel/blorp/blorp_blit.c | 29 ++--- src/mesa/drivers/dri/i965/brw_blorp.c | 28 +++- 3 files changed, 30 insertions(+), 29 deletions(-) diff --git a/src/intel/blorp/blorp.h

[Mesa-dev] [PATCH 25/33] anv: Make image_get_surface_for_aspect_mask const

--- src/intel/vulkan/anv_image.c | 7 --- src/intel/vulkan/anv_meta_copy.c | 4 ++-- src/intel/vulkan/anv_private.h | 4 ++-- 3 files changed, 8 insertions(+), 7 deletions(-) diff --git a/src/intel/vulkan/anv_image.c b/src/intel/vulkan/anv_image.c index 63b8c86..3ab11e7 100644 ---

[Mesa-dev] [PATCH 18/33] intel/blorp: Add a swizzle parameter to blorp_clear

While we're here, we also re-arrange the parameters to better match the parameter order of blorp_blit. --- src/intel/blorp/blorp.h | 3 ++- src/intel/blorp/blorp_clear.c | 4 +++- src/mesa/drivers/dri/i965/brw_blorp.c | 3 ++- 3 files changed, 7 insertions(+), 3 deletions(-)

[Mesa-dev] [PATCH 29/33] anv: Use blorp for CopyImage

--- src/intel/vulkan/anv_blorp.c | 67 + src/intel/vulkan/anv_meta_copy.c | 158 --- 2 files changed, 67 insertions(+), 158 deletions(-) diff --git a/src/intel/vulkan/anv_blorp.c b/src/intel/vulkan/anv_blorp.c index 5fa6699..89ff3b3 100644

[Mesa-dev] [PATCH 13/33] intel/blorp: Pull the guts of blorp_blit into a helper

--- src/intel/blorp/blorp_blit.c | 277 +++ 1 file changed, 147 insertions(+), 130 deletions(-) diff --git a/src/intel/blorp/blorp_blit.c b/src/intel/blorp/blorp_blit.c index a8b38de..3ab39a3 100644 --- a/src/intel/blorp/blorp_blit.c +++

[Mesa-dev] [PATCH 06/33] intel/blorp: Fix the early return condition in convert_to_single_slice

The convert_to_single_slice operation is *mostly* idempotent. The only non-repeatable thing it does is that, when it sets the intratile offset fields, it just overwrites them instead of doing a += operation. This is supposed to be ok because we have an early return at the top that should make it

[Mesa-dev] [PATCH 24/33] anv: Add initial blorp support

--- src/intel/vulkan/Makefile.am | 1 + src/intel/vulkan/Makefile.sources | 5 + src/intel/vulkan/anv_blorp.c | 120 + src/intel/vulkan/anv_device.c | 4 + src/intel/vulkan/anv_genX.h| 3 + src/intel/vulkan/anv_private.h | 6 +

[Mesa-dev] [PATCH 20/33] intel/blorp: Use #defines for all __gen_ helpers

This allows us to #undef them later if we don't want them to persist --- src/intel/blorp/blorp_genX_exec.h | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/src/intel/blorp/blorp_genX_exec.h b/src/intel/blorp/blorp_genX_exec.h index ff89865..71beadc 100644 ---

[Mesa-dev] [PATCH 11/33] intel/blorp: Use fake_interleaved_msaa in retile_w_to_y

--- src/intel/blorp/blorp_blit.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/intel/blorp/blorp_blit.c b/src/intel/blorp/blorp_blit.c index 05fad8f..2838a26 100644 --- a/src/intel/blorp/blorp_blit.c +++ b/src/intel/blorp/blorp_blit.c @@ -1342,9 +1342,7 @@

[Mesa-dev] [PATCH 15/33] intel/blorp: Add support for RGB destinations in copies

--- src/intel/blorp/blorp_blit.c | 61 src/intel/blorp/blorp_priv.h | 6 + 2 files changed, 67 insertions(+) diff --git a/src/intel/blorp/blorp_blit.c b/src/intel/blorp/blorp_blit.c index 42a502c..1790f0b 100644 --- a/src/intel/blorp/blorp_blit.c

[Mesa-dev] [PATCH 04/33] intel/blorp: Don't assume R8_UINT in convert_to_single_slice

We're going to use it for more than just stencil textures --- src/intel/blorp/blorp_blit.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/intel/blorp/blorp_blit.c b/src/intel/blorp/blorp_blit.c index e59b81e..181dfeea 100644 --- a/src/intel/blorp/blorp_blit.c +++

[Mesa-dev] [PATCH 12/33] intel/blorp: Stop using the X/YOffset field of RENDER_SURFACE_STATE

While it can be useful, the field has substantial limtations. In particular, the bittom 2 or 3 bits is missing so your offset always has to be a multiple of 4 or 8. While surface alignments usually work out to make this ok, when you start trying to fake compressed surfaces as uncompressed (which

[Mesa-dev] [PATCH 23/33] intel/anv: Use #defines for all __gen_ helpers

This allows us to #undef them later if we don't want them to persist --- src/intel/vulkan/anv_private.h | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/src/intel/vulkan/anv_private.h b/src/intel/vulkan/anv_private.h index 805b3aa..5ef81d9 100644 ---

[Mesa-dev] [PATCH 07/33] intel/isl: Fix an assert in get_intratile_offset_sa

--- src/intel/isl/isl.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/intel/isl/isl.h b/src/intel/isl/isl.h index 1ed286f..aa923c0 100644 --- a/src/intel/isl/isl.h +++ b/src/intel/isl/isl.h @@ -1432,7 +1432,7 @@ isl_tiling_get_intratile_offset_sa(const struct isl_device

[Mesa-dev] [PATCH 09/33] intel/isl: Add a helper for getting the size of an interleaved pixel

--- src/intel/isl/isl.c | 22 +- src/intel/isl/isl.h | 3 +++ 2 files changed, 20 insertions(+), 5 deletions(-) diff --git a/src/intel/isl/isl.c b/src/intel/isl/isl.c index 1b76043..8e086b1 100644 --- a/src/intel/isl/isl.c +++ b/src/intel/isl/isl.c @@ -286,9 +286,8 @@

[Mesa-dev] [PATCH 00/33] anv: Use blorp for most blits and clears

This little (hah!) series does a bit more blorp reworking and then converts most of the Vulkan driver to using blorp for its blit and copy operations. As it currently stands, it adds a few cts "regresssions" which are really because the CTS makes assumptions about rounding in scaled blit

[Mesa-dev] [PATCH 05/33] intel/blorp: Use the surface format for computing offsets

If we use the view format, it may be an uncompressed view of a compressed image which throws things off. Since we're computing offsets of images, we want the actual surface offset anyway. --- src/intel/blorp/blorp_blit.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[Mesa-dev] [PATCH 14/33] intel/blorp: Add an entrypoint for doing bit-for-bit copies

--- src/intel/blorp/blorp.h | 10 src/intel/blorp/blorp_blit.c | 133 +++ 2 files changed, 143 insertions(+) diff --git a/src/intel/blorp/blorp.h b/src/intel/blorp/blorp.h index c1e93fd..6574124 100644 --- a/src/intel/blorp/blorp.h +++

[Mesa-dev] [PATCH 10/33] intel/blorp: Use isl_get_interleaved_msaa_px_size_sa

--- src/intel/blorp/blorp_blit.c | 34 ++ 1 file changed, 6 insertions(+), 28 deletions(-) diff --git a/src/intel/blorp/blorp_blit.c b/src/intel/blorp/blorp_blit.c index b5d8d2a..05fad8f 100644 --- a/src/intel/blorp/blorp_blit.c +++ b/src/intel/blorp/blorp_blit.c

[Mesa-dev] [PATCH 08/33] intel/blorp: Handle 3D surfaces in convert_to_single_slice

--- src/intel/blorp/blorp_blit.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/src/intel/blorp/blorp_blit.c b/src/intel/blorp/blorp_blit.c index c580be7..b5d8d2a 100644 --- a/src/intel/blorp/blorp_blit.c +++ b/src/intel/blorp/blorp_blit.c @@ -1265,10 +1265,15 @@

[Mesa-dev] [PATCH 01/33] intel/isl: Add an isl_swizzle structure and use it for isl_view swizzles

This should be more compact than the enum isl_channel_select[4] that we were using before. It's also very convenient because we already had such a structure in the Vulkan driver we just needed to pull it over. --- src/intel/blorp/blorp.c | 7 +-

Re: [Mesa-dev] Improving ralloc performance for the GLSL compiler

On 31 August 2016 at 17:39, Marek Olšák wrote: > On Wed, Aug 31, 2016 at 4:39 PM, Eero Tamminen > wrote: >> Hi, >> >> On 31.08.2016 16:37, Marek Olšák wrote: >> ... >>> >>> OK. I'm afraid malloc/calloc/realloc/free from libjemalloc.so will >>>

Re: [Mesa-dev] [PATCH 1/8] intel: Add a new "common" library for more code sharing

+Mauro On Wed, Aug 31, 2016 at 1:56 PM, Jason Ekstrand wrote: > The first thing to go in this new library is brw_device_info. > > Signed-off-by: Jason Ekstrand > Cc: Rob Herring > --- > > The android build files I just

[Mesa-dev] [PATCH 3/8] intel: Rename brw_get_device_name/info to gen_get_device_name/info

Signed-off-by: Jason Ekstrand --- src/intel/common/gen_device_info.c | 4 ++-- src/intel/common/gen_device_info.h | 4 ++-- src/intel/isl/tests/isl_surf_get_image_offset_test.c | 6 +++--- src/intel/tools/disasm.c

[Mesa-dev] [PATCH 4/8] intel: Pull the guts of gen7_l3_state.c into a shared helper

Signed-off-by: Jason Ekstrand --- src/intel/Makefile.sources| 4 +- src/intel/common/gen_l3_config.c | 297 src/intel/common/gen_l3_config.h | 108 + src/mesa/drivers/dri/i965/brw_context.h | 4 +-

[Mesa-dev] [PATCH 7/8] anv/cmd_buffer: Move emit_lri and emit_lrm higher up

Signed-off-by: Jason Ekstrand --- src/intel/vulkan/genX_cmd_buffer.c | 38 +++--- 1 file changed, 19 insertions(+), 19 deletions(-) diff --git a/src/intel/vulkan/genX_cmd_buffer.c b/src/intel/vulkan/genX_cmd_buffer.c index 95ed5f2..2806231

[Mesa-dev] [PATCH 0/8] intel: Add a common folder for code-sharing

Right now, we have 3 places where code is shared between the Vulkan and GL drivers: blorp, isl, and libi965_compiler. There are a few places where we want to share misc. code that doesn't fall into any of these categories. This little series adds a new src/intel/common folder and puts the device

[Mesa-dev] [PATCH 8/8] anv: Move cmd_buffer_config_l3 into anv_cmd_buffer.c

This is the only remaining part of genX_l3.c and there's really no good reason for it to be in its own file. Signed-off-by: Jason Ekstrand --- src/intel/vulkan/Makefile.sources | 4 - src/intel/vulkan/anv_genX.h| 2 +- src/intel/vulkan/gen7_cmd_buffer.c | 2

[Mesa-dev] [PATCH 5/8] anv: Leverage the shared L3$ config code

When Jordan first implement L3$ configuration for Vulkan, he copied+pasted from the GL driver because we had no good place to share it. Now that we have src/intel/common, we should be sharing these tables. Signed-off-by: Jason Ekstrand --- src/intel/vulkan/anv_private.h |

[Mesa-dev] [PATCH 6/8] anv: Refactor pipeline l3 config setup

Now that we're using gen_l3_config.c, we no longer have one set of l3 config functions per gen and we can simplify a bit. Also, we know that only compute uses SLM so we don't need to look for it in all of the stages. Signed-off-by: Jason Ekstrand ---

[Mesa-dev] [PATCH 1/8] intel: Add a new "common" library for more code sharing

The first thing to go in this new library is brw_device_info. Signed-off-by: Jason Ekstrand Cc: Rob Herring --- The android build files I just copied-and-pasted from blorp but I don't have an android build setup so I can't test them.

Re: [Mesa-dev] [PATCH] st/mesa: expose OES_geometry_shader and OES_texture_cube_map_array

On Wed, Aug 31, 2016 at 4:46 PM, Marek Olšák wrote: > On Wed, Aug 31, 2016 at 1:33 AM, Ilia Mirkin wrote: >> On Mon, Aug 29, 2016 at 11:49 AM, Marek Olšák wrote: >>> On Mon, Aug 29, 2016 at 5:41 PM, Ilia Mirkin

[Mesa-dev] [PATCH 2/6] nvc0: re-upload currently bound shaders after code eviction

This fixes a very old issue which happens when the code segment size is full. A bunch of real applications like Tomb Raider, F1 2015, Elemental, hit that issue because they use a ton of shaders. In this case, all shaders are evicted (for freeing space) but all currently bound shaders also need to

[Mesa-dev] [PATCH 1/6] nvc0: refactor the program upload process

This refactoring will help for fixing the "out of code space" eviction issue because we will need to reupload the code for all currently bound shaders but it's slightly different than uploading a new fresh code. Signed-off-by: Samuel Pitoiset ---

[Mesa-dev] [PATCH 6/6] nvc0: reduce the initial code segment size to 512KB

Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/nouveau/nvc0/nvc0_screen.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/nouveau/nvc0/nvc0_screen.c b/src/gallium/drivers/nouveau/nvc0/nvc0_screen.c index 6c6d177..0627f3d

[Mesa-dev] [PATCH 3/6] nvc0: add nvc0_screen_resize_text_area() helper

This function will be helpful for resizing the code segment area when we need to evict all shaders. Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/nouveau/nvc0/nvc0_context.h | 1 + src/gallium/drivers/nouveau/nvc0/nvc0_screen.c | 47

[Mesa-dev] [PATCH 4/6] nvc0: add a new bin for the code segment

To avoid the bins list to grow up indefinitely when the code segment size will be bumped, we need to separate that bin from the SCREEN one because it contains other resources like the uniform bo. Signed-off-by: Samuel Pitoiset ---

[Mesa-dev] [PATCH 5/6] nvc0: allow to resize the code segment dynamically

When an application uses a ton of shaders, we need to evict them when the code segment is full but this is not really a good solution if monster shaders are used because code eviction will happen a lot. To avoid this, it seems better to dynamically resize the code segment area after each

Re: [Mesa-dev] [PATCH] st/mesa: expose OES_geometry_shader and OES_texture_cube_map_array

On Wed, Aug 31, 2016 at 1:33 AM, Ilia Mirkin wrote: > On Mon, Aug 29, 2016 at 11:49 AM, Marek Olšák wrote: >> On Mon, Aug 29, 2016 at 5:41 PM, Ilia Mirkin wrote: >>> On Mon, Aug 29, 2016 at 11:35 AM, Marek Olšák

Re: [Mesa-dev] [PATCH] gallium/docs: clarify render_condition_enabled parameter to clear functions

Reviewed-by: Marek Olšák Marek On Wed, Aug 31, 2016 at 6:04 PM, Brian Paul wrote: > If false, it means do the clear unconditionally. > --- > src/gallium/docs/source/context.rst | 4 > 1 file changed, 4 insertions(+) > > diff --git

Re: [Mesa-dev] [PATCH] brw_clear: fix noop_scissor range issue on width/height

On Wed, Aug 31, 2016 at 1:05 PM, Matt Turner wrote: > From: Jordan Justen > > If scissor X or Y was set to a negative value then the previous > code might have indicated noop scissors when the scissor range > actually was masking a portion of the

[Mesa-dev] [PATCH] brw_clear: fix noop_scissor range issue on width/height

From: Jordan Justen If scissor X or Y was set to a negative value then the previous code might have indicated noop scissors when the scissor range actually was masking a portion of the framebuffer. Since fb->_Xmin, _Xmax, _Ymin and _Ymax take scissors into account, we

Re: [Mesa-dev] [PATCH] glsl: Reject TCS/TES input arrays not sized to gl_MaxPatchVertices.

Kenneth Graunke writes: > We handled the unsized case, implicitly sizing arrays to the value > of gl_MaxPatchVertices. But if a size was present, we failed to > raise a compile error if it wasn't the value of gl_MaxPatchVertices. > > Fixes CTS tests: > >

[Mesa-dev] [Bug 9427] Problems in manual-page markup on the Mesa gl library pages

https://bugs.freedesktop.org/show_bug.cgi?id=9427 karan kapoor changed: What|Removed |Added Assignee|mesa-dev@lists.freedesktop.

[Mesa-dev] [Bug 9427] Problems in manual-page markup on the Mesa gl library pages

https://bugs.freedesktop.org/show_bug.cgi?id=9427 karan kapoor changed: What|Removed |Added Version|unspecified |9.2

[Mesa-dev] [Bug 9427] Problems in manual-page markup on the Mesa gl library pages

https://bugs.freedesktop.org/show_bug.cgi?id=9427 karan kapoor changed: What|Removed |Added CC|

[Mesa-dev] [PATCH] glsl: Reject TCS/TES input arrays not sized to gl_MaxPatchVertices.

We handled the unsized case, implicitly sizing arrays to the value of gl_MaxPatchVertices. But if a size was present, we failed to raise a compile error if it wasn't the value of gl_MaxPatchVertices. Fixes CTS tests: *.tessellation_shader.compilation_and_linking_errors.

Re: [Mesa-dev] Improving ralloc performance for the GLSL compiler

On Wed, Aug 31, 2016 at 4:39 PM, Eero Tamminen wrote: > Hi, > > On 31.08.2016 16:37, Marek Olšák wrote: > ... >> >> OK. I'm afraid malloc/calloc/realloc/free from libjemalloc.so will >> conflict with libc and Steam. > >> >> >> When building jemalloc from source, there

Re: [Mesa-dev] Improving ralloc performance for the GLSL compiler

On Wed, Aug 31, 2016 at 05:39:20PM +0300, Eero Tamminen wrote: > Hi, Hi, > > On 31.08.2016 16:37, Marek Olšák wrote: > ... > > OK. I'm afraid malloc/calloc/realloc/free from libjemalloc.so will > > conflict with libc and Steam. > > > > When building jemalloc from source, there is an option to

  1   2   >