Re: [Mesa-dev] [PATCH v03 35/38] i965: Port gen4+ emit vertices code to genxml.

On Thu, May 04, 2017 at 12:16:53PM -0700, Rafael Antognolli wrote: > On Thu, May 04, 2017 at 11:19:24AM +0300, Pohjolainen, Topi wrote: > > On Mon, May 01, 2017 at 06:43:23PM -0700, Rafael Antognolli wrote: > > > Some code that was placed in brw_draw_upload.c and exported to be used > > > by gen8+

Re: [Mesa-dev] [PATCH] i965: Move MOCS macros to brw_state.h.

On Thu, May 04, 2017 at 11:49:08AM -0700, Rafael Antognolli wrote: > brw_state.h is a better place to keep them, instead of brw_context.h. Thanks for the follow-up :) > > Signed-off-by: Rafael Antognolli > Reviewed-by: Topi Pohjolainen

Re: [Mesa-dev] [PATCH 3/3] egl/android: Mark surface as lost when dequeueBuffer fails

On Thu, May 4, 2017, at 05:42 AM, Emil Velikov wrote: > Hi Chad, > > On 4 May 2017 at 00:47, Chad Versace wrote: > > From: Chad Versace > > > > This ensures that future calls to eglSwapBuffers and eglMakeCurrent emit > > an error. > > > > This

Re: [Mesa-dev] [PATCH] egl/android: Set EGLSurface.Lost to EGL_TRUE/EGL_FALSE

On Thu, May 4, 2017, at 07:43 PM, Nicolas Boichat wrote: > Lost is an EGLBoolean, so we should assign it to EGL_TRUE/EGL_FALSE, > not true/false. > > Fixes: e5eace58684 ("egl/android: Mark surface as lost when dequeueBuffer > fails") > Fixes: 0212db35040 ("egl/android: Cancel any outstanding

[Mesa-dev] [PATCH] egl/android: Set EGLSurface.Lost to EGL_TRUE/EGL_FALSE

Lost is an EGLBoolean, so we should assign it to EGL_TRUE/EGL_FALSE, not true/false. Fixes: e5eace58684 ("egl/android: Mark surface as lost when dequeueBuffer fails") Fixes: 0212db35040 ("egl/android: Cancel any outstanding ANativeBuffer in surface destructor") ---

Re: [Mesa-dev] [PATCH 2/3] egl/android: Cancel any outstanding ANativeBuffer in surface destructor

On Thu, May 4, 2017 at 7:47 AM, Chad Versace wrote: > From: Chad Versace > > That is, call ANativeWindow::cancelBuffer in droid_destroy_surface(). > > This should prevent application deadlock when the app destroys the > EGLSurface after EGL has

[Mesa-dev] [PATCH] configure.ac: Also match -androideabi tuple

From: Nicolas Boichat On ARM Android platforms, the host_os tuple should be linux-androideabi, so let's match both -android and -androideabi (or any other -android* tuple) to determine if we should do an Android build. --- configure.ac | 2 +- 1 file changed, 1

[Mesa-dev] [PATCH 2/9] i965: Move multiply by 4 for VS ATTR setup into the scalar backend.

The vec4 backend will want to count in units of vec4s, not scalar components. The simplest solution is to move the multiplication by 4 into the scalar backend. This also improves consistency with how we count varyings. --- src/intel/compiler/brw_fs_nir.cpp | 2 +- src/intel/compiler/brw_nir.c

[Mesa-dev] [PATCH 9/9] i965/vec4: Use NIR to do GS input remapping

We're already doing this in the FS back-end. This just does the same thing in the vec4 back-end. --- src/intel/compiler/brw_nir.c | 3 -- src/intel/compiler/brw_vec4.cpp| 44 --- src/intel/compiler/brw_vec4.h | 2 -

[Mesa-dev] [PATCH 0/9] intel/compiler: Do vec4 input remapping in NIR

We've been doing input remapping in NIR for the FS back-end for some time now but never bothered to port over vec4. This little series does the same thing for the vec4 back-end and makes a couple of other nice cleanups along the way. Jason Ekstrand (9): i965/nir: Inline remap_vs_attrs i965:

[Mesa-dev] [PATCH 6/9] i965/vec4: Use NIR remapping for VS attributes

We have to pass inputs_read through from prog_data because we may add an edge flag on old platforms. --- src/intel/compiler/brw_nir.c | 12 +++ src/intel/compiler/brw_nir.h | 2 +- src/intel/compiler/brw_vec4.cpp| 54 +++---

[Mesa-dev] [PATCH 4/9] i965/fs: Lower gl_VertexID and friends to inputs at the NIR level

NIR calls these system values but they come in from the VF unit as vertex data. It's terribly convenient to just be able to treat them as such in the back-end. --- src/intel/compiler/brw_fs.h | 1 - src/intel/compiler/brw_fs_nir.cpp | 30 +--

[Mesa-dev] [PATCH 5/9] intel/compiler/vs: Move inputs_read handling to generic code

--- src/intel/compiler/brw_vec4.cpp| 7 +++ src/intel/vulkan/anv_pipeline.c| 3 --- src/mesa/drivers/dri/i965/brw_vs.c | 7 --- 3 files changed, 7 insertions(+), 10 deletions(-) diff --git a/src/intel/compiler/brw_vec4.cpp b/src/intel/compiler/brw_vec4.cpp index afef49a..21f34bc

[Mesa-dev] [PATCH 3/9] i965/vs: Set uses_vertexid and friends from brw_compile_vs

--- src/intel/compiler/brw_fs_visitor.cpp | 6 -- src/intel/compiler/brw_vec4.cpp| 17 + src/intel/compiler/brw_vec4_vs_visitor.cpp | 5 - 3 files changed, 17 insertions(+), 11 deletions(-) diff --git a/src/intel/compiler/brw_fs_visitor.cpp

[Mesa-dev] [PATCH 7/9] i965/nir: Inline remap_inputs_with_vue_map

--- src/intel/compiler/brw_nir.c | 49 1 file changed, 22 insertions(+), 27 deletions(-) diff --git a/src/intel/compiler/brw_nir.c b/src/intel/compiler/brw_nir.c index 5ca532f..725143f 100644 --- a/src/intel/compiler/brw_nir.c +++

[Mesa-dev] [PATCH 8/9] i965/fs: Move remapping of gl_PointSize to the NIR level

--- src/intel/compiler/brw_fs_nir.cpp | 26 +++--- src/intel/compiler/brw_nir.c | 22 +++--- 2 files changed, 22 insertions(+), 26 deletions(-) diff --git a/src/intel/compiler/brw_fs_nir.cpp b/src/intel/compiler/brw_fs_nir.cpp index d4ce753..f408d48

[Mesa-dev] [PATCH 1/9] i965/nir: Inline remap_vs_attrs

Now that we have nice block iterators, there's no good reason for this to be off on it's own. While we're here, we convert to using the NIR const index getters/setters instead of whacking const_index values directly. --- src/intel/compiler/brw_nir.c | 56

[Mesa-dev] [PATCH 4/5] radv/meta: move blit2d to using push constants

From: Dave Airlie This allows us to drop the vertex buffer. Signed-off-by: Dave Airlie --- src/amd/vulkan/radv_meta_blit2d.c | 130 +- src/amd/vulkan/radv_meta_copy.c | 4 +- 2 files changed, 59 insertions(+), 75

[Mesa-dev] [PATCH 1/5] radv: set base/ranges for push constant loads.

From: Dave Airlie This isn't necessary yet but I'd like to use the range in some future patches. Signed-off-by: Dave Airlie --- src/amd/vulkan/radv_meta_blit2d.c | 2 ++ src/amd/vulkan/radv_meta_buffer.c | 2 ++

[Mesa-dev] [PATCH 2/5] radv/meta: use novertex save path for resolve pass.

From: Dave Airlie This was missing in the original change. Signed-off-by: Dave Airlie --- src/amd/vulkan/radv_meta_resolve.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/amd/vulkan/radv_meta_resolve.c

[Mesa-dev] [PATCH 3/5] radv/meta: move clear color to using push constants

From: Dave Airlie The color clear value is uniform and needs only to be emitted from the frag shader, so just push it down via a push constant, and remove the vertex buffer completely. The depth clear value needs to be emitted from the vertex shader, but is only a single

[Mesa-dev] [PATCH 5/5] radv/meta: port blit to using push constants

From: Dave Airlie Remove use of vertex buffer. Signed-off-by: Dave Airlie --- src/amd/vulkan/radv_meta_blit.c | 165 1 file changed, 65 insertions(+), 100 deletions(-) diff --git

[Mesa-dev] radv: move to using push constants for more meta shaders

Most of the meta shader don't need vertex data and can use push constants, currently this won't make a massive difference, however I've written patches to start inlining push constants into user sgprs, which will reduce the overheads in the meta paths. Dave.

Re: [Mesa-dev] [PATCH v3 32/32] glsl: skip tree grafting for sampler and image types

Nice work :) Everything but patch 4, which I'd like a response on is: Reviewed-by: Timothy Arceri On 03/05/17 06:53, Samuel Pitoiset wrote: From: Nicolai Hähnle v2: - use is_sampler()/is_image() instead (Samuel Pitoiset) Reviewed-by: Samuel

Re: [Mesa-dev] [PATCH v3 27/32] glsl: implement ARB_bindless_texture conversions

On 03/05/17 06:53, Samuel Pitoiset wrote: From section 5.4.1 of the ARB_bindless_texture spec: "In the following four constructors, the low 32 bits of the sampler type correspond to the .x component of the uvec2 and the high 32 bits correspond to the .y component."

Re: [Mesa-dev] [PATCH] radv: set base/ranges for push constant loads.

On 5 May 2017 at 10:43, Dave Airlie wrote: > From: Dave Airlie > > This isn't necessary yet but I'd like to use the range in > some future patches. > > Signed-off-by: Dave Airlie > --- > src/amd/vulkan/radv_meta_blit2d.c | 2 ++ >

Re: [Mesa-dev] [PATCH] radv: enable POLARIS12 support.

Reviewed-by: Bas Nieuwenhuizen Maybe nominate for stable too? On Fri, May 5, 2017 at 2:28 AM, Dave Airlie wrote: > From: Dave Airlie > > This just adds the chip in the right places. > > We don't set the partial_vs_wave

[Mesa-dev] [PATCH] radv: set base/ranges for push constant loads.

From: Dave Airlie This isn't necessary yet but I'd like to use the range in some future patches. Signed-off-by: Dave Airlie --- src/amd/vulkan/radv_meta_blit2d.c | 2 ++ src/amd/vulkan/radv_meta_buffer.c | 2 ++

Re: [Mesa-dev] [PATCH 3/3] egl/android: Mark surface as lost when dequeueBuffer fails

On Thu 04 May 2017, Emil Velikov wrote: > Hi Chad, > > On 4 May 2017 at 00:47, Chad Versace wrote: > > From: Chad Versace > > > > This ensures that future calls to eglSwapBuffers and eglMakeCurrent emit > > an error. > > > > This patch is part of a

Re: [Mesa-dev] [PATCH] anv: fix possible stack corruption

Something funny happened with the indentation, if you could fix this, this is : Reviewed-by: Lionel Landwerlin Thanks! - Lionel On 04/05/17 17:34, Grazvydas Ignotas wrote: ping Emil: the code this fixes is yours. Gražvydas On Tue, May 2, 2017 at 8:17 PM,

[Mesa-dev] [Bug 100613] Regression in Mesa 17 on s390x (zSystems)

https://bugs.freedesktop.org/show_bug.cgi?id=100613 --- Comment #24 from Ray Strode --- (mid-air collision) (In reply to Roland Scheidegger from comment #22) > I think this has more to do with packed formats - for things like 10/10/10/2 > you can't really access that as

Re: [Mesa-dev] [PATCH] anv: fix possible stack corruption

ping Emil: the code this fixes is yours. Gražvydas On Tue, May 2, 2017 at 8:17 PM, Grazvydas Ignotas wrote: > drmGetDevices2 takes count and not size. Probably hasn't caused problems > yet in practice and was missed as setups with more than 8 DRM devices > are not very

[Mesa-dev] [PATCH v3] swr: move msaa resolve to generalized StoreTile

v3: list piglit tests fixed by this patch. Fixed typo Tim pointed out. v2: Reword commit message to more closely adhere to community guidelines. This patch moves msaa resolve down into core/StoreTiles where the surface format conversion routines are available. The previous "experimental" resolve

[Mesa-dev] [PATCH] radv: enable POLARIS12 support.

From: Dave Airlie This just adds the chip in the right places. We don't set the partial_vs_wave workaround, as radeonsi doesn't, but have to confirm it's not required. Signed-off-by: Dave Airlie --- src/amd/common/ac_llvm_util.c | 1

[Mesa-dev] [Bug 100613] Regression in Mesa 17 on s390x (zSystems)

https://bugs.freedesktop.org/show_bug.cgi?id=100613 --- Comment #23 from Roland Scheidegger --- (In reply to Ray Strode from comment #20) > in this layout, vec_nr needs to be 0, then 1, then 1 to get the correct > values, which is achieved with > > vec_nr = (fetch_width -

Re: [Mesa-dev] [PATCH v3 19/32] glsl: relax bindless sampler arrays indexing

On 04/05/17 22:29, Nicolai Hähnle wrote: On 02.05.2017 22:53, Samuel Pitoiset wrote: From section 4.1.7 of the ARB_bindless_texture spec: "Samplers aggregated into arrays within a shader (using square brackets []) can be indexed with arbitrary integer expressions." v3: - update spec

Re: [Mesa-dev] [PATCH v3 12/32] glsl: allow bindless samplers/images inside interface blocks

On 04/05/17 22:24, Nicolai Hähnle wrote: On 02.05.2017 22:53, Samuel Pitoiset wrote: From section 4.3.7 of the ARB_bindless_texture spec: "(remove the following bullet from the last list on p. 39, thereby permitting sampler types in interface blocks; image types are also permitted

Re: [Mesa-dev] [PATCH v3 04/32] glsl: make component_slots() returns 2 for samplers/images

What happened with my suggestion [1]? Was there a problem? IMO this patch just hacks around the problem and as mentioned previously will result in extra unused uniform storage being allocated. [1] https://lists.freedesktop.org/archives/mesa-dev/2017-April/153156.html On 03/05/17 06:53,

[Mesa-dev] [Bug 100613] Regression in Mesa 17 on s390x (zSystems)

https://bugs.freedesktop.org/show_bug.cgi?id=100613 --- Comment #22 from Roland Scheidegger --- (In reply to Ray Strode [halfline] from comment #21) > Unless I'm misunderstanding something, I think this comment in u_format.h is > the crux of the issue: > > * If each

Re: [Mesa-dev] [PATCH 01/18] mesa: make map_buffer_range() static

On 05/05/17 03:38, Eric Anholt wrote: This series is: Reviewed-by: Eric Anholt Thanks for breaking your work up into digestible chunks! Thanks for the reviews :) I'm looking forward to trying out your no_error stuff in glamor. Cool. I'd be interested in the results.

Re: [Mesa-dev] [PATCH 12/18] mesa: remove unused _mesa_total_buffer_object_memory()

On 05/05/17 02:00, Brian Paul wrote: On 05/04/2017 01:41 AM, Timothy Arceri wrote: --- src/mesa/main/bufferobj.c | 31 --- src/mesa/main/bufferobj.h | 3 --- 2 files changed, 34 deletions(-) diff --git a/src/mesa/main/bufferobj.c b/src/mesa/main/bufferobj.c

Re: [Mesa-dev] [PATCH] st/glsl_to_tgsi: fix the DCE pass in presence of loops

On 04/05/17 22:28, Samuel Pitoiset wrote: On 05/04/2017 02:13 PM, Samuel Pitoiset wrote: On 05/04/2017 12:26 PM, Timothy Arceri wrote: On 04/05/17 18:22, Samuel Pitoiset wrot On 05/04/2017 02:36 AM, Timothy Arceri wrote: This and the tgsi copy_propagation pass are very slow, I'd really

[Mesa-dev] 17.1 cherry-pick request (Polarsi12 fix)

Hi Emil, Can we please get this into the 17.1 release? https://cgit.freedesktop.org/mesa/mesa/commit/?id=69e6eab6533ff48f72223cd21ef640242c52598b Thanks, Marek ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org

[Mesa-dev] [PATCHi V2] mesa: add KHR_no_error support for glUseProgram

V2: use CALL_ dispatch macro to select no_error variant of BindProgramPipeline rather than a custom USE_PROGRAM macro. --- I'm actually not to sure if using the CALL_ macro is any better than just a no error check to select the correct function. It seems like it should be, but either

Re: [Mesa-dev] [PATCH] virgl: remove unused draw include

Acked-by: Dave Airlie On 28 April 2017 at 01:26, Emil Velikov wrote: > From: Emil Velikov > > Driver does not use the gallium draw module. > > Cc: Dave Airlie > Signed-off-by: Emil Velikov

[Mesa-dev] [AppVeyor] mesa master #4263 failed

Build mesa 4263 failed Commit 69e6eab653 by Marek Olšák on 5/4/2017 11:16 PM: winsys/amdgpu: fix Polaris12 (RX 550) breakage\n\nreported by Greg White.\n\nBugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=100892\nCc: 17.1

Re: [Mesa-dev] [PATCH 6/7] egl: drop unneeded sentinel from level_strings[]

It should be: i < ARRAY_SIZE(level_strings) On 04.05.2017 20:47, Emil Velikov wrote: From: Emil Velikov The array is local so we already know its size. Signed-off-by: Emil Velikov --- src/egl/main/egllog.c | 4 ++-- 1 file

[Mesa-dev] [PATCH v2] mesa: return early with error when shader source count is 0

malloc can return valid pointer for zero size allocation, which causes OOB access later on v2: Return error if count is 0, clear previous shader source --- src/mesa/main/shaderapi.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/mesa/main/shaderapi.c

Re: [Mesa-dev] [RFC] - Rewrite mesa website in Sphinx

Any throughts on this? Emil, Did you have time to check the page I mentioned? Best Regards, Jean Hertel ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 0/2] anv/i965: drop libdrm dependency completely

On Thu, May 4, 2017 at 12:21 PM, Kristian Høgsberg wrote: > On Thu, May 4, 2017 at 11:43 AM, Lionel Landwerlin > wrote: > > On 04/05/17 07:52, Emil Velikov wrote: > >> > >> On 4 May 2017 at 14:46, Daniel Vetter wrote: > >>> >

Re: [Mesa-dev] [PATCH] mesa: return early with no error when shader source count is 0

Bartosz Tomczyk writes: > You are right, it doesn't free old shader source. Should we also clear > old source if new source is NULL? Then I could unify both conditions. shader_source() would free the old and put in the new. If calloc fails, you could throw

Re: [Mesa-dev] [PATCH v2 19/31] glsl: fix explicit binding location for bindless samplers/images

On 05/04/2017 09:55 PM, Samuel Pitoiset wrote: On 05/04/2017 09:51 PM, Samuel Pitoiset wrote: On 05/04/2017 09:44 PM, Nicolai Hähnle wrote: On 04.05.2017 20:54, Marek Olšák wrote: On Wed, Apr 26, 2017 at 9:40 AM, Nicolai Hähnle wrote: On 24.04.2017 12:35, Samuel

Re: [Mesa-dev] [PATCH v2 19/31] glsl: fix explicit binding location for bindless samplers/images

On 05/04/2017 09:51 PM, Samuel Pitoiset wrote: On 05/04/2017 09:44 PM, Nicolai Hähnle wrote: On 04.05.2017 20:54, Marek Olšák wrote: On Wed, Apr 26, 2017 at 9:40 AM, Nicolai Hähnle wrote: On 24.04.2017 12:35, Samuel Pitoiset wrote: The ARB_bindless_texture spec

Re: [Mesa-dev] [PATCH v2 19/31] glsl: fix explicit binding location for bindless samplers/images

On 05/04/2017 09:44 PM, Nicolai Hähnle wrote: On 04.05.2017 20:54, Marek Olšák wrote: On Wed, Apr 26, 2017 at 9:40 AM, Nicolai Hähnle wrote: On 24.04.2017 12:35, Samuel Pitoiset wrote: The ARB_bindless_texture spec says: "Interactions with GLSL 4.20" "Without

Re: [Mesa-dev] [Mesa-stable] [PATCH v2] swr: move msaa resolve to generalized StoreTile

> On Apr 27, 2017, at 6:22 PM, Bruce Cherniak wrote: > > v2: Reword commit message to more closely adhere to community > guidelines. > > This patch moves msaa resolve down into core/StoreTiles where the > surface format conversion routines are available. The previous

Re: [Mesa-dev] [PATCH v2 19/31] glsl: fix explicit binding location for bindless samplers/images

On 04.05.2017 20:54, Marek Olšák wrote: On Wed, Apr 26, 2017 at 9:40 AM, Nicolai Hähnle wrote: On 24.04.2017 12:35, Samuel Pitoiset wrote: The ARB_bindless_texture spec says: "Interactions with GLSL 4.20" "Without GLSL 4.20 support, sampler and image uniforms may

Re: [Mesa-dev] [PATCH 0/2] anv/i965: drop libdrm dependency completely

On Thu, May 4, 2017 at 11:43 AM, Lionel Landwerlin wrote: > On 04/05/17 07:52, Emil Velikov wrote: >> >> On 4 May 2017 at 14:46, Daniel Vetter wrote: >>> >>> On Thu, Apr 27, 2017 at 10:58:42AM -0700, Lionel Landwerlin wrote: On 27/04/17

Re: [Mesa-dev] [PATCH 2/7] egl: fold Android logger into main/

On Thu, May 4, 2017 at 1:46 PM, Emil Velikov wrote: > From: Emil Velikov > > Will allow us to greatly simplify a lot of the code in egllog.c Okay, because on its own, this is not an improvement. > > Signed-off-by: Emil Velikov

Re: [Mesa-dev] [PATCH v03 35/38] i965: Port gen4+ emit vertices code to genxml.

On Thu, May 04, 2017 at 11:19:24AM +0300, Pohjolainen, Topi wrote: > On Mon, May 01, 2017 at 06:43:23PM -0700, Rafael Antognolli wrote: > > Some code that was placed in brw_draw_upload.c and exported to be used > > by gen8+ was also moved to genX_state_upload, and the respective symbols > > are

Re: [Mesa-dev] [PATCH 3/3] genxml: Rename "Line Width" to "BDW Line Width"

Eh... I don't think this is needed but I don't really care too much. I guess there are only 2 gen8 plaforms so it makes some sense. Would you mind adding one more patch to inline __emit_sf_state now that we don't need all the stupid? With that, all 4 would be Reviewed-by: Jason Ekstrand

Re: [Mesa-dev] [PATCH 0/4] Call for testing: Gallium set_index_buffer removal etc.

On 05/03/2017 10:37 PM, Brian Paul wrote: On 05/01/2017 10:03 AM, Brian Paul wrote: On 05/01/2017 08:32 AM, Brian Paul wrote: On 04/28/2017 05:12 PM, Marek Olšák wrote: Hi, This series shrinks various gallium structures and removes set_index_buffer in order to decrease CPU overhead. PART

[Mesa-dev] [PATCH 1/3] i965: Fix line width on Cherryview.

We just add another field to gen8.xml for the Cherryview line width, rather than trying to replicate the gymnastics done in the Vulkan driver to use gen9 SF pack functions. --- src/intel/genxml/gen8.xml | 1 + src/mesa/drivers/dri/i965/genX_state_upload.c | 7 +++ 2 files

[Mesa-dev] [PATCH 3/3] genxml: Rename "Line Width" to "BDW Line Width"

To clarify "BDW Line Width" vs. "CHV Line Width". --- src/intel/genxml/gen8.xml | 2 +- src/intel/vulkan/gen8_cmd_buffer.c| 2 +- src/mesa/drivers/dri/i965/genX_state_upload.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git

[Mesa-dev] [PATCH 2/3] anv: Simplify Cherryview line handling.

We can just use the new CHVLineWidth field rather than an entirely different generation's packing function. --- src/intel/vulkan/gen8_cmd_buffer.c | 45 -- 1 file changed, 9 insertions(+), 36 deletions(-) diff --git a/src/intel/vulkan/gen8_cmd_buffer.c

Re: [Mesa-dev] [PATCH v2 19/31] glsl: fix explicit binding location for bindless samplers/images

On Wed, Apr 26, 2017 at 9:40 AM, Nicolai Hähnle wrote: > On 24.04.2017 12:35, Samuel Pitoiset wrote: >> >> The ARB_bindless_texture spec says: >> >>"Interactions with GLSL 4.20" >> >>"Without GLSL 4.20 support, sampler and image uniforms may only >> be initialized

[Mesa-dev] [PATCH 1/7] egl: remove unused _eglSetLogLevel()

From: Emil Velikov Signed-off-by: Emil Velikov --- src/egl/main/egllog.c | 21 - src/egl/main/egllog.h | 4 2 files changed, 25 deletions(-) diff --git a/src/egl/main/egllog.c b/src/egl/main/egllog.c index

[Mesa-dev] [PATCH 6/7] egl: drop unneeded sentinel from level_strings[]

From: Emil Velikov The array is local so we already know its size. Signed-off-by: Emil Velikov --- src/egl/main/egllog.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/egl/main/egllog.c

[Mesa-dev] [PATCH 7/7] egl: use designated initializers

From: Emil Velikov All the compilers used to build Mesa support them. Signed-off-by: Emil Velikov --- src/egl/main/egllog.c | 15 +++ 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/src/egl/main/egllog.c

[Mesa-dev] [PATCH 3/7] egl: remove no longer needed logger infra

From: Emil Velikov As of last commit nobody requires anything else but the _eglDefaultLogger(). As such use it directly and simplify the implementation. Signed-off-by: Emil Velikov --- src/egl/main/egllog.c | 48

[Mesa-dev] [PATCH 5/7] egl: remove suprous header eglcompiler.h

From: Emil Velikov The header is used only to provide STATIC_ASSERT. The latter is already available in utils/macros.h so use that instead and kill of the header. Signed-off-by: Emil Velikov --- src/egl/Makefile.sources |

[Mesa-dev] [PATCH 2/7] egl: fold Android logger into main/

From: Emil Velikov Will allow us to greatly simplify a lot of the code in egllog.c Signed-off-by: Emil Velikov --- src/egl/drivers/dri2/egl_dri2.h | 1 - src/egl/drivers/dri2/platform_android.c | 34

[Mesa-dev] [PATCH 4/7] egl: remove unneeded else statement in _eglInitLogger

From: Emil Velikov The variable level is already initialized to -1 which is already interpreted as FALLBACK_LOG_LEVEL. Signed-off-by: Emil Velikov --- src/egl/main/egllog.c | 3 --- 1 file changed, 3 deletions(-) diff --git

Re: [Mesa-dev] [PATCH v03 14/38] i965: Move MOCS macros to brw_context.h.

On Wed, May 03, 2017 at 11:36:29PM -0700, Kenneth Graunke wrote: > On Wednesday, May 3, 2017 7:52:01 PM PDT Pohjolainen, Topi wrote: > > On Wed, May 03, 2017 at 05:11:45PM -0700, Rafael Antognolli wrote: > > > On Wed, May 03, 2017 at 08:28:24PM +0300, Pohjolainen, Topi wrote: > > > > On Mon, May

[Mesa-dev] [PATCH] i965: Move MOCS macros to brw_state.h.

brw_state.h is a better place to keep them, instead of brw_context.h. Signed-off-by: Rafael Antognolli Reviewed-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/brw_context.h | 42 -

Re: [Mesa-dev] [PATCH 0/2] anv/i965: drop libdrm dependency completely

On 04/05/17 07:52, Emil Velikov wrote: On 4 May 2017 at 14:46, Daniel Vetter wrote: On Thu, Apr 27, 2017 at 10:58:42AM -0700, Lionel Landwerlin wrote: On 27/04/17 08:20, Eric Anholt wrote: Emil Velikov writes: On 25 April 2017 at 23:56, Lionel

Re: [Mesa-dev] [PATCH 1/3] mesa: Simplify _mesa_primitive_restart_index().

Reviewed-by: Rafael Antognolli On Thu, May 04, 2017 at 08:13:05AM -0700, Kenneth Graunke wrote: > We can use a simple shift equation rather than a switch statement. > --- > src/mesa/main/varray.c | 12 ++-- > 1 file changed, 2 insertions(+), 10 deletions(-)

Re: [Mesa-dev] [PATCH 09/11] intel/tools: Refactor gen_disasm_disassemble() to use annotations

On Tue, May 2, 2017 at 6:03 AM, Iago Toral wrote: > On Mon, 2017-05-01 at 13:54 -0700, Matt Turner wrote: >> Which will allow us to print validation errors found in shader >> assembly >> in GPU hang error states. >> --- >> src/intel/tools/disasm.c | 71

Re: [Mesa-dev] [PATCH 02/11] i965: Pass pointer and end of assembly to brw_validate_instructions

On Tue, May 2, 2017 at 5:30 AM, Iago Toral wrote: > On Mon, 2017-05-01 at 13:54 -0700, Matt Turner wrote: >> This will allow us to more easily run brw_validate_instructions() on >> shader programs we find in GPU hang error states. >> --- >> src/intel/compiler/brw_eu.h

Re: [Mesa-dev] [PATCH 17/18] anv/allocator: Allow state pools to allocate large states

On Thu, May 4, 2017 at 9:26 AM, Juan A. Suarez Romero wrote: > On Thu, 2017-05-04 at 07:49 -0700, Jason Ekstrand wrote: > > On Thu, May 4, 2017 at 1:00 AM, Juan A. Suarez Romero < > jasua...@igalia.com> wrote: > > > On Wed, 2017-04-26 at 07:35 -0700, Jason Ekstrand wrote: >

Re: [Mesa-dev] [PATCH] mesa: return early with no error when shader source count is 0

You are right, it doesn't free old shader source. Should we also clear old source if new source is NULL? Then I could unify both conditions. On 04.05.2017 19:03, Eric Anholt wrote: Bartosz Tomczyk writes: malloc can return valid pointer for zero size

[Mesa-dev] [AppVeyor] mesa master #4259 failed

Build mesa 4259 failed Commit 7b55a05159 by Rob Clark on 5/4/2017 5:26 PM: freedreno/a5xx: compute shader support\n\nSigned-off-by: Rob Clark Configure your notification preferences

Re: [Mesa-dev] [PATCH 2/7] mesa: add KHR_no_error support for glUseProgramStages()

Eric Anholt writes: > [ Unknown signature status ] > Timothy Arceri writes: > >> --- >> +void GLAPIENTRY >> +_mesa_UseProgramStages_no_error(GLuint pipeline, GLbitfield stages, >> +GLuint prog) >> +{ >> +

Re: [Mesa-dev] [PATCH 2/3] i965: Port 3DSTATE_VF to genxml and simplify the implementation.

On Thursday, May 4, 2017 8:51:43 AM PDT Emil Velikov wrote: > Hi Ken, > > On 4 May 2017 at 16:13, Kenneth Graunke wrote: > > > +#if GEN_IS_HASWELL || GEN_GEN >= 8 > > +static void > > +genX(upload_cut_index)(struct brw_context *brw) > > +{ > > + const struct gl_context

Re: [Mesa-dev] [PATCH] nir/lower_tex: Fix minor error in YUV color conversion matrix

On 4 May 2017 at 16:50, Jason Ekstrand wrote: > Did you also scoop up a stable CC? Seems not. Should be sorted now. -Emil ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org

Re: [Mesa-dev] [PATCH 2/7] mesa: add KHR_no_error support for glUseProgramStages()

Timothy Arceri writes: > --- > src/mapi/glapi/gen/ARB_separate_shader_objects.xml | 2 +- > src/mesa/main/pipelineobj.c| 21 + > src/mesa/main/pipelineobj.h| 3 +++ > 3 files changed, 25 insertions(+),

Re: [Mesa-dev] [PATCH 01/18] mesa: make map_buffer_range() static

This series is: Reviewed-by: Eric Anholt Thanks for breaking your work up into digestible chunks! I'm looking forward to trying out your no_error stuff in glamor. signature.asc Description: PGP signature ___ mesa-dev mailing list

[Mesa-dev] [Bug 100227] gl_marshal.py: generating duplicate declaration specifiers

https://bugs.freedesktop.org/show_bug.cgi?id=100227 --- Comment #2 from Gustaw Smolarczyk --- I didn't really looked at the python generator, but this is what came to my mind: maybe one of the consts was meant to be applied to the pointee type? So instead of "const const

Re: [Mesa-dev] [PATCH 01/13] gallium/dri: always link against shared glapi

On 3 May 2017 at 13:59, Nicolai Hähnle wrote: > Nice cleanups, and looks good as far as I can tell. For the series: > > Reviewed-by: Nicolai Hähnle > Thanks a million Nicolai! -Emil ___ mesa-dev mailing

[Mesa-dev] [Bug 98428] Undefined non-weak-symbol in dri-drivers

https://bugs.freedesktop.org/show_bug.cgi?id=98428 Emil Velikov changed: What|Removed |Added Status|NEW |RESOLVED

Re: [Mesa-dev] [PATCH 3/3] egl: Implement EGL_EXT_device_{base, query, enumeration}

Adam Jackson writes: > On Wed, 2017-05-03 at 12:38 -0700, Eric Anholt wrote: >> > Adam Jackson writes: >> > +#ifdef HAVE_LIBDRM >> > +/* XXX kind of copypasta of drmCompareBusInfo */ >> > +static int >> > +dri2_bus_info_equal(drmDevicePtr a, drmDevicePtr b) >>

Re: [Mesa-dev] [PATCH] c11/threads: rework Windows thrd_current() comment

On 2 May 2017 at 11:23, Eric Engestrom wrote: > On Saturday, 2017-04-29 14:51:15 +0100, Emil Velikov wrote: >> From: Emil Velikov >> >> Drop the misleading "will not match the one returned by thread_create" >> hunk and provide more clarity

Re: [Mesa-dev] [PATCH] mesa: return early with no error when shader source count is 0

Bartosz Tomczyk writes: > malloc can return valid pointer for zero size allocation, > which causes OOB access later on > --- > src/mesa/main/shaderapi.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/src/mesa/main/shaderapi.c b/src/mesa/main/shaderapi.c

Re: [Mesa-dev] [PATCH 2/3] egl/platform/drm: Don't take display ownership until gbm is initialized

On Thu, 2017-05-04 at 13:00 +0100, Emil Velikov wrote: > On 3 May 2017 at 16:57, Adam Jackson wrote: > > If the gbm_create_device() call here actually did fail, any > > subsequent > > eglTerminate on the display would segfault. > > > > We do have a couple of checks after we set

Re: [Mesa-dev] [PATCH] nir/lower_tex: Fix minor error in YUV color conversion matrix

On Thu, May 4, 2017 at 8:50 AM, Jason Ekstrand wrote: > On Wed, May 3, 2017 at 11:53 PM, Kenneth Graunke > wrote: > >> On Wednesday, May 3, 2017 11:37:52 PM PDT Johnson Lin wrote: >> > The matrix used for YCbCr to RGB is listed in: >> > >> >

Re: [Mesa-dev] [PATCH 3/3] egl: Implement EGL_EXT_device_{base, query, enumeration}

On Wed, 2017-05-03 at 12:38 -0700, Eric Anholt wrote: > > Adam Jackson writes: > > +#ifdef HAVE_LIBDRM > > +/* XXX kind of copypasta of drmCompareBusInfo */ > > +static int > > +dri2_bus_info_equal(drmDevicePtr a, drmDevicePtr b) > > +{ > > +if (a == NULL || b == NULL) > > +

Re: [Mesa-dev] [PATCH v2 21/27] st/xvmc: add DRI3 support

On Thu, May 4, 2017 at 12:33 PM, Emil Velikov wrote: > UNTESTED. > > Ilia, can you give this a try? Weekend at the earliest. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org

[Mesa-dev] [PATCH] docs: remove released versions from the calendar

From: Emil Velikov Signed-off-by: Emil Velikov --- docs/release-calendar.html | 16 ++-- 1 file changed, 2 insertions(+), 14 deletions(-) diff --git a/docs/release-calendar.html b/docs/release-calendar.html index

[Mesa-dev] [PATCH v2 25/27] configure: error out if building XVMC w/o supported platform

From: Emil Velikov Cc: Signed-off-by: Emil Velikov --- configure.ac | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index

[Mesa-dev] [PATCH v2 23/27] configure: error out if building OMX w/o supported platform

From: Emil Velikov Cc: Signed-off-by: Emil Velikov --- configure.ac | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index

[Mesa-dev] [PATCH v2 24/27] configure: error out if building VDPAU w/o supported platform

From: Emil Velikov Cc: Signed-off-by: Emil Velikov --- configure.ac | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index

  1   2   3   >