Re: [Mesa-dev] [PATCH] llvmpipe: add LP_NEW_GS flag for updating vertex info

On 05/26/2017 08:35 PM, srol...@vmware.com wrote: From: Roland Scheidegger The vertex information we compute here is really dependent on the last stage before FS. It just happened to work most of the time because new GS tend to come with new VS and/or FS... (The LP_NEW_GS

[Mesa-dev] [PATCH] llvmpipe: add LP_NEW_GS flag for updating vertex info

From: Roland Scheidegger The vertex information we compute here is really dependent on the last stage before FS. It just happened to work most of the time because new GS tend to come with new VS and/or FS... (The LP_NEW_GS flag was previously set but never used.) ---

Re: [Mesa-dev] [PATCH 00/30] i965: Overhaul resolves

On Fri, May 26, 2017 at 4:30 PM, Jason Ekstrand wrote: > This patch series does a complete overhaul of the current resolve handling > framework inside the i916 OpenGL driver. For HiZ and MCS, the current > resolve code is ok but not optimal. For CCS, however, it's pretty

[Mesa-dev] [PATCH 16/30] i965: Use the new resolve function for several simple cases

--- src/mesa/drivers/dri/i965/brw_context.c| 2 +- src/mesa/drivers/dri/i965/intel_blit.c | 14 -- src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 12 +--- src/mesa/drivers/dri/i965/intel_mipmap_tree.h | 18 ++

[Mesa-dev] [PATCH 19/30] i965: Move color rendering to the new resolve functions

--- src/mesa/drivers/dri/i965/brw_context.c | 35 +++ src/mesa/drivers/dri/i965/brw_draw.c | 4 +-- src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 48 +++ src/mesa/drivers/dri/i965/intel_mipmap_tree.h | 9 + 4 files changed, 63

[Mesa-dev] [PATCH 30/30] i965: Enable non-CCS_E fast-clears on gen9+

Sky Lake and above can fast-clear exactly the same set of formats as older hardware. The only restriction is that you can't *texture* from it unless the format supports CCS_E but you can fast-clear and render to it just fine. All of the code exists and now that we have sane resolves, we can

[Mesa-dev] [PATCH 13/30] i965: Combine render target resolve code

We have two different bits of resolve code for render targets: one in brw_draw where it's always been and one in brw_context to deal with sRGB on gen9. Let's pull them together. --- src/mesa/drivers/dri/i965/brw_context.c | 47 -

[Mesa-dev] [PATCH 29/30] i965: Delete intel_resolve_map

Now that we've moved over to the new array mechanism, it's no longer needed. --- src/mesa/drivers/dri/i965/Makefile.sources| 2 - src/mesa/drivers/dri/i965/brw_context.h | 1 - src/mesa/drivers/dri/i965/gen8_depth_state.c | 1 - src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 1

[Mesa-dev] [PATCH 20/30] i965: Remove an unneeded render_cache_set_check_flush

This is only needed to fix rendering corruptions caused by not flushing after doing a resolve operation. The resolve now does all the needed flushing so this is unnecessary. --- src/mesa/drivers/dri/i965/brw_context.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

[Mesa-dev] [PATCH 17/30] i965: Finalize miptrees before prepare_texture

In order to do resolves for texture views with different formats, we need intel_texture_object::_Format to be valid. Calling intel_finalize_mipmap_tree can safely be done multiple times in a row and should be a fairly cheap operation. --- src/mesa/drivers/dri/i965/brw_context.c | 4 1 file

[Mesa-dev] [PATCH 22/30] i965: Move images to the new resolve functions

--- src/mesa/drivers/dri/i965/brw_context.c | 9 + src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 9 + src/mesa/drivers/dri/i965/intel_mipmap_tree.h | 3 +++ 3 files changed, 13 insertions(+), 8 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_context.c

[Mesa-dev] [PATCH 21/30] i965: Move framebuffer fetch to the new resolve functions

--- src/mesa/drivers/dri/i965/brw_context.c | 6 ++--- src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 37 ++- src/mesa/drivers/dri/i965/intel_mipmap_tree.h | 4 +++ 3 files changed, 36 insertions(+), 11 deletions(-) diff --git

[Mesa-dev] [PATCH 25/30] i965: Use the new get/set_aux_state functions for color clears

--- src/mesa/drivers/dri/i965/brw_blorp.c | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_blorp.c b/src/mesa/drivers/dri/i965/brw_blorp.c index 3c605d1..6e860f0 100644 --- a/src/mesa/drivers/dri/i965/brw_blorp.c +++

[Mesa-dev] [PATCH 23/30] i965: Move depth to the new resolve functions

--- src/mesa/drivers/dri/i965/brw_clear.c | 12 ++-- src/mesa/drivers/dri/i965/brw_context.c | 7 --- src/mesa/drivers/dri/i965/brw_draw.c | 17 + src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 23 ++-

[Mesa-dev] [PATCH 24/30] i965: Move blorp to the new resolve functions

--- src/mesa/drivers/dri/i965/brw_blorp.c | 64 +++ 1 file changed, 19 insertions(+), 45 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_blorp.c b/src/mesa/drivers/dri/i965/brw_blorp.c index 8f5b169..3c605d1 100644 ---

[Mesa-dev] [PATCH 27/30] i965: Wholesale replace the color resolve tracking code

This commit reworks the resolve tracking for CCS and MCS to use the new isl_aux_state enum. This should provide much more accurate and easy to reason about tracking. In order to understand, for instance, the intel_miptree_prepare_ccs_access function, one only has to go look at the giant comment

[Mesa-dev] [PATCH 18/30] i965: Move texturing to the new resolve functions

--- src/mesa/drivers/dri/i965/brw_context.c | 55 +-- src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 55 +++ src/mesa/drivers/dri/i965/intel_mipmap_tree.h | 6 +++ 3 files changed, 71 insertions(+), 45 deletions(-) diff --git

[Mesa-dev] [PATCH 28/30] i965: Use the new tracking mechanism for HiZ

This is similar to the previous commit only for HiZ. For HiZ, apart from everything looking different, there is really only one functional change: We now track the ISL_AUX_STATE_COMPRESSED_NO_CLEAR state. Previously, if you rendered to a resolved slice of the miptree and then did a fast-clear

[Mesa-dev] [PATCH 07/30] i965: Get rid of intel_renderbuffer_resolve_*

There is exactly one caller so it's a bit pointless to have all of this plumbing. Just inline it at the one place it's used. --- src/mesa/drivers/dri/i965/brw_context.c | 7 +-- src/mesa/drivers/dri/i965/intel_fbo.c | 26 -- src/mesa/drivers/dri/i965/intel_fbo.h

[Mesa-dev] [PATCH 15/30] i965/miptree: Add new entrypoints for resolve management

This commit adds a new unified interface for doing resolves. The basic format is that, prior to any surface access such as texturing or rendering, you call intel_miptree_prepare_access. If the surface was written, you call intel_miptree_finish_write. These two functions take parameters which

[Mesa-dev] [PATCH 09/30] i965/miptree: Move color resolve on map to intel_miptree_map

None of the other methods such as blit work with CCS either so we need to do the resolve for all maps. This change also makes us only resolve the one slice we're mapping and not the entire image. --- src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 6 +- 1 file changed, 1 insertion(+), 5

[Mesa-dev] [PATCH 26/30] i965: Delete most of the old resolve interface

--- src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 91 +++ src/mesa/drivers/dri/i965/intel_mipmap_tree.h | 49 --- 2 files changed, 10 insertions(+), 130 deletions(-) diff --git a/src/mesa/drivers/dri/i965/intel_mipmap_tree.c

[Mesa-dev] [PATCH 14/30] intel/isl: Add an enum for describing auxiliary compression state

This enum describes all of the states that a auxiliary compressed surface can have. All of the states as well as normative language for referring to each of the compression operations is provided in the truly colossal comment for the new isl_aux_state enum. There is also a diagram showing how

[Mesa-dev] [PATCH 11/30] i965/blorp: Refactor do_single_blorp_clear

Previously, we had two checks for can_fast_clear and a tiny bit of shared code in between. This commit pulls all of the fast clear code together and duplicates the tiny bit that declares some surface structs and calls blorp_surf_for_miptree. The duplication is no real loss and we're about to

[Mesa-dev] [PATCH 05/30] i965/miptree: Clean up the depth resolve helpers a little

--- src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 70 --- 1 file changed, 30 insertions(+), 40 deletions(-) diff --git a/src/mesa/drivers/dri/i965/intel_mipmap_tree.c b/src/mesa/drivers/dri/i965/intel_mipmap_tree.c index 2701201..3a4fd89 100644 ---

[Mesa-dev] [PATCH 10/30] i965/blorp: Take an explicit fast clear op in resolve_color

--- src/mesa/drivers/dri/i965/brw_blorp.c | 15 ++- src/mesa/drivers/dri/i965/brw_blorp.h | 3 ++- src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 15 ++- 3 files changed, 18 insertions(+), 15 deletions(-) diff --git

[Mesa-dev] [PATCH 04/30] i965/miptree: Store fast clear colors in an isl_color_value

This commit, out of necessity, makes a number of changes at once: 1) Changes intel_mipmap_tree to store the clear color for both color and depth as an isl_color_value. 2) Changes the depth/stencil emit code to do the format conversion of the depth clear value on Haswell and earlier

[Mesa-dev] [PATCH 01/30] i965: Mark depth surfaces as needing a HiZ resolve after blitting

Cc: "17.0 17.1" --- src/mesa/drivers/dri/i965/intel_blit.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/mesa/drivers/dri/i965/intel_blit.c b/src/mesa/drivers/dri/i965/intel_blit.c index 2925fc2..b1e1eaa 100644 ---

[Mesa-dev] [PATCH 12/30] i965/blorp: Move MCS allocation earlier for clears

This way it happens before we call get_aux_state. --- src/mesa/drivers/dri/i965/brw_blorp.c | 28 ++-- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_blorp.c b/src/mesa/drivers/dri/i965/brw_blorp.c index 4c34395..8f5b169

[Mesa-dev] [PATCH 06/30] i965/miptree: Refactor intel_miptree_resolve_color

The new version now takes a range of levels as well as a range of layers. It should also be a tiny bit faster because it only walks the resolve_map list once instead of once per layer. --- src/mesa/drivers/dri/i965/brw_blorp.c | 3 +- src/mesa/drivers/dri/i965/brw_context.c | 9

[Mesa-dev] [PATCH 08/30] i965: Inline renderbuffer_att_set_needs_depth_resolve

--- src/mesa/drivers/dri/i965/brw_clear.c | 12 ++-- src/mesa/drivers/dri/i965/brw_draw.c | 12 +++- src/mesa/drivers/dri/i965/intel_fbo.c | 15 --- src/mesa/drivers/dri/i965/intel_fbo.h | 3 --- 4 files changed, 21 insertions(+), 21 deletions(-) diff --git

[Mesa-dev] [PATCH 03/30] intel/isl: Add a helper for determining if a color is 0/1

--- src/intel/isl/isl.c | 19 +++ src/intel/isl/isl.h | 4 2 files changed, 23 insertions(+) diff --git a/src/intel/isl/isl.c b/src/intel/isl/isl.c index 321850e..4eec2fd 100644 --- a/src/intel/isl/isl.c +++ b/src/intel/isl/isl.c @@ -267,6 +267,25 @@

[Mesa-dev] [PATCH 02/30] i965/surface_state: Images can't handle CCS at all

--- src/mesa/drivers/dri/i965/brw_wm_surface_state.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_wm_surface_state.c b/src/mesa/drivers/dri/i965/brw_wm_surface_state.c index a0fed60..f37dd93 100644 ---

[Mesa-dev] [PATCH 00/30] i965: Overhaul resolves

This patch series does a complete overhaul of the current resolve handling framework inside the i916 OpenGL driver. For HiZ and MCS, the current resolve code is ok but not optimal. For CCS, however, it's pretty bad. I've been looking at the code for a week now and I still don't know how Ben ever

Re: [Mesa-dev] [PATCH 06/24] i965/cnl: Add gen10 specific function declarations

On Fri, May 26, 2017 at 9:48 AM, Rafael Antognolli wrote: > On Wed, May 24, 2017 at 10:12:12AM -0700, Anuj Phogat wrote: >> On Mon, May 22, 2017 at 11:23 AM, Anuj Phogat wrote: >> > On Mon, May 22, 2017 at 10:07 AM, Rafael Antognolli >> >

Re: [Mesa-dev] Proposal to branch off old drivers

On Fri, May 26, 2017 at 6:27 PM, Timothy Arceri wrote: > > > On 27/05/17 08:11, Rob Clark wrote: >> >> On Fri, May 26, 2017 at 10:16 AM, Brian Paul wrote: >>> >>> I think a key point is what do the distro vendors think/want? That is, >>> do >>> vendors

Re: [Mesa-dev] Proposal to branch off old drivers

On 27/05/17 08:11, Rob Clark wrote: On Fri, May 26, 2017 at 10:16 AM, Brian Paul wrote: On 05/25/2017 06:45 PM, Timothy Arceri wrote: Hi all, Following on from the discussion here:

[Mesa-dev] [PATCH 1/9] i965/dri: Rewrite comment for intelCreateBuffer

The old comment pinned this function to X11 windows. In reality, this function serves more than X11 and more than just windows. --- src/mesa/drivers/dri/i965/intel_screen.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/intel_screen.c

[Mesa-dev] [PATCH 6/9] i965: Add whitespace in intel_update_image_buffers()

Improve readability. Add an empty line between two large 'if' blocks. --- src/mesa/drivers/dri/i965/brw_context.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/drivers/dri/i965/brw_context.c b/src/mesa/drivers/dri/i965/brw_context.c index 825912b7b5..3e3fe2d0ed 100644 ---

[Mesa-dev] [PATCH 9/9] i965: Fix type of brw_context::render_target_format[]

It's an array of isl_format, not uint32_t. This patch updates every reference to render_target_format[] git-grep. Trivial cleanup. No change in behavior. --- src/mesa/drivers/dri/i965/brw_blorp.c| 4 ++-- src/mesa/drivers/dri/i965/brw_context.h | 2 +-

[Mesa-dev] [PATCH 0/9] i965: A few tiny trivial cleanups

I was hacking on the i965/DRI glue, and on brw_surface_formats.c, and I found several little cleanups to make the code nicer. All these patches are super small. Chad Versace (9): i965/dri: Rewrite comment for intelCreateBuffer i965/dri: Combine declaration and assignment in intelCreateBuffer

[Mesa-dev] [PATCH 3/9] i965: Rename intel_create_renderbuffer

The name is misleading because the function is unrelated to GL renderbuffers. Rename it to intel_create_winsys_renderbuffer. --- src/mesa/drivers/dri/i965/intel_fbo.c| 11 ++- src/mesa/drivers/dri/i965/intel_fbo.h| 2 +- src/mesa/drivers/dri/i965/intel_screen.c | 4 ++-- 3 files

[Mesa-dev] [PATCH 7/9] i965: Document type of GLuint __DRIimage::format

It's either a mesa_format or mesa_array_format. --- src/mesa/drivers/dri/i965/intel_image.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/intel_image.h b/src/mesa/drivers/dri/i965/intel_image.h index ad426910e4..cf0610540f 100644 ---

[Mesa-dev] [PATCH 2/9] i965/dri: Combine declaration and assignment in intelCreateBuffer

Trivial cleanup. --- src/mesa/drivers/dri/i965/intel_screen.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/mesa/drivers/dri/i965/intel_screen.c b/src/mesa/drivers/dri/i965/intel_screen.c index 5de6f18b84..24123e7986 100644 ---

[Mesa-dev] [PATCH 8/9] i965: Move func to right comment block in brw_context.h

brw_init_surface_formats() is defined in brw_surface_formats.c, not brw_wm_surface_state.c. --- src/mesa/drivers/dri/i965/brw_context.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/brw_context.h b/src/mesa/drivers/dri/i965/brw_context.h index

[Mesa-dev] [PATCH 4/9] i965: Fix type of intel_update_image_buffers::format

It's a mesa_format, not an unsigned int. --- src/mesa/drivers/dri/i965/brw_context.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/brw_context.c b/src/mesa/drivers/dri/i965/brw_context.c index c815a0454d..adae921e57 100644 ---

[Mesa-dev] [PATCH 5/9] i965: Move an 'i' declaration into its 'for' loop

In intel_update_dri2_buffers(). Trivial cleanup. --- src/mesa/drivers/dri/i965/brw_context.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_context.c b/src/mesa/drivers/dri/i965/brw_context.c index adae921e57..825912b7b5 100644 ---

Re: [Mesa-dev] Proposal to branch off old drivers

On Fri, May 26, 2017 at 10:16 AM, Brian Paul wrote: > On 05/25/2017 06:45 PM, Timothy Arceri wrote: >> >> Hi all, >> >> Following on from the discussion here: >> >> >>

[Mesa-dev] [PATCH 0/2] egl/android: A few trivial cleanups

Chad Versace (2): egl/android: Align channel masks in HAL_PIXEL_FORMAT table egl/android: Drop unused 'format' param in get_back_bo() src/egl/drivers/dri2/platform_android.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) -- 2.13.0

[Mesa-dev] [PATCH 2/2] egl/android: Drop unused 'format' param in get_back_bo()

--- src/egl/drivers/dri2/platform_android.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/egl/drivers/dri2/platform_android.c b/src/egl/drivers/dri2/platform_android.c index e76e1678a8..4fed751eae 100644 --- a/src/egl/drivers/dri2/platform_android.c +++

[Mesa-dev] [PATCH 1/2] egl/android: Align channel masks in HAL_PIXEL_FORMAT table

Improves readability. No change in behavior. --- src/egl/drivers/dri2/platform_android.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/egl/drivers/dri2/platform_android.c b/src/egl/drivers/dri2/platform_android.c index de24a8f5c4..e76e1678a8 100644 ---

[Mesa-dev] [PATCH v2 3/4] i965: Move add_exec_bo()

To avoid a forward declaration in the next patch, move the definition of add_exec_bo() earlier. Signed-off-by: Chris Wilson Cc: Kenneth Graunke Cc: Jason Ekstrand --- src/mesa/drivers/dri/i965/intel_batchbuffer.c | 106

[Mesa-dev] [PATCH v2 2/4] i965: Use I915_EXEC_NO_RELOC

If we correctly fill the batch with the right relocation value, and that matches the expected location of the object, we can then tell the kernel it can forgo checking each individual relocation by only checking whether the object moved. v2: Rebase to apply ahead of I915_EXEC_HANDLE_LUT

[Mesa-dev] [PATCH v2 1/4] i965: Track last location of bo used for the batch

Borrow a trick from anv, and use the last known index for the bo to skip a search of the batch->exec_bo when adding a new relocation. In defence against the bo being used in multiple batches simultaneously, we check that this slot exists and points back to us. Signed-off-by: Chris Wilson

[Mesa-dev] [PATCH v2 4/4] RFC i965: Convert reloc.target_handle into an index for I915_EXEC_HANDLE_LUT

Passing the index of the target buffer via the reloc.target_handle is marginally more efficient for the kernel (it can avoid some allocations, and can use a direct lookup rather than a hash or search). It is also useful for ourselves as we can use the index into our exec_bos for other tasks. v2:

Re: [Mesa-dev] [PATCH] i965/copy_image: Use the blitter on gen5

Reviewed-by: Matt Turner ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH] i965/copy_image: Use the blitter on gen5

This was just an accidental typo in the refactoring. The intention was to try the blitter on gen4-5, not just gen4. --- src/mesa/drivers/dri/i965/intel_copy_image.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/intel_copy_image.c

Re: [Mesa-dev] [PATCH 42/43] i965: Use blorp for CopyImageSubData on gen4-5

On Fri, May 26, 2017 at 11:42 AM, Ilia Mirkin wrote: > On Tue, May 16, 2017 at 6:45 PM, Jason Ekstrand > wrote: > > @@ -118,55 +42,25 @@ copy_miptrees(struct brw_context *brw, > >int dst_x, int dst_y, int dst_z, unsigned dst_level, > >

Re: [Mesa-dev] [PATCH 42/43] i965: Use blorp for CopyImageSubData on gen4-5

On Tue, May 16, 2017 at 6:45 PM, Jason Ekstrand wrote: > @@ -118,55 +42,25 @@ copy_miptrees(struct brw_context *brw, >int dst_x, int dst_y, int dst_z, unsigned dst_level, >int src_width, int src_height) > { > - unsigned bw, bh; > - > - if

Re: [Mesa-dev] [PATCH 2/3] i965: Convert reloc.target_handle into an index for I915_EXEC_HANDLE_LUT

On Fri, May 26, 2017 at 10:47:18AM -0700, Kenneth Graunke wrote: > On Friday, May 26, 2017 4:25:20 AM PDT Chris Wilson wrote: > > Passing the index of the target buffer via the reloc.target_handle is > > marginally more efficient for the kernel (it can avoid some allocations, > > and can use a

Re: [Mesa-dev] [PATCH 2/3] i965: Convert reloc.target_handle into an index for I915_EXEC_HANDLE_LUT

On Friday, May 26, 2017 4:25:20 AM PDT Chris Wilson wrote: > Passing the index of the target buffer via the reloc.target_handle is > marginally more efficient for the kernel (it can avoid some allocations, > and can use a direct lookup rather than a hash or search). It is also > useful for

[Mesa-dev] [Bug 101136] [r600, regression] Colored lines appear in World of Warcraft on AMD ARUBA Trinity

https://bugs.freedesktop.org/show_bug.cgi?id=101136 Grigory changed: What|Removed |Added Resolution|--- |FIXED

[Mesa-dev] [Bug 101136] [r600, regression] Colored lines appear in World of Warcraft on AMD ARUBA Trinity

https://bugs.freedesktop.org/show_bug.cgi?id=101136 --- Comment #5 from Grigory --- The problem was solved the other day. -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the

[Mesa-dev] [Bug 101136] [r600, regression] Colored lines appear in World of Warcraft on AMD ARUBA Trinity

https://bugs.freedesktop.org/show_bug.cgi?id=101136 --- Comment #4 from Grigory --- If you tell me which commands to enter, I will write. I did not see the difference in the code. There are other cases. The main thing for me is that it works. Home users / strongly swore that

Re: [Mesa-dev] [PATCH 2/5] r600: remove custom and incomplete OpenCL code paths

On Fri, May 26, 2017 at 12:03 PM, Jan Vesely wrote: > On Fri, 2017-05-26 at 11:53 -0500, Aaron Watry wrote: > > On Fri, May 26, 2017 at 10:56 AM, Marek Olšák wrote: > > > > > I think this will break r600 clover support. I don't know if anybody > uses >

Re: [Mesa-dev] [PATCH 2/5] r600: remove custom and incomplete OpenCL code paths

On Fri, 2017-05-26 at 11:53 -0500, Aaron Watry wrote: > On Fri, May 26, 2017 at 10:56 AM, Marek Olšák wrote: > > > I think this will break r600 clover support. I don't know if anybody uses > > it. > > > > I just rebuild my desktop a month ago with a new Ryzen setup, which

Re: [Mesa-dev] [PATCH 2/5] r600: remove custom and incomplete OpenCL code paths

On Fri, May 26, 2017 at 10:56 AM, Marek Olšák wrote: > I think this will break r600 clover support. I don't know if anybody uses > it. > I just rebuild my desktop a month ago with a new Ryzen setup, which means that my BARTS is actually in my old machine now. WIth the

Re: [Mesa-dev] [PATCH 06/24] i965/cnl: Add gen10 specific function declarations

On Wed, May 24, 2017 at 10:12:12AM -0700, Anuj Phogat wrote: > On Mon, May 22, 2017 at 11:23 AM, Anuj Phogat wrote: > > On Mon, May 22, 2017 at 10:07 AM, Rafael Antognolli > > wrote: > >> On Fri, May 12, 2017 at 04:38:10PM -0700, Anuj Phogat

Re: [Mesa-dev] [PATCH 4/5] ac: remove amdgpu.h dependency

On Friday, 2017-05-26 16:32:52 +0100, Emil Velikov wrote: > From: Emil Velikov > > Add a couple of forward declarations and drop the amdgpu.h requirement. > > With this we can build the r300 and r600 drivers without the need for > amdgpu. > > Cc: Nicolai Hähnle

Re: [Mesa-dev] [PATCH 1/5] radeon: remove out of date LLVM_REVISION.txt

Reviewed-by: Marek Olšák Marek On Fri, May 26, 2017 at 5:32 PM, Emil Velikov wrote: > From: Emil Velikov > > The file was introduced to track which LLVM revision was required, yet > that has quickly gone out of shape.

Re: [Mesa-dev] [PATCH 4/5] ac: remove amdgpu.h dependency

ac_gpu_info.c should include amdgpu.h. Marek On Fri, May 26, 2017 at 5:32 PM, Emil Velikov wrote: > From: Emil Velikov > > Add a couple of forward declarations and drop the amdgpu.h requirement. > > With this we can build the r300 and r600

[Mesa-dev] Adding a SPIR-V back-end to the GLSL compiler

This is something that I have considered doing on multiple occasions and have given a significant amount of thought. Unfortunately, it has never made it particularly high on my priority list so no code has been written. However, there have been a number of people who have brought this up lately

Re: [Mesa-dev] [PATCH 2/5] r600: remove custom and incomplete OpenCL code paths

I think this will break r600 clover support. I don't know if anybody uses it. Marek On Fri, May 26, 2017 at 5:32 PM, Emil Velikov wrote: > From: Emil Velikov > > The code hasn't bee en touched in a very long time, and was never >

[Mesa-dev] [PATCH 2/5] r600: remove custom and incomplete OpenCL code paths

From: Emil Velikov The code hasn't bee en touched in a very long time, and was never completed. It is conditionally built only when OpenCL is selected at built time, and pulls the libamd_common static library, which in itself depends on amdgpu. With later commit(s)

[Mesa-dev] [PATCH 3/5] r600: remove libamd_common dependency

From: Emil Velikov Seemingly nothing in r600 depends on it any more. This is the second step to unwrapping the amdgpu dependency out of r600. Reported-by: udovdh on #dri-devel Cc: Nicolai Hähnle Cc: Marek Olšák

[Mesa-dev] [PATCH 5/5] Revert "amd/common: add missing libdrm include path"

This reverts commit 44b29dd7b6cdc1a3fde58c367b9de8081ac4167b. Should no longer be required as of last patch. Cc: Eric Engestrom --- src/amd/Makefile.common.am | 1 - 1 file changed, 1 deletion(-) diff --git a/src/amd/Makefile.common.am b/src/amd/Makefile.common.am

[Mesa-dev] [PATCH 4/5] ac: remove amdgpu.h dependency

From: Emil Velikov Add a couple of forward declarations and drop the amdgpu.h requirement. With this we can build the r300 and r600 drivers without the need for amdgpu. Cc: Nicolai Hähnle Cc: Marek Olšák Bugzilla:

[Mesa-dev] [PATCH 1/5] radeon: remove out of date LLVM_REVISION.txt

From: Emil Velikov The file was introduced to track which LLVM revision was required, yet that has quickly gone out of shape. It has seen no updates since 2013. Cc: Nicolai Hähnle Cc: Marek Olšák Signed-off-by: Emil

Re: [Mesa-dev] [Patch v2] osmesa: link with libunwind if enabled (v2)

Yes, please do. Alexandre Demers On Fri, May 26, 2017, 10:17 Brian Paul wrote: > On 05/25/2017 09:09 PM, Alexandre Demers wrote: > > Fixes linking error in libOSmesa when using libunwind. > > > > CXXLDlibOSMesa.la > >

[Mesa-dev] [PATCH] svga: fix git_sha1.h include path in Android.mk

Fixes the following building error: external/mesa/src/gallium/drivers/svga/svga_screen.c:26:10: fatal error: 'git_sha1.h' file not found ^ 1 error generated. --- src/gallium/drivers/svga/Android.mk | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git

Re: [Mesa-dev] [PATCH] radeonsi: drop useless memcmp() check in si_set_blend_color()

On 05/26/2017 04:42 PM, Marek Olšák wrote: On Fri, May 26, 2017 at 1:45 AM, Samuel Pitoiset wrote: err, used in si_begin_new_cs(). Ignore for now. Why? The patch seems good. It's not very important because radeonsi is behind u_threaded_context. Anyway: Because

Re: [Mesa-dev] [RFC PATCH 48/65] radeonsi: add a slab allocator for resident descriptors

On 05/26/2017 04:39 PM, Marek Olšák wrote: FYI, I've replied on some radeonsi patches and skimmed through the rest without Rbs. I'll do another review once there is version 2. Looks good to me. Marek On Fri, May 19, 2017 at 6:52 PM, Samuel Pitoiset wrote: For

Re: [Mesa-dev] [PATCH] radeonsi: drop useless memcmp() check in si_set_blend_color()

On Fri, May 26, 2017 at 1:45 AM, Samuel Pitoiset wrote: > err, used in si_begin_new_cs(). Ignore for now. Why? The patch seems good. It's not very important because radeonsi is behind u_threaded_context. Anyway: Reviewed-by: Marek Olšák Marek >

[Mesa-dev] [Bug 101136] [r600, regression] Colored lines appear in World of Warcraft on AMD ARUBA Trinity

https://bugs.freedesktop.org/show_bug.cgi?id=101136 Vedran Miletić changed: What|Removed |Added Summary|problems with mesa |[r600, regression]

Re: [Mesa-dev] [RFC PATCH 48/65] radeonsi: add a slab allocator for resident descriptors

FYI, I've replied on some radeonsi patches and skimmed through the rest without Rbs. I'll do another review once there is version 2. Marek On Fri, May 19, 2017 at 6:52 PM, Samuel Pitoiset wrote: > For each texture/image handles, we need to allocate a new > buffer for

[Mesa-dev] [Bug 101136] problems with mesa 17.2.0-devel

https://bugs.freedesktop.org/show_bug.cgi?id=101136 --- Comment #3 from Vedran Miletić --- Can you bisect to find out which change broke this? -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the

Re: [Mesa-dev] [RFC PATCH 02/65] mesa: implement ARB_bindless_texture

On 26.05.2017 14:09, Samuel Pitoiset wrote: On 05/24/2017 12:10 PM, Nicolai Hähnle wrote: [snip] +static GLuint64 +get_texture_handle(struct gl_context *ctx, struct gl_texture_object *texObj, + struct gl_sampler_object *sampObj) +{ + struct gl_texture_handle_object

Re: [Mesa-dev] Proposal to branch off old drivers

On 05/25/2017 06:45 PM, Timothy Arceri wrote: Hi all, Following on from the discussion here:

Re: [Mesa-dev] [PATCH] amd/common: add vcn dec ip info query for amdgpu version 3.17

Hi Emil, On 05/26/2017 09:07 AM, Emil Velikov wrote: Hi Leo, On 26 May 2017 at 12:24, Leo Liu wrote: Signed-off-by: Leo Liu --- src/amd/common/ac_gpu_info.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git

Re: [Mesa-dev] [PATCH v4 4/4] glthread/gallium: require safe_glthread to start glthread

There were some comments, but the overall idea sounds good to me. Marek On Sun, May 21, 2017 at 4:59 PM, Gregory Hainaut wrote: > Print an error message for the user if the requirement isn't met, or > we're not thread safe. > > v2: based on Nicolai feedbacks > Check

Re: [Mesa-dev] [Patch v2] osmesa: link with libunwind if enabled (v2)

On 05/25/2017 09:09 PM, Alexandre Demers wrote: Fixes linking error in libOSmesa when using libunwind. CXXLDlibOSMesa.la src/gallium/auxiliary/.libs/libgallium.a(u_debug_stack.o): In function `symbol_name_cached': ./src/gallium/auxiliary/util/u_debug_stack.c:87: undefined reference to

Re: [Mesa-dev] [PATCH] configure.ac: Add --with-wayland-scanner-path

Hi Jussi, On 26 May 2017 at 14:55, Jussi Kukkonen wrote: > On 26 May 2017 at 14:32, Emil Velikov wrote: >> b) with a wrapper script - see [1]. >> I think that the "export PKG_CONFIG_DIR=" is a typo (should be ..PATH >> instead) and is not

Re: [Mesa-dev] [PATCH v4 1/4] dri: Extend __DRIbackgroundCallableExtensionRec to include a callback that checks for thread safety

On Sun, May 21, 2017 at 4:59 PM, Gregory Hainaut wrote: > DRI-drivers could call Xlib functions, for example to allocate a new back > buffer. > > When glthread is enabled, the driver runs mostly on a separate thread. > Therefore we need to guarantee the thread safety

Re: [Mesa-dev] [PATCH] amd/common: add vcn dec ip info query for amdgpu version 3.17

On Fri, May 26, 2017 at 3:07 PM, Emil Velikov wrote: > Hi Leo, > > On 26 May 2017 at 12:24, Leo Liu wrote: >> Signed-off-by: Leo Liu >> --- >> src/amd/common/ac_gpu_info.c | 10 +- >> 1 file changed, 9 insertions(+), 1

Re: [Mesa-dev] [PATCH] configure.ac: Add --with-wayland-scanner-path

On 26 May 2017 at 14:32, Emil Velikov wrote: > > On 26 May 2017 at 08:52, Jussi Kukkonen wrote: > > > > > > On 24 May 2017 at 16:39, Emil Velikov wrote: > >> > >> Hi Jussi, > >> > >> On 23 May 2017 at 09:13, Jussi

Re: [Mesa-dev] [PATCH mesa] amd/common: add missing libdrm include path

Reviewed-by: Marek Olšák Marek On Fri, May 26, 2017 at 2:42 PM, Eric Engestrom wrote: > Fixes: de9dd4f9f1bb5984c554 ("ac/radeonsi: move struct radeon_info to > ac_gpu_info.h") > Cc: Nicolai Hähnle > Cc: Marek Olšák

Re: [Mesa-dev] [PATCH] amd/common: add vcn dec ip info query for amdgpu version 3.17

Hi Leo, On 26 May 2017 at 12:24, Leo Liu wrote: > Signed-off-by: Leo Liu > --- > src/amd/common/ac_gpu_info.c | 10 +- > 1 file changed, 9 insertions(+), 1 deletion(-) > > diff --git a/src/amd/common/ac_gpu_info.c b/src/amd/common/ac_gpu_info.c > index

Re: [Mesa-dev] Proposal to branch off old drivers

On Fri, May 26, 2017 at 2:34 PM, Timothy Arceri wrote: > On 26/05/17 21:38, Marek Olšák wrote: > >> On May 26, 2017 2:45 AM, "Timothy Arceri" > > wrote: >> >> Hi all, >> >> Following on from the discussion here:

[Mesa-dev] [Bug 101200] No debug info generated for symbol glBlendFuncSeparate since Mesa 17

https://bugs.freedesktop.org/show_bug.cgi?id=101200 Bug ID: 101200 Summary: No debug info generated for symbol glBlendFuncSeparate since Mesa 17 Product: Mesa Version: 17.0 Hardware: x86-64 (AMD64) OS:

[Mesa-dev] [PATCH mesa] amd/common: add missing libdrm include path

Fixes: de9dd4f9f1bb5984c554 ("ac/radeonsi: move struct radeon_info to ac_gpu_info.h") Cc: Nicolai Hähnle Cc: Marek Olšák Signed-off-by: Eric Engestrom --- src/amd/Makefile.common.am | 1 + 1 file changed, 1 insertion(+)

  1   2   >