[Mesa-dev] [PATCH] scons: add code to generate format_fallback.c file

2017-06-27 Thread Brian Paul
Fixes broken SCons build since a1983223d8839a0c9 --- src/mesa/SConscript | 7 +++ 1 file changed, 7 insertions(+) diff --git a/src/mesa/SConscript b/src/mesa/SConscript index fa4efe1..b63e15a 100644 --- a/src/mesa/SConscript +++ b/src/mesa/SConscript @@ -79,6 +79,13 @@ format_unpack =

Re: [Mesa-dev] [PATCH 42/42] mesa: add KHR_no_error support for glClear()

2017-06-27 Thread Timothy Arceri
41-42: Reviewed-by: Timothy Arceri On 27/06/17 21:20, Samuel Pitoiset wrote: Signed-off-by: Samuel Pitoiset --- src/mapi/glapi/gen/gl_API.xml | 2 +- src/mesa/main/clear.c | 8 src/mesa/main/clear.h | 2 ++ 3

Re: [Mesa-dev] [PATCH 40/42] mesa: add KHR_no_error support for glBindAttribLocation()

2017-06-27 Thread Timothy Arceri
On 27/06/17 21:20, Samuel Pitoiset wrote: Signed-off-by: Samuel Pitoiset --- src/mapi/glapi/gen/gl_API.xml | 2 +- src/mesa/main/shader_query.cpp | 11 +++ src/mesa/main/shaderapi.h | 3 +++ 3 files changed, 15 insertions(+), 1 deletion(-) diff

Re: [Mesa-dev] [PATCH 37/42] mesa: create read_buffer_err() and always inline read_buffer()

2017-06-27 Thread Timothy Arceri
On 27/06/17 21:20, Samuel Pitoiset wrote: Signed-off-by: Samuel Pitoiset --- src/mesa/main/buffers.c | 46 +- 1 file changed, 29 insertions(+), 17 deletions(-) diff --git a/src/mesa/main/buffers.c

Re: [Mesa-dev] [PATCH 01/12] genxml: Silence about a billion unused parameter warnings

2017-06-27 Thread Dylan Baker
Quoting Dylan Baker (2017-06-27 10:04:47) > Quoting Ian Romanick (2017-06-26 16:22:34) > > From: Ian Romanick > > > > v2: Use textwrap.dedent to make the source line a lot shorter. > > Shortening (?) the line was requested by Jason. > > > > Signed-off-by: Ian Romanick

[Mesa-dev] [Bug 101614] OSMesa 17.1.3 simd16intrin build FAIL on Win/MinGW - 'expected initializer before _simd16_setzero_ps ...'

2017-06-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=101614 Bug ID: 101614 Summary: OSMesa 17.1.3 simd16intrin build FAIL on Win/MinGW - 'expected initializer before _simd16_setzero_ps ...' Product: Mesa Version: 17.1 Hardware:

Re: [Mesa-dev] [PATCH 25/42] mesa: prepare create_render_buffers() for KHR_no_error support

2017-06-27 Thread Timothy Arceri
On 27/06/17 21:20, Samuel Pitoiset wrote: Signed-off-by: Samuel Pitoiset --- src/mesa/main/fbobject.c | 30 -- 1 file changed, 20 insertions(+), 10 deletions(-) diff --git a/src/mesa/main/fbobject.c b/src/mesa/main/fbobject.c index

Re: [Mesa-dev] [PATCH 13/30] i965/miptree: Add an explicit format parameter to create_for_dri_image

2017-06-27 Thread Jason Ekstrand
On Tue, Jun 27, 2017 at 12:49 PM, Chad Versace wrote: > On Fri 16 Jun 2017, Jason Ekstrand wrote: > > --- > > src/mesa/drivers/dri/i965/intel_fbo.c | 3 ++- > > src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 7 --- > >

Re: [Mesa-dev] [PATCH 12/30] i965/miptree: Allocate mt earlier in update winsys

2017-06-27 Thread Jason Ekstrand
On Tue, Jun 27, 2017 at 12:19 PM, Chad Versace wrote: > On Mon 26 Jun 2017, Pohjolainen, Topi wrote: > > On Fri, Jun 16, 2017 at 03:41:34PM -0700, Jason Ekstrand wrote: > > > From: Ben Widawsky > > > > > > Allows us to continue utilizing common

Re: [Mesa-dev] [PATCH 27/30] i965/screen: Support import and export of surfaces with CCS

2017-06-27 Thread Jason Ekstrand
On Mon, Jun 26, 2017 at 12:50 PM, Pohjolainen, Topi < topi.pohjolai...@gmail.com> wrote: > On Fri, Jun 16, 2017 at 03:41:49PM -0700, Jason Ekstrand wrote: > > --- > > src/mesa/drivers/dri/i965/intel_screen.c | 55 > +--- > > 1 file changed, 50 insertions(+), 5

Re: [Mesa-dev] [PATCH 1/2] vulkan/util: Introduce format utilities

2017-06-27 Thread Dave Airlie
> > > Drive-by: Yes, I agree that this doesn't match Vulkan particularly well. > It's a very X11 or drm_fourcc way of described formats and is nothing like > anything else we have in mesa. That doesn't mean it's strictly wrong, just > that it's awkward to people who are used to some of the other

Re: [Mesa-dev] [PATCH 1/2] vulkan/util: Introduce format utilities

2017-06-27 Thread Jason Ekstrand
On Tue, Jun 27, 2017 at 4:29 PM, Chad Versace wrote: > On Fri 23 Jun 2017, alexandros.frant...@collabora.com wrote: > > From: Alexandros Frantzis > > > > Introduce utilities to describe, find and compare Vulkan formats based > > on

[Mesa-dev] [AppVeyor] mesa master #4772 failed

2017-06-27 Thread AppVeyor
Build mesa 4772 failed Commit 74db56b97a by Chad Versace on 5/30/2017 7:27 PM: i965: Add a RGBX->RGBA fallback for glEGLImageTextureTarget2D()\n\nThis enables support for importing RGBX EGLImage textures on\nSkylake.\n\nChrome OS needs support for RGBX

Re: [Mesa-dev] [PATCH 3/3] i965/dri: Support R8G8B8A8 and R8G8B8X8 configs

2017-06-27 Thread Chad Versace
Daniel, I have a question for you below. On Tue 27 Jun 2017, Kenneth Graunke wrote: > On Tuesday, June 27, 2017 11:00:48 AM PDT Chad Versace wrote: > > The Android framework requires support for EGLConfigs with > > HAL_PIXEL_FORMAT_RGBX_ and HAL_PIXEL_FORMAT_RGBA_. > > > > Even though

Re: [Mesa-dev] [PATCH 23/42] mesa: prepare create_program_pipelines() for KHR_no_error support

2017-06-27 Thread Timothy Arceri
On 27/06/17 21:20, Samuel Pitoiset wrote: Signed-off-by: Samuel Pitoiset --- src/mesa/main/pipelineobj.c | 33 +++-- 1 file changed, 19 insertions(+), 14 deletions(-) diff --git a/src/mesa/main/pipelineobj.c

Re: [Mesa-dev] [PATCH 21/42] mesa: prepare create_samplers() helper for KHR_no_error support

2017-06-27 Thread Timothy Arceri
On 27/06/17 21:20, Samuel Pitoiset wrote: Signed-off-by: Samuel Pitoiset --- src/mesa/main/samplerobj.c | 37 ++--- 1 file changed, 22 insertions(+), 15 deletions(-) diff --git a/src/mesa/main/samplerobj.c

Re: [Mesa-dev] [PATCH 0/2] vulkan/wsi/wayland: Improve surface format support

2017-06-27 Thread Chad Versace
On Fri 23 Jun 2017, alexandros.frant...@collabora.com wrote: > From: Alexandros Frantzis > > Improve the surface format support in the Wayland Vulkan WSI, by > automating the matching between wl_drm and Vulkan formats. The same > mechanism can be used to

Re: [Mesa-dev] [PATCH 19/42] mesa: prepare create_textures() helper for KHR_no_error support

2017-06-27 Thread Timothy Arceri
On 27/06/17 21:20, Samuel Pitoiset wrote: Signed-off-by: Samuel Pitoiset --- src/mesa/main/texobj.c | 34 +- 1 file changed, 21 insertions(+), 13 deletions(-) diff --git a/src/mesa/main/texobj.c b/src/mesa/main/texobj.c index

Re: [Mesa-dev] [PATCH 1/2] vulkan/util: Introduce format utilities

2017-06-27 Thread Chad Versace
On Fri 23 Jun 2017, alexandros.frant...@collabora.com wrote: > From: Alexandros Frantzis > > Introduce utilities to describe, find and compare Vulkan formats based > on their color component masks, taking into account system endianness. > --- >

Re: [Mesa-dev] [PATCH 16/42] mesa: prepare create_buffers() helper for KHR_no_error support

2017-06-27 Thread Timothy Arceri
On 27/06/17 21:20, Samuel Pitoiset wrote: Signed-off-by: Samuel Pitoiset --- src/mesa/main/bufferobj.c | 45 ++--- 1 file changed, 26 insertions(+), 19 deletions(-) diff --git a/src/mesa/main/bufferobj.c

Re: [Mesa-dev] [PATCH 15/42] mesa: add KHR_no_error support for glBindTextureUnit()

2017-06-27 Thread Timothy Arceri
5-15: Reviewed-by: Timothy Arceri On 27/06/17 21:20, Samuel Pitoiset wrote: Signed-off-by: Samuel Pitoiset --- src/mapi/glapi/gen/ARB_direct_state_access.xml | 2 +- src/mesa/main/texobj.c | 8

Re: [Mesa-dev] [PATCH 04/42] mesa: pass the 'caller' function to create_shader()

2017-06-27 Thread Timothy Arceri
On 27/06/17 21:20, Samuel Pitoiset wrote: Signed-off-by: Samuel Pitoiset --- src/mesa/main/shaderapi.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/mesa/main/shaderapi.c b/src/mesa/main/shaderapi.c index

Re: [Mesa-dev] [PATCH 03/42] mesa: add KHR_no_error support for glAttachShader() and glAttachObjectARB()

2017-06-27 Thread Timothy Arceri
On 27/06/17 21:20, Samuel Pitoiset wrote: Signed-off-by: Samuel Pitoiset --- src/mapi/glapi/gen/gl_API.xml | 4 ++-- src/mesa/main/shaderapi.c | 28 src/mesa/main/shaderapi.h | 7 ++- 3 files changed, 36 insertions(+), 3

[Mesa-dev] [PATCH] intel/compiler: Don't use opt_sampler_eot() optimization on gen10+

2017-06-27 Thread Anuj Phogat
This optimization has been removed on gen10+. Signed-off-by: Anuj Phogat --- src/intel/compiler/brw_fs.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/intel/compiler/brw_fs.cpp b/src/intel/compiler/brw_fs.cpp index 43b6e34..a2a99b7 100644 ---

[Mesa-dev] [PATCH] swr: conditionally validate vertex buffer state

2017-06-27 Thread Bruce Cherniak
Vertex buffer state doesn't need to be validated on every call, only on dirty _NEW_VERTEX or indexed draws. Unconditional validation was introduced as part of patch 330d0607ed6, "remove pipe_index_buffer and set_index_buffer", with the expectation we'd optimize later. ---

Re: [Mesa-dev] [PATCH 1/3] mesa: GL_TEXTURE_BORDER_COLOR exists in OpenGL 1.0, so don't depend on GL_ARB_texture_border_clamp

2017-06-27 Thread Ilia Mirkin
On Tue, Jun 27, 2017 at 3:18 PM, Ian Romanick wrote: > On 06/27/2017 11:23 AM, Ilia Mirkin wrote: >> On Tue, Jun 27, 2017 at 1:09 PM, Ian Romanick wrote: >>> From: Ian Romanick >>> >>> On NV20 (and probably also on earlier NV

Re: [Mesa-dev] [PATCH 18/30] intel/isl: Add basic modifier introspection

2017-06-27 Thread Chad Versace
On Fri 16 Jun 2017, Jason Ekstrand wrote: > --- > src/intel/Makefile.am | 1 + > src/intel/Makefile.sources | 1 + > src/intel/isl/isl.h| 22 + > src/intel/isl/isl_drm.c| 59 > ++ > 4 files changed, 83 insertions(+) >

Re: [Mesa-dev] [PATCH 17/30] i965: Add an isl_device to intel_screen

2017-06-27 Thread Chad Versace
On Fri 16 Jun 2017, Jason Ekstrand wrote: > --- > src/mesa/drivers/dri/i965/brw_context.c | 2 +- > src/mesa/drivers/dri/i965/intel_screen.c | 3 +++ > src/mesa/drivers/dri/i965/intel_screen.h | 4 > 3 files changed, 8 insertions(+), 1 deletion(-) Patch 17 is Reviewed-by: Chad Versace

Re: [Mesa-dev] [PATCH 13/30] i965/miptree: Add an explicit format parameter to create_for_dri_image

2017-06-27 Thread Chad Versace
On Fri 16 Jun 2017, Jason Ekstrand wrote: > --- > src/mesa/drivers/dri/i965/intel_fbo.c | 3 ++- > src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 7 --- > src/mesa/drivers/dri/i965/intel_mipmap_tree.h | 3 ++- > src/mesa/drivers/dri/i965/intel_tex_image.c | 3 ++- > 4 files

Re: [Mesa-dev] [PATCH 3/3] i965/dri: Support R8G8B8A8 and R8G8B8X8 configs

2017-06-27 Thread Kenneth Graunke
On Tuesday, June 27, 2017 11:00:48 AM PDT Chad Versace wrote: > The Android framework requires support for EGLConfigs with > HAL_PIXEL_FORMAT_RGBX_ and HAL_PIXEL_FORMAT_RGBA_. > > Even though all RGBX formats are disabled on gen9 by > brw_surface_formats.c, the new configs work correctly

Re: [Mesa-dev] [PATCH v2] mesa: Add _mesa_format_fallback_rgba_to_rgbx()

2017-06-27 Thread Chad Versace
On Tue 20 Jun 2017, Jason Ekstrand wrote: > From: Chad Versace > > The new function takes a mesa_format and, if the format is an alpha > format with a non-alpha variant, returns the non-alpha format. > Otherwise, it returns the original format. > > Example: > input

Re: [Mesa-dev] [PATCH 12/30] i965/miptree: Allocate mt earlier in update winsys

2017-06-27 Thread Chad Versace
On Mon 26 Jun 2017, Pohjolainen, Topi wrote: > On Fri, Jun 16, 2017 at 03:41:34PM -0700, Jason Ekstrand wrote: > > From: Ben Widawsky > > > > Allows us to continue utilizing common miptree creation using __DRIimage > > without creating a new DRIimage (for the

Re: [Mesa-dev] [PATCH 1/3] mesa: GL_TEXTURE_BORDER_COLOR exists in OpenGL 1.0, so don't depend on GL_ARB_texture_border_clamp

2017-06-27 Thread Ian Romanick
On 06/27/2017 11:23 AM, Ilia Mirkin wrote: > On Tue, Jun 27, 2017 at 1:09 PM, Ian Romanick wrote: >> From: Ian Romanick >> >> On NV20 (and probably also on earlier NV GPUs that lack >> GL_ARB_texture_border_clamp) fixes the following piglit tests:

Re: [Mesa-dev] [RFT PATCH 2/2] nv20: enable ARB_texture_border_clamp support

2017-06-27 Thread Ian Romanick
On 06/27/2017 11:16 AM, Roland Scheidegger wrote: > Am 27.06.2017 um 20:10 schrieb Ian Romanick: >> On 06/27/2017 11:00 AM, Ilia Mirkin wrote: >>> On Tue, Jun 27, 2017 at 1:11 PM, Ian Romanick wrote: On 06/27/2017 02:59 AM, Timothy Arceri wrote: > Just curious. Can

Re: [Mesa-dev] [PATCH 1/3] mesa: GL_TEXTURE_BORDER_COLOR exists in OpenGL 1.0, so don't depend on GL_ARB_texture_border_clamp

2017-06-27 Thread Ilia Mirkin
On Tue, Jun 27, 2017 at 1:09 PM, Ian Romanick wrote: > From: Ian Romanick > > On NV20 (and probably also on earlier NV GPUs that lack > GL_ARB_texture_border_clamp) fixes the following piglit tests: > > gl-1.0-beginend-coverage

Re: [Mesa-dev] [PATCH 00/30] i965: Add support for I915_FORMAT_MOD_Y_TILED_CCS

2017-06-27 Thread Pohjolainen, Topi
On Wed, Jun 21, 2017 at 05:51:00PM -0700, Jason Ekstrand wrote: > On Fri, Jun 16, 2017 at 3:41 PM, Jason Ekstrand > wrote: > > > This series is a rework of Ben's series to enable the CCS format modifier. > > It started as an attempt to rebase his original patches on top of

Re: [Mesa-dev] [PATCH 19/30] intel/isl: Add a helper to convert tilings fro ISL to i915

2017-06-27 Thread Pohjolainen, Topi
In the subject: s/fro/from/ On Fri, Jun 16, 2017 at 03:41:41PM -0700, Jason Ekstrand wrote: > --- > src/intel/isl/isl.h | 3 +++ > src/intel/isl/isl_drm.c | 23 +++ > 2 files changed, 26 insertions(+) > > diff --git a/src/intel/isl/isl.h b/src/intel/isl/isl.h > index

Re: [Mesa-dev] [RFT PATCH 2/2] nv20: enable ARB_texture_border_clamp support

2017-06-27 Thread Roland Scheidegger
Am 27.06.2017 um 20:10 schrieb Ian Romanick: > On 06/27/2017 11:00 AM, Ilia Mirkin wrote: >> On Tue, Jun 27, 2017 at 1:11 PM, Ian Romanick wrote: >>> On 06/27/2017 02:59 AM, Timothy Arceri wrote: Just curious. Can this extension be added to NV04 and NV10? As those are

Re: [Mesa-dev] [RFT PATCH 2/2] nv20: enable ARB_texture_border_clamp support

2017-06-27 Thread Ilia Mirkin
On Tue, Jun 27, 2017 at 2:10 PM, Ian Romanick wrote: > On 06/27/2017 11:00 AM, Ilia Mirkin wrote: >> On Tue, Jun 27, 2017 at 1:11 PM, Ian Romanick wrote: >>> On 06/27/2017 02:59 AM, Timothy Arceri wrote: Just curious. Can this extension be added

Re: [Mesa-dev] [PATCH 12/12] i965: Assert that blorp always handles color blits

2017-06-27 Thread Ian Romanick
On 06/27/2017 10:53 AM, Kenneth Graunke wrote: > On Monday, June 26, 2017 4:22:45 PM PDT Ian Romanick wrote: >> From: Ian Romanick >> >> --- >> src/mesa/drivers/dri/i965/brw_blorp.c | 2 ++ >> src/mesa/drivers/dri/i965/intel_fbo.c | 3 +++ >> 2 files changed, 5

Re: [Mesa-dev] [RFT PATCH 2/2] nv20: enable ARB_texture_border_clamp support

2017-06-27 Thread Ian Romanick
On 06/27/2017 11:00 AM, Ilia Mirkin wrote: > On Tue, Jun 27, 2017 at 1:11 PM, Ian Romanick wrote: >> On 06/27/2017 02:59 AM, Timothy Arceri wrote: >>> Just curious. Can this extension be added to NV04 and NV10? As those are >>> the only drivers that don't currently support

[Mesa-dev] [PATCH 3/3] i965/dri: Support R8G8B8A8 and R8G8B8X8 configs

2017-06-27 Thread Chad Versace
The Android framework requires support for EGLConfigs with HAL_PIXEL_FORMAT_RGBX_ and HAL_PIXEL_FORMAT_RGBA_. Even though all RGBX formats are disabled on gen9 by brw_surface_formats.c, the new configs work correctly on Broxton thanks to _mesa_format_fallback_rgbx_to_rgba(). On GLX, this

[Mesa-dev] [PATCH v2 03/13] swr/rast: gen_backends.py removal of commented debug prints

2017-06-27 Thread Tim Rowley
--- src/gallium/drivers/swr/rasterizer/codegen/gen_backends.py | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/src/gallium/drivers/swr/rasterizer/codegen/gen_backends.py b/src/gallium/drivers/swr/rasterizer/codegen/gen_backends.py index 09f40fa..f65f764 100644 ---

[Mesa-dev] [PATCH v2 02/13] swr/rast: gen_backends.py quote cleanup

2017-06-27 Thread Tim Rowley
--- .../drivers/swr/rasterizer/codegen/gen_backends.py | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/src/gallium/drivers/swr/rasterizer/codegen/gen_backends.py b/src/gallium/drivers/swr/rasterizer/codegen/gen_backends.py index d9e938a..09f40fa 100644

[Mesa-dev] [PATCH v2 05/13] swr/rast: Support dynamically sized vertex layout

2017-06-27 Thread Tim Rowley
Each shader stage state (VS, TS, GS, SO, BE/CLIP) now has a vertexAttribOffset to specify the offset to the start of the general attribute section of the incoming verts for that stage. It is up to the driver to set this up correctly based on the active stages. All the shader stages use this value

[Mesa-dev] [PATCH v2 06/13] swr/rast: gen_backends.py remove extraneous semicolon

2017-06-27 Thread Tim Rowley
--- src/gallium/drivers/swr/rasterizer/codegen/gen_backends.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/swr/rasterizer/codegen/gen_backends.py b/src/gallium/drivers/swr/rasterizer/codegen/gen_backends.py index 3f0790c..2fc91d1 100644 ---

[Mesa-dev] [PATCH v2 00/13] swr: update rasterizer

2017-06-27 Thread Tim Rowley
Highlights include splitting the heavily templated files into multiple chunks to speed compile (2x for a large machine), and switching the simd intrinsic usage from a macro-based header to a more c++ feeling library. No regressions on piglit or vtk tests, passes "make dist"/compile. v2: *

[Mesa-dev] [PATCH v2 11/13] swr/rast: Fix missing setup of psContext.pColorBuffer

2017-06-27 Thread Tim Rowley
Fixes render target read access from pixel shaders. --- .../drivers/swr/rasterizer/core/backend_sample.cpp| 15 +++ .../drivers/swr/rasterizer/core/backend_singlesample.cpp | 15 +++ 2 files changed, 14 insertions(+), 16 deletions(-) diff --git

[Mesa-dev] [PATCH v2 13/13] swr/rast: increase number of possible draws in flight

2017-06-27 Thread Tim Rowley
Increases performance of some large workloads on KNL by ~30%. --- src/gallium/drivers/swr/rasterizer/codegen/knob_defs.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/swr/rasterizer/codegen/knob_defs.py

[Mesa-dev] [PATCH v2 09/13] scons: allow .inl file extension

2017-06-27 Thread Tim Rowley
Intended for header files which are not meant to be included directly. --- scons/custom.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scons/custom.py b/scons/custom.py index 544b15d..955247c 100644 --- a/scons/custom.py +++ b/scons/custom.py @@ -281,7 +281,7 @@ def

[Mesa-dev] [PATCH v2 08/13] swr/rast: Fix unused variable warnings

2017-06-27 Thread Tim Rowley
--- src/gallium/drivers/swr/rasterizer/core/binner.cpp | 6 -- 1 file changed, 6 deletions(-) diff --git a/src/gallium/drivers/swr/rasterizer/core/binner.cpp b/src/gallium/drivers/swr/rasterizer/core/binner.cpp index 19eef9b..29d2f1c 100644 ---

[Mesa-dev] [PATCH v2 01/13] swr/rast: generators will create target directories

2017-06-27 Thread Tim Rowley
--- src/gallium/drivers/swr/rasterizer/codegen/gen_common.py | 7 +++ 1 file changed, 7 insertions(+) diff --git a/src/gallium/drivers/swr/rasterizer/codegen/gen_common.py b/src/gallium/drivers/swr/rasterizer/codegen/gen_common.py index 07b455a..7f53ec6 100644 ---

[Mesa-dev] [PATCH v2 12/13] swr/rast: move default split size from driver to rasterizer

2017-06-27 Thread Tim Rowley
--- src/gallium/drivers/swr/rasterizer/codegen/knob_defs.py | 2 +- src/gallium/drivers/swr/swr_screen.cpp | 4 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/src/gallium/drivers/swr/rasterizer/codegen/knob_defs.py

[Mesa-dev] [PATCH 2/3] i965: Add a RGBX->RGBA fallback for glEGLImageTextureTarget2D()

2017-06-27 Thread Chad Versace
This enables support for importing RGBX EGLImage textures on Skylake. Chrome OS needs support for RGBX EGLImage textures because because the Android framework produces HAL_PIXEL_FORMAT_RGBX winsys surfaces, which the Chrome OS compositor consumes as dma_bufs. On hardware for which

[Mesa-dev] [PATCH 1/3] mesa: Add _mesa_format_fallback_rgbx_to_rgba() [v2]

2017-06-27 Thread Chad Versace
The new function takes a mesa_format and, if the format is an alpha format with a non-alpha variant, returns the non-alpha format. Otherwise, it returns the original format. Example: input -> output // Fallback exists MESA_FORMAT_R8G8B8X8_UNORM -> MESA_FORMAT_R8G8B8A8_UNORM

Re: [Mesa-dev] [PATCH 12/30] i965/miptree: Allocate mt earlier in update winsys

2017-06-27 Thread Pohjolainen, Topi
On Mon, Jun 26, 2017 at 09:36:34PM +0300, Pohjolainen, Topi wrote: > On Fri, Jun 16, 2017 at 03:41:34PM -0700, Jason Ekstrand wrote: > > From: Ben Widawsky > > > > Allows us to continue utilizing common miptree creation using __DRIimage > > without creating a new DRIimage (for

[Mesa-dev] [PATCH 0/3 v2] i965: Add RGBX, RGBA configs, even on gen9

2017-06-27 Thread Chad Versace
The Android framework requires support for EGLConfigs with HAL_PIXEL_FORMAT_RGBX_ and HAL_PIXEL_FORMAT_RGBA_. This prevents Chrome OS from updating its Android drivers, because earlier this year Intel disabled all rgbx formats for gen >=9 in brw_surface_formats.c. This patch series safely

Re: [Mesa-dev] [RFT PATCH 2/2] nv20: enable ARB_texture_border_clamp support

2017-06-27 Thread Ilia Mirkin
On Tue, Jun 27, 2017 at 1:11 PM, Ian Romanick wrote: > On 06/27/2017 02:59 AM, Timothy Arceri wrote: >> Just curious. Can this extension be added to NV04 and NV10? As those are >> the only drivers that don't currently support it. >> >> I have cards I could test those with,

Re: [Mesa-dev] [PATCH] i965: Fix anisotropic filtering for mag filter

2017-06-27 Thread Kenneth Graunke
On Tuesday, June 27, 2017 10:37:16 AM PDT Rafael Antognolli wrote: > From: Eero Tamminen > > Commit f8d69beed49c64f883bb8ffb28d4960306baf575 moving sampler > handling to genxml messed up change done by commit > 6a7c5257cac23cd9767aa4bc8fdab68925b11157. > > This broke

Re: [Mesa-dev] [PATCH 12/12] i965: Assert that blorp always handles color blits

2017-06-27 Thread Kenneth Graunke
On Monday, June 26, 2017 4:22:45 PM PDT Ian Romanick wrote: > From: Ian Romanick > > --- > src/mesa/drivers/dri/i965/brw_blorp.c | 2 ++ > src/mesa/drivers/dri/i965/intel_fbo.c | 3 +++ > 2 files changed, 5 insertions(+) > > diff --git

Re: [Mesa-dev] [PATCH] i965: Fix anisotropic filtering for mag filter

2017-06-27 Thread Ian Romanick
Ouch. The frustrating thing is that anisotropic filtering is so underspecified (intentionally) that it's hard to write tests that will detect these kinds of problems and also work across multiple vendors. :( Reviewed-by: Ian Romanick On 06/27/2017 10:37 AM, Rafael

Re: [Mesa-dev] [PATCH mesa] build systems: uniformize git_sha1.h generation

2017-06-27 Thread Matt Turner
Right you are. Thanks. Reviewed-by: Matt Turner ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH] i965: Fix anisotropic filtering for mag filter

2017-06-27 Thread Rafael Antognolli
From: Eero Tamminen Commit f8d69beed49c64f883bb8ffb28d4960306baf575 moving sampler handling to genxml messed up change done by commit 6a7c5257cac23cd9767aa4bc8fdab68925b11157. This broke rendering in SynMark CSDof and TexFilterAniso tests. Bugzilla:

Re: [Mesa-dev] [PATCH mesa] build systems: uniformize git_sha1.h generation

2017-06-27 Thread Eric Engestrom
On 27 June 2017 18:11:14 BST, Matt Turner wrote: > On Tue, Jun 27, 2017 at 5:47 AM, Eric Engestrom > wrote: > > Signed-off-by: Eric Engestrom > > --- > > Note: Autotools and SCons are tested, but Android isn't. > > --- >

Re: [Mesa-dev] [PATCH 2/2] radeonsi: move instance divisors into a constant buffer

2017-06-27 Thread Nicolai Hähnle
On 27.06.2017 18:59, Marek Olšák wrote: On Tue, Jun 27, 2017 at 6:50 PM, Nicolai Hähnle wrote: On 27.06.2017 17:07, Marek Olšák wrote: On Tue, Jun 27, 2017 at 9:22 AM, Nicolai Hähnle wrote: On 27.06.2017 02:14, Marek Olšák wrote: From: Marek

Re: [Mesa-dev] [PATCH v2 01/13] intel/blorp: Assert levels and layers are in range

2017-06-27 Thread Nanley Chery
On Thu, Jun 22, 2017 at 10:32:42AM -0700, Jason Ekstrand wrote: > On Thu, Jun 22, 2017 at 10:02 AM, Nanley Chery > wrote: > > > On Thu, Jun 22, 2017 at 09:59:44AM -0700, Nanley Chery wrote: > > > On Thu, Jun 22, 2017 at 09:55:50AM -0700, Nanley Chery wrote: > > > > On Wed,

Re: [Mesa-dev] [PATCH 01/12] genxml: Silence about a billion unused parameter warnings

2017-06-27 Thread Ian Romanick
On 06/27/2017 10:04 AM, Dylan Baker wrote: > Quoting Ian Romanick (2017-06-26 16:22:34) >> From: Ian Romanick >> >> v2: Use textwrap.dedent to make the source line a lot shorter. >> Shortening (?) the line was requested by Jason. >> >> Signed-off-by: Ian Romanick

Re: [Mesa-dev] [PATCH shader-db] Drop Orbital Explorer shader.

2017-06-27 Thread Chad Versace
On Mon 26 Jun 2017, Eero Tamminen wrote: > Hi, > > On 22.06.2017 23:14, Chad Versace wrote: > > On Thu 22 Jun 2017, Chad Versace wrote: > > > On Thu 22 Jun 2017, Kenneth Graunke wrote: > > > > The author eventually emailed me and said that he considers it a > > > > "finished experiment" and said

Re: [Mesa-dev] [RFT PATCH 2/2] nv20: enable ARB_texture_border_clamp support

2017-06-27 Thread Ian Romanick
On 06/27/2017 02:59 AM, Timothy Arceri wrote: > Just curious. Can this extension be added to NV04 and NV10? As those are > the only drivers that don't currently support it. > > I have cards I could test those with, but don't have an NV20. I just sent out an updated series that I tested on NV20.

Re: [Mesa-dev] [PATCH mesa] build systems: uniformize git_sha1.h generation

2017-06-27 Thread Matt Turner
On Tue, Jun 27, 2017 at 5:47 AM, Eric Engestrom wrote: > Signed-off-by: Eric Engestrom > --- > Note: Autotools and SCons are tested, but Android isn't. > --- > git_sha1_gen.sh | 13 + > src/Makefile.am

Re: [Mesa-dev] [PATCH mesa] Fix khrplatform.h not installed if EGL is disabled.

2017-06-27 Thread Eric Engestrom
On Tuesday, 2017-06-27 19:02:22 +0300, Andres Gomez wrote: > Sound like a good inclusion for -stable (?) It's extremely unlikely to break anything, so sure, go ahead :) > > On Mon, 2017-06-12 at 12:00 +0100, Eric Engestrom wrote: > > From: Eric Le Bihan > > > >

[Mesa-dev] [PATCH 2/3] nv20: Fix GL_CLAMP

2017-06-27 Thread Ian Romanick
From: Ian Romanick v2: Force T and R wrap modes to GL_CLAMP_TO_EDGE for 1D textures. This fixes a regression in tex1d-2dborder. The test uses a 1D texture but it provides S and T texture coordinates. Since the T wrap mode would (correctly) be set to GL_CLAMP, the

[Mesa-dev] [PATCH 3/3] nv20: Enable ARB_texture_border_clamp

2017-06-27 Thread Ian Romanick
From: Ilia Mirkin Fixes quite a few 'texwrap [12]d border color only' tests on NV20 (10de:0201). All told, 40 more tests pass. Signed-off-by: Ilia Mirkin --- src/mesa/drivers/dri/nouveau/nv20_state_tex.c | 29 ++- 1 file

[Mesa-dev] [PATCH 1/3] mesa: GL_TEXTURE_BORDER_COLOR exists in OpenGL 1.0, so don't depend on GL_ARB_texture_border_clamp

2017-06-27 Thread Ian Romanick
From: Ian Romanick On NV20 (and probably also on earlier NV GPUs that lack GL_ARB_texture_border_clamp) fixes the following piglit tests: gl-1.0-beginend-coverage gltexparameter[if]{v,} push-pop-texture-state texwrap 1d texwrap 1d proj texwrap 2d

Re: [Mesa-dev] [PATCH] winsys/radeon: only call pb_slabs_reclaim when slabs are actually used

2017-06-27 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Tue, Jun 27, 2017 at 6:19 PM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=100242 > Fixes: fb827c055cb1 ("winsys/radeon: enable buffer

Re: [Mesa-dev] [PATCH 01/12] genxml: Silence about a billion unused parameter warnings

2017-06-27 Thread Dylan Baker
Quoting Ian Romanick (2017-06-26 16:22:34) > From: Ian Romanick > > v2: Use textwrap.dedent to make the source line a lot shorter. > Shortening (?) the line was requested by Jason. > > Signed-off-by: Ian Romanick > --- >

Re: [Mesa-dev] [PATCH 2/2] radeonsi: move instance divisors into a constant buffer

2017-06-27 Thread Marek Olšák
On Tue, Jun 27, 2017 at 6:50 PM, Nicolai Hähnle wrote: > On 27.06.2017 17:07, Marek Olšák wrote: >> >> On Tue, Jun 27, 2017 at 9:22 AM, Nicolai Hähnle >> wrote: >>> >>> On 27.06.2017 02:14, Marek Olšák wrote: From: Marek Olšák

[Mesa-dev] [PATCH 2/2] radeonsi: set COMPUTE_DISPATCH_INITIATOR.ORDER_MODE = 1

2017-06-27 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/radeonsi/si_compute.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeonsi/si_compute.c b/src/gallium/drivers/radeonsi/si_compute.c index 91a6a40..fba02fa 100644 ---

[Mesa-dev] [PATCH 1/2] radeonsi: use the DISPATCH packets to force COMPUTE_START_X/Y/Z = 0

2017-06-27 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/radeonsi/si_compute.c | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_compute.c b/src/gallium/drivers/radeonsi/si_compute.c index 65f3261..91a6a40 100644 ---

Re: [Mesa-dev] [PATCH 3/3] radeonsi: use #pragma pack to pack si_shader_key

2017-06-27 Thread Nicolai Hähnle
On 27.06.2017 17:02, Marek Olšák wrote: On Tue, Jun 27, 2017 at 10:02 AM, Nicolai Hähnle wrote: On 27.06.2017 00:15, Marek Olšák wrote: On Thu, Jun 22, 2017 at 9:19 AM, Nicolai Hähnle wrote: On 20.06.2017 20:00, Marek Olšák wrote: From: Marek

Re: [Mesa-dev] [PATCH 2/2] radeonsi: move instance divisors into a constant buffer

2017-06-27 Thread Nicolai Hähnle
On 27.06.2017 17:07, Marek Olšák wrote: On Tue, Jun 27, 2017 at 9:22 AM, Nicolai Hähnle wrote: On 27.06.2017 02:14, Marek Olšák wrote: From: Marek Olšák Shader key size: 107 -> 47 Nice improvement. Divisors of 0 and 1 are encoded in the shader

Re: [Mesa-dev] [PATCH] winsys/radeon: only call pb_slabs_reclaim when slabs are actually used

2017-06-27 Thread Samuel Pitoiset
Good catch! Reviewed-by: Samuel Pitoiset On 06/27/2017 06:19 PM, Nicolai Hähnle wrote: From: Nicolai Hähnle Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=100242 Fixes: fb827c055cb1 ("winsys/radeon: enable buffer allocation from

Re: [Mesa-dev] [PATCH 1/2] svga: clamp device line width to at least 1 to fix HWv8 line stippling

2017-06-27 Thread Andres Gomez
It looks like we could want these 2 into -stable (?) On Thu, 2017-06-15 at 11:41 -0600, Brian Paul wrote: > The line stipple fallback code for virtual HW version 8 didn't work. > > With HW version 8, we were getting zero when querying the max line > widths (AA and non-AA). This means we were

[Mesa-dev] [PATCH] winsys/radeon: only call pb_slabs_reclaim when slabs are actually used

2017-06-27 Thread Nicolai Hähnle
From: Nicolai Hähnle Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=100242 Fixes: fb827c055cb1 ("winsys/radeon: enable buffer allocation from slabs") Cc: mesa-sta...@lists.freedesktop.org --- src/gallium/winsys/radeon/drm/radeon_drm_bo.c | 3 ++- 1 file changed,

Re: [Mesa-dev] [PATCH mesa] Fix khrplatform.h not installed if EGL is disabled.

2017-06-27 Thread Andres Gomez
Sound like a good inclusion for -stable (?) On Mon, 2017-06-12 at 12:00 +0100, Eric Engestrom wrote: > From: Eric Le Bihan > > KHR/khrplatform.h is required by the EGL, GLES and VG headers, but is > only installed if Mesa3d is compiled with EGL support. > > This

[Mesa-dev] [RFC PATCH 2/2] ac/nir: Don't treat each element as a vec4 in compute shared memory

2017-06-27 Thread Alex Smith
Currently every element in shared memory (including individual elements of an array) are treated as a vec4. For example, the following: shared uint array[1024]; gets treated as an array of 1024 vec4s with only the first component ever used. This can be highly wasteful of LDS space. We have

[Mesa-dev] [RFC PATCH 1/2] nir: Add a C wrapper for glsl_type::std430_array_stride

2017-06-27 Thread Alex Smith
Signed-off-by: Alex Smith --- src/compiler/nir_types.cpp | 7 +++ src/compiler/nir_types.h | 3 +++ 2 files changed, 10 insertions(+) diff --git a/src/compiler/nir_types.cpp b/src/compiler/nir_types.cpp index 25980b9..554130c 100644 ---

Re: [Mesa-dev] [PATCHv2] etnaviv: Add support for ETC2 texture compression

2017-06-27 Thread Christian Gmeiner
2017-06-27 17:39 GMT+02:00 Wladimir J. van der Laan : > On Tue, Jun 27, 2017 at 05:31:52PM +0200, Wladimir J. van der Laan wrote: > >> > sure if we should advertise the broken formats (on gpus with HALTI0). > > FWIW, I did check on both GC2000 and GC3000, so HALTI0 should be ok.

Re: [Mesa-dev] [Mesa-stable] [PATCH] nv50, nvc0: remove IDX from bufctx immediately, to avoid conflicts with clear

2017-06-27 Thread Ilia Mirkin
Indeed you are quite right. My apologies for the incorrect tag. My internal timer said "it's been a while", but I didn't check if it was in the last release. On Tue, Jun 27, 2017 at 11:34 AM, Andres Gomez wrote: > Ilia, this patch tries to fix 61d8f3387d which, in turn, tried

Re: [Mesa-dev] [PATCHv2] etnaviv: Add support for ETC2 texture compression

2017-06-27 Thread Wladimir J. van der Laan
On Tue, Jun 27, 2017 at 05:31:52PM +0200, Wladimir J. van der Laan wrote: > > sure if we should advertise the broken formats (on gpus with HALTI0). FWIW, I did check on both GC2000 and GC3000, so HALTI0 should be ok. Wladimir ___ mesa-dev mailing list

Re: [Mesa-dev] [Mesa-stable] [PATCH] nv50, nvc0: remove IDX from bufctx immediately, to avoid conflicts with clear

2017-06-27 Thread Andres Gomez
Ilia, this patch tries to fix 61d8f3387d which, in turn, tried to fix 330d0607e. None of them did it for 17.1 so I suppose we should leave this out, then. Let me know if you think otherwise. On Sat, 2017-06-24 at 13:24 -0400, Ilia Mirkin wrote: > The idxbuf could linger, and when a clear

Re: [Mesa-dev] [PATCHv2] etnaviv: Add support for ETC2 texture compression

2017-06-27 Thread Wladimir J. van der Laan
> I can confirm that 11 bit stuff works on the GC2000 . I used piglit's > oes_compressed_etc2_texture-miptree_gles3 for verification. > How have you tested these formats? I rendered the example images from https://github.com/Ericsson/ETCPACK/tree/master/testing/testvectors_correct/pkm, which

Re: [Mesa-dev] [PATCHv2] etnaviv: Add support for ETC2 texture compression

2017-06-27 Thread Christian Gmeiner
2017-06-27 14:54 GMT+02:00 Wladimir J. van der Laan : > Add support for ETC2 compressed textures in the etnaviv driver. > > One step closer towards GL ES 3 support. > > For now, treat SRGB and RGB formats the same. It looks like these are > distinguished using a different bit in

Re: [Mesa-dev] [PATCH 11/11] etnaviv: advertise supported dmabuf modifiers

2017-06-27 Thread Lucas Stach
Am Dienstag, den 27.06.2017, 17:10 +0200 schrieb Wladimir J. van der Laan: > On Fri, Jun 23, 2017 at 05:50:28PM +0200, Lucas Stach wrote: > > Simply advertise all supported modifiers, independent of the format. > > Special formats, like compressed, which don't support all those modifiers > > are

Re: [Mesa-dev] [PATCH 07/11] etnaviv: implement resource import with modifier

2017-06-27 Thread Philipp Zabel
On Fri, 2017-06-23 at 17:50 +0200, Lucas Stach wrote: > This implements resource import with modifier, deriving the correct > internal layout from the modifier and constructing a render compatible > base resource if needed. > > This removes the special cases for DDX and renderonly scanout

Re: [Mesa-dev] [PATCH 11/11] etnaviv: advertise supported dmabuf modifiers

2017-06-27 Thread Wladimir J. van der Laan
On Fri, Jun 23, 2017 at 05:50:28PM +0200, Lucas Stach wrote: > Simply advertise all supported modifiers, independent of the format. > Special formats, like compressed, which don't support all those modifiers > are already culled from the dmabuf format list, as we don't support > the render target

Re: [Mesa-dev] gallium: Reduce trace_dump_box_bytes size by box->x.

2017-06-27 Thread Marek Olšák
On Tue, Jun 27, 2017 at 8:57 AM, Michel Dänzer wrote: > On 27/06/17 04:10 AM, Marek Olšák wrote: >> In my opinion, dumping resources isn't very useful. I think it would >> be better to remove that completely. > > You'd have to remove the whole trace driver along with it, since

Re: [Mesa-dev] [PATCH 2/2] radeonsi: move instance divisors into a constant buffer

2017-06-27 Thread Marek Olšák
On Tue, Jun 27, 2017 at 9:22 AM, Nicolai Hähnle wrote: > On 27.06.2017 02:14, Marek Olšák wrote: >> >> From: Marek Olšák >> >> Shader key size: 107 -> 47 > > > Nice improvement. > > >> Divisors of 0 and 1 are encoded in the shader key. Greater instance >>

Re: [Mesa-dev] [PATCH 3/3] radeonsi: use #pragma pack to pack si_shader_key

2017-06-27 Thread Marek Olšák
On Tue, Jun 27, 2017 at 10:02 AM, Nicolai Hähnle wrote: > On 27.06.2017 00:15, Marek Olšák wrote: >> >> On Thu, Jun 22, 2017 at 9:19 AM, Nicolai Hähnle >> wrote: >>> >>> On 20.06.2017 20:00, Marek Olšák wrote: From: Marek Olšák

Re: [Mesa-dev] [PATCH 04/11] etnaviv: pad scanout buffer size to RS alignment

2017-06-27 Thread Wladimir J. van der Laan
On Fri, Jun 23, 2017 at 05:50:21PM +0200, Lucas Stach wrote: > This fixes failures to import the scanout buffer with screen resolutions > that don't satisfy teh RS alignment restrictions, like 1680x1050. Thanks. I remember having this issue on OLPC, but never came up with a good solution.

  1   2   >