[Mesa-dev] [PATCH] radv/gfx9: add 3d sampler image->buffer copy shader. (v2)

2017-12-18 Thread Dave Airlie
From: Dave Airlie On GFX9 we must access 3D textures with 3D samplers AFAICS. This fixes: dEQP-VK.api.image_clearing.core.clear_color_image.3d.single_layer on GFX9 for me. v2: fixes a bunch of other tests as well. v1.1: fix tex->sampler_dim to dim v2: send layer in from

[Mesa-dev] [PATCH] glsl: minor simplification in assign_varying_locations()

2017-12-18 Thread Brian Paul
--- src/compiler/glsl/link_varyings.cpp | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/src/compiler/glsl/link_varyings.cpp b/src/compiler/glsl/link_varyings.cpp index 9039c3b..6d74f9a 100644 --- a/src/compiler/glsl/link_varyings.cpp +++

[Mesa-dev] [PATCH] glsl: use bitwise operators in varying_matches::compute_packing_class()

2017-12-18 Thread Brian Paul
The mix of bitwise operators with * and + to compute the packing_class values was a little weird. Just use bitwise ops instead. v2: add assertion to make sure interpolation bits fit without collision, per Timothy. Basically, rewrite function to be simpler. ---

[Mesa-dev] [PATCH] radv/gfx9: add 3d sampler image->buffer copy shader.

2017-12-18 Thread Dave Airlie
From: Dave Airlie On GFX9 we must access 3D textures with 3D samplers AFAICS. This fixes: dEQP-VK.api.image_clearing.core.clear_color_image.3d.single_layer on GFX9 for me. Fixes: e38685cc62e 'Revert "radv: disable support for VEGA for now."' Signed-off-by: Dave Airlie

Re: [Mesa-dev] [PATCH 5/9] glsl: use bitwise operators in varying_matches::compute_packing_class()

2017-12-18 Thread Brian Paul
On 12/18/2017 06:49 PM, Timothy Arceri wrote: On 19/12/17 07:47, Brian Paul wrote: The mix of bitwise operators with * and + to compute the packing_class values was a little weird. Just use bitwise ops instead. --- src/compiler/glsl/link_varyings.cpp | 7 --- 1 file changed, 4

Re: [Mesa-dev] [PATCH] Android: gallium_dri: add include to get "xmlpool/options.h"

2017-12-18 Thread Yu, Qiang
I met this problem when upgrade mesa 17.2 to 17.3, and build without a make clean. A clean build won't have this problem. Regards, Qiang From: Mauro Rossi Sent: Tuesday, December 19, 2017 6:19:44 AM To: Emil Velikov Cc: ML

Re: [Mesa-dev] [PATCH 5/9] glsl: use bitwise operators in varying_matches::compute_packing_class()

2017-12-18 Thread Timothy Arceri
On 19/12/17 07:47, Brian Paul wrote: The mix of bitwise operators with * and + to compute the packing_class values was a little weird. Just use bitwise ops instead. --- src/compiler/glsl/link_varyings.cpp | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git

[Mesa-dev] [PATCH 11/16] meta/blit: Use _mesa_bind_texture instead of _mesa_BindTexture

2017-12-18 Thread Ian Romanick
From: Ian Romanick Signed-off-by: Ian Romanick --- src/mesa/drivers/common/meta_blit.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/drivers/common/meta_blit.c b/src/mesa/drivers/common/meta_blit.c index

[Mesa-dev] [PATCH 12/16] meta/blit: Track temporary texture using gl_texture_object instead of GL API object handle

2017-12-18 Thread Ian Romanick
From: Ian Romanick Signed-off-by: Ian Romanick --- src/mesa/drivers/common/meta.h | 2 +- src/mesa/drivers/common/meta_blit.c | 12 ++-- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git

[Mesa-dev] [PATCH 05/16] meta/blit: Don't restore state of the temporary texture

2017-12-18 Thread Ian Romanick
From: Ian Romanick It's about to be destroyed, so there's no point. Signed-off-by: Ian Romanick --- src/mesa/drivers/common/meta_blit.c | 48 + 1 file changed, 27 insertions(+), 21 deletions(-) diff --git

[Mesa-dev] [PATCH 16/16] meta: Don't pollute the texture namespace

2017-12-18 Thread Ian Romanick
From: Ian Romanick tl;dr: For many types of GL object, we can *NEVER* use the Gen function. In OpenGL ES (all versions!) and OpenGL compatibility profile, applications don't have to call Gen functions. The GL spec is very clear about how you can mix-and-match

[Mesa-dev] [PATCH 10/16] meta/blit: Don't bind texture in _mesa_meta_bind_rb_as_tex_image

2017-12-18 Thread Ian Romanick
From: Ian Romanick All of the callers of _mesa_meta_bind_rb_as_tex_image call _mesa_meta_setup_sampler shortly after. _mesa_meta_setup_sampler also binds the texture. This is necessary because not all paths that lead to _mesa_meta_setup_sampler some through

[Mesa-dev] [PATCH 06/16] meta/blit: Don't return the target from _mesa_meta_bind_rb_as_tex_image

2017-12-18 Thread Ian Romanick
From: Ian Romanick It's always the same as *texObj->Target. Signed-off-by: Ian Romanick --- src/mesa/drivers/common/meta.h | 3 +-- src/mesa/drivers/common/meta_blit.c | 21 + 2 files changed, 10 insertions(+), 14

[Mesa-dev] [PATCH 02/16] Revert "mesa: remove unused _mesa_delete_nameless_texture()"

2017-12-18 Thread Ian Romanick
From: Ian Romanick Changes in this series use this function. This reverts commit 048de9e34a2214371481143cddcaa53f52468c6b. Signed-off-by: Ian Romanick Cc: Samuel Pitoiset Cc: Timothy Arceri

[Mesa-dev] [PATCH 03/16] mesa: Add _mesa_bind_texture method

2017-12-18 Thread Ian Romanick
From: Ian Romanick Light-weight glBindTexture for internal use. Signed-off-by: Ian Romanick --- src/mesa/main/texobj.c | 17 - src/mesa/main/texobj.h | 4 +++- 2 files changed, 19 insertions(+), 2 deletions(-) diff --git

[Mesa-dev] [PATCH 15/16] meta: Use _mesa_bind_texture instead of _mesa_BindTexture

2017-12-18 Thread Ian Romanick
From: Ian Romanick Signed-off-by: Ian Romanick --- src/mesa/drivers/common/meta.c | 6 +++--- src/mesa/drivers/common/meta_generate_mipmap.c | 4 ++-- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git

[Mesa-dev] [PATCH 13/16] meta: Track temporary textures using gl_texture_object instead of GL API object handle

2017-12-18 Thread Ian Romanick
From: Ian Romanick Signed-off-by: Ian Romanick --- src/mesa/drivers/common/meta.c | 43 ++--- src/mesa/drivers/common/meta.h | 2 +- src/mesa/drivers/common/meta_blit.c | 8 --- 3 files changed,

[Mesa-dev] [PATCH 00/16] Texutre object namespace pollution and misc

2017-12-18 Thread Ian Romanick
This series is mostly from almost two years ago when I was working on GL object namespace pollution in meta. At the time, I abandonded it because we were going to replace all of meta with blorp. That work too stalled. I picked this up again when I was working on

[Mesa-dev] [PATCH 01/16] mesa: Fold _mesa_record_error into its only caller

2017-12-18 Thread Ian Romanick
From: Ian Romanick Also, the comment on _mesa_record_error was wrong. dd_function_table::Error was not called because that function does not exist. Signed-off-by: Ian Romanick --- src/mesa/main/context.c | 25 -

[Mesa-dev] [PATCH 09/16] meta/blit: Track source texture using gl_texture_object instead of GL API object handle

2017-12-18 Thread Ian Romanick
From: Ian Romanick Signed-off-by: Ian Romanick --- src/mesa/drivers/common/meta.h | 1 + src/mesa/drivers/common/meta_blit.c | 1 + 2 files changed, 2 insertions(+) diff --git a/src/mesa/drivers/common/meta.h

[Mesa-dev] [PATCH 04/16] meta/blit: Check the values instead of the target before restoring

2017-12-18 Thread Ian Romanick
From: Ian Romanick Signed-off-by: Ian Romanick --- src/mesa/drivers/common/meta_blit.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/mesa/drivers/common/meta_blit.c b/src/mesa/drivers/common/meta_blit.c

[Mesa-dev] [PATCH 14/16] meta: Use _mesa_CreateTextures instead of _mesa_GenTextures

2017-12-18 Thread Ian Romanick
From: Ian Romanick Signed-off-by: Ian Romanick --- src/mesa/drivers/common/meta.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/drivers/common/meta.c b/src/mesa/drivers/common/meta.c index be490d5..5bad17d

[Mesa-dev] [PATCH 07/16] meta/blit: Don't return the texture handle from _mesa_meta_bind_rb_as_tex_image

2017-12-18 Thread Ian Romanick
From: Ian Romanick It's always the same as *texObj->Name. Signed-off-by: Ian Romanick --- src/mesa/drivers/common/meta.h | 1 - src/mesa/drivers/common/meta_blit.c | 15 +++ 2 files changed, 7 insertions(+), 9 deletions(-)

[Mesa-dev] [PATCH 08/16] meta/blit: Since _mesa_meta_bind_rb_as_tex_image has only one output, return it

2017-12-18 Thread Ian Romanick
From: Ian Romanick Signed-off-by: Ian Romanick --- src/mesa/drivers/common/meta.h | 5 ++--- src/mesa/drivers/common/meta_blit.c | 23 --- 2 files changed, 14 insertions(+), 14 deletions(-) diff --git

[Mesa-dev] [Bug 103955] Using array in structure results in wrong GLSL compilation output

2017-12-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103955 Ilia Mirkin changed: What|Removed |Added Resolution|--- |FIXED

[Mesa-dev] [Bug 103955] Using array in structure results in wrong GLSL compilation output

2017-12-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103955 --- Comment #10 from Younghun Jang --- No one seems to care about this easily avoidable bug. Alright. Just waiting for someone to rediscover this and make a duplicate. -- You are receiving this mail because: You are the

[Mesa-dev] [PATCH 1/2] intel/fs/bank_conflicts: Use posix_memalign() instead of overaligned new to obtain vector storage.

2017-12-18 Thread Francisco Jerez
The weight_vector_type constructor was inadvertently assuming C++17 semantics of the new operator applied on a type with alignment requirement greater than the largest fundamental alignment. Unfortunately on earlier C++ dialects the implementation was allowed to raise an allocation failure when

[Mesa-dev] [PATCH 2/2] intel/fs: Initialize fs_visitor::grf_used on construction.

2017-12-18 Thread Francisco Jerez
This should shut up some Valgrind errors during pre-regalloc scheduling. The errors were harmless since they could only have led to the estimation of the bank conflict penalty of an instruction pre-regalloc, which is inaccurate at that point of the program compilation, but no less accurate than

Re: [Mesa-dev] [PATCH] intel/compiler/gen10: Disable push constants.

2017-12-18 Thread Ben Widawsky
On 17-12-18 15:23:11, Antognolli, Rafael wrote: We still have gpu hangs on Cannonlake when using push constants, so disable them for now until we have a proper fix for these hangs. v2: Add warning message when creating context too. Signed-off-by: Rafael Antognolli

[Mesa-dev] [PATCH] intel/compiler/gen10: Disable push constants.

2017-12-18 Thread Rafael Antognolli
We still have gpu hangs on Cannonlake when using push constants, so disable them for now until we have a proper fix for these hangs. v2: Add warning message when creating context too. Signed-off-by: Rafael Antognolli Cc: Ben Widawsky Cc: Kenneth

[Mesa-dev] [Bug 104329] Vulkan app crashes GPU

2017-12-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=104329 --- Comment #1 from Samuel Pitoiset --- Hi, Can you reproduce the VM faults after reverting ff0f17da1446e7aa965e06c04a6ad5a55d95463d ? -- You are receiving this mail because: You are the assignee for the bug. You

Re: [Mesa-dev] [PATCH] Android: gallium_dri: add include to get "xmlpool/options.h"

2017-12-18 Thread Mauro Rossi
Il 18/dic/2017 17:27, "Emil Velikov" ha scritto: On 17 December 2017 at 23:34, Mauro Rossi wrote: > target.c requires "xmlpool/options.h" generated header > or the following tricky Android building error may appear: > > In file included from

[Mesa-dev] [Bug 104329] Vulkan app crashes GPU

2017-12-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=104329 Bug ID: 104329 Summary: Vulkan app crashes GPU Product: Mesa Version: git Hardware: Other OS: All Status: NEW Severity: normal Priority:

[Mesa-dev] [PATCH] radv: properly load unused gl_LocalInvocationID/gl_WorkGroupID components

2017-12-18 Thread Samuel Pitoiset
F1 2017 looks good now. Signed-off-by: Samuel Pitoiset --- src/amd/common/ac_nir_to_llvm.c | 21 ++--- src/amd/vulkan/radv_shader.c| 7 +-- 2 files changed, 23 insertions(+), 5 deletions(-) diff --git a/src/amd/common/ac_nir_to_llvm.c

[Mesa-dev] [PATCH 9/9] glsl: disable vec3 packing/splitting in tfb separate mode

2017-12-18 Thread Brian Paul
This fixes a varying packing issue when using transform feedback in GL_SEPARATE_ATTRIBS mode. By time we get to linking, we already know that the number of feedback attributes is under the GL_MAX_TRANSFORM_FEEDBACK_SEPARATE_ATTRIBS limit so packing isn't as critical. In fact, packing/splitting

Re: [Mesa-dev] [PATCH] swr: Account for VBO index_bias in offsets

2017-12-18 Thread Cherniak, Bruce
This change only affects the client buffer case (swr_user_vbuf_range), not VBOs. Reviewed with the caveat that the patch description be changed to remove "VBO" Reviewed-by: Bruce Cherniak > On Dec 15, 2017, at 10:22 AM, George Kyriazis >

[Mesa-dev] [PATCH 4/9] glsl: simplify loop in varying_matches::assign_locations()

2017-12-18 Thread Brian Paul
The use of break/continue was kind of weird/confusing. --- src/compiler/glsl/link_varyings.cpp | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/compiler/glsl/link_varyings.cpp b/src/compiler/glsl/link_varyings.cpp index 6d74f9a..7821b1e 100644 ---

[Mesa-dev] [PATCH 3/9] glsl: minor simplification in assign_varying_locations()

2017-12-18 Thread Brian Paul
--- src/compiler/glsl/link_varyings.cpp | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/src/compiler/glsl/link_varyings.cpp b/src/compiler/glsl/link_varyings.cpp index 9039c3b..6d74f9a 100644 --- a/src/compiler/glsl/link_varyings.cpp +++

[Mesa-dev] [PATCH 8/9] glsl: simply packing class comparison

2017-12-18 Thread Brian Paul
Handle comparing the packing class using the same method as we do for var->data.is_xfb_only --- src/compiler/glsl/link_varyings.cpp | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/compiler/glsl/link_varyings.cpp b/src/compiler/glsl/link_varyings.cpp index

[Mesa-dev] [PATCH 5/9] glsl: use bitwise operators in varying_matches::compute_packing_class()

2017-12-18 Thread Brian Paul
The mix of bitwise operators with * and + to compute the packing_class values was a little weird. Just use bitwise ops instead. --- src/compiler/glsl/link_varyings.cpp | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/compiler/glsl/link_varyings.cpp

Re: [Mesa-dev] [PATCH] drirc: add option to disable ARB_draw_indirect

2017-12-18 Thread Rob Clark
On Fri, Dec 15, 2017 at 1:08 PM, Nicolai Hähnle wrote: > On 15.12.2017 12:37, Rob Clark wrote: >> >> On Fri, Dec 15, 2017 at 4:41 AM, Nicolai Hähnle >> wrote: >>> >>> On 15.12.2017 00:56, Rob Clark wrote: On Wed, Dec 6, 2017 at

[Mesa-dev] [PATCH 1/9] glsl: trivial comment fix in lower_packed_varyings.cpp

2017-12-18 Thread Brian Paul
--- src/compiler/glsl/lower_packed_varyings.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/compiler/glsl/lower_packed_varyings.cpp b/src/compiler/glsl/lower_packed_varyings.cpp index 1aec7ee..b840d26 100644 --- a/src/compiler/glsl/lower_packed_varyings.cpp +++

[Mesa-dev] [PATCH 7/9] glsl: document varying_matches::assign_locations() params and return value

2017-12-18 Thread Brian Paul
And change *components to components[] as a reminder that it's an array. --- src/compiler/glsl/link_varyings.cpp | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/src/compiler/glsl/link_varyings.cpp b/src/compiler/glsl/link_varyings.cpp index 3de3f25..95306fa 100644

[Mesa-dev] [PATCH 2/9] glsl: make varying_matches::is_varying_packing_safe() const

2017-12-18 Thread Brian Paul
--- src/compiler/glsl/link_varyings.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/compiler/glsl/link_varyings.cpp b/src/compiler/glsl/link_varyings.cpp index cadffeb..9039c3b 100644 --- a/src/compiler/glsl/link_varyings.cpp +++

[Mesa-dev] [PATCH 6/9] glsl: remove some continue statements

2017-12-18 Thread Brian Paul
In some cases, I think loop code is easier to read without continue statements. --- src/compiler/glsl/link_varyings.cpp | 24 +++- 1 file changed, 11 insertions(+), 13 deletions(-) diff --git a/src/compiler/glsl/link_varyings.cpp b/src/compiler/glsl/link_varyings.cpp index

[Mesa-dev] [PATCH 1/3] radv/amdgpu: wrap sync fd import/export.

2017-12-18 Thread Bas Nieuwenhuizen
--- src/amd/vulkan/radv_radeon_winsys.h | 5 + src/amd/vulkan/winsys/amdgpu/radv_amdgpu_cs.c | 21 + 2 files changed, 26 insertions(+) diff --git a/src/amd/vulkan/radv_radeon_winsys.h b/src/amd/vulkan/radv_radeon_winsys.h index e851c3edf86..45f58f063a4 100644

[Mesa-dev] [PATCH 2/3] radv: Implement sync file import/export for fences & semaphores.

2017-12-18 Thread Bas Nieuwenhuizen
--- src/amd/vulkan/radv_device.c | 115 --- 1 file changed, 87 insertions(+), 28 deletions(-) diff --git a/src/amd/vulkan/radv_device.c b/src/amd/vulkan/radv_device.c index a4ec912ff2c..0c31bfb9b44 100644 --- a/src/amd/vulkan/radv_device.c +++

[Mesa-dev] [PATCH 3/3] radv: Advertise sync fd import and export.

2017-12-18 Thread Bas Nieuwenhuizen
Passes dEQP-VK.*.sync_fd.* --- src/amd/vulkan/radv_device.c | 19 +++ 1 file changed, 15 insertions(+), 4 deletions(-) diff --git a/src/amd/vulkan/radv_device.c b/src/amd/vulkan/radv_device.c index 0c31bfb9b44..51488285b09 100644 --- a/src/amd/vulkan/radv_device.c +++

Re: [Mesa-dev] [PATCH 20/29] anv/cmd_buffer: Decide whether or not to HiZ clear up-front

2017-12-18 Thread Pohjolainen, Topi
On Mon, Nov 27, 2017 at 07:06:10PM -0800, Jason Ekstrand wrote: > This moves the decision out of begin_subpass and into BeginRenderPass > like the decision for color clears. We use a similar name for the > function for depth/stencil as for color even though no aux usage is > really getting

[Mesa-dev] [PATCH] docs: update 17.3 and 18.0 cycles for the release calendar

2017-12-18 Thread Andres Gomez
Cc: Emil Velikov Cc: Juan A. Suarez Romero Signed-off-by: Andres Gomez --- docs/release-calendar.html | 63 +- 1 file changed, 62 insertions(+), 1 deletion(-) diff --git

Re: [Mesa-dev] [PATCH 19/29] anv/cmd_buffer: Move the rest of clear_subpass into begin_subpass

2017-12-18 Thread Pohjolainen, Topi
On Mon, Nov 27, 2017 at 07:06:09PM -0800, Jason Ekstrand wrote: > --- > src/intel/vulkan/anv_blorp.c | 243 > - > src/intel/vulkan/anv_private.h | 17 ++- > src/intel/vulkan/genX_cmd_buffer.c | 68 ++- > 3 files changed, 188 insertions(+),

Re: [Mesa-dev] [PATCH] egl: link libEGL against the dynamic version of libglapi

2017-12-18 Thread Dylan Baker
Quoting Eric Engestrom (2017-12-18 08:33:18) > From: Brendan King > > DRI modules store the address of the dispatch table in a TLS variable, > _glapi_tls_Dispatch. > > Changes to the way libEGL is built in d884d8d0077c16d459b1 resulted in > it being statically linked

[Mesa-dev] [PATCH 7/7] radv: do not add extra SGPR when push constants are not used

2017-12-18 Thread Samuel Pitoiset
This is not because the vertex stage needs some push constants that other stages need them too. This should reduce the number of loaded SGPRs in some situations. Signed-off-by: Samuel Pitoiset --- src/amd/common/ac_shader_info.c | 3 ++- 1 file changed, 2

[Mesa-dev] [PATCH 6/7] radv: change the needs_push_constants logic

2017-12-18 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/amd/common/ac_shader_info.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/amd/common/ac_shader_info.c b/src/amd/common/ac_shader_info.c index 4df428ae81..6aadb5032e 100644 ---

[Mesa-dev] [PATCH 5/7] radv: store pipeline stages that need push constants

2017-12-18 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_descriptor_set.c | 3 +++ src/amd/vulkan/radv_descriptor_set.h | 1 + 2 files changed, 4 insertions(+) diff --git a/src/amd/vulkan/radv_descriptor_set.c b/src/amd/vulkan/radv_descriptor_set.c index

[Mesa-dev] [PATCH 2/7] radv: add assertions to make sure pipeline layout objects are valid

2017-12-18 Thread Samuel Pitoiset
The spec requires it. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_pipeline.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/amd/vulkan/radv_pipeline.c b/src/amd/vulkan/radv_pipeline.c index fedabcd73f..3fc21bb501 100644 ---

[Mesa-dev] [PATCH 4/7] radv: remove one useless check in ac_nir_shader_info_pass()

2017-12-18 Thread Samuel Pitoiset
pipeline->layout can't be NULL now. Signed-off-by: Samuel Pitoiset --- src/amd/common/ac_shader_info.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/amd/common/ac_shader_info.c b/src/amd/common/ac_shader_info.c index

[Mesa-dev] [PATCH 3/7] radv: remove one useless check in radv_flush_constants()

2017-12-18 Thread Samuel Pitoiset
pipeline->layout can't be NULL now. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_cmd_buffer.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/amd/vulkan/radv_cmd_buffer.c b/src/amd/vulkan/radv_cmd_buffer.c index

[Mesa-dev] [PATCH 1/7] radv: create pipeline layout objects for all meta operations

2017-12-18 Thread Samuel Pitoiset
They are dummy objects but the spec requires layout to not be NULL, this just makes sure we are creating valid pipeline layout objects. This will allow us to remove some useless checks. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_meta_decompress.c | 28

Re: [Mesa-dev] [PATCH 18/29] intel/blorp: Add a blorp_hiz_clear_depth_stencil helper

2017-12-18 Thread Pohjolainen, Topi
On Mon, Nov 27, 2017 at 07:06:08PM -0800, Jason Ekstrand wrote: > This is similar to blorp_gen8_hiz_clear_attachments except that it takes > actual images instead of trusting in the already set depth state. > --- > src/intel/blorp/blorp.h | 11 ++ > src/intel/blorp/blorp_clear.c |

Re: [Mesa-dev] [PATCH] drirc: add option to disable ARB_draw_indirect

2017-12-18 Thread Eric Anholt
Nicolai Hähnle writes: > On 15.12.2017 12:37, Rob Clark wrote: >> On Fri, Dec 15, 2017 at 4:41 AM, Nicolai Hähnle >> wrote: >>> On 15.12.2017 00:56, Rob Clark wrote: On Wed, Dec 6, 2017 at 3:31 PM, Ian Romanick

Re: [Mesa-dev] [PATCH] spirv: Relax the validation conditions of OpSelect

2017-12-18 Thread Lionel Landwerlin
Thanks for point me to the code actually doing this (nir_build_alu). Reviewed-by: Lionel Landwerlin On 15/12/17 03:56, Jason Ekstrand wrote: The Talos Principle contains shaders with an OpSelect between two vectors where the condition is a scalar boolean. This

Re: [Mesa-dev] [PATCH 3/3] Revert "i965: Disable regular fast-clears (CCS_D) on gen9+"

2017-12-18 Thread Nanley Chery
On Sun, Dec 17, 2017 at 07:34:47PM -0800, Jason Ekstrand wrote: > On Sat, Dec 16, 2017 at 3:07 PM, Jason Ekstrand > wrote: > > > On December 16, 2017 14:35:29 Nanley Chery wrote: > > > > On Wed, Dec 13, 2017 at 05:52:03PM -0800, Jason Ekstrand wrote:

Re: [Mesa-dev] [PATCH] egl: link libEGL against the dynamic version of libglapi

2017-12-18 Thread Emil Velikov
On 18 December 2017 at 16:33, Eric Engestrom wrote: > From: Brendan King > > DRI modules store the address of the dispatch table in a TLS variable, > _glapi_tls_Dispatch. > > Changes to the way libEGL is built in d884d8d0077c16d459b1 resulted

Re: [Mesa-dev] [PATCH] i965/miptree: Refactor CCS_E and CCS_D cases in render_aux_usage

2017-12-18 Thread Nanley Chery
On Sun, Dec 17, 2017 at 08:03:45PM -0800, Jason Ekstrand wrote: > This commit unifies the CCS_E and CCS_D cases. This should fix a couple > of subtle issues. One is that when you use INTEL_DEBUG=norbc to disable > CCS_E, we don't get the sRGB blending workaround. By unifying the code, > we give

[Mesa-dev] [PATCH] egl: link libEGL against the dynamic version of libglapi

2017-12-18 Thread Eric Engestrom
From: Brendan King DRI modules store the address of the dispatch table in a TLS variable, _glapi_tls_Dispatch. Changes to the way libEGL is built in d884d8d0077c16d459b1 resulted in it being statically linked against libglapi, and thus containing its own copy of

Re: [Mesa-dev] [PATCH v2 0/5] i965: ASTC5x5 workaround

2017-12-18 Thread Nanley Chery
On Mon, Dec 18, 2017 at 08:05:38AM +, Rogovin, Kevin wrote: > Hi, > > I gave it a try by modifying isl_genX(surf_fill_state_s) in > src/intel/isl/isl_surface_state.c where I set SamplerL2BypassModeDisable > ALWAYS as true for GEN9; sadly car chase continued to hang. > > -Kevin > Hi,

Re: [Mesa-dev] [PATCH] Android: gallium_dri: add include to get "xmlpool/options.h"

2017-12-18 Thread Emil Velikov
On 17 December 2017 at 23:34, Mauro Rossi wrote: > target.c requires "xmlpool/options.h" generated header > or the following tricky Android building error may appear: > > In file included from external/mesa/src/gallium/targets/dri/target.c:1: > In file included from >

[Mesa-dev] Mesa 17.3.1 release candidate

2017-12-18 Thread Emil Velikov
Hello list, The candidate for the Mesa 17.3.1 is now available. Currently we have: - 35 queued - 1 nominated (outstanding) - and 2 rejected patches The current queue consists of: Nearly a multiple fixes, making the GLSL shader cache more robust. The RADV driver does not advertise

Re: [Mesa-dev] [PATCH] anv: fix bug when VK_REMAINING_ARRAY_LAYERS is used in vkCmdClearAttachments()

2017-12-18 Thread Jason Ekstrand
On Mon, Dec 18, 2017 at 2:55 AM, Samuel Iglesias Gonsálvez < sigles...@igalia.com> wrote: > > > On 15/12/17 16:46, Jason Ekstrand wrote: > > Ugh... The problem here is that we may not know the framebuffer in > > CmdCearAttachments if it's in a secondary command buffer. I'm not > > actually sure

Re: [Mesa-dev] [PATCH 9/9] mesa: always compare optype with symbolic name in ATI_fs

2017-12-18 Thread Miklós Máté
Thanks for the review. I'll also need somebody to commit these, because I have no access. MM On 11/12/17 19:50, Marek Olšák wrote: For the series: Reviewed-by: Marek Olšák Marek On Sat, Dec 2, 2017 at 11:35 PM, Miklós Máté wrote: Signed-off-by:

[Mesa-dev] [Bug 97250] Mesa/Clover: openCV library bugs on CL_MEM_USE_HOST_PTR

2017-12-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97250 mirh changed: What|Removed |Added CC||m...@protonmail.ch -- You

Re: [Mesa-dev] [PATCH] travis: use LLVM 5.0 for Meson Vulkan

2017-12-18 Thread Juan A. Suarez Romero
On Fri, 2017-12-15 at 18:49 +0100, Gert Wollny wrote: > Am Freitag, den 15.12.2017, 17:17 +0100 schrieb Juan A. Suarez Romero: > > Travis CI has moved to LLVM 5.0, and meson is detecting automatically > > the available version. > > Considering that LLVM 5.0 is obviously not properly made

[Mesa-dev] [Bug 97250] Mesa/Clover: openCV library bugs on CL_MEM_USE_HOST_PTR

2017-12-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97250 adnan changed: What|Removed |Added CC||cheema6...@gmail.com --

Re: [Mesa-dev] [PATCH] anv: fix bug when VK_REMAINING_ARRAY_LAYERS is used in vkCmdClearAttachments()

2017-12-18 Thread Samuel Iglesias Gonsálvez
On 15/12/17 16:46, Jason Ekstrand wrote: > Ugh... The problem here is that we may not know the framebuffer in > CmdCearAttachments if it's in a secondary command buffer.  I'm not > actually sure what to do in that case.  I guess we could store the > number of later somewhere and teach blorp how

Re: [Mesa-dev] [PATCH 2/2] ac/nir: fix lds store for patch outputs.

2017-12-18 Thread Bas Nieuwenhuizen
Reviewed-by: Bas Nieuwenhuizen for the series. On Mon, Dec 18, 2017 at 7:55 AM, Dave Airlie wrote: > From: Dave Airlie > > This wasn't calculating the correct value, this along with > a nir patch fixes a regression in: >

[Mesa-dev] [PATCH 1/1] Use getprogname from stdlib.h on all BSDs and APPLE

2017-12-18 Thread Maya Rashish
Remove EOL NetBSD < 1.x (this didn't work, since we don't include sys/param.h). Remove EOL FreeBSD < 4.4 Functionally changes OpenBSD which now uses getprogname instead of fallback. --- src/util/xmlconfig.c | 17 +++-- 1 file changed, 3 insertions(+), 14 deletions(-) diff --git

Re: [Mesa-dev] [PATCH v2 0/5] i965: ASTC5x5 workaround

2017-12-18 Thread Rogovin, Kevin
Hi, I gave it a try by modifying isl_genX(surf_fill_state_s) in src/intel/isl/isl_surface_state.c where I set SamplerL2BypassModeDisable ALWAYS as true for GEN9; sadly car chase continued to hang. -Kevin -Original Message- From: Nanley Chery [mailto:nanleych...@gmail.com] Sent:

Re: [Mesa-dev] [PATCH 22/22] mesa: Add GL_UNSIGNED_INT_2_10_10_10_REV OES read type for BGRX1010102.

2017-12-18 Thread Tapani Pälli
Reviewed-by: Tapani Pälli On 12/16/2017 12:05 AM, Mario Kleiner wrote: As Marek noted, the GL_RGBA + GL_UNSIGNED_INT_2_10_10_10_REV type combo is also good for readback of BGRX1010102 framebuffers, not only for BGRA1010102 framebuffers for use with glReadPixels() under

Re: [Mesa-dev] [Mesa-stable] [PATCH] swr: Fix KNOB_MAX_WORKER_THREADS thread creation override.

2017-12-18 Thread Andres Gomez
On Mon, 2017-12-18 at 00:28 +, Cherniak, Bruce wrote: > > On Dec 17, 2017, at 10:23 AM, Andres Gomez > > wrote: > > > > Bruce, this depends on ead0dfe31ec7 which didn't make it for the > > 17.2 > > queue so I will be leaving out from there. > > Hi Andres, it is fine to

Re: [Mesa-dev] [PATCH] radv: port merge tess info from anv

2017-12-18 Thread Bas Nieuwenhuizen
Reviewed-by: Bas Nieuwenhuizen On Mon, Dec 18, 2017 at 6:08 AM, Dave Airlie wrote: > From: Dave Airlie > > anv merges the tess info correctly, but radv wasn't doing this. > > This fixes hangs in >