[Mesa-dev] [PATCH v1] egl/android: Implement the eglSwapinterval for Android.

Implement the eglSwapinterval for Android platform to enable the async mode for some GFX benchmarks. Signed-off-by: Zhongmin Wu --- src/egl/drivers/dri2/platform_android.c | 16 1 file changed, 16 insertions(+) diff --git

Re: [Mesa-dev] [egl/android: Implement the eglSwapinterval for Android] egl/android: Implement the eglSwapinterval for Android.

Hi Tomasz: Thanks very much for your reply, I will re-submit the patch. And I did not do the deqp testing yet, I am going to have a try. -Original Message- From: mesa-dev [mailto:mesa-dev-boun...@lists.freedesktop.org] On Behalf Of Tomasz Figa Sent: Tuesday, January 16, 2018 15:17 To:

Re: [Mesa-dev] [PATCH v4 03/10] nir/spirv: add gl_spirv_validation method

On 15/01/18 17:28, Jason Ekstrand wrote: > On January 15, 2018 06:46:13 Alejandro Piñeiro > wrote: > >> ARB_gl_spirv adds the ability to use SPIR-V binaries, and a new >> method, glSpecializeShader. From OpenGL 4.6 spec, section 7.2.1 >> "Shader Specialization", error table:

Re: [Mesa-dev] DRI Configurator replacement announcement

Hello Jean, Am Montag, den 15.01.2018, 20:15 + schrieb Jean Hertel: > I have written a simply application like DRI Conf tool. > It is written using GTKmm and C++. Great! Unfortunately, it didn't link properly, so I send you a pull request to correct the Boost_LOCALE dependency.   

Re: [Mesa-dev] [egl/android: Implement the eglSwapinterval for Android] egl/android: Implement the eglSwapinterval for Android.

Hi Zhongmin, On Tue, Jan 16, 2018 at 4:07 PM, Wu, Zhongmin wrote: > Sorry, is there any comment about the below patch, Thanks very much! Or did I > miss something ? I assumed this was sent by mistake. The subject doesn't look like a patch for review - it should have

Re: [Mesa-dev] [egl/android: Implement the eglSwapinterval for Android] egl/android: Implement the eglSwapinterval for Android.

Sorry, is there any comment about the below patch, Thanks very much! Or did I miss something ? -Original Message- From: Wu, Zhongmin Sent: Wednesday, January 3, 2018 10:11 To: mesa-dev@lists.freedesktop.org Cc: Kondapally, Kalyan ; Palli, Tapani

[Mesa-dev] [PATCH] ac: fix nir_intrinsic_get_buffer_size for radeonsi

--- src/amd/common/ac_nir_to_llvm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c index 4a80748e4e..0940dc82d8 100644 --- a/src/amd/common/ac_nir_to_llvm.c +++ b/src/amd/common/ac_nir_to_llvm.c @@ -2401,9

[Mesa-dev] [PATCH] ac: fix buffer overflow bug in 64bit SSBO loads

Fixes: 441ee1e65b04 "radv/ac: Implement Float64 SSBO loads" --- src/amd/common/ac_nir_to_llvm.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c index 6467ed66ae..4a80748e4e 100644 ---

[Mesa-dev] [Bug 103699] Latest mesa breaks firefox on kde plasma with compositing on

https://bugs.freedesktop.org/show_bug.cgi?id=103699 Tapani Pälli changed: What|Removed |Added Resolution|--- |FIXED

Re: [Mesa-dev] [PATCH] st/dri: Default ALLOW_RGB10_CONFIGS to false on gallium as well.

Reviewed-by: Tapani Pälli On 16.01.2018 06:39, Mario Kleiner wrote: For consistency with the i965 default of "off". Signed-off-by: Mario Kleiner --- src/gallium/auxiliary/pipe-loader/driinfo_gallium.h | 2 +- 1 file changed, 1

[Mesa-dev] [PATCH] st/dri: Default ALLOW_RGB10_CONFIGS to false on gallium as well.

For consistency with the i965 default of "off". Signed-off-by: Mario Kleiner --- src/gallium/auxiliary/pipe-loader/driinfo_gallium.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/auxiliary/pipe-loader/driinfo_gallium.h

[Mesa-dev] [PATCH] draw: fix vsplit code when the (post-bias) index value is -1

From: Roland Scheidegger vsplit_add_cache uses the post-bias index for hashing, but the vsplit_add_cache_uint/ushort/ubyte ones used the pre-bias index, therefore the code for handling the special case (because -1 matches the initialization value of the cache) wasn't actually

[Mesa-dev] [PATCH 2/2] st/vdpau: release held lock in error path

Signed-off-by: Grazvydas Ignotas --- src/gallium/state_trackers/vdpau/surface.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/gallium/state_trackers/vdpau/surface.c b/src/gallium/state_trackers/vdpau/surface.c index c678eb7..012d303 100644 ---

[Mesa-dev] [PATCH 1/2] st/va: release held locks in error paths

Found with the help of following Coccinelle semantic patch: // @@ expression E; @@ \(pthread_mutex_lock\|mtx_lock\|simple_mtx_lock\)(E) ... ( \(pthread_mutex_unlock\|mtx_unlock\|simple_mtx_unlock\)(E); ... return ...; | + maybe need_unlock(E); return ...; ) // Signed-off-by:

Re: [Mesa-dev] [PATCH 1/2] meson: Fix configuring dri glx with only gallium drivers

On Mon, 2018-01-15 at 20:01 +, Jon Turney wrote: > On 12/01/2018 17:25, Dylan Baker wrote: > > meson considers classic swrast to be a dri driver, I know it's not exactly > > accurate, but, at least for me, it made the build system easier to reason > > about. > > I think maybe the point here

[Mesa-dev] DRI Configurator replacement announcement

Hello, I have written a simply application like DRI Conf tool. It is written using GTKmm and C++. Main Features (apart from what is already available in driconf): - Automatic removal of invalid options (Options that the driver doesn't support at all) - Options that have the same value as the

Re: [Mesa-dev] [PATCH 1/2] meson: Fix configuring dri glx with only gallium drivers

On 12/01/2018 17:25, Dylan Baker wrote: meson considers classic swrast to be a dri driver, I know it's not exactly accurate, but, at least for me, it made the build system easier to reason about. I think maybe the point here is that '-Ddri-drivers= -Dgallium-drivers= -Dglx=dri' (or at least,

[Mesa-dev] [Bug 104490] [radeonsi/290x] Dota2 fails to start (can't create opengl context)

https://bugs.freedesktop.org/show_bug.cgi?id=104490 --- Comment #11 from Adam Jackson --- I've reverted these for now. I'm reasonably sure that the issue is a skew between X server and Mesa, such that the app thinks it can create a no-flush context but either the server or libGL

Re: [Mesa-dev] [PATCH 1/2] meson: Fix configuring dri glx with only gallium drivers

On 12/01/2018 17:33, Dylan Baker wrote: Maybe this is correct, but it makes me nervous treating with_gallium as equivalent to with_dri, since gallium drivers can be built dri-less (gallium-xlib, and some other configurations on windows). I think something like: with_glx = get_option('glx')

Re: [Mesa-dev] [PATCH 2/4] i965/miptree: Use the tiling from the modifier instead of the BO

On Mon, Jan 15, 2018 at 5:47 AM, Pohjolainen, Topi < topi.pohjolai...@gmail.com> wrote: > On Thu, Jan 11, 2018 at 05:40:51PM -0800, Jason Ekstrand wrote: > > From: Jason Ekstrand > > > > This fixes a bug where we were taking the tiling from the BO regardless > > of what the

[Mesa-dev] [PATCH] vbo: optimize some display list drawing (v2)

The vbo_save_vertex_list structure records one or more glBegin/End primitives which all have the same vertex format. To draw these primitives, we setup the vertex array state, then issue the drawing command. Before, the 'start' vertex was typically zero and we used the vertex array pointer to

Re: [Mesa-dev] [PATCH 17/17] vbo: optimize some display list drawing

On 01/12/2018 03:52 PM, Ian Romanick wrote: On 01/12/2018 02:23 PM, Brian Paul wrote: The vbo_save_vertex_list structure records one or more glBegin/End primitives which all have the same vertex format. To draw these primitives, we setup the vertex array state, then issue the drawing command.

Re: [Mesa-dev] [PATCH 11/17] anv: Separate compute and graphics descriptor sets

On Mon, Jan 15, 2018 at 10:47:08AM -0800, Jason Ekstrand wrote: > On Mon, Jan 15, 2018 at 7:11 AM, Pohjolainen, Topi < > topi.pohjolai...@gmail.com> wrote: > > > On Fri, Dec 15, 2017 at 05:09:09PM -0800, Jason Ekstrand wrote: > > > The Vulkan spec says: > > > > > > "pipelineBindPoint is a

Re: [Mesa-dev] [PATCH 01/10] mesa: Also track a remapped version of the color logic op

On 01/12/2018 03:56 PM, Ian Romanick wrote: From: Ian Romanick With the exception of NVIDIA hardware, these are is the values that all hardware and Gallium want. The remapping is currently implemented in at least 6 places. This starts the process of consolidating to

Re: [Mesa-dev] [PATCH 11/17] anv: Separate compute and graphics descriptor sets

On Mon, Jan 15, 2018 at 7:11 AM, Pohjolainen, Topi < topi.pohjolai...@gmail.com> wrote: > On Fri, Dec 15, 2017 at 05:09:09PM -0800, Jason Ekstrand wrote: > > The Vulkan spec says: > > > > "pipelineBindPoint is a VkPipelineBindPoint indicating whether the > > descriptors will be used by

Re: [Mesa-dev] [PATCH] glx: fix non-dri build

Nicolai Hähnle, on lun. 15 janv. 2018 15:07:03 +0100, wrote: > On 13.01.2018 12:36, Samuel Thibault wrote: > > glXGetDriverConfig parameters do not provide a context to dynamically > > check for the presence of the function, so the dispatcher directly calls > > glXGetDriverConfig, but in non-dri

[Mesa-dev] [PATCHv2] glx: fix non-dri build

glXGetDriverConfig parameters do not provide a context to dynamically check for the presence of the function, so the dispatcher directly calls glXGetDriverConfig, but in non-dri builds dri_glx.c didn't provide glXGetDriverConfig. This change make it just return NULL in that case. Fixes:

Re: [Mesa-dev] [PATCHv2] glx: fix non-dri build

Hi, On 15-01-18 15:38, Samuel Thibault wrote: glXGetDriverConfig parameters do not provide a context to dynamically check for the presence of the function, so the dispatcher directly calls glXGetDriverConfig, but in non-dri builds dri_glx.c didn't provide glXGetDriverConfig. This change make

Re: [Mesa-dev] [RFC libdrm 0/5] Move alloc_handle_t from gralloc impls.

Hey Tomasz, On 01/15/2018 04:03 PM, Tomasz Figa wrote: On Tue, Jan 16, 2018 at 12:00 AM, Rob Herring wrote: On Mon, Jan 15, 2018 at 7:09 AM, Robert Foss wrote: Hey, On 01/13/2018 12:49 AM, Gurchetan Singh wrote: We can define accessor

Re: [Mesa-dev] [PATCH v4 03/10] nir/spirv: add gl_spirv_validation method

On January 15, 2018 06:46:13 Alejandro Piñeiro wrote: ARB_gl_spirv adds the ability to use SPIR-V binaries, and a new method, glSpecializeShader. From OpenGL 4.6 spec, section 7.2.1 "Shader Specialization", error table: INVALID_VALUE is generated if does not name a

[Mesa-dev] [PATCH 3/3] mesa/program/prog_optimize.c: Silence two warnings

Specifically, -Wsign-compare (explicite cast) and -Wunused-param (annotate) Signed-off-by: Gert Wollny --- src/mesa/program/prog_optimize.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/mesa/program/prog_optimize.c

[Mesa-dev] [PATCH 1/3] mesa: make Visual.samples to be of type unsigned int and propagate this

According to the ARB_multisample Visual.samples is a non-negative Integer. Consequently define it, and related functions and values as such and fail in glx/choose_visual if a negative number is given. Signed-off-by: Gert Wollny --- The patch was motivated by Emil:

[Mesa-dev] [PATCH 2/3] mesa/program/prog_execute: silence a -Wunused-param warning by annotation

Signed-off-by: Gert Wollny --- src/mesa/program/prog_execute.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/program/prog_execute.c b/src/mesa/program/prog_execute.c index 1268476279..4950420fbc 100644 --- a/src/mesa/program/prog_execute.c +++

Re: [Mesa-dev] [PATCH 1/7] gallium: Refactor out vl_put_screen and vl_get_screen

Hi lists, If there is no more questions, and no objection, I would like to commit this new OMX st. to upstream. @Gurkipal, If you can send me or lists your rebased patches set for committing, that would be appreciated. Leo On 12/04/2017 08:58 AM, Leo Liu wrote: On 12/03/2017 10:04

Re: [Mesa-dev] [PATCH 29/29] anv: Use blorp_ccs_ambiguate instead of fast-clears

On Sat, Jan 13, 2018 at 10:33:29AM +0200, Pohjolainen, Topi wrote: > On Mon, Nov 27, 2017 at 07:06:19PM -0800, Jason Ekstrand wrote: > > Even though the blorp pass looks a bit on the sketchy side, the end > > result in the Vulkan driver is very nice. Instead of having this weird > > case where

Re: [Mesa-dev] [PATCH 00/17] anv: Rework state tracking to better separate

On Fri, Dec 15, 2017 at 05:08:58PM -0800, Jason Ekstrand wrote: > This series is intended to address a bug filed in September: > > https://bugs.freedesktop.org/show_bug.cgi?id=102897 > > Unfortunately, the fix is either a lot of patches or very messy. This > series (as is common for me) takes

Re: [Mesa-dev] [PATCH 11/17] anv: Separate compute and graphics descriptor sets

On Fri, Dec 15, 2017 at 05:09:09PM -0800, Jason Ekstrand wrote: > The Vulkan spec says: > > "pipelineBindPoint is a VkPipelineBindPoint indicating whether the > descriptors will be used by graphics pipelines or compute pipelines. > There is a separate set of bind points for each of

Re: [Mesa-dev] [RFC libdrm 0/5] Move alloc_handle_t from gralloc impls.

On Tue, Jan 16, 2018 at 12:00 AM, Rob Herring wrote: > On Mon, Jan 15, 2018 at 7:09 AM, Robert Foss > wrote: >> Hey, >> >> On 01/13/2018 12:49 AM, Gurchetan Singh wrote: >>> >>> We can define accessor functions too (not ptrs), then the struct is

Re: [Mesa-dev] [RFC libdrm 0/5] Move alloc_handle_t from gralloc impls.

On Mon, Jan 15, 2018 at 7:09 AM, Robert Foss wrote: > Hey, > > On 01/13/2018 12:49 AM, Gurchetan Singh wrote: >> >> We can define accessor functions too (not ptrs), then the struct is >> opaque >> and you can do your own accessor implementation if aligning is

[Mesa-dev] [PATCH v4 3/5] spirv_extensions: define spirv_extensions_supported

Add a struct to maintain which SPIR-V extensions are supported, and an utility method to initialize it based on nir_spirv_supported_capabilities. v2: * Fixing code style (Ian Romanick) * Adding a prefix (spirv) to fill_supported_spirv_extensions (Ian Romanick) v3: rebase update

[Mesa-dev] [PATCH v4 2/5] spirv_extensions: add list of extensions and to_string method

Ideally this should be generated somehow. One option would be gather all the extension dependencies listed on the core grammar, but there would be the possibility of not including some of the extensions. Note that spirv-tools is doing it just slightly better, as it has a hardcoded list of

[Mesa-dev] [PATCH v4 5/5] spirv_extensions: i965: initialize SPIR-V extensions

v2: Rebase update after changes on previous patches. --- src/mesa/drivers/dri/i965/brw_context.c | 9 - src/mesa/main/context.c | 2 ++ 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/brw_context.c

[Mesa-dev] [PATCH v4 4/5] spirv_extensions: add spirv_supported_extensions on gl_constants

We can use it to get real values for ARB_spirv_extensions methods. v2: Rebase update after changes on previous patches. --- src/mesa/main/mtypes.h | 3 +++ src/mesa/main/spirv_extensions.c | 20 +++- 2 files changed, 22 insertions(+), 1 deletion(-) diff --git

[Mesa-dev] [PATCH v4 0/5] ARB_spirv_extensions support in Mesa and i965

Hi, This series is the latest version of the support for ARB_spirv_extensions on i965. The patches are basically the same that v3 series we sent one month ago [1] but rebased against today master, and removing the patch that enabled the extension on i965. As with v3 it was split from a previous

[Mesa-dev] [PATCH v4 1/5] spirv_extensions: add GL_ARB_spirv_extensions boilerplate

v2: * Mention extension gap at gl_API.xml (Emil Velikov) * Bail with INVALID_ENUM if extension not available on getStringi (Emil Velikov) * Use EXTRA_EXT macro when defining the extension at get.c/get_hash_params.py (Emil Velikov) * Rename source files (spirvextensions.[ch] ->

[Mesa-dev] [PATCH v4 10/10] i965: Don't call process_glsl_ir() for SPIR-V shaders

From: Eduardo Lima Mitev v2: Use 'spirv_data' from gl_linked_shader instead, to check if shader is SPIR-V. (Timothy Arceri) Reviewed-by: Timothy Arceri --- src/mesa/drivers/dri/i965/brw_link.cpp | 3 ++- 1 file changed, 2 insertions(+), 1

[Mesa-dev] [PATCH v4 06/10] mesa/glspirv: Add _mesa_spirv_link_shaders() function

From: Eduardo Lima Mitev This is the equivalent to link_shaders() from src/compiler/glsl/linker.cpp, but for SPIR-V programs. It just creates the program and its gl_linked_shader objects, giving drivers the opportunity to implement any linking of SPIR-V shaders they choose, at

[Mesa-dev] [PATCH v4 08/10] mesa/glspirv: Add a _mesa_spirv_to_nir() function

From: Eduardo Lima Mitev This is basically a wrapper around spirv_to_nir() that includes arguments setup and post-conversion validation. v2: * Rebase update (SpirVCapabilities not a pointer anymore, spirv_to_nir_options added, and others). * Code-style improvements and

[Mesa-dev] [PATCH v4 07/10] mesa/program: Link SPIR-V shaders using the SPIR-V code-path

From: Eduardo Lima Mitev --- src/mesa/program/ir_to_mesa.cpp | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/mesa/program/ir_to_mesa.cpp b/src/mesa/program/ir_to_mesa.cpp index 29198509a6c..5d56c2ef44a 100644 --- a/src/mesa/program/ir_to_mesa.cpp

[Mesa-dev] [PATCH v4 04/10] mesa: Implement glSpecializeShaderARB

From: Nicolai Hähnle v2: * Use gl_spirv_validation instead of spirv_to_nir. This method just validates the shader. The conversion to NIR will happen later, during linking. (Alejandro Piñeiro) * Use gl_shader_spirv_data struct to store the SPIR-V data.

[Mesa-dev] [PATCH v4 09/10] i965: Call spirv_to_nir() instead of glsl_to_nir() for SPIR-V shaders

From: Eduardo Lima Mitev This is the main fork of the shader compilation code-path, where a NIR shader is obtained by calling spirv_to_nir() or glsl_to_nir(), depending on its nature.. v2: Use 'spirv_data' member from gl_linked_shader to know which method to call. (Timothy

[Mesa-dev] [PATCH v4 05/10] mesa: Add a reference to gl_shader_spirv_data to gl_linked_shader

From: Eduardo Lima Mitev This is a reference to the spirv_data object stored in gl_shader, which stores shader SPIR-V data that is needed during linking too. Reviewed-by: Timothy Arceri --- src/mesa/main/mtypes.h| 8

[Mesa-dev] [PATCH v4 02/10] i965: initialize SPIR-V capabilities

Needed for ARB_gl_spirv. Right now those are the same that the intel vulkan driver, but those are not shared. From the ARB_spirv_extensions spec: "3. If a new GL extension is added that includes SPIR-V support via a new SPIR-V extension does it's SPIR-V extension also get enumerated by

[Mesa-dev] [PATCH v4 01/10] mesa: add gl_constants::SpirVCapabilities

From: Nicolai Hähnle For drivers to declare which SPIR-V features they support. v2: Don't use a pointer (Ian Romanick) --- src/mesa/main/mtypes.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/mesa/main/mtypes.h b/src/mesa/main/mtypes.h index

[Mesa-dev] [PATCH v4 03/10] nir/spirv: add gl_spirv_validation method

ARB_gl_spirv adds the ability to use SPIR-V binaries, and a new method, glSpecializeShader. From OpenGL 4.6 spec, section 7.2.1 "Shader Specialization", error table: INVALID_VALUE is generated if does not name a valid entry point for . INVALID_VALUE is generated if any element of

[Mesa-dev] [PATCH v4 00/10] Initial gl_spirv support in Mesa and i965

Hi, This is the 4rd version of the series adding initial support for ARB_gl_spirv. This series is equal to v3 we sent one month ago [1], but rebased against today master. As with v3, we are splitting the series, so after this series we will send one for ARB_spirv_extensions. Notice also that

Re: [Mesa-dev] [PATCHv2] glx: fix non-dri build

On 15.01.2018 15:38, Samuel Thibault wrote: glXGetDriverConfig parameters do not provide a context to dynamically check for the presence of the function, so the dispatcher directly calls glXGetDriverConfig, but in non-dri builds dri_glx.c didn't provide glXGetDriverConfig. This change make it

Re: [Mesa-dev] [PATCH] glx: fix non-dri build

On 15.01.2018 15:15, Samuel Thibault wrote: Nicolai Hähnle, on lun. 15 janv. 2018 15:07:03 +0100, wrote: On 13.01.2018 12:36, Samuel Thibault wrote: glXGetDriverConfig parameters do not provide a context to dynamically check for the presence of the function, so the dispatcher directly calls

Re: [Mesa-dev] [PATCH] i965/miptree: Refactor CCS_E and CCS_D cases in render_aux_usage

On Sun, Dec 17, 2017 at 08:03:45PM -0800, Jason Ekstrand wrote: > This commit unifies the CCS_E and CCS_D cases. This should fix a couple > of subtle issues. One is that when you use INTEL_DEBUG=norbc to disable > CCS_E, we don't get the sRGB blending workaround. By unifying the code, > we give

Re: [Mesa-dev] [PATCH] glx: fix non-dri build

On 13.01.2018 12:36, Samuel Thibault wrote: glXGetDriverConfig parameters do not provide a context to dynamically check for the presence of the function, so the dispatcher directly calls glXGetDriverConfig, but in non-dri builds dri_glx.c didn't provide glXGetDriverConfig. This change makes it

[Mesa-dev] [PATCH 3/3] ac: set no-signed-zeros-fp-math when RADV_DEBUG="unsafemath" is used

This is an optimisation that is recommended by Matt Arsenault, and used by RadeonSI, but it's not compatible with Vulkan. Note that AC_FLOAT_MODE_UNSAFE_FP_MATH includes the no signed zeros flag in LLVM. v2: - enable nsz with unsafe math Signed-off-by: Samuel Pitoiset

[Mesa-dev] [PATCH 2/3] ac: set fast math flags when RADV_DEBUG="unsafemath" is used

When that debug option is not used, we use the default float mode because the no signed zeros optimisation is not Vulkan compatible. Signed-off-by: Samuel Pitoiset --- src/amd/common/ac_nir_to_llvm.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-)

[Mesa-dev] [PATCH 1/3] ac: import lp_create_builder() from gallivm

Signed-off-by: Samuel Pitoiset --- src/amd/common/ac_llvm_helper.cpp | 30 ++ src/amd/common/ac_llvm_util.h | 9 +++ src/gallium/auxiliary/gallivm/lp_bld_misc.cpp | 29 -

Re: [Mesa-dev] [PATCH 2/4] i965/miptree: Use the tiling from the modifier instead of the BO

On Thu, Jan 11, 2018 at 05:40:51PM -0800, Jason Ekstrand wrote: > From: Jason Ekstrand > > This fixes a bug where we were taking the tiling from the BO regardless > of what the modifier said. When we got images in from Vulkan where it > doesn't set the tiling on the BO, we

Re: [Mesa-dev] [PATCH 06/29] anv/image: Add a helper for determining when fast clears are supported

On Sat, Jan 13, 2018 at 11:11:35AM -0800, Jason Ekstrand wrote: > Sorry for all the list spam, but I'm sort of thinking out-loud and writing > it on the list for all to read. > > I'm thinking that what we want this list to return is not a bool but an enum > > /* The ordering of this enum is

Re: [Mesa-dev] [RFC libdrm 0/5] Move alloc_handle_t from gralloc impls.

Hey, On 01/13/2018 12:49 AM, Gurchetan Singh wrote: We can define accessor functions too (not ptrs), then the struct is opaque and you can do your own accessor implementation if aligning is not possible or desired. Accessor functions in libdrm sound good to me. Alright, this

[Mesa-dev] [PATCH 2/7] egl: add support for EGL_ANDROID_blob_cache

Signed-off-by: Tapani Pälli --- src/egl/drivers/dri2/egl_dri2.c | 43 + src/egl/drivers/dri2/egl_dri2.h | 4 src/egl/main/eglapi.c | 29 +++ src/egl/main/eglapi.h | 4

[Mesa-dev] [PATCH 5/7] i965: add __DRI2_BLOB support and set cache functions

Signed-off-by: Tapani Pälli --- src/mesa/drivers/dri/i965/intel_screen.c | 21 + 1 file changed, 21 insertions(+) diff --git a/src/mesa/drivers/dri/i965/intel_screen.c b/src/mesa/drivers/dri/i965/intel_screen.c index 08032c9b22..4c19304f14 100644 ---

[Mesa-dev] [PATCH 6/7] android: ignore MESA_GLSL_CACHE_DISABLE setting

Signed-off-by: Tapani Pälli --- src/mesa/drivers/dri/i965/brw_disk_cache.c | 2 ++ src/util/disk_cache.c | 2 ++ 2 files changed, 4 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_disk_cache.c b/src/mesa/drivers/dri/i965/brw_disk_cache.c

[Mesa-dev] [PATCH 4/7] disk cache: support setting MESA_GLSL_CACHE_DIR at compile time

Signed-off-by: Tapani Pälli --- src/util/disk_cache.c | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/src/util/disk_cache.c b/src/util/disk_cache.c index b71363bcf3..d7891e3b70 100644 --- a/src/util/disk_cache.c +++

[Mesa-dev] [PATCH 3/7] disk cache: add callback functionality

Signed-off-by: Tapani Pälli --- src/util/disk_cache.c | 39 +++ src/util/disk_cache.h | 19 +++ 2 files changed, 58 insertions(+) diff --git a/src/util/disk_cache.c b/src/util/disk_cache.c index 7ebfa8c045..b71363bcf3

[Mesa-dev] [PATCH 0/7] EGL_ANDROID_blob_cache

Hello; Here's a refactored series of EGL_ANDROID_blob_cache. Now cache functions are stored in disk_cache struct and the functionality called within existing disk_cache put/get code. Problems/errors that existed with earlier series are gone. On Android cache index file is created to

[Mesa-dev] [PATCH 7/7] android: set '/sdcard/' as MESA_GLSL_CACHE_DIR by default

This can/should be modified depending on needs. AFAIK by default, this is the only path that can be read/written to by anyone. Signed-off-by: Tapani Pälli --- Android.common.mk | 1 + 1 file changed, 1 insertion(+) diff --git a/Android.common.mk b/Android.common.mk

[Mesa-dev] [PATCH 1/7] dri: add interface for EGL_ANDROID_blob_cache extension

Signed-off-by: Tapani Pälli --- include/GL/internal/dri_interface.h | 26 +- 1 file changed, 25 insertions(+), 1 deletion(-) diff --git a/include/GL/internal/dri_interface.h b/include/GL/internal/dri_interface.h index 34a5c9fb01..de367d8f77

Re: [Mesa-dev] [PATCH] u_thread: Use pthread_setname_np on linux only

On 13/01/18 11:33, Samuel Thibault wrote: pthread_setname_np was added in glibc 2.12 for the Linux port only, other ports do not necessarily have it. --- src/util/u_thread.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/util/u_thread.h b/src/util/u_thread.h index

Re: [Mesa-dev] [PATCH] osmesa: don't check SmoothFlag twice

On Sunday, 2018-01-14 23:59:48 +0200, Grazvydas Ignotas wrote: > Trivial. Found by Coccinelle. Series is: Reviewed-by: Eric Engestrom > --- > src/mesa/drivers/osmesa/osmesa.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/src/mesa/drivers/osmesa/osmesa.c >

[Mesa-dev] [PATCH v3 2/2] anv: return VK_ERROR_OUT_OF_DEVICE_MEMORY when surface size is out of HW limits

Signed-off-by: Samuel Iglesias Gonsálvez --- src/intel/vulkan/anv_image.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/intel/vulkan/anv_image.c b/src/intel/vulkan/anv_image.c index 4d13e05e11f..401de16ddc5 100644 --- a/src/intel/vulkan/anv_image.c +++

[Mesa-dev] [PATCH v3 1/2] isl: don't crash when creating a huge image

The HW has some limits but, according to the spec, we can create the image as it has not yet any memory backing it. This patch logs a debug error and set the size to the UINT64_MAX in order to avoid allocating actual memory later. Fixes the crashes on BDW for the following tests:

Re: [Mesa-dev] [PATCH] glsl/linker: link-error using the same name in unnamed block and outside

On 01/15/2018 12:56 PM, Juan A. Suarez Romero wrote: On Thu, 2018-01-11 at 16:51 +0100, Juan A. Suarez Romero wrote: On Wed, 2018-01-10 at 14:04 +0200, Tapani Pälli wrote: On 01/08/2018 03:19 PM, Juan A. Suarez Romero wrote: Please, could someone take a look at this patch? Thanks in

[Mesa-dev] [Bug 104625] semicolon after if

https://bugs.freedesktop.org/show_bug.cgi?id=104625 --- Comment #1 from Thomas Hellström --- Thanks. This looks like a leftover debug hack. -- You are receiving this mail because: You are the QA Contact for the bug.___ mesa-dev

[Mesa-dev] [Bug 104329] Vulkan app crashes GPU

https://bugs.freedesktop.org/show_bug.cgi?id=104329 neel84...@gmail.com changed: What|Removed |Added CC||neel84...@gmail.com -- You are

Re: [Mesa-dev] [PATCH] glsl/linker: link-error using the same name in unnamed block and outside

On Thu, 2018-01-11 at 16:51 +0100, Juan A. Suarez Romero wrote: > On Wed, 2018-01-10 at 14:04 +0200, Tapani Pälli wrote: > > > > On 01/08/2018 03:19 PM, Juan A. Suarez Romero wrote: > > > Please, could someone take a look at this patch? Thanks in advance. > > > > > > > This looks correct to me.

Re: [Mesa-dev] [PATCH v2 1/4] anv/query: implement multiview interactions

This is still awaiting review. Any takers? On Mon, 2018-01-08 at 13:57 +0100, Iago Toral Quiroga wrote: > From the Vulkan spec with KHX extensions: > > "If queries are used while executing a render pass instance that > has >multiview enabled, the query uses N consecutive query indices >

Re: [Mesa-dev] [PATCH v2 1/3] anv/blorp: only clear enabled views when multiview is used

This series is still awaiting review, any takers? On Fri, 2018-01-05 at 17:38 +0100, Iago Toral Quiroga wrote: > --- > src/intel/vulkan/anv_blorp.c | 55 > > 1 file changed, 40 insertions(+), 15 deletions(-) > > diff --git

Re: [Mesa-dev] [PATCH] glx: fix non-dri build

Dylan Baker, on dim. 14 janv. 2018 09:37:49 -0800, wrote: > I don't know enough about glx to know if this is correct, but you'll need to > add the c files to the meson.build as well Oh, mesa now also uses meson. Ok, now commited that to my tree. Samuel