[Mesa-dev] [Bug 77449] Tracker bug for all bugs related to Steam titles

2018-04-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=77449 Bug 77449 depends on bug 91969, which changed state. Bug 91969 Summary: [radeonsi][bonaire] Stalls with Borderlands 2 https://bugs.freedesktop.org/show_bug.cgi?id=91969 What|Removed |Added

Re: [Mesa-dev] [PATCH v3] mesa: readpixels add support for GL_HALF_FLOAT

2018-04-02 Thread Tapani Pälli
Hi Eric; On 03/30/2018 11:25 PM, Eric Anholt wrote: Lin Johnson writes: Ext_color_buffer_half_float is using type GL_HALF_FLOAT and data_type GL_FLOAT. This fix Android CTS test android.view.cts.PixelCopyTest v2: remove commtens of Ext_color_buffer_half_float. As

Re: [Mesa-dev] [PATCH] st/mesa: add missing GLSL_TYPE_[U]INT8 cases in st_glsl_type_dword_size()

2018-04-02 Thread Timothy Arceri
Thanks Brian. Reviewed-by: Timothy Arceri On 31/03/18 01:40, Brian Paul wrote: Silences a compiler warning about unhandled enum switch cases. --- src/mesa/state_tracker/st_glsl_types.cpp | 3 +++ 1 file changed, 3 insertions(+) diff --git

Re: [Mesa-dev] [PATCH 05/55] radeonsi: use num_cs_dw_queries_suspend

2018-04-02 Thread Timothy Arceri
This is the only patch that seems to have a functional change. I have no idea what this is doing from a glance, are you able to put a little comment on why this is needed in the commit message? Other than that for the series: Acked-by: Timothy Arceri On 02/04/18

Re: [Mesa-dev] [PATCH] glsl: always call do_lower_jumps() after loop unrolling

2018-04-02 Thread Matt Turner
Seems reasonable. Reviewed-by: Matt Turner ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [Bug 77449] Tracker bug for all bugs related to Steam titles

2018-04-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=77449 Bug 77449 depends on bug 95308, which changed state. Bug 95308 Summary: [radeonsi] Hangs after some minutes on Team Fortress 2 https://bugs.freedesktop.org/show_bug.cgi?id=95308 What|Removed |Added

[Mesa-dev] [PATCH] st/mesa: tex offsets can't be in a const or 2d-indexed

2018-04-02 Thread Ilia Mirkin
All consts are now implicitly 2d (they set .Dimension), so trigger asserts. Also, the texture offset can't handle any sort of 2d indexing. While this could be tacked on, this seems unnecessary, just move it off into a separate temp. Fixes assertion failure in

[Mesa-dev] [PATCH] glsl: always call do_lower_jumps() after loop unrolling

2018-04-02 Thread Timothy Arceri
This fixes a bug in radeonsi where LLVM cannot handle the case where a break exists but its not the last instruction in the block. LLVM would fail with: Terminator found in the middle of a basic block! LLVM ERROR: Broken function found, compilation aborted! Fixes: 96fe8834f539 "glsl_to_tgsi: do

Re: [Mesa-dev] [PATCH] mesa: ensure that variable is initialized

2018-04-02 Thread Mark Janes
Tested-by: Mark Janes Dylan Baker writes: > locally I've added: > Fixes: 16f6634e7fb5ada308e55b852cd49251e7f3f8b1 >("mesa/program: Link SPIR-V shaders using the SPIR-V code-path") > > Quoting Dylan Baker (2018-04-02 15:36:01) >> Otherwise

Re: [Mesa-dev] [RFC] - Rewrite mesa website in Sphinx

2018-04-02 Thread Jean Hertel
Hi Laura, I haven't used any script. I made all the HTML to rst translations by hand, file by file. Kind Regards, Jean Hertel Em 2 de abril de 2018 19:09:34 BRT, Laura Ekstrand escreveu: Hi Jean, I'm going to play around with your patches to get them into a format that

Re: [Mesa-dev] [PATCH] mesa: ensure that variable is initialized

2018-04-02 Thread Dylan Baker
locally I've added: Fixes: 16f6634e7fb5ada308e55b852cd49251e7f3f8b1 ("mesa/program: Link SPIR-V shaders using the SPIR-V code-path") Quoting Dylan Baker (2018-04-02 15:36:01) > Otherwise this variable will only be set if there are spirv shaders > present, but it's used regardless,

[Mesa-dev] [PATCH] mesa: ensure that variable is initialized

2018-04-02 Thread Dylan Baker
Otherwise this variable will only be set if there are spirv shaders present, but it's used regardless, resulting in undefined behavior. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=105820 CC: Alejandro Piñeiro CC: Mark Janes Signed-off-by:

Re: [Mesa-dev] [RFC] - Rewrite mesa website in Sphinx

2018-04-02 Thread Laura Ekstrand
Hi Jean, I'm going to play around with your patches to get them into a format that Mesa devs can review. This will blow the history away. The problem is that your workflow in 1 & 2 ruins the Git history for reviewers. It makes the patch series hard to read. Could you provide us with your

Re: [Mesa-dev] VC4 not working for me with mesa 17.3.7 - was [meta-raspberrypi] VC4 not working for me with mesa 17.3.7

2018-04-02 Thread Trevor Woerner
Even without the patch, simply adding: PACKAGECONFIG_append_pn-mesa = "dri3" to my conf/local.conf has glmark2-es2 running, and chromium-x11 is running accelerated out-of-the-box (i.e. I don't have to install the egl/gles libraries it builds itself). I'm re-building my rpi3-64 image to

Re: [Mesa-dev] VC4 not working for me with mesa 17.3.7 - was [meta-raspberrypi] VC4 not working for me with mesa 17.3.7

2018-04-02 Thread Andreas Müller
On Mon, Apr 2, 2018 at 3:05 PM, Andreas Müller wrote: > On Mon, Apr 2, 2018 at 2:42 PM, Daniel Stone wrote: >> Hi Andreas, >> >> On 31 March 2018 at 15:18, Andreas Müller wrote: >>> Thanks for prompt an VERY helpful

[Mesa-dev] [Bug 105846] Assertion failure @ st_atom_array.c:675

2018-04-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105846 --- Comment #4 from l...@protonmail.ch --- After some testing, it does not seem to happen when MESA_DEBUG=context and MESA_VERBOSE=all. -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the

Re: [Mesa-dev] 2018 Election voting OPEN

2018-04-02 Thread Rob Clark
To all X.Org Foundation Members: Due to some technical difficulties, the earlier election notification messages to memb...@x.org list did not go through (but also did not trigger bounce/moderator notification). We cross referenced the members list to the subscriber lists for xorg-devel, xorg,

Re: [Mesa-dev] [PATCH] radeonsi: skip DCC render feedback checking if color writes are disabled

2018-04-02 Thread Marek Olšák
On Mon, Apr 2, 2018 at 2:22 PM, Dieter Nützel wrote: > Hello Marek, > > this one do not longer apply after 'GL_KHR_blend_equation_advanced' > landed. > The conflict can be resolved trivially. The patch is still open for review. Marek

Re: [Mesa-dev] [PATCH] nir: Look into uniform structs for samplers when counting num_textures.

2018-04-02 Thread Jason Ekstrand
Doesn't st/mesa have a pass for getting rid if the structs? On Mon, Apr 2, 2018 at 11:13 AM, Eric Anholt wrote: > mesa/st decides whether to update samplers after a program change based on > whether num_textures is nonzero. By not counting samplers in a uniform > struct, we

Re: [Mesa-dev] [PATCH] radeonsi: skip DCC render feedback checking if color writes are disabled

2018-04-02 Thread Dieter Nützel
Hello Marek, this one do not longer apply after 'GL_KHR_blend_equation_advanced' landed. Happy Easter! Dieter Am 02.04.2018 05:54, schrieb Marek Olšák: From: Marek Olšák --- src/gallium/drivers/radeonsi/si_blit.c | 5 +

[Mesa-dev] [PATCH] nir: Look into uniform structs for samplers when counting num_textures.

2018-04-02 Thread Eric Anholt
mesa/st decides whether to update samplers after a program change based on whether num_textures is nonzero. By not counting samplers in a uniform struct, we would segfault in KHR-GLES3.shaders.struct.uniform.sampler_vertex if it was run in the same context after a non-vertex-shader-uniform

Re: [Mesa-dev] [PATCH] st/dri: Initialise modifier to INVALID for DRI2

2018-04-02 Thread Daniel Stone
On 2 April 2018 at 18:52, Eric Anholt wrote: > Daniel Stone writes: >> When allocating a buffer for DRI2, set the modifier to INVALID to inform >> the backend that we have no supplied modifiers and it should do its own >> thing. The missed initialisation

Re: [Mesa-dev] [PATCH] st/dri: Initialise modifier to INVALID for DRI2

2018-04-02 Thread Eric Anholt
Daniel Stone writes: > When allocating a buffer for DRI2, set the modifier to INVALID to inform > the backend that we have no supplied modifiers and it should do its own > thing. The missed initialisation forced linear, even if the > implementation had made other

[Mesa-dev] [Bug 105442] Hang when running nine ff lighting shader with radeonsi

2018-04-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105442 Axel Davy changed: What|Removed |Added Component|Drivers/Gallium/radeonsi|Other --- Comment #3

Re: [Mesa-dev] 2018 Election voting OPEN

2018-04-02 Thread Rob Clark
On Wed, Mar 21, 2018 at 8:40 PM, Rob Clark wrote: > To all X.Org Foundation Members: > > The X.Org Foundation's annual election is now open and will remain > open until 23:59 UTC on 5 April 2018. Reminder that the elections are open until midnight on Thurs, so if you have

[Mesa-dev] [PATCH] st/nine: Declare lighting consts for ff shaders

2018-04-02 Thread Axel Davy
The lighting constants were not declared previously, but were accessed with indirect addressing, which is illegal. Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=105442 Signed-off-by: Axel Davy CC: "17.3 18.0" ---

Re: [Mesa-dev] vmware change resolution mode

2018-04-02 Thread Deepak Singh Rawat
Hi, What distro you are running ? Is open-vm-tools installed ? This package is required for setting resolutions from user-space. Also what is the Linux kernel version used ? Regarding usage of kernel option I suspect there is a upper limit on that, I will verify that. During bootup vmwgfx use

Re: [Mesa-dev] [PATCH] compiler/spirv: set is_shadow for depth comparitor sampling opcodes

2018-04-02 Thread Jason Ekstrand
On April 2, 2018 04:04:49 Iago Toral Quiroga wrote: From the SPIR-V spec, OpTypeImage: "Depth is whether or not this image is a depth image. (Note that whether or not depth comparisons are actually done is a property of the sampling opcode, not of this type declaration.)"

[Mesa-dev] [PATCH] radv: enable VK_EXT_shader_viewport_index_layer

2018-04-02 Thread Samuel Pitoiset
The driver already supports exporting the Layer and ViewportIndex built-ins from vertex or tessellation shaders. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_extensions.py | 1 + src/amd/vulkan/radv_shader.c | 1 + 2 files changed, 2 insertions(+) diff

Re: [Mesa-dev] [PATCH 4/4] swr: Fix include for createPromoteMemoryToRegisterPass

2018-04-02 Thread Kyriazis, George
Please use LLVM defines consistent with the surrounding code. Surrounding code uses LLVM_VERSION_MAJOR / LLVM_VERSION_MINOR. This code should then be: #if LLVM_VERSION_MAJOR >= 7 … #endif Thank you! George > On Apr 1, 2018, at 3:05 PM, Vinson Lee wrote: > > On Sun,

[Mesa-dev] [PATCH 2/5] i965: replace calls to dup(2) with fcntl(F_DUPFD_CLOEXEC)

2018-04-02 Thread Matt Whitlock
Without this fix, duplicated file descriptors leak into child processes. See commit aaac913e901229d11a1894f6aaf646de6b1a542c for one instance where the same fix was employed. Signed-off-by: Matt Whitlock --- src/mesa/drivers/dri/i965/brw_sync.c | 4 ++-- 1 file

[Mesa-dev] [PATCH 1/5] egl/dri2: replace call to dup(2) with fcntl(F_DUPFD_CLOEXEC)

2018-04-02 Thread Matt Whitlock
Without this fix, duplicated file descriptors leak into child processes. See commit aaac913e901229d11a1894f6aaf646de6b1a542c for one instance where the same fix was employed. Signed-off-by: Matt Whitlock --- src/egl/drivers/dri2/egl_dri2.c | 2 +- 1 file changed,

Re: [Mesa-dev] [PATCH] i965: Extend the negative 32-bit deltas to 64-bits

2018-04-02 Thread Stuart Young
Hi Sergii, I built this into mesa 17.3.7 and it seems to solve all the issues I've seen that were mentioned in 101408. This includes not just the issues with the Mortar, but the other visual artefacts that I've noticed with the player models and with other weapons in the game. Many thanks for

[Mesa-dev] [PATCH 5/5] freedreno: replace calls to dup(2) with fcntl(F_DUPFD_CLOEXEC)

2018-04-02 Thread Matt Whitlock
Without this fix, duplicated file descriptors leak into child processes. See commit aaac913e901229d11a1894f6aaf646de6b1a542c for one instance where the same fix was employed. Signed-off-by: Matt Whitlock --- src/gallium/drivers/freedreno/freedreno_fence.c | 4 ++--

[Mesa-dev] [PATCH 4/5] etnaviv: replace calls to dup(2) with fcntl(F_DUPFD_CLOEXEC)

2018-04-02 Thread Matt Whitlock
Without this fix, duplicated file descriptors leak into child processes. See commit aaac913e901229d11a1894f6aaf646de6b1a542c for one instance where the same fix was employed. Signed-off-by: Matt Whitlock --- src/gallium/drivers/etnaviv/etnaviv_fence.c | 4 ++-- 1

[Mesa-dev] [PATCH 3/5] winsys/svga/drm: replace calls to dup(2) with fcntl(F_DUPFD_CLOEXEC)

2018-04-02 Thread Matt Whitlock
Without this fix, duplicated file descriptors leak into child processes. See commit aaac913e901229d11a1894f6aaf646de6b1a542c for one instance where the same fix was employed. Signed-off-by: Matt Whitlock --- src/gallium/winsys/svga/drm/vmw_screen_svga.c | 4 ++--

Re: [Mesa-dev] VC4 not working for me with mesa 17.3.7 - was [meta-raspberrypi] VC4 not working for me with mesa 17.3.7

2018-04-02 Thread Andreas Müller
On Mon, Apr 2, 2018 at 2:42 PM, Daniel Stone wrote: > Hi Andreas, > > On 31 March 2018 at 15:18, Andreas Müller wrote: >> Thanks for prompt an VERY helpful support. I did: >> >> * Check my configure and found: --disable-dri3! >> * Tested your patch

Re: [Mesa-dev] [PATCH V2 kmscube] cube-tex: make use of modifiers

2018-04-02 Thread Daniel Stone
Hi Christian, On 2 April 2018 at 12:49, Christian Gmeiner wrote: > Fixes rendering issues with mode rgba on etnaviv. I have applied > the same change for nv12 variants but they are not supported on > etnaviv. > > [...] > > + EGLint attr[] = { >

Re: [Mesa-dev] [PATCH] RFC: Externd IMG_context_priority with NV_context_priority_realtime

2018-04-02 Thread Daniel Stone
On 30 March 2018 at 19:20, Kenneth Graunke wrote: > On Friday, March 30, 2018 7:40:13 AM PDT Chris Wilson wrote: >> For i915, we are proposing to use a quality-of-service parameter in >> addition to that of just a priority that usurps everyone. Due to our HW, >> preemption

Re: [Mesa-dev] VC4 not working for me with mesa 17.3.7

2018-04-02 Thread Daniel Stone
Hi Andreas, On 31 March 2018 at 15:18, Andreas Müller wrote: > Thanks for prompt an VERY helpful support. I did: > > * Check my configure and found: --disable-dri3! > * Tested your patch (with --disable-dri3) and as expected it fixes the issue > * Found what causes

Re: [Mesa-dev] [ANNOUNCE] Mesa 17.3.8 release candidate

2018-04-02 Thread Daniel Stone
Hi Juan, On 29 March 2018 at 11:25, Juan A. Suarez Romero wrote: > The plan is to have 17.3.8 this Monday (2nd April), around or shortly after > 11:00 > GMT. Does this mean we could expect 17.3.9 in a couple of weeks, or is this the last release for the 17.3.x branch?

[Mesa-dev] [Bug 105847] Profile GL3bc is not available on X11GraphicsDevice

2018-04-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105847 Bug ID: 105847 Summary: Profile GL3bc is not available on X11GraphicsDevice Product: Mesa Version: unspecified Hardware: x86-64 (AMD64) OS: Linux (All) Status:

[Mesa-dev] [PATCH] st/dri: Initialise modifier to INVALID for DRI2

2018-04-02 Thread Daniel Stone
When allocating a buffer for DRI2, set the modifier to INVALID to inform the backend that we have no supplied modifiers and it should do its own thing. The missed initialisation forced linear, even if the implementation had made other decisions. This resulted in VC4 DRI2 clients failing with:

[Mesa-dev] [Bug 105846] Assertion failure @ st_atom_array.c:675

2018-04-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105846 --- Comment #3 from l...@protonmail.ch --- Can't upload attachment here; got 500 internal server error. -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the

[Mesa-dev] [Bug 105846] Assertion failure @ st_atom_array.c:675

2018-04-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105846 --- Comment #2 from l...@protonmail.ch --- link to coredump (also uploading as attachment):

[Mesa-dev] [PATCH V2 kmscube] cube-tex: make use of modifiers

2018-04-02 Thread Christian Gmeiner
Fixes rendering issues with mode rgba on etnaviv. I have applied the same change for nv12 variants but they are not supported on etnaviv. Signed-off-by: Christian Gmeiner --- common.c | 3 +++ common.h | 19 + cube-tex.c | 91

Re: [Mesa-dev] [PATCH kmscube 2/2] Use weak functions to handle lack of gbm modifiers

2018-04-02 Thread Rob Clark
On Fri, Mar 30, 2018 at 10:17 AM, Emil Velikov wrote: > From: Emil Velikov > > Add weak function declaration and check if they're valid prior > to calling the functions. > > This allows us to remove conditional compilation, yet allowing the >

Re: [Mesa-dev] [PATCH kmscube 1/2] Rework default modifier handling

2018-04-02 Thread Rob Clark
On Fri, Mar 30, 2018 at 10:17 AM, Emil Velikov wrote: > From: Emil Velikov > > Currently the default modifier is MOD_INVALID. At a later stage, if the > modifier is the same (the user may have explicit selected MOD_INVALID), > we'll fallback

[Mesa-dev] [Bug 105846] Assertion failure @ st_atom_array.c:675

2018-04-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105846 --- Comment #1 from l...@protonmail.ch --- Created attachment 138489 --> https://bugs.freedesktop.org/attachment.cgi?id=138489=edit glxinfo for 0b73c8 -- You are receiving this mail because: You are the assignee for the bug. You are the QA

[Mesa-dev] [Bug 105846] Assertion failure @ st_atom_array.c:675

2018-04-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105846 Bug ID: 105846 Summary: Assertion failure @ st_atom_array.c:675 Product: Mesa Version: unspecified Hardware: x86-64 (AMD64) OS: Linux (All) Status: NEW

Re: [Mesa-dev] [PATCH kmscube 2/2] Use weak functions to handle lack of gbm modifiers

2018-04-02 Thread Christian Gmeiner
2018-03-30 16:17 GMT+02:00 Emil Velikov : > From: Emil Velikov > > Add weak function declaration and check if they're valid prior > to calling the functions. > > This allows us to remove conditional compilation, yet allowing the > modifiers

Re: [Mesa-dev] [PATCH kmscube 1/2] Rework default modifier handling

2018-04-02 Thread Christian Gmeiner
2018-03-30 16:17 GMT+02:00 Emil Velikov : > From: Emil Velikov > > Currently the default modifier is MOD_INVALID. At a later stage, if the > modifier is the same (the user may have explicit selected MOD_INVALID), > we'll fallback to

[Mesa-dev] [PATCH] compiler/spirv: set is_shadow for depth comparitor sampling opcodes

2018-04-02 Thread Iago Toral Quiroga
From the SPIR-V spec, OpTypeImage: "Depth is whether or not this image is a depth image. (Note that whether or not depth comparisons are actually done is a property of the sampling opcode, not of this type declaration.)" OpImageSample{Proj}Dref{Explicit,Implicit}Lod sampling opcodes always do a

[Mesa-dev] [Bug 77449] Tracker bug for all bugs related to Steam titles

2018-04-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=77449 Bug 77449 depends on bug 100239, which changed state. Bug 100239 Summary: Incorrect rendering in CS:GO https://bugs.freedesktop.org/show_bug.cgi?id=100239 What|Removed |Added

[Mesa-dev] XDC 2018: Call for Papers

2018-04-02 Thread Samuel Iglesias Gonsálvez
Hello, I have the pleasure to announce that the X.org Developer Conference 2018 will be held in A Coruña, Spain from September 26th to September 28th. The venue is located at the Computer Science faculty of the University of Coruña. This year, we have created a new website for the event:

[Mesa-dev] vmware change resolution mode

2018-04-02 Thread Vignesh Raman
Hi, I have a question how to change screen resolution. I'm running a image in vmplayer. From dmesg logs I see, [2.947320] [drm] Screen Objects Display Unit initialized [2.947346] [drm] width 1280 [2.947351] [drm] height 768 [2.947356] [drm] bpp 32 lsmod | grep vmwgfx vmwgfx

Re: [Mesa-dev] [PATCH 1/2] compiler/nir: add a is_image_sample_dref flag to texture instructions

2018-04-02 Thread Iago Toral
On Wed, 2018-03-28 at 17:19 -0700, Jason Ekstrand wrote: > How is this different from is_shadow? From the SPIR-V spec, OpTypeImage: "Depth is whether or not this image is a depth image. (Note that whether or not depth comparisons are actually done is a property of the sampling opcode, not

[Mesa-dev] [Bug 104665] r600: computer shaders break Bioshock on barts (bisected)

2018-04-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=104665 --- Comment #4 from Gert Wollny --- Since the game needs OpenGL 4.1 I have export MESA_GL_VERSION_OVERRIDE=4.1 -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the

[Mesa-dev] [Bug 102204] GL_ARB_buffer_storage crippled extension on r600, radeonsi and amdgpu Mesa drivers

2018-04-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=102204 --- Comment #6 from H4nN1baL --- Created attachment 138484 --> https://bugs.freedesktop.org/attachment.cgi?id=138484=edit glxinfo4 Upgrade to Mesa 18.1 (https://launchpad.net/~paulo-miguel-dias/+archive/ubuntu/mesa/) I

[Mesa-dev] [PATCH] i965: Extend the negative 32-bit deltas to 64-bits

2018-04-02 Thread Sergii Romantsov
Gen8+ use 48-bit address relocations so need to extend the sign to 64-bit return value. Without it we have higher bits zeroed and missing the negavive values. Haswell and older use 32-bit deltas so are unaffected by this issue. v2: used int32_t fucntion parameter instead of explicit type