From: Dave Airlie
This should add all the pieces to enable tess shaders on virgl.
This + fp64 enabled should give GL4.1
---
docs/features.txt | 2 +-
src/gallium/drivers/virgl/virgl_context.c | 82 --
On Thu, Jun 7, 2018 at 6:02 PM Jason Ekstrand wrote:
>
> On June 7, 2018 16:47:17 Ilia Mirkin wrote:
>
> > On Thu, Jun 7, 2018 at 7:31 PM, Fritz Koenig wrote:
> >> On Thu, Jun 7, 2018 at 4:10 PM Ilia Mirkin wrote:
> >>>
> >>> It's slightly different than what you've specified, but can't you
>
Reviewed-by: Marek Olšák
Marek
On Tue, Jun 5, 2018 at 7:58 AM, Gert Wollny
wrote:
> This warning is misleading: When a struct is partially initialized without
> assigning to the structure members by name, then the remaining fields
> will be zeroed out, and this warning will be issued (if
Reviewed-by: Marek Olšák
Marek
On Tue, Jun 5, 2018 at 7:58 AM, Gert Wollny
wrote:
> tgsi_dump.c: In function 'iter_property':
> tgsi_dump.c:443:18: warning: comparison between signed and unsigned
> integer expressions [-Wsign-compare]
> for (i = 0; i < prop->Property.NrTokens - 1; ++i) {
Reviewed-by: Marek Olšák
Marek
On Tue, Jun 5, 2018 at 7:58 AM, Gert Wollny
wrote:
> remove unused parameter chan_index from fetch_src_file_channel, fixes
> warning:
>
> tgsi/tgsi_exec.c: In Funktion »fetch_src_file_channel«:
> tgsi/tgsi_exec.c:1480:35: Warning: unused parameter »chan_index«
I pushed the series, thanks!
Marek
On Thu, Jun 7, 2018 at 12:13 PM, Sonny Jiang wrote:
> Remembering latest states of registers to eliminate redunant
> SET_CONTEXT_REG packets
>
> Signed-off-by: Sonny Jiang
> ---
> src/gallium/drivers/radeonsi/si_state.h | 3 ++
>
radeonsi is scalar.
Marek
On Thu, Jun 7, 2018 at 3:32 PM, Christian Gmeiner <
christian.gmei...@gmail.com> wrote:
> Signed-off-by: Christian Gmeiner
> ---
> src/gallium/docs/source/screen.rst | 2 +-
> src/gallium/drivers/etnaviv/etnaviv_screen.c | 1 +
>
Ping
On Fri, Jun 1, 2018 at 1:21 AM, Marek Olšák wrote:
> From: Marek Olšák
>
> ---
> src/gallium/drivers/radeonsi/si_state_binning.c | 14 +-
> 1 file changed, 5 insertions(+), 9 deletions(-)
>
> diff --git a/src/gallium/drivers/radeonsi/si_state_binning.c
>
From: Dave Airlie
This enables ARB_gpu_shader_fp64 if the host provides it.
---
src/gallium/drivers/virgl/virgl_screen.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/gallium/drivers/virgl/virgl_screen.c
b/src/gallium/drivers/virgl/virgl_screen.c
index
On Thu, Jun 7, 2018 at 8:11 PM, Dave Airlie wrote:
> On 8 June 2018 at 07:53, Jiang, Sonny wrote:
> > By applied patch 1, gfx IB size changes obviously.
> >
> >
> > openarena GFX-IB-size changes from 7.64k to 7.44k.
> > glxgears GFX-IB-size changes from 8.48k to 8.416k.
> >
> >
> > The adding
From: Dave Airlie
---
docs/features.txt| 2 +-
src/gallium/drivers/virgl/virgl_encode.c | 7 +--
src/gallium/drivers/virgl/virgl_hw.h | 1 +
src/gallium/drivers/virgl/virgl_screen.c | 3 ++-
4 files changed, 9 insertions(+), 4 deletions(-)
diff --git
On June 7, 2018 16:47:17 Ilia Mirkin wrote:
On Thu, Jun 7, 2018 at 7:31 PM, Fritz Koenig wrote:
On Thu, Jun 7, 2018 at 4:10 PM Ilia Mirkin wrote:
It's slightly different than what you've specified, but can't you
achieve this with GL_ARB_clip_control / GL_EXT_clip_control ?
It can be,
On 8 June 2018 at 07:53, Jiang, Sonny wrote:
> By applied patch 1, gfx IB size changes obviously.
>
>
> openarena GFX-IB-size changes from 7.64k to 7.44k.
> glxgears GFX-IB-size changes from 8.48k to 8.416k.
>
>
> The adding CPU workloads are quite small in this case and it's hard to
> measure
On Fri, Jun 8, 2018 at 9:59 AM, Jan Vesely wrote:
> Use of void * in pointer arithmetic is illegal, use char * instead.
> Fixes: cf54bd5e8381dba18d52fe438acda20cc1685bf3 ("drisw: use shared
> memory when possible")
>
> Signed-off-by: Jan Vesely
>
Reviewed-by: Dave Airlie
Use of void * in pointer arithmetic is illegal, use char * instead.
Fixes: cf54bd5e8381dba18d52fe438acda20cc1685bf3 ("drisw: use shared memory when
possible")
Signed-off-by: Jan Vesely
---
src/gallium/winsys/sw/dri/dri_sw_winsys.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff
On Thu, Jun 7, 2018 at 4:02 PM Fritz Koenig wrote:
>
> Adds an extension to glFramebufferParameteri
> that will specify if the framebuffer is vertically
> flipped. Historically system framebuffers are
> vertically flipped and user framebuffers are not.
> Checking to see the state was done by
On Thu, Jun 7, 2018 at 7:31 PM, Fritz Koenig wrote:
> On Thu, Jun 7, 2018 at 4:10 PM Ilia Mirkin wrote:
>>
>> It's slightly different than what you've specified, but can't you
>> achieve this with GL_ARB_clip_control / GL_EXT_clip_control ?
>>
>
> It can be, but there is a lot of extra work that
On Thu, Jun 7, 2018 at 4:02 PM, Kenneth Graunke
wrote:
> We were enabling undefined memory checking for genxml values based on
> Valgrind being installed at build time, even for release builds. This
> generates piles and piles of assembly whenever you touch genxml.
>
> With gcc 7.3.1 and -O3
On Thu, Jun 7, 2018 at 4:10 PM Ilia Mirkin wrote:
>
> It's slightly different than what you've specified, but can't you
> achieve this with GL_ARB_clip_control / GL_EXT_clip_control ?
>
It can be, but there is a lot of extra work that needs to be done to
get ReadPixels to work correctly. It
It's slightly different than what you've specified, but can't you
achieve this with GL_ARB_clip_control / GL_EXT_clip_control ?
On Thu, Jun 7, 2018 at 7:01 PM, Fritz Koenig wrote:
> Adds an extension to glFramebufferParameteri
> that will specify if the framebuffer is vertically
> flipped.
There are also a pile of places where we look at rb->Name == 0 to determine
if it's a window-system framebuffer
On Thu, Jun 7, 2018 at 4:01 PM, Fritz Koenig wrote:
> Instead of using _mesa_is_winsys_fbo or
> _mesa_is_user_fbo to infer if an fbo is
> flipped use the InvertedY flag.
> ---
>
Adds an extension to glFramebufferParameteri
that will specify if the framebuffer is vertically
flipped. Historically system framebuffers are
vertically flipped and user framebuffers are not.
Checking to see the state was done by looking at
the name field. This adds an explicit field.
---
We were enabling undefined memory checking for genxml values based on
Valgrind being installed at build time, even for release builds. This
generates piles and piles of assembly whenever you touch genxml.
With gcc 7.3.1 and -O3 and -march=native on a Kabylake with Valgrind
installed at build
Instead of using _mesa_is_winsys_fbo or
_mesa_is_user_fbo to infer if an fbo is
flipped use the InvertedY flag.
---
src/mesa/drivers/dri/i965/brw_blorp.c | 2 +-
src/mesa/drivers/dri/i965/brw_meta_util.c | 4 +-
src/mesa/drivers/dri/i965/brw_sf.c| 6 +--
On Thu, Jun 7, 2018 at 3:45 PM, Mark Janes wrote:
> This is cc'd to stable, but causes compile errors when to stable
> branches:
>
> src/intel/isl/isl_format.c:372:20: error: ‘ISL_NUM_FORMATS’ undeclared
> (first use in this function); did you mean ‘ISL_UFLOAT’?
>
> Is it dependent on another
This is cc'd to stable, but causes compile errors when to stable
branches:
src/intel/isl/isl_format.c:372:20: error: ‘ISL_NUM_FORMATS’ undeclared
(first use in this function); did you mean ‘ISL_UFLOAT’?
Is it dependent on another patch?
Jason Ekstrand writes:
> We follow the same convention
Quoting Eric Anholt (2018-06-07 14:34:02)
> Dylan Baker writes:
>
> > The reason we restrict the use of ASM when cross compiling is that there
> > is a C based generator (mtypes) that must be run as part of the build
> > process, and it must be built for the host architecture. In the case of
> >
By applied patch 1, gfx IB size changes obviously.
openarena GFX-IB-size changes from 7.64k to 7.44k.
glxgears GFX-IB-size changes from 8.48k to 8.416k.
The adding CPU workloads are quite small in this case and it's hard to measure
it. So the assumption is that writing a SET_CONTEXT_REG
Dylan Baker writes:
> The reason we restrict the use of ASM when cross compiling is that there
> is a C based generator (mtypes) that must be run as part of the build
> process, and it must be built for the host architecture. In the case of
> an x86 host and an x86_64 build machine this is
Dylan Baker writes:
> Some of these are done already, some of them are things we're not going
> to do, like have a toggle for GLX_TLS.
>
> Signed-off-by: Dylan Baker
> -
> if with_osmesa != 'none'
>if with_osmesa == 'classic' and not with_dri_swrast
> error('OSMesa classic requires
Reviewed-by: Gurchetan Singh
On Wed, Jun 6, 2018 at 5:45 PM Dave Airlie wrote:
>
> From: Dave Airlie
>
> This hopefully adds virgl to the correct places and current statuses
> of various extensions.
>
> virgl of course relies on two external things
> a) host driver that can support the features
Quoting Eric Anholt (2018-06-07 14:18:32)
> Dylan Baker writes:
>
> > Not tested at all (not even compiled), just a blind port from autotools.
> >
> > Signed-off-by: Dylan Baker
> > ---
> > meson.build| 5 +
> > src/mapi/glapi/meson.build | 3 ++-
> > src/mesa/meson.build
Dylan Baker writes:
> ---
> meson.build | 30 ++
> meson_options.txt | 7 +++
> 2 files changed, 33 insertions(+), 4 deletions(-)
>
> diff --git a/meson.build b/meson.build
> index 0171328bcd7..f6fe141056a 100644
> --- a/meson.build
> +++ b/meson.build
>
On 8 June 2018 at 02:13, Sonny Jiang wrote:
> Remembering latest states of registers to eliminate redunant SET_CONTEXT_REG
> packets
>
Does this help anywhere btw? Numbers for an app or game.
In the past I've always found this sort of optimisation pointless, the
CP on the GPU side
does a
Dylan Baker writes:
> Not tested at all (not even compiled), just a blind port from autotools.
>
> Signed-off-by: Dylan Baker
> ---
> meson.build| 5 +
> src/mapi/glapi/meson.build | 3 ++-
> src/mesa/meson.build | 16 +---
> 3 files changed, 20
Christian Gmeiner writes:
> Signed-off-by: Christian Gmeiner
Shouldn't the cap be per shader target, rather than per screen? i965,
for example, was vector VS and scalar FS for a long time.
signature.asc
Description: PGP signature
___
mesa-dev
On Thu, Jun 7, 2018 at 3:32 PM, Christian Gmeiner
wrote:
> diff --git a/src/gallium/drivers/nouveau/nv30/nv30_screen.c
> b/src/gallium/drivers/nouveau/nv30/nv30_screen.c
> index a77f70e6bb..f7566958f9 100644
> --- a/src/gallium/drivers/nouveau/nv30/nv30_screen.c
> +++
As not every (upcoming) backend compiler is happy with
nir_lower_xxx_to_scalar lowerings do them only if the backend
is scalar (and not vec4) based.
Signed-off-by: Christian Gmeiner
---
src/mesa/state_tracker/st_glsl_to_nir.cpp | 26 +++
src/mesa/state_tracker/st_nir.h
Signed-off-by: Christian Gmeiner
---
src/gallium/docs/source/screen.rst | 2 +-
src/gallium/drivers/etnaviv/etnaviv_screen.c | 1 +
src/gallium/drivers/freedreno/freedreno_screen.c | 1 +
src/gallium/drivers/nouveau/nv30/nv30_screen.c | 1 +
On Thu, Jun 7, 2018 at 2:01 AM, Erik Faye-Lund wrote:
> Just as a fun toy, I decided to give an animated SVG "variation" of
> this a go myself:
>
> https://codepen.io/kusma/pen/vrXppL
>
> The actual SVG can be found here:
>
> https://gitlab.freedesktop.org/snippets/492
>
> The gears were
Not tested at all (not even compiled), just a blind port from autotools.
Signed-off-by: Dylan Baker
---
meson.build| 5 +
src/mapi/glapi/meson.build | 3 ++-
src/mesa/meson.build | 16 +---
3 files changed, 20 insertions(+), 4 deletions(-)
diff --git
meson 0.43 gained support for optional modules, which clover wold like
to use. Since we require 0.44.1 now we can rely on them being available
for clover.
compile tested only.
Signed-off-by: Dylan Baker
---
meson.build | 15 ---
1 file changed, 12 insertions(+), 3 deletions(-)
---
meson.build | 30 ++
meson_options.txt | 7 +++
2 files changed, 33 insertions(+), 4 deletions(-)
diff --git a/meson.build b/meson.build
index 0171328bcd7..f6fe141056a 100644
--- a/meson.build
+++ b/meson.build
@@ -601,13 +601,33 @@ if
Some of these are done already, some of them are things we're not going
to do, like have a toggle for GLX_TLS.
Signed-off-by: Dylan Baker
---
meson.build | 11 ---
src/egl/meson.build | 2 --
src/gbm/meson.build | 2 --
3 files changed, 15 deletions(-)
diff --git
This series implements most of the remaining todo's for Unix-like OSes, and
cleans up a lot of the remaining ones. The big thing in this series is
assembly/optimization support for SPARC and PPC, none of which I've tested at
all, not even compile tested. The optional modules for clover are compile
On Thu, Jun 7, 2018 at 10:51 AM, Dylan Baker wrote:
> Gentoo's ebuild system always adds -m32 to the compiler for doing x86_64
> -> x86 cross builds, while meson expects it not to do that. This
> results in an x86 -> x86 cross build, and assembly gets disabled.
>
> Fixes:
Quoting Matt Turner (2018-06-07 11:31:46)
> On Thu, Jun 7, 2018 at 11:29 AM, Dylan Baker wrote:
> > Quoting Matt Turner (2018-06-07 11:20:37)
> >> Port of 6dfc5e28f7d0 (configure.ac: Add support to enable read-only text
> >> segment on x86.) to Meson.
> >> ---
> >> meson.build | 5 +
>
On Thu, Jun 7, 2018 at 11:29 AM, Dylan Baker wrote:
> Quoting Matt Turner (2018-06-07 11:20:37)
>> Port of 6dfc5e28f7d0 (configure.ac: Add support to enable read-only text
>> segment on x86.) to Meson.
>> ---
>> meson.build | 5 +
>> meson_options.txt | 6 ++
>> 2 files changed, 11
Quoting Matt Turner (2018-06-07 11:20:37)
> Port of 6dfc5e28f7d0 (configure.ac: Add support to enable read-only text
> segment on x86.) to Meson.
> ---
> meson.build | 5 +
> meson_options.txt | 6 ++
> 2 files changed, 11 insertions(+)
>
> diff --git a/meson.build b/meson.build
>
Port of 6dfc5e28f7d0 (configure.ac: Add support to enable read-only text
segment on x86.) to Meson.
---
meson.build | 5 +
meson_options.txt | 6 ++
2 files changed, 11 insertions(+)
diff --git a/meson.build b/meson.build
index 32ab30faa4b..161aae83e31 100644
--- a/meson.build
+++
Gentoo's ebuild system always adds -m32 to the compiler for doing x86_64
-> x86 cross builds, while meson expects it not to do that. This
results in an x86 -> x86 cross build, and assembly gets disabled.
Fixes: 2d62fc06465281d3d45b8a7c7fd2b17ef718448c
("meson: disable x86 asm in fewer
This is actually quite wrong, the problem is really that gentoo and the way I've
done mesa's meson have very different expectations. I expected that most people
would treat x86_64 -> x86 as a cross compile, since it gives nice properties
like the ability to use a different pkg-config and to ensure
On Thursday, 2018-06-07 10:11:39 -0700, Dylan Baker wrote:
> This makes the reasoning for why a cross compile is not using asm
> clearer (hopefully).
>
> Signed-off-by: Dylan Baker
> ---
> meson.build | 24 +---
> 1 file changed, 17 insertions(+), 7 deletions(-)
>
> diff
Suggested-by: Emil Velikov
Signed-off-by: Eric Engestrom
---
configure.ac| 4 ++--
meson.build | 2 +-
src/egl/Makefile.am | 1 -
3 files changed, 3 insertions(+), 4 deletions(-)
diff --git a/configure.ac b/configure.ac
index 875c47fcd43a29e6c5d5..75ee1a7c01c9663250e3 100644
This makes the reasoning for why a cross compile is not using asm
clearer (hopefully).
Signed-off-by: Dylan Baker
---
meson.build | 24 +---
1 file changed, 17 insertions(+), 7 deletions(-)
diff --git a/meson.build b/meson.build
index 4d4ca5d5578..4e96a074698 100644
---
On Thursday, 2018-06-07 09:19:29 -0700, Dylan Baker wrote:
> The reason we restrict the use of ASM when cross compiling is that there
> is a C based generator (mtypes) that must be run as part of the build
> process, and it must be built for the host architecture. In the case of
> an x86 host and
https://bugs.freedesktop.org/show_bug.cgi?id=106774
--- Comment #15 from Jason Ekstrand ---
(In reply to Michel Dänzer from comment #10)
> (In reply to Jason Ekstrand from comment #9)
> > > > I'm not sure if you looked at it, but it is a piglit shader_runner
> > > > test.
> > > > The current
https://bugs.freedesktop.org/show_bug.cgi?id=106843
--- Comment #3 from Alex Granni ---
Found some posts from mailing list that describe this issue:
https://lists.freedesktop.org/archives/mesa-users/2012-May/000431.html
https://lists.freedesktop.org/archives/mesa-users/2016-March/001142.html
--
The reason we restrict the use of ASM when cross compiling is that there
is a C based generator (mtypes) that must be run as part of the build
process, and it must be built for the host architecture. In the case of
an x86 host and an x86_64 build machine this is possible as long as the
host and
Remembering latest states of registers to eliminate redunant SET_CONTEXT_REG
packets
Signed-off-by: Sonny Jiang
---
src/gallium/drivers/radeonsi/si_state.c | 7 ---
src/gallium/drivers/radeonsi/si_state.h | 3 +++
2 files changed, 7 insertions(+), 3 deletions(-)
diff --git
Remembering latest states of registers to eliminate redunant SET_CONTEXT_REG
packets
Signed-off-by: Sonny Jiang
---
src/gallium/drivers/radeonsi/si_state.h | 3 ++
src/gallium/drivers/radeonsi/si_state_binning.c | 44 +
2 files changed, 26 insertions(+), 21
Remembering latest states of registers to eliminate redunant SET_CONTEXT_REG
packets
Signed-off-by: Sonny Jiang
---
src/gallium/drivers/radeonsi/si_state.c | 6 --
src/gallium/drivers/radeonsi/si_state.h | 2 ++
2 files changed, 6 insertions(+), 2 deletions(-)
diff --git
Remembering latest states of registers to eliminate redunant SET_CONTEXT_REG
packets
Signed-off-by: Sonny Jiang
---
src/gallium/drivers/radeonsi/si_state.c | 50 +++--
src/gallium/drivers/radeonsi/si_state.h | 6
2 files changed, 28 insertions(+), 28
Remembering latest states of registers to eliminate redunant SET_CONTEXT_REG
packets
Signed-off-by: Sonny Jiang
---
src/gallium/drivers/radeonsi/si_build_pm4.h | 28
src/gallium/drivers/radeonsi/si_state.c | 22 +-
Remembering latest states of registers to eliminate redunant SET_CONTEXT_REG
packets
Signed-off-by: Sonny Jiang
---
src/gallium/drivers/radeonsi/si_build_pm4.h | 43 +
src/gallium/drivers/radeonsi/si_gfx_cs.c| 3 ++
src/gallium/drivers/radeonsi/si_pipe.h | 2 +
This patch allows building asm for x86 on x86_64 cross compiles
Fixes: 2d62fc064652 ("meson: disable x86 asm in fewer cases.")
Signed-off-by: Mike Lothian
---
If you're happy with this change, please can you commit it as I don't
have access
---
meson.build | 2 +-
1 file changed, 1
On Thu, Jun 7, 2018, 4:59 AM Lucas Stach wrote:
> Hi Marek,
>
> thanks for the review.
>
> Am Samstag, den 26.05.2018, 00:36 -0400 schrieb Marek Olšák:
> [...]
> >
> > > @@ -983,7 +760,7 @@ dri2_update_tex_buffer(struct dri_drawable
> *drawable,
> > >
> > > static __DRIimage *
> > >
https://bugs.freedesktop.org/show_bug.cgi?id=105613
--- Comment #8 from Samuel Pitoiset ---
Created attachment 140068
--> https://bugs.freedesktop.org/attachment.cgi?id=140068=edit
workaround
Not the best solution but that works.
--
You are receiving this mail because:
You are the QA
This patch adds the implementation of ARB_compute_variable_group_size
for i965. We do this by storing the group size in a buffer surface,
similarly to the work group number.
v2: Fix some indentation inconsistencies (Jordan, Ilia)
Do DIV_ROUND_UP correctly in brw_nir_lower_cs_intrinsics.c
Hi Kenneth,
Can you please look at this patch ?
2018-06-07 15:30 GMT+03:00 Den :
> Hello. Found out that this patch also fixes 2 new issues:
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=106158
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=106667
>
> Tested-by: Denis
On Thu, 2018-06-07 at 08:25 +0100, Daniel Stone wrote:
> The following dormant repos were _not_ migrated, but can be migrated
> (perhaps to an archive/ section?) if they are still useful:
> clover glw libwsbm linux-agp-compat r600_demo rbug-gui
Eek. glw has a bugfix in it from me I don't even
Reviewed-by: Lionel Landwerlin
On 06/06/18 18:47, Jason Ekstrand wrote:
---
src/mesa/drivers/dri/i965/intel_screen.c | 24
1 file changed, 20 insertions(+), 4 deletions(-)
diff --git a/src/mesa/drivers/dri/i965/intel_screen.c
Reviewed-by: Lionel Landwerlin
On 06/06/18 18:47, Jason Ekstrand wrote:
Not all of the MESA_FORMAT and ISL_FORMAT helpers we use can properly
handle RGBX formats. Also, we don't want to make decisions based on
those in the first place because we can't render to RGBA and we use the
non-sRGB
Reviewed-by: Lionel Landwerlin
On 06/06/18 18:47, Jason Ekstrand wrote:
Cc: mesa-sta...@lists.freedesktop.org
---
src/mesa/drivers/dri/i965/intel_screen.c | 16 ++--
1 file changed, 14 insertions(+), 2 deletions(-)
diff --git a/src/mesa/drivers/dri/i965/intel_screen.c
Reviewed-by: Lionel Landwerlin
On 06/06/18 18:47, Jason Ekstrand wrote:
This reworks it to work like query_dma_buf_modifiers and, in particular,
makes it more flexible so that we can disallow a non-static set of
formats.
Cc: mesa-sta...@lists.freedesktop.org
---
https://bugs.freedesktop.org/show_bug.cgi?id=106774
--- Comment #14 from almos ---
(In reply to Eero Tamminen from comment #13)
> Hang recovery is kernel functionality, not Mesa. There can be Mesa drivers
> for HW with experimental kernel drivers, which don't have reliable hang
> recovery yet
Reviewed-by: Lionel Landwerlin
On 06/06/18 18:47, Jason Ekstrand wrote:
We follow the same convention as isl_format_get_layout in having two
assertions to ensure that only valid formats are passed in. We also
check against the array size of the table because some valid formats
such as CCS
You left out isl_buffer_fill_image_param() in isl_storage_image.c
Regardless, this is an improvement and with this I actually hit the
assert :)
Reviewed-by: Lionel Landwerlin
On 06/06/18 18:47, Jason Ekstrand wrote:
We add two assertions instead of one because the first assertion that
Timothy Arceri writes:
> I still think you might be able to drop the tree without using a hash
> table. Can't you just add an offset field to the state struct and use
> this? You would increment it as you recurse down the arrays/structs via
> nir_link_uniform() and you could detect the first
Hello. Found out that this patch also fixes 2 new issues:
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=106158
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=106667
Tested-by: Denis
On 24.05.18 14:16, vadym.shovkoplias wrote:
Bugzilla:
On 06/06/18 19:10, Neil Roberts wrote:
Timothy Arceri writes:
+static struct type_tree_entry *
+build_type_tree_for_type(const struct glsl_type *type)
+{
Do we really need this? As far as I can tell we walk the types here to
build a tree then in nir_link_uniform() we walk the tree. Why
On Thursday, 2018-06-07 13:42:06 +1000, Stuart Young wrote:
> I see that the theme and logo is now on the test site! All looks good.
>
> As a test, I threw the site at WebSiteTest, Pingdom, GTMetrix and Google
> PageSpeed Insights and all came back with great results.
>
> There's a few things
On Wednesday, 2018-06-06 09:08:47 -0600, Kyle Brenneman wrote:
> If FindProcIndex in egldispatchstubs.c is called with a name that's less than
> the first entry in the array, it would end up trying to store an index of -1
> in
> an unsigned integer, wrap around to 2^32, and then crash when it
On Tuesday, 2018-06-05 12:46:35 -0700, Eric Anholt wrote:
> This will catch many automake bugs that end-users get to experience first,
> otherwise.
Good idea! Both patches are
Reviewed-by: Eric Engestrom
> ---
> .travis.yml | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff
Reviewed-by: Lionel Landwerlin
On 07/06/18 01:48, Jason Ekstrand wrote:
There were some places that were calling anv_semaphore_impl_cleanup and
neither deleting the semaphore nor setting the type back to NONE. Just
set it to NONE in impl_cleanup to avoid these issues.
Bugzilla:
Timothy Arceri writes:
>
> glsl_get_sampler_dim() contains the following:
>
> assert(glsl_type_is_sampler(type) || glsl_type_is_image(type));
>
> Which leads me to believe the code above should just be:
>
> const struct glsl_type *glsl_type = glsl_without_array(var->type);
>
> If you agree
It doesn't fix a truncation though, as even though type is 8 chars we
never write the full size (I think our max is 5 chars), but GCC is
apparently not smart enough to see that.
Reviewed-by: Bas Nieuwenhuizen
On Thu, Jun 7, 2018 at 2:30 AM, Timothy Arceri wrote:
> Fixes the gcc warning:
>
https://bugs.freedesktop.org/show_bug.cgi?id=106774
--- Comment #13 from Eero Tamminen ---
(In reply to almos from comment #12)
> (In reply to Michel Dänzer from comment #10)
> > Please don't add piglit tests which are expected to hang the GPU, or at
> > least don't set them up to be run by
On 2018-06-07 12:07 PM, Michel Dänzer wrote:
> On 2018-06-07 03:03 AM, Timothy Arceri wrote:
>> Fixes truncation warning in gcc 8.1
>>
>> Fixes: 8539c9bf3158 ("gallium/radeon: add the kernel version into the
>> renderer string")
>> ---
>> src/gallium/drivers/radeonsi/si_pipe.h | 2 +-
>> 1 file
On 2018-06-07 03:03 AM, Timothy Arceri wrote:
> Fixes truncation warning in gcc 8.1
>
> Fixes: 8539c9bf3158 ("gallium/radeon: add the kernel version into the
> renderer string")
> ---
> src/gallium/drivers/radeonsi/si_pipe.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff
On 7 June 2018 at 10:43, Rob Clark wrote:
> On Thu, Jun 7, 2018 at 3:25 AM, Daniel Stone wrote:
>> Hi,
>>
>> On 2 June 2018 at 16:45, Jason Ekstrand wrote:
>>> When the migration happens, there will be a very brief (less than 30
>>> minutes?) period during which no one will be able to push to
Hi,
On 07.06.2018 12:01, Erik Faye-Lund wrote:
Just as a fun toy, I decided to give an animated SVG "variation" of
this a go myself:
https://codepen.io/kusma/pen/vrXppL
The actual SVG can be found here:
https://gitlab.freedesktop.org/snippets/492
The gears were generated by this python
On Thu, Jun 7, 2018 at 3:25 AM, Daniel Stone wrote:
> Hi,
>
> On 2 June 2018 at 16:45, Jason Ekstrand wrote:
>> When the migration happens, there will be a very brief (less than 30
>> minutes?) period during which no one will be able to push to either repo.
>> I'll fire off an e-mail as well as
On Thu, Jun 7, 2018 at 9:25 AM, Daniel Stone wrote:
> Hi,
>
> On 2 June 2018 at 16:45, Jason Ekstrand wrote:
>> When the migration happens, there will be a very brief (less than 30
>> minutes?) period during which no one will be able to push to either repo.
>> I'll fire off an e-mail as well as
https://bugs.freedesktop.org/show_bug.cgi?id=106843
--- Comment #2 from Alex Granni ---
Can also replicate with the very short scons gles=1 because osmesa is included
in the default configuration.
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee
On Thu, Jun 7, 2018 at 11:14 AM, Mike Lothian wrote:
> Hi
>
> Is it possible to get all 3 gears lined up under the points of the "M" and
> have the 3rd gear go under the "e" if need be
There's certainly room for improvement here, yeah.
I tried to get the gears lined up, but when throwing
Hi
Is it possible to get all 3 gears lined up under the points of the "M" and
have the 3rd gear go under the "e" if need be
Cheers
Mike
On Thu, 7 Jun 2018 at 10:02 Erik Faye-Lund wrote:
> Just as a fun toy, I decided to give an animated SVG "variation" of
> this a go myself:
>
>
Just as a fun toy, I decided to give an animated SVG "variation" of
this a go myself:
https://codepen.io/kusma/pen/vrXppL
The actual SVG can be found here:
https://gitlab.freedesktop.org/snippets/492
The gears were generated by this python script, based on the glxgears
source code:
Hi Marek,
thanks for the review.
Am Samstag, den 26.05.2018, 00:36 -0400 schrieb Marek Olšák:
[...]
>
> > @@ -983,7 +760,7 @@ dri2_update_tex_buffer(struct dri_drawable *drawable,
> >
> > static __DRIimage *
> > dri2_create_image_from_winsys(__DRIscreen *_screen,
> > -
Reviewed-by: Samuel Pitoiset
On 06/07/2018 01:49 AM, Timothy Arceri wrote:
swizzle is unsigned so "desc->swizzle[c] < 0" is never true.
---
src/amd/vulkan/radv_formats.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/amd/vulkan/radv_formats.c
1 - 100 of 104 matches
Mail list logo
