[Mesa-dev] [Bug 107670] Massive slowdown under specific memcpy implementations (32bit, no-SIMD, backward copy).

2018-08-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107670 --- Comment #3 from Roland Scheidegger --- Isn't this mapped as WC? In this case I'd expect the direction to make little difference, since write combine of any decent cpu should be able to combine the writes regardless the order? Although if

Re: [Mesa-dev] [PATCH 5/8] anv/android: support import/export of AHardwareBuffer objects

2018-08-23 Thread Tapani Pälli
On 08/22/2018 05:28 PM, Jason Ekstrand wrote: On Tue, Aug 21, 2018 at 3:27 AM Tapani Pälli > wrote: v2: add support for non-image buffers (AHARDWAREBUFFER_FORMAT_BLOB) v3: properly handle usage bits when creating from image Signed-off-by: Tapani

Re: [Mesa-dev] [PATCH 3/8] anv/android: add GetAndroidHardwareBufferPropertiesANDROID

2018-08-23 Thread Tapani Pälli
On 08/22/2018 05:18 PM, Jason Ekstrand wrote: On Tue, Aug 21, 2018 at 3:27 AM Tapani Pälli > wrote: When adding YUV support, we need to figure out implementation-defined external format identifier. Signed-off-by: Tapani Pälli

Re: [Mesa-dev] [PATCH 2/8] anv: add from/to helpers with android and vulkan formats

2018-08-23 Thread Tapani Pälli
On 08/22/2018 05:11 PM, Jason Ekstrand wrote: On Tue, Aug 21, 2018 at 3:27 AM Tapani Pälli > wrote: Signed-off-by: Tapani Pälli mailto:tapani.pa...@intel.com>> ---  src/intel/vulkan/vk_format_info.h | 43 +++

Re: [Mesa-dev] [PATCH] Add NV_fragment_shader_interlock support.

2018-08-23 Thread Kevin Rogovin
Thankyou for pushing; I will post the one liner for the release notes shortly. Best Regards, -Kevin Rogovin On Fri, 24 Aug 2018 at 3.44, Jason Ekstrand wrote: > Your first version has already landed; Ken pushed it: > > >

[Mesa-dev] [Bug 107477] [DXVK] Setting high shader quality in GTA V results in LLVM error

2018-08-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107477 --- Comment #9 from Clément Guérin --- Created attachment 141267 --> https://bugs.freedesktop.org/attachment.cgi?id=141267=edit Smoke glitches Great. I can confirm that the game no longer crashes at ultra settings with this patch. However,

Re: [Mesa-dev] [PATCH v4 3/7] mesa: Add support for AMD_depth_clamp_separate

2018-08-23 Thread Marek Olšák
Looks good. Marek On Thu, Aug 23, 2018 at 11:16 PM, Sagar Ghuge wrote: > Enable _mesa_PushAttrib() and _mesa_PopAttrib() to handle > GL_DEPTH_CLAMP_NEAR_AMD and GL_DEPTH_CLAMP_FAR_AMD tokens. > > Remove DepthClamp, because DepthClampNear + DepthClampFar replaces it, > as suggested by Marek

Re: [Mesa-dev] [PATCH 2/3] configure: allow building with python3

2018-08-23 Thread Ilia Mirkin
This breaks the build for me. It selects python3 instead of python2, and gen_xmlpool.py bails out when trying to print \xf3 to stdout with a LANG=C locale. Revert until scripts are fixed and try again? On Thu, Aug 23, 2018 at 10:34 AM, Emil Velikov wrote: > From: Emil Velikov > > Pretty much

Re: [Mesa-dev] [PATCH] xmlpool: fix script to write bytes instead of locale-formatted strings

2018-08-23 Thread Ilia Mirkin
Withdrawn. This doesn't actually work. Will follow up with something that does. On Thu, Aug 23, 2018 at 11:08 PM, Ilia Mirkin wrote: > With LANG=C, print won't output any non-ascii characters. Since we're > trying to get specific bytes onto stdout, we can just write these > directly. > >

[Mesa-dev] [PATCH v4 3/7] mesa: Add support for AMD_depth_clamp_separate

2018-08-23 Thread Sagar Ghuge
Enable _mesa_PushAttrib() and _mesa_PopAttrib() to handle GL_DEPTH_CLAMP_NEAR_AMD and GL_DEPTH_CLAMP_FAR_AMD tokens. Remove DepthClamp, because DepthClampNear + DepthClampFar replaces it, as suggested by Marek Olsak. Driver that enables AMD_depth_clamp_separate will only ever look at

[Mesa-dev] [PATCH] xmlpool: fix script to write bytes instead of locale-formatted strings

2018-08-23 Thread Ilia Mirkin
With LANG=C, print won't output any non-ascii characters. Since we're trying to get specific bytes onto stdout, we can just write these directly. Signed-off-by: Ilia Mirkin --- src/util/xmlpool/gen_xmlpool.py | 16 +--- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git

Re: [Mesa-dev] [PATCH v3 3/7] mesa: Add support for AMD_depth_clamp_separate

2018-08-23 Thread Sagar Ghuge
Thank you for reviewing the patch. On 08/23/2018 06:17 PM, Marek Olšák wrote: > On Thu, Aug 23, 2018 at 8:18 PM, Sagar Ghuge wrote: >> Enable _mesa_PushAttrib() and _mesa_PopAttrib() to handle >> GL_DEPTH_CLAMP_NEAR_AMD and GL_DEPTH_CLAMP_FAR_AMD tokens. >> >> Remove DepthClamp, because

Re: [Mesa-dev] [PATCH 5/5] nir: Lower flrp differently when the alpha value is reused

2018-08-23 Thread Eric Anholt
Ian Romanick writes: > From: Ian Romanick > > For some reason, if I did not move the regular lowering to late > optimizations, the new lowering would never trigger. This also means > that the fsub lowering had to be added to late optimizations, and this > requires "intel/compiler: Repeat

[Mesa-dev] [Bug 107670] Massive slowdown under specific memcpy implementations (32bit, no-SIMD, backward copy).

2018-08-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107670 --- Comment #2 from i...@yahoo.com --- (In reply to Timothy Arceri from comment #1) > There already is asm optimized version of memcpy() in glibc. Why would we > want to reinvent that in Mesa? > > glibc should pick the right implementation for

Re: [Mesa-dev] [PATCH v2 08/11] nir: Add a array-of-vector variable shrinking pass

2018-08-23 Thread Jason Ekstrand
On Thu, Aug 23, 2018 at 8:16 PM Caio Marcelo de Oliveira Filho < caio.olive...@intel.com> wrote: > On Sat, Jul 28, 2018 at 10:44:39PM -0700, Jason Ekstrand wrote: > > This pass looks for variables with vector or array-of-vector types and > > narrows the type to only the components used. > > --- >

Re: [Mesa-dev] [PATCH v2 11/11] intel/nir: Enable nir_opt_find_array_copies

2018-08-23 Thread Jason Ekstrand
On Thu, Aug 23, 2018 at 5:42 PM Caio Marcelo de Oliveira Filho < caio.olive...@intel.com> wrote: > On Sat, Jul 28, 2018 at 10:44:42PM -0700, Jason Ekstrand wrote: > > We have to be a bit careful with this one because we want it to run in > > the optimization loop but only in the first

[Mesa-dev] [Bug 107669] [bisected] wflinfo fails ctx->Const.MaxCombinedTextureImageUnits assertion

2018-08-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107669 --- Comment #1 from Marek Olšák --- Here's your fix: diff --git a/src/mesa/drivers/dri/i965/brw_context.c b/src/mesa/drivers/dri/i965/brw_context.c index 6ba64e4e06d..51cae9dc637 100644 --- a/src/mesa/drivers/dri/i965/brw_context.c +++

Re: [Mesa-dev] [PATCH v3 3/7] mesa: Add support for AMD_depth_clamp_separate

2018-08-23 Thread Marek Olšák
On Thu, Aug 23, 2018 at 8:18 PM, Sagar Ghuge wrote: > Enable _mesa_PushAttrib() and _mesa_PopAttrib() to handle > GL_DEPTH_CLAMP_NEAR_AMD and GL_DEPTH_CLAMP_FAR_AMD tokens. > > Remove DepthClamp, because DepthClampNear + DepthClampFar replaces it, > as suggested by Marek Olsak. > > Driver that

Re: [Mesa-dev] [PATCH v2 08/11] nir: Add a array-of-vector variable shrinking pass

2018-08-23 Thread Caio Marcelo de Oliveira Filho
On Sat, Jul 28, 2018 at 10:44:39PM -0700, Jason Ekstrand wrote: > This pass looks for variables with vector or array-of-vector types and > narrows the type to only the components used. > --- > src/compiler/nir/nir.h| 1 + > src/compiler/nir/nir_split_vars.c | 694

Re: [Mesa-dev] [PATCH] Add NV_fragment_shader_interlock support.

2018-08-23 Thread Jason Ekstrand
Your first version has already landed; Ken pushed it: https://cgit.freedesktop.org/mesa/mesa/commit/src?id=7ec308d978019dd9aa0e7a756b5919e34431196d Mind making a patch with just the release notes update? Thanks! --Jason On August 22, 2018 22:57:42 Kevin Rogovin wrote: Hi, My request for

[Mesa-dev] [Bug 107670] Massive slowdown under specific memcpy implementations (32bit, no-SIMD, backward copy).

2018-08-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107670 --- Comment #1 from Timothy Arceri --- There already is asm optimized version of memcpy() in glibc. Why would we want to reinvent that in Mesa? glibc should pick the right implementation for you system. -- You are receiving this mail

[Mesa-dev] [PATCH v3 3/7] mesa: Add support for AMD_depth_clamp_separate

2018-08-23 Thread Sagar Ghuge
Enable _mesa_PushAttrib() and _mesa_PopAttrib() to handle GL_DEPTH_CLAMP_NEAR_AMD and GL_DEPTH_CLAMP_FAR_AMD tokens. Remove DepthClamp, because DepthClampNear + DepthClampFar replaces it, as suggested by Marek Olsak. Driver that enables AMD_depth_clamp_separate will only ever look at

[Mesa-dev] [Bug 107670] Massive slowdown under specific memcpy implementations (32bit, no-SIMD, backward copy).

2018-08-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107670 Bug ID: 107670 Summary: Massive slowdown under specific memcpy implementations (32bit, no-SIMD, backward copy). Product: Mesa Version: unspecified Hardware: x86 (IA32)

[Mesa-dev] [Bug 107669] [bisected] wflinfo fails ctx->Const.MaxCombinedTextureImageUnits assertion

2018-08-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107669 Bug ID: 107669 Summary: [bisected] wflinfo fails ctx->Const.MaxCombinedTextureImageUnits assertion Product: Mesa Version: git Hardware: Other OS: All

[Mesa-dev] [Bug 90311] Fail to build libglx with clang at linking stage

2018-08-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=90311 Timothy Arceri changed: What|Removed |Added Resolution|--- |WONTFIX Status|NEW

[Mesa-dev] [Bug 98831] Constantly increasing memory consumption in JavaFX applications

2018-08-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=98831 Timothy Arceri changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Mesa-dev] [Bug 103449] Mesa 17.2 cannot be built with clang and libc++

2018-08-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103449 Timothy Arceri changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Mesa-dev] [Bug 105904] Needed to delete mesa shader cache after driver upgrade for 32 bit wine vulkan programs to work.

2018-08-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105904 Timothy Arceri changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|---

Re: [Mesa-dev] [PATCH v2 11/11] intel/nir: Enable nir_opt_find_array_copies

2018-08-23 Thread Caio Marcelo de Oliveira Filho
On Sat, Jul 28, 2018 at 10:44:42PM -0700, Jason Ekstrand wrote: > We have to be a bit careful with this one because we want it to run in > the optimization loop but only in the first brw_nir_optimize call. > Later calls assume that we've lowered away copy_deref instructions and > we don't want to

Re: [Mesa-dev] OpenCL Support on older AMD GPUs

2018-08-23 Thread Jan Vesely
On Thu, 2018-08-23 at 18:11 +0300, Benson Muite wrote: > Hi, > > Is there likely to be support for OpenCL on older AMD GPUs? I have tried > running an OpenCL benchmark > (https://github.com/mpicbg-scicomp/gearshifft) on an AMD A6-6420K APU > running Fedora 28. The code seems to partially run,

[Mesa-dev] [Bug 107667] [regression, bisected] 2.5% performance drop in Middle Earth: Shadow of Mordor

2018-08-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107667 Gregor Münch changed: What|Removed |Added CC||e...@anholt.net, |

[Mesa-dev] [Bug 107667] [regression, bisected] 2.5% performance drop in Middle Earth: Shadow of Mordor

2018-08-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107667 Bug ID: 107667 Summary: [regression, bisected] 2.5% performance drop in Middle Earth: Shadow of Mordor Product: Mesa Version: git Hardware: Other OS: All

Re: [Mesa-dev] [PATCH] gallivm: don't use saturated unsigned add/sub intrinsics for llvm 8.0

2018-08-23 Thread Roland Scheidegger
Am 23.08.2018 um 22:13 schrieb Jose Fonseca: > On 23/08/18 18:53, srol...@vmware.com wrote: >> From: Roland Scheidegger >> >> These have been removed. Unfortunately auto-upgrade doesn't work for >> jit. (Worse, it seems we don't get a compilation error anymore when >> compiling the shader, rather

Re: [Mesa-dev] [PATCH] gallivm: don't use saturated unsigned add/sub intrinsics for llvm 8.0

2018-08-23 Thread Jose Fonseca
On 23/08/18 18:53, srol...@vmware.com wrote: From: Roland Scheidegger These have been removed. Unfortunately auto-upgrade doesn't work for jit. (Worse, it seems we don't get a compilation error anymore when compiling the shader, rather llvm will just do a call to a null function in the jitted

[Mesa-dev] [PATCH] i965: Replace checks for rb->Name with FlipY (v2)

2018-08-23 Thread Fritz Koenig
In the GL_MESA_framebuffer_flip_y implementation _mesa_is_winsys_fbo checks were replaced with FlipY checks. rb->Name is also used to determine if a buffer is winsys. v2: Fixes annotation [for emil] Fixes: ab05dd183cc ("i965: implement GL_MESA_framebuffer_flip_y [v3]") ---

Re: [Mesa-dev] [PATCH] i965: Replace checks for rb->Name with FlipY

2018-08-23 Thread Fritz Koenig
On Thu, Aug 23, 2018 at 11:01 AM Emil Velikov wrote: > > On Thu, 23 Aug 2018 at 18:41, Emil Velikov wrote: > > > > Hi Fritz, > > > > On Wed, 22 Aug 2018 at 23:01, Fritz Koenig wrote: > > > > > > In the GL_MESA_framebuffer_flip_y implementation > > > _mesa_is_winsys_fbo checks were replaced with

Re: [Mesa-dev] [PATCH] i965: Replace checks for rb->Name with FlipY

2018-08-23 Thread Emil Velikov
On Thu, 23 Aug 2018 at 18:41, Emil Velikov wrote: > > Hi Fritz, > > On Wed, 22 Aug 2018 at 23:01, Fritz Koenig wrote: > > > > In the GL_MESA_framebuffer_flip_y implementation > > _mesa_is_winsys_fbo checks were replaced with > > FlipY checks. rb->Name is also used to determine > > if a buffer

[Mesa-dev] [PATCH v2 1/4] gallium: Add a helper for implementing PIPE_CAP_* default values.

2018-08-23 Thread Eric Anholt
One of the pains of implementing a gallium driver is filling in a million pipe caps you don't know about yet when you're just starting out. One of the pains of working on gallium is copy-and-pasting your new PIPE_CAP into each driver. We can fix both of these by having each driver call into the

[Mesa-dev] [PATCH v2 2/4] vc4: Drop a bunch of duplicated gallium PIPE_CAP default code.

2018-08-23 Thread Eric Anholt
Now that we have the util function for the default values, we can get rid of the boilerplate. v2: drop GLSL level in favor of defaults. --- src/gallium/auxiliary/util/u_screen.c | 6 +- src/gallium/drivers/vc4/vc4_screen.c | 175 -- 2 files changed, 1 insertion(+), 180

[Mesa-dev] [PATCH v2 4/4] freedreno: Drop a bunch of duplicated gallium PIPE_CAP default code.

2018-08-23 Thread Eric Anholt
Now that we have the util function for the default values, we can get rid of the boilerplate. Cc: Rob Clark --- .../drivers/freedreno/freedreno_screen.c | 103 +- 1 file changed, 2 insertions(+), 101 deletions(-) diff --git

[Mesa-dev] [PATCH v2 3/4] v3d: Drop a bunch of duplicated gallium PIPE_CAP default code.

2018-08-23 Thread Eric Anholt
Now that we have the util function for the default values, we can get rid of the boilerplate. --- src/gallium/drivers/v3d/v3d_screen.c | 147 --- 1 file changed, 147 deletions(-) diff --git a/src/gallium/drivers/v3d/v3d_screen.c b/src/gallium/drivers/v3d/v3d_screen.c

[Mesa-dev] [PATCH] gallivm: don't use saturated unsigned add/sub intrinsics for llvm 8.0

2018-08-23 Thread sroland
From: Roland Scheidegger These have been removed. Unfortunately auto-upgrade doesn't work for jit. (Worse, it seems we don't get a compilation error anymore when compiling the shader, rather llvm will just do a call to a null function in the jitted shaders making it difficult to detect when

Re: [Mesa-dev] [PATCH] i965: Replace checks for rb->Name with FlipY

2018-08-23 Thread Emil Velikov
Hi Fritz, On Wed, 22 Aug 2018 at 23:01, Fritz Koenig wrote: > > In the GL_MESA_framebuffer_flip_y implementation > _mesa_is_winsys_fbo checks were replaced with > FlipY checks. rb->Name is also used to determine > if a buffer is winsys. This seems like it fixes your earlier patch, so you

Re: [Mesa-dev] [PATCH] autotools: include git_sha1.h in dist tarball

2018-08-23 Thread Emil Velikov
On Thu, 23 Aug 2018 at 18:31, Eric Anholt wrote: > > "Juan A. Suarez Romero" writes: > > > On Mon, 2018-08-20 at 21:32 +0100, Eric Engestrom wrote: > >> On Monday, 2018-08-20 14:23:28 +, Juan A. Suarez Romero wrote: > >> > This fixes `make distcheck`. > >> > > >> > Fixes: 471f708ed6

Re: [Mesa-dev] [PATCH] autotools: include git_sha1.h in dist tarball

2018-08-23 Thread Eric Anholt
"Juan A. Suarez Romero" writes: > On Mon, 2018-08-20 at 21:32 +0100, Eric Engestrom wrote: >> On Monday, 2018-08-20 14:23:28 +, Juan A. Suarez Romero wrote: >> > This fixes `make distcheck`. >> > >> > Fixes: 471f708ed6 ("git_sha1: simplify logic") >> > CC: Eric Engestrom >> > --- >> >

Re: [Mesa-dev] [PATCH v4 12/49] meson: don't build glx or dri by default on windows

2018-08-23 Thread Dylan Baker
Quoting Eric Engestrom (2018-08-23 10:13:17) > On Wednesday, 2018-08-22 10:04:35 -0700, Dylan Baker wrote: > > Signed-off-by: Dylan Baker > > Reviewed-by: Eric Anholt > > --- > > meson.build | 8 ++-- > > 1 file changed, 6 insertions(+), 2 deletions(-) > > > > diff --git a/meson.build

Re: [Mesa-dev] [PATCH v4 12/49] meson: don't build glx or dri by default on windows

2018-08-23 Thread Eric Engestrom
On Wednesday, 2018-08-22 10:04:35 -0700, Dylan Baker wrote: > Signed-off-by: Dylan Baker > Reviewed-by: Eric Anholt > --- > meson.build | 8 ++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/meson.build b/meson.build > index 1af610573d5..5102ffe0c7c 100644 > ---

[Mesa-dev] [Bug 107477] [DXVK] Setting high shader quality in GTA V results in LLVM error

2018-08-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107477 --- Comment #8 from Samuel Pitoiset --- Created attachment 141256 --> https://bugs.freedesktop.org/attachment.cgi?id=141256=edit possible fix Can you apply this patch? It should fix the LLVM IR error. -- You are receiving this mail

Re: [Mesa-dev] [PATCH v4 46/49] appveyor: use chocolatey (cinst) to install winflexbison

2018-08-23 Thread Dylan Baker
Quoting Jose Fonseca (2018-08-22 11:39:12) > On 22/08/18 18:05, Dylan Baker wrote: > > v2: - fix typos in commit message > > --- > > appveyor.yml | 6 +- > > 1 file changed, 1 insertion(+), 5 deletions(-) > > > > diff --git a/appveyor.yml b/appveyor.yml > > index 15a31da9411..b26a3c624e8

[Mesa-dev] [Bug 106187] Vulkan apps run on secondary GPU on multi-GPU system

2018-08-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106187 Kristoffer changed: What|Removed |Added CC||bri...@outlook.com -- You are receiving

Re: [Mesa-dev] OpenCL Support on older AMD GPUs

2018-08-23 Thread Alex Deucher
On Thu, Aug 23, 2018 at 11:30 AM Benson Muite wrote: > > Hi, > > Is there likely to be support for OpenCL on older AMD GPUs? I have tried > running an OpenCL benchmark (https://github.com/mpicbg-scicomp/gearshifft) on > an AMD A6-6420K APU running Fedora 28. The code seems to partially run, but

[Mesa-dev] [Bug 106187] Vulkan apps run on secondary GPU on multi-GPU system

2018-08-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106187 Sven Arvidsson changed: What|Removed |Added CC||s...@whiz.se -- You are receiving

Re: [Mesa-dev] [PATCH 2/3] configure: allow building with python3

2018-08-23 Thread Emil Velikov
On Thu, 23 Aug 2018 at 15:59, Eric Engestrom wrote: > > On Thursday, 2018-08-23 15:34:29 +0100, Emil Velikov wrote: > > From: Emil Velikov > > > > Pretty much all of the scripts are python2+3 compatible. > > Check and allow using python3, while adjusting the PYTHON2 refs. > > > > Note: > > -

Re: [Mesa-dev] [PATCH 1/3] vulkan/alloc: Add a vk_strdup helper

2018-08-23 Thread Jason Ekstrand
On Thu, Aug 23, 2018 at 10:34 AM Grazvydas Ignotas wrote: > On Thu, Aug 23, 2018 at 6:13 PM, Jason Ekstrand > wrote: > > --- > > src/vulkan/util/vk_alloc.h | 17 + > > 1 file changed, 17 insertions(+) > > > > diff --git a/src/vulkan/util/vk_alloc.h b/src/vulkan/util/vk_alloc.h

[Mesa-dev] [Bug 107477] [DXVK] Setting high shader quality in GTA V results in LLVM error

2018-08-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107477 --- Comment #7 from Clément Guérin --- Created attachment 141250 --> https://bugs.freedesktop.org/attachment.cgi?id=141250=edit shaders,preoptir,spirv.log Here's the output logs. -- You are receiving this mail because: You are the QA

Re: [Mesa-dev] [PATCH 1/3] vulkan/alloc: Add a vk_strdup helper

2018-08-23 Thread Grazvydas Ignotas
On Thu, Aug 23, 2018 at 6:13 PM, Jason Ekstrand wrote: > --- > src/vulkan/util/vk_alloc.h | 17 + > 1 file changed, 17 insertions(+) > > diff --git a/src/vulkan/util/vk_alloc.h b/src/vulkan/util/vk_alloc.h > index f58a80625a8..bc2bb7509e4 100644 > --- a/src/vulkan/util/vk_alloc.h

[Mesa-dev] [Bug 107477] [DXVK] Setting high shader quality in GTA V results in LLVM error

2018-08-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107477 --- Comment #6 from Clément Guérin --- Created attachment 141249 --> https://bugs.freedesktop.org/attachment.cgi?id=141249=edit checkir.log -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for

[Mesa-dev] OpenCL Support on older AMD GPUs

2018-08-23 Thread Benson Muite
Hi, Is there likely to be support for OpenCL on older AMD GPUs? I have tried running an OpenCL benchmark (https://github.com/mpicbg-scicomp/gearshifft) on an AMD A6-6420K APU running Fedora 28. The code seems to partially run, but gives incorrect results. Would it be challenging to add full

[Mesa-dev] [PATCH 2/3] anv: Copy the appliation info into the instance

2018-08-23 Thread Jason Ekstrand
--- src/intel/vulkan/anv_device.c | 27 --- src/intel/vulkan/anv_private.h | 11 ++- 2 files changed, 30 insertions(+), 8 deletions(-) diff --git a/src/intel/vulkan/anv_device.c b/src/intel/vulkan/anv_device.c index d85615caaed..0357fc7c0ea 100644 ---

[Mesa-dev] [PATCH 1/3] vulkan/alloc: Add a vk_strdup helper

2018-08-23 Thread Jason Ekstrand
--- src/vulkan/util/vk_alloc.h | 17 + 1 file changed, 17 insertions(+) diff --git a/src/vulkan/util/vk_alloc.h b/src/vulkan/util/vk_alloc.h index f58a80625a8..bc2bb7509e4 100644 --- a/src/vulkan/util/vk_alloc.h +++ b/src/vulkan/util/vk_alloc.h @@ -67,6 +67,23 @@ vk_free(const

[Mesa-dev] [PATCH 3/3] anv: Claim to support depthBounds for ID games

2018-08-23 Thread Jason Ekstrand
--- src/intel/vulkan/anv_device.c | 9 + 1 file changed, 9 insertions(+) diff --git a/src/intel/vulkan/anv_device.c b/src/intel/vulkan/anv_device.c index 0357fc7c0ea..5a63592f7ca 100644 --- a/src/intel/vulkan/anv_device.c +++ b/src/intel/vulkan/anv_device.c @@ -854,6 +854,15 @@ void

Re: [Mesa-dev] [PATCH 3/3] travis: use python3 for the autoconf builds

2018-08-23 Thread Eric Engestrom
On Thursday, 2018-08-23 15:34:30 +0100, Emil Velikov wrote: > From: Emil Velikov > > Signed-off-by: Emil Velikov Reviewed-by: Eric Engestrom > --- > .travis.yml | 12 +++- > 1 file changed, 11 insertions(+), 1 deletion(-) > > diff --git a/.travis.yml b/.travis.yml > index

Re: [Mesa-dev] [PATCH 2/3] configure: allow building with python3

2018-08-23 Thread Eric Engestrom
On Thursday, 2018-08-23 15:34:29 +0100, Emil Velikov wrote: > From: Emil Velikov > > Pretty much all of the scripts are python2+3 compatible. > Check and allow using python3, while adjusting the PYTHON2 refs. > > Note: > - python3.4 is used as it's the earliest supported version > - python3

Re: [Mesa-dev] [PATCH 1/3] bin/git_sha1_gen.py: remove execute bit/shebang

2018-08-23 Thread Eric Engestrom
On Thursday, 2018-08-23 15:34:28 +0100, Emil Velikov wrote: > From: Emil Velikov > > The script is executed explicitly via the build system, that uses > PYTHON/prog_python and equivalent. All 4 build systems actually do the same thing there, almost hard to believe :] Reviewed-by: Eric

[Mesa-dev] [PATCH 3/3] travis: use python3 for the autoconf builds

2018-08-23 Thread Emil Velikov
From: Emil Velikov Signed-off-by: Emil Velikov --- .travis.yml | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/.travis.yml b/.travis.yml index 90f9ec40e12..4ef0286a68f 100644 --- a/.travis.yml +++ b/.travis.yml @@ -90,6 +90,7 @@ matrix: -

[Mesa-dev] [PATCH 2/3] configure: allow building with python3

2018-08-23 Thread Emil Velikov
From: Emil Velikov Pretty much all of the scripts are python2+3 compatible. Check and allow using python3, while adjusting the PYTHON2 refs. Note: - python3.4 is used as it's the earliest supported version - python3 is chosen prior to python2 Signed-off-by: Emil Velikov --- configure.ac

[Mesa-dev] [PATCH 1/3] bin/git_sha1_gen.py: remove execute bit/shebang

2018-08-23 Thread Emil Velikov
From: Emil Velikov The script is executed explicitly via the build system, that uses PYTHON/prog_python and equivalent. Signed-off-by: Emil Velikov --- bin/git_sha1_gen.py | 2 -- 1 file changed, 2 deletions(-) mode change 100755 => 100644 bin/git_sha1_gen.py diff --git

[Mesa-dev] [PATCH 1/2] radv: record if the framebuffer has CB/DB metadata

2018-08-23 Thread Samuel Pitoiset
For further optimizations. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_device.c | 7 +++ src/amd/vulkan/radv_private.h | 3 +++ 2 files changed, 10 insertions(+) diff --git a/src/amd/vulkan/radv_device.c b/src/amd/vulkan/radv_device.c index 79dbbd886d..be4c9719c1 100644 ---

[Mesa-dev] [PATCH 2/2] radv: only flush CB/DB metadata for subpass barriers when needed

2018-08-23 Thread Samuel Pitoiset
Shouldn't be required when the framebuffer doesn't use CB or DB metadata. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_cmd_buffer.c | 42 1 file changed, 32 insertions(+), 10 deletions(-) diff --git a/src/amd/vulkan/radv_cmd_buffer.c

Re: [Mesa-dev] [PATCH] i965/gen6/xfb: handle case where transform feedback is not active

2018-08-23 Thread Samuel Iglesias Gonsálvez
The patch seems fine to me. I also tested it on Intel CI and there were no regressions. Reviewed-by: Samuel Iglesias Gonsálvez Thanks, Sam On 15/08/18 17:20, asimiklit.w...@gmail.com wrote: > From: Andrii Simiklit > > When the SVBI Payload Enable is false I guess the register R1.4 > which

[Mesa-dev] [PATCH] intel: compiler: remove dead local variables at optimization pass

2018-08-23 Thread Lionel Landwerlin
We're hitting an assert in gfxbench because one of the local variable is a sampler (according to Jason this isn't valid) : testfw_app: ../src/compiler/nir_types.cpp:551: void glsl_get_natural_size_align_bytes(const glsl_type*, unsigned int*, unsigned int*): Assertion `!"type does not have a

Re: [Mesa-dev] [PATCH] compiler: nir: opt_large_constants: don't consider empty sized variables

2018-08-23 Thread Lionel Landwerlin
On 23/08/2018 13:50, Jason Ekstrand wrote: On Thu, Aug 23, 2018 at 7:04 AM Lionel Landwerlin mailto:lionel.g.landwer...@intel.com>> wrote: We're hitting an assert in gfxbench because one of the local variable is a sampler : Of course we were That's because gfxbench does illegal

Re: [Mesa-dev] [PATCH] compiler: nir: opt_large_constants: don't consider empty sized variables

2018-08-23 Thread Jason Ekstrand
On Thu, Aug 23, 2018 at 7:04 AM Lionel Landwerlin < lionel.g.landwer...@intel.com> wrote: > We're hitting an assert in gfxbench because one of the local variable is a > sampler : > Of course we were That's because gfxbench does illegal things like creating local variables which are samplers.

[Mesa-dev] [PATCH] compiler: nir: opt_large_constants: don't consider empty sized variables

2018-08-23 Thread Lionel Landwerlin
We're hitting an assert in gfxbench because one of the local variable is a sampler : testfw_app: ../src/compiler/nir_types.cpp:551: void glsl_get_natural_size_align_bytes(const glsl_type*, unsigned int*, unsigned int*): Assertion `!"type does not have a natural size"' failed. Signed-off-by:

Re: [Mesa-dev] [PATCH] glsl: Do not propagate 'precise' and 'invariant' on read-only variables

2018-08-23 Thread Danylo Piliaiev
Hi Jason, On 8/22/18 7:07 PM, Jason Ekstrand wrote: I think this would be correct to do and would fix the bug at hand but there may be other bugs lurking deeper.  In particular, if you have multiple shaders for the same stage that share some global variables and get linked together, I think

Re: [Mesa-dev] [PATCH] python: Remove shebang and executable bit

2018-08-23 Thread Emil Velikov
On Thu, 23 Aug 2018 at 11:11, Eric Engestrom wrote: > > On Wednesday, 2018-08-22 18:58:26 +0200, Mathieu Bridon wrote: > > Since the script is never executed directly, but launched by Meson as an > > argument to the Python interpreter, those are not needed any more. > > > > In addition, they are

[Mesa-dev] [Bug 107477] [DXVK] Setting high shader quality in GTA V results in LLVM error

2018-08-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107477 --- Comment #5 from Samuel Pitoiset --- Actually, I would need the SPIRV too in order to reproduce the problem myself. Can you try with RADV_DEBUG=shaders,preoptir,spirv and attach the output? You will need spirv-dis in your path. Thanks! --

Re: [Mesa-dev] [PATCH] intel/decoder: Decode SFIXED values.

2018-08-23 Thread Lionel Landwerlin
On 23/08/2018 09:07, Kenneth Graunke wrote: This lets us example SAMPLER_STATE's LOD Bias field, among other things. Thanks Ken! Reviewed-by: Lionel Landwerlin --- src/intel/common/gen_decoder.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git

[Mesa-dev] [PATCH v2] glsl/linker: Allow unused in blocks which are not declated on previous stage

2018-08-23 Thread vadym.shovkoplias
From Section 4.3.4 (Inputs) of the GLSL 1.50 spec: "Only the input variables that are actually read need to be written by the previous stage; it is allowed to have superfluous declarations of input variables." Fixes: * interstage-multiple-shader-objects.shader_test v2:

Re: [Mesa-dev] [PATCH] python: Remove shebang and executable bit

2018-08-23 Thread Eric Engestrom
On Wednesday, 2018-08-22 18:58:26 +0200, Mathieu Bridon wrote: > Since the script is never executed directly, but launched by Meson as an > argument to the Python interpreter, those are not needed any more. > > In addition, they are the reason this script was missed when I moved the > Meson

[Mesa-dev] [Bug 107477] [DXVK] Setting high shader quality in GTA V results in LLVM error

2018-08-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107477 --- Comment #4 from Samuel Pitoiset --- Can you also try with RADV_DEBUG=checkir and show me the output please? -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the

Re: [Mesa-dev] [PATCH] glsl/linker: Allow unused in blocks which are not declated on previous stage

2018-08-23 Thread Alejandro Piñeiro
On 23/08/18 01:51, Timothy Arceri wrote: > On 21/08/18 19:42, Vadym Shovkoplias wrote: >> Hi Timothy, Alejandro, >> >> Thanks for the review comments! >> I'd just like to mention that the same approach is already used >> in link_varyings.cpp file in >> function cross_validate_outputs_to_inputs().

Re: [Mesa-dev] EGL_MESA_query_renderer

2018-08-23 Thread Emil Velikov
On Wed, 22 Aug 2018 at 19:12, Rob Clark wrote: > > On Wed, Aug 22, 2018 at 1:43 PM Emil Velikov wrote: > > > > On 21 August 2018 at 14:40, Rob Clark wrote: > > > On Tue, Aug 21, 2018 at 5:19 AM Emil Velikov > > > wrote: > > >> > > >> HI all, > > >> > > >> On 20 August 2018 at 20:01, Rob Clark

[Mesa-dev] [PATCH] intel/decoder: Decode SFIXED values.

2018-08-23 Thread Kenneth Graunke
This lets us example SAMPLER_STATE's LOD Bias field, among other things. --- src/intel/common/gen_decoder.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/src/intel/common/gen_decoder.c b/src/intel/common/gen_decoder.c index ec0a486b101..a276f37835b 100644 ---

Re: [Mesa-dev] ANDROID: eglCreateImageKHR missing modifiers

2018-08-23 Thread Tapani Pälli
On 08/22/2018 07:56 PM, Emil Velikov wrote: Hi all, Pardon for dropping in so late. I've seems to have missed this. On 24 July 2018 at 14:24, Martin Fuzzey wrote: Hi Thomasz, thanks for your reply On 21/07/18 04:27, Tomasz Figa wrote: As you noticed, this adds back the dependency on

Re: [Mesa-dev] [PATCH] glapi: actually implement GL_EXT_robustness for GLES

2018-08-23 Thread Tapani Pälli
Reviewed-by: Tapani Pälli On 08/23/2018 12:56 AM, Marek Olšák wrote: From: Marek Olšák The extension was exposed but not the functions. This fixes: dEQP-GLES31.functional.debug.negative_coverage.get_error.buffer.readn_pixels