[Mesa-dev] [Bug 108355] Civilization VI - Artifacts in mouse cursor

https://bugs.freedesktop.org/show_bug.cgi?id=108355 Hadrien Nilsson changed: What|Removed |Added Component|Drivers/Gallium/radeonsi|Drivers/Gallium/softpipe

[Mesa-dev] [PATCH] vulkan: Add VK_EXT_calibrated_timestamps extension (radv and anv) [v4]

Offers three clocks, device, clock monotonic and clock monotonic raw. Could use some kernel support to reduce the deviation between clock values. v2: Ensure deviation is at least as big as the GPU time interval. v3: Set device->lost when returning DEVICE_LOST. Use MAX2

Re: [Mesa-dev] [PATCH] vulkan: Add VK_EXT_calibrated_timestamps extension (radv and anv) [v3]

Jason Ekstrand writes: > You need to add this to anv_gem_stubs.c as well or else the unit tests > won't build. Sorry for not catching it earlier. I'm always missing this > too. Well, that's a bit hard to test as -Dbuild-tests=true fails in a bunch of glx tests, but I think I've got it. >

[Mesa-dev] [PATCH] meson: Add -Werror=return-type when supported.

This warning detects non-void functions with a missing return statement, return statements with a value in void functions, and functions with an bogus return type that ends up defaulting to int. It's already enabled by default with -Wall. Generally, these are fairly serious bugs in the code,

Re: [Mesa-dev] [PATCH] vulkan: Add VK_EXT_calibrated_timestamps extension (radv and anv) [v3]

On Mon, Oct 15, 2018 at 6:05 PM Keith Packard wrote: > Offers three clocks, device, clock monotonic and clock monotonic > raw. Could use some kernel support to reduce the deviation between > clock values. > > v2: > Ensure deviation is at least as big as the GPU time interval. > > v3: >

[Mesa-dev] [PATCH] nir: Allow using nir_lower_io_to_scalar_early on VS input vars.

This will be used on V3D to cut down the size of the VS inputs in the VPM (memory area for sharing data between shader stages). --- src/compiler/nir/nir_lower_io_to_scalar.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/compiler/nir/nir_lower_io_to_scalar.c

Re: [Mesa-dev] [PATCH] i965: Add PCI IDs for new Amberlake parts that are Coffeelake based

On Mon, Oct 15, 2018 at 04:05:39PM -0700, Kenneth Graunke wrote: > See commit c0c46ca461f136a0ae1ed69da6c874e850aeeb53 in the Linux kernel, > where José Roberto de Souza added this new PCI ID there. Reviewed-by: Rodrigo Vivi > --- > include/pci_ids/i965_pci_ids.h | 5 +++-- > 1 file

Re: [Mesa-dev] [PATCH] i965: Add PCI IDs for new Amberlake parts that are Coffeelake based

Reviewed-by: Jordan Justen On 2018-10-15 16:05:39, Kenneth Graunke wrote: > See commit c0c46ca461f136a0ae1ed69da6c874e850aeeb53 in the Linux kernel, > where José Roberto de Souza added this new PCI ID there. > --- > include/pci_ids/i965_pci_ids.h | 5 +++-- > 1 file changed, 3 insertions(+), 2

[Mesa-dev] [PATCH] i965: Add PCI IDs for new Amberlake parts that are Coffeelake based

See commit c0c46ca461f136a0ae1ed69da6c874e850aeeb53 in the Linux kernel, where José Roberto de Souza added this new PCI ID there. --- include/pci_ids/i965_pci_ids.h | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/include/pci_ids/i965_pci_ids.h

[Mesa-dev] [PATCH] vulkan: Add VK_EXT_calibrated_timestamps extension (radv and anv) [v3]

Offers three clocks, device, clock monotonic and clock monotonic raw. Could use some kernel support to reduce the deviation between clock values. v2: Ensure deviation is at least as big as the GPU time interval. v3: Set device->lost when returning DEVICE_LOST. Use MAX2

Re: [Mesa-dev] [PATCH] intel: disable FS IR validation in release mode.

Reviewed-by: Matt Turner ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH] st/mesa: Record shader access qualifiers for images

From: Jason Ekstrand They're not required to be the same as the access flag on the image unit. For hardware that does shader image lowering based on the qualifier (Intel), it may be required for state setup. --- src/gallium/include/pipe/p_state.h | 1 +

[Mesa-dev] [PATCH] intel: disable FS IR validation in release mode.

We probably don't need to iterate, fprintf, and abort in release mode. --- src/intel/compiler/brw_fs_validate.cpp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/intel/compiler/brw_fs_validate.cpp b/src/intel/compiler/brw_fs_validate.cpp index 676942c19c0..75a794fd794 100644 ---

Re: [Mesa-dev] [PATCH] vulkan: Add VK_EXT_calibrated_timestamps extension (radv and anv) [v2]

On 15/10/2018 22:22, Keith Packard wrote: +#define TIMESTAMP 0x2358 + +VkResult radv_GetCalibratedTimestampsEXT( Heh, I think you copied that define over from Anv ;) ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org

Re: [Mesa-dev] [PATCH] vulkan: Add VK_EXT_calibrated_timestamps extension (radv and anv) [v2]

On Mon, Oct 15, 2018 at 4:22 PM Keith Packard wrote: > Offers three clocks, device, clock monotonic and clock monotonic > raw. Could use some kernel support to reduce the deviation between > clock values. > > v2: > Ensure deviation is at least as big as the GPU time interval. > >

Re: [Mesa-dev] [PATCH] anv: Don't advertise ASTC support on BSW

On Mon, Oct 15, 2018 at 01:07:12PM -0500, Jason Ekstrand wrote: > --- > src/intel/vulkan/anv_formats.c | 8 > 1 file changed, 8 insertions(+) > This patch is Reviewed-by: Nanley Chery > diff --git a/src/intel/vulkan/anv_formats.c b/src/intel/vulkan/anv_formats.c > index

Re: [Mesa-dev] [PATCH] Add tests for VK_EXT_calibrated_timestamps [v2]

Jason Ekstrand writes: > We're using MRs for crucible. Please create one and make sure you check > the "Allow commits from members who can merge to the target branch" so it > can be rebased through the UI by someone other than yourself. OOo. Shiny! -- -keith signature.asc Description: PGP

[Mesa-dev] [PATCH] vulkan: Add VK_EXT_calibrated_timestamps extension (radv and anv) [v2]

Offers three clocks, device, clock monotonic and clock monotonic raw. Could use some kernel support to reduce the deviation between clock values. v2: Ensure deviation is at least as big as the GPU time interval. Signed-off-by: Keith Packard --- src/amd/vulkan/radv_device.c | 84

Re: [Mesa-dev] [PATCH] Add tests for VK_EXT_calibrated_timestamps [v2]

We're using MRs for crucible. Please create one and make sure you check the "Allow commits from members who can merge to the target branch" so it can be rebased through the UI by someone other than yourself. --Jason On Mon, Oct 15, 2018 at 4:15 PM Keith Packard wrote: > Five tests: > > 1)

[Mesa-dev] [PATCH] Add tests for VK_EXT_calibrated_timestamps [v2]

Five tests: 1) Check for non-null function pointers 2) Check for in-range time domains 3) Check monotonic domains for correct values 4) Check correlation between monotonic and device domains 5) Check to make sure times in device domain match queue times Signed-off-by: Keith Packard ---

[Mesa-dev] [Bug 107971] SPV_GOOGLE_hlsl_functionality1 / SPV_GOOGLE_decorate_string

https://bugs.freedesktop.org/show_bug.cgi?id=107971 --- Comment #5 from Jason Ekstrand --- If you want to give me a "Tested-by" tag, I'll happily add it to the patch before pushing. -- You are receiving this mail because: You are the assignee for the

Re: [Mesa-dev] [PATCH v3] nir: Copy propagation between blocks

On Mon, Oct 15, 2018 at 3:07 PM Caio Marcelo de Oliveira Filho < caio.olive...@intel.com> wrote: > Extend the pass to propagate the copies information along the control > flow graph. It performs two walks, first it collects the vars > that were written inside each node. Then it walks applying

[Mesa-dev] [Bug 107971] SPV_GOOGLE_hlsl_functionality1 / SPV_GOOGLE_decorate_string

https://bugs.freedesktop.org/show_bug.cgi?id=107971 --- Comment #4 from xbx --- thanks. the patches work fine. -- You are receiving this mail because: You are the assignee for the bug.___ mesa-dev mailing list mesa-dev@lists.freedesktop.org

Re: [Mesa-dev] [PATCH 2/7] nir/int64: Add some more lowering helpers

On Mon, Oct 15, 2018 at 3:13 PM Connor Abbott wrote: > On Mon, Oct 15, 2018 at 8:41 PM Jason Ekstrand > wrote: > > > > On Mon, Oct 15, 2018 at 1:39 PM Ian Romanick > wrote: > >> > >> On 10/14/2018 03:58 PM, Jason Ekstrand wrote: > >> > On October 14, 2018 17:12:34 Matt Turner wrote: > >> >>

Re: [Mesa-dev] [PATCH 2/7] nir/int64: Add some more lowering helpers

On Mon, Oct 15, 2018 at 8:41 PM Jason Ekstrand wrote: > > On Mon, Oct 15, 2018 at 1:39 PM Ian Romanick wrote: >> >> On 10/14/2018 03:58 PM, Jason Ekstrand wrote: >> > On October 14, 2018 17:12:34 Matt Turner wrote: >> >> +static nir_ssa_def * >> >> +lower_iabs64(nir_builder *b, nir_ssa_def *x)

[Mesa-dev] [PATCH v3] nir: Copy propagation between blocks

Extend the pass to propagate the copies information along the control flow graph. It performs two walks, first it collects the vars that were written inside each node. Then it walks applying the copy propagation using a list of copies previously available. At each node the list is invalidated

Re: [Mesa-dev] [RFC 4/7] mesa: Helper functions for counting set bits in a mask

Am 15.10.18 um 15:19 schrieb Toni Lönnberg: > --- > src/util/bitscan.h | 25 + > 1 file changed, 25 insertions(+) > > diff --git a/src/util/bitscan.h b/src/util/bitscan.h > index dc89ac9..cdfecaf 100644 > --- a/src/util/bitscan.h > +++ b/src/util/bitscan.h > @@ -112,6

Re: [Mesa-dev] [PATCH] anv: Don't advertise ASTC support on BSW

Tested-by: Mark Janes Jason Ekstrand writes: > --- > src/intel/vulkan/anv_formats.c | 8 > 1 file changed, 8 insertions(+) > > diff --git a/src/intel/vulkan/anv_formats.c b/src/intel/vulkan/anv_formats.c > index 33faf7cc37f..9199567f445 100644 > --- a/src/intel/vulkan/anv_formats.c >

Re: [Mesa-dev] [PATCH 5/7] nir/int64: Call nir_lower_int64() in a loop

On Mon, Oct 15, 2018 at 1:48 PM Ian Romanick wrote: > On 10/14/2018 03:11 PM, Matt Turner wrote: > > Unfortunately some int64 lowerings generate more int64 operations, so we > > need to call this function a few times. Also call > > nir_lower_alu_to_scalar() beforehand to make more int64

Re: [Mesa-dev] [PATCH 11/11] nir: Copy propagation between blocks

Can you please re-send the latest version of this patch? It's easier to comment on the ML. On Mon, Oct 15, 2018 at 12:44 PM Caio Marcelo de Oliveira Filho < caio.olive...@intel.com> wrote: > Hi, > > > > + } > > > + > > > + if (new_written) { > > > + /* Merge new information to the

Re: [Mesa-dev] [PATCH 05/11] nir: Separate dead write removal into its own pass

Latest version is Reviewed-by: Jason Ekstrand On Mon, Oct 15, 2018 at 2:41 PM Jason Ekstrand wrote: > Cool, thanks! > > On Mon, Oct 15, 2018 at 2:38 PM Caio Marcelo de Oliveira Filho < > caio.olive...@intel.com> wrote: > >> > > > > +{ >> > > > > + bool progress = false; >> > > > > + >> > >

Re: [Mesa-dev] [PATCH] st/mesa: Pass index to pipe->create_query() for statistics queries.

FWIW the gallium pipeline stats query exists for way longer than the GL ARB spec for it, and at least llvmpipe implemented it for ages. So the reason for it being like that is due to dx10 (which always queries these together), when gl couldn't do it at all. To make it a bit nicer you could use

Re: [Mesa-dev] [PATCH 05/11] nir: Separate dead write removal into its own pass

Cool, thanks! On Mon, Oct 15, 2018 at 2:38 PM Caio Marcelo de Oliveira Filho < caio.olive...@intel.com> wrote: > > > > > +{ > > > > > + bool progress = false; > > > > > + > > > > > + /* Find writes that are unused and can be removed. */ > > > > > +

Re: [Mesa-dev] [PATCH 05/11] nir: Separate dead write removal into its own pass

> > > > +{ > > > > + bool progress = false; > > > > + > > > > + /* Find writes that are unused and can be removed. */ > > > > + util_dynarray_foreach_reverse(unused_writes, struct write_entry, > > > > entry) { > > > > + nir_deref_compare_result comp = nir_compare_derefs(dst, > >

Re: [Mesa-dev] [PATCH 5/7] nir/int64: Call nir_lower_int64() in a loop

On 10/14/2018 03:11 PM, Matt Turner wrote: > Unfortunately some int64 lowerings generate more int64 operations, so we > need to call this function a few times. Also call > nir_lower_alu_to_scalar() beforehand to make more int64 operations > available for lowering. > --- >

Re: [Mesa-dev] [PATCH 4/7] nir/int64: Implement lowering of shift operations

On 10/14/2018 07:16 PM, Jason Ekstrand wrote: > On Sun, Oct 14, 2018 at 5:12 PM Matt Turner > wrote: > > --- >  src/compiler/nir/nir.h             |   1 + >  src/compiler/nir/nir_lower_int64.c | 142 > + >  2 files

Re: [Mesa-dev] [PATCH 2/7] nir/int64: Add some more lowering helpers

On Mon, Oct 15, 2018 at 1:39 PM Ian Romanick wrote: > On 10/14/2018 03:58 PM, Jason Ekstrand wrote: > > On October 14, 2018 17:12:34 Matt Turner wrote: > >> +static nir_ssa_def * > >> +lower_iabs64(nir_builder *b, nir_ssa_def *x) > >> +{ > >> + nir_ssa_def *x_hi =

Re: [Mesa-dev] [PATCH 2/7] nir/int64: Add some more lowering helpers

On 10/14/2018 03:58 PM, Jason Ekstrand wrote: > On October 14, 2018 17:12:34 Matt Turner wrote: >> +static nir_ssa_def * >> +lower_iabs64(nir_builder *b, nir_ssa_def *x) >> +{ >> +   nir_ssa_def *x_hi = nir_unpack_64_2x32_split_y(b, x); >> +   nir_ssa_def *x_is_neg = nir_ilt(b, x_hi,

Re: [Mesa-dev] [PATCH 3/3] appveyor: Cache pip's cache files.

Am 12.10.18 um 17:27 schrieb Jose Fonseca: > It should speed up the Python packages installation. > --- > appveyor.yml | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/appveyor.yml b/appveyor.yml > index a4e942c14ca..ccb84fd3403 100644 > --- a/appveyor.yml > +++ b/appveyor.yml > @@

[Mesa-dev] [PATCH] anv: Don't advertise ASTC support on BSW

--- src/intel/vulkan/anv_formats.c | 8 1 file changed, 8 insertions(+) diff --git a/src/intel/vulkan/anv_formats.c b/src/intel/vulkan/anv_formats.c index 33faf7cc37f..9199567f445 100644 --- a/src/intel/vulkan/anv_formats.c +++ b/src/intel/vulkan/anv_formats.c @@ -521,6 +521,14 @@

Re: [Mesa-dev] [PATCH] i965: Drop assert about number of uniforms in ARB handling.

Reviewed-by: Jason Ekstrand On Mon, Oct 15, 2018 at 12:49 PM Kenneth Graunke wrote: > My recent prog_to_nir patch started making new sampler uniforms, which > apparently increased the number of parameters. We used to poke at the > one parameter directly, making it important that there was

[Mesa-dev] [PATCH] i965: Drop assert about number of uniforms in ARB handling.

My recent prog_to_nir patch started making new sampler uniforms, which apparently increased the number of parameters. We used to poke at the one parameter directly, making it important that there was only one, but we haven't done that in a while. It should be safe to just delete the assertion.

Re: [Mesa-dev] [PATCH 11/11] nir: Copy propagation between blocks

Hi, > > + } > > + > > + if (new_written) { > > + /* Merge new information to the parent control flow node. */ > > + if (written) { > > + written->modes |= new_written->modes; > > + struct hash_entry *ht_entry; > > + hash_table_foreach(new_written->derefs,

Re: [Mesa-dev] [PATCH 05/11] nir: Separate dead write removal into its own pass

On Mon, Oct 15, 2018 at 12:37 PM Caio Marcelo de Oliveira Filho < caio.olive...@intel.com> wrote: > Hi, > > > > +{ > > > + bool progress = false; > > > + > > > + /* Find writes that are unused and can be removed. */ > > > + util_dynarray_foreach_reverse(unused_writes, struct write_entry, >

Re: [Mesa-dev] [PATCH 05/11] nir: Separate dead write removal into its own pass

Hi, > > +{ > > + bool progress = false; > > + > > + /* Find writes that are unused and can be removed. */ > > + util_dynarray_foreach_reverse(unused_writes, struct write_entry, > > entry) { > > + nir_deref_compare_result comp = nir_compare_derefs(dst, entry->dst); > > + if (comp &

[Mesa-dev] [PATCH] intel/tools: fix error_decode batch length

count field is in dwords, the argument to the decoder is in bytes... Signed-off-by: Lionel Landwerlin Fixes: d374423eabbfe3 ("intel/tools: Switch aubinator_error_decode over to the gen_print_batch") --- src/intel/tools/aubinator_error_decode.c | 3 ++- 1 file changed, 2 insertions(+), 1

Re: [Mesa-dev] [RFC] Allow fd.o to join forces with X.Org

On October 15, 2018 2:50:13 PM UTC, Harry Wentland wrote: > The leadership of freedesktop.org (fd.o) has recently expressed > interest > in having an elected governing body. Given the tight connection > between > fd.o and X.Org and the fact that X.Org has such a governing body it > seemed

Re: [Mesa-dev] [PATCH v5 4/5] loader/dri3: Enable adaptive_sync via _VARIABLE_REFRESH property

On 10/15/2018 11:18 AM, Michel Dänzer wrote: On 2018-10-12 6:48 p.m., Nicholas Kazlauskas wrote: The DDX driver can be notified of adaptive sync suitability by flagging the application's window with the _VARIABLE_REFRESH property. This property is set on the first swap the application performs

Re: [Mesa-dev] [PATCH 09/13] anv: Implement vkCmdDrawIndirectByteCountEXT

On Mon, Oct 15, 2018 at 7:06 AM Lionel Landwerlin < lionel.g.landwer...@intel.com> wrote: > On 13/10/2018 14:09, Jason Ekstrand wrote: > > Annoyingly, this requires that we implement integer division on the > > command streamer. Fortunately, we're only ever dividing by constants so > > we can

Re: [Mesa-dev] [PATCH 08/13] anv: Implement the basic form of VK_EXT_transform_feedback

On Mon, Oct 15, 2018 at 8:34 AM Lionel Landwerlin < lionel.g.landwer...@intel.com> wrote: > On 13/10/2018 14:09, Jason Ekstrand wrote: > > --- > > src/intel/vulkan/anv_cmd_buffer.c | 29 +++ > > src/intel/vulkan/anv_device.c | 24 ++ > > src/intel/vulkan/anv_extensions.py |

Re: [Mesa-dev] [PATCH] ac/nir: Use context-specific LLVM types

Reviewed-by: Samuel Pitoiset On 10/15/18 5:23 PM, Bas Nieuwenhuizen wrote: Reviewed-by: Bas Nieuwenhuizen Thanks! On Mon, Oct 15, 2018 at 5:19 PM Alex Smith wrote: LLVMInt*Type() return types from the global context and therefore are not safe for use in other contexts. Use types from our

Re: [Mesa-dev] [PATCH] ac/nir: Use context-specific LLVM types

Reviewed-by: Bas Nieuwenhuizen Thanks! On Mon, Oct 15, 2018 at 5:19 PM Alex Smith wrote: > > LLVMInt*Type() return types from the global context and therefore are > not safe for use in other contexts. Use types from our own context > instead. > > Fixes frequent crashes seen when doing

Re: [Mesa-dev] [PATCH 1/3] anv: Add a dummy implementation of GetPhysicalDevicePresentRectanglesKHR

And what size would that be on Wayland? I've opened a spec bug about this and we'll talk about it on the SI call this week. This entrypoint seems extraordinarily half-baked to me. I don't see how it makes any sense outside of VK_KHR_display or windows full-screen exclusive. --Jason On Mon,

Re: [Mesa-dev] [PATCH 1/3] anv: Add a dummy implementation of GetPhysicalDevicePresentRectanglesKHR

Argh :( Shouldn't we at least return the size of the surface? On 15/10/2018 16:08, Jason Ekstrand wrote: It's explicitly for a multi-device case where each device presents to part of the screen.  Since we don't do that, I'm not sure what we're supposed to do. On Mon, Oct 15, 2018 at 9:14 AM

[Mesa-dev] [PATCH] ac/nir: Use context-specific LLVM types

LLVMInt*Type() return types from the global context and therefore are not safe for use in other contexts. Use types from our own context instead. Fixes frequent crashes seen when doing multithreaded pipeline creation. Fixes: 4d0b02bb5a "ac: add support for 16bit load_push_constant" Fixes:

Re: [Mesa-dev] [PATCH v5 4/5] loader/dri3: Enable adaptive_sync via _VARIABLE_REFRESH property

On 2018-10-12 6:48 p.m., Nicholas Kazlauskas wrote: > The DDX driver can be notified of adaptive sync suitability by > flagging the application's window with the _VARIABLE_REFRESH property. > > This property is set on the first swap the application performs > when adaptive_sync is set to true in

Re: [Mesa-dev] [PATCH 1/3] anv: Add a dummy implementation of GetPhysicalDevicePresentRectanglesKHR

It's explicitly for a multi-device case where each device presents to part of the screen. Since we don't do that, I'm not sure what we're supposed to do. On Mon, Oct 15, 2018 at 9:14 AM Lionel Landwerlin < lionel.g.landwer...@intel.com> wrote: > I'm guessing we should plugged that into the

[Mesa-dev] [PATCH] swr/rast: fix intrinsic/function for LLVM 7 compatibility

Converted from x86 VFMADDPS intrinsic to generic LLVM intrinsic, and removed createInstructionSimplifierPass, which were both removed in LLVM 7.0.0 These changes combine patches we received from the community and our own internal patches --- .../swr/rasterizer/codegen/gen_llvm_ir_macros.py

[Mesa-dev] [RFC] Allow fd.o to join forces with X.Org

The leadership of freedesktop.org (fd.o) has recently expressed interest in having an elected governing body. Given the tight connection between fd.o and X.Org and the fact that X.Org has such a governing body it seemed obvious to consider extending X.Org's mandate to fd.o. Quite a bit of

[Mesa-dev] [Bug 108353] Request: Control Center for AMD GPU

https://bugs.freedesktop.org/show_bug.cgi?id=108353 --- Comment #2 from Alex Deucher --- The tricky part is making something that works across different desktop environments. Each desktop environment stores it's display settings in a different way. Additionally, since most of the

[Mesa-dev] [Bug 108353] Request: Control Center for AMD GPU

https://bugs.freedesktop.org/show_bug.cgi?id=108353 Alex Deucher changed: What|Removed |Added Severity|normal |enhancement -- You are receiving this

Re: [Mesa-dev] [PATCH 1/3] anv: Add a dummy implementation of GetPhysicalDevicePresentRectanglesKHR

I'm guessing we should plugged that into the number of screen on bare DRM for example, which each screen native size reported in pRects. On 15/10/2018 04:47, Jason Ekstrand wrote: Not really sure what we're supposed to do with this one but we should do something. ---

Re: [Mesa-dev] [PATCH 00/13] anv: Add support for VK_EXT_transform_feedback

I've left a couple of comments on patch 8 about a programming note for Gen10+ and a nit on patch 9. Otherwise patches 7->13 are : Reviewed-by: Lionel Landwerlin (Hopefully Samuel & you can review each other's nir changes :) On 13/10/2018 14:09, Jason Ekstrand wrote: This series adds support

Re: [Mesa-dev] [PATCH 08/13] anv: Implement the basic form of VK_EXT_transform_feedback

On 13/10/2018 14:09, Jason Ekstrand wrote: --- src/intel/vulkan/anv_cmd_buffer.c | 29 +++ src/intel/vulkan/anv_device.c | 24 ++ src/intel/vulkan/anv_extensions.py | 2 +- src/intel/vulkan/anv_pipeline.c| 10 ++- src/intel/vulkan/anv_private.h | 13 +++

[Mesa-dev] [RFC 2/7] i965: SIMD32 heuristics control data

Added a new structure for holding SIMD32 heuristics control data. The control data itself will be fetched from drirc. --- src/intel/compiler/brw_compiler.h | 11 +++ 1 file changed, 11 insertions(+) diff --git a/src/intel/compiler/brw_compiler.h b/src/intel/compiler/brw_compiler.h index

[Mesa-dev] [RFC 6/7] i965/fs: SIMD32 selection heuristic based on grouped texture fetches

The function goes through the compiled shader and checks how many grouped texture fetches there are. This is a simple heuristic which gets rid of most of the regressions when enabling SIMD32 shaders but still retains some of the benefits. --- src/intel/compiler/brw_fs.cpp | 26

[Mesa-dev] [RFC 3/7] i965: SIMD32 heuristics control data from drirc

To be able to test the heuristics with different parameters, they can be controlled via environment variables through drirc. --- src/mesa/drivers/dri/i965/brw_context.c | 13 + src/mesa/drivers/dri/i965/intel_screen.c | 27 +++ 2 files changed, 40

[Mesa-dev] [RFC 5/7] i965/fs: Save the instruction count of each dispatch width

The SIMD32 selection heuristics will use this information for deciding whether SIMD32 shaders should be used. --- src/intel/compiler/brw_fs.h | 2 ++ src/intel/compiler/brw_fs_generator.cpp | 12 2 files changed, 14 insertions(+) diff --git a/src/intel/compiler/brw_fs.h

[Mesa-dev] [RFC 4/7] mesa: Helper functions for counting set bits in a mask

--- src/util/bitscan.h | 25 + 1 file changed, 25 insertions(+) diff --git a/src/util/bitscan.h b/src/util/bitscan.h index dc89ac9..cdfecaf 100644 --- a/src/util/bitscan.h +++ b/src/util/bitscan.h @@ -112,6 +112,31 @@ u_bit_scan64(uint64_t *mask) return i; } +/*

[Mesa-dev] [RFC 7/7] i965/fs: Enable all SIMD32 heuristics

There are three simple heuristics for SIMD32 shader enabling: - How many MRTs does the shader write into? - How many grouped texture fetches does the shader have? - How many instructions does the SIMD32 shader have compared to the SIMD16 shader? For testing purposes, the heuristics can be

[Mesa-dev] [RFC 1/7] i965: SIMD32 heuristics debug flag

Added a new DEBUG_HEUR32 flag to INTEL_DEBUG flags for enabling SIMD32 selection heuristics. --- src/intel/common/gen_debug.c | 1 + src/intel/common/gen_debug.h | 3 ++- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/src/intel/common/gen_debug.c b/src/intel/common/gen_debug.c

[Mesa-dev] [RFC 0/7] i965: SIMD32 selection heuristics

Since we have SIMD32 support available for fragment shaders, it would be nice to actually enable them. The changes proposed here are not meant as the final solution to SIMD32 selection by any means, they're meant to be a way to enable SIMD32 in case a customer absolutely needs them to be enabled

Re: [Mesa-dev] [PATCH] radv: implement buffer to image operations for R32G32B32

On Mon, Oct 15, 2018 at 12:35 PM Samuel Pitoiset wrote: > > This should fix rendering issues with Batman Arkham City. > We will probably need to implement itob and itoi at some > point, but currently nothing hits these paths. > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107765 >

[Mesa-dev] [PATCH] radv: bump discreteQueuePriorities to 2

It's the minimum value required by the spec. This fixes dEQP-VK.api.info.device.properties. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_device.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/amd/vulkan/radv_device.c b/src/amd/vulkan/radv_device.c index

[Mesa-dev] [PATCH] radv: do not force the flat qualifier for clip/cull distances

This fixes some new CTS that reads clip/cull distances from the fragment shader stage: dEQP-VK.clipping.user_defined.clip_* Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_pipeline.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/amd/vulkan/radv_pipeline.c

Re: [Mesa-dev] [PATCH 09/13] anv: Implement vkCmdDrawIndirectByteCountEXT

On 13/10/2018 14:09, Jason Ekstrand wrote: Annoyingly, this requires that we implement integer division on the command streamer. Fortunately, we're only ever dividing by constants so we can use the mulh+add+shift trick and it's not as bad as it sounds. --- src/intel/vulkan/anv_device.c |

Re: [Mesa-dev] [PATCH 08/13] anv: Implement the basic form of VK_EXT_transform_feedback

On 13/10/2018 14:09, Jason Ekstrand wrote: --- src/intel/vulkan/anv_cmd_buffer.c | 29 +++ src/intel/vulkan/anv_device.c | 24 ++ src/intel/vulkan/anv_extensions.py | 2 +- src/intel/vulkan/anv_pipeline.c| 10 ++- src/intel/vulkan/anv_private.h | 13 +++

Re: [Mesa-dev] [PATCH] radv: implement buffer to image operations for R32G32B32

Tested-by: Timothy Arceri ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH] radv: implement buffer to image operations for R32G32B32

This should fix rendering issues with Batman Arkham City. We will probably need to implement itob and itoi at some point, but currently nothing hits these paths. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107765 Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_meta_bufimage.c

[Mesa-dev] [Bug 108365] swr: segfault when running test case GLES2.functional.vertex_arrays.multiple_attributes.stride.3_float2_17_float2_17_float2_0

https://bugs.freedesktop.org/show_bug.cgi?id=108365 Bug ID: 108365 Summary: swr: segfault when running test case GLES2.functional.vertex_arrays.multiple_attributes.str ide.3_float2_17_float2_17_float2_0 Product: Mesa

Re: [Mesa-dev] [PATCH 02/15] nir: fix compacting varyings when XFB outputs are present

On 10/14/18 11:30 PM, Timothy Arceri wrote: What happened to v2? This one isn't up-to-date. On 13/10/18 11:57 pm, Samuel Pitoiset wrote: We shouldn't try to compact any varyings known as always active IO, especially XFB outputs. For example, if one component of an xfb output is also used

Re: [Mesa-dev] [PATCH 01/15] vulkan: Update the XML and headers to 1.1.88

On 10/15/18 9:54 AM, Bas Nieuwenhuizen wrote: On Mon, Oct 15, 2018 at 9:37 AM Jason Ekstrand wrote: Acked-by: Jason Ekstrand Let's land the header. As far as I can tell, you did that yesterday already:

Re: [Mesa-dev] [PATCH] radv: Implement VK_EXT_pci_bus_info.

Reviewed-by: Samuel Pitoiset On 10/13/18 7:21 PM, Bas Nieuwenhuizen wrote: --- src/amd/vulkan/radv_device.c | 10 ++ src/amd/vulkan/radv_extensions.py | 1 + src/amd/vulkan/radv_private.h | 2 ++ 3 files changed, 13 insertions(+) diff --git

Re: [Mesa-dev] [PATCH 1/7] i965/fs: Add 64-bit int immediate support to dump_instructions()

Patches 1 and 2 are: Reviewed-by: Iago Toral Quiroga On Sun, 2018-10-14 at 15:11 -0700, Matt Turner wrote: > --- > src/intel/compiler/brw_fs.cpp | 6 ++ > src/intel/compiler/brw_shader.h | 2 ++ > 2 files changed, 8 insertions(+) > > diff --git a/src/intel/compiler/brw_fs.cpp >

Re: [Mesa-dev] [PATCH 01/15] vulkan: Update the XML and headers to 1.1.88

On Mon, Oct 15, 2018 at 9:37 AM Jason Ekstrand wrote: > > Acked-by: Jason Ekstrand > > Let's land the header. As far as I can tell, you did that yesterday already: https://gitlab.freedesktop.org/mesa/mesa/commit/13fd4e601c80b85317feac894c52bd24e4f98c09 ? > > On Sat, Oct 13, 2018 at 7:55 AM

Re: [Mesa-dev] [PATCH 04/15] radv: gather the number of streams used by geometry shaders

On Sat, Oct 13, 2018 at 2:56 PM Samuel Pitoiset wrote: > > This will be used for splitting the GS->VS ring buffer. The > stream ID is always 0 for now. > > Signed-off-by: Samuel Pitoiset > --- > src/amd/vulkan/radv_shader.h | 1 + > src/amd/vulkan/radv_shader_info.c | 14 ++ >

[Mesa-dev] [PATCH] nir: fix clip cull lowering to not assert if GLSL already lowered.

From: Dave Airlie If GLSL has already done the lowering, we'd rather not crash in this pass. Reviewed-by: Kenneth Graunke --- src/compiler/nir/nir_lower_clip_cull_distance_arrays.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/compiler/nir/nir_lower_clip_cull_distance_arrays.c

[Mesa-dev] [PATCH] st/mesa: Pass index to pipe->create_query() for statistics queries.

GL exposes separate queries for each pipeline statistics counter. For some reason, Gallium chose to map them all to a single target, PIPE_QUERY_PIPELINE_STATISTICS. Radeon hardware appears to query them all as a group. pipe->get_query_result_resource() takes an index, indicating which to write