[Mesa-dev] [Bug 108742] Battlefield 4 in Wine Freezes when joining games since ~mesa-18.2.3

2018-11-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108742 coolo...@gmail.com changed: What|Removed |Added CC||coolo...@gmail.com -- You are

[Mesa-dev] [Bug 108749] XInput support doesn't support rumble on the DS4 (at least)

2018-11-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108749 epigr...@yahoo.com changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Mesa-dev] [Bug 108749] XInput support doesn't support rumble on the DS4 (at least)

2018-11-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108749 Bug ID: 108749 Summary: XInput support doesn't support rumble on the DS4 (at least) Product: Mesa Version: unspecified Hardware: Other OS: All

[Mesa-dev] [PATCH] intel/compiler: Disassemble GEN6_SFID_DATAPORT_SAMPLER_CACHE as dp_sampler

2018-11-14 Thread Sagar Ghuge
Both BRW_SFID_SAMPLER and GEN6_SFID_DATAPORT_SAMPLER_CACHE are getting disassembled as "sampler", which is misleading for assembler tool. Signed-off-by: Sagar Ghuge --- src/intel/compiler/brw_disasm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[Mesa-dev] [Bug 90346] DispatchSanity_test.GLES2 regression

2018-11-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=90346 Tapani Pälli changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

Re: [Mesa-dev] [PATCH 1/2] nir: add new nir_remove_dead_barriers() pass

2018-11-14 Thread Timothy Arceri
On 14/11/18 11:39 pm, Bas Nieuwenhuizen wrote: On Wed, Nov 14, 2018 at 1:03 PM Timothy Arceri wrote: On 14/11/18 10:22 pm, Bas Nieuwenhuizen wrote: On Wed, Nov 14, 2018 at 6:30 AM Timothy Arceri wrote: Link time opts can remove unused outputs leaving behind useless barriers. This pass

Re: [Mesa-dev] [PATCH 2/2] radv: force-enable primitive binning for The Talos Principle

2018-11-14 Thread Bas Nieuwenhuizen
On Wed, Nov 14, 2018 at 5:32 PM Samuel Pitoiset wrote: > > > > On 11/14/18 5:28 PM, Bas Nieuwenhuizen wrote: > > On Wed, Nov 14, 2018 at 5:26 PM Samuel Pitoiset > > wrote: > >> > >> +5% in ultra settings for both 4k and 1080p. > >> > >> Signed-off-by: Samuel Pitoiset > >> --- > >>

[Mesa-dev] [PATCH] gallium/u_tests: add a compute shader test that clears an image

2018-11-14 Thread Marek Olšák
From: Marek Olšák --- src/gallium/auxiliary/util/u_tests.c | 77 1 file changed, 77 insertions(+) diff --git a/src/gallium/auxiliary/util/u_tests.c b/src/gallium/auxiliary/util/u_tests.c index 59953dc70a4..cb930ee0d03 100644 ---

Re: [Mesa-dev] [PATCH 0/8] intel: Move shared/SSBO access lowering to NIR

2018-11-14 Thread Jason Ekstrand
I just sent one more, "nir/lower_io: Add shared to get_io_offset_src" that's required for the pass to apply properly to shared vairables. Do we have any testing of shared variables with anything other than 32 bits? Do we even test 64 bits? I'm begining to think that there are basically zero

[Mesa-dev] [PATCH] nir/lower_io: Add shared to get_io_offset_src

2018-11-14 Thread Jason Ekstrand
--- src/compiler/nir/nir_lower_io.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/compiler/nir/nir_lower_io.c b/src/compiler/nir/nir_lower_io.c index f3377eaec8f..64424307812 100644 --- a/src/compiler/nir/nir_lower_io.c +++ b/src/compiler/nir/nir_lower_io.c @@ -538,6 +538,7 @@

Re: [Mesa-dev] [PATCH 7/8] nir: Add alignment parameters to SSBO, UBO, and shared access

2018-11-14 Thread Karol Herbst
I like the general idea, we just shouldn't rely too much on the type size later on, especially in regards to CL where we can have unaligned load/stores especially for packed structs. Acked-by: Karol Herbst On Wed, Nov 14, 2018 at 12:24 AM Jason Ekstrand wrote: > > This also changes spirv_to_nir

Re: [Mesa-dev] [PATCH 3/8] nir/builder: Add iadd_imm and imul_imm helpers

2018-11-14 Thread Karol Herbst
Reviewed-by: Karol Herbst On Wed, Nov 14, 2018 at 12:23 AM Jason Ekstrand wrote: > > The pattern of adding or multiplying an integer by an immediate is > fairly common especially in deref chain handling. This adds a helper > for it and uses it a few places. The advantage to the helper is that

Re: [Mesa-dev] [PATCH 17/22] nir: rename global to private memory

2018-11-14 Thread Jason Ekstrand
On Tue, Nov 13, 2018 at 9:49 AM Karol Herbst wrote: > the naming is a bit confusing no matter how you look at it. Within OpenCL > "global" memory is memory accessible from all threads. glsl "global" memory > normally refers to shader thread private memory declared at global scope. > As > we

Re: [Mesa-dev] [PATCH 10/9] bin/get-pick-list.sh: handle reverts prior to the branchpoint

2018-11-14 Thread Emil Velikov
On Wed, 14 Nov 2018 at 18:51, Emil Velikov wrote: > > From: Emil Velikov > > Currently we detect when a breaking commit: > - has landed in stable, and > - is referenced by a untagged fix in master > > Yet we did not consider the case of breaking commit: > - prior to the branchpoint, and > -

[Mesa-dev] [PATCH 10/9] bin/get-pick-list.sh: handle reverts prior to the branchpoint

2018-11-14 Thread Emil Velikov
From: Emil Velikov Currently we detect when a breaking commit: - has landed in stable, and - is referenced by a untagged fix in master Yet we did not consider the case of breaking commit: - prior to the branchpoint, and - is referenced by a untagged fix in master Addressing the latter is

Re: [Mesa-dev] [PATCH v3] i965: Fix calculation of layers array length for isl_view

2018-11-14 Thread Jason Ekstrand
On Wed, Nov 14, 2018 at 6:02 AM Danylo Piliaiev wrote: > Hi Ilia, Jason, > > All these cases are indeed could induce confusion, > I'll try to explain all of them: > > Texture is not layered: > Layers: 1 > Base Layer: %layer of image unit% + %layer of texture view% > > Layered 3D

Re: [Mesa-dev] [PATCH] st/mesa: Don't record garbage streamout information in the non-SSO case.

2018-11-14 Thread Gert Wollny
Hi Kenneth, unfortunately this patch breaks r600. I tried to dig into it to figure out where things going wrong but I was not very successful so far. While the right shader (TES) registers the stream output in the shader translation also with your patch, querying with GL_QUERY_RESULT just now

Re: [Mesa-dev] [PATCH 1/5] i965/icl: Fix L3 configurations

2018-11-14 Thread Anuj Phogat
No problem Ken. On Tue, Nov 13, 2018 at 9:48 PM Kenneth Graunke wrote: > On Tuesday, November 13, 2018 2:33:58 PM PST Anuj Phogat wrote: > > Use L3 configuration table specified in h/w specification. > > > > Signed-off-by: Anuj Phogat > > Cc: Kenneth Graunke > > Cc: Francisco Jerez > > Cc:

[Mesa-dev] [Bug 108734] Regression: [bisected] dEQP-GLES31.functional.tessellation.invariance.* start failing on r600

2018-11-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108734 --- Comment #1 from Gert Wollny --- A bit of digging showed that in these tests the driver only seems to write streamout data from the TES shader, but it somehow gets lost. My guess is that the driver at one point ignores the TF information

Re: [Mesa-dev] [PATCH mesa] egl: add missing glvnd entrypoint for EGL_ANDROID_blob_cache

2018-11-14 Thread Emil Velikov
On Wed, 14 Nov 2018 at 12:55, Eric Engestrom wrote: > > Fixes dEQP-EGL.functional.get_proc_address.extension.egl_android_blob_cache > on builds with glvnd enabled. > > Fixes: 6f5b57093b3462a54e9c7 "egl: add support for EGL_ANDROID_blob_cache" > Signed-off-by: Eric Engestrom > Reviewed-by: Tapani

Re: [Mesa-dev] [PATCH mesa] gbm: add new entrypoint to symbols check

2018-11-14 Thread Eric Anholt
Eric Engestrom writes: > Fixes: 6328536ff28ca26f2ad4e "gbm: Introduce a helper function for > printing GBM format names." > Cc: Eric Anholt > Signed-off-by: Eric Engestrom r-b. Oh, how I wish we had merge requests that were gated on CI. signature.asc

Re: [Mesa-dev] [PATCH 2/2] radv: force-enable primitive binning for The Talos Principle

2018-11-14 Thread Samuel Pitoiset
On 11/14/18 5:28 PM, Bas Nieuwenhuizen wrote: On Wed, Nov 14, 2018 at 5:26 PM Samuel Pitoiset wrote: +5% in ultra settings for both 4k and 1080p. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_device.c | 3 +++ 1 file changed, 3 insertions(+) diff --git

[Mesa-dev] [PATCH v4 5/5] intel/tools: make sure the binary file is properly read

2018-11-14 Thread asimiklit . work
From: Andrii Simiklit 1. tools/i965_disasm.c:58:4: warning: ignoring return value of ‘fread’, declared with attribute warn_unused_result fread(assembly, *end, 1, fp); v2: Fixed incorrect return value check. ( Eric Engestrom ) v3: Zero size file check placed before fread

Re: [Mesa-dev] [PATCH 2/2] radv: force-enable primitive binning for The Talos Principle

2018-11-14 Thread Bas Nieuwenhuizen
On Wed, Nov 14, 2018 at 5:26 PM Samuel Pitoiset wrote: > > +5% in ultra settings for both 4k and 1080p. > > Signed-off-by: Samuel Pitoiset > --- > src/amd/vulkan/radv_device.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/src/amd/vulkan/radv_device.c b/src/amd/vulkan/radv_device.c

[Mesa-dev] [PATCH 1/2] radv: add a debug option for disabling primitive binning

2018-11-14 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_debug.h | 1 + src/amd/vulkan/radv_device.c | 1 + 2 files changed, 2 insertions(+) diff --git a/src/amd/vulkan/radv_debug.h b/src/amd/vulkan/radv_debug.h index 9fe4c3b740..397d567961 100644 --- a/src/amd/vulkan/radv_debug.h +++

[Mesa-dev] [PATCH 2/2] radv: force-enable primitive binning for The Talos Principle

2018-11-14 Thread Samuel Pitoiset
+5% in ultra settings for both 4k and 1080p. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_device.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/amd/vulkan/radv_device.c b/src/amd/vulkan/radv_device.c index b2078975a8..5d212201ec 100644 --- a/src/amd/vulkan/radv_device.c

Re: [Mesa-dev] [PATCH] mesa/st: swap order of clear() and clear_with_quad()

2018-11-14 Thread Marek Olšák
On Wed, Nov 14, 2018, 10:36 AM Rob Clark On Wed, Nov 14, 2018 at 10:13 AM Marek Olšák wrote: > > > > > > > > On Wed, Nov 14, 2018, 7:54 AM Rob Clark >> > >> On Tue, Nov 13, 2018 at 9:54 PM Marek Olšák wrote: > >> > > >> > > >> > > >> > On Tue, Nov 13, 2018, 6:00 PM Rob Clark >> >> > >> >> On

Re: [Mesa-dev] [PATCH v3 5/5] intel/tools: avoid 'ignoring return value'

2018-11-14 Thread Eric Engestrom
On Wednesday, 2018-11-14 15:49:24 +0200, asimiklit.w...@gmail.com wrote: > From: Andrii Simiklit > > 1. tools/i965_disasm.c:58:4: warning: > ignoring return value of ‘fread’, > declared with attribute warn_unused_result > fread(assembly, *end, 1, fp); > > v2: Fixed incorrect

Re: [Mesa-dev] [PATCH] mesa/st: swap order of clear() and clear_with_quad()

2018-11-14 Thread Rob Clark
On Wed, Nov 14, 2018 at 10:13 AM Marek Olšák wrote: > > > > On Wed, Nov 14, 2018, 7:54 AM Rob Clark > >> On Tue, Nov 13, 2018 at 9:54 PM Marek Olšák wrote: >> > >> > >> > >> > On Tue, Nov 13, 2018, 6:00 PM Rob Clark > >> >> >> On Tue, Nov 13, 2018 at 5:25 PM Eric Anholt wrote: >> >> > >> >> >

Re: [Mesa-dev] [PATCH mesa] egl: add missing glvnd entrypoint for EGL_ANDROID_blob_cache

2018-11-14 Thread Kyle Brenneman
On 11/14/2018 05:55 AM, Eric Engestrom wrote: Fixes dEQP-EGL.functional.get_proc_address.extension.egl_android_blob_cache on builds with glvnd enabled. Fixes: 6f5b57093b3462a54e9c7 "egl: add support for EGL_ANDROID_blob_cache" Signed-off-by: Eric Engestrom Reviewed-by: Tapani Pälli ---

Re: [Mesa-dev] [PATCH] mesa/st: swap order of clear() and clear_with_quad()

2018-11-14 Thread Marek Olšák
On Wed, Nov 14, 2018, 7:54 AM Rob Clark On Tue, Nov 13, 2018 at 9:54 PM Marek Olšák wrote: > > > > > > > > On Tue, Nov 13, 2018, 6:00 PM Rob Clark >> > >> On Tue, Nov 13, 2018 at 5:25 PM Eric Anholt wrote: > >> > > >> > Rob Clark writes: > >> > > >> > > If we can't clear all the buffers with

[Mesa-dev] [PATCH v3 5/5] intel/tools: avoid 'ignoring return value'

2018-11-14 Thread asimiklit . work
From: Andrii Simiklit 1. tools/i965_disasm.c:58:4: warning: ignoring return value of ‘fread’, declared with attribute warn_unused_result fread(assembly, *end, 1, fp); v2: Fixed incorrect return value check. ( Eric Engestrom ) v3: Zero size file check moved before fread

Re: [Mesa-dev] [PATCH] radeonsi: fix video APIs on Raven2

2018-11-14 Thread Liu, Leo
Reviewed-by: Leo Liu On 11/13/18 6:51 PM, Marek Olšák wrote: > From: Marek Olšák > > This was missed when I added the new enum. > > Cc: 18.3 > --- > src/gallium/drivers/radeonsi/si_get.c | 9 ++--- > src/gallium/drivers/radeonsi/si_uvd.c | 3 ++- > 2 files changed, 8 insertions(+), 4

[Mesa-dev] [PATCH mesa] gbm: add new entrypoint to symbols check

2018-11-14 Thread Eric Engestrom
Fixes: 6328536ff28ca26f2ad4e "gbm: Introduce a helper function for printing GBM format names." Cc: Eric Anholt Signed-off-by: Eric Engestrom --- src/gbm/gbm-symbols-check | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gbm/gbm-symbols-check

Re: [Mesa-dev] [PATCH] mesa/st: swap order of clear() and clear_with_quad()

2018-11-14 Thread Rob Clark
On Wed, Nov 14, 2018 at 6:32 AM Erik Faye-Lund wrote: > > On Tue, 2018-11-13 at 19:07 -0500, Ilia Mirkin wrote: > > On Tue, Nov 13, 2018 at 6:50 PM Rob Clark > > wrote: > > > On Tue, Nov 13, 2018 at 6:19 PM Eric Anholt > > > wrote: > > > > Rob Clark writes: > > > > > > > > > On Tue, Nov 13,

[Mesa-dev] [PATCH mesa] egl: add missing glvnd entrypoint for EGL_ANDROID_blob_cache

2018-11-14 Thread Eric Engestrom
Fixes dEQP-EGL.functional.get_proc_address.extension.egl_android_blob_cache on builds with glvnd enabled. Fixes: 6f5b57093b3462a54e9c7 "egl: add support for EGL_ANDROID_blob_cache" Signed-off-by: Eric Engestrom Reviewed-by: Tapani Pälli --- src/egl/generate/eglFunctionList.py | 3 +++ 1 file

Re: [Mesa-dev] [PATCH] mesa/st: swap order of clear() and clear_with_quad()

2018-11-14 Thread Rob Clark
On Tue, Nov 13, 2018 at 9:54 PM Marek Olšák wrote: > > > > On Tue, Nov 13, 2018, 6:00 PM Rob Clark > >> On Tue, Nov 13, 2018 at 5:25 PM Eric Anholt wrote: >> > >> > Rob Clark writes: >> > >> > > If we can't clear all the buffers with pctx->clear() (say, for example, >> > > because of

Re: [Mesa-dev] [PATCH] radeonsi: fix video APIs on Raven2

2018-11-14 Thread Bas Nieuwenhuizen
Reviewed-by: Bas Nieuwenhuizen On Wed, Nov 14, 2018 at 12:51 AM Marek Olšák wrote: > > From: Marek Olšák > > This was missed when I added the new enum. > > Cc: 18.3 > --- > src/gallium/drivers/radeonsi/si_get.c | 9 ++--- > src/gallium/drivers/radeonsi/si_uvd.c | 3 ++- > 2 files changed,

Re: [Mesa-dev] [PATCH 1/2] nir: add new nir_remove_dead_barriers() pass

2018-11-14 Thread Bas Nieuwenhuizen
On Wed, Nov 14, 2018 at 1:03 PM Timothy Arceri wrote: > > On 14/11/18 10:22 pm, Bas Nieuwenhuizen wrote: > > On Wed, Nov 14, 2018 at 6:30 AM Timothy Arceri > > wrote: > >> > >> Link time opts can remove unused outputs leaving behind useless > >> barriers. This pass is intended to be called

[Mesa-dev] [Bug 108742] Battlefield 4 in Wine Freezes when joining games since ~mesa-18.2.3

2018-11-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108742 Bug ID: 108742 Summary: Battlefield 4 in Wine Freezes when joining games since ~mesa-18.2.3 Product: Mesa Version: unspecified Hardware: Other OS: All

Re: [Mesa-dev] [PATCH 1/2] nir: add new nir_remove_dead_barriers() pass

2018-11-14 Thread Timothy Arceri
On 14/11/18 10:22 pm, Bas Nieuwenhuizen wrote: On Wed, Nov 14, 2018 at 6:30 AM Timothy Arceri wrote: Link time opts can remove unused outputs leaving behind useless barriers. This pass is intended to be called after linking so I've added it to nir_linking_helpers.c This pass removes some

Re: [Mesa-dev] [PATCH v3] i965: Fix calculation of layers array length for isl_view

2018-11-14 Thread Danylo Piliaiev
Hi Ilia, Jason, All these cases are indeed could induce confusion, I'll try to explain all of them: Texture is not layered:     Layers: 1     Base Layer: %layer of image unit% + %layer of texture view% Layered 3D texture:     Layers: Entire level is bound, texture view does not affect layers

Re: [Mesa-dev] [PATCH 0/8] intel: Move shared/SSBO access lowering to NIR

2018-11-14 Thread Samuel Iglesias Gonsálvez
Thanks a lot for this work. Patches 1-7 are, Reviewed-by: Samuel Iglesias Gonsálvez I will review patch 8 later, probably tomorrow. Sam On 14/11/2018 00:23, Jason Ekstrand wrote: > In order to properly do all the different kinds of SSBO and SLM writes that > we have in GL and Vulkan, we

Re: [Mesa-dev] [PATCH] mesa/st: swap order of clear() and clear_with_quad()

2018-11-14 Thread Erik Faye-Lund
On Tue, 2018-11-13 at 21:53 -0500, Marek Olšák wrote: > > > On Tue, Nov 13, 2018, 6:00 PM Rob Clark > On Tue, Nov 13, 2018 at 5:25 PM Eric Anholt > > wrote: > > > > > > Rob Clark writes: > > > > > > > If we can't clear all the buffers with pctx->clear() (say, for > > example, > > > > because

Re: [Mesa-dev] [PATCH] egl/dri: fix error value with unknown drm format

2018-11-14 Thread Lionel Landwerlin
On 14/11/2018 11:04, Eric Engestrom wrote: On Tuesday, 2018-11-13 14:10:45 +, Lionel Landwerlin wrote: According to the EGL_EXT_image_dma_buf_import spec, creating an EGL image with a DRM format not supported should yield the BAD_MATCH error : " * If is EGL_LINUX_DMA_BUF_EXT, and

Re: [Mesa-dev] [PATCH] mesa/st: swap order of clear() and clear_with_quad()

2018-11-14 Thread Erik Faye-Lund
On Tue, 2018-11-13 at 19:07 -0500, Ilia Mirkin wrote: > On Tue, Nov 13, 2018 at 6:50 PM Rob Clark > wrote: > > On Tue, Nov 13, 2018 at 6:19 PM Eric Anholt > > wrote: > > > Rob Clark writes: > > > > > > > On Tue, Nov 13, 2018 at 5:25 PM Eric Anholt > > > > wrote: > > > > > Rob Clark writes: >

Re: [Mesa-dev] [PATCH 1/2] nir: add new nir_remove_dead_barriers() pass

2018-11-14 Thread Bas Nieuwenhuizen
On Wed, Nov 14, 2018 at 6:30 AM Timothy Arceri wrote: > > Link time opts can remove unused outputs leaving behind useless > barriers. This pass is intended to be called after linking so > I've added it to nir_linking_helpers.c > > This pass removes some barriers from Witcher 3 (DXVK) Vulkan >

Re: [Mesa-dev] [PATCH] egl/dri: fix error value with unknown drm format

2018-11-14 Thread Eric Engestrom
On Tuesday, 2018-11-13 14:10:45 +, Lionel Landwerlin wrote: > According to the EGL_EXT_image_dma_buf_import spec, creating an EGL > image with a DRM format not supported should yield the BAD_MATCH > error : > > " >* If is EGL_LINUX_DMA_BUF_EXT, and the > EGL_LINUX_DRM_FOURCC_EXT >

[Mesa-dev] [Bug 105328] Can't include gl and gles headers simultaneously on non-64 bit architectures

2018-11-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105328 Eric Engestrom changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Mesa-dev] [Bug 108530] [Tracker] Mesa 18.3 Release Tracker

2018-11-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108530 Bug 108530 depends on bug 105328, which changed state. Bug 105328 Summary: Can't include gl and gles headers simultaneously on non-64 bit architectures https://bugs.freedesktop.org/show_bug.cgi?id=105328 What|Removed

Re: [Mesa-dev] [PATCH 16/28] Replace IROUND_POS with _mesa_roundevenf

2018-11-14 Thread Erik Faye-Lund
On Tue, 2018-11-13 at 22:13 +, Roland Scheidegger wrote: > Am 13.11.18 um 18:00 schrieb Dylan Baker: > > Quoting Erik Faye-Lund (2018-11-13 01:34:53) > > > On Mon, 2018-11-12 at 09:22 -0800, Dylan Baker wrote: > > > > Quoting Erik Faye-Lund (2018-11-12 04:51:47) > > > > > On Fri, 2018-11-09 at

Re: [Mesa-dev] [PATCH 16/28] Replace IROUND_POS with _mesa_roundevenf

2018-11-14 Thread Erik Faye-Lund
On Tue, 2018-11-13 at 09:00 -0800, Dylan Baker wrote: > Quoting Erik Faye-Lund (2018-11-13 01:34:53) > > On Mon, 2018-11-12 at 09:22 -0800, Dylan Baker wrote: > > > Quoting Erik Faye-Lund (2018-11-12 04:51:47) > > > > On Fri, 2018-11-09 at 10:40 -0800, Dylan Baker wrote: > > > > > Which has the

Re: [Mesa-dev] [PATCH v2 3/5] i965: avoid 'unused variable'

2018-11-14 Thread andrey simiklit
On Tue, Nov 13, 2018 at 6:35 PM Eric Engestrom wrote: > On Tuesday, 2018-11-13 14:19:30 +0200, asimiklit.w...@gmail.com wrote: > > From: Andrii Simiklit > > > > 1. brw_pipe_control.c:311:34: warning: > > unused variable ‘devinfo’ > > 2. brw_program_binary.c:209:19: warning: > > unused

Re: [Mesa-dev] [PATCH 11/22] nir: simplify get_io_offset() parameters

2018-11-14 Thread Erik Faye-Lund
On Tue, 2018-11-13 at 16:48 +0100, Karol Herbst wrote: > From: Rob Clark > > For pointers we'll need to add another caller, plus in addition a > type_align() fxn ptr. So just simplify things and pass the > lower_io_state to get_io_offset(). > > Signed-off-by: Karol Herbst Reviewed-by: Erik