[Mesa-dev] [PATCH v2] st/glsl_to_nir: remove dead local variables

2019-01-30 Thread Timothy Arceri
Without this we do not end up with a deterministic NIR because temporary register variables are added in random order. NIR must be deterministic because we use it to produce a sha for the radeonsi backends disk cache. This fixes the shader cache for a bunch of shaders. Another positive is that

[Mesa-dev] [PATCH] nir: move nir_block_cf_tree_{next, prev}() NULL checking to caller

2019-01-30 Thread Timothy Arceri
Rather than doing a NULL check on every block that is passed in just do it for nir_foreach_block_{reverse}_safe() where the potential problem is. This is a micro optimisation after seeing nir_block_cf_tree_next() when profiling shader compile-times. --- src/compiler/nir/nir.c | 13 -

Re: [Mesa-dev] [PATCH v2 05/32] intel/isl: Use a 4D physical total extent for size calculations

2019-01-30 Thread Nanley Chery
On Fri, Oct 12, 2018 at 01:46:35PM -0500, Jason Ekstrand wrote: > With Yf and Ys tiling, everything is actually four dimensional because > we can have multiple depth or multisampled array slices in the same > tile. This commit just enhances the calculations so they can handle it. > >

[Mesa-dev] [PATCH] radeonsi/nir: remove dead local variables

2019-01-30 Thread Timothy Arceri
Without this we do not end up with a deterministic NIR. NIR must be deterministic here because we use it to produce a sha for the radeonsi backends disk cache. This fixes the shader cache for a bunch of shaders. --- src/gallium/drivers/radeonsi/si_shader_nir.c | 3 +++ 1 file changed, 3

Re: [Mesa-dev] [PATCH 13/13] wayland: Add buffer handling and visuals for fp16 formats

2019-01-30 Thread Jason Ekstrand
On January 30, 2019 04:30:17 Daniel Stone wrote: Hi Kevin, On Mon, 28 Jan 2019 at 18:43, Kevin Strasser wrote: Set loader caps indicating that wayland can handle both rgba ordering and fp16 formats. NOTE: This requries libwayland to provide definitions for WL_SHM_FORMAT_XBGR16161616F and

[Mesa-dev] [ANNOUNCE] mesa 19.0.0-rc1

2019-01-30 Thread Dylan Baker
Hello list, This email announces the mesa 19.0 release candidate 1. I'll keep this email fairly brief since I'm already running a little late on getting this done :) I've just had to resolve quite a few autotools issues to get the dist built. Notable in the 19.0-rc1 branch is SWR is set to

Re: [Mesa-dev] [PATCH 03/13] dri: Add config attributes for color channel shift

2019-01-30 Thread Strasser, Kevin
Emil Velikov wrote: > On Mon, 28 Jan 2019 at 18:42, Kevin Strasser wrote: > > diff --git a/src/mesa/drivers/dri/common/utils.c > > b/src/mesa/drivers/dri/common/utils.c > > index 5a66bcf..1fdc160 100644 > > --- a/src/mesa/drivers/dri/common/utils.c > > +++ b/src/mesa/drivers/dri/common/utils.c >

Re: [Mesa-dev] [PATCH 02/13] drm-uapi: Add fp16 formats to drm_fourcc.h

2019-01-30 Thread Strasser, Kevin
Emil Velikov wrote: > Changes to drm-uapi should land in the kernel drm-next before being merged > here. > Otherwise we may end up with mesa and kernel using different > definitions, resulting in broken code :-( Sure, but we need userspace to be ready before landing new uapi in the kernel. Maybe

Re: [Mesa-dev] [PATCH 01/13] egl/dri: Avoid out of bounds array access

2019-01-30 Thread Strasser, Kevin
Emile Velikov wrote: > JFYI: > Checking the offending commit (like below) allows us to better track > where the patch is need plus it gives you a few automatic reviewers > ;-) > > Cc: Chad Versace > Cc: Eric Engestrom > Fixes: cd717cbe1a6 ("egl/dri2: Declare loop vars inside the loop") > >

Re: [Mesa-dev] [PATCH 13/13] wayland: Add buffer handling and visuals for fp16 formats

2019-01-30 Thread Strasser, Kevin
Daniel Stone wrote: > On Mon, 28 Jan 2019 at 18:43, Kevin Strasser wrote: > > Set loader caps indicating that wayland can handle both rgba ordering and > > fp16 formats. > > > > NOTE: This requries libwayland to provide definitions for > > WL_SHM_FORMAT_XBGR16161616F and

Re: [Mesa-dev] [PATCH v10 09/20] clover: Track flags per module section

2019-01-30 Thread Pierre Moreau
On 2019-01-20 — 16:59, Pierre Moreau wrote: [snip] > > Is this patch being used at all in this series? > > Not in this one, but it will be in the next merge request which adds support > for SPIR-V as a second main IR in clover alongside LLVM IR. > I’ll drop this patch from this series and add it

[Mesa-dev] [Bug 109129] format_types.h:1220: undefined reference to `_mm256_cvtps_ph'

2019-01-30 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109129 Dylan Baker changed: What|Removed |Added Resolution|--- |FIXED Status|NEW

[Mesa-dev] [Bug 109023] error: inlining failed in call to always_inline ‘__m512 _mm512_and_ps(__m512, __m512)’: target specific option mismatch

2019-01-30 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109023 Dylan Baker changed: What|Removed |Added Resolution|--- |FIXED Status|NEW

[Mesa-dev] [Bug 109323] [TRACKER] mesa: Remove autotools

2019-01-30 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109323 Bug 109323 depends on bug 109023, which changed state. Bug 109023 Summary: error: inlining failed in call to always_inline ‘__m512 _mm512_and_ps(__m512, __m512)’: target specific option mismatch

[Mesa-dev] [Bug 109323] [TRACKER] mesa: Remove autotools

2019-01-30 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109323 Bug 109323 depends on bug 109129, which changed state. Bug 109129 Summary: format_types.h:1220: undefined reference to `_mm256_cvtps_ph' https://bugs.freedesktop.org/show_bug.cgi?id=109129 What|Removed |Added

[Mesa-dev] [PATCH] gallium: allow more PIPE_RESOURCE_ driver flags

2019-01-30 Thread Marek Olšák
From: Marek Olšák radeonsi has 8 and will probably have 9 soon. --- src/gallium/include/pipe/p_defines.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/include/pipe/p_defines.h b/src/gallium/include/pipe/p_defines.h index 867d0cb5d74..1f2a3469cc9 100644 ---

Re: [Mesa-dev] [Mesa-announce] [ANNOUNCE] Mesa 18.3.3 release candidate

2019-01-30 Thread Matt Turner
On Wed, Jan 30, 2019 at 10:37 AM Emil Velikov wrote: > > Hello list, > > The candidate for the Mesa 18.3.3 is now available. Currently we have: > - 45 queued > - 4 nominated (outstanding) > - and 3 rejected patches Might be good to cherry-pick the two patches mentioned in

[Mesa-dev] [ANNOUNCE] Mesa 18.3.3 release candidate

2019-01-30 Thread Emil Velikov
Hello list, The candidate for the Mesa 18.3.3 is now available. Currently we have: - 45 queued - 4 nominated (outstanding) - and 3 rejected patches In the current release candidate we have fix for a memory leak in the etnaviv driver, better NEON assembly code in vc4 and couple of stability

[Mesa-dev] [Bug 109393] [vega10] hang with Mario Party 9 through Dolphin

2019-01-30 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109393 --- Comment #9 from Jaap Buurman --- Created attachment 143257 --> https://bugs.freedesktop.org/attachment.cgi?id=143257=edit Hang.report file, no crash. Contains an error though. I have just closed the emulator, since it still hadn't

[Mesa-dev] [Bug 109393] [vega10] hang with Mario Party 9 through Dolphin

2019-01-30 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109393 --- Comment #8 from Jaap Buurman --- I've set the environment variables and started Dolphin as instructed. However, I can no longer get it to crash. The FPS is around 4-6 FPS, instead of the regular 60 FPS, probably because a trace is being

Re: [Mesa-dev] [PATCH] meson: drop the xcb-xrandr version requirement

2019-01-30 Thread Erik Faye-Lund
On Wed, 2019-01-30 at 12:32 -0500, Marek Olšák wrote: > ping > Probably worth including Keith, who added this line... But yeah, I tend to think that this makes sense. The autotools-build doesn't seem to tie this to a specific version, and seems to have been used without problems for almost a

Re: [Mesa-dev] [PATCH] meson: drop the xcb-xrandr version requirement

2019-01-30 Thread Marek Olšák
ping On Fri, Jan 25, 2019 at 5:48 PM Marek Olšák wrote: > From: Marek Olšák > > autotools doesn't have any requirement. This fixes meson on Ubuntu 16.04. > --- > meson.build | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/meson.build b/meson.build > index

[Mesa-dev] [MR] mesa/i965: ARB_gl_spirv and ARB_spirv_extensions implementation, plus 4.6

2019-01-30 Thread apinheiro
https://gitlab.freedesktop.org/mesa/mesa/merge_requests/178 TL; DR; This series implements all the mesa bits needed to enable ARB_gl_spirv and ARB_spirv_extensions on the i965 driver, and with that, expose OpenGL 4.6 on that driver. Detailed explanation: we reached a point where we consider

Re: [Mesa-dev] [PATCH 03/13] dri: Add config attributes for color channel shift

2019-01-30 Thread Emil Velikov
On Mon, 28 Jan 2019 at 18:42, Kevin Strasser wrote: > > The existing mask attributes can only support up to 32 bpp. Introduce > per-channel SHIFT attributes that indicate how many bits, from lsb towards > msb, the bit field is offset. A shift of -1 will indicate that there is no > bit field set

[Mesa-dev] [Bug 109393] [vega10] hang with Mario Party 9 through Dolphin

2019-01-30 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109393 --- Comment #7 from Samuel Pitoiset --- Unlikely. What you can do is to capture a hang report as follows: export RADV_TRACE_FILE=$HOME/hang.trace export RADV_DEBUG=syncshaders,vmfaults,allbos dolphin-emu &> hang.report And attach the files

[Mesa-dev] [Bug 109393] [vega10] hang with Mario Party 9 through Dolphin

2019-01-30 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109393 --- Comment #6 from Jaap Buurman --- Is there anything I can do, test or research to find out why this is happening? Could this be a Vega 64 bug that doesn't affect Vega 56? -- You are receiving this mail because: You are the assignee for the

[Mesa-dev] [Bug 109393] [vega10] hang with Mario Party 9 through Dolphin

2019-01-30 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109393 --- Comment #5 from Samuel Pitoiset --- Yes, I tried Mario Party 9 on my vega 56. -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the bug.___

[Mesa-dev] [Bug 109393] [vega10] hang with Mario Party 9 through Dolphin

2019-01-30 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109393 --- Comment #4 from Jaap Buurman --- I cannot edit my previous post: Did you test with Mario party as well? I am in Europe, and am therefor using a PAL version. Not sure if that matters. -- You are receiving this mail because: You are the

[Mesa-dev] [Bug 109393] [vega10] hang with Mario Party 9 through Dolphin

2019-01-30 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109393 --- Comment #3 from Jaap Buurman --- I am using a stock install of Dolphin. The only thing I changed was switching from the OpenGL backend to the Vulkan backend. Are you using Vega 64 or Vega 56? -- You are receiving this mail because: You

Re: [Mesa-dev] [PATCH 02/13] drm-uapi: Add fp16 formats to drm_fourcc.h

2019-01-30 Thread Emil Velikov
On Mon, 28 Jan 2019 at 18:42, Kevin Strasser wrote: > > Add 64 bpp 16:16:16:16 half float pixel formats. Each 16 bit component is > formatted in IEEE-754 half-precision float (binary16) 1:5:10 > MSb-sign:exponent:fraction form. > > Signed-off-by: Kevin Strasser > --- >

Re: [Mesa-dev] [PATCH 01/13] egl/dri: Avoid out of bounds array access

2019-01-30 Thread Emil Velikov
On Mon, 28 Jan 2019 at 18:42, Kevin Strasser wrote: > > indexConfigAttrib iterates over every index in the dri driver, possibly > exceeding __DRI_ATTRIB_MAX. In other words, if the dri driver has newer > attributes libEGL will end up reading from uninitialized memory through >

[Mesa-dev] [Bug 104553] mat4: m[i][j] incorrect result with row_major UBO & SSBO

2019-01-30 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=104553 Alejandro Piñeiro (freenode IRC: apinheiro) changed: What|Removed |Added Status|NEW |NEEDINFO

Re: [Mesa-dev] [PATCH v2 14/29] nir: fix constant expressions for rounding mode conversions

2019-01-30 Thread Connor Abbott
I think maybe it would be better if we put all this in nir_opcodes.py instead. Again, I'd like to make sure that for every opcode, what it does is right next to the definition instead of buried in nir_constant_expressions.py. Also, I don't see anywhere in the series where you handle different

Re: [Mesa-dev] [PATCH v2 04/29] nir: add support for flushing to zero denorm constants

2019-01-30 Thread Connor Abbott
On Tue, Dec 18, 2018 at 11:35 AM Samuel Iglesias Gonsálvez < sigles...@igalia.com> wrote: > v2: > - Refactor conditions and shared function (Connor) > - Move code to nir_eval_const_opcode() (Connor) > - Don't flush to zero on fquantize2f16 > From Vulkan spec, VK_KHR_shader_float_controls

Re: [Mesa-dev] [PATCH 13/13] wayland: Add buffer handling and visuals for fp16 formats

2019-01-30 Thread Daniel Stone
Hi Kevin, On Mon, 28 Jan 2019 at 18:43, Kevin Strasser wrote: > Set loader caps indicating that wayland can handle both rgba ordering and > fp16 formats. > > NOTE: This requries libwayland to provide definitions for > WL_SHM_FORMAT_XBGR16161616F and WL_SHM_FORMAT_ABGR16161616F To be honest, we

Re: [Mesa-dev] Thoughts after hitting 100 merge requests?

2019-01-30 Thread Juan A. Suarez Romero
On Fri, 2019-01-25 at 13:26 -0800, Eric Anholt wrote: > Rob Clark writes: > > > I guess as discovered with > > https://gitlab.freedesktop.org/mesa/mesa/merge_requests/47 maybe we > > should wait to turn on merging MRs via web until we have at least some > > basic build-test CI wired up.. the

[Mesa-dev] [Bug 108720] Possible GPU hangs with Cemu Emulator

2019-01-30 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108720 Samuel Pitoiset changed: What|Removed |Added Status|NEW |NEEDINFO

[Mesa-dev] [Bug 109242] [RADV] The Witcher 3 system freeze

2019-01-30 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109242 --- Comment #32 from Samuel Pitoiset --- Should be fixed with https://cgit.freedesktop.org/mesa/mesa/commit/?id=568e7a2998e39263c41ec70ec67bcc5601477781 Can we close the issue? -- You are receiving this mail because: You are the QA Contact

[Mesa-dev] [Bug 109393] [vega10] hang with Mario Party 9 through Dolphin

2019-01-30 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109393 --- Comment #2 from Samuel Pitoiset --- Just tried to reproduce with these settings OpenGL renderer string: Radeon RX Vega (VEGA10, DRM 3.27.0, 4.20.5-arch1-1-ARCH, LLVM 7.0.1) OpenGL core profile version string: 4.5 (Core Profile) Mesa 18.3.2

[Mesa-dev] [Bug 109446] Shadow of the Tomb Raider Trial freezes the system at startup

2019-01-30 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109446 Samuel Pitoiset changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|INVALID

Re: [Mesa-dev] Thoughts after hitting 100 merge requests?

2019-01-30 Thread Pekka Paalanen
On Sat, 12 Jan 2019 12:10:42 +0100 apinheiro wrote: > > On 11/1/19 18:05, Jason Ekstrand wrote: > >  5. There's no way with gitlab for Reviewed-by tags to get > > automatically applied as part of the merging process.  This makes > > merging a bit more manual than it needs to be but is really no