[Mesa-dev] [PATCH] util: Don't block SIGSYS for new threads

2019-02-22 Thread Drew Davenport
SIGSYS is needed for programs using seccomp for sandboxing. --- src/util/u_thread.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/util/u_thread.h b/src/util/u_thread.h index 7538d7d634b2..a46c18d3db20 100644 --- a/src/util/u_thread.h +++ b/src/util/u_thread.h @@ -44,7

[Mesa-dev] [AppVeyor] mesa master #10151 completed

2019-02-22 Thread AppVeyor
Build mesa 10151 completed Commit 4c160b6bd8 by Caio Marcelo de Oliveira Filho on 2/23/2019 6:38 AM: nir: fix MSVC build\n\nZero initialize struct with {0} instead of {}. Configure your notification preferences

[Mesa-dev] [AppVeyor] mesa master #10150 failed

2019-02-22 Thread AppVeyor
Build mesa 10150 failed Commit eb13211997 by Caio Marcelo de Oliveira Filho on 1/14/2019 9:52 PM: nir/copy_prop_vars: add tests for load/store elements of vectors\n\nTest using array deref on vectors in loads and stores. These are\nmarked DISABLED_ as this

[Mesa-dev] [PATCH] nir/split_vars: Don't compact vectors unnecissarily

2019-02-22 Thread Jason Ekstrand
--- src/compiler/nir/nir_split_vars.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/compiler/nir/nir_split_vars.c b/src/compiler/nir/nir_split_vars.c index 244ffd6dcf0..96b6042e6d9 100644 --- a/src/compiler/nir/nir_split_vars.c +++ b/src/compiler/nir/nir_split_vars.c @@ -1423,6

[Mesa-dev] [Bug 109752] meson: more ensure that xmlpool_options.h is generated for targets that need it

2019-02-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109752 Bug ID: 109752 Summary: meson: more ensure that xmlpool_options.h is generated for targets that need it Product: Mesa Version: unspecified Hardware: Other

[Mesa-dev] [PATCH] nir/algebraic: Replace a-fract(a) with floor(a)

2019-02-22 Thread Ian Romanick
From: Ian Romanick I noticed this while looking at a shader that was affected by Tim's "more loop unrolling" series. All Gen6+ platforms had similar results. (Skylake shown) total instructions in shared programs: 15437001 -> 15435259 (-0.01%) instructions in affected programs: 213651 -> 211909

Re: [Mesa-dev] [PATCH] nir/builder: Don't emit no-op swizzles

2019-02-22 Thread Bas Nieuwenhuizen
Reviewed-by: Bas Nieuwenhuizen On Sat, Feb 23, 2019 at 1:14 AM Ian Romanick wrote: > > Reviewed-by: Ian Romanick > > On 2/22/19 4:03 PM, Jason Ekstrand wrote: > > The nir_swizzle helper is used some on it's own but it's also called by > > nir_channel and nir_channels which are used everywhere.

[Mesa-dev] [Bug 109532] ir_variable has maximum access out of bounds -- but it's not out of bounds

2019-02-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109532 --- Comment #38 from Ilia Mirkin --- (In reply to asimiklit from comment #36) > Ilia could you please share your thoughts about this solution? > Do you agree with Ian suggestion as to disallow the elimination from the > beginning of the array?

[Mesa-dev] [Bug 109532] ir_variable has maximum access out of bounds -- but it's not out of bounds

2019-02-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109532 Rob Clark changed: What|Removed |Added CC||robcl...@freedesktop.org --- Comment #37

Re: [Mesa-dev] [PATCH] radeonsi: fix query buffer allocation

2019-02-22 Thread Timothy Arceri
On 23/2/19 11:31 am, Marek Olšák wrote: Nicolai also has a change in si_query_buffer_reset. Is there a reason the change is not here? duh ... no reason other than I forgot that bit. Thanks, Marek On Thu, Feb 21, 2019 at 10:09 PM Timothy Arceri > wrote:

Re: [Mesa-dev] [PATCH] radeonsi: fix query buffer allocation

2019-02-22 Thread Marek Olšák
Nicolai also has a change in si_query_buffer_reset. Is there a reason the change is not here? Thanks, Marek On Thu, Feb 21, 2019 at 10:09 PM Timothy Arceri wrote: > Fix the logic for buffer full check on alloc. > > This patch just takes the fix Nicolai attached to the bug report > and updates

Re: [Mesa-dev] [PATCH] nir/builder: Don't emit no-op swizzles

2019-02-22 Thread Ian Romanick
Reviewed-by: Ian Romanick On 2/22/19 4:03 PM, Jason Ekstrand wrote: > The nir_swizzle helper is used some on it's own but it's also called by > nir_channel and nir_channels which are used everywhere. It's pretty > quick to check while we're walking the swizzle anyway whether or not > it's an

[Mesa-dev] [PATCH] nir/builder: Don't emit no-op swizzles

2019-02-22 Thread Jason Ekstrand
The nir_swizzle helper is used some on it's own but it's also called by nir_channel and nir_channels which are used everywhere. It's pretty quick to check while we're walking the swizzle anyway whether or not it's an identity swizzle. If it is, we now don't bother emitting the instruction.

[Mesa-dev] [PATCH 3/4] panfrost/nondrm: Make COHERENT_LOCAL explicit

2019-02-22 Thread Alyssa Rosenzweig
This flag corresponds to what was MEM_COHERENT_LOCAL in the vendor driver, which seems to influence the cache policy, necessary for the varying temporary storage but nothing else. Signed-off-by: Alyssa Rosenzweig --- src/gallium/drivers/panfrost/pan_context.c | 2 +-

[Mesa-dev] [PATCH 4/4] panfrost/nondrm: Split out dump_counters

2019-02-22 Thread Alyssa Rosenzweig
Previously, this function was implied a part of the job submit. Signed-off-by: Alyssa Rosenzweig --- src/gallium/drivers/panfrost/pan_context.c | 2 ++ src/gallium/drivers/panfrost/pan_screen.h | 1 + 2 files changed, 3 insertions(+) diff --git a/src/gallium/drivers/panfrost/pan_context.c

[Mesa-dev] [PATCH 2/4] panfrost/nondrm: Flag CPU-invisible regions

2019-02-22 Thread Alyssa Rosenzweig
Potentially, the kernel could optimize these allocations, or perhaps we can save on mapping costs. Signed-off-by: Alyssa Rosenzweig --- src/gallium/drivers/panfrost/pan_context.c | 6 +++--- src/gallium/drivers/panfrost/pan_screen.h | 1 + 2 files changed, 4 insertions(+), 3 deletions(-) diff

[Mesa-dev] [PATCH 0/4] panfrost: Improve non-DRM integration

2019-02-22 Thread Alyssa Rosenzweig
This contains a potpourrie of patches to improve the non-DRM glue layer. Ideally, we'll be able to remove this glue entirely in the near future, but for now, this at least removes some of the magic and should fix cross-compilation with the glue. Alyssa Rosenzweig (4): panfrost/meson: Remove

[Mesa-dev] [PATCH 1/4] panfrost/meson: Remove subdir for nondrm

2019-02-22 Thread Alyssa Rosenzweig
This change fixes cross builds with the (temporary) non-DRM overlay. Signed-off-by: Alyssa Rosenzweig --- src/gallium/drivers/panfrost/meson.build | 1 - 1 file changed, 1 deletion(-) diff --git a/src/gallium/drivers/panfrost/meson.build b/src/gallium/drivers/panfrost/meson.build index

Re: [Mesa-dev] [PATCH v3] nir: allow nir_lower_phis_to_scalar() on more src types

2019-02-22 Thread Jason Ekstrand
On Fri, Feb 22, 2019 at 5:21 PM Timothy Arceri wrote: > Rather than only lowering if all srcs are scalarizable we instead > check that at least one src is scalarizable. > > We remove undef type from the is_phi_src_scalarizable() as using > this as a check just cause regressions when it is the

[Mesa-dev] [Bug 109741] swr doesn't build on i386 - simdlib.hpp:594:37: error: static assertion failed: This path only meant for 64-bit code

2019-02-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109741 Alok Hota changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Mesa-dev] [Bug 109741] swr doesn't build on i386 - simdlib.hpp:594:37: error: static assertion failed: This path only meant for 64-bit code

2019-02-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109741 Alok Hota changed: What|Removed |Added Assignee|mesa-dev@lists.freedesktop. |alok.h...@intel.com |org

[Mesa-dev] [PATCH v3] nir: allow nir_lower_phis_to_scalar() on more src types

2019-02-22 Thread Timothy Arceri
Rather than only lowering if all srcs are scalarizable we instead check that at least one src is scalarizable. We remove undef type from the is_phi_src_scalarizable() as using this as a check just cause regressions when it is the only scalarizable src. total instructions in shared programs:

Re: [Mesa-dev] [PATCH] nir: add nir_instr_type_tex support to nir_lower_phis_to_scalar()

2019-02-22 Thread Rob Clark
On Fri, Feb 22, 2019 at 3:47 PM Timothy Arceri wrote: > > > > On 23/2/19 6:31 am, Rob Clark wrote: > > On Fri, Feb 22, 2019 at 12:39 PM Jason Ekstrand > > wrote: > >> > >> On Fri, Feb 22, 2019 at 9:51 AM Eric Anholt wrote: > >>> > >>> Timothy Arceri writes: > >>> > shader-db results i965

Re: [Mesa-dev] [PATCH] nir: add nir_instr_type_tex support to nir_lower_phis_to_scalar()

2019-02-22 Thread Jason Ekstrand
On Fri, Feb 22, 2019 at 4:05 PM Timothy Arceri wrote: > > > On 23/2/19 8:54 am, Jason Ekstrand wrote: > > On Fri, Feb 22, 2019 at 2:47 PM Timothy Arceri > > wrote: > > > > > > > > On 23/2/19 6:31 am, Rob Clark wrote: > > > On Fri, Feb 22, 2019 at 12:39 PM

Re: [Mesa-dev] [PATCH] nir: add nir_instr_type_tex support to nir_lower_phis_to_scalar()

2019-02-22 Thread Timothy Arceri
On 23/2/19 8:54 am, Jason Ekstrand wrote: On Fri, Feb 22, 2019 at 2:47 PM Timothy Arceri > wrote: On 23/2/19 6:31 am, Rob Clark wrote: > On Fri, Feb 22, 2019 at 12:39 PM Jason Ekstrand mailto:ja...@jlekstrand.net>> wrote: >> >> On Fri,

[Mesa-dev] [PATCH v2] nir: add nir_instr_type_tex support to nir_lower_phis_to_scalar()

2019-02-22 Thread Timothy Arceri
total instructions in shared programs: 13219105 -> 13024613 (-1.47%) instructions in affected programs: 1155045 -> 960553 (-16.84%) helped: 581 HURT: 100 total cycles in shared programs: 333968972 -> 324813762 (-2.74%) cycles in affected programs: 129831032 -> 120675822 (-7.05%) helped: 571 HURT:

Re: [Mesa-dev] [PATCH] nir: add nir_instr_type_tex support to nir_lower_phis_to_scalar()

2019-02-22 Thread Jason Ekstrand
On Fri, Feb 22, 2019 at 2:47 PM Timothy Arceri wrote: > > > On 23/2/19 6:31 am, Rob Clark wrote: > > On Fri, Feb 22, 2019 at 12:39 PM Jason Ekstrand > wrote: > >> > >> On Fri, Feb 22, 2019 at 9:51 AM Eric Anholt wrote: > >>> > >>> Timothy Arceri writes: > >>> > shader-db results i965

Re: [Mesa-dev] [PATCH v5] etnaviv: fix resource usage tracking across different pipe_context's

2019-02-22 Thread Marek Vasut
On 2/22/19 10:30 AM, Boris Brezillon wrote: > On Thu, 21 Feb 2019 23:29:53 +0100 > Boris Brezillon wrote: > >> Christian, Marek, >> >> On Wed, 30 Jan 2019 05:28:14 +0100 >> Marek Vasut wrote: >> >>> From: Christian Gmeiner >>> >>> A pipe_resource can be shared by all the pipe_context's hanging

[Mesa-dev] [PATCH v4] i965: fixed clamping in set_scissor_bits when the y is flipped

2019-02-22 Thread Eleni Maria Stea
Calculating the scissor rectangle fields with the y flipped (0 on top) can generate negative values that will cause assertion failure later on as the scissor fields are all unsigned. We must clamp the bbox values again to make sure they don't exceed the fb_height. Also fixed a calculation error.

Re: [Mesa-dev] [PATCH] nir: add nir_instr_type_tex support to nir_lower_phis_to_scalar()

2019-02-22 Thread Timothy Arceri
On 23/2/19 6:31 am, Rob Clark wrote: On Fri, Feb 22, 2019 at 12:39 PM Jason Ekstrand wrote: On Fri, Feb 22, 2019 at 9:51 AM Eric Anholt wrote: Timothy Arceri writes: shader-db results i965 (SKL): total instructions in shared programs: 13219105 -> 13024761 (-1.47%) instructions in

Re: [Mesa-dev] [PATCH] nir: add nir_instr_type_tex support to nir_lower_phis_to_scalar()

2019-02-22 Thread Rob Clark
On Fri, Feb 22, 2019 at 12:39 PM Jason Ekstrand wrote: > > On Fri, Feb 22, 2019 at 9:51 AM Eric Anholt wrote: >> >> Timothy Arceri writes: >> >> > shader-db results i965 (SKL): >> > >> > total instructions in shared programs: 13219105 -> 13024761 (-1.47%) >> > instructions in affected programs:

[Mesa-dev] [Bug 109748] follow not working

2019-02-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109748 Mayank changed: What|Removed |Added Assignee|mesa-dev@lists.freedesktop. |indive...@gmail.com |org

[Mesa-dev] [Bug 109748] follow not working

2019-02-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109748 Bug ID: 109748 Summary: follow not working Product: Mesa Version: 7.4 Hardware: Other OS: Windows (All) Status: NEW Severity: major Priority:

[Mesa-dev] [Bug 109747] Add framerate to vulkan-overlay-layer

2019-02-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109747 --- Comment #1 from Shmerl --- Also, frametimes meter seems to be always on without any option to control it. May be it should be behind an option as well. -- You are receiving this mail because: You are the assignee for the

[Mesa-dev] [Bug 109747] Add framerate to vulkan-overlay-layer

2019-02-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109747 Bug ID: 109747 Summary: Add framerate to vulkan-overlay-layer Product: Mesa Version: git Hardware: x86-64 (AMD64) OS: Linux (All) Status: NEW Severity:

Re: [Mesa-dev] [PATCH 1/3] glsl: XFB TSC per-vertex output varyings match as not declared as arrays

2019-02-22 Thread Chema Casanova
V2 of this series that address the fix for KHR-GL*.tessellation_shader.single.xfb_captures_data_from_correct_stage regressions is available at Gitlab MR!300 https://gitlab.freedesktop.org/mesa/mesa/merge_requests/300 On 21/11/18 19:45, Jose Maria Casanova Crespo wrote: > Recent change on OpenGL

Re: [Mesa-dev] [PATCH] nir: add nir_instr_type_tex support to nir_lower_phis_to_scalar()

2019-02-22 Thread Jason Ekstrand
On Fri, Feb 22, 2019 at 9:51 AM Eric Anholt wrote: > Timothy Arceri writes: > > > shader-db results i965 (SKL): > > > > total instructions in shared programs: 13219105 -> 13024761 (-1.47%) > > instructions in affected programs: 1169457 -> 975113 (-16.62%) > > helped: 599 > > HURT: 154 > > > >

Re: [Mesa-dev] [PATCH v3 2/2] anv: advertise 8 subpixel precision bits

2019-02-22 Thread Juan A. Suarez Romero
On Fri, 2019-02-22 at 10:04 -0600, Jason Ekstrand wrote: > On Fri, Feb 22, 2019 at 9:58 AM Jason Ekstrand wrote: > > On Fri, Feb 22, 2019 at 9:57 AM Lionel Landwerlin > > wrote: > > > On 22/02/2019 15:51, Juan A. Suarez Romero wrote: > > > > > > > On one side, when emitting 3DSTATE_SF,

[Mesa-dev] [Bug 109735] [Regression] broken font with mesa_vulkan_overlay

2019-02-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109735 Bas Nieuwenhuizen changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

Re: [Mesa-dev] [PATCH] anv: Explicitly set 3DSTATE_CLIP::VertexSubPixelPrecisionSelect

2019-02-22 Thread Lionel Landwerlin
On 22/02/2019 16:02, Jason Ekstrand wrote: This field was added on gen8 even though there's an identically defined one in 3DSTATE_SF. --- src/intel/vulkan/genX_pipeline.c | 4 1 file changed, 4 insertions(+) diff --git a/src/intel/vulkan/genX_pipeline.c

Re: [Mesa-dev] [PATCH v3 1/2] genxml: add missing field values for 3DSTATE_SF

2019-02-22 Thread Jason Ekstrand
Reviewed-by: Jason Ekstrand On Fri, Feb 22, 2019 at 9:56 AM Lionel Landwerlin < lionel.g.landwer...@intel.com> wrote: > On 22/02/2019 15:51, Juan A. Suarez Romero wrote: > > Fill out "Vertex Sub Pixel Precision Select" possible values. > > > > Signed-off-by: Juan A. Suarez Romero > > >

Re: [Mesa-dev] [PATCH v3 2/2] anv: advertise 8 subpixel precision bits

2019-02-22 Thread Jason Ekstrand
On Fri, Feb 22, 2019 at 9:58 AM Jason Ekstrand wrote: > On Fri, Feb 22, 2019 at 9:57 AM Lionel Landwerlin < > lionel.g.landwer...@intel.com> wrote: > >> On 22/02/2019 15:51, Juan A. Suarez Romero wrote: >> > On one side, when emitting 3DSTATE_SF, VertexSubPixelPrecisionSelect is >> > used to

[Mesa-dev] [PATCH] anv: Explicitly set 3DSTATE_CLIP::VertexSubPixelPrecisionSelect

2019-02-22 Thread Jason Ekstrand
This field was added on gen8 even though there's an identically defined one in 3DSTATE_SF. --- src/intel/vulkan/genX_pipeline.c | 4 1 file changed, 4 insertions(+) diff --git a/src/intel/vulkan/genX_pipeline.c b/src/intel/vulkan/genX_pipeline.c index 6255e5d83c5..192a121324d 100644 ---

Re: [Mesa-dev] [PATCH v3 2/2] anv: advertise 8 subpixel precision bits

2019-02-22 Thread Jason Ekstrand
On Fri, Feb 22, 2019 at 9:57 AM Lionel Landwerlin < lionel.g.landwer...@intel.com> wrote: > On 22/02/2019 15:51, Juan A. Suarez Romero wrote: > > On one side, when emitting 3DSTATE_SF, VertexSubPixelPrecisionSelect is > > used to select between 8 bit subpixel precision (value 0) or 4 bit > >

Re: [Mesa-dev] [PATCH v3 2/2] anv: advertise 8 subpixel precision bits

2019-02-22 Thread Lionel Landwerlin
On 22/02/2019 15:51, Juan A. Suarez Romero wrote: On one side, when emitting 3DSTATE_SF, VertexSubPixelPrecisionSelect is used to select between 8 bit subpixel precision (value 0) or 4 bit subpixel precision (value 1). As this value is not set, means it is taking the value 0, so 8 bit are used.

Re: [Mesa-dev] [PATCH v3 1/2] genxml: add missing field values for 3DSTATE_SF

2019-02-22 Thread Lionel Landwerlin
On 22/02/2019 15:51, Juan A. Suarez Romero wrote: Fill out "Vertex Sub Pixel Precision Select" possible values. Signed-off-by: Juan A. Suarez Romero Reviewed-by: Lionel Landwerlin --- src/intel/genxml/gen10.xml | 5 - src/intel/genxml/gen11.xml | 5 -

[Mesa-dev] [PATCH v3 1/2] genxml: add missing field values for 3DSTATE_SF

2019-02-22 Thread Juan A. Suarez Romero
Fill out "Vertex Sub Pixel Precision Select" possible values. Signed-off-by: Juan A. Suarez Romero --- src/intel/genxml/gen10.xml | 5 - src/intel/genxml/gen11.xml | 5 - src/intel/genxml/gen7.xml | 5 - src/intel/genxml/gen75.xml | 5 - src/intel/genxml/gen8.xml | 5 -

[Mesa-dev] [PATCH v3 2/2] anv: advertise 8 subpixel precision bits

2019-02-22 Thread Juan A. Suarez Romero
On one side, when emitting 3DSTATE_SF, VertexSubPixelPrecisionSelect is used to select between 8 bit subpixel precision (value 0) or 4 bit subpixel precision (value 1). As this value is not set, means it is taking the value 0, so 8 bit are used. On the other side, in the Vulkan CTS tests, if the

Re: [Mesa-dev] [PATCH] nir: add nir_instr_type_tex support to nir_lower_phis_to_scalar()

2019-02-22 Thread Eric Anholt
Timothy Arceri writes: > shader-db results i965 (SKL): > > total instructions in shared programs: 13219105 -> 13024761 (-1.47%) > instructions in affected programs: 1169457 -> 975113 (-16.62%) > helped: 599 > HURT: 154 > > total cycles in shared programs: 333968972 -> 324822073 (-2.74%) > cycles

[Mesa-dev] [Bug 109739] Mesa build fails when vulkan-overlay-layer option is enabled

2019-02-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109739 --- Comment #5 from Lionel Landwerlin --- Uploaded https://gitlab.freedesktop.org/mesa/mesa/merge_requests/293 -- You are receiving this mail because: You are the assignee for the bug.___ mesa-dev

Re: [Mesa-dev] [PATCH 3/4] i965: Use genxml for emitting PIPE_CONTROL.

2019-02-22 Thread Pohjolainen, Topi
On Thu, Nov 01, 2018 at 08:04:20PM -0700, Kenneth Graunke wrote: > While this does add a bunch of boilerplate, it also protects us against > the hardware moving bits, or changing their meaning. For something as > finnicky as PIPE_CONTROL, the extra safety seems worth it. > > We turn

[Mesa-dev] [Bug 109739] Mesa build fails when vulkan-overlay-layer option is enabled

2019-02-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109739 --- Comment #4 from Lionel Landwerlin --- On the install : true, I was told to remove it. Not being a meson expert but I can definitely put it back. On the header files of the loader/validation-layers, I have the headers installed in a

[Mesa-dev] [Bug 109739] Mesa build fails when vulkan-overlay-layer option is enabled

2019-02-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109739 --- Comment #3 from Tapani Pälli --- It seems like meson.build should add 'inc_vulkan_validation' dev header directory to include_directories or just append 'vulkan/' for each header used from there. -- You are receiving this mail because:

Re: [Mesa-dev] [PATCH] panfrost: Backport driver to Mali T600/T700

2019-02-22 Thread Emil Velikov
On Tue, 19 Feb 2019 at 16:59, Connor Abbott wrote: > > On Tue, Feb 19, 2019 at 5:33 PM Emil Velikov wrote: >> >> On Fri, 15 Feb 2019 at 21:39, Alyssa Rosenzweig wrote: >> > >> > > - about 1/5 of the patch seems to be white space changes >> > >> > ...Oops. Any tips for avoiding this type of diff

Re: [Mesa-dev] [PATCH v2 2/2] isl: the display engine requires 64B alignment for linear surfaces

2019-02-22 Thread Lionel Landwerlin
Pushed with the PRM quote, thanks! On 22/02/2019 06:16, Samuel Iglesias Gonsálvez wrote: Lionel, are you going to push it with this quote? I can add it otherwise. Sam On Thu, 2019-02-21 at 13:41 +, Lionel Landwerlin wrote: On 21/02/2019 13:30, Chris Wilson wrote: Quoting Lionel

Re: [Mesa-dev] [PATCH] etnaviv: blt: mark used src resource as read from

2019-02-22 Thread Boris Brezillon
On Fri, 22 Feb 2019 11:10:29 +0100 Christian Gmeiner wrote: > Signed-off-by: Christian Gmeiner Reviewed-by: Boris Brezillon > --- > src/gallium/drivers/etnaviv/etnaviv_blt.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/src/gallium/drivers/etnaviv/etnaviv_blt.c >

Re: [Mesa-dev] etnaviv: rs: mark used src resource as read from

2019-02-22 Thread Boris Brezillon
On Fri, 22 Feb 2019 11:02:34 +0100 Christian Gmeiner wrote: > Signed-off-by: Christian Gmeiner Reviewed-by: Boris Brezillon > --- > src/gallium/drivers/etnaviv/etnaviv_rs.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/src/gallium/drivers/etnaviv/etnaviv_rs.c >

Re: [Mesa-dev] [PATCH v5] etnaviv: fix resource usage tracking across different pipe_context's

2019-02-22 Thread Boris Brezillon
On Thu, 21 Feb 2019 23:29:53 +0100 Boris Brezillon wrote: > Christian, Marek, > > On Wed, 30 Jan 2019 05:28:14 +0100 > Marek Vasut wrote: > > > From: Christian Gmeiner > > > > A pipe_resource can be shared by all the pipe_context's hanging off the > > same pipe_screen. > > We seem to be

Re: [Mesa-dev] [PATCH] etnaviv: blt: mark used src resource as read from

2019-02-22 Thread Lucas Stach
Am Freitag, den 22.02.2019, 11:10 +0100 schrieb Christian Gmeiner: > Signed-off-by: Christian Gmeiner Reviewed-by: Lucas Stach > --- > src/gallium/drivers/etnaviv/etnaviv_blt.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/src/gallium/drivers/etnaviv/etnaviv_blt.c >

Re: [Mesa-dev] etnaviv: rs: mark used src resource as read from

2019-02-22 Thread Lucas Stach
Am Freitag, den 22.02.2019, 11:02 +0100 schrieb Christian Gmeiner: > Signed-off-by: Christian Gmeiner Reviewed-by: Lucas Stach > --- > src/gallium/drivers/etnaviv/etnaviv_rs.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/src/gallium/drivers/etnaviv/etnaviv_rs.c >

[Mesa-dev] [Bug 109532] ir_variable has maximum access out of bounds -- but it's not out of bounds

2019-02-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109532 --- Comment #36 from asimiklit --- (In reply to Ian Romanick from comment #33) > (In reply to andrii simiklit from comment #32) > > (In reply to andrii simiklit from comment #31) > > > (In reply to Mark Janes from comment #30) > > > > (In reply

[Mesa-dev] [Bug 109739] Mesa build fails when vulkan-overlay-layer option is enabled

2019-02-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109739 --- Comment #2 from osch...@web.de --- I had to add this to get the overlay .so deployed: diff --git a/src/vulkan/overlay-layer/meson.build b/src/vulkan/overlay-layer/meson.build index 573983e0438..9d1bc97c131 100644 ---

[Mesa-dev] [PATCH] etnaviv: blt: mark used src resource as read from

2019-02-22 Thread Christian Gmeiner
Signed-off-by: Christian Gmeiner --- src/gallium/drivers/etnaviv/etnaviv_blt.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/gallium/drivers/etnaviv/etnaviv_blt.c b/src/gallium/drivers/etnaviv/etnaviv_blt.c index 52731a9c770..42190d75d4e 100644 ---

[Mesa-dev] etnaviv: rs: mark used src resource as read from

2019-02-22 Thread Christian Gmeiner
Signed-off-by: Christian Gmeiner --- src/gallium/drivers/etnaviv/etnaviv_rs.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/drivers/etnaviv/etnaviv_rs.c b/src/gallium/drivers/etnaviv/etnaviv_rs.c index fc4f65dbeee..a9d3872ad41 100644 ---

[Mesa-dev] [Bug 109711] [DXVK] Skyrim Special edition hangs

2019-02-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109711 Michel Dänzer changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

Re: [Mesa-dev] [PATCH v5] etnaviv: fix resource usage tracking across different pipe_context's

2019-02-22 Thread Christian Gmeiner
Hi Boris, Am Fr., 22. Feb. 2019 um 10:30 Uhr schrieb Boris Brezillon : > > On Thu, 21 Feb 2019 23:29:53 +0100 > Boris Brezillon wrote: > > > Christian, Marek, > > > > On Wed, 30 Jan 2019 05:28:14 +0100 > > Marek Vasut wrote: > > > > > From: Christian Gmeiner > > > > > > A pipe_resource can be

Re: [Mesa-dev] [PATCH 3/4] etnaviv: hook-up etc2 patching

2019-02-22 Thread Lucas Stach
Am Freitag, den 22.02.2019, 10:18 +0100 schrieb Christian Gmeiner: > Signed-off-by: Christian Gmeiner AFAICS this is directly operating on the mapped buffer, right? As ETC is stored as a linear, we won't get a temporary resource for the transfer, but map the GPU resource directly. So this will

Re: [Mesa-dev] [PATCH 2/4] etnaviv: keep track of mapped bo address

2019-02-22 Thread Lucas Stach
Am Freitag, den 22.02.2019, 10:18 +0100 schrieb Christian Gmeiner: > Saves us from calling etna_bo_map(..) and saves us from doing the > same offset calcs for map() and unmap() operations. > > Signed-off-by: Christian Gmeiner Reviewed-by: Lucas Stach > --- >

[Mesa-dev] [PATCH 1/4] etnaviv: implement ETC2 block patching for HALTI0

2019-02-22 Thread Christian Gmeiner
ETC2 is supported with HALTI0, however that implementation is buggy in hardware. The blob driver does per-block patching to work around this. We need to swap colors for t-mode etc2 blocks. Signed-off-by: Christian Gmeiner --- src/gallium/drivers/etnaviv/Makefile.sources | 2 +

[Mesa-dev] [PATCH 0/4] Add ETC2 block patching for HALTI0

2019-02-22 Thread Christian Gmeiner
HALTI0 GPUs have broken ETC2 support (for RGB and RGBA) formats. The blob driver does per-block patching. The patching is quite simple: color swaping. This patch series adds support for the needed block patching and enabled ETC2 support for HALTI0. Passes all tested formats of the following

[Mesa-dev] [PATCH 3/4] etnaviv: hook-up etc2 patching

2019-02-22 Thread Christian Gmeiner
Signed-off-by: Christian Gmeiner --- .../drivers/etnaviv/etnaviv_resource.c| 3 ++ .../drivers/etnaviv/etnaviv_resource.h| 5 ++ .../drivers/etnaviv/etnaviv_transfer.c| 49 +++ 3 files changed, 57 insertions(+) diff --git

[Mesa-dev] [PATCH 4/4] etnaviv: enable ETC2 texture compression support for HALTI0 GPUs

2019-02-22 Thread Christian Gmeiner
Signed-off-by: Christian Gmeiner --- src/gallium/drivers/etnaviv/etnaviv_screen.c | 12 +--- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/src/gallium/drivers/etnaviv/etnaviv_screen.c b/src/gallium/drivers/etnaviv/etnaviv_screen.c index de822fc85ca..ee32a499fb5 100644

[Mesa-dev] [PATCH 2/4] etnaviv: keep track of mapped bo address

2019-02-22 Thread Christian Gmeiner
Saves us from calling etna_bo_map(..) and saves us from doing the same offset calcs for map() and unmap() operations. Signed-off-by: Christian Gmeiner --- src/gallium/drivers/etnaviv/etnaviv_context.h | 1 + .../drivers/etnaviv/etnaviv_transfer.c| 19 ++- 2 files

[Mesa-dev] [Bug 109741] swr doesn't build on i386 - simdlib.hpp:594:37: error: static assertion failed: This path only meant for 64-bit code

2019-02-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109741 Bug ID: 109741 Summary: swr doesn't build on i386 - simdlib.hpp:594:37: error: static assertion failed: This path only meant for 64-bit code Product: Mesa

Re: [Mesa-dev] [PATCH v5] etnaviv: fix resource usage tracking across different pipe_context's

2019-02-22 Thread Boris Brezillon
Christian, Marek, On Wed, 30 Jan 2019 05:28:14 +0100 Marek Vasut wrote: > From: Christian Gmeiner > > A pipe_resource can be shared by all the pipe_context's hanging off the > same pipe_screen. We seem to be impacted by the problem you're fixing here, but, while this patch definitely make

[Mesa-dev] [PATCH] nir: add nir_instr_type_tex support to nir_lower_phis_to_scalar()

2019-02-22 Thread Timothy Arceri
shader-db results i965 (SKL): total instructions in shared programs: 13219105 -> 13024761 (-1.47%) instructions in affected programs: 1169457 -> 975113 (-16.62%) helped: 599 HURT: 154 total cycles in shared programs: 333968972 -> 324822073 (-2.74%) cycles in affected programs: 130032440 ->