We have a native op for this, which was just found in a disassembly --
so instead of lowering, use it!
Signed-off-by: Alyssa Rosenzweig
---
src/gallium/drivers/panfrost/midgard/helpers.h | 1 +
src/gallium/drivers/panfrost/midgard/midgard.h | 2 ++
Reviewed-by: Sagar Ghuge
On 3/12/19 3:34 AM, Eleni Maria Stea wrote:
> Enabled the VK_EXT_sample_locations for Intel Gen >= 7.
>
> v2: Replaced device.info->gen >= 7 with True, as Anv doesn't support
> anything below Gen7. (Lionel Landwerlin)
> ---
> src/intel/vulkan/anv_extensions.py | 2
Reviewed-by: Sagar Ghuge
On 3/12/19 3:34 AM, Eleni Maria Stea wrote:
> Added the VK_EXT_sample_locations to the anv_extensions.py list to
> generate the related entrypoints.
> ---
> src/intel/vulkan/anv_extensions.py | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git
NIR can produce IR that looks like this:
vec1 1 ssa_51 = ilt ssa_32, ssa_50
vec4 32 ssa_54 = intrinsic load_deref (ssa_53) (0)
vec4 32 ssa_57 = intrinsic load_deref (ssa_56) (0)
vec4 32 ssa_61 = bcsel ssa_51., ssa_54, ssa_57
The swizzle on the first bcsel src
Cc: mesa-sta...@lists.freedesktop.org
Cc: Nanley Chery
---
src/intel/vulkan/anv_pass.c | 18 +-
1 file changed, 17 insertions(+), 1 deletion(-)
diff --git a/src/intel/vulkan/anv_pass.c b/src/intel/vulkan/anv_pass.c
index 5fac5bbb31c..ec217abfda0 100644
---
The series looks great. Just a few minor suggestions below.
Reviewed-by: Brian Paul
BTW, I happened to look at _mesa_primitive_restart_index(). It seems we
could/should add an assertion in there:
assert(index_size == 1 ||
index_size == 2 ||
index_size == 4);
right?
-Brian
Build mesa 10389 completed
Commit 3570d15b6d by Kenneth Graunke on 3/12/2019 2:00 AM:
intel/fs: Fix opt_peephole_csel to not throw away saturates.\n\nWe were not copying the saturate bit from the original instruction\nto the new replacement instruction. This
https://bugs.freedesktop.org/show_bug.cgi?id=109641
Brian Paul changed:
What|Removed |Added
Resolution|--- |FIXED
Status|NEW
On Tue, Mar 12, 2019 at 9:59 AM Marc-André Lureau
wrote:
>
> Hi
>
> On Fri, Mar 1, 2019 at 12:13 PM Mathias Fröhlich
> wrote:
> >
> > On Friday, 1 March 2019 12:15:08 CET Eero Tamminen wrote:
> > > Hi,
> > >
> > > On 1.3.2019 11.12, Michel Dänzer wrote:
> > > > On 2019-02-28 8:41 p.m., Marek
Build mesa 10388 failed
Commit 904905e3de by Alyssa Rosenzweig on 3/13/2019 1:50 AM:
panfrost: Compute viewport state on the fly\n\nPreviously, we were caching this incorrectly; there's no real reason to\ngiven how variable it is (sensitive to changes in
Pushed. Thanks!
On Tue, Mar 12, 2019 at 6:35 PM Sagar Ghuge wrote:
> Reviewed-by: Sagar Ghuge
>
> On 3/12/19 4:21 PM, Jason Ekstrand wrote:
> > We don't care about the information but there's no sense in throwing a
> > debug warning about it. It's harmless but annoying to users.
> >
> >
Pushed! Thanks.
On Tue, Mar 12, 2019 at 5:42 PM Timothy Arceri
wrote:
>
>
> On 13/3/19 8:30 am, Jason Ekstrand wrote:
> > The previous code was completely broken when it came to constructing the
> > undef values. I'm not sure how it ever worked. For the case of a copy
> > that reads an
Signed-off-by: Alyssa Rosenzweig
---
src/gallium/drivers/panfrost/pan_context.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/src/gallium/drivers/panfrost/pan_context.c
b/src/gallium/drivers/panfrost/pan_context.c
index 48e471eace2..cb226cc2220 100644
---
This removes a clunky hack where the depth buffer was enabled during the
*clear*, instead of during depth buffer linking. That said, this does
not yet support writeback like AFBC depth buffers.
Signed-off-by: Alyssa Rosenzweig
---
src/gallium/drivers/panfrost/pan_mfbd.c | 19 +--
It's not clear why the hardware "spills" a little bit, but if we don't
do this, we get MMU faults with linear depth buffers.
Signed-off-by: Alyssa Rosenzweig
---
src/gallium/drivers/panfrost/pan_resource.c | 5 +
1 file changed, 5 insertions(+)
diff --git
While a depth buffer may be supplied, it only needs to be written to if
the depth writemask is set for any draw AND if the depth buffer is not
immediately invalidated (as is the case for scanout). This refactors
panfrost_job to provide a depth write requirement, which is now
implemented for MFBD
Signed-off-by: Alyssa Rosenzweig
---
src/gallium/drivers/panfrost/pan_mfbd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/gallium/drivers/panfrost/pan_mfbd.c
b/src/gallium/drivers/panfrost/pan_mfbd.c
index 68c842981f3..ac7f9ed665f 100644
---
For inexplicable reasons, the depth buffer is faster if kept as linear,
whereas the colour buffers are faster if AFBC. Given both code paths are
available, we'll choose the faster one of each (which also helps with
testing coverage).
Signed-off-by: Alyssa Rosenzweig
---
This patch series can be considered a "v2" of the previous, for the
commits that were not merged due to regressions and such. It goes back
and fixes quite a bit of these issues the right way. One particular
benefit is the removal of the staging fragment framebuffer descriptor,
which was a major
Previously, we were caching this incorrectly; there's no real reason to
given how variable it is (sensitive to changes in viewport, framebuffer
dimensions, and scissors) and how cheap it is to recompute. So, just do
it on the fly each draw.
Fixes glmark-es2 -bshadow and -brefract.
Signed-off-by:
The fragment framebuffer descriptor should not be a context entry;
rather, it should be constructed only at fragment time to keep analysis
tractable.
Signed-off-by: Alyssa Rosenzweig
---
src/gallium/drivers/panfrost/pan_context.h | 5 +-
src/gallium/drivers/panfrost/pan_fragment.c | 7 ++-
This substantially cleans up the corresponding logic at the expense of a
bit of code duplication; nevertheless, it's a net win since otherwise
incompatible hardware code is mixed confusingly.
Signed-off-by: Alyssa Rosenzweig
---
src/gallium/drivers/panfrost/meson.build| 3 +
Same idea as the previous commit, but for the MFBD this time instead of
the SFBD.
Signed-off-by: Alyssa Rosenzweig
---
src/gallium/drivers/panfrost/pan_context.h | 13 --
src/gallium/drivers/panfrost/pan_mfbd.c| 194 +++--
2 files changed, 98 insertions(+), 109 deletions(-)
This one causes 2000+ piglit tests to fail on radeonsi. For example:
./bin/shader_runner
generated_tests/spec/arb_gpu_shader_fp64/execution/conversion/geom-conversion-explicit-bool-double.shader_test
-auto -fbo
On 13/3/19 3:19 am, Samuel Pitoiset wrote:
New buffer intrinsics have a separate
Both patches are:
Reviewed-by: Alyssa Rosenzweig
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Reviewed-by: Sagar Ghuge
On 3/12/19 4:21 PM, Jason Ekstrand wrote:
> We don't care about the information but there's no sense in throwing a
> debug warning about it. It's harmless but annoying to users.
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=109984
> Cc: Craig Stout
> ---
We don't care about the information but there's no sense in throwing a
debug warning about it. It's harmless but annoying to users.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=109984
Cc: Craig Stout
---
src/intel/vulkan/anv_pass.c | 4
1 file changed, 4 insertions(+)
diff
The env var workaround is fine.
Thread affinity is used for cache topology related optimizations. I think
it's a mistake to treat it only as a resource allocation tool.
Marek
On Tue, Mar 12, 2019, 1:59 AM Marc-André Lureau
wrote:
> Hi
>
> On Fri, Mar 1, 2019 at 12:13 PM Mathias Fröhlich
>
Francisco Jerez writes:
> Iago Toral writes:
>
>> On Tue, 2019-03-05 at 07:35 +0100, Iago Toral wrote:
>>> On Mon, 2019-03-04 at 15:36 -0800, Francisco Jerez wrote:
>>> > Iago Toral writes:
>>> >
>>> > > On Fri, 2019-03-01 at 19:04 -0800, Francisco Jerez wrote:
>>> > > > Iago Toral writes:
Iago Toral writes:
> On Wed, 2019-03-06 at 09:21 +0100, Iago Toral wrote:
>> On Tue, 2019-03-05 at 07:35 +0100, Iago Toral wrote:
>> > On Mon, 2019-03-04 at 15:36 -0800, Francisco Jerez wrote:
>> > > Iago Toral writes:
>> > >
>> > > > On Fri, 2019-03-01 at 19:04 -0800, Francisco Jerez wrote:
Iago Toral writes:
> On Tue, 2019-03-05 at 07:35 +0100, Iago Toral wrote:
>> On Mon, 2019-03-04 at 15:36 -0800, Francisco Jerez wrote:
>> > Iago Toral writes:
>> >
>> > > On Fri, 2019-03-01 at 19:04 -0800, Francisco Jerez wrote:
>> > > > Iago Toral writes:
>> > > >
>> > > > > On Thu,
On 13/3/19 8:30 am, Jason Ekstrand wrote:
The previous code was completely broken when it came to constructing the
undef values. I'm not sure how it ever worked. For the case of a copy
that reads an undefined value, we can just delete the copy because the
destination is a valid undefined
Iago Toral writes:
> On Mon, 2019-03-04 at 15:36 -0800, Francisco Jerez wrote:
>> Iago Toral writes:
>>
>> > On Fri, 2019-03-01 at 19:04 -0800, Francisco Jerez wrote:
>> > > Iago Toral writes:
>> > >
>> > > > On Thu, 2019-02-28 at 09:54 -0800, Francisco Jerez wrote:
>> > > > > Iago Toral
On 3/12/19 5:19 PM, Samuel Pitoiset wrote:
Similar to ac_build_buffer_load_format().
Signed-off-by: Samuel Pitoiset
---
src/amd/common/ac_llvm_build.c | 100
src/amd/common/ac_llvm_build.h | 11
src/amd/common/ac_nir_to_llvm.c | 29 +++--
3
On Tue, Mar 12, 2019 at 1:59 PM Roland Scheidegger wrote:
>
> Am 12.03.19 um 16:16 schrieb Rob Clark:
> > This previously was not called out clearly, but based on a survey of the
> > code, it seems the expected behavior is to release the reference to any
> > sampler views beyond the new range
The previous code was completely broken when it came to constructing the
undef values. I'm not sure how it ever worked. For the case of a copy
that reads an undefined value, we can just delete the copy because the
destination is a valid undefined value. This saves us the effort of
trying to
This fixes random SteamVR corruption, see
https://github.com/ValveSoftware/SteamVR-for-Linux/issues/181
Fixes: 4d30f2c6f42 ("radv/winsys: remove the max IBs per submit limit for the
fallback path")
Signed-off-by: Samuel Pitoiset
---
src/amd/vulkan/radv_device.c | 2
On 3/12/19 7:11 PM, Emil Velikov wrote:
On Tue, 12 Mar 2019 at 15:12, Samuel Pitoiset wrote:
Reviewed-by: Samuel Pitoiset
A fixes tag like below would be great ;-)
Fixes: 14cad8786a8 ("radv: generate the same driver UUID as radeonsi")
Reviewed-by: Emil Velikov
Aside: seems like
We've been fairly inconsistent about this so we should really choose
whether we're going to use VK_TRUE/FALSE or the C boolean values. The
Vulkan #defines are set to 1 and 0 respectively so it's the same value
as C gives you when you cast a boolean expression to an integer. Since
there are
Hi,
chained to this message are two patches that aim to fix llvmpipe driver on
an ARM machine that has no NEON instructions. My machine is a XO-1.75
laptop with a Marvell MMP2 processor:
[lkundrak@xo ~]$ LD_SHOW_AUXV=yespls /bin/true |grep HWCAP
AT_HWCAP:half thumb fastmult vfp edsp
getHostCPUFeatures() is also available on ARM, for even longer time than
for x86. Use it -- it potentially enables instructions that may speed
things up.
Signed-off-by: Lubomir Rintel
Cc:
---
src/gallium/auxiliary/gallivm/lp_bld_misc.cpp | 13 ++---
1 file changed, 6 insertions(+), 7
The LLVM project made some questionable decisions about defaults for
armv7 (e.g. they enable NEON that is not there on NVIDIA and Marvell
platforms).
On top of that, getHostCPUFeatures() doesn't disable missing machine
attributes. Finally, -neon alone is not sufficient to disable emmision
of NEON
Reviewed-by: Sagar Ghuge
On 3/12/19 3:34 AM, Eleni Maria Stea wrote:
> In src/intel/vulkan/genX_blorp_exec.c we included the file:
> common/gen_sample_positions.h but not use it. Removed.
> ---
> src/intel/vulkan/genX_blorp_exec.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git
r-b for the series
On Tue, Feb 26, 2019 at 1:39 PM Samuel Pitoiset
wrote:
>
> This drastically reduces the number of SGPRs because the driver
> now uses descriptors per vertex binding, instead of per vertex
> attribute format.
>
> 29077 shaders in 15096 tests
> Totals:
> SGPRS: 1354285 ->
On Tue, 12 Mar 2019 at 15:12, Samuel Pitoiset wrote:
>
> Reviewed-by: Samuel Pitoiset
>
A fixes tag like below would be great ;-)
Fixes: 14cad8786a8 ("radv: generate the same driver UUID as radeonsi")
Reviewed-by: Emil Velikov
Aside: seems like radv_get_driver_uuid() produces "AMD-MESA-DRV"
Am 12.03.19 um 16:16 schrieb Rob Clark:
> This previously was not called out clearly, but based on a survey of the
> code, it seems the expected behavior is to release the reference to any
> sampler views beyond the new range being bound.
That isn't really true. This was designed to work like
Am 12.03.19 um 18:34 schrieb Eric Anholt:
> Ilia Mirkin writes:
>
>> I believe the distinction here is between initializing all the fields
>> and using them individually (thus leaving the padding uninitialized),
>> vs using the fields to create a structure to hash as a sequence of
>> bytes. For
Ilia Mirkin writes:
> I believe the distinction here is between initializing all the fields
> and using them individually (thus leaving the padding uninitialized),
> vs using the fields to create a structure to hash as a sequence of
> bytes. For the latter, you really need all the memory
I believe the distinction here is between initializing all the fields
and using them individually (thus leaving the padding uninitialized),
vs using the fields to create a structure to hash as a sequence of
bytes. For the latter, you really need all the memory initialized, not
just the "valid"
Brian Paul writes:
> On 03/11/2019 04:47 PM, Eric Anholt wrote:
>> Brian Paul writes:
>>
>>> Since the compiler may not zero-out padding in the object.
>>> Add a couple comments about this to prevent misunderstandings in
>>> the future.
>>>
>>> Fixes: 67d96816ff5 ("st/mesa: move, clean-up
New buffer intrinsics have a separate soffset parameter.
Signed-off-by: Samuel Pitoiset
---
src/amd/common/ac_llvm_build.c | 66 ++
1 file changed, 26 insertions(+), 40 deletions(-)
diff --git a/src/amd/common/ac_llvm_build.c b/src/amd/common/ac_llvm_build.c
Signed-off-by: Samuel Pitoiset
---
src/amd/common/ac_llvm_build.c | 108
src/amd/common/ac_llvm_build.h | 26
src/amd/common/ac_nir_to_llvm.c | 26 ++--
3 files changed, 139 insertions(+), 21 deletions(-)
diff --git
Signed-off-by: Samuel Pitoiset
---
src/amd/common/ac_llvm_build.c | 8
1 file changed, 8 insertions(+)
diff --git a/src/amd/common/ac_llvm_build.c b/src/amd/common/ac_llvm_build.c
index bb8a470ae1d..7aec8154a76 100644
--- a/src/amd/common/ac_llvm_build.c
+++
Similar to ac_build_buffer_load_format().
Signed-off-by: Samuel Pitoiset
---
src/amd/common/ac_llvm_build.c | 100
src/amd/common/ac_llvm_build.h | 11
src/amd/common/ac_nir_to_llvm.c | 29 +++--
3 files changed, 119 insertions(+), 21 deletions(-)
Trivial.
Signed-off-by: Samuel Pitoiset
---
src/amd/common/ac_nir_to_llvm.c | 9 +++--
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c
index c10a0cce16f..55d3ce90ce4 100644
--- a/src/amd/common/ac_nir_to_llvm.c
Signed-off-by: Samuel Pitoiset
---
src/amd/common/ac_nir_to_llvm.c | 23 +--
1 file changed, 9 insertions(+), 14 deletions(-)
diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c
index be0dca2d857..47a865de36f 100644
---
Signed-off-by: Samuel Pitoiset
---
src/amd/common/ac_nir_to_llvm.c | 35 ++---
1 file changed, 6 insertions(+), 29 deletions(-)
diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c
index 922f1063c79..be0dca2d857 100644
---
ac_build_llvm8_tbuffer_load() expects a boolean for glc.
Fixes: 2cf5433b99f ("ac: use new LLVM 8 intrinsic when loading 16-bit values")
Signed-off-by: Samuel Pitoiset
---
src/amd/common/ac_llvm_build.c | 4 ++--
src/amd/common/ac_llvm_build.h | 2 +-
src/amd/common/ac_nir_to_llvm.c | 4 ++--
Signed-off-by: Samuel Pitoiset
---
src/amd/common/ac_nir_to_llvm.c | 65 +
1 file changed, 41 insertions(+), 24 deletions(-)
diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c
index 55d3ce90ce4..922f1063c79 100644
---
For consistency regarding other store operations.
Signed-off-by: Samuel Pitoiset
---
src/amd/common/ac_nir_to_llvm.c | 9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c
index a7b3fdf64aa..ff29345ffe5
Signed-off-by: Samuel Pitoiset
---
src/amd/common/ac_llvm_build.c | 8 ++--
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/src/amd/common/ac_llvm_build.c b/src/amd/common/ac_llvm_build.c
index 88ea289a121..253073e52fb 100644
--- a/src/amd/common/ac_llvm_build.c
+++
Hi,
This small series makes use of new LLVM 8 buffer intrinsics.
No CTS regressions on GFX8 with LLVM 7, 8 and master.
Please review,
Thanks!
Samuel Pitoiset (11):
ac: fix glc parameter use for new LLVM 8 typed buffer intrinsics
ac: make use of ac_get_store_intr_attribs() where possible
So we can unmap it later.
Signed-off-by: Tomeu Vizoso
---
include/drm-uapi/panfrost_drm.h| 1 -
src/gallium/drivers/panfrost/pan_drm.c | 10 +-
2 files changed, 5 insertions(+), 6 deletions(-)
diff --git a/include/drm-uapi/panfrost_drm.h b/include/drm-uapi/panfrost_drm.h
index
So we can free it later.
Signed-off-by: Tomeu Vizoso
---
src/gallium/drivers/panfrost/pan_resource.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/src/gallium/drivers/panfrost/pan_resource.c
b/src/gallium/drivers/panfrost/pan_resource.c
index d647f618ee77..2fa468b177b9
https://bugs.freedesktop.org/show_bug.cgi?id=109535
Bug 109535 depends on bug 107510, which changed state.
Bug 107510 Summary: [GEN8+] up to 10% perf drop on several 3D benchmarks
https://bugs.freedesktop.org/show_bug.cgi?id=107510
What|Removed |Added
This previously was not called out clearly, but based on a survey of the
code, it seems the expected behavior is to release the reference to any
sampler views beyond the new range being bound.
I think radeonsi and freedreno were the only ones not doing this. Which
could probably temporarily leak
Bug 109646 - New video compositor compute shader render glitches mpv
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=109646
Fixed Problem 2,3:Jaggines caused by interpolation issue with weave de-interlace
James Zhu (3):
gallium/auxiliary/vl: Increase shader_params size
Reviewed-by: Samuel Pitoiset
On 3/12/19 4:07 PM, Józef Kucia wrote:
---
src/amd/vulkan/radv_device.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/amd/vulkan/radv_device.c b/src/amd/vulkan/radv_device.c
index 83d218fb6bf0..6deb69d22d48 100644
---
Using draw area for grid setting instead of destination
buffer size.
Signed-off-by: James Zhu
Tested-by: Bruno Milreu
---
src/gallium/auxiliary/vl/vl_compositor_cs.c | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/src/gallium/auxiliary/vl/vl_compositor_cs.c
Use 2D_ARRARY instead of RECT to fetch texels for weave compute
shader.
Problem 2,3: Fixed interpolation issue with weave de-interlace
Fixes: 9364d66cb7f7 (Add video compositor compute shader render)
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=109646
Signed-off-by: James Zhu
Cc: mesa-sta...@lists.freedesktop.org
---
src/mesa/main/get.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/src/mesa/main/get.c b/src/mesa/main/get.c
index ee77c45d03c1..efc9c11f79d3 100644
--- a/src/mesa/main/get.c
+++ b/src/mesa/main/get.c
@@ -906,6 +906,9 @@ find_custom_value(struct
Increase shader_params size to pass sampler data to
compute shader during weave de-interlace.
Signed-off-by: James Zhu
Tested-by: Bruno Milreu
---
src/gallium/auxiliary/vl/vl_compositor.c| 2 +-
src/gallium/auxiliary/vl/vl_compositor_cs.c | 9 -
2 files changed, 9 insertions(+), 2
---
src/amd/vulkan/radv_device.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/amd/vulkan/radv_device.c b/src/amd/vulkan/radv_device.c
index 83d218fb6bf0..6deb69d22d48 100644
--- a/src/amd/vulkan/radv_device.c
+++ b/src/amd/vulkan/radv_device.c
@@ -337,7 +337,7 @@
https://bugs.freedesktop.org/show_bug.cgi?id=109929
--- Comment #4 from Timur Kristóf ---
Created attachment 143635
--> https://bugs.freedesktop.org/attachment.cgi?id=143635=edit
build log of mesa with e582e761b7f49d1c0b100289b62442e6295cefef
I tried with the commit before that,
https://bugs.freedesktop.org/show_bug.cgi?id=109641
--- Comment #2 from Brian Paul ---
And it appears this patch will be in the Mesa 19.0 release.
--- Comment #3 from Marcello Blancasio ---
The patch fixed the issue. Thank you.
--
You are receiving this mail because:
You are the assignee for
On Tue, Mar 12, 2019 at 12:24:00AM +, Wentland, Harry wrote:
> To all X.Org Foundation Members:
>
> The election for the X.Org Foundation Board of Directors will begin on
> 14 March 2019. We have 6 candidates who are running for 4 seats. They
> are (in alphabetical order):
> Attached below
https://bugs.freedesktop.org/show_bug.cgi?id=77449
Bug 77449 depends on bug 104602, which changed state.
Bug 104602 Summary: [apitrace] Graphical artifacts in Civilization VI on RX Vega
https://bugs.freedesktop.org/show_bug.cgi?id=104602
What|Removed |Added
On Mon, 11 Mar 2019 11:39:58 -0700
Sagar Ghuge wrote:
> On Mon, 2019-03-11 at 17:04 +0200, Eleni Maria Stea wrote:
> > The VkPhysicalDeviceSampleLocationPropertiesEXT struct is filled
> > with implementation dependent values and according to the table
> > from the Vulkan Specification section
In src/intel/vulkan/genX_blorp_exec.c we included the file:
common/gen_sample_positions.h but not use it. Removed.
---
src/intel/vulkan/genX_blorp_exec.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/src/intel/vulkan/genX_blorp_exec.c
b/src/intel/vulkan/genX_blorp_exec.c
index
We only emit sample locations when the extension is enabled by the user.
In all other cases the default locations are emitted once when the device
is initialized to increase performance.
---
src/intel/vulkan/anv_genX.h| 3 ++-
src/intel/vulkan/genX_cmd_buffer.c | 2 +-
Allowing setting dynamic and non-dynamic sample locations on Gen7.
---
src/intel/vulkan/anv_genX.h| 13 ++---
src/intel/vulkan/genX_cmd_buffer.c | 9 ++--
src/intel/vulkan/genX_pipeline.c | 13 +
src/intel/vulkan/genX_state.c | 86 +-
4 files
Added support for setting the locations when the pipeline has been
created with the dynamic state bit enabled according to the Vulkan
Specification section [26.5. Custom Sample Locations] for the function:
'vkCmdSetSampleLocationsEXT'
The reason that we preferred to store the boolean valid
The VkPhysicalDeviceSampleLocationPropertiesEXT struct is filled with
implementation dependent values and according to the table from the
Vulkan Specification section [36.1. Limit Requirements]:
pname | max | min
pname:sampleLocationSampleCounts |-|ename:VK_SAMPLE_COUNT_4_BIT
Implemented the vkGetPhysicalDeviceMultisamplePropertiesEXT according to
the Vulkan Specification section [36.2. Additional Multisampling
Capabilities].
---
src/intel/Makefile.sources | 1 +
src/intel/vulkan/anv_sample_locations.c | 60 +
Enabled the VK_EXT_sample_locations for Intel Gen >= 7.
v2: Replaced device.info->gen >= 7 with True, as Anv doesn't support
anything below Gen7. (Lionel Landwerlin)
---
src/intel/vulkan/anv_extensions.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
Implemented the requirements from the VK_EXT_sample_locations extension
specification to allow setting custom sample locations on Intel Gen >= 7.
Some decisions explained:
The grid size was set to 1x1 because the hardware only supports a single
set of sample locations for the whole framebuffer.
Allowing the user to set custom sample locations non-dynamically, by
filling the extension structs and chaining them to the pipeline structs
according to the Vulkan specification section [26.5. Custom Sample Locations]
for the following structures:
'VkPipelineSampleLocationsStateCreateInfoEXT'
Added the VK_EXT_sample_locations to the anv_extensions.py list to
generate the related entrypoints.
---
src/intel/vulkan/anv_extensions.py | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/intel/vulkan/anv_extensions.py
b/src/intel/vulkan/anv_extensions.py
index 6fff293dee4..9e4e03e46df
Hi
On Fri, Mar 1, 2019 at 12:13 PM Mathias Fröhlich
wrote:
>
> On Friday, 1 March 2019 12:15:08 CET Eero Tamminen wrote:
> > Hi,
> >
> > On 1.3.2019 11.12, Michel Dänzer wrote:
> > > On 2019-02-28 8:41 p.m., Marek Olšák wrote:
> > >>> On Thu, Feb 28, 2019 at 1:37 PM Eero Tamminen
> > >>>
> >
89 matches
Mail list logo
