[Mesa-dev] [PATCH] softpipe: fix integer texture swizzling for 1 vs 1.0f

2019-03-20 Thread Dave Airlie
From: Dave Airlie The swizzling was putting float one in not integer 1. This fixes a lot of arb_texture_view-rendering-formats cases. --- src/gallium/drivers/softpipe/sp_tex_sample.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git

[Mesa-dev] [PATCH] softpipe: remove shadow_ref assert.

2019-03-20 Thread Dave Airlie
From: Dave Airlie I don't think this really buys us anything and TG4 with cubemap arrays falls over because sampler == 2, but otherwise works fine. Fixes: ./bin/textureGather fs shadow r CubeArray repeat on softpipe with ARB_gpu_shader5 enabled. --- src/gallium/auxiliary/tgsi/tgsi_exec.c | 1

[Mesa-dev] [PATCH 1/2] softpipe: fix 32-bit bitfield extract

2019-03-20 Thread Dave Airlie
From: Dave Airlie These didn't deal with the width == 32 case that TGSI is defined with. Fixes piglit tests if ARB_gpu_shader5 is enabled. --- src/gallium/auxiliary/tgsi/tgsi_exec.c | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git

[Mesa-dev] [PATCH 2/2] softpipe: handle 32-bit bitfield inserts

2019-03-20 Thread Dave Airlie
From: Dave Airlie Fixes piglits if ARB_gpu_shader5 is enabled --- src/gallium/auxiliary/tgsi/tgsi_exec.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/src/gallium/auxiliary/tgsi/tgsi_exec.c b/src/gallium/auxiliary/tgsi/tgsi_exec.c index c93e4e26e40..78159fc1d9f

[Mesa-dev] svga build warning

2019-03-20 Thread Dave Airlie
src/gallium/winsys/svga/drm/vmw_screen.c: In function 'vmw_dev_compare': src/gallium/winsys/svga/drm/vmw_screen.c:48:13: warning: In the GNU C Library, "major" is defined by . For historical compatibility, it is currently defined by as well, but we plan to remove this soon. To use "major",

Re: [Mesa-dev] [PATCH v4 1/6] glsl/linker: location aliasing requires types to have the same width

2019-03-20 Thread Timothy Arceri
On 21/3/19 2:07 am, Andres Gomez wrote: On Wed, 2019-03-20 at 16:46 +0200, Andres Gomez wrote: On Thu, 2019-03-21 at 00:20 +1100, Timothy Arceri wrote: On 20/3/19 9:31 pm, Andres Gomez wrote: On Wed, 2019-03-20 at 20:46 +1100, Timothy Arceri wrote: On 2/2/19 5:05 am, Andres Gomez wrote:

Re: [Mesa-dev] [PATCH v4 1/6] glsl/linker: location aliasing requires types to have the same width

2019-03-20 Thread Timothy Arceri
On 21/3/19 1:38 am, Andres Gomez wrote: On Wed, 2019-03-20 at 20:46 +1100, Timothy Arceri wrote: On 2/2/19 5:05 am, Andres Gomez wrote: From: Iago Toral Quiroga Regarding location aliasing requirements, the OpenGL spec says: "Further, when location aliasing, the aliases sharing the

Re: [Mesa-dev] [PATCH] st/nine: enable csmt per default on iris

2019-03-20 Thread Axel Davy
On 20/03/2019 21:38, Andre Heider wrote: iris is thread safe, enable csmt for a ~5% performace boost. Signed-off-by: Andre Heider --- src/gallium/state_trackers/nine/device9.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git

Re: [Mesa-dev] [PATCH] virgl: Use right key to insert resource to hash.

2019-03-20 Thread Chia-I Wu
On Mon, Mar 18, 2019 at 2:22 PM Lepton Wu wrote: > The old code could use gem name as key when inserting it to bo_handles > hash table while trying to remove it from hash table with bo_handle as > key in virgl_hw_res_destroy. This triggers use after free. Also, we > should only reuse resource

[Mesa-dev] [Bug 110211] If DESTDIR is set to an empty string, the dri drivers are not installed

2019-03-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110211 Dylan Baker changed: What|Removed |Added Resolution|--- |FIXED Status|ASSIGNED

Re: [Mesa-dev] [PATCH] virgl: close drm fd when destroying virgl screen.

2019-03-20 Thread Chia-I Wu
Reviewed-by: Chia-I Wu On Mon, Mar 18, 2019 at 4:40 PM Lepton Wu wrote: > This fd was create in virgl_drm_screen_create and should be closed > in virgl_drm_screen_destroy. > > Signed-off-by: Lepton Wu > --- > src/gallium/winsys/virgl/drm/virgl_drm_winsys.c | 1 + > 1 file changed, 1

Re: [Mesa-dev] [PATCH 5/8] ac/nir: implement 8-bit ssbo stores

2019-03-20 Thread Samuel Pitoiset
On 3/20/19 1:07 AM, Bas Nieuwenhuizen wrote: On Tue, Mar 19, 2019 at 9:28 AM Samuel Pitoiset wrote: From: Rhys Perry Signed-off-by: Rhys Perry --- src/amd/common/ac_nir_to_llvm.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/src/amd/common/ac_nir_to_llvm.c

Re: [Mesa-dev] [PATCH 0/8] radv: VK_KHR_8bit_storage

2019-03-20 Thread Bas Nieuwenhuizen
Reviewed-by: Bas Nieuwenhuizen for the series. On Tue, Mar 19, 2019 at 9:28 AM Samuel Pitoiset wrote: > > Hi, > > This series implements VK_KHR_8bit_storage for RADV. Original work > is from Rhys Perry, I did rebase, update some patches and test. > > Please review, > thanks! > > Rhys Perry

Re: [Mesa-dev] [PATCH] st/nine: enable csmt per default on iris

2019-03-20 Thread Kenneth Graunke
On Wednesday, March 20, 2019 1:38:40 PM PDT Andre Heider wrote: > iris is thread safe, enable csmt for a ~5% performace boost. > > Signed-off-by: Andre Heider > --- > src/gallium/state_trackers/nine/device9.c | 8 +--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git

[Mesa-dev] [PATCH] st/nine: enable csmt per default on iris

2019-03-20 Thread Andre Heider
iris is thread safe, enable csmt for a ~5% performace boost. Signed-off-by: Andre Heider --- src/gallium/state_trackers/nine/device9.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/src/gallium/state_trackers/nine/device9.c

Re: [Mesa-dev] [PATCH] gallium: Add PIPE_BARRIER_UPDATE_BUFFER and UPDATE_TEXTURE bits.

2019-03-20 Thread Kenneth Graunke
On Wednesday, March 20, 2019 6:37:07 AM PDT Ilia Mirkin wrote: > On Wed, Mar 6, 2019 at 3:32 AM Kenneth Graunke wrote: > > There are no nouveau changes in this patch, but that's only because none > > appeared to be necessary. Most drivers performed some kind of flush on > > any memory_barrier()

[Mesa-dev] [Bug 108841] [RADV] SPIRV's control flow attributes do not propagate to LLVM

2019-03-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108841 --- Comment #5 from Alex Smith --- Thanks for doing this. I'm out of the office this week so I can't get an example right now, will get one and test the MR once I'm back. -- You are receiving this mail because: You are the QA Contact for the

[Mesa-dev] [PATCH] vl/dri3: remove the wait before getting back buffer

2019-03-20 Thread Liu, Leo
The wait here is unnecessary since we got a pool of back buffers, and the wait for swap buffer will happen before the present pixmap, at the same time the previous back buffer will be put back to pool for reuse after the check for PresentIdleNotify event Signed-off-by: Leo Liu ---

[Mesa-dev] [Bug 110211] If DESTDIR is set to an empty string, the dri drivers are not installed

2019-03-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110211 Bug ID: 110211 Summary: If DESTDIR is set to an empty string, the dri drivers are not installed Product: Mesa Version: 19.0 Hardware: All OS: All

Re: [Mesa-dev] [PATCH v4 1/6] glsl/linker: location aliasing requires types to have the same width

2019-03-20 Thread Andres Gomez
On Wed, 2019-03-20 at 16:46 +0200, Andres Gomez wrote: > On Thu, 2019-03-21 at 00:20 +1100, Timothy Arceri wrote: > > On 20/3/19 9:31 pm, Andres Gomez wrote: > > > On Wed, 2019-03-20 at 20:46 +1100, Timothy Arceri wrote: > > > > On 2/2/19 5:05 am, Andres Gomez wrote: > > > > > From: Iago Toral

Re: [Mesa-dev] [PATCH] softpipe: fix texture view crashes

2019-03-20 Thread Brian Paul
On 03/19/2019 09:13 PM, Dave Airlie wrote: From: Dave Airlie I noticed we crashed piglit arb_texture_view-rendering-formats when run on softpipe. This fixes the clear tiles to use the surface format not the underlying storage format. This fixes a bunch of srgb piglits as well. ---

Re: [Mesa-dev] [PATCH v4 1/6] glsl/linker: location aliasing requires types to have the same width

2019-03-20 Thread Andres Gomez
On Thu, 2019-03-21 at 00:20 +1100, Timothy Arceri wrote: > On 20/3/19 9:31 pm, Andres Gomez wrote: > > On Wed, 2019-03-20 at 20:46 +1100, Timothy Arceri wrote: > > > On 2/2/19 5:05 am, Andres Gomez wrote: > > > > From: Iago Toral Quiroga > > > > > > > > Regarding location aliasing requirements,

Re: [Mesa-dev] [PATCH v4 1/6] glsl/linker: location aliasing requires types to have the same width

2019-03-20 Thread Andres Gomez
On Wed, 2019-03-20 at 20:46 +1100, Timothy Arceri wrote: > On 2/2/19 5:05 am, Andres Gomez wrote: > > From: Iago Toral Quiroga > > > > Regarding location aliasing requirements, the OpenGL spec says: > > > >"Further, when location aliasing, the aliases sharing the location > > must have

Re: [Mesa-dev] [PATCH] nir: Constant values are per-column not per-component

2019-03-20 Thread Karol Herbst
Reviewed-by: Karol Herbst On Wed, Mar 20, 2019 at 1:22 PM Lionel Landwerlin wrote: > > Reviewed-by: Lionel Landwerlin > > On 19/03/2019 19:15, Jason Ekstrand wrote: > > --- > > src/compiler/nir/nir.h | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git

Re: [Mesa-dev] [PATCH] gallium: Add PIPE_BARRIER_UPDATE_BUFFER and UPDATE_TEXTURE bits.

2019-03-20 Thread Ilia Mirkin
On Wed, Mar 6, 2019 at 3:32 AM Kenneth Graunke wrote: > > The glMemoryBarrier() function makes shader memory stores ordered with > respect to things specified by the given bits. Until now, st/mesa has > ignored GL_TEXTURE_UPDATE_BARRIER_BIT and GL_BUFFER_UPDATE_BARRIER_BIT, > saying that drivers

Re: [Mesa-dev] [PATCH v4 1/6] glsl/linker: location aliasing requires types to have the same width

2019-03-20 Thread Timothy Arceri
On 20/3/19 9:31 pm, Andres Gomez wrote: On Wed, 2019-03-20 at 20:46 +1100, Timothy Arceri wrote: On 2/2/19 5:05 am, Andres Gomez wrote: From: Iago Toral Quiroga Regarding location aliasing requirements, the OpenGL spec says: "Further, when location aliasing, the aliases sharing the

Re: [Mesa-dev] [PATCH 1/1] nir: add a pass that removes continue blocks

2019-03-20 Thread Timothy Arceri
On 20/3/19 9:41 pm, Samuel Pitoiset wrote: 28717 shaders in 14931 tests Totals: SGPRS: 1267317 -> 1267549 (0.02 %) VGPRS: 896876 -> 895920 (-0.11 %) Spilled SGPRs: 24701 -> 26367 (6.74 %) Code Size: 48379452 -> 48507880 (0.27 %) bytes Max Waves: 241159 -> 241190 (0.01 %) Totals from affected

Re: [Mesa-dev] [PATCH] nir: Constant values are per-column not per-component

2019-03-20 Thread Lionel Landwerlin
Reviewed-by: Lionel Landwerlin On 19/03/2019 19:15, Jason Ekstrand wrote: --- src/compiler/nir/nir.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/compiler/nir/nir.h b/src/compiler/nir/nir.h index 67304af1d64..e4f012809e5 100644 --- a/src/compiler/nir/nir.h +++

Re: [Mesa-dev] [PATCH 1/1] nir: add a pass that removes continue blocks

2019-03-20 Thread Samuel Pitoiset
On 3/20/19 11:47 AM, Timothy Arceri wrote: On 20/3/19 9:41 pm, Samuel Pitoiset wrote: 28717 shaders in 14931 tests Totals: SGPRS: 1267317 -> 1267549 (0.02 %) VGPRS: 896876 -> 895920 (-0.11 %) Spilled SGPRs: 24701 -> 26367 (6.74 %) Code Size: 48379452 -> 48507880 (0.27 %) bytes Max Waves:

Re: [Mesa-dev] [PATCH 1/1] nir: add a pass that removes continue blocks

2019-03-20 Thread Timothy Arceri
On 20/3/19 9:41 pm, Samuel Pitoiset wrote: 28717 shaders in 14931 tests Totals: SGPRS: 1267317 -> 1267549 (0.02 %) VGPRS: 896876 -> 895920 (-0.11 %) Spilled SGPRs: 24701 -> 26367 (6.74 %) Code Size: 48379452 -> 48507880 (0.27 %) bytes Max Waves: 241159 -> 241190 (0.01 %) Totals from affected

[Mesa-dev] [PATCH 0/1] nir: new pass that removes continue blocks (+10% FPS with Doom on RADV)

2019-03-20 Thread Samuel Pitoiset
Hi, I wrote that NIR pass few weeks ago when I was trying to improve performance with Shadow Of The Tomb Raider, which has a bunch of complex loops. While this pass doesn't really improve SotTR, it gives a huge boost with DOOM (and probably DOOM VFR), +10% FPS on my Vega 56. I have no ideas why

[Mesa-dev] [PATCH 1/1] nir: add a pass that removes continue blocks

2019-03-20 Thread Samuel Pitoiset
28717 shaders in 14931 tests Totals: SGPRS: 1267317 -> 1267549 (0.02 %) VGPRS: 896876 -> 895920 (-0.11 %) Spilled SGPRs: 24701 -> 26367 (6.74 %) Code Size: 48379452 -> 48507880 (0.27 %) bytes Max Waves: 241159 -> 241190 (0.01 %) Totals from affected shaders: SGPRS: 23584 -> 23816 (0.98 %) VGPRS:

Re: [Mesa-dev] [PATCH v4 1/6] glsl/linker: location aliasing requires types to have the same width

2019-03-20 Thread Andres Gomez
On Wed, 2019-03-20 at 20:46 +1100, Timothy Arceri wrote: > On 2/2/19 5:05 am, Andres Gomez wrote: > > From: Iago Toral Quiroga > > > > Regarding location aliasing requirements, the OpenGL spec says: > > > >"Further, when location aliasing, the aliases sharing the location > > must have

Re: [Mesa-dev] [PATCH v4 1/6] glsl/linker: location aliasing requires types to have the same width

2019-03-20 Thread Timothy Arceri
On 2/2/19 5:05 am, Andres Gomez wrote: From: Iago Toral Quiroga Regarding location aliasing requirements, the OpenGL spec says: "Further, when location aliasing, the aliases sharing the location must have the same underlying numerical type (floating-point or integer)." Khronos