Re: [Mesa-dev] [PATCH v2 8/8] egl: add EGL_platform_device support

2019-04-02 Thread Mathias Fröhlich
Marek, On Tuesday, 2 April 2019 23:07:50 CEST Marek Olšák wrote: > Do you have a branch with patch 7/8 and 8/8? I'm interested in > EGL_EXT_platform_device on radeonsi. You can take a look at the egl-device-4 branch on https://gitlab.freedesktop.org/frohlich/mesa.git I pushed a rebased and

[Mesa-dev] [PATCH 1/3] panfrost: Cleanup some indirection in pan_resource

2019-04-02 Thread Alyssa Rosenzweig
Signed-off-by: Alyssa Rosenzweig --- src/gallium/drivers/panfrost/pan_resource.c | 45 ++--- 1 file changed, 21 insertions(+), 24 deletions(-) diff --git a/src/gallium/drivers/panfrost/pan_resource.c b/src/gallium/drivers/panfrost/pan_resource.c index 3d93fd0dc4d..f7df1353d68

[Mesa-dev] [PATCH 2/3] panfrost: Respect box->width in tiled stores

2019-04-02 Thread Alyssa Rosenzweig
This fixes a regression uploading partial tiled textures introduced sometime during the cubemap series. Signed-off-by: Alyssa Rosenzweig --- src/gallium/drivers/panfrost/pan_resource.c | 4 +++- src/gallium/drivers/panfrost/pan_swizzle.c | 4 ++-- src/gallium/drivers/panfrost/pan_swizzle.h |

[Mesa-dev] [PATCH 3/3] panfrost: Size tiled temp buffers correctly

2019-04-02 Thread Alyssa Rosenzweig
This should lower transient memory usage and improve performance slightly (due to less memory to malloc/free, better cache locality, etc). Signed-off-by: Alyssa Rosenzweig --- src/gallium/drivers/panfrost/pan_resource.c | 12 +++- src/gallium/drivers/panfrost/pan_swizzle.c | 7 +--

[Mesa-dev] [PATCH 0/3] Cleanup tiled texture upload

2019-04-02 Thread Alyssa Rosenzweig
The state management for tiled textures was questionable to begin with; the cubemap changes transformed it to something only half-way reasonable, unwittingly regressing SuperTuxKart (among others). This change set finalizes the tiled texture refactor, fixing STK. Alyssa Rosenzweig (3):

[Mesa-dev] [PATCH v3] nir: propagate known constant values into the if-then branch

2019-04-02 Thread Timothy Arceri
Helps Max Waves / VGPR use in a bunch of Unigine Heaven shaders. shader-db results radeonsi (VEGA): Totals from affected shaders: SGPRS: 5505440 -> 5505872 (0.01 %) VGPRS: 3077520 -> 3077296 (-0.01 %) Spilled SGPRs: 39032 -> 39030 (-0.01 %) Spilled VGPRs: 16326 -> 16326 (0.00 %) Private memory

Re: [Mesa-dev] [PATCH] panfrost: Remove support for legacy kernels

2019-04-02 Thread Tomeu Vizoso
On 4/1/19 2:16 AM, Alyssa Rosenzweig wrote: Previously, there was minimal support for interoperating with legacy kernels (reusing kernel modules originally designed for proprietary legacy userspaces, rather than for upstream-friendly free software stacks). Now that the Panfrost kernel is

[Mesa-dev] [PATCH 2/2] panfrost: Implement system values

2019-04-02 Thread Alyssa Rosenzweig
This patch implements system values via specially-crafted uniforms. While we previously had an ad hoc system for passing the viewport into the vertex shader, this commit generalizes the system to allow for arbitrary system values to be added to both shader stages. While we're at it, we clean up

[Mesa-dev] [PATCH 0/2] Implement (viewport) system values

2019-04-02 Thread Alyssa Rosenzweig
This patch set implements the infrastructure for piping system values through Panfrost, replacing the prior brittle system of magic uniform offsets. This infrastructure is used to implement the vertex shader viewport transformation, which will soon be shared with lima. Alyssa Rosenzweig (2):

[Mesa-dev] [PATCH 1/2] nir: Add "viewport vector" system values

2019-04-02 Thread Alyssa Rosenzweig
While a partial set of viewport system values exist, these are scalar values, which is a poor fit for viewport transformations on vector ISAs like Midgard (where the vec3 values for scale and offset each need to be coherent in a vec4 uniform slot to take advantage of vectorized transform math).

[Mesa-dev] [PATCH] nir: disable opt_for_known_values() for non scalar constants

2019-04-02 Thread Timothy Arceri
We don't handle swizzles and non-scalar backends don't split these constants so we need to skip these too. Fixes: 4218b6422cf1 ("nir: propagate known constant values into the if-then branch") https://bugs.freedesktop.org/show_bug.cgi?id=110311 --- src/compiler/nir/nir_opt_if.c | 3 ++- 1 file

Re: [Mesa-dev] new dispatch generator broke with Marek's parallel compile commit

2019-04-02 Thread Dave Airlie
On Wed, 3 Apr 2019 at 04:32, Emil Velikov wrote: > > On Tue, 2 Apr 2019 at 12:43, Emil Velikov wrote: > > > > On Tue, 2 Apr 2019 at 04:55, Dave Airlie wrote: > > > > > > On Tue, 2 Apr 2019 at 11:24, Dave Airlie wrote: > > > > > > > > Marek's commit to add ARB_parallel_shader_compile broke some

Re: [Mesa-dev] [PATCH] virgl: close drm fd when destroying virgl screen.

2019-04-02 Thread Gurchetan Singh
On Mon, Apr 1, 2019 at 12:39 PM Lepton Wu wrote: > > On Wed, Mar 20, 2019 at 2:26 PM Chia-I Wu wrote: > >> Reviewed-by: Chia-I Wu >> > Anything else to need for merging this? I think this is a straightforward > leaking fix. > Merged. Thanks for the patch and review! > > >> >> On Mon, Mar

Re: [Mesa-dev] [PATCH v2 8/8] egl: add EGL_platform_device support

2019-04-02 Thread Marek Olšák
Do you have a branch with patch 7/8 and 8/8? I'm interested in EGL_EXT_platform_device on radeonsi. Thanks, Marek On Wed, Oct 3, 2018 at 4:36 AM Mathias Fröhlich wrote: > Hi Emil, > > Ok, thanks for picking that up. > > On Tuesday, 2 October 2018 12:23:30 CEST Emil Velikov wrote: > > On Thu,

[Mesa-dev] [Bug 110310] glXQueryServerString is weirdly restrictive

2019-04-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110310 Bug ID: 110310 Summary: glXQueryServerString is weirdly restrictive Product: Mesa Version: unspecified Hardware: Other OS: All Status: NEW Severity:

Re: [Mesa-dev] [ANNOUNCE] Mesa 18.3.6 release candidate

2019-04-02 Thread Matt Turner
On Mon, Apr 1, 2019 at 5:18 AM Emil Velikov wrote: > For anyone wondering about the delay: > > We have been using LunarG OpenGL and Vulkan testing service to > validate Mesa releases since day 1. > > Unfortunately, they've been experiencing some issues which we're > expecting to be resolved any

Re: [Mesa-dev] new dispatch generator broke with Marek's parallel compile commit

2019-04-02 Thread Ian Romanick
On 4/2/19 4:43 AM, Emil Velikov wrote: > On Tue, 2 Apr 2019 at 04:55, Dave Airlie wrote: >> >> On Tue, 2 Apr 2019 at 11:24, Dave Airlie wrote: >>> >>> Marek's commit to add ARB_parallel_shader_compile broke some es1 tests >>> in the Intel CI. >>> >>> It appears the whatever generates the es1api

[Mesa-dev] [Bug 109929] tgsi_to_nir.c:2111: undefined reference to `gl_nir_lower_samplers_as_deref'

2019-04-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109929 --- Comment #15 from Timur Kristóf --- As discussed with Jan and Jason on IRC, the proper solution will be to attempt to refactor gl_nir_lower_samplers and gl_nir_lower_samplers_as_deref in a way that separates the GLSL specific code. Then

Re: [Mesa-dev] Move adriconf to mesa repositories

2019-04-02 Thread Jean Hertel
Hey Emil, You also showed interest in this project in the past. Any thoughts about moving it to mesa gitlab? Kind Regards, Jean Hertel ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] new dispatch generator broke with Marek's parallel compile commit

2019-04-02 Thread Emil Velikov
On Tue, 2 Apr 2019 at 12:43, Emil Velikov wrote: > > On Tue, 2 Apr 2019 at 04:55, Dave Airlie wrote: > > > > On Tue, 2 Apr 2019 at 11:24, Dave Airlie wrote: > > > > > > Marek's commit to add ARB_parallel_shader_compile broke some es1 tests > > > in the Intel CI. > > > > > > It appears the

[Mesa-dev] [PATCH 3/3] gallium/auxiliary/vl: Add barrier/unbind after compute shader launch.

2019-04-02 Thread Zhu, James
Add memory barrier sync and unbind resource after launch will enhance the robustness. Signed-off-by: James Zhu --- src/gallium/auxiliary/vl/vl_compositor_cs.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/src/gallium/auxiliary/vl/vl_compositor_cs.c

[Mesa-dev] [PATCH 2/3] gallium/auxiliary/vl: Fixed blank issue with compute shader

2019-04-02 Thread Zhu, James
Multiple init buffer within one open instance will cause blank issue. Updating viewport per frame will fix this issue. Signed-off-by: James Zhu Tested-by: Bruno Milreu --- src/gallium/auxiliary/vl/vl_compositor_cs.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git

[Mesa-dev] [PATCH 1/3] gallium/auxiliary/vl: Fixed blur issue with weave compute shader

2019-04-02 Thread Zhu, James
Correct wrong interpolatation with top/bottom row which caused blur issue. Signed-off-by: James Zhu Tested-by: Bruno Milreu --- src/gallium/auxiliary/vl/vl_compositor_cs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/auxiliary/vl/vl_compositor_cs.c

Re: [Mesa-dev] [PATCH] mesa gallium: use compute shaders for vaapi blit

2019-04-02 Thread Eric Anholt
Ilia Mirkin writes: > Shouldn't this sort of decision be left up to the driver? If the > driver would like to use CS for blits, fine, but why not let it blit > in the most optimal way possible and force it to use a compute shader? Yeah, commit messages require an explanation of why a change is

Re: [Mesa-dev] New JIT Features in LLVM

2019-04-02 Thread preejackie
Hi all, Just following up on this request, Feel free to reply On 02/04/19 12:51 AM, preejackie wrote: Hi I'm Praveen Velliengiri, student from India. I'm working on developing a Speculative compilation support in LLVM ORC JIT Infrastructure. As LLVM ORC supports compiling in multiple

Re: [Mesa-dev] [PATCH] mesa gallium: use compute shaders for vaapi blit

2019-04-02 Thread Ilia Mirkin
Shouldn't this sort of decision be left up to the driver? If the driver would like to use CS for blits, fine, but why not let it blit in the most optimal way possible and force it to use a compute shader? On Tue, Apr 2, 2019 at 1:44 PM Jiang, Sonny wrote: > > Signed-off-by: Sonny Jiang > --- >

[Mesa-dev] [PATCH] mesa gallium: use compute shaders for vaapi blit

2019-04-02 Thread Jiang, Sonny
Signed-off-by: Sonny Jiang --- src/gallium/auxiliary/Makefile.sources | 2 + src/gallium/auxiliary/util/u_compute.c | 165 + src/gallium/auxiliary/util/u_compute.h | 44 ++ src/gallium/state_trackers/va/context.c| 2 +

[Mesa-dev] [Bug 87738] [OpenCL] Please add Image support

2019-04-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=87738 --- Comment #5 from smt --- Is there any progress at all towards this? I feel like it would really improve Linux use case for some of us using software like Darktable and whatever other software could possibly use this, I'm still unable to use

Re: [Mesa-dev] [PATCH] docs: Fix 19.0.x version numbers

2019-04-02 Thread Dylan Baker
Quoting Guido Günther (2019-04-01 08:58:24) > The list has 19.0.2 twice. > > Signed-off-by: Guido Günther > --- > docs/release-calendar.html | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/docs/release-calendar.html b/docs/release-calendar.html > index

[Mesa-dev] [Bug 110253] glBlitFramebuffer fails on MSAA fbo source.

2019-04-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110253 --- Comment #1 from Bruce Cherniak --- Thank you for reporting this bug and a possible solution. We will investigate. -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the

[Mesa-dev] [PATCH v4 1/2] egl: introduce a log level getter function

2019-04-02 Thread Silvestrs Timofejevs
Being able to retrieve the log level can be useful to enable/disable debug code. The alternative, which is calling 'getenv' function every time to retrieve the log level, is more "expensive". Signed-off-by: Silvestrs Timofejevs Reviewed-by: Eric Engestrom --- src/egl/main/egllog.c | 9

[Mesa-dev] [PATCH v4 2/2] egl: add config debug printout (v4)

2019-04-02 Thread Silvestrs Timofejevs
Feature to print out EGL returned configs for debug purposes. 'eglChooseConfig' and 'eglGetConfigs' debug information printout is enabled when the log level equals '_EGL_DEBUG'. The configs are printed, and if any of them are "chosen" they are marked with their index in the chosen configs array.

[Mesa-dev] debug feature to dump "get configs" and "chosen configs" (v4)

2019-04-02 Thread Silvestrs Timofejevs
This patch series provides an easy way to see what configs have been returned by the 'eglGetConfigs' and 'eglChooseConfig' functions, and give an overview of config attributes. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org

Re: [Mesa-dev] [PATCH v2 4/8] gallium/u_vbuf: export u_vbuf_get_minmax_index

2019-04-02 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Fri, Mar 22, 2019 at 10:30 AM Qiang Yu wrote: > This helper function can be used by driver which > always need min/max index. > > Signed-off-by: Qiang Yu > --- > src/gallium/auxiliary/util/u_vbuf.c | 7 +++ > src/gallium/auxiliary/util/u_vbuf.h | 3 +++

Re: [Mesa-dev] [PATCH 4/9] gallium: add a cap to force compute minmax indices

2019-04-02 Thread Marek Olšák
On Fri, Mar 15, 2019 at 9:30 PM Qiang Yu wrote: > From: Erico Nunes > > pipe_draw_info has min_index and max_index fields that can be useful in > indexed drawing, however gallium may decide to not compute them in some > cases to avoid impacting performance if the driver won't need them. >

Re: [Mesa-dev] [PATCH 1/2] radeonsi: always use compute rings for clover on CI and newer (v2)

2019-04-02 Thread Michel Dänzer
On 2019-04-02 2:57 p.m., Marek Olšák wrote: > On Tue, Apr 2, 2019 at 4:57 AM Michel Dänzer wrote: >> On 2019-04-02 12:39 a.m., Marek Olšák wrote: >>> On Mon, Apr 1, 2019 at 1:28 PM Jan Vesely >> wrote: On Mon, 2019-04-01 at 12:30 -0400, Marek Olšák wrote: > Does the attached patch fix

[Mesa-dev] [Bug 99553] Tracker bug for runnning OpenCL applications on Clover

2019-04-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99553 Bug 99553 depends on bug 110045, which changed state. Bug 110045 Summary: [radeonsi][clover][regression][bisected] cl-api-enqueue-copy-buffer hangs on radeonsi https://bugs.freedesktop.org/show_bug.cgi?id=110045 What|Removed

Re: [Mesa-dev] [PATCH 1/2] radeonsi: always use compute rings for clover on CI and newer (v2)

2019-04-02 Thread Marek Olšák
On Tue, Apr 2, 2019 at 4:57 AM Michel Dänzer wrote: > On 2019-04-02 12:39 a.m., Marek Olšák wrote: > > On Mon, Apr 1, 2019 at 1:28 PM Jan Vesely > wrote: > >> On Mon, 2019-04-01 at 12:30 -0400, Marek Olšák wrote: > >>> Does the attached patch fix the copy-buffer test? > >> > >> it does thanks.

Re: [Mesa-dev] [PATCH] radeonsi: don't use PFP_SYNC_ME with compute-only contexts

2019-04-02 Thread Dieter Nützel
Tested-by: Dieter Nützel For the first time since ages no horizontal line corruption with old luxmark-linux64-v2.0 (LuxBall e.g. HDR) on RX580. Dieter Am 02.04.2019 00:37, schrieb Marek Olšák: From: Marek Olšák Fixes: a1378639ab1 "radeonsi: always use compute rings for clover on CI and

Re: [Mesa-dev] new dispatch generator broke with Marek's parallel compile commit

2019-04-02 Thread Emil Velikov
On Tue, 2 Apr 2019 at 04:55, Dave Airlie wrote: > > On Tue, 2 Apr 2019 at 11:24, Dave Airlie wrote: > > > > Marek's commit to add ARB_parallel_shader_compile broke some es1 tests > > in the Intel CI. > > > > It appears the whatever generates the es1api isn't consistent, for > > example

[Mesa-dev] [Bug 110301] mesa-git reports Vulkan 1.1.90

2019-04-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110301 Eric Engestrom changed: What|Removed |Added Resolution|--- |NOTABUG Status|NEW

Re: [Mesa-dev] [PATCH 2/2] etnaviv: flush all pending contexts when accessing a resource with the CPU

2019-04-02 Thread Guido Günther
Hi Lucas, On Wed, Mar 27, 2019 at 12:22:58PM +0100, Lucas Stach wrote: > When setting up a transfer to a resource, all contexts where the resource > is pending must be flushed. Otherwise a write transfer might be started > in the current context before all contexts that access the resource in >

Re: [Mesa-dev] [PATCH 1/2] radeonsi: always use compute rings for clover on CI and newer (v2)

2019-04-02 Thread Michel Dänzer
On 2019-04-02 12:39 a.m., Marek Olšák wrote: > On Mon, Apr 1, 2019 at 1:28 PM Jan Vesely wrote: >> On Mon, 2019-04-01 at 12:30 -0400, Marek Olšák wrote: >>> Does the attached patch fix the copy-buffer test? >> >> it does thanks. >> Won't the compute only context still need some synchronization?

Re: [Mesa-dev] Move adriconf to mesa repositories

2019-04-02 Thread Daniel Stone
Hi, On Tue, 2 Apr 2019 at 00:19, Rob Clark wrote: > On Mon, Apr 1, 2019 at 1:55 PM Jean Hertel wrote: > > As we have spoken already in the past, I have the intention to move > > adriconf under the mesa project umbrella, as an official tool for > > configuring DRI options. > > I would like to

Re: [Mesa-dev] [PATCH] radeonsi: don't use PFP_SYNC_ME with compute-only contexts

2019-04-02 Thread Jan Vesely
On Mon, 2019-04-01 at 18:37 -0400, Marek Olšák wrote: > From: Marek Olšák Tested-by: Jan Vesely Can you add a note along the lines; "compute rings don't have PFP" or anything more descriptive on the commit message? thanks, Jan > > Fixes: a1378639ab1 "radeonsi: always use compute rings for

Re: [Mesa-dev] Commit 'gallium: fix autotools build of pipe_msm.la' broke Clover - bisected

2019-04-02 Thread Jan Vesely
On Tue, 2019-04-02 at 02:37 +0200, Dieter Nützel wrote: > Am 01.04.2019 07:43, schrieb Jan Vesely: > > Hi, > > > > On Mon, 2019-04-01 at 06:24 +0200, Dieter Nützel wrote: > > > Hello, > > > > > > commit #356ec7a2196 'gallium: fix autotools build of pipe_msm.la' > > > broke > > > Clover. > > >

Re: [Mesa-dev] [PATCH] radeonsi: don't use PFP_SYNC_ME with compute-only contexts

2019-04-02 Thread Samuel Pitoiset
Reviewed-by: Samuel Pitoiset On 4/2/19 12:37 AM, Marek Olšák wrote: From: Marek Olšák Fixes: a1378639ab1 "radeonsi: always use compute rings for clover on CI and newer (v2)" --- src/gallium/drivers/radeonsi/si_cp_dma.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[Mesa-dev] [Bug 109939] After upgrade mesa to 19.0.0 stop working the game Rise of the Tomb Raider

2019-04-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109939 --- Comment #25 from mikhail.v.gavri...@gmail.com --- Alex, can you look please at this issue: https://bugzilla.redhat.com/show_bug.cgi?id=1694938 There about warning "Current CPU governor may impact performance" even when package gamemode is