Re: [Mesa-dev] [PATCH v2] virgl: Use right key to insert resource to hash.

2019-04-08 Thread Dave Airlie
https://gitlab.freedesktop.org/mesa/mesa/merge_requests/605 Can you try that please and maybe discuss there as well? I cleaned up the code a bit and realigned it with the radeon code. Dave. On Tue, 9 Apr 2019 at 04:44, Chia-I Wu wrote: > > > > On Mon, Apr 8, 2019 at 11:24 AM Lepton Wu wrote:

Re: [Mesa-dev] [PATCH 2/2] radv: allow to force enable vsync with RADV_VSYNC=1

2019-04-08 Thread Jason Ekstrand
Why not just do this in a way that common to the two drivers? Forcing FIFO and MAILBOX both seem useful. For that matter, why not just MESA_VK_WSI_PRESENT_MODE=FIFO/mailbox/immediate? On April 8, 2019 13:39:20 Samuel Pitoiset wrote: Bugzilla:

Re: [Mesa-dev] [PATCH] gallium: Add support for frame_cropping_flag of VAEncSequenceParameterBufferH264

2019-04-08 Thread Sahu, Satyajit
On 4/9/2019 12:34 AM, Liu, Leo wrote: > On 4/8/19 1:17 AM, Sahu, Satyajit wrote: >> From: suresh guttula >> >> This patch will add support for frame_cropping when the input size is not >> matched with aligned size. Currently vaapi driver ignores frame cropping >> values provided by client. This

[Mesa-dev] [Bug 110350] DOOM 2016 crash + severe artifacting on RADV + Vega VII

2019-04-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110350 --- Comment #3 from Thomas Crider --- https://youtu.be/9dtlKTMGqTE game didn't crash this time, and at least i was able to capture it -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the

[Mesa-dev] [Bug 110337] Mesa 19.0.0(1)

2019-04-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110337 Berg changed: What|Removed |Added QA Contact|dri-devel@lists.freedesktop |mesa-dev@lists.freedesktop.

Re: [Mesa-dev] [PATCH 0/4] RadeonSI: Upload constants to VRAM via SDMA

2019-04-08 Thread Dieter Nützel
Am 09.04.2019 02:42, schrieb Marek Olšák: I'm pretty sure I merged this series in February. Marek Yes, of course you did (with my tb), but I meant... (see below) On Mon, Apr 8, 2019 at 6:10 PM Dieter Nützel wrote: Maybe someone working on this, too. I'm feeling fine again after a short

Re: [Mesa-dev] [PATCH] glsl: fix shader_storage_blocks_write_access for SSBO block arrays

2019-04-08 Thread Timothy Arceri
Reviewed-by: Timothy Arceri On 9/4/19 7:21 am, Marek Olšák wrote: From: Marek Olšák CTS: GL45-CTS.compute_shader.resources-max Fixes: 4e1e8f684bf "glsl: remember which SSBOs are not read-only and pass it to gallium" --- src/compiler/glsl/link_uniforms.cpp | 8 ++-- 1 file changed, 6

[Mesa-dev] [Bug 110345] Unrecoverable GPU crash with DiRT 4

2019-04-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110345 Timothy Arceri changed: What|Removed |Added Assignee|dri-devel@lists.freedesktop |mesa-dev@lists.freedesktop.

Re: [Mesa-dev] [PATCH 0/4] RadeonSI: Upload constants to VRAM via SDMA

2019-04-08 Thread Marek Olšák
I'm pretty sure I merged this series in February. Marek On Mon, Apr 8, 2019 at 6:10 PM Dieter Nützel wrote: > Maybe someone working on this, too. > > I'm feeling fine again after a short 'trip' into the hospital...;-) > > Dieter > > Am 26.02.2019 07:36, schrieb Marek Olšák: > > We need to

Re: [Mesa-dev] [PATCH 00/26] RadeonSI: Primitive culling with async compute

2019-04-08 Thread Marek Olšák
Hi Dieter, The latest version is on gitlab as a merge request. Marek On Mon, Apr 8, 2019 at 6:06 PM Dieter Nützel wrote: > After you've recuperated from hopefully GREAT vacation, > > is it time? ;-) > > Greetings, > Dieter > > Am 26.02.2019 03:31, schrieb Dieter Nützel: > > Hello Marek, > > >

Re: [Mesa-dev] gitlab: Let's delete a buildsystem

2019-04-08 Thread Jan Vesely
Hi, is there a release with that change planned any time soon? thanks, Jan On Mon, Apr 8, 2019 at 4:23 PM Dylan Baker wrote: > > As per the discussion last time around, the last feature meson needed to grow > to > be able to remove autotools was support for remembering PKG_CONFIG_PATH, since

[Mesa-dev] [Bug 109615] 19.0.0_rc4 fails u_format_test on ppc64

2019-04-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109615 A. Wilcox changed: What|Removed |Added CC||awil...@adelielinux.org

[Mesa-dev] [Bug 109615] 19.0.0_rc4 fails u_format_test on ppc64

2019-04-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109615 --- Comment #8 from A. Wilcox --- Is this an actual endian bug in Mesa, or do the test constants need to be adjusted based on byte order? -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the

Re: [Mesa-dev] [PATCH] intel/compiler/icl: Use tcs barrier id bits 24:30 instead of 24:27

2019-04-08 Thread Anuj Phogat
On Wed, Mar 27, 2019 at 9:47 AM Topi Pohjolainen wrote: > > Similarly to 1cc17fb731466c68586915acbb916586457b19bc > > Fixes gpu hangs with dEQP-VK.tessellation.shader_input_output.barrier > > CC: Anuj Phogat > CC: Clayton Craft > Signed-off-by: Topi Pohjolainen > --- >

[Mesa-dev] [Bug 109615] 19.0.0_rc4 fails u_format_test on ppc64

2019-04-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109615 --- Comment #7 from Matt Turner --- No surprise: it's endianness dependent. Passes on little endian; fails on big endian. -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the

Re: [Mesa-dev] [PATCH 0/4] RadeonSI: Upload constants to VRAM via SDMA

2019-04-08 Thread Dieter Nützel
Maybe someone working on this, too. I'm feeling fine again after a short 'trip' into the hospital...;-) Dieter Am 26.02.2019 07:36, schrieb Marek Olšák: We need to extend the CS ioctl to allow submitting 2 command buffers at the same time. Marek On Mon, Feb 25, 2019, 10:06 PM Dieter Nützel

Re: [Mesa-dev] [PATCH 00/26] RadeonSI: Primitive culling with async compute

2019-04-08 Thread Dieter Nützel
After you've recuperated from hopefully GREAT vacation, is it time? ;-) Greetings, Dieter Am 26.02.2019 03:31, schrieb Dieter Nützel: Hello Marek, do you plan to commit or rebase both set? Dieter Am 14.02.2019 07:29, schrieb Marek Olšák: I have some fixes for Sea Islands that improve

Re: [Mesa-dev] [PATCH] radeonsi: fix a crash when unbinding sampler states

2019-04-08 Thread Dieter Nützel
SOLVED it. Thanks to both of you! Dieter Am 08.04.2019 21:12, schrieb James Zhu: This patch is Acked-by: James Zhu On 2019-04-08 3:02 p.m., Marek Olšák wrote: On Mon, Apr 8, 2019 at 2:45 PM James Zhu wrote: On 2019-04-08 2:39 p.m., Marek Olšák wrote: On Mon, Apr 8, 2019 at 2:33 PM

Re: [Mesa-dev] [PATCH 2/2] meson: upgrade minimum meson version

2019-04-08 Thread Dylan Baker
It would be nice if people wouldn't try to build bleeding edge mesa on a 12 year old distro :D. Unfortunately as Eero ppoints out they do. I'd like to bump the meson version to 0.47 in the future for some of the other features it adds (automatically figuring out the dependencies for pkg-config,

[Mesa-dev] [PATCH] glsl: fix shader_storage_blocks_write_access for SSBO block arrays

2019-04-08 Thread Marek Olšák
From: Marek Olšák CTS: GL45-CTS.compute_shader.resources-max Fixes: 4e1e8f684bf "glsl: remember which SSBOs are not read-only and pass it to gallium" --- src/compiler/glsl/link_uniforms.cpp | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git

Re: [Mesa-dev] [PATCH] nir/radv: remove restrictions on opt_if_loop_last_continue()

2019-04-08 Thread Samuel Pitoiset
Acked-by: Samuel Pitoiset On 4/8/19 12:13 PM, Timothy Arceri wrote: When I implemented opt_if_loop_last_continue() I had restricted this pass from moving other if-statements inside the branch opposite the continue. At the time it was causing a bunch of spilling in shader-db for i965. However

[Mesa-dev] [PATCH 1/2] wsi: add an option that allows to force enable vsync at device creation

2019-04-08 Thread Samuel Pitoiset
When the WSI device wants to enable vsync, it just switches to the FIFO presentation mode. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_wsi.c | 2 +- src/freedreno/vulkan/tu_wsi.c | 2 +- src/intel/vulkan/anv_wsi.c | 2 +- src/vulkan/wsi/wsi_common.c |

[Mesa-dev] [PATCH 2/2] radv: allow to force enable vsync with RADV_VSYNC=1

2019-04-08 Thread Samuel Pitoiset
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107391 Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_wsi.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/amd/vulkan/radv_wsi.c b/src/amd/vulkan/radv_wsi.c index 2fd07447668..7651043b2b2 100644 ---

[Mesa-dev] gitlab: Let's delete a buildsystem

2019-04-08 Thread Dylan Baker
As per the discussion last time around, the last feature meson needed to grow to be able to remove autotools was support for remembering PKG_CONFIG_PATH, since that has landed: https://github.com/mesonbuild/meson/pull/4931, so I'm sending this out again. The gitlab link for the PR is here:

[Mesa-dev] [Bug 110350] DOOM 2016 crash + severe artifacting on RADV + Vega VII

2019-04-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110350 --- Comment #2 from Thomas Crider --- Sure, I just started a new campaign and loaded into the first mission. no less than about 15-30 seconds in it immediately went black/polygony, then crashed. I'll see if I can record it later tonight. My

[Mesa-dev] [Bug 110349] radv: Dragon Quest XI (DXVK) has a graphical glitch (regression, bisected)

2019-04-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110349 Samuel Pitoiset changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

Re: [Mesa-dev] [PATCH] radeonsi: fix a crash when unbinding sampler states

2019-04-08 Thread James Zhu
This patch is Acked-by: James Zhu On 2019-04-08 3:02 p.m., Marek Olšák wrote: On Mon, Apr 8, 2019 at 2:45 PM James Zhu mailto:jam...@amd.com>> wrote: On 2019-04-08 2:39 p.m., Marek Olšák wrote: On Mon, Apr 8, 2019 at 2:33 PM James Zhu mailto:jam...@amd.com>> wrote:

Re: [Mesa-dev] [PATCH] gallium: Add support for frame_cropping_flag of VAEncSequenceParameterBufferH264

2019-04-08 Thread Liu, Leo
On 4/8/19 1:17 AM, Sahu, Satyajit wrote: > From: suresh guttula > > This patch will add support for frame_cropping when the input size is not > matched with aligned size. Currently vaapi driver ignores frame cropping > values provided by client. This change will update SPS nalu with proper >

Re: [Mesa-dev] [PATCH] radeonsi: fix a crash when unbinding sampler states

2019-04-08 Thread Marek Olšák
On Mon, Apr 8, 2019 at 2:45 PM James Zhu wrote: > > On 2019-04-08 2:39 p.m., Marek Olšák wrote: > > On Mon, Apr 8, 2019 at 2:33 PM James Zhu wrote: > >> >> On 2019-04-08 2:25 p.m., Marek Olšák wrote: >> > From: Marek Olšák >> > >> > --- >> > src/gallium/drivers/radeonsi/si_descriptors.c | 2

[Mesa-dev] [Bug 109183] GPU Hangs randomly with GTA V

2019-04-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109183 --- Comment #5 from Samuel Pitoiset --- Do you have something in dmesg when it freezes? -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the

Re: [Mesa-dev] [PATCH v7 28/35] intel/compiler: implement SIMD16 restrictions for mixed-float instructions

2019-04-08 Thread Francisco Jerez
"Juan A. Suarez Romero" writes: > From: Iago Toral Quiroga > > v2: f32to16/f16to32 can use a :W destination (Curro) > --- > src/intel/compiler/brw_fs.cpp | 71 +++ > 1 file changed, 71 insertions(+) > > diff --git a/src/intel/compiler/brw_fs.cpp

Re: [Mesa-dev] [PATCH] radeonsi: fix a crash when unbinding sampler states

2019-04-08 Thread James Zhu
On 2019-04-08 2:39 p.m., Marek Olšák wrote: On Mon, Apr 8, 2019 at 2:33 PM James Zhu mailto:jam...@amd.com>> wrote: On 2019-04-08 2:25 p.m., Marek Olšák wrote: > From: Marek Olšák mailto:marek.ol...@amd.com>> > > --- > src/gallium/drivers/radeonsi/si_descriptors.c | 2 +- > 1 file changed, 1

Re: [Mesa-dev] [PATCH v2] virgl: Use right key to insert resource to hash.

2019-04-08 Thread Chia-I Wu
On Mon, Apr 8, 2019 at 11:24 AM Lepton Wu wrote: > On Mon, Apr 8, 2019 at 11:10 AM Chia-I Wu wrote: > > > > > > > > On Mon, Apr 8, 2019 at 9:34 AM Lepton Wu wrote: > >> > >> The old code could use gem name as key when inserting it to bo_handles > >> hash table while trying to remove it from

Re: [Mesa-dev] [PATCH] radeonsi: fix a crash when unbinding sampler states

2019-04-08 Thread Marek Olšák
On Mon, Apr 8, 2019 at 2:33 PM James Zhu wrote: > > On 2019-04-08 2:25 p.m., Marek Olšák wrote: > > From: Marek Olšák > > > > --- > > src/gallium/drivers/radeonsi/si_descriptors.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git

[Mesa-dev] [PATCH] st/va: reverse qt matrix back to its original order

2019-04-08 Thread boyuan.zhang
From: Boyuan Zhang The quantiser matrix that VAAPI provides has been applied with inverse z-scan. However, what we expect in MPEG2 picture description is the original order. Therefore, we need to reverse it back to its original order. Bugzilla:

Re: [Mesa-dev] [PATCH] radeonsi: fix a crash when unbinding sampler states

2019-04-08 Thread James Zhu
On 2019-04-08 2:25 p.m., Marek Olšák wrote: > From: Marek Olšák > > --- > src/gallium/drivers/radeonsi/si_descriptors.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/gallium/drivers/radeonsi/si_descriptors.c > b/src/gallium/drivers/radeonsi/si_descriptors.c >

Re: [Mesa-dev] [PATCH] gallium/drivers/radeonsi: Add si_bind_sampler_states unbind support

2019-04-08 Thread Marek Olšák
I've sent a simpler patch. Please review. Thanks, Marek On Sat, Apr 6, 2019 at 9:07 AM Zhu, James wrote: > commit a613607dc3dab2b43884a4e5891aa5939cdcfbe0 will cause segfault > during unbind sampler state. This patch will fix the issue. > > Signed-off-by: James Zhu > --- >

[Mesa-dev] [PATCH] radeonsi: fix a crash when unbinding sampler states

2019-04-08 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/radeonsi/si_descriptors.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeonsi/si_descriptors.c b/src/gallium/drivers/radeonsi/si_descriptors.c index 244ba5a7bec..ac40ed27f91 100644 ---

Re: [Mesa-dev] [PATCH v2] virgl: Use right key to insert resource to hash.

2019-04-08 Thread Lepton Wu
On Mon, Apr 8, 2019 at 11:10 AM Chia-I Wu wrote: > > > > On Mon, Apr 8, 2019 at 9:34 AM Lepton Wu wrote: >> >> The old code could use gem name as key when inserting it to bo_handles >> hash table while trying to remove it from hash table with bo_handle as >> key in virgl_hw_res_destroy and then

[Mesa-dev] [Bug 109333] mesa, meson: Need ability to remember PKG_CONFIG_PATH

2019-04-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109333 Dylan Baker changed: What|Removed |Added Resolution|--- |FIXED Status|ASSIGNED

[Mesa-dev] [Bug 109323] [TRACKER] mesa: Remove autotools

2019-04-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109323 Bug 109323 depends on bug 109333, which changed state. Bug 109333 Summary: mesa, meson: Need ability to remember PKG_CONFIG_PATH https://bugs.freedesktop.org/show_bug.cgi?id=109333 What|Removed |Added

Re: [Mesa-dev] [PATCH] virgl: Use right key to insert resource to hash.

2019-04-08 Thread Lepton Wu
The kernel code will create a new gem handle for SHARED handle every time, see code here: https://github.com/torvalds/linux/blob/master/drivers/gpu/drm/drm_gem.c#L796 On Mon, Apr 8, 2019 at 11:12 AM Chia-I Wu wrote: > > > > On Wed, Apr 3, 2019 at 8:17 PM Dave Airlie wrote: >> >> On Thu, 4 Apr

Re: [Mesa-dev] [PATCH] virgl: Use right key to insert resource to hash.

2019-04-08 Thread Chia-I Wu
On Wed, Apr 3, 2019 at 8:17 PM Dave Airlie wrote: > On Thu, 4 Apr 2019 at 06:54, Chia-I Wu wrote: > > > > You could end up having two virgl_hw_res with two different GEM handles > pointing to the same kernel GEM object. That might break some assumptions > about dependency tracking. > > > > For

Re: [Mesa-dev] [PATCH v2] virgl: Use right key to insert resource to hash.

2019-04-08 Thread Chia-I Wu
On Mon, Apr 8, 2019 at 9:34 AM Lepton Wu wrote: > The old code could use gem name as key when inserting it to bo_handles > hash table while trying to remove it from hash table with bo_handle as > key in virgl_hw_res_destroy and then it fail to remove it from bo_handles > hash table. This

Re: [Mesa-dev] [PATCH] intel/disasm: Disassemble JIP offset for while

2019-04-08 Thread Anuj Phogat
On Wed, Mar 27, 2019 at 5:12 PM Sagar Ghuge wrote: > > Signed-off-by: Sagar Ghuge > --- > src/intel/compiler/brw_disasm.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/src/intel/compiler/brw_disasm.c b/src/intel/compiler/brw_disasm.c > index efca3e2ce7d..440e51faa61

Re: [Mesa-dev] [PATCH] intel/compiler: Set flag reg/subreg number properly

2019-04-08 Thread Sagar Ghuge
Thanks for reviewing the patch. On 4/8/19 10:34 AM, Anuj Phogat wrote: > On Wed, Mar 27, 2019 at 4:05 PM Sagar Ghuge wrote: >> >> If predicate control is set to None, then in that case we can simply set >> flag reg/subreg number to zero. This allows round-tripping through the >>

Re: [Mesa-dev] [PATCH] intel/compiler: Set flag reg/subreg number properly

2019-04-08 Thread Anuj Phogat
On Wed, Mar 27, 2019 at 4:05 PM Sagar Ghuge wrote: > > If predicate control is set to None, then in that case we can simply set > flag reg/subreg number to zero. This allows round-tripping through the > assembler/disassembler > > Signed-off-by: Sagar Ghuge > --- >

[Mesa-dev] [Bug 109183] GPU Hangs randomly with GTA V

2019-04-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109183 Alexander changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|INVALID

[Mesa-dev] [PATCH v2] virgl: Set bind when creating temp resource.

2019-04-08 Thread Lepton Wu
virgl render complains about "Illegal resource" when running dEQP-EGL.functional.color_clears.single_context.gles2.rgb888_window, the reason is that a zero bind value was given for temp resource. Signed-off-by: Lepton Wu --- src/gallium/drivers/virgl/virgl_texture.c | 10 ++ 1 file

[Mesa-dev] [PATCH v2] virgl: Use right key to insert resource to hash.

2019-04-08 Thread Lepton Wu
The old code could use gem name as key when inserting it to bo_handles hash table while trying to remove it from hash table with bo_handle as key in virgl_hw_res_destroy and then it fail to remove it from bo_handles hash table. This triggers use after free. Also, we should insert resource to

[Mesa-dev] [Bug 109565] CmdBindDescriptorSets gets confused about dynamic offsets

2019-04-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109565 --- Comment #9 from Samuel Pitoiset --- Do you still have a problem with binding offsets? -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the

Re: [Mesa-dev] [PATCH 1/2] radeonsi: always use compute rings for clover on CI and newer (v2)

2019-04-08 Thread Michel Dänzer
On 2019-04-02 4:00 p.m., Michel Dänzer wrote: > On 2019-04-02 2:57 p.m., Marek Olšák wrote: >> On Tue, Apr 2, 2019 at 4:57 AM Michel Dänzer wrote: >>> On 2019-04-02 12:39 a.m., Marek Olšák wrote: On Mon, Apr 1, 2019 at 1:28 PM Jan Vesely >>> wrote: > On Mon, 2019-04-01 at 12:30 -0400,

Re: [Mesa-dev] [PATCH] radv: allow secondary command buffers to inherit unknown framebuffers

2019-04-08 Thread Samuel Pitoiset
What's the status of this patch? On 12/20/18 8:05 PM, Rhys Perry wrote: Fixes: f4e499ec79 ('radv: add initial non-conformant radv vulkan driver') Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107986 Signed-off-by: Rhys Perry --- src/amd/vulkan/radv_cmd_buffer.c | 59

[Mesa-dev] [Bug 110350] DOOM 2016 crash + severe artifacting on RADV + Vega VII

2019-04-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110350 --- Comment #1 from Samuel Pitoiset --- Can you explain the steps for reproducing the problem in-game? -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the

[Mesa-dev] [Bug 110356] install_megadrivers.py creates new dangling symlink [bisected]

2019-04-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110356 Bug ID: 110356 Summary: install_megadrivers.py creates new dangling symlink [bisected] Product: Mesa Version: unspecified Hardware: Other OS: All

[Mesa-dev] [Bug 110349] radv: Dragon Quest XI (DXVK) has a graphical glitch (regression, bisected)

2019-04-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110349 --- Comment #6 from Andrew Sheldon --- (In reply to Samuel Pitoiset from comment #5) > Can you apply this > https://patchwork.freedesktop.org/patch/297237/?series=59168=1 ? The patch fixes the issue, thanks. -- You are receiving this mail

Re: [Mesa-dev] [PATCH v2 1/2] nir: Add nir_lower_viewport_transform

2019-04-08 Thread Thomas Helland
man. 8. apr. 2019 kl. 06:30 skrev Alyssa Rosenzweig : > > On Mali hardware (supported by Panfrost and Lima), the fixed-function > transformation from world-space to screen-space coordinates is done in > the vertex shader prior to writing out the gl_Position varying, rather > than in dedicated

[Mesa-dev] [Bug 110291] Vega 64 GPU hang running Space Engineers

2019-04-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110291 --- Comment #1 from Samuel Pitoiset --- Is this a recent regression? -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the bug.___ mesa-dev mailing

[Mesa-dev] [Bug 110349] radv: Dragon Quest XI (DXVK) has a graphical glitch (regression, bisected)

2019-04-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110349 --- Comment #5 from Samuel Pitoiset --- Can you apply this https://patchwork.freedesktop.org/patch/297237/?series=59168=1 ? -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the

[Mesa-dev] [PATCH] radv: fix getting the vertex strides if the bindings aren't contiguous

2019-04-08 Thread Samuel Pitoiset
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=110349 Fixes: a66b186bebf ("radv: use typed buffer loads for vertex input fetches") Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_pipeline.c | 16 +++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git

Re: [Mesa-dev] [PATCH v2 1/2] nir: Add nir_lower_viewport_transform

2019-04-08 Thread Qiang Yu
On Mon, Apr 8, 2019 at 12:30 PM Alyssa Rosenzweig wrote: > > On Mali hardware (supported by Panfrost and Lima), the fixed-function > transformation from world-space to screen-space coordinates is done in > the vertex shader prior to writing out the gl_Position varying, rather > than in dedicated

[Mesa-dev] [Bug 110261] Segmentation fault when using vulkaninfo on Radeon

2019-04-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110261 --- Comment #10 from Jason Ekstrand --- Unfortunately, thanks fo Vulkan passing everything as struct pointers, a backtrack with `bt full` isn't as useful as one would like. That said, given where it's crashing, I'm 93% sure that both of those

Re: [Mesa-dev] [PATCH 2/2] meson: upgrade minimum meson version

2019-04-08 Thread Eero Tamminen
Hi, On 6.4.2019 11.44, Khaled Emara wrote: Sorry, I though LTS distros used old versions of mesa. Got it. Those *provide* older Mesa version, so naturally people want to build latest Mesa on them (especially if they've just bought HW that isn't supported by distro version of Mesa). Building

Re: [Mesa-dev] [PATCH] ac/nir: fix intrinsic names for atomic operations with LLVM 9+

2019-04-08 Thread Bas Nieuwenhuizen
r-b On Mon, Apr 8, 2019 at 12:36 PM Samuel Pitoiset wrote: > > > On 4/8/19 12:32 PM, Erik Faye-Lund wrote: > > On Mon, 2019-04-08 at 11:39 +0200, Samuel Pitoiset wrote: > >> This fixes the following LLVM error when using RADV_DEBUG=checkir: > >> Intrinsic name not mangled correctly for type

Re: [Mesa-dev] [PATCH] ac/nir: fix intrinsic names for atomic operations with LLVM 9+

2019-04-08 Thread Erik Faye-Lund
On Mon, 2019-04-08 at 12:39 +0200, Samuel Pitoiset wrote: > On 4/8/19 12:32 PM, Erik Faye-Lund wrote: > > On Mon, 2019-04-08 at 11:39 +0200, Samuel Pitoiset wrote: > > > This fixes the following LLVM error when using > > > RADV_DEBUG=checkir: > > > Intrinsic name not mangled correctly for type

Re: [Mesa-dev] [PATCH] ac/nir: fix intrinsic names for atomic operations with LLVM 9+

2019-04-08 Thread Samuel Pitoiset
On 4/8/19 12:32 PM, Erik Faye-Lund wrote: On Mon, 2019-04-08 at 11:39 +0200, Samuel Pitoiset wrote: This fixes the following LLVM error when using RADV_DEBUG=checkir: Intrinsic name not mangled correctly for type arguments! Should be: llvm.amdgcn.buffer.atomic.add.i32 i32 (i32, <4 x i32>, i32,

[Mesa-dev] [Bug 110261] Segmentation fault when using vulkaninfo on Radeon

2019-04-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110261 --- Comment #9 from Denis --- bt all didn't provide anything, so I did same with Kenneth. Output below: (gdb) bt all No symbol "all" in current context. (gdb) thread apply all backtrace Thread 2 (Thread 0x76c37700 (LWP 11457)): #0

Re: [Mesa-dev] [PATCH 1/2] egl: add optional plat_opt to _eglFindDisplay()

2019-04-08 Thread Emil Velikov
On Thu, 4 Apr 2019 at 18:05, Adam Jackson wrote: > > On Thu, 2019-04-04 at 16:25 +0100, Emil Velikov wrote: > > > I'm not a huge fan of this. Yet again the other platform (x11) that uses > > these has a number of issues, see below for details. Once those are resolved > > we could try and make

Re: [Mesa-dev] [PATCH] ac/nir: fix intrinsic names for atomic operations with LLVM 9+

2019-04-08 Thread Erik Faye-Lund
On Mon, 2019-04-08 at 11:39 +0200, Samuel Pitoiset wrote: > This fixes the following LLVM error when using RADV_DEBUG=checkir: > Intrinsic name not mangled correctly for type arguments! Should be: > llvm.amdgcn.buffer.atomic.add.i32 > i32 (i32, <4 x i32>, i32, i32, i1)*

Re: [Mesa-dev] [PATCH 2/2] egl: add EGL_platform_device support

2019-04-08 Thread Emil Velikov
On Fri, 5 Apr 2019 at 14:57, Mathias Fröhlich wrote: > > Hi Emil, > > Now that I have been putting together a test case for the the actual use > I do see some issues with the pbuffer code path. Well - still investigating > if the test is wrong or the result. > Actually I do recall some issues

Re: [Mesa-dev] Move adriconf to mesa repositories

2019-04-08 Thread Emil Velikov
On Thu, 4 Apr 2019 at 17:25, Jean Hertel wrote: > > From: Emil Velikov > Sent: 4th april, 2019 13:08 > >Yes I have interest in a configuration tool, although my vision varies > >a lot from what adriconf and its predecessor. > > I'm super interested and open to hear yours, and other mesa devs,

[Mesa-dev] [PATCH] nir/radv: remove restrictions on opt_if_loop_last_continue()

2019-04-08 Thread Timothy Arceri
When I implemented opt_if_loop_last_continue() I had restricted this pass from moving other if-statements inside the branch opposite the continue. At the time it was causing a bunch of spilling in shader-db for i965. However Samuel Pitoiset noticed that making this pass more aggressive

[Mesa-dev] [Bug 110261] Segmentation fault when using vulkaninfo on Radeon

2019-04-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110261 Denis changed: What|Removed |Added CC||denys.kos...@globallogic.co

[Mesa-dev] [Bug 110261] Segmentation fault when using vulkaninfo on Radeon

2019-04-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110261 --- Comment #8 from Denis --- >/build/vulkan-tools/src/Vulkan-Tools-1.1.102/vulkaninfo/vulkaninfo.c:4504: >failed with VK_ERROR_OUT_OF_HOST_MEMORY Actually that's exactly what I got in "normal" version. I discussed this error with dev and he

[Mesa-dev] [PATCH] ac/nir: fix intrinsic names for atomic operations with LLVM 9+

2019-04-08 Thread Samuel Pitoiset
This fixes the following LLVM error when using RADV_DEBUG=checkir: Intrinsic name not mangled correctly for type arguments! Should be: llvm.amdgcn.buffer.atomic.add.i32 i32 (i32, <4 x i32>, i32, i32, i1)* @llvm.amdgcn.buffer.atomic.add The cmpswap operation still uses the old intrinsic.

[Mesa-dev] [Bug 110349] radv: Dragon Quest XI (DXVK) has a graphical glitch (regression, bisected)

2019-04-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110349 --- Comment #4 from Andrew Sheldon --- I should note that I used a version of Mesa with the test patch in #110348 (which I thought might be related), which I forgot to remove. If this is likely to affect the trace I'll upload a new one (the bug

[Mesa-dev] [Bug 110349] radv: Dragon Quest XI (DXVK) has a graphical glitch (regression, bisected)

2019-04-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110349 --- Comment #3 from Andrew Sheldon --- Added a renderdoc for the game. And yes, it affects up to current master (4209a27c61ee4bda2efb63e080bde01545edb2b5). -- You are receiving this mail because: You are the QA Contact for the bug. You are

[Mesa-dev] [Bug 110349] radv: Dragon Quest XI (DXVK) has a graphical glitch (regression, bisected)

2019-04-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110349 --- Comment #2 from Andrew Sheldon --- Created attachment 143891 --> https://bugs.freedesktop.org/attachment.cgi?id=143891=edit Dragon Quest XI DXVK renderdoc -- You are receiving this mail because: You are the assignee for the bug. You are

Re: [Mesa-dev] [PATCH] radv: enable VK_AMD_gpu_shader_half_float

2019-04-08 Thread Samuel Pitoiset
On 3/21/19 11:09 AM, Bas Nieuwenhuizen wrote: Honestly the zero tests is worrying me. This is a pretty big extension and I have questions like: to 16-bit loads + 16-bit ALU actually work together or have we been silently relying on the fact there is always a ZExt cast after and that did not

[Mesa-dev] [PATCH 2/2] ac: add 16-bit support to ac_build_ddxy()

2019-04-08 Thread Samuel Pitoiset
From: Rhys Perry Signed-off-by: Rhys Perry --- src/amd/common/ac_llvm_build.c | 22 +- 1 file changed, 17 insertions(+), 5 deletions(-) diff --git a/src/amd/common/ac_llvm_build.c b/src/amd/common/ac_llvm_build.c index 54e90288bda..3e3ca5c7fdb 100644 ---

[Mesa-dev] [PATCH 1/2] ac/nir: fix nir_op_b2f16

2019-04-08 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/amd/common/ac_nir_to_llvm.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c index 6739551ca26..8510be5dfe6 100644 --- a/src/amd/common/ac_nir_to_llvm.c +++

[Mesa-dev] [PATCH v2] st/nine: skip position checks in SetCursorPosition()

2019-04-08 Thread Andre Heider
For HW cursors, "cursor.pos" doesn't hold the current position of the pointer, just the position of the last call to SetCursorPosition(). Skip the check against stale values and bump the d3dadapter9 drm version to expose this change of behaviour. Signed-off-by: Andre Heider --- V2: don't

[Mesa-dev] [Bug 110348] radv: Resolve attachments do not work if view format differs from image format

2019-04-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110348 --- Comment #1 from Samuel Pitoiset --- This probably needs a spec clarification? -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug.___

[Mesa-dev] [Bug 110349] radv: Dragon Quest XI (DXVK) has a graphical glitch (regression, bisected)

2019-04-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110349 --- Comment #1 from Samuel Pitoiset --- Do you have the following commit in your build ? ommit d5befdbe4ad4523e58074063a3b619f389fb9f1f Author: Samuel Pitoiset Date: Fri Mar 15 10:36:00 2019 +0100 radv: always load 3 channels for

[Mesa-dev] [Bug 110350] DOOM 2016 crash + severe artifacting on RADV + Vega VII

2019-04-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110350 Bug ID: 110350 Summary: DOOM 2016 crash + severe artifacting on RADV + Vega VII Product: Mesa Version: git Hardware: x86-64 (AMD64) OS: Linux (All)