On Fri, May 3, 2019 at 7:19 AM Nicolai Hähnle wrote:
> From: Nicolai Hähnle
>
> ---
> src/amd/common/ac_binary.c| 2 +
> src/gallium/drivers/radeonsi/si_compute.c | 14 +--
> src/gallium/drivers/radeonsi/si_shader.c | 112 +++---
>
For the series:
Reviewed-by: Marek Olšák
Marek
On Fri, May 3, 2019 at 7:06 AM Haehnle, Nicolai
wrote:
> On 03.05.19 12:36, Nicolai Hähnle wrote:
> > On 25.04.19 13:18, Nicolai Hähnle wrote:
> >> @@ -4618,21 +4648,27 @@ static void si_bind_vertex_elements(struct
> >> pipe_context *ctx, void
On Wed, May 08, 2019 at 01:55:53PM +1000, Timothy Arceri wrote:
> This was missed in e00fa99b08b3.
>
> Cc: Christian Gmeiner
> ---
> src/compiler/glsl/glsl_to_nir.cpp | 9 -
> 1 file changed, 9 deletions(-)
Reviewed-by: Caio Marcelo de Oliveira Filho
https://bugs.freedesktop.org/show_bug.cgi?id=91687
Timothy Arceri changed:
What|Removed |Added
Status|NEW |NEEDINFO
--- Comment #6 from Timothy
This was missed in e00fa99b08b3.
Cc: Christian Gmeiner
---
src/compiler/glsl/glsl_to_nir.cpp | 9 -
1 file changed, 9 deletions(-)
diff --git a/src/compiler/glsl/glsl_to_nir.cpp
b/src/compiler/glsl/glsl_to_nir.cpp
index 47159ebd5e8..a51d39c4753 100644
---
https://bugs.freedesktop.org/show_bug.cgi?id=99781
Timothy Arceri changed:
What|Removed |Added
Status|RESOLVED|REOPENED
Resolution|FIXED
https://bugs.freedesktop.org/show_bug.cgi?id=110632
Timothy Arceri changed:
What|Removed |Added
Resolution|--- |FIXED
Status|NEW
From: Dave Airlie
---
src/gallium/targets/dri/meson.build | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/gallium/targets/dri/meson.build
b/src/gallium/targets/dri/meson.build
index dd40969a166..45daf647960 100644
--- a/src/gallium/targets/dri/meson.build
+++
Makes sense, thank you for the clarification.
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Acked-by: Marek Olšák
Marek
On Mon, May 6, 2019 at 11:02 AM Emil Velikov
wrote:
> This new 'platform' is added by default with no guards.
>
> It is effectively a copy of the surfaceless one, with updated function
> names and brand new probe function.
>
> Due to the reuse, some of the ifdef
Quoting Alyssa Ross (2019-05-07 06:17:15)
> On Mon, May 06, 2019 at 04:38:20PM -0700, Alyssa Rosenzweig wrote:
> > Wrong Alyssa, cc'ing the right one :)
>
> Thank you for the CC, fellow Alyssa! :)
>
> > On Mon, May 06, 2019 at 04:32:38PM +0100, Emil Velikov wrote:
> > > Alyssa this should
They aren't. It's just a function pointer. We could add support for it but
it doesn't seem worth the effort.
On May 7, 2019 17:42:23 Alyssa Rosenzweig wrote:
Gotcha. I wasn't sure negations in the NIR search rule were possible...?
___
mesa-dev
On 8/5/19 1:51 am, Samuel Pitoiset wrote:
What games are affected btw?
PERCENTAGE DELTASShaders SGPRs VGPRs SpillSGPR CodeSize
MaxWaves
batman-arkham-city 2581 . . .. .
dawn-of-war-3 244 . . ..
Reviewed-by: Marek Olšák
Marek
On Thu, May 2, 2019 at 10:12 AM Samuel Pitoiset
wrote:
> This changes requires LLVM r356755.
>
> 32706 shaders in 16744 tests
> Totals:
> SGPRS: 1448848 -> 1455984 (0.49 %)
> VGPRS: 1016684 -> 1016220 (-0.05 %)
> Spilled SGPRs: 25871 -> 25815 (-0.22 %)
> Spilled
There is a document about this in docs/, but I think you just need to add
the Cc: stable tag or the Fixes: tag to the commit message of all commits
you wanna nominate.
Mare
On Mon, May 6, 2019 at 12:12 PM Chuck Atkins
wrote:
> When doing an MR via GitLab, is adding the Cc: mesa-stable item
Reviewed-by: Marek Olšák
Marek
On Mon, May 6, 2019 at 8:19 PM Timothy Arceri wrote:
> This brings it inline with the recently added AMD_DEBUG.
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=109619
> ---
> src/gallium/drivers/radeonsi/si_pipe.c | 4
> 1 file changed, 4
D'oh.
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Sigh ... given that there's both "is_used_by_if" and
"is_not_used_by_if" ... gonna go with "no".
On Tue, May 7, 2019 at 6:42 PM Alyssa Rosenzweig wrote:
>
> Gotcha. I wasn't sure negations in the NIR search rule were possible...?
___
mesa-dev mailing
Gotcha. I wasn't sure negations in the NIR search rule were possible...?
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
On Mon, May 6, 2019 at 11:19 AM Emil Velikov
wrote:
> On Sat, 4 May 2019 at 04:18, Marek Olšák wrote:
> >
> > On Fri, May 3, 2019 at 1:58 AM Mathias Fröhlich <
> mathias.froehl...@gmx.net> wrote:
> >>
> >> Good Morning,
> >>
> >> On Wednesday, 1 May 2019 21:43:08 CEST Marek Olšák wrote:
> >> >
On Mon, May 6, 2019 at 11:02 AM Emil Velikov
wrote:
> From: Emil Velikov
>
> By default, the user is likely to pick the first device so it should
> not be the least performant (aka software) one.
>
> Suggested-by: Marek Olšák
> Signed-off-by: Emil Velikov
> ---
> src/egl/main/egldevice.c |
For patches 1-7:
Reviewed-by: Marek Olšák
Marek
On Mon, May 6, 2019 at 11:02 AM Emil Velikov
wrote:
> From: Emil Velikov
>
> By default, the user is likely to pick the first device so it should
> not be the least performant (aka software) one.
>
> Suggested-by: Marek Olšák
> Signed-off-by:
On Tue, May 7, 2019 at 5:45 PM Alyssa Rosenzweig wrote:
>
> > IMO better names might be is_scalar_swizzle or something.
>
> Ah, yes, that would be a better name! is_not_scalar_swizzle in this case
> (logic is flipped).
>
> > Can num_components be 1? If so, then this will return false, whereas
> >
> IMO better names might be is_scalar_swizzle or something.
Ah, yes, that would be a better name! is_not_scalar_swizzle in this case
(logic is flipped).
> Can num_components be 1? If so, then this will return false, whereas
> you probably wanted it to return true.
I think that's the correct
Tentative R-b, but I'm baffled what the flip-flops would be about. Could
you link the list of failures introduced (we're maybe relying on buggy
behaviour anyway)?
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
> Logic ops seem... challenging to emulate in the shader. That shader
> would need the destination colors in the framebuffer storage format, and
> I'm not sure that's always possible (maybe?).
Alright, that's good to know.
I will note that in Midgard, the native hardware ops are to load/store
That's a bit gross that we have to do that Oh, well.
Reviewed-by: Jason Ekstrand
On Mon, Apr 29, 2019 at 6:01 PM Matt Turner wrote:
> In the FS IR we pretend that the instruction is predicated with (+f0.1)
> just for flag dependency tracking purposes. Since the instruction
> doesn't
https://bugs.freedesktop.org/show_bug.cgi?id=107511
Madhurkiran changed:
What|Removed |Added
Status|RESOLVED|REOPENED
Resolution|FIXED
https://bugs.freedesktop.org/show_bug.cgi?id=110625
El jinete sin cabeza changed:
What|Removed |Added
CC||romanescu.2...@gmail.com
--
This commit is
Reviewed-by: Ian Romanick
On 5/5/19 7:26 PM, Alyssa Rosenzweig wrote:
> We add enums corresponding to (GLES) blend state to shader_enums.h,
> complementing the existing advanced blending enums in the file. This
> allows us to represent blending state in a driver-agnostic,
This commit is
Reviewed-by: Ian Romanick
On 5/5/19 7:26 PM, Alyssa Rosenzweig wrote:
> This represents a float vec4 constant color, as passed to glBlendColor.
> While the existing 4 shader sysvals are retained to minimize code churn,
> a single vectorized intrinsic is required for efficient
On 5/5/19 7:26 PM, Alyssa Rosenzweig wrote:
> This new lowering pass implements the OpenGL ES blend pipeline in
> shaders, applicable to hardware lacking full-featured blending hardware
> (including Midgard/Bifrost and vc4). This pass is run on a fragment
> shader, rewriting the store to a blended
Hi Samuel,
This doesn't apply cleanly on 19.0, and I'm not sure how to resolve the diff.
Could you provide a packport please?
Thanks,
Dylan
Quoting Samuel Pitoiset (2019-05-03 02:45:34)
> Because the new raw/struct intrinsics are buggy with LLVM 8
> (they weren't marked as source of
The first release candidate for Mesa 19.1.0 is now available, with
1 week of delay.
The plan is to have one release candidate every Tuesday, until the
anticipated final release on 28th May 2019 (one week later the schedule
in the calendar, due the delay).
The expectation is that the 19.0 branch
On Tue, 2019-05-07 at 20:17 +1000, Timothy Arceri wrote:
> I don't know enough about this code to take responsibility for such
> changes. I was just trying to revert to the status quo until this could
> be investigated again.
>
> My suggestion is we roll back the recent change. Then someone
For the series:
Reviewed-by: Roland Scheidegger
Am 04.05.19 um 18:07 schrieb Brian Paul:
> Remove stray const qualifier.
> s/unsigned/enum tgsi_semantic/
> ---
> src/gallium/auxiliary/util/u_format_zs.h | 2 +-
> src/gallium/auxiliary/util/u_simple_shaders.c | 4 ++--
> 2 files changed, 3
What games are affected btw?
Can you please double check before pushing because of the flrp changes
that landed around?
On 5/7/19 7:14 AM, Timothy Arceri wrote:
ping!
On 2/5/19 1:38 pm, Timothy Arceri wrote:
The pattern of calling opt algebraic first seems to have originated
in i965. The
https://bugs.freedesktop.org/show_bug.cgi?id=102522
Kaelyn T changed:
What|Removed |Added
Status|NEEDINFO|RESOLVED
Resolution|---
Nope, r-b
On Tue, May 7, 2019 at 8:36 AM Samuel Pitoiset
wrote:
>
> Seems fine to,
>
> Reviewed-by: Samuel Pitoiset
>
> Bas, any comments?
>
> On 5/7/19 7:14 AM, Timothy Arceri wrote:
> > ping!
> >
> > On 2/5/19 1:38 pm, Timothy Arceri wrote:
> >> The pattern of calling opt algebraic first
Valgrind was complaining of those.
NIR_PASS only sets progress to TRUE if there was progress.
nir_const_load_to_arr() only sets as many constants as components has
the instruction.
This was causing some dEQP tests to flip-flop.
Signed-off-by: Tomeu Vizoso
---
On 5/7/19 5:30 PM, Ian Romanick wrote:
On 5/7/19 8:20 AM, Samuel Pitoiset wrote:
This introduces glitches with Talos and Serious Sam 2017 with RADV...
Are you able to reproduce the problem with ANV?
Probably not very easily. If you can figure out which shader it is, it
should be easy to
On 5/7/19 8:20 AM, Samuel Pitoiset wrote:
> This introduces glitches with Talos and Serious Sam 2017 with RADV...
>
> Are you able to reproduce the problem with ANV?
Probably not very easily. If you can figure out which shader it is, it
should be easy to figure out the problem from before /
This introduces glitches with Talos and Serious Sam 2017 with RADV...
Are you able to reproduce the problem with ANV?
On 5/7/19 8:01 AM, GitLab Mirror wrote:
Module: Mesa
Branch: master
Commit: 5b908db604b2f47bb8382047533e556db8d5f52b
URL:
LGTM.
Reviewed-by: Jose Fonseca
From: srol...@vmware.com
Sent: Tuesday, May 7, 2019 03:12
To: Jose Fonseca; Brian Paul; mesa-dev@lists.freedesktop.org
Cc: Roland Scheidegger
Subject: [PATCH] gallivm: fix broken 8-wide s3tc decoding
From: Roland Scheidegger
On Tue, May 7, 2019 at 9:28 AM Ilia Mirkin wrote:
> Divergence is generally when multiple parallel "lanes" go in different
> directions -- a jump that some lanes take and others don't, which
> requires the GPU to execute some lanes first, and then the rest,
> separately.
>
> IMO better names
Divergence is generally when multiple parallel "lanes" go in different
directions -- a jump that some lanes take and others don't, which
requires the GPU to execute some lanes first, and then the rest,
separately.
IMO better names might be is_scalar_swizzle or something.
On Mon, May 6, 2019 at
The load/store optimizer pass doesn't handle WaW hazards correctly
and this is the root cause of the reflection issue with Monster
Hunter World. AFAIK, it's the only game that are affected by this
issue.
LLVM 9 will be fixed but we need a workaround for older LLVM
versions, see
On Mon, May 06, 2019 at 04:38:20PM -0700, Alyssa Rosenzweig wrote:
> Wrong Alyssa, cc'ing the right one :)
Thank you for the CC, fellow Alyssa! :)
> On Mon, May 06, 2019 at 04:32:38PM +0100, Emil Velikov wrote:
> > Alyssa this should resolve the failure with minimal churn. Please let
> > me know
On 7/5/19 6:27 pm, Michel Dänzer wrote:
On 2019-05-07 5:55 a.m., Timothy Arceri wrote:
This reverts commit e91ee763c378d03883eb88cf0eadd8aa916f7878.
This seems to have broken a number of wine games.
Cc: Adam Jackson
Cc: Ian Romanick
Cc: Hal Gentz
Bugzilla:
https://bugs.freedesktop.org/show_bug.cgi?id=110606
Eric Engestrom changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|---
https://bugs.freedesktop.org/show_bug.cgi?id=110606
Eric Engestrom changed:
What|Removed |Added
CC||tehfr...@gmail.com
--- Comment #1
https://bugs.freedesktop.org/show_bug.cgi?id=110607
Eric Engestrom changed:
What|Removed |Added
Resolution|--- |DUPLICATE
Status|NEW
On Tue, 7 May 2019 at 09:27, Michel Dänzer wrote:
>
> On 2019-05-07 5:55 a.m., Timothy Arceri wrote:
> > This reverts commit e91ee763c378d03883eb88cf0eadd8aa916f7878.
> >
> > This seems to have broken a number of wine games.
> >
> > Cc: Adam Jackson
> > Cc: Ian Romanick
> > Cc: Hal Gentz
> >
https://bugs.freedesktop.org/show_bug.cgi?id=110632
--- Comment #6 from Hi-Angel ---
(In reply to Ian Romanick from comment #1)
> Is it possible to get a backtrace from __glXSendError? I don't understand
> why this particular commit would change behavior from "not error" to "error".
Sure, can
On 2019-05-07 5:55 a.m., Timothy Arceri wrote:
> This reverts commit e91ee763c378d03883eb88cf0eadd8aa916f7878.
>
> This seems to have broken a number of wine games.
>
> Cc: Adam Jackson
> Cc: Ian Romanick
> Cc: Hal Gentz
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=110632
>
https://bugs.freedesktop.org/show_bug.cgi?id=110345
--- Comment #16 from Samuel Pitoiset ---
Are you still able to reproduce with latest mesa/llvm git?
We fixed some issues that might or might not help.
Since last time, I tried (a bunch of times) to reproduce the GPU hang with Dirt
4 without
https://bugs.freedesktop.org/show_bug.cgi?id=110632
Michel Dänzer changed:
What|Removed |Added
CC||zegen...@protonmail.com
--
You are
https://bugs.freedesktop.org/show_bug.cgi?id=110632
Michel Dänzer changed:
What|Removed |Added
CC||hi-an...@yandex.ru
--- Comment #5 from
https://bugs.freedesktop.org/show_bug.cgi?id=110590
Michel Dänzer changed:
What|Removed |Added
Resolution|--- |DUPLICATE
Status|NEW
https://bugs.freedesktop.org/show_bug.cgi?id=106351
Michel Dänzer changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|---
https://bugs.freedesktop.org/show_bug.cgi?id=110603
--- Comment #5 from Samuel Pitoiset ---
This is indeed weird.
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.___
mesa-dev mailing list
On Mon, 2019-05-06 at 14:32 -0500, Jason Ekstrand wrote:
> On Mon, May 6, 2019 at 9:01 AM Iago Toral Quiroga
> wrote:
> > From: Samuel Iglesias Gonsálvez
> >
> >
> >
> > There are tests in CTS for alpha to coverage without a color
> > attachment
> >
> > that are failing. This happens because
Seems fine to,
Reviewed-by: Samuel Pitoiset
Bas, any comments?
On 5/7/19 7:14 AM, Timothy Arceri wrote:
ping!
On 2/5/19 1:38 pm, Timothy Arceri wrote:
The pattern of calling opt algebraic first seems to have originated
in i965. The order in OpenGL drivers generally doesn't matter
because
63 matches
Mail list logo
