From: Anuj Phogat anuj.pho...@gmail.com
Hi,
Here is a patch to allow glTexImage2D and glCopyTexImage2D with depth component
cubemap.
It is listed in mesa work queue with a label CUBE1. I've tested the patch and
output looks visually correct.
Please review the fix and let me know if i'm
From: Anuj Phogat anuj.pho...@gmail.com
Thanks for the review comments. Here is the updated patch to allow depth
component cube maps in GL 3.0.
I'll post the piglit testcase for this patch in a separate e-mail.
Anuj
Signed-off-by: Anuj Phogat anuj.pho...@gmail.com
---
src/mesa/main/teximage.c
From: Anuj Phogat anuj.pho...@gmail.com
Hi Brian,
I think something like this would be simpler:
@@ -1629,7 +1629,9 @@ texture_error_check( struct gl_context *ctx,
target != GL_TEXTURE_2D_ARRAY
target != GL_PROXY_TEXTURE_2D_ARRAY
target != GL_TEXTURE_RECTANGLE_ARB
- target
On Tue 22 Nov 2011 12:21:09 PM PST, Kenneth Graunke wrote:
On 11/22/2011 11:42 AM, Anuj Phogat wrote:
[snip]
I agree. This is simpler to read and _mesa_is_cube_map_face() can be reused
in mesa. Posting an updated patch with your suggestions.
I haven't tested this so the logic might
From: Anuj Phogat anuj.pho...@gmail.com
This is an updated patch to allow glTexImage2D with a depth component cube map.
Patch
was producing an expected ouput with depth-cube-map test (posted on piglit
mailing list).
But i'm getting an incorrect output since i updated my mesa branch with
git
Hi Brian,
This is an updated patch to allow glTexImage2D with a depth component
cube map. Patch
was producing an expected ouput with depth-cube-map test (posted on
piglit mailing list).
But i'm getting an incorrect output since i updated my mesa branch
with
From: Anuj Phogat anuj.pho...@gmail.com
I made the suggested changes to swrast/s_texfilter.c (see the patch listed
below). Now it render
polygons without any texture (black) in depth-cube-map test (see the patch sent
on Nov 28 to piglit mailing list).
But the expected output is polygons
On Thu 01 Dec 2011 06:56:09 AM PST, Brian Paul wrote:
On 11/30/2011 12:39 PM, Anuj Phogat wrote:
From: Anuj Phogatanuj.pho...@gmail.com
I made the suggested changes to swrast/s_texfilter.c (see the patch
listed below). Now it render
polygons without any texture (black) in depth-cube-map test
From: Anuj Phogat anuj@aphogat.(none)
This patch fixes the samplerCubeShadow support in GLSL shader compiler. shader
compiler was picking
the 'r' texture coordinate for shadow comparison when the expected behaviour is
to use 'q' texture coordinate
in case of cube shadow maps.
Signed-off
On Tue 13 Dec 2011 12:49:28 PM PST, Ian Romanick wrote:
On 12/13/2011 12:01 PM, Anuj Phogat wrote:
Enabling display list support for glClearBuffer functions with minor
fixes
There's also a #if 0 block in that file that should be removed. This
is a case where 'git blame' is useful. doing
On 11/27/2011 12:54 PM, Dave Airlie wrote:
From: Dave Airlie airl...@redhat.com
fixing these makes piglit fbo-integer pass on softpipe.
Signed-off-by: Dave Airlie airl...@redhat.com
---
src/mesa/main/format_unpack.c | 135
+
1 files changed, 135
-by: Vinson Lee v...@vmware.com
Signed-off-by: Anuj Phogat anuj.pho...@gmail.com
---
src/mesa/drivers/dri/intel/intel_mipmap_tree.c |5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/src/mesa/drivers/dri/intel/intel_mipmap_tree.c
b/src/mesa/drivers/dri/intel
On Tue 03 Jan 2012 07:14:09 PM PST, Ian Romanick wrote:
On 01/03/2012 06:36 PM, Anuj Phogat wrote:
Coverity reported a read from pointer after free defect in
src/mesa/drivers/dri/intel/intel_mipmap_tree.c
In intel_miptree_all_slices_resolve() function, i = i-next was
executing after freeing i
glDrawBuffer(GL_FRONT_AND_BACK) results in to segmentation fault if
intel-is_front_buffer_rendering is not enabled with GL_FRONT_AND_BACK.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=44153
Reported-by: Yi Sun yi@intel.com
Signed-off-by: Anuj Phogat anuj.pho...@gmail.com
---
src
On Fri 06 Jan 2012 01:00:36 PM PST, Anuj Phogat wrote:
glDrawBuffer(GL_FRONT_AND_BACK) results in to segmentation fault if
intel-is_front_buffer_rendering is not enabled with GL_FRONT_AND_BACK.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=44153
Reported-by: Yi Sun yi@intel.com
://bugs.freedesktop.org/show_bug.cgi?id=44614
Reported-by: Yi Sun yi@intel.com
Signed-off-by: Anuj Phogat anuj.pho...@gmail.com
---
src/mesa/drivers/dri/intel/intel_screen.c | 12 +++-
1 files changed, 7 insertions(+), 5 deletions(-)
diff --git a/src/mesa/drivers/dri/intel/intel_screen.c
b/src/mesa
;
default:
/* no-op */
;
--
1.7.10.4
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Reviewed-by: Anuj Phogat anuj.pho...@gmail.com
);
}
/**
--
1.7.11.7
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Reviewed-by: Anuj Phogat anuj.pho...@gmail.com
___
mesa-dev mailing
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Reviewed-by: Anuj Phogat anuj.pho...@gmail.com
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
-by: Anuj Phogat anuj.pho...@gmail.com
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Reviewed-by: Anuj Phogat anuj.pho...@gmail.com
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
are Reviewed-by: Anuj Phogat anuj.pho...@gmail.com
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
tex-Sright and tex-Ttop are initialized during texture allocation.
This fixes depth buffer blitting failures in khronos conformance tests
when run on desktop GL 3.0.
Note: This is a candidate for stable branches.
Signed-off-by: Anuj Phogat anuj.pho...@gmail.com
---
src/mesa/drivers/common
On Fri, Feb 22, 2013 at 12:28 PM, Patrick Baggett
baggett.patr...@gmail.com wrote:
On Fri, Feb 22, 2013 at 2:23 PM, Ian Romanick i...@freedesktop.org wrote:
On 02/15/2013 11:20 AM, Anuj Phogat wrote:
tex-Sright and tex-Ttop are initialized during texture allocation.
This fixes depth buffer
On Mon, Feb 25, 2013 at 6:13 AM, Alle Mahesh alle_mah...@infosys.com wrote:
Hi,
We have run the Khronos test suite on for OpenGLES2.0. There are few failures
in the GL tests because of the difference in the images generated.
We have found that the images generated using our
.
-* 3. Store the uncompressed data into the miptree and discard the
ETC1/ETC2
-* data.
-*/
- bool wraps_etc;
-
/* These are also refcounted:
*/
GLuint refcount;
--
1.8.1.4
Reviewed-by: Anuj Phogat anuj.pho...@gmail.com
On Mon, Mar 4, 2013 at 11:38 AM, Matt Turner matts...@gmail.com wrote:
Reported-by: Marek Olšák mar...@gmail.com
---
src/mesa/main/teximage.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/src/mesa/main/teximage.c b/src/mesa/main/teximage.c
index 0dcf88a..e5260d1
On Mon, Mar 4, 2013 at 11:41 AM, Ian Romanick i...@freedesktop.org wrote:
On 03/04/2013 11:38 AM, Matt Turner wrote:
Reported-by: Marek Olšák mar...@gmail.com
Do our ETC2 piglit tests run in this mode? It would be good to see this
change actually fix a bug by making a failing test pass. :)
Framebuffer blitting operation should be skipped if any of the
dimensions (width/height) of src/dst rect are zero.
Fixes: fbblit(negative.nullblit.zeroSize) in Intel oglconform
https://bugs.freedesktop.org/show_bug.cgi?id=59495
Note: Candidate for all the stable branches.
Signed-off-by: Anuj
On Fri, Mar 8, 2013 at 8:02 AM, Paul Berry stereotype...@gmail.com wrote:
On 7 March 2013 14:15, Anuj Phogat anuj.pho...@gmail.com wrote:
Framebuffer blitting operation should be skipped if any of the
dimensions (width/height) of src/dst rect are zero.
Fixes: fbblit
=59495
Note: Candidate for all the stable branches.
Signed-off-by: Anuj Phogat anuj.pho...@gmail.com
---
src/mesa/main/fbobject.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/src/mesa/main/fbobject.c b/src/mesa/main/fbobject.c
index d6acc58..0126e29 100644
--- a/src/mesa
mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Reviewed-by: Anuj Phogat anuj.pho...@gmail.com
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo
-by: Anuj Phogat anuj.pho...@gmail.com
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Signed-off-by: Anuj Phogat anuj.pho...@gmail.com
---
src/mesa/drivers/dri/intel/intel_screen.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/src/mesa/drivers/dri/intel/intel_screen.c
b/src/mesa/drivers/dri/intel/intel_screen.c
index 16750f2..27b992c 100644
--- a/src/mesa/drivers/dri
On Tue, Apr 16, 2013 at 3:06 PM, Matt Turner matts...@gmail.com wrote:
On Tue, Apr 16, 2013 at 11:11 AM, Anuj Phogat anuj.pho...@gmail.com wrote:
Signed-off-by: Anuj Phogat anuj.pho...@gmail.com
---
src/mesa/drivers/dri/intel/intel_screen.c | 3 +++
1 file changed, 3 insertions(+)
diff
I've run these tests only on my implementation of
EXT_framebuffer_multisample_blit_scaled
extension on i965 drivers. NVIDIA, AMD machines I've don't support this
extension.
Could somebody try running on NVIDIA drivers?
Anuj Phogat (4):
Add functionality to create a FBO with multisample
Signed-off-by: Anuj Phogat anuj.pho...@gmail.com
---
tests/spec/ext_framebuffer_multisample/common.cpp | 17 -
1 file changed, 16 insertions(+), 1 deletion(-)
diff --git a/tests/spec/ext_framebuffer_multisample/common.cpp
b/tests/spec/ext_framebuffer_multisample/common.cpp
Signed-off-by: Anuj Phogat anuj.pho...@gmail.com
---
tests/all.tests| 6 +
.../ext_framebuffer_multisample/CMakeLists.gl.txt | 1 +
.../blit-scaled-glsl.cpp | 268 +
3 files changed, 275 insertions(+)
create
Signed-off-by: Anuj Phogat anuj.pho...@gmail.com
---
tests/all.tests| 1 +
.../ext_framebuffer_multisample/CMakeLists.gl.txt | 1 +
.../negative-blit-scaled.cpp | 111 +
3 files changed, 113 insertions(+)
create
Anuj Phogat (3):
mesa: Implement ext_framebuffer_multisample_blit_scaled extension
intel: Add multisample scaled blitting in blorp engine
i965: Enable ext_framebuffer_multisample_blit_scaled on intel h/w
src/mesa/drivers/dri/i965/brw_blorp.h | 16 +-
src/mesa/drivers/dri/i965
Signed-off-by: Anuj Phogat anuj.pho...@gmail.com
---
src/mesa/main/extensions.c | 1 +
src/mesa/main/fbobject.c | 17 ++---
src/mesa/main/mtypes.h | 1 +
3 files changed, 16 insertions(+), 3 deletions(-)
diff --git a/src/mesa/main/extensions.c b/src/mesa/main/extensions.c
on sandybridge ivybridge with these
changes.
Signed-off-by: Anuj Phogat anuj.pho...@gmail.com
---
src/mesa/drivers/dri/i965/brw_blorp.h | 16 +-
src/mesa/drivers/dri/i965/brw_blorp_blit.cpp | 581 +
src/mesa/drivers/dri/intel/intel_mipmap_tree.c | 2 +
3 files changed
about these scaling factors. I'll update my patches to fix the issue
along with other review comments.
Signed-off-by: Anuj Phogat anuj.pho...@gmail.com
---
src/mesa/drivers/dri/intel/intel_extensions.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/mesa/drivers/dri/intel
On Wed, May 1, 2013 at 1:58 PM, Anuj Phogat anuj.pho...@gmail.com wrote:
I've run these tests only on my implementation of
EXT_framebuffer_multisample_blit_scaled
extension on i965 drivers. NVIDIA, AMD machines I've don't support this
extension.
Could somebody try running on NVIDIA drivers
On Wed, May 1, 2013 at 2:44 PM, Matt Turner matts...@gmail.com wrote:
On Wed, May 1, 2013 at 2:10 PM, Anuj Phogat anuj.pho...@gmail.com wrote:
@@ -1063,22 +1176,21 @@ brw_blorp_blit_program::translate_tiling(bool
old_tiled_w, bool new_tiled_w)
* X' = (X ~0b1011) 1 | (Y 0b1) 2
On Wed, May 1, 2013 at 2:10 PM, Anuj Phogat anuj.pho...@gmail.com wrote:
In traditional multisampled framebuffer rendering, color samples must be
explicitly
resolved via BlitFramebuffer before doing the scaled blitting of the
framebuffer.
So, scaled blitting of a multisample framebuffer
On Tue, May 7, 2013 at 10:40 AM, Paul Berry stereotype...@gmail.com wrote:
On 1 May 2013 14:10, Anuj Phogat anuj.pho...@gmail.com wrote:
In traditional multisampled framebuffer rendering, color samples must be
explicitly
resolved via BlitFramebuffer before doing the scaled blitting
V2:
- Split patch 2/3 in to two:
intel: Change the register type from UW to UD in blorp engine
intel: Add multisample scaled blitting in blorp engine
- Modify src texture coordinates clipping to account for scaling.
- Code rewrite to avoid unwanted changes.
Anuj Phogat (4
Signed-off-by: Anuj Phogat anuj.pho...@gmail.com
Reviewed-by: Paul Berry stereotype...@gmail.com
Reviewed-by: Brian Paul bri...@vmware.com
---
src/mesa/main/extensions.c | 1 +
src/mesa/main/fbobject.c | 30 +++---
src/mesa/main/mtypes.h | 1 +
3 files changed, 29
These changes are required to implement scaled blitting in blorp
in my next patch.
No regressions observed in piglit quick-driver.tests with this patch.
Signed-off-by: Anuj Phogat anuj.pho...@gmail.com
---
src/mesa/drivers/dri/i965/brw_blorp.h| 15 ++--
src/mesa/drivers/dri/i965
filtering.
I'll work on implementing a better filtering technique in blorp.
Signed-off-by: Anuj Phogat anuj.pho...@gmail.com
---
src/mesa/drivers/dri/intel/intel_extensions.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/mesa/drivers/dri/intel/intel_extensions.c
b/src/mesa/drivers/dri
with
these changes.
Signed-off-by: Anuj Phogat anuj.pho...@gmail.com
---
src/mesa/drivers/dri/i965/brw_blorp.h | 23 ++--
src/mesa/drivers/dri/i965/brw_blorp_blit.cpp | 143 +++--
src/mesa/drivers/dri/i965/brw_reg.h| 7 --
src/mesa/drivers/dri/intel
On Fri, May 24, 2013 at 12:01 PM, Paul Berry stereotype...@gmail.com wrote:
On 16 May 2013 11:44, Anuj Phogat anuj.pho...@gmail.com wrote:
In traditional multisampled framebuffer rendering, color samples must be
explicitly resolved via BlitFramebuffer before doing the scaled blitting
On Wed, May 29, 2013 at 10:06 AM, Anuj Phogat anuj.pho...@gmail.com wrote:
On Fri, May 24, 2013 at 12:01 PM, Paul Berry stereotype...@gmail.com wrote:
On 16 May 2013 11:44, Anuj Phogat anuj.pho...@gmail.com wrote:
In traditional multisampled framebuffer rendering, color samples must
-stetch test and framebuffer_blit_functionality_magnifying_blit.test
in gles3 CTS pass.
Observed no piglit, gles3 CTS regressions on sandybridge ivybridge with
this patch.
Signed-off-by: Anuj Phogat anuj.pho...@gmail.com
Reviewed-by: Paul Berry stereotype...@gmail.com
---
src/mesa/drivers/dri
Current implementation of ext_framebuffer_multisample_blit_scaled in
i965/blorp uses nearest filtering for multisample scaled blits. Using
nearest filtering produces blocky artifacts and negates the benefits
of MSAA. That is the reason why extension was not enabled on i965.
This patch implements
, and stencil masks (see section 17.4.2)
are ignored.
Signed-off-by: Anuj Phogat anuj.pho...@gmail.com
---
src/mesa/drivers/dri/intel/intel_extensions.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/mesa/drivers/dri/intel/intel_extensions.c
b/src/mesa/drivers/dri/intel/intel_extensions.c
index
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Both patches are:
Reviewed-by: Anuj Phogat anuj.pho...@gmail.com
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
/listinfo/mesa-dev
Looks like a right thing to do and it makes a failing piglit test pass.
Reviewed-by: Anuj Phogat anuj.pho...@gmail.com
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
to sample locations.
- Test the boundary conditions on the edges of texture.
Signed-off-by: Anuj Phogat anuj.pho...@gmail.com
---
src/mesa/drivers/dri/i965/brw_blorp.h| 11 ++
src/mesa/drivers/dri/i965/brw_blorp_blit.cpp | 257 +--
2 files changed, 258 insertions
benefits of multisampling. Since your implementation is effectively
equivalent to downsampling and then blitting using GL_NEAREST filtering,
my fear is that it will lead to blocky artifacts that are severe enough
to negate the benefit of multisampling in the first place.
Anuj Phogat proposed v2:
My
://lists.freedesktop.org/mailman/listinfo/mesa-dev
Changes look good to me.
Both patches are: Reviewed-by: Anuj Phogat anuj.pho...@gmail.com
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
= intel_blit_framebuffer;
intel-ctx.Driver.EGLImageTargetRenderbufferStorage =
--
1.8.3.rc0
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Patches 3, 4-11 are Reviewed-by: Anuj Phogat anuj.pho
to sample locations.
- Test the boundary conditions on the edges of texture.
Signed-off-by: Anuj Phogat anuj.pho...@gmail.com
---
Made a small fix in setting up the interpolator value on top and bottom
edges in Y direction.
src/mesa/drivers/dri/i965/brw_blorp.h| 11 ++
src/mesa
On Tue, Jun 25, 2013 at 10:27 AM, Paul Berry stereotype...@gmail.com wrote:
On 19 June 2013 19:45, Anuj Phogat anuj.pho...@gmail.com wrote:
Current implementation of ext_framebuffer_multisample_blit_scaled in
i965/blorp uses nearest filtering for multisample scaled blits. Using
nearest
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Reviewed-by: Anuj Phogat anuj.pho...@gmail.com
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
On Tue, Jun 25, 2013 at 10:27 AM, Paul Berry stereotype...@gmail.com wrote:
On 19 June 2013 19:45, Anuj Phogat anuj.pho...@gmail.com wrote:
Current implementation of ext_framebuffer_multisample_blit_scaled in
i965/blorp uses nearest filtering for multisample scaled blits. Using
nearest
to sample locations.
- Test the boundary conditions on the edges of texture.
V4:
- Clip texcoords and use conditional MOVs.
- Send texture dimensions as push constants.
- Remove the optimization in case of scaled multisample blits.
Signed-off-by: Anuj Phogat anuj.pho...@gmail.com
---
src/mesa
Assertions are not sufficient to check for null pointers as they don't
show up in release builds. So, add explicit null pointer checks in the
code.
Signed-off-by: Anuj Phogat anuj.pho...@gmail.com
---
src/mesa/program/prog_execute.c | 10 ++
1 file changed, 10 insertions(+)
diff --git
On Thu, Jun 27, 2013 at 2:59 PM, Brian Paul bri...@vmware.com wrote:
On 06/27/2013 03:31 PM, Kenneth Graunke wrote:
On 06/27/2013 02:20 PM, Anuj Phogat wrote:
Assertions are not sufficient to check for null pointers as they don't
show up in release builds. So, add explicit null pointer
Assertions are not sufficient to check for null pointers as they don't
show up in release builds. So, return ZeroVec/dummyReg instead of NULL
pointer in get_{src,dst}_register_pointer(). This should calm down
static analysis tool.
Signed-off-by: Anuj Phogat anuj.pho...@gmail.com
---
src/mesa
+void
+brw_blorp_blit_program::manual_blend_linear(unsigned num_samples)
+{
+ if (key-tex_layout == INTEL_MSAA_LAYOUT_CMS)
+ mcs_fetch();
This won't work. The MCS value we fetch has to match up with the pixel
that we're sampling from. Since this function samples from
coordinates.
Signed-off-by: Anuj Phogat anuj.pho...@gmail.com
---
src/mesa/drivers/dri/i965/brw_blorp.h| 16 ++
src/mesa/drivers/dri/i965/brw_blorp_blit.cpp | 278 +--
2 files changed, 273 insertions(+), 21 deletions(-)
diff --git a/src/mesa/drivers/dri/i965
On Tue, Jul 9, 2013 at 6:44 PM, Chris Forbes chr...@ijw.co.nz wrote:
I think it would be clearer to do this, rather than 4 parallel checks:
Yes. It's clearer. I will make this change.
if (intel-gen = 7) {
/* rationale ... */
x0 = ROUND_DOWN_TO(x0, 2 * x_align);
y0 =
://bugs.freedesktop.org/show_bug.cgi?id=65744
Signed-off-by: Anuj Phogat anuj.pho...@gmail.com
---
src/mesa/drivers/dri/i965/brw_blorp_clear.cpp | 23 +++
1 file changed, 19 insertions(+), 4 deletions(-)
diff --git a/src/mesa/drivers/dri/i965/brw_blorp_clear.cpp
b/src/mesa
-by: Anuj Phogat anuj.pho...@gmail.com
---
src/mesa/drivers/common/meta.c | 25 +++--
1 file changed, 15 insertions(+), 10 deletions(-)
diff --git a/src/mesa/drivers/common/meta.c b/src/mesa/drivers/common/meta.c
index c62927c..155c4fa 100644
--- a/src/mesa/drivers/common/meta.c
Anuj Phogat (3):
i965/blorp: Use more appropriate variable names
i965/blorp: Define a function to clamp texture coordinates
i965/blorp: Add support for single sample scaled blit with bilinear
filter
src/mesa/drivers/dri/i965/brw_blorp.h | 15 +-
src/mesa/drivers/dri/i965
filter.
Signed-off-by: Anuj Phogat anuj.pho...@gmail.com
---
src/mesa/drivers/dri/i965/brw_blorp.h| 8 +++-
src/mesa/drivers/dri/i965/brw_blorp_blit.cpp | 24 +++-
2 files changed, 14 insertions(+), 18 deletions(-)
diff --git a/src/mesa/drivers/dri/i965/brw_blorp.h
New function clamp_tex_coords() clamps the texture coordinates
to texture boundaries. This function will also be utilized later
for the BLORP implementation of single-sample scaled blit with
bilinear filter.
Signed-off-by: Anuj Phogat anuj.pho...@gmail.com
---
src/mesa/drivers/dri/i965
this implementation are out on piglit
mailing list.
Signed-off-by: Anuj Phogat anuj.pho...@gmail.com
---
src/mesa/drivers/dri/i965/brw_blorp.h | 7 +-
src/mesa/drivers/dri/i965/brw_blorp_blit.cpp | 157 --
src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 4 +-
3 files
On Tue, Aug 6, 2013 at 3:05 PM, Paul Berry stereotype...@gmail.com wrote:
On 5 August 2013 15:37, Anuj Phogat anuj.pho...@gmail.com wrote:
Currently single sample scaled blits with GL_LINEAR filter falls
back to meta path. Patch removes this limitation in BLORP engine
and implements single
this implementation are out on piglit
mailing list.
V2:
Use sample message in place of LD message to utilize the linear/nearest
filtering (of single-sampled texture) functionality built in to hardware.
Signed-off-by: Anuj Phogat anuj.pho...@gmail.com
---
src/mesa/drivers/dri/i965/brw_blorp.h | 5
On Mon, Aug 5, 2013 at 3:00 PM, Anuj Phogat anuj.pho...@gmail.com wrote:
This patch fixes a case of framebuffer blitting with renderbuffer
as color attachment and GL_LINEAR filter. Meta implementation of
glBlitFrambuffer() converts source color buffer to a texture and
uses it to do the scaled
On Wed, Aug 14, 2013 at 10:25 AM, Paul Berry stereotype...@gmail.com wrote:
On 9 August 2013 19:01, Anuj Phogat anuj.pho...@gmail.com wrote:
Currently single sample scaled blits with GL_LINEAR filter falls
back to meta path. Patch removes this limitation in BLORP engine
and implements single
On Wed, Aug 14, 2013 at 1:46 PM, Paul Berry stereotype...@gmail.com wrote:
On 5 August 2013 15:00, Anuj Phogat anuj.pho...@gmail.com wrote:
This patch fixes a case of framebuffer blitting with renderbuffer
as color attachment and GL_LINEAR filter. Meta implementation of
glBlitFrambuffer
to utilize the linear filtering functionality
built in to hardware.
V3: Define a bool variable (bilinear_filter) to handle the conditions
for GL_LINEAR blits.
Signed-off-by: Anuj Phogat anuj.pho...@gmail.com
---
One subtest of piglit test fbo-blit-stetch fails on Sandybridge with following
logs:
45x79 (0
/listinfo/mesa-dev
This series is Reviewed-by: Anuj Phogat anuj.pho...@gmail.com
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
They immediately dropped this with Ivybridge; it's not been present on any
other platform.
fs_inst::conditional_mod represents that conditional modifier (always = 0,
never, less, equal, lequal, greater, notequal, gequal).
Thanks for explaining Ken.
Reviewed-by: Anuj Phogat anuj.pho...@gmail.com
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Both patches are:
Reviewed-by: Anuj Phogat anuj.pho...@gmail.com
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http
-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Reviewed-by: Anuj Phogat anuj.pho...@gmail.com
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo
to be set for
sampler types in GLSL (commit d5948f2). This patch makes it follow
GLSL ES rules and also allow declaring sampler variables with a
precision qualifier in GLSL.
This fixes a shader compilation error in Khronos OpenGL conformance
test depth_texture_mipmap.
Signed-off-by: Anuj Phogat anuj.pho
On Tue, Aug 27, 2013 at 11:53 AM, Ian Romanick i...@freedesktop.org wrote:
On 08/27/2013 10:45 AM, Anuj Phogat wrote:
GLSL 1.30 doesn't allow precision qualifiers on sampler types,
but in GLSL ES, sampler types are also allowed. This seems like
an oversight (since the intention of including
On Wed, Aug 28, 2013 at 4:56 PM, Ian Romanick i...@freedesktop.org wrote:
On 08/27/2013 12:52 PM, Anuj Phogat wrote:
On Tue, Aug 27, 2013 at 11:53 AM, Ian Romanick i...@freedesktop.org wrote:
On 08/27/2013 10:45 AM, Anuj Phogat wrote:
GLSL 1.30 doesn't allow precision qualifiers on sampler
-alpha-to-coverage and
sample-alpha-to-one
This series is:
Reviewed-by: Anuj Phogat anuj.pho...@gmail.com
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
;
/* _NEW_BUFFERS */
--
1.7.7.6
This patch makes piglit sample-alpha-to-coverage test pass for depth buffer.
I'll soon send out a patch to enable depth buffer testing in existing
piglit test case.
Reviewed-by: Anuj Phogat anuj.pho...@gmail.com
void
--
1.7.7.6
Reviewed-by: Anuj Phogat anuj.pho...@gmail.com
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
that
are not in integer format.
This patch makes following piglit tests pass on mesa:
int-draw-buffers-alpha-to-coverage
int-draw-buffers-alpha-to-one
Note: Patches for these piglit tests are under review on piglit mailing
list.
Signed-off-by: Anuj Phogat anuj.pho...@gmail.com
---
src/mesa/drivers/dri/i965
,
struct brw_reg src0,
--
1.7.7.6
This patch is
Reviewed-by: Anuj Phogat anuj.pho...@gmail.com
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
texturing hardware only supports the IMS layout with the
* ld2dms instruction (which blorp doesn't use). So if the source is
--
1.7.7.6
looks good to me:
Reviewed-by: Anuj Phogat anuj.pho...@gmail.com
___
mesa-dev mailing list
mesa-dev
-by: Anuj Phogat anuj.pho...@gmail.com
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
1 - 100 of 1770 matches
Mail list logo
