Re: [Mesa-dev] [PATCH] etnaviv: make use of TEXTURE_TYPE_1D

2017-10-26 Thread Christian Gmeiner
2017-10-26 9:45 GMT+02:00 Lucas Stach <l.st...@pengutronix.de>: > Am Donnerstag, den 26.10.2017, 03:17 +0200 schrieb Christian Gmeiner: >> Signed-off-by: Christian Gmeiner <christian.gmei...@gmail.com> > > Has this been tested on older GPU cores like the GC600? >

Re: [Mesa-dev] [PATCH] etnaviv: dirty TS state when framebuffer has changed

2018-01-21 Thread Christian Gmeiner
engutronix.de> Reviewed-by: Christian Gmeiner <christian.gmei...@gmail.com> > --- > src/gallium/drivers/etnaviv/etnaviv_state.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/src/gallium/drivers/etnaviv/etnaviv_state.c > b/src/gallium/drivers/etnaviv

Re: [Mesa-dev] [PATCH] etnaviv: add useful information to BO import errors

2018-02-13 Thread Christian Gmeiner
2018-02-12 15:25 GMT+01:00 Lucas Stach <l.st...@pengutronix.de>: > From: Philipp Zabel <p.za...@pengutronix.de> > > Signed-off-by: Philipp Zabel <p.za...@pengutronix.de> Reviewed-by: Christian Gmeiner <christian.gmei...@gmail.com> > --- > src/gallium

Re: [Mesa-dev] [PATCH 1/3] etnaviv: add debug switch to disable single buffer feature

2018-02-13 Thread Christian Gmeiner
LE)) >screen->specs.can_supertile = 0; > + if (DBG_ENABLED(ETNA_DBG_NO_SINGLEBUF)) > + screen->specs.single_buffer = 0; > > pscreen->destroy = etna_screen_destroy; > pscreen->get_param = etna_screen_get_param; > -- > 2.15.1 > >

[Mesa-dev] [PATCH] etnaviv: enable glsl/tgsi on-disk cache

2018-02-20 Thread Christian Gmeiner
Signed-off-by: Christian Gmeiner <christian.gmei...@gmail.com> --- src/gallium/drivers/etnaviv/etnaviv_screen.c | 36 src/gallium/drivers/etnaviv/etnaviv_screen.h | 2 ++ 2 files changed, 38 insertions(+) diff --git a/src/gallium/drivers/etnaviv/etnaviv_scree

[Mesa-dev] [PATCH] etnaviv: npot_tex_any_wrap needs one bit only

2018-02-20 Thread Christian Gmeiner
Reduces size of struct etna_specs from 100 to 94 bytes. Signed-off-by: Christian Gmeiner <christian.gmei...@gmail.com> --- src/gallium/drivers/etnaviv/etnaviv_internal.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/etnaviv/etnaviv_internal.h

Re: [Mesa-dev] [PATCH] etnaviv: disable in-place resolve for non-supertiled surfaces

2018-01-01 Thread Christian Gmeiner
by: Lucas Stach <l.st...@pengutronix.de> Reviewed-by: Christian Gmeiner <christian.gmei...@gmail.com> > --- > src/gallium/drivers/etnaviv/etnaviv_rs.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/src/gallium/drivers/etnaviv/etnaviv_rs.c > b/src/galliu

Re: [Mesa-dev] [PATCH 1/2] loader: add loader_open_name(..)

2018-08-02 Thread Christian Gmeiner
Hi Eric Thanks for you code review! Am Do., 2. Aug. 2018 um 13:09 Uhr schrieb Eric Engestrom : > > On Wednesday, 2018-08-01 23:07:02 +0200, Christian Gmeiner wrote: > > Add an improved drmOpenWithType(..) clone which fixes some serious > > flaws. Some highlights: > >

[Mesa-dev] [PATCH v2 01/11] util/list: Make some helpers take const lists

2018-07-29 Thread Christian Gmeiner
Reviewed-by: Christian Gmeiner Jason Ekstrand schrieb am So., 29. Juli 2018, 07:46: > They're all just querying things about the list and not mutating > anything. > > Reviewed-by: Thomas Helland > --- > src/util/list.h | 8 > 1 file changed, 4 insertions(+), 4

[Mesa-dev] [PATCH 1/2] loader: add loader_open_name(..)

2018-08-01 Thread Christian Gmeiner
- borderline hacks with massive documentation [1] to keep this running. Signed-off-by: Christian Gmeiner --- src/loader/loader.c | 79 + src/loader/loader.h | 3 ++ 2 files changed, 82 insertions(+) diff --git a/src/loader/loader.c b/src/loader

[Mesa-dev] [PATCH 2/2] imx: make use of loader_open_name(..)

2018-08-01 Thread Christian Gmeiner
Gets rid of hard-coded gpu device path. Signed-off-by: Christian Gmeiner --- src/gallium/winsys/imx/drm/imx_drm_winsys.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/winsys/imx/drm/imx_drm_winsys.c b/src/gallium/winsys/imx/drm/imx_drm_winsys.c index

[Mesa-dev] [PATCH] etnaviv: fix typo in query names

2018-07-30 Thread Christian Gmeiner
Fixes: d0bed0b4944d ("etnaviv: support HI performance counters") Cc: mesa-sta...@lists.freedesktop.org Signed-off-by: Christian Gmeiner --- src/gallium/drivers/etnaviv/etnaviv_query_pm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/gallium/drive

[Mesa-dev] [PATCH 4/4] imx: make use of loader_open_render_node(..) helper

2018-08-08 Thread Christian Gmeiner
Gets rid of hard-coded gpu device path. Signed-off-by: Christian Gmeiner --- src/gallium/winsys/imx/drm/imx_drm_winsys.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/gallium/winsys/imx/drm/imx_drm_winsys.c b/src/gallium/winsys/imx/drm/imx_drm_winsys.c index

[Mesa-dev] [PATCH 2/4] loader: add loader_open_render_node(..)

2018-08-08 Thread Christian Gmeiner
This helper is almost a 1:1 copy of tegra_open_render_node(). Signed-off-by: Christian Gmeiner --- src/loader/loader.c | 65 + src/loader/loader.h | 3 +++ 2 files changed, 68 insertions(+) diff --git a/src/loader/loader.c b/src/loader/loader.c

[Mesa-dev] [PATCH 3/4] tegra: make use loader_open_render_node(..) helper

2018-08-08 Thread Christian Gmeiner
Signed-off-by: Christian Gmeiner --- src/gallium/drivers/tegra/tegra_screen.c | 61 +--- 1 file changed, 2 insertions(+), 59 deletions(-) diff --git a/src/gallium/drivers/tegra/tegra_screen.c b/src/gallium/drivers/tegra/tegra_screen.c index 361ec034de..243bdde8d2 100644

[Mesa-dev] [PATCH 1/4] tegra: fix memory leak

2018-08-08 Thread Christian Gmeiner
Signed-off-by: Christian Gmeiner --- src/gallium/drivers/tegra/tegra_screen.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/drivers/tegra/tegra_screen.c b/src/gallium/drivers/tegra/tegra_screen.c index 034ea271ee..361ec034de 100644 --- a/src/gallium/drivers/tegra

[Mesa-dev] [PATCH 0/4] Add and make use of loader_open_render_node(..)

2018-08-08 Thread Christian Gmeiner
Factor out tegra_open_render_node() into a helper and make use of it. Suggested-by: Emil Velikov Christian Gmeiner (4): tegra: fix memory leak loader: add loader_open_render_node(..) tegra: make use loader_open_render_node(..) helper imx: make use of loader_open_render_node(..) helper

Re: [Mesa-dev] [PATCH 1/4] tegra: fix memory leak

2018-08-09 Thread Christian Gmeiner
Am Do., 9. Aug. 2018 um 12:23 Uhr schrieb Emil Velikov : > > On 9 August 2018 at 06:12, Christian Gmeiner > wrote: > > Signed-off-by: Christian Gmeiner > > --- > > src/gallium/drivers/tegra/tegra_screen.c | 1 + > > 1 file changed, 1 insertion(+) > > >

Re: [Mesa-dev] [1/2] loader: add loader_open_name(..)

2018-08-14 Thread Christian Gmeiner
Am Fr., 10. Aug. 2018 um 19:52 Uhr schrieb Emil Velikov : > > On 10 August 2018 at 13:25, Martin Fuzzey > wrote: > > Hi Christian, > > > > On 01/08/18 23:07, Christian Gmeiner wrote: > >> > >> Add an improved drmOpenWithType(..) clone which f

Re: [Mesa-dev] [PATCH] st/nir: Fix st_nir_opts() prototype.

2018-07-25 Thread Christian Gmeiner
Reviewed-by: Christian Gmeiner -- Christian Gmeiner, MSc https://christian-gmeiner.info Kenneth Graunke schrieb am Di., 24. Juli 2018, 23:55: > This wasn't updated for the new scalar ISA parameter. It worked anyway > because all the function's callers live in the same file, so it

[Mesa-dev] [PATCH 1/2] nir: add lowering for ffloor

2018-09-01 Thread Christian Gmeiner
Signed-off-by: Christian Gmeiner --- src/compiler/nir/nir.h| 3 +++ src/compiler/nir/nir_opt_algebraic.py | 1 + 2 files changed, 4 insertions(+) diff --git a/src/compiler/nir/nir.h b/src/compiler/nir/nir.h index 169fa1fa20..d81eefc032 100644 --- a/src/compiler/nir/nir.h +++ b

[Mesa-dev] [PATCH 2/2] nir: add lowering for fceil

2018-09-01 Thread Christian Gmeiner
Signed-off-by: Christian Gmeiner --- src/compiler/nir/nir.h| 3 +++ src/compiler/nir/nir_opt_algebraic.py | 1 + 2 files changed, 4 insertions(+) diff --git a/src/compiler/nir/nir.h b/src/compiler/nir/nir.h index d81eefc032..1dcc221777 100644 --- a/src/compiler/nir/nir.h +++ b

Re: [Mesa-dev] [PATCH 2/2] nir: add lowering for fceil

2018-09-01 Thread Christian Gmeiner
Am Sa., 1. Sep. 2018 um 21:15 Uhr schrieb Christian Gmeiner : > > Signed-off-by: Christian Gmeiner > --- > src/compiler/nir/nir.h| 3 +++ > src/compiler/nir/nir_opt_algebraic.py | 1 + > 2 files changed, 4 insertions(+) > > diff --git a/src/compiler/nir/

Re: [Mesa-dev] [PATCH v2 1/7] st/mesa: use real bool for can_ubo

2018-09-04 Thread Christian Gmeiner
Am Di., 4. Sep. 2018 um 11:09 Uhr schrieb Erik Faye-Lund : > > We're doing full c99 now, so there's no point in using the old boolean > type. > > Signed-off-by: Erik Faye-Lund > Reviewed-by: Marek Olšák Reviewed-by: Christian Gmeiner > --- > src/mesa/state_tra

[Mesa-dev] [PATCH] etnaviv: remove superfluous \n from DBG(..) callers

2018-03-10 Thread Christian Gmeiner
The DBG(..) macro appends a \n already so there is no need to do it twice. Signed-off-by: Christian Gmeiner <christian.gmei...@gmail.com> --- src/gallium/drivers/etnaviv/etnaviv_blt.c | 2 +- src/gallium/drivers/etnaviv/etnaviv_rs.c| 2 +- src/gallium/drivers/e

[Mesa-dev] [PATCH] etnaviv: add layout string to resource debug output

2018-03-10 Thread Christian Gmeiner
This is quite helpful for debug purposes. Signed-off-by: Christian Gmeiner <christian.gmei...@gmail.com> --- src/gallium/drivers/etnaviv/etnaviv_resource.c | 24 ++-- 1 file changed, 22 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/etnaviv/etnaviv_reso

Re: [Mesa-dev] [PATCH] travis: bump libxcb version to 1.13

2018-03-10 Thread Christian Gmeiner
2018-03-10 16:19 GMT+01:00 Daniel Stone <dan...@fooishbar.org>: > On 10 March 2018 at 14:53, Christian Gmeiner > <christian.gmei...@gmail.com> wrote: >> Fixes following dependency problem: >> Native dependency xcb-dri3 found: NO found '1.11' but need: '>= 1.13' &

[Mesa-dev] [PATCH] travis: bump libxcb version to 1.13

2018-03-10 Thread Christian Gmeiner
Fixes following dependency problem: Native dependency xcb-dri3 found: NO found '1.11' but need: '>= 1.13' Signed-off-by: Christian Gmeiner <christian.gmei...@gmail.com> --- .travis.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.travis.yml b/.travis.

Re: [Mesa-dev] [PATCH] etnaviv: allow mixing different bit depths for color and depth surfaces

2018-03-09 Thread Christian Gmeiner
2018-03-08 10:20 GMT+01:00 Lucas Stach <l.st...@pengutronix.de>: > Vivante hardware supports this just fine. There is no reason why this > shouldn't > be advertised as a valid combination. > > Signed-off-by: Lucas Stach <l.st...@pengutronix.de> Reviewed-by: Christ

[Mesa-dev] [PATCH] freedreno: bump required libdrm version

2018-03-06 Thread Christian Gmeiner
Fixes: 26a9321d0a "freedreno: add global_bindings state" Signed-off-by: Christian Gmeiner <christian.gmei...@gmail.com> --- configure.ac | 2 +- meson.build | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/configure.ac b/configure.ac index d8093597dd..1

Re: [Mesa-dev] [PATCH 08/12] etnaviv: support TX performance counters

2018-04-06 Thread Christian Gmeiner
2018-03-29 16:25 GMT+02:00 Lucas Stach <l.st...@pengutronix.de>: > Am Sonntag, den 25.03.2018, 22:30 +0200 schrieb Christian Gmeiner: >> > Signed-off-by: Christian Gmeiner <christian.gmei...@gmail.com> >> --- >> src/gallium/dri

[Mesa-dev] [PATCH] etnaviv: sw queries: return correct number of groups

2018-04-06 Thread Christian Gmeiner
Fixes: 3d912bd742ed ("etnaviv: add query_group_info for sw counters") Signed-off-by: Christian Gmeiner <christian.gmei...@gmail.com> --- src/gallium/drivers/etnaviv/etnaviv_query_sw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium

Re: [Mesa-dev] [PATCH] etnaviv: meson: add etnaviv_query_pm.[ch] to the sources

2018-04-09 Thread Christian Gmeiner
. > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=105960 > Fixes: 72d2043be06 ("etnaviv: add perfmon query implementation") > Cc: Christian Gmeiner <christian.gmei...@gmail.com> > Cc: Clayton Craft <clayton.a.cr...@intel.com> > Signed-off-by: Emil Velikov

[Mesa-dev] [RFC PATCH] nir: extend nir_shader_compiler_options with is_scalar

2018-04-05 Thread Christian Gmeiner
As not every (upcoming) backend compiler is happy with nir_lower_xxx_to_scalar lowerings do them only if the backend is scalar (and not vec4) based. Signed-off-by: Christian Gmeiner <christian.gmei...@gmail.com> --- src/amd/vulkan/radv_shader.c| 1 + src/broadcom/co

Re: [Mesa-dev] [PATCH kmscube 1/4] drm-atomic: Fix indentation

2018-04-05 Thread Christian Gmeiner
2018-04-05 15:44 GMT+02:00 Thierry Reding <thierry.red...@gmail.com>: > From: Thierry Reding <tred...@nvidia.com> > > One of the error returns ended up being indented twice. Fix it. > > Signed-off-by: Thierry Reding <tred...@nvidia.com> Reviewed-by: Christian Gme

Re: [Mesa-dev] [PATCH kmscube 2/4] Pass struct drm to init_gbm()

2018-04-05 Thread Christian Gmeiner
t_gbm() needs to access, so passing in the struct make sure these > will be available. > > Based on work by Lucas Stach <l.st...@pengutronix.de>. > > Signed-off-by: Thierry Reding <tred...@nvidia.com> Reviewed-by: Christian Gmeiner <christian.gmei...@gmail.com> >

Re: [Mesa-dev] [RFC PATCH] nir: extend nir_shader_compiler_options with is_scalar

2018-04-05 Thread Christian Gmeiner
- thanks for your comments! -- greets -- Christian Gmeiner, MSc https://christian-gmeiner.info ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH 1/2] etnaviv: remove redundant include

2018-04-20 Thread Christian Gmeiner
Signed-off-by: Christian Gmeiner <christian.gmei...@gmail.com> --- src/gallium/drivers/etnaviv/etnaviv_rs.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/gallium/drivers/etnaviv/etnaviv_rs.c b/src/gallium/drivers/etnaviv/etnaviv_rs.c index b8a3b12ae4..fc4f65dbee 100644 ---

[Mesa-dev] [PATCH 2/2] etnaviv: remove not needed includes

2018-04-20 Thread Christian Gmeiner
Signed-off-by: Christian Gmeiner <christian.gmei...@gmail.com> --- src/gallium/drivers/etnaviv/etnaviv_translate.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/gallium/drivers/etnaviv/etnaviv_translate.h b/src/gallium/drivers/etnaviv/etnaviv_translate.h index 7c85f81a70..88ce

[Mesa-dev] [PATCH V2 kmscube] cube-tex: make use of modifiers

2018-04-02 Thread Christian Gmeiner
Fixes rendering issues with mode rgba on etnaviv. I have applied the same change for nv12 variants but they are not supported on etnaviv. Signed-off-by: Christian Gmeiner <christian.gmei...@gmail.com> --- common.c | 3 +++ common.h | 19 + cube-tex.

Re: [Mesa-dev] [PATCH kmscube 1/2] Rework default modifier handling

2018-04-02 Thread Christian Gmeiner
e'll fallback to MOD_LINEAR. > > Simplify things to a) use MOD_LINEAR by default b) use the user modifier > - even if they request MOD_INVALID. > > Signed-off-by: Emil Velikov <emil.veli...@collabora.com> Reviewed-by: Christian Gmeiner <ch

Re: [Mesa-dev] [PATCH kmscube 2/2] Use weak functions to handle lack of gbm modifiers

2018-04-02 Thread Christian Gmeiner
, yet allowing the > modifiers codepath to work if API is available. > > Cc: Christian Gmeiner <christian.gmei...@gmail.com> > Cc: Rob Clark <robdcl...@gmail.com> > Signed-off-by: Emil Velikov <emil.veli...@collabora.com> Reviewed-by: Christian Gm

[Mesa-dev] [PATCH 06/12] etnaviv: support SE performance counters

2018-03-25 Thread Christian Gmeiner
Signed-off-by: Christian Gmeiner <christian.gmei...@gmail.com> --- src/gallium/drivers/etnaviv/etnaviv_query_pm.c | 14 ++ src/gallium/drivers/etnaviv/etnaviv_query_pm.h | 3 +++ 2 files changed, 17 insertions(+) diff --git a/src/gallium/drivers/etnaviv/etnaviv_query_pm.c

[Mesa-dev] [PATCH 04/12] etnaviv: support SH performance counters

2018-03-25 Thread Christian Gmeiner
Signed-off-by: Christian Gmeiner <christian.gmei...@gmail.com> --- src/gallium/drivers/etnaviv/etnaviv_query_pm.c | 63 ++ src/gallium/drivers/etnaviv/etnaviv_query_pm.h | 10 2 files changed, 73 insertions(+) diff --git a/src/gallium/drivers/e

[Mesa-dev] [PATCH 02/12] etnaviv: support HI performance counters

2018-03-25 Thread Christian Gmeiner
Signed-off-by: Christian Gmeiner <christian.gmei...@gmail.com> --- src/gallium/drivers/etnaviv/etnaviv_query_pm.c | 35 ++ src/gallium/drivers/etnaviv/etnaviv_query_pm.h | 6 + 2 files changed, 41 insertions(+) diff --git a/src/gallium/drivers/e

[Mesa-dev] [PATCH 07/12] etnaviv: support RA performance counters

2018-03-25 Thread Christian Gmeiner
Signed-off-by: Christian Gmeiner <christian.gmei...@gmail.com> --- src/gallium/drivers/etnaviv/etnaviv_query_pm.c | 49 ++ src/gallium/drivers/etnaviv/etnaviv_query_pm.h | 8 + 2 files changed, 57 insertions(+) diff --git a/src/gallium/drivers/e

[Mesa-dev] [PATCH 03/12] etnaviv: support PE performance counters

2018-03-25 Thread Christian Gmeiner
Signed-off-by: Christian Gmeiner <christian.gmei...@gmail.com> --- src/gallium/drivers/etnaviv/etnaviv_query_pm.c | 28 ++ src/gallium/drivers/etnaviv/etnaviv_query_pm.h | 6 ++ 2 files changed, 34 insertions(+) diff --git a/src/gallium/drivers/e

[Mesa-dev] [PATCH 01/12] etnaviv: add perfmon query implementation

2018-03-25 Thread Christian Gmeiner
Add needed infrastructure to use performance monitor requests for queries. Signed-off-by: Christian Gmeiner <christian.gmei...@gmail.com> --- configure.ac | 2 +- meson.build| 2 +- src/gallium/drivers/e

[Mesa-dev] [PATCH 10/12] etnaviv: assign group_ids to perfmon queries

2018-03-25 Thread Christian Gmeiner
Prep work for AMD_performance_monitor support. Signed-off-by: Christian Gmeiner <christian.gmei...@gmail.com> --- src/gallium/drivers/etnaviv/etnaviv_query_pm.c | 48 +- src/gallium/drivers/etnaviv/etnaviv_query_pm.h | 9 + 2 files changed, 56 insertions

[Mesa-dev] [PATCH 11/12] etnaviv: add query_group_info for perfmon counters

2018-03-25 Thread Christian Gmeiner
Signed-off-by: Christian Gmeiner <christian.gmei...@gmail.com> --- src/gallium/drivers/etnaviv/etnaviv_query_pm.c | 45 ++ src/gallium/drivers/etnaviv/etnaviv_query_pm.h | 5 +++ 2 files changed, 50 insertions(+) diff --git a/src/gallium/drivers/e

[Mesa-dev] [PATCH 09/12] etnaviv: support MC performance counters

2018-03-25 Thread Christian Gmeiner
Signed-off-by: Christian Gmeiner <christian.gmei...@gmail.com> --- src/gallium/drivers/etnaviv/etnaviv_query_pm.c | 21 + src/gallium/drivers/etnaviv/etnaviv_query_pm.h | 4 2 files changed, 25 insertions(+) diff --git a/src/gallium/drivers/etnaviv/etnaviv_query_p

[Mesa-dev] [PATCH 08/12] etnaviv: support TX performance counters

2018-03-25 Thread Christian Gmeiner
Signed-off-by: Christian Gmeiner <christian.gmei...@gmail.com> --- src/gallium/drivers/etnaviv/etnaviv_query_pm.c | 63 ++ src/gallium/drivers/etnaviv/etnaviv_query_pm.h | 10 2 files changed, 73 insertions(+) diff --git a/src/gallium/drivers/e

[Mesa-dev] [PATCH 05/12] etnaviv: support PA performance counters

2018-03-25 Thread Christian Gmeiner
Signed-off-by: Christian Gmeiner <christian.gmei...@gmail.com> --- src/gallium/drivers/etnaviv/etnaviv_query_pm.c | 42 ++ src/gallium/drivers/etnaviv/etnaviv_query_pm.h | 7 + 2 files changed, 49 insertions(+) diff --git a/src/gallium/drivers/e

[Mesa-dev] [PATCH 00/12] etnaviv: support performance monitor

2018-03-25 Thread Christian Gmeiner
Starting with kernel 4.16 the etnaviv driver exports perfmon domains and signals to userspace. This patch series adds support for those queries to mesa and exposes them via amd_performance_monitor. Passes all amd_performance_monitor piglits. Christian Gmeiner (12): etnaviv: add perfmon query

[Mesa-dev] [PATCH 12/12] etnaviv: expose perfmon query groups

2018-03-25 Thread Christian Gmeiner
Signed-off-by: Christian Gmeiner <christian.gmei...@gmail.com> --- src/gallium/drivers/etnaviv/etnaviv_query.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/etnaviv/etnaviv_query.c b/src/gallium/drivers/etnaviv/etnaviv_query.c index 00f8

Re: [Mesa-dev] [PATCH 2/2] etnaviv: advertise YUV formats as external only

2018-04-04 Thread Christian Gmeiner
t;l.st...@pengutronix.de> Reviewed-by: Christian Gmeiner <christian.gmei...@gmail.com> > --- > src/gallium/drivers/etnaviv/etnaviv_screen.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/gallium/drivers/etnaviv/etnaviv_screen.c > b/s

Re: [Mesa-dev] [PATCH 1/2] gallium/util: implement util_format_is_yuv

2018-04-04 Thread Christian Gmeiner
2018-03-29 16:15 GMT+02:00 Lucas Stach <l.st...@pengutronix.de>: > This adds a helper to check if a pipe format is in YUV color space. > Drivers want to know about this, as YUV mostly needs special handling. > > Signed-off-by: Lucas Stach <l.st...@pengutronix.de> Review

[Mesa-dev] [PATCH kmscube] cube-tex: make use of modifiers

2018-03-20 Thread Christian Gmeiner
Fixes rendering issues with mode rgba on etnaviv. I have applied the same change for nv12 variants but they are not supported on etnaviv. Signed-off-by: Christian Gmeiner <christian.gmei...@gmail.com> --- cube-tex.c | 32 1 file changed, 24 insertions

[Mesa-dev] [PATCH 1/2] etnaviv: add query_group_info for sw counters

2018-03-05 Thread Christian Gmeiner
Signed-off-by: Christian Gmeiner <christian.gmei...@gmail.com> --- src/gallium/drivers/etnaviv/etnaviv_query_sw.c | 30 -- src/gallium/drivers/etnaviv/etnaviv_query_sw.h | 5 + 2 files changed, 29 insertions(+), 6 deletions(-) diff --git a/src/gallium/drivers/e

[Mesa-dev] [PATCH 2/2] etnaviv: add get_driver_query_group_info(..)

2018-03-05 Thread Christian Gmeiner
This enables AMD_performance_monitor extension. Signed-off-by: Christian Gmeiner <christian.gmei...@gmail.com> --- src/gallium/drivers/etnaviv/etnaviv_query.c | 13 + 1 file changed, 13 insertions(+) diff --git a/src/gallium/drivers/etnaviv/etnaviv_query.c b/src/gallium/d

[Mesa-dev] [PATCH 0/2] etnaviv: amd_performance_monitor support

2018-03-05 Thread Christian Gmeiner
Nothing fancy - passes all amd_performance_monitor piglits. Christian Gmeiner (2): etnaviv: add query_group_info for sw counters etnaviv: add get_driver_query_group_info(..) src/gallium/drivers/etnaviv/etnaviv_query.c| 13 +++ src/gallium/drivers/etnaviv/etnaviv_query_sw.c | 30

[Mesa-dev] [PATCH] nir: call nir_index_local_regs(..) to update reg_alloc

2018-06-24 Thread Christian Gmeiner
After calling nir_lower_regs_to_ssa(..) nir_function_impl's reg_alloc counter still hold its old value. Just call nir_index_local_regs(..) to set reg_alloc to the correct value - which should be 0. Signed-off-by: Christian Gmeiner --- src/compiler/nir/nir_lower_regs_to_ssa.c | 2 ++ 1 file

Re: [Mesa-dev] [PATCH] mesa/st: Only call nir_lower_io_to_scalar_early on scalar ISAs

2018-10-21 Thread Christian Gmeiner
t; > With this patch, Panfrost is able to consume NIR directly, rather than > TGSI with the TGSI->NIR conversion. > > For how this affects Lima, see > https://www.mail-archive.com/mesa-dev@lists.freedesktop.org/msg189216.html > > Signed-off-by: Alyssa Rosenzweig Reviewed-b

Re: [Mesa-dev] [RFC 31/31] nir: Add a bool to float32 lowering pass

2018-10-22 Thread Christian Gmeiner
it easy to support vivante gpus with and without integer support I can give this pass a try over the weekend if you want. -- greets -- Christian Gmeiner, MSc https://christian-gmeiner.info ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [RFC 31/31] nir: Add a bool to float32 lowering pass

2018-10-23 Thread Christian Gmeiner
bit_size == 1) { > >> + nir_const_value value = load->value; > >> + for (unsigned i = 0; i < load->def.num_components; i++) > >> + load->value.u32[i] = value.b[i] ? NIR_TRUE : NIR_FALSE; > > > > value.f32[i] = value.b[i] ? 1.0 : 0.0 > > > >> + load->def.bit_size = 32; > >> + progress = true; > >> +} > >> +break; > >> + } > >> + > >> + case nir_instr_type_intrinsic: > >> + case nir_instr_type_ssa_undef: > >> + case nir_instr_type_phi: > >> + case nir_instr_type_tex: > >> +nir_foreach_ssa_def(instr, rewrite_1bit_ssa_def_to_32bit, > >> +); > >> +break; > >> + > >> + default: > >> +nir_foreach_ssa_def(instr, assert_ssa_def_is_not_1bit, NULL); > >> + } > >> + } > >> + } > >> + > >> + if (progress) { > >> + nir_metadata_preserve(impl, nir_metadata_block_index | > >> + nir_metadata_dominance); > >> + } > >> + > >> + return progress; > >> +} > >> + > >> +bool > >> +nir_lower_bool_to_int32(nir_shader *shader) > > > > int32... > > > >> +{ > >> + bool progress = false; > >> + > >> + nir_foreach_function(function, shader) { > >> + if (function->impl && nir_lower_bool_to_int32_impl(function->impl)) > >> + progress = true; > >> + } > >> + > >> + return progress; > >> +} > >> -- > >> 2.19.1 > >> > >> ___ > >> mesa-dev mailing list > >> mesa-dev@lists.freedesktop.org > >> https://lists.freedesktop.org/mailman/listinfo/mesa-dev > > ___ > > mesa-dev mailing list > > mesa-dev@lists.freedesktop.org > > https://lists.freedesktop.org/mailman/listinfo/mesa-dev > > > > ___ > mesa-dev mailing list > mesa-dev@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/mesa-dev -- greets -- Christian Gmeiner, MSc https://christian-gmeiner.info ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH] Revert "imx: make use of loader_open_render_node(..) helper"

2018-10-29 Thread Christian Gmeiner
, instead of a devicetree node. A patch set to fix this problem was send out [1] but it looks like that a proper solution needs more time to bake. [1] https://lists.freedesktop.org/archives/dri-devel/2018-October/194651.html Suggested-by: Emil Velikov Signed-off-by: Christian Gmeiner --- src/gallium

Re: [Mesa-dev] [PATCH 1/2] nir: add lowering for ffloor

2018-11-12 Thread Christian Gmeiner
Hi Jason Am Sa., 1. Sep. 2018 um 21:23 Uhr schrieb Jason Ekstrand : > > I don't think either of these work for negative numbers > I would like to land this patch - can you provide some details why this does not work for negative numbers? > On September 1, 2018 14:16:11 Chris

Re: [Mesa-dev] [PATCH 1/3] nir: add fceil lowering

2018-11-12 Thread Christian Gmeiner
Am Mo., 12. Nov. 2018 um 19:17 Uhr schrieb Jonathan Marek : > > lowers ceil(x) as -floor(-x) > > Signed-off-by: Jonathan Marek Reviewed-by: Christian Gmeiner > --- > src/compiler/nir/nir.h| 3 +++ > src/compiler/nir/nir_opt_algebraic.py | 1 + > 2 fil

Re: [Mesa-dev] [PATCH 02/11] util: Add macro to get number of elements in dynarray

2018-09-21 Thread Christian Gmeiner
Am Sa., 15. Sep. 2018 um 07:45 Uhr schrieb Caio Marcelo de Oliveira Filho : > > --- > > I've ended up not using this macro in this series, but it is useful > for other cases, so kept it here. > I could make use of it. Reviewed-by: Christian Gmeiner > src/util/u_dynar

[Mesa-dev] [PATCH v2] etnaviv: fix resource usage tracking across different pipe_context's

2019-01-02 Thread Christian Gmeiner
A pipe_resource can be shared by all the pipe_context's hanging off the same pipe_screen. Changes from v1 -> v2: - to remove the resource from the used_resources set when it is destroyed Signed-off-by: Christian Gmeiner --- src/gallium/drivers/etnaviv/etnaviv_context.c | 21

[Mesa-dev] [PATCH 2/4] etnaviv: update headers from rnndb

2019-01-20 Thread Christian Gmeiner
Update to etna_viv commit 4d2f857. Signed-off-by: Christian Gmeiner --- .../drivers/etnaviv/hw/cmdstream.xml.h| 8 +- src/gallium/drivers/etnaviv/hw/common.xml.h | 171 +- .../drivers/etnaviv/hw/common_3d.xml.h| 12 +- src/gallium/drivers/etnaviv/hw

[Mesa-dev] [PATCH 4/4] etnaviv: hook up linear texture sampling support

2019-01-20 Thread Christian Gmeiner
If the GPU supports linear sampling, linear addressing mode will be used as default. Signed-off-by: Christian Gmeiner --- src/gallium/drivers/etnaviv/etnaviv_resource.c | 10 +++--- src/gallium/drivers/etnaviv/etnaviv_texture.c | 4 +++- 2 files changed, 10 insertions(+), 4 deletions

[Mesa-dev] [PATCH 1/4] etnaviv: extend etna_resource with an addressing mode

2019-01-20 Thread Christian Gmeiner
Defines how sampler (and pixel pipes) needs to access the data represented with a resource. The used default is mode is ETNA_ADDRESSING_MODE_TILED. Signed-off-by: Christian Gmeiner --- src/gallium/drivers/etnaviv/etnaviv_resource.c | 17 +++-- src/gallium/drivers/etnaviv

[Mesa-dev] [PATCH 3/4] etnaviv: add linear sampling support

2019-01-20 Thread Christian Gmeiner
Signed-off-by: Christian Gmeiner --- .../drivers/etnaviv/etnaviv_texture_state.c | 21 +++ .../drivers/etnaviv/etnaviv_texture_state.h | 1 + 2 files changed, 22 insertions(+) diff --git a/src/gallium/drivers/etnaviv/etnaviv_texture_state.c b/src/gallium/drivers/etnaviv

[Mesa-dev] [PATCH] meson: make it possible to build etnaviv's cmdline compiler

2018-12-13 Thread Christian Gmeiner
Signed-off-by: Christian Gmeiner --- meson.build | 2 +- meson_options.txt | 2 +- src/gallium/drivers/etnaviv/meson.build | 3 ++- 3 files changed, 4 insertions(+), 3 deletions(-) diff --git a/meson.build b/meson.build index fe647f682c

Re: [Mesa-dev] [RFC PATCH 0/5] last call for autotools (meson travis fixes)

2018-12-12 Thread Christian Gmeiner
gh Travis CI. I helped me to find missing parts in makefiles etc. -- greets -- Christian Gmeiner, MSc https://christian-gmeiner.info ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] etnaviv: Consolidate buffer references from framebuffers

2018-12-17 Thread Christian Gmeiner
Tomeu Vizoso > Reported-by: Sjoerd Simons Reviewed-by: Christian Gmeiner > --- > src/gallium/drivers/etnaviv/etnaviv_context.c | 10 ++ > src/gallium/drivers/etnaviv/etnaviv_internal.h | 1 - > src/gallium/drivers/etnaviv/etnaviv_state.c| 8 +++- > 3 files ch

[Mesa-dev] [PATCH] etnaviv: drop redundant ctx function parameter

2018-12-12 Thread Christian Gmeiner
There is no need to have an extra ctx paramter as all the other parameters carry all the needed information. Signed-off-by: Christian Gmeiner --- src/gallium/drivers/etnaviv/etnaviv_shader.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/src/gallium/drivers/etnaviv

Re: [Mesa-dev] [PATCH] meson: make it possible to build etnaviv's cmdline compiler

2018-12-15 Thread Christian Gmeiner
Hi Dylan Am Fr., 14. Dez. 2018 um 20:13 Uhr schrieb Dylan Baker : > > Quoting Christian Gmeiner (2018-12-13 12:07:23) > > Signed-off-by: Christian Gmeiner > > --- > > meson.build | 2 +- > > meson_options.txt |

Re: [Mesa-dev] [PATCH 1/3] nir: add fceil lowering

2018-11-19 Thread Christian Gmeiner
Am Mo., 12. Nov. 2018 um 19:17 Uhr schrieb Jonathan Marek : > > lowers ceil(x) as -floor(-x) > > Signed-off-by: Jonathan Marek Do you have push rights? As I am interested in this one I would push it for you if needed. -- greets -- Christian Gmeiner, MSc https://christian-

Re: [Mesa-dev] [PATCH 1/3] nir: add fceil lowering

2018-11-19 Thread Christian Gmeiner
Am Mo., 19. Nov. 2018 um 21:17 Uhr schrieb Jonathan marek : > > I don't have push rights, but robclark added this patch to his staging > branch so I imagine he will push it soon. > Great.. > On 11/19/2018 03:15 PM, Christian Gmeiner wrote: > > Am Mo., 12. Nov. 2018 um 19:17

Re: [Mesa-dev] [PATCH] etnaviv_screen: Fix typo in cflush_all description

2019-01-07 Thread Christian Gmeiner
Am Mo., 7. Jan. 2019 um 15:00 Uhr schrieb Guido Günther : > > Signed-off-by: Guido Günther Reviewed-by: Christian Gmeiner > --- > src/gallium/drivers/etnaviv/etnaviv_screen.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/gallium/drivers/etn

Re: [Mesa-dev] [PATCH v2 1/2] etnaviv: enable full overwrite in a few more cases

2018-12-28 Thread Christian Gmeiner
s Stach Reviewed-by: Christian Gmeiner > --- > v2: clarify comment > --- > src/gallium/drivers/etnaviv/etnaviv_blend.c | 11 +++ > 1 file changed, 7 insertions(+), 4 deletions(-) > > diff --git a/src/gallium/drivers/etnaviv/etnaviv_blend.c > b/src/galli

Re: [Mesa-dev] [PATCH] etnaviv: implement check_resource_capability

2018-12-28 Thread Christian Gmeiner
gt; pscreen->resource_changed = etna_resource_changed; > pscreen->resource_destroy = etna_resource_destroy; > + pscreen->check_resource_capability = etna_check_resource_capability; > } > -- > 2.19.1 > >

Re: [Mesa-dev] [PATCH] autotools: Deprecate the use of autotools

2019-01-11 Thread Christian Gmeiner
Am So., 16. Dez. 2018 um 12:24 Uhr schrieb Gert Wollny : > > Since Meson will eventually be the only build system deprecate autotools > now. It can still be used by invoking configure with the flag > --enable-autotools > > Signed-off-by: Gert Wollny Reviewed-by: Christian Gme

Re: [Mesa-dev] [PATCH v2 2/2] etnaviv: annotate variables only used in debug build

2018-12-28 Thread Christian Gmeiner
s Stach Reviewed-by: Christian Gmeiner > --- > v2: get rid of superfluous variable initialization > --- > src/gallium/drivers/etnaviv/etnaviv_compiler.c | 11 --- > 1 file changed, 4 insertions(+), 7 deletions(-) > > diff --git a/src/gallium/drivers/etnaviv/etna

Re: [Mesa-dev] [PATCH 04/16] nir: add nir_lower_bool_to_float

2018-12-19 Thread Christian Gmeiner
ssa_undef: > + case nir_instr_type_phi: > + case nir_instr_type_tex: > +nir_foreach_ssa_def(instr, rewrite_1bit_ssa_def_to_32bit, > +); > +break; > + > + default: > +nir_foreach_ssa_def

Re: [Mesa-dev] [PATCH 2/2] etnaviv: flush all pending contexts when accessing a resource with the CPU

2019-03-27 Thread Christian Gmeiner
t; shared (read) mode have been executed. > > Fixes: 64813541d575 (etnaviv: fix resource usage tracking across > different pipe_context's) > Signed-off-by: Lucas Stach Reviewed-by: Christian Gmeiner > --- > src/gallium/drivers/etnaviv/etnaviv_transfer.c | 10 -- >

Re: [Mesa-dev] [PATCH 1/2] etnaviv: don't flush own context when updating resource use

2019-03-27 Thread Christian Gmeiner
w call, causing huge CPU overhead. > > Fixes: 64813541d575 (etnaviv: fix resource usage tracking across > different pipe_context's) > Signed-off-by: Lucas Stach Reviewed-by: Christian Gmeiner > --- > src/gallium/drivers/etnaviv/etnaviv_resource.c | 11 ++- > 1 file c

Re: [Mesa-dev] [PATCH] etnaviv: only try to construct scanout resource when on KMS winsys

2019-03-27 Thread Christian Gmeiner
d-off-by: Lucas Stach Reviewed-by: Christian Gmeiner > --- > src/gallium/drivers/etnaviv/etnaviv_resource.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/gallium/drivers/etnaviv/etnaviv_resource.c > b/src/gallium/drivers/etnaviv/etnaviv_resour

[Mesa-dev] [PATCH] etnaviv: shrink struct etna_3d_state

2019-03-27 Thread Christian Gmeiner
Drop struct members which are only written to but never read from. Signed-off-by: Christian Gmeiner --- src/gallium/drivers/etnaviv/etnaviv_emit.c | 17 - src/gallium/drivers/etnaviv/etnaviv_internal.h | 6 -- 2 files changed, 23 deletions(-) diff --git a/src/gallium

Re: [Mesa-dev] [PATCH v2 3/4] etnaviv: hook-up etc2 patching

2019-02-27 Thread Christian Gmeiner
Hi Lucas Am Mi., 27. Feb. 2019 um 10:19 Uhr schrieb Lucas Stach : > > Am Dienstag, den 26.02.2019, 19:15 +0100 schrieb Christian Gmeiner: > > Changes v1 -> v2: > > - Avoid the GPU sampling from the resource that gets mutated by the the > >transfer map by

Re: [Mesa-dev] [PATCH v2 1/4] etnaviv: implement ETC2 block patching for HALTI0

2019-02-27 Thread Christian Gmeiner
Hi Lucas Am Mi., 27. Feb. 2019 um 10:22 Uhr schrieb Lucas Stach : > > Am Dienstag, den 26.02.2019, 19:15 +0100 schrieb Christian Gmeiner: > > ETC2 is supported with HALTI0, however that implementation is buggy > > in hardware. The blob driver does per-block patching to work a

[Mesa-dev] [PATCH] gallium/u_transfer_helper: do not call resource_create(..) directly

2019-03-01 Thread Christian Gmeiner
Use u_transfer_helper_resource_create(..) instead which uses the resource_create(..) function specified in u_transfer_vtbl. Signed-off-by: Christian Gmeiner --- src/gallium/auxiliary/util/u_transfer_helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium

Re: [Mesa-dev] [PATCH] panfrost: List primitive restart enable bit

2019-02-27 Thread Christian Gmeiner
t; struct mali_vertex_tiler_prefix { > /* This is a dynamic bitfield containing the following things in > this order: super nitpicking: What is the purpose of this change? Should this define be added when it really gets used? -- greets -- Christian Gmeiner, MSc https://chri

Re: [Mesa-dev] [PATCH v5] etnaviv: fix resource usage tracking across different pipe_context's

2019-02-22 Thread Christian Gmeiner
Hi Boris, Am Fr., 22. Feb. 2019 um 10:30 Uhr schrieb Boris Brezillon : > > On Thu, 21 Feb 2019 23:29:53 +0100 > Boris Brezillon wrote: > > > Christian, Marek, > > > > On Wed, 30 Jan 2019 05:28:14 +0100 > > Marek Vasut wrote: > > > > > From:

[Mesa-dev] [PATCH 4/4] etnaviv: enable ETC2 texture compression support for HALTI0 GPUs

2019-02-22 Thread Christian Gmeiner
Signed-off-by: Christian Gmeiner --- src/gallium/drivers/etnaviv/etnaviv_screen.c | 12 +--- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/src/gallium/drivers/etnaviv/etnaviv_screen.c b/src/gallium/drivers/etnaviv/etnaviv_screen.c index de822fc85ca..ee32a499fb5 100644

[Mesa-dev] [PATCH 2/4] etnaviv: keep track of mapped bo address

2019-02-22 Thread Christian Gmeiner
Saves us from calling etna_bo_map(..) and saves us from doing the same offset calcs for map() and unmap() operations. Signed-off-by: Christian Gmeiner --- src/gallium/drivers/etnaviv/etnaviv_context.h | 1 + .../drivers/etnaviv/etnaviv_transfer.c| 19 ++- 2 files

[Mesa-dev] [PATCH 3/4] etnaviv: hook-up etc2 patching

2019-02-22 Thread Christian Gmeiner
Signed-off-by: Christian Gmeiner --- .../drivers/etnaviv/etnaviv_resource.c| 3 ++ .../drivers/etnaviv/etnaviv_resource.h| 5 ++ .../drivers/etnaviv/etnaviv_transfer.c| 49 +++ 3 files changed, 57 insertions(+) diff --git a/src/gallium/drivers/etnaviv

[Mesa-dev] [PATCH 1/4] etnaviv: implement ETC2 block patching for HALTI0

2019-02-22 Thread Christian Gmeiner
ETC2 is supported with HALTI0, however that implementation is buggy in hardware. The blob driver does per-block patching to work around this. We need to swap colors for t-mode etc2 blocks. Signed-off-by: Christian Gmeiner --- src/gallium/drivers/etnaviv/Makefile.sources | 2 + src/gallium

<    1   2   3   4   5   >