Re: [Mesa-dev] [android-x86-devel] Re: gralloc_drm_pipe

2016-03-29 Thread Daniel Vetter
On Tue, Mar 29, 2016 at 10:00:00AM -0400, Rob Clark wrote: > On Tue, Mar 29, 2016 at 4:41 AM, Daniel Vetter <dan...@ffwll.ch> wrote: > > On Sat, Mar 26, 2016 at 07:44:58PM -0400, Rob Clark wrote: > >> On Sat, Mar 26, 2016 at 7:09 PM, Stéphane Marchesin > >> <

Re: [Mesa-dev] [android-x86-devel] Re: gralloc_drm_pipe

2016-03-29 Thread Daniel Vetter
one piece. Your also have to consider things like > > alignment and format restrictions for video decode for example. These can be > > different from 3d so you need some knowledge of the video engine for > > example. Ditto with everything else. > > hmm, admittedly I'm used to think of gpu as the most restrictive thing.. > > But maybe to start with we don't have to solve all the world's > problems.. maybe it is good enough to do a reference gbm_gralloc which > works in the common cases.. SoC vendors can still replace it with > their own thing when the generic one doesn't fit their needs. Going > from "everyone has their own implementation" to "some have their own > implementation" seems like forward progress. > > At least then we can get to something that works for all the mesa > drivers and at least a reasonable subset of everyone else.. At least with video I thought the Grand Android Plan was to switch over to v4l? Maybe we just need to add/query some v4l apis to figure out what's needed for a basic gralloc that works everywhere. There's still the question of where to allocate stuff, but maybe a simple heuristics like assuming that display > v4l > gpu wrt placement constraints (e.g. allocating from cma or not) should be good enough? Maybe with an optional fallback to some ION heap for some shared buffers, there's a todo somewhere about that. Just throwing out my thoughts, I agree that starting out with a gralloc that's good enough for display+gpu sounds like a solid plan. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH RFC 0/2] GBM API extension to support fusing KMS and render devices

2016-03-07 Thread Daniel Vetter
akes sense if you e.g. have some 2d blitter on the display block and a 3d gpu and want to make them one thing (and use the blitter to shuffle bytes around for uploads). Wrt the internal API I'm not concerned too much, since in the end all that coordination is the exact same thing we need to add for compositor/client communication too. They need to agree on what is most suitable as the frontbuffer format and how/where to allocate it, otherwise you'll suffer tons of unnecessary copies. In short we need much more powerful "what buffers can you support/prefer" interfaces anyway, not just for kms/gpu dual drm device support in gbm. And I actually think prototyping those in gbm is a great idea, gets rid of the wayland/X proto complexities. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [Intel-gfx] [RFC libdrm] intel: Add support for softpin

2015-12-14 Thread Daniel Vetter
On Mon, Dec 14, 2015 at 08:41:05AM +, Song, Ruiling wrote: > > > > -Original Message- > > From: Daniel Vetter [mailto:daniel.vet...@ffwll.ch] On Behalf Of Daniel > > Vetter > > Sent: Monday, December 14, 2015 4:28 PM > > To: Song, Ruilin

Re: [Mesa-dev] [Intel-gfx] [RFC libdrm] intel: Add support for softpin

2015-12-14 Thread Daniel Vetter
RAM_REVISION 32 > #define I915_PARAM_SUBSLICE_TOTAL 33 > #define I915_PARAM_EU_TOTAL 34 > +#define I915_PARAM_HAS_EXEC_SOFTPIN 37 > > typedef struct drm_i915_getparam { > int param; > @@ -680,7 +681,8 @@ struct drm_i915_gem_exec_object2 { > #define

Re: [Mesa-dev] [PATCH] i965: Query the actual GTT size for reporting total usuable GPU memory

2015-10-19 Thread Daniel Vetter
onstant GTT size as it also computes addition information not > used here and has the side-effect of doing a sysfs scan for PCI > devices.) > > Signed-off-by: Chris Wilson <ch...@chris-wilson.co.uk> Since I just pulled in the kernel side earlier today: Reviewed-by: Daniel

[Mesa-dev] Request for Proposal for XDC 2016

2015-10-15 Thread Daniel Vetter
that. Please send in your proposal to bo...@foundation.x.org latest by 28th Oct to make sure the baord can consider it. Thanks, Daniel, secretary of the board -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch

Re: [Mesa-dev] [PATCH v4 1/2] intel: 48b ppgtt support (EXEC_OBJECT_SUPPORTS_48B_ADDRESS flag)

2015-10-14 Thread Daniel Vetter
gt; Kristian's concern. I'd suspect that providing reference to the HW > >> documentation (confirming your assumption) might be beneficial. > >> > > > > Sure, attached is the hang I get if I don't set the restriction in > > gen8_misc_state.c and try to use the ful

Re: [Mesa-dev] [PATCH 57/70] i965: Stage blitted buffer uploads through the common upload bo

2015-08-10 Thread Daniel Vetter
___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch ___ mesa-dev

Re: [Mesa-dev] [PATCH] i965: Use updated kernel interface for accurate TIMESTAMP reads

2015-07-23 Thread Daniel Vetter
. Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk Cc: Martin Peres martin.pe...@linux.intel.com Cc: Kenneth Graunke kenn...@whitecape.org Cc: Michał Winiarski michal.winiar...@intel.com Cc: Daniel Vetter dan...@ffwll.ch --- src/mesa/drivers/dri/i965/brw_queryobj.c | 15

Re: [Mesa-dev] [PATCH] i965: Fix comment about DRM_IOCTL_I915_GEM_WAIT.

2015-07-16 Thread Daniel Vetter
is needed. That fixed got cc: stable'ed. If you're still running broken kernels you don't care enough about anything that I don't think this would matter either. It was just that it took us a few releases to spot this. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch

Re: [Mesa-dev] [RFC 0/6] i965: INTEL_performance_query re-work

2015-05-06 Thread Daniel Vetter
@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH V2 06/22] i965/gen9: Set tiled resource mode for the miptree

2015-05-06 Thread Daniel Vetter
-- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] i965: Always use Y-tiled buffers on SKL+

2015-04-13 Thread Daniel Vetter
@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa

Re: [Mesa-dev] [PATCH] i965: Throttle rendering to an fbo

2015-03-12 Thread Daniel Vetter
On Wed, Mar 11, 2015 at 09:10:01AM -0700, Ian Romanick wrote: On 03/06/2015 06:30 AM, Daniel Vetter wrote: On Thu, Mar 05, 2015 at 02:38:44PM -0800, Ian Romanick wrote: On 03/04/2015 10:28 AM, Chad Versace wrote: That text does not appear in the GL spec. When I read the manpage alongside

Re: [Mesa-dev] [PATCH] i965: Throttle rendering to an fbo

2015-03-06 Thread Daniel Vetter
is there no gl entry point in mesa we can abuse and make this happen? Citing the spec doesn't make the real world issue go away. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch ___ mesa-dev mailing list mesa

Re: [Mesa-dev] [PATCH] i965: Cache register write capability checks.

2015-01-05 Thread Daniel Vetter
to for debugging), developers know what might happen. So fully agreed that hurt feet aren't a concern here. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch ___ mesa-dev mailing list mesa-dev

Re: [Mesa-dev] [PATCH 1/4] i965/byt: Allow 128 bpp to be linear or Y-tiled on

2014-12-10 Thread Daniel Vetter
mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http

Re: [Mesa-dev] [PATCH] dri/kms: Always zero out struct drm_mode_create_dumb

2014-11-14 Thread Daniel Vetter
so that structures can be validated and IOCTLs rejected if output fields aren't set to zero. Signed-off-by: Thierry Reding tred...@nvidia.com Reviewed-by: Daniel Vetter daniel.vet...@ffwll.ch --- src/gallium/winsys/sw/kms-dri/kms_dri_sw_winsys.c | 2 +- src/gbm/backends/dri/gbm_dri.c

Re: [Mesa-dev] [PATCH] i965: Use the predicate enable bit for conditional rendering without stalling

2014-11-12 Thread Daniel Vetter
to catch any userspace issues we've missed. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa

Re: [Mesa-dev] [PATCH] i965: Implement WaCsStallAtEveryFourthPipecontrol on IVB/BYT.

2014-11-12 Thread Daniel Vetter
-off-by: Kenneth Graunke kenn...@whitecape.org Yeah, kernel adds the CS stall bit both to the flush right before/after the batch so this works. The kernel also has a comment so people hopefully check userspace assumptions when testing this. Reviewed-by: Daniel Vetter daniel.vet...@ffwll.ch Some

Re: [Mesa-dev] [PATCH v2 2/2] i965: Use the predicate enable bit for conditional rendering without stalling

2014-11-09 Thread Daniel Vetter
is picking the numbers, since you seem to assume here that ver = 2 means the stuff actually works. But like Ken said the cmd parser in upstream isn't really enabled yet. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch

Re: [Mesa-dev] [PATCH 2/2] i965: Use BDW_MOCS_PTE for renderbuffers.

2014-09-30 Thread Daniel Vetter
changed, 1 insertion(+), 1 deletion(-) Cc'd to stable because it's a pretty trivial change and provides a sizable boost to performance on new hardware. Both patches are Reviewed-by: Daniel Vetter daniel.vet...@ffwll.ch Aside: Not using WT on display can lead to corruption (apparently bdw

Re: [Mesa-dev] [PATCH 3/4] i965: Issue performance warnings for program cache related stalls.

2014-09-29 Thread Daniel Vetter
for timeout=0) asking to just wait for read-only access. Shouldn't be a lot of fuzz to pimp the corresponding igt testcase and wire it all up. Or not that interesting? Cheers, Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch

Re: [Mesa-dev] [Intel-gfx] [PATCH 00/68] Broadwell 48b addressing and prelocations (no relocs)

2014-08-22 Thread Daniel Vetter
poking people to look at this for years. too. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo

Re: [Mesa-dev] [Intel-gfx] [PATCH 00/68] Broadwell 48b addressing and prelocations (no relocs)

2014-08-22 Thread Daniel Vetter
On Fri, Aug 22, 2014 at 3:38 PM, Chris Wilson ch...@chris-wilson.co.uk wrote: On Fri, Aug 22, 2014 at 03:30:12PM +0200, Daniel Vetter wrote: On Fri, Aug 22, 2014 at 9:03 AM, Chris Wilson ch...@chris-wilson.co.uk wrote: If a GPU client uses only prelocations, the relocation process can

Re: [Mesa-dev] [Intel-gfx] [PATCH 00/68] Broadwell 48b addressing and prelocations (no relocs)

2014-08-22 Thread Daniel Vetter
On Fri, Aug 22, 2014 at 3:38 PM, Chris Wilson ch...@chris-wilson.co.uk wrote: On Fri, Aug 22, 2014 at 03:30:12PM +0200, Daniel Vetter wrote: On Fri, Aug 22, 2014 at 9:03 AM, Chris Wilson ch...@chris-wilson.co.uk wrote: If a GPU client uses only prelocations, the relocation process can

Re: [Mesa-dev] [rong.r.y...@intel.com: [Intel-gfx] How user space applications load registers on HSW?]

2014-05-13 Thread Daniel Vetter
for the kernel team. --Ken ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch

Re: [Mesa-dev] [PATCH] drm: add FOURCC formats for compute dma_buf interop.

2014-03-19 Thread Daniel Vetter
On Wed, Mar 19, 2014 at 7:30 AM, Gwenole Beauchesne gb.de...@gmail.com wrote: 2014-03-15 12:28 GMT+01:00 Daniel Vetter dan...@ffwll.ch: On Sat, Mar 15, 2014 at 05:41:05AM +0100, Gwenole Beauchesne wrote: Hi, 2014-03-14 22:52 GMT+01:00 Daniel Vetter dan...@ffwll.ch: On Fri, Mar 14, 2014

Re: [Mesa-dev] [PATCH] drm: add FOURCC formats for compute dma_buf interop.

2014-03-15 Thread Daniel Vetter
___ dri-devel mailing list dri-de...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch ___ mesa-dev mailing list mesa-dev

Re: [Mesa-dev] [PATCH] drm: add FOURCC formats for compute dma_buf interop.

2014-03-15 Thread Daniel Vetter
On Sat, Mar 15, 2014 at 05:41:05AM +0100, Gwenole Beauchesne wrote: Hi, 2014-03-14 22:52 GMT+01:00 Daniel Vetter dan...@ffwll.ch: On Fri, Mar 14, 2014 at 06:59:21PM +0100, Gwenole Beauchesne wrote: This is a follow-up to: http://lists.freedesktop.org/archives/mesa-dev/2014-March/055742

Re: [Mesa-dev] [PATCH 3/3] i965: Bump MaxTexMbytes from 1GB to 1.5GB.

2014-02-04 Thread Daniel Vetter
) only has 512 MB of aperture ... Also going this high runs the risk that you fool up with fragmentation, but meh. You'd need to get at bufmgr_gem-gtt_size somehow. At least the current code is safe for address spaces 4G. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57

Re: [Mesa-dev] [PATCH 05/10] i965: Use Global GTT for Sandybridge post-sync non-zero workaround.

2014-01-14 Thread Daniel Vetter
to consult the I915_PARAM_HAS_ALIASING_PPGTT driver param. If it is set then you should use ppgtt as the address space selector. This will even hold for full ppgtt (so a better name would be USES_PPGTT_FOR_EXECBUF, but abi and all that). Cheers, Daniel -- Daniel Vetter Software Engineer, Intel

Re: [Mesa-dev] [PATCH] Don't use libudev for glx/dri3

2013-12-16 Thread Daniel Vetter
On Mon, Dec 16, 2013 at 11:19:56AM -0800, Eric Anholt wrote: Daniel Vetter dan...@ffwll.ch writes: On Sat, Dec 14, 2013 at 3:33 AM, Kenneth Graunke kenn...@whitecape.org wrote: On 11/18/2013 12:58 PM, Emil Velikov wrote: On 18/11/13 01:08, Keith Packard wrote: libudev doesn't have

Re: [Mesa-dev] [PATCH] Don't use libudev for glx/dri3

2013-12-14 Thread Daniel Vetter
do that dance in reverse if we want to have a pci id based lookup. Anyway I've never read through the loader code, just figured it won't hurt if I drop my uninformed opinion ;-) Cheers, Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch

Re: [Mesa-dev] [PATCH 04/10] i965: Emit full-length PIPE_CONTROLs for (non-write) flushes.

2013-12-13 Thread Daniel Vetter
/mailman/listinfo/mesa-dev -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 05/10] i965: Use Global GTT for Sandybridge post-sync non-zero workaround.

2013-12-13 Thread Daniel Vetter
checks whether the write lands) for gen67, this is Reviewed-by: Daniel Vetter daniel.vet...@ffwll.ch --- src/mesa/drivers/dri/i965/intel_batchbuffer.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/intel_batchbuffer.c b/src/mesa/drivers/dri

Re: [Mesa-dev] [PATCH 06/10] i965: Use full-length PIPE_CONTROL packets for workaround writes.

2013-12-13 Thread Daniel Vetter
(and MI_FLUSH_DW, too) have a stern w/a notice on all gen6+ generations that bit5 of the target address must be cleared. I haven't checked existing users, but these here seem safe. So Reviewed-by: Daniel Vetter daniel.vet...@ffwll.ch --- src/mesa/drivers/dri/i965/intel_batchbuffer.c | 15 +-- 1

Re: [Mesa-dev] [PATCH 08/10] i965: Introduce an OUT_RELOC64 macro.

2013-12-13 Thread Daniel Vetter
() intel_batchbuffer_cached_advance(brw); -- 1.8.4.4 ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http

Re: [Mesa-dev] [PATCH 08/10] i965: Introduce an OUT_RELOC64 macro.

2013-12-13 Thread Daniel Vetter
On Fri, Dec 13, 2013 at 10:04:53AM -0800, Kenneth Graunke wrote: On 12/13/2013 09:28 AM, Daniel Vetter wrote: On Thu, Dec 12, 2013 at 01:26:40AM -0800, Kenneth Graunke wrote: Broadwell uses 48-bit addresses. The first DWord is the low 32 bits, and the second DWord is the high 16 bits

Re: [Mesa-dev] [PATCH] mesa: Define helper function to get the number of texture layers.

2013-12-11 Thread Daniel Vetter
but also no false positive compiler warnings, even in release builds. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org

Re: [Mesa-dev] [PATCH] intel: Track known prime buffers for re-use

2013-11-26 Thread Daniel Vetter
a small comment saying that the kernel lies. Or just remove it. Either way: Reviewed-by: Daniel Vetter daniel.vet...@ffwll.ch Aside: I think drm is the only subsystem that goes out of it's way to ensure a unique relationship between dmabuf and other handles and underlying objects. If you throw

Re: [Mesa-dev] [Intel-gfx] [PATCH] dri3, i915, i965: Add __DRI_IMAGE_FOURCC_SARGB8888

2013-11-25 Thread Daniel Vetter
the different projects anyway, so meh. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] intel: Track known prime buffers for re-use

2013-11-25 Thread Daniel Vetter
/mailman/listinfo/mesa-dev -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] dri3, i915, i965: Add __DRI_IMAGE_FOURCC_SARGB8888

2013-11-22 Thread Daniel Vetter
, 0, __DRI_IMAGE_FORMAT_XRGB, 4 }, } }, -- 1.8.4.2 ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48

Re: [Mesa-dev] [PATCH] dri3, i915, i965: Add __DRI_IMAGE_FOURCC_SARGB8888

2013-11-22 Thread Daniel Vetter
On Fri, Nov 22, 2013 at 12:01 PM, Keith Packard kei...@keithp.com wrote: Daniel Vetter dan...@ffwll.ch writes: Hm, where do we have the canonical source for all these fourcc codes? I'm asking since we have our own copy in the kernel as drm_fourcc.h, and that one is part of the userspace ABI

Re: [Mesa-dev] [PATCH 23/27] i965: Start and stop OA counters as necessary.

2013-11-14 Thread Daniel Vetter
a few questions I wanted to throw out there for consideration, current approach looks fine to me. I've read through the entire pile of patches, so Acked-by: Daniel Vetter daniel.vet...@ffwll.ch on the series. Whatever that's worth ;-) Cheers, Daniel + +/** + * Called at the end of every render

Re: [Mesa-dev] [PATCH 07/18] i915: Wire up initial support for DRI_RENDERER_QUERY extension

2013-11-11 Thread Daniel Vetter
On Mon, Nov 11, 2013 at 11:03:49AM -0800, Ian Romanick wrote: On 11/09/2013 02:44 AM, Daniel Vetter wrote: On Fri, Oct 11, 2013 at 03:10:14PM -0700, Ian Romanick wrote: From: Ian Romanick ian.d.roman...@intel.com Signed-off-by: Ian Romanick ian.d.roman...@intel.com --- src/mesa

Re: [Mesa-dev] [PATCH 2/4] i965: Use drm_intel_get_aperture_sizes instead of hard-coded 2GiB

2013-11-11 Thread Daniel Vetter
. Signed-off-by: Ian Romanick ian.d.roman...@intel.com Cc: Daniel Vetter dan...@ffwll.ch Cc: 10.0 mesa-sta...@lists.freedesktop.org --- src/mesa/drivers/dri/i965/intel_screen.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/src/mesa/drivers/dri/i965

Re: [Mesa-dev] [PATCH 2/4] i965: Use drm_intel_get_aperture_sizes instead of hard-coded 2GiB

2013-11-11 Thread Daniel Vetter
On Mon, Nov 11, 2013 at 01:45:43PM -0800, Ian Romanick wrote: On 11/11/2013 01:35 PM, Daniel Vetter wrote: On Mon, Nov 11, 2013 at 11:19:07AM -0800, Ian Romanick wrote: From: Ian Romanick ian.d.roman...@intel.com Systems with little physical memory installed will report less than 2GiB

Re: [Mesa-dev] [PATCH 07/18] i915: Wire up initial support for DRI_RENDERER_QUERY extension

2013-11-09 Thread Daniel Vetter
://lists.freedesktop.org/mailman/listinfo/mesa-dev -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 08/18] i965: Wire up initial support for DRI_RENDERER_QUERY extension

2013-11-08 Thread Daniel Vetter
On Thu, Nov 07, 2013 at 04:23:12PM -0800, Ian Romanick wrote: On 11/07/2013 01:33 PM, Daniel Vetter wrote: On Sat, Oct 12, 2013 at 12:10 AM, Ian Romanick i...@freedesktop.org wrote: + /* Once a batch uses more than 75% of the maximum mappable size, we + * assume that there's some

Re: [Mesa-dev] [PATCH 08/18] i965: Wire up initial support for DRI_RENDERER_QUERY extension

2013-11-07 Thread Daniel Vetter
. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] Possible Sandybridge GPU hang fixes

2013-10-27 Thread Daniel Vetter
. Cheers, Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH] i965: CS writes/reads should use I915_GEM_INSTRUCTION

2013-10-09 Thread Daniel Vetter
helper used by the gen6 queryobj code. Cc: Kenneth Graunke kenn...@whitecape.org Signed-off-by: Daniel Vetter daniel.vet...@ffwll.ch --- src/mesa/drivers/dri/i965/gen6_queryobj.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/mesa/drivers/dri/i965/gen6_queryobj.c b/src

Re: [Mesa-dev] [PATCH 4/7] i965/blorp: Use R16_UNORM for Z32F surfaces.

2013-10-08 Thread Daniel Vetter
: this-brw_surfaceformat = BRW_SURFACEFORMAT_R16_UNORM; break; -- 1.8.3.2 ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57

Re: [Mesa-dev] [PATCH 6/7] i965/blorp: Rework sRGB override behavior.

2013-10-08 Thread Daniel Vetter
-by: Daniel Vetter daniel.vet...@ffwll.ch It's a bit hairy how the outermost blt code needs to check the depth stuff, I'd have prefered to keep that logic in one place. But bubbling that error up the layers looks like a pain, blorp has other similar conditions already and the code seems

Re: [Mesa-dev] [PATCH 0/6] Support for 10 bpc EGLSurface

2013-09-16 Thread Daniel Vetter
the pixel format to gbm so we can generate buffers with that format. Creating 10bpc rgb framebuffers also works with the old addfb ioctl, same for rbg565 and rgb555. Heck even c8 palette mode works ;-) Just so you don't unduly restrict the wayland/weston support here ... Cheers, Daniel -- Daniel Vetter

Re: [Mesa-dev] [PATCH 16/20] radeonsi: add FMASK texture binding slots and resource setup

2013-08-11 Thread Daniel Vetter
is directly driven by vm pressure. Cheers, Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa

Re: [Mesa-dev] [PATCH 3/5] i965/hsw: Change L3 MOCS of SURFACE_STATE

2013-07-19 Thread Daniel Vetter
, and they can happen even if mesa _never_ access the bo from the gpu with cached mocs settings or with the cpu. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch ___ mesa-dev mailing list mesa-dev

Re: [Mesa-dev] [PATCH 05/13] i965: Delete the data cache is the sampler cache comments on Gen7+.

2013-07-11 Thread Daniel Vetter
, brw-shader_time.bo, 0, -- 1.8.3.2 ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365

Re: [Mesa-dev] [RFC] Mesa 9.2 and release process changes

2013-07-04 Thread Daniel Vetter
patches for backporting, there's no burden on developers to keep track of patches which should get nominated after some testing and still there's a reasonable chance that crap doesn't land in the stable branch. Cheers, Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57

Re: [Mesa-dev] [v6 2/9] intel: do not create renderbuffers out of planar images

2013-05-30 Thread Daniel Vetter
-eg_image step still gives a useful piece of information to users. Since this sounds like a spec question cc'ing all the people from the original dma_buf_import spec discussions. Yours, Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch

Re: [Mesa-dev] [PATCH mesa] wayland: Disable prime support on buggy kernels

2013-05-10 Thread Daniel Vetter
on the kernel side. Things are solved on the kernel side now I think, and prime fixes are trickling down to all stable releases atm. So I don't think you need any workarounds and we can just enable prime buffer passing in the next mesa release. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation

Re: [Mesa-dev] [PATCH 0/2] i965/hsw: Set MOCS for surfaces

2013-05-06 Thread Daniel Vetter
don't remember having any trouble like this before. This one here maybe? https://bugs.freedesktop.org/show_bug.cgi?id=63914 Cheers, Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch ___ mesa-dev

Re: [Mesa-dev] [v2 09/10] egl: dri2: support for creating images out of dma buffers

2013-04-29 Thread Daniel Vetter
://lists.freedesktop.org/mailman/listinfo/mesa-dev -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] intel: Be more conservative in disabling tiling to save memory.

2013-04-26 Thread Daniel Vetter
and 64b when Y-tiling is possible? Otoh only pre-gen6 would care, so meh. Either way Reviewed-by: Daniel Vetter daniel.vet...@ffwll.ch - if (ALIGN(mt-total_width * mt-cpp, 512) = 32768) { + if (ALIGN(minimum_pitch, 512) = 32768) { perf_debug(%dx%d miptree too large to blit, falling

Re: [Mesa-dev] new i965g pipe driver for Intel GEN6 (and later)

2013-04-17 Thread Daniel Vetter
with a i830_dri.so - i915_dri.so symlink and the ddx should start to ask for the i830 dri on gen2. Back in the days when I didn't just have little, but provable zero clue I've had some amusement around that on my i855gm trying to use i915g ;-) -Daniel -- Daniel Vetter Software Engineer, Intel

Re: [Mesa-dev] [PATCH 3/3] i965: Prefer Y-tiling on Gen6+.

2013-04-08 Thread Daniel Vetter
; return I915_TILING_NONE; } -- 1.8.1.1 ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http

Re: [Mesa-dev] [PATCH 3/3] i965: Prefer Y-tiling on Gen6+.

2013-04-08 Thread Daniel Vetter
On Tue, Apr 09, 2013 at 01:17:39AM +0200, Daniel Vetter wrote: On Mon, Apr 08, 2013 at 07:27:38PM -0700, Kenneth Graunke wrote: In the past, we preferred X-tiling for color buffers because our BLT code couldn't handle Y-tiling. However, the BLT paths have been largely replaced by BLORP

Re: [Mesa-dev] [PATCH] intel: Do temporary CPU maps of textures that are too big to GTT map.

2013-04-05 Thread Daniel Vetter
need to have a proper interface for userspace to figure this out. And snoopable bos obviously need a separate cache, otherwise we'll drown in clflush. On the patch: Reviewed-by: Daniel Vetter daniel.vet...@ffwll.ch --- src/mesa/drivers/dri/intel/intel_mipmap_tree.c | 23

Re: [Mesa-dev] [PATCH 2/3] intel: Do temporary CPU maps of textures that are too big to GTT map.

2013-04-03 Thread Daniel Vetter
, slice); } else { intel_miptree_map_gtt(intel, mt, map, level, slice); } -- 1.7.10.4 ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev -- Daniel Vetter Software Engineer

Re: [Mesa-dev] [PATCH 2/3] intel: Do temporary CPU maps of textures that are too big to GTT map.

2013-04-03 Thread Daniel Vetter
://lists.freedesktop.org/mailman/listinfo/mesa-dev -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] i965: Fix Vertex URB Read Length calculation in 3DSTATE_SF on Gen6.

2013-02-06 Thread Daniel Vetter
On Tue, Feb 05, 2013 at 10:40:28PM +0100, Martin Steigerwald wrote: Am Dienstag, 5. Februar 2013 schrieb Daniel Vetter: On Sat, Feb 02, 2013 at 09:22:55PM +0100, Martin Steigerwald wrote: About these messages: Uhm, bingo: merkaba:~ zgrep -i GPU hung /var/log/kern.log* /var/log

Re: [Mesa-dev] [PATCH] i965: Fix Vertex URB Read Length calculation in 3DSTATE_SF on Gen6.

2013-02-05 Thread Daniel Vetter
with latest 3.8-rc kernels might be good - we've just merged a few workaround patches for snb, which reportedly fix some hangs. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch ___ mesa-dev mailing list

Re: [Mesa-dev] [PATCH] i965: Compile the driver with -march=core2.

2013-01-26 Thread Daniel Vetter
took us a few attempts to put that crazy pciid into the right tables in the kernel/ddx/mesa - originally we've marked it as gen3 until someont tried to actually use it. Marketing and production differention win again :( -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57

Re: [Mesa-dev] [PATCH] llvmpipe: Implement PIPE_QUERY_TIMESTAMP and PIPE_QUERY_TIME_ELAPSED.

2012-12-04 Thread Daniel Vetter
the monotonic clock, leading to nice unified timestamps accross all things linux media. Hence I think pipe queries should do the same, just for consistency. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch

Re: [Mesa-dev] [PATCH] i965: Disable guardband clipping on SNB unless workaround is present.

2012-10-08 Thread Daniel Vetter
;-) -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] i965: Disable guardband clipping on SNB unless workaround is present.

2012-10-07 Thread Daniel Vetter
-- 1.7.11.4 ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch

Re: [Mesa-dev] FOSDEM2013: DevRoom or not?

2012-09-28 Thread Daniel Vetter
). Or something else. To make the intel roundup complete: Chris, can I volunteer you to give another stab at an updates from flatland talk? Cheers, Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch

Re: [Mesa-dev] [PATCH] intel: Improve teximage perf for Google Chrome paint rects

2012-09-13 Thread Daniel Vetter
On Thu, Sep 13, 2012 at 04:22:20PM +0300, Chad Versace wrote: On 09/11/2012 10:40 PM, Daniel Vetter wrote: Only quick read-through but I'd have expected a has_llc check in there - if vlv is anything like the previous platforms wc gtt will be much faster there. I'm not too familiar

Re: [Mesa-dev] [PATCH] intel: Improve teximage perf for Google Chrome paint rects

2012-09-11 Thread Daniel Vetter
*/ if (dims != 2 || !intel_blit_texsubimage(ctx, texImage, xoffset, yoffset, -- 1.7.12 ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev -- Daniel

Re: [Mesa-dev] [PATCH 7/7] i965: Rework the extra flushes surrounding occlusion queries.

2012-08-08 Thread Daniel Vetter
need a CS stall, which needs a stall at scoreboard. Signed-off-by: Daniel Vetter daniel.vet...@ffwll.ch Signed-off-by: Kenneth Graunke kenn...@whitecape.org In my understanding of Bspec (haven't done any experiments on hw) we need to set the depth stall bit on the pipe_control

Re: [Mesa-dev] [PATCH 7/7] i965: Rework the extra flushes surrounding occlusion queries.

2012-08-08 Thread Daniel Vetter
On Wed, Aug 08, 2012 at 09:41:44AM +0200, Daniel Vetter wrote: On Tue, Aug 07, 2012 at 04:05:33PM -0700, Kenneth Graunke wrote: Separate out the depth stall from the depth count write. Workarounds say that a depth stall needs to be preceeded with a non-zero post-sync op (in this case

Re: [Mesa-dev] [PATCH v2] i965: Rework the extra flushes surrounding occlusion queries.

2012-08-08 Thread Daniel Vetter
Vetter daniel.vet...@ffwll.ch Cc: Eric Anholt e...@anholt.net Signed-off-by: Kenneth Graunke kenn...@whitecape.org v2 lsooks good to me now. Reviewed-by: Daniel Vetter daniel.vet...@ffwll.ch -- Daniel Vetter Mail: dan...@ffwll.ch Mobile: +41 (0)79 365 57 48

[Mesa-dev] [PATCH 2/4] i965: we want 64bit writes for depth count

2012-07-20 Thread Daniel Vetter
... and the hardware seems to take the lenght of the pipe control command to indicate whether the write is 64bit or 32bit. Which makes sense for immediate writes. I've discovered this by writing a pattern into the query object bo and noticing that the high 32bits are left intact, even on those

[Mesa-dev] [PATCH 1/4] i965: tackle the occlusion query pipe control mess

2012-07-20 Thread Daniel Vetter
- Separate out the depth stall from the depth count write, workarounds say that a depth stall needs to be preceeded with a non-zero post-sync op. - Implement the cs stall workaround like the kernel does. I've hoped that this would fix a occlusion query issue on snb, but alas, it doesn't seem

[Mesa-dev] [PATCH 3/4] i965: adjust gen6+ timestamp pipe_control writes

2012-07-20 Thread Daniel Vetter
Similar treatment to the depth count pipe_control writes - Add the CS_STALL workaround, timestamp writes are non-zero post-sync ops, too. - Also ensure that we write the full 64bits by using the 5 dword long variant of pipe_control. v2: Implement |(5-2) suggestion from Kenneth Graunke. ---

[Mesa-dev] [PATCH 4/4] i965: make the length for PIPE_CONTROL explicit

2012-07-20 Thread Daniel Vetter
PIPE_CONTROL has variable length, depending upon gen and whether we write out 32bit or 64bit. So make this explicit. Suggested by Kenneth Graunke. --- src/mesa/drivers/dri/i965/brw_queryobj.c | 22 +++--- src/mesa/drivers/dri/i965/gen6_vs_state.c |2 +-

Re: [Mesa-dev] [PATCH 2/3] i965: we want 64bit writes for depth count

2012-07-02 Thread Daniel Vetter
On Sun, Jul 01, 2012 at 07:59:56PM -0700, Kenneth Graunke wrote: On 06/26/2012 07:28 AM, Daniel Vetter wrote: ... and the hardware seems to take the lenght of the pipe control command to indicate whether the write is 64bit or 32bit. Which makes sense for immediate writes. I've

Re: [Mesa-dev] [PATCH 3/3] i965: adjust gen6+ timestamp pipe_control writes

2012-07-02 Thread Daniel Vetter
On Sun, Jul 01, 2012 at 08:10:49PM -0700, Kenneth Graunke wrote: On 06/26/2012 07:28 AM, Daniel Vetter wrote: Similar treatment to the depth count pipe_control writes - Add the CS_STALL workaround, timestamp writes are non-zero post-sync ops, too. - Also ensure that we write the full

[Mesa-dev] [PATCH 0/3] gen6+ pipe control fixes for queries

2012-06-26 Thread Daniel Vetter
grossly oversized) works around the issue. These patches here don't fix this major issue, but at least a few other things. Cheers, Daniel Daniel Vetter (3): i965: tackle the occlusion query pipe control mess i965: we want 64bit writes for depth count i965: adjust gen6+ timestamp

[Mesa-dev] [PATCH 1/3] i965: tackle the occlusion query pipe control mess

2012-06-26 Thread Daniel Vetter
- Separate out the depth stall from the depth count write, workarounds say that a depth stall needs to be preceeded with a non-zero post-sync op. - Implement the cs stall workaround like the kernel does. I've hoped that this would fix a occlusion query issue on snb, but alas, it doesn't seem

[Mesa-dev] [PATCH 2/3] i965: we want 64bit writes for depth count

2012-06-26 Thread Daniel Vetter
... and the hardware seems to take the lenght of the pipe control command to indicate whether the write is 64bit or 32bit. Which makes sense for immediate writes. I've discovered this by writing a pattern into the query object bo and noticing that the high 32bits are left intact, even on those

[Mesa-dev] [PATCH 3/3] i965: adjust gen6+ timestamp pipe_control writes

2012-06-26 Thread Daniel Vetter
Similar treatment to the depth count pipe_control writes - Add the CS_STALL workaround, timestamp writes are non-zero post-sync ops, too. - Also ensure that we write the full 64bits by using the 5 dword long variant of pipe_control. --- src/mesa/drivers/dri/i965/brw_queryobj.c | 32

Re: [Mesa-dev] [PATCH 00/25] i915 HW context support

2012-06-14 Thread Daniel Vetter
patches directly and only applied the minimal change to get rid of object-context_id. Please commit the i-g-t testcase so that qa can start testing this aspa. Cheers, Daniel -- Daniel Vetter Mail: dan...@ffwll.ch Mobile: +41 (0)79 365 57 48 ___ mesa-dev

Re: [Mesa-dev] [PATCH] i915g: Fix depth/stencil glClear

2012-06-10 Thread Daniel Vetter
) is executed instead of glClear(DEPTH)/glClear(STENCIL). Woot, nice catch - iirc this problem elluded me for about a year, i.e. since I've enabled hw clears. Reviewed-by: Daniel Vetter daniel.vet...@ffwll.ch Do you have commit access or should I do that? Yours, Daniel --- src/gallium/drivers/i915

Re: [Mesa-dev] [PATCH v5] intel: wait render timeout implementation

2012-06-08 Thread Daniel Vetter
in this function instead. As Daniel pointed out, the polling case (timeout == 0) should also return -ETIME. Cc: Eric Anholt e...@anholt.net Cc: Daniel Vetter daniel.vet...@ffwll.ch Signed-off-by: Ben Widawsky b...@bwidawsk.net Reviewed-by: Daniel Vetter daniel.vet...@ffwll.ch --- intel

Re: [Mesa-dev] [PATCH 2/2 v4] intel: wait render timeout implementation

2012-06-07 Thread Daniel Vetter
param and fallback for older kernels v3: only doing getparam at init prototypes now have a signed input value v4: update comments fall back to correct polling behavior with new userspace and old kernel Cc: Eric Anholt e...@anholt.net Cc: Daniel Vetter daniel.vet...@ffwll.ch Signed-off

Re: [Mesa-dev] [Intel-gfx] [RFC] [PATCH] i965: better ClientWaitSync

2012-06-07 Thread Daniel Vetter
-StatusFlag = 1; drm_intel_bo_unreference(sync-bo); sync-bo = NULL; -- 1.7.10.3 ___ Intel-gfx mailing list intel-...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Daniel Vetter Mail: dan...@ffwll.ch

<    1   2   3   4   >