Re: [Mesa-dev] [PATCH 0/3] Meson build system

I forgot to CC you on this like you asked, Dylan Quoting Dylan Baker (2018-01-05 12:00:57) > This is a fifth iteration of the meson build system for libdrm. This > version is significantly cleaned up from the last version and uses a > style more like the build system in mesa. > >

Re: [Mesa-dev] [PATCH 09/14] meson: do not redeclare pkg-config dependencies (yet)

We absolutely can't merge this as-is, it will break all of the these since they'll end up linking the backend and frontend, which we're not supposed to do. The bug you linked to has nothing to do with the problem you describe either, that issue is that `dependency("threads")` is special in meson,

Re: [Mesa-dev] [PATCH v3 3/4] meson: build clover

Quoting Jan Vesely (2018-01-06 15:18:54) > On Fri, 2018-01-05 at 15:26 -0800, Dylan Baker wrote: > > Quoting Jan Vesely (2018-01-05 14:16:41) > > > Hi, > > > > > > > > > sorry for the delay. I was mostly traveling during the holidays. > >

Re: [Mesa-dev] [PATCH 5/7] report.py: Add option to only display measurements that have changes

Quoting Ian Romanick (2018-01-16 09:39:07) > On 01/12/2018 12:23 PM, Dylan Baker wrote: > > Quoting Ian Romanick (2018-01-12 12:06:59) > >> From: Ian Romanick <ian.d.roman...@intel.com> > >> > >> This is useful for preparing data to go in a Mesa co

Re: [Mesa-dev] [PATCH 1/2] meson: Fix configuring dri glx with only gallium drivers

Your attached patch looks good to me. You can add my r-b to it. Quoting Jon Turney (2018-01-15 11:50:04) > On 12/01/2018 17:33, Dylan Baker wrote: > > Maybe this is correct, but it makes me nervous treating with_gallium as > > equivalent to with_dri, since gallium drivers can be

Re: [Mesa-dev] [PATCH 00/14] BSD portability (Meson, ANV, RADV, VC4/5, SWR)

Just wanted to see how things were going on this, especially for the meson bits as I'd like to get them merged before the 18.0 merge window closes. Quoting Greg V (2017-12-31 08:55:14) > Hello everyone and happy new year! :) > > This set of patches makes the Meson build work on FreeBSD,

[Mesa-dev] [PATCH] meson: Don't confuse the install and search paths for dri drivers

. Reported-by: Ilia Mirkin <imir...@alum.mit.edu> Signed-off-by: Dylan Baker <dylan.c.ba...@intel.com> --- meson.build | 6 ++ meson_options.txt | 8 +++- src/egl/meson.build | 2 +- src/gbm/meson.build | 2 +- src/glx/meson.build | 3 ++- 5 files changed, 17 inse

Re: [Mesa-dev] [PATCH] meson: add llvm dependency for swr build

Reviewed-by: Dylan Baker <dy...@pnwbakers.com> Quoting George Kyriazis (2018-01-16 13:25:45) > cc: Dylan Baker <dy...@pnwbakers.com> > --- > src/gallium/drivers/swr/meson.build | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/src/gallium/drivers/swr/meson.

Re: [Mesa-dev] [PATCH 02/14] vc4, vc5: add ETIME fallback define

I'm not sure how Emil feels about this (and the related patches) but I think it might be better to handle this at the build system level, for meson it would look something like (in the top level meson.build): if cc.get_define('ETIME') == '' pre_args += '-DETIME=ETIMEDOUT' endif Which should be

Re: [Mesa-dev] [PATCH] meson: generate translations for driconf

Quoting Eric Anholt (2018-01-17 12:58:27) > Dylan Baker <dy...@pnwbakers.com> writes: > > > Currently meson implements the same logic as SCons for translations, > > namely it doesn't do them. This patch changes meson to use logic more > > like autotools, and genera

[Mesa-dev] [PATCH] autotools: include meson build files in tarball

This adds the meson.build, meson_options.txt, and a few scripts that are used exclusively by the meson build. Signed-off-by: Dylan Baker <dylan.c.ba...@intel.com> --- Makefile.am | 7 ++- src/Makefile.am

[Mesa-dev] [PATCH] meson: ensure that xmlpool_options.h is generated for targets that need it

Currently a couple of gallium targets race with xmlpool_options.h being generated, don't do that. Signed-off-by: Dylan Baker <dylan.c.ba...@intel.com> --- src/gallium/auxiliary/pipe-loader/meson.build | 4 ++-- src/gallium/targets/d3dadapter9/meson.build | 2 +- src/gallium/target

[Mesa-dev] [PATCH v2] meson: Don't confuse the install and search paths for dri drivers

. v2: - Split input list before joining. Reported-by: Ilia Mirkin <imir...@alum.mit.edu> Signed-off-by: Dylan Baker <dylan.c.ba...@intel.com> --- meson.build | 6 ++ meson_options.txt | 8 +++- src/egl/meson.build | 2 +- src/gbm/meson.build | 2 +- src/glx/meson.buil

Re: [Mesa-dev] [PATCH 00/14] BSD portability (Meson, ANV, RADV, VC4/5, SWR)

No worries, December is a busy time of year. Quoting Greg V (2018-01-17 12:57:39) > On 01/17/2018 00:59, Dylan Baker wrote: > > Just wanted to see how things were going on this, especially for the meson > > bits > > as I'd like to get them merged before the 18.0 merge w

Re: [Mesa-dev] [PATCH v2 3/4] meson: fix getting cflags from pkg-config

Reviewed-by: Dylan Baker <dy...@pnwbakers.com> Quoting Greg V (2018-01-17 12:54:17) > get_pkgconfig_variable('cflags') always returns an empty list, it's a > function for getting *custom* variables. > > Meson does not yet support asking for cflags, so explicitly invoke &g

Re: [Mesa-dev] [PATCH v2 4/4] meson: fix missing dependencies

Quoting Greg V (2018-01-17 12:54:18) > --- > meson.build | 4 > src/gallium/drivers/radeonsi/meson.build | 2 +- > src/mesa/meson.build | 2 +- > 3 files changed, 6 insertions(+), 2 deletions(-) > > diff --git a/meson.build b/meson.build >

Re: [Mesa-dev] [PATCH 3/6] meson: fix va-api target linkage

Quoting Marc Dietrich (2018-01-18 04:03:21) > Am Mittwoch, 17. Januar 2018, 19:34:48 CET schrieb Dylan Baker: > > The state tracker needs to be linked with whole-archive (like > > autotools), and we need a few window system deps. > > > > Signed-off-by: Dylan Bak

Re: [Mesa-dev] [PATCH 02/14] vc4, vc5: add ETIME fallback define

Forgot to CC Emil... Quoting Dylan Baker (2018-01-18 09:13:13) > I'm not sure how Emil feels about this (and the related patches) but I think > it > might be better to handle this at the build system level, for meson it would > look something like (in the top level

[Mesa-dev] [PATCH 7/6] meson: use va-api version reported by pkg-config

Signed-off-by: Dylan Baker <dylan.c.ba...@intel.com> --- meson.build | 2 +- src/gallium/state_trackers/va/meson.build | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/meson.build b/meson.build index 1ec9e4c2221..c95c44641f9

Re: [Mesa-dev] [PATCH 3/6] meson: fix va-api target linkage

Quoting Marc Dietrich (2018-01-18 04:03:21) > Am Mittwoch, 17. Januar 2018, 19:34:48 CET schrieb Dylan Baker: > > The state tracker needs to be linked with whole-archive (like > > autotools), and we need a few window system deps. > > > > Signed-off-by: Dylan Bak

Re: [Mesa-dev] [PATCH v2 2/4] meson: handle LLVM 'x.x.xgit-revision' versions

Quoting Emil Velikov (2018-01-18 10:22:50) > On 17 January 2018 at 20:54, Greg V wrote: > > When LLVM is built inside of a git repo (even way below, e.g. > > /usr/ports/.git > > exists, and LLVM is built in /usr/ports/devel/llvm50/work), its version > > becomes

Re: [Mesa-dev] [PATCH] meson: fix the install path of amdgpu.ids

Reviewed-by: Dylan Baker <dy...@pnwbakers.com> I'll go ahead and push this. Quoting Christoph Haag (2018-01-18 10:01:55) > --- > amdgpu/meson.build | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/amdgpu/meson.build b/amdgpu/meson.build >

Re: [Mesa-dev] [PATCH] anv_icd.py: improve reproducible builds

Reviewed-by: Dylan Baker <dy...@pnwbakers.com> Quoting maxin.j...@gmail.com (2018-01-18 03:33:37) > From: "Maxin B. John" <maxin.j...@intel.com> > > Sort the output to ensure build reproducibility > > Signed-off-by: Maxin B. John <maxin.j...@intel.com&g

Re: [Mesa-dev] [PATCH 0/6] meson: fix gallium media target linkage

Quoting Emil Velikov (2018-01-18 11:12:30) > On 17 January 2018 at 18:34, Dylan Baker <dy...@pnwbakers.com> wrote: > > The linkage of all of the gallium media targets is broken in various > > ways in the meson build. This series should correct that by doing more > > wh

Re: [Mesa-dev] [PATCH v2 3/4] meson: fix getting cflags from pkg-config

Quoting Emil Velikov (2018-01-18 10:26:20) > On 17 January 2018 at 20:54, Greg V wrote: > > get_pkgconfig_variable('cflags') always returns an empty list, it's a > > function for getting *custom* variables. > > > > Meson does not yet support asking for cflags, so

Re: [Mesa-dev] [PATCH 12/14] swr: build on FreeBSD/DragonFlyBSD

Quoting Emil Velikov (2018-01-18 10:50:05) > On 18 January 2018 at 18:09, Greg V wrote: > > On 01/18/2018 21:01, Emil Velikov wrote: > >> > >> On 31 December 2017 at 16:55, Greg V wrote: > >>> > >>> (Needs CPU topology detection to

Re: [Mesa-dev] [PATCH 02/14] vc4, vc5: add ETIME fallback define

Quoting Emil Velikov (2018-01-18 10:40:40) > On 18 January 2018 at 17:13, Dylan Baker <dy...@pnwbakers.com> wrote: > > I'm not sure how Emil feels about this (and the related patches) but I > > think it > > might be better to handle this at the build system level,

Re: [Mesa-dev] [PATCH 00/14] BSD portability (Meson, ANV, RADV, VC4/5, SWR)

Quoting Emil Velikov (2018-01-19 08:26:41) > On 18 January 2018 at 21:30, Dylan Baker <dy...@pnwbakers.com> wrote: > > Quoting Emil Velikov (2018-01-18 10:57:02) > >> On 18 January 2018 at 18:29, Greg V <greg@unrelenting.technology> wrote: > >> > >

Re: [Mesa-dev] [PATCH 00/14] BSD portability (Meson, ANV, RADV, VC4/5, SWR)

Quoting Daniel Stone (2018-01-19 08:50:17) > Hi, > > On 19 January 2018 at 16:26, Emil Velikov <emil.l.veli...@gmail.com> wrote: > > On 18 January 2018 at 21:30, Dylan Baker <dy...@pnwbakers.com> wrote: > >> I'm willing to defer to you on this, if you think

Re: [Mesa-dev] [PATCH 00/14] BSD portability (Meson, ANV, RADV, VC4/5, SWR)

Quoting Emil Velikov (2018-01-18 10:57:02) > On 18 January 2018 at 18:29, Greg V wrote: > > > > On 01/18/2018 21:18, Emil Velikov wrote: > >> > >> Hi Greg, > >> > >> On 31 December 2017 at 16:55, Greg V wrote: > >>> > >>> Hello everyone

[Mesa-dev] [PATCH v2] autotools: include meson build files in tarball

This adds the meson.build, meson_options.txt, and a few scripts that are used exclusively by the meson build. v2: - Remove accidentally included changes needed to test make dist with LLVM > 3.9 Signed-off-by: Dylan Baker <dylan.c.ba...@intel.com> Acked-by: Eric Engestrom <e...@

Re: [Mesa-dev] [PATCH] autotools: include meson build files in tarball

Quoting Eric Engestrom (2018-01-18 13:04:00) > On Thursday, 2018-01-18 17:09:04 +0000, Dylan Baker wrote: > > This adds the meson.build, meson_options.txt, and a few scripts that are > > used exclusively by the meson build. > > > > Signed-off-by: Dylan Baker <d

Re: [Mesa-dev] [PATCH] meson: fix some more defines meson.build

Quoting Marc Dietrich (2018-01-24 08:05:52) > Second hunk of fixes found by manual comparison with autotools generated > compiler flags. > > Signed-off-by: Marc Dietrich > --- > - Why do we need two version macros? > - And why do we either define DEBUG or NDEBUG? > - Also

Re: [Mesa-dev] [PATCH] meson: correctly set SYSCONFDIR for loading dirrc

Quoting Emil Velikov (2018-01-24 03:53:35) > On 24 January 2018 at 10:39, Marc Dietrich <marvi...@gmx.de> wrote: > > Hi Dylan, > > > > Am Dienstag, 23. Januar 2018, 19:28:08 CET schrieb Dylan Baker: > >> Fixes: d1992255bb29 ("meson: Add build Intel &qu

Re: [Mesa-dev] [PATCH] meson: correctly set SYSCONFDIR for loading dirrc

Quoting Emil Velikov (2018-01-24 11:00:04) > On 24 January 2018 at 18:19, Dylan Baker <dy...@pnwbakers.com> wrote: > > Quoting Emil Velikov (2018-01-24 03:53:35) > >> On 24 January 2018 at 10:39, Marc Dietrich <marvi...@gmx.de> wrote: > >> > Hi Dylan, >

Re: [Mesa-dev] [PATCH] meson: fix some more defines meson.build

ng on NDEBUG are controlled by > `-D b_ndebug=true|false`, and shouldn't be overridden inside meson.build > > > The two hunks below are correct though, thank you for finding these :) > Could you re-send the patch with these tags? > > Fixes: 84486f64626ad2b51291b &qu

Re: [Mesa-dev] [PATCH v2] meson: correctly set sysconfdir for drirc

Quoting Jon Turney (2018-01-24 12:26:47) > On 24/01/2018 19:35, Dylan Baker wrote: > > v2: - Also fix drirc install path > > > > Fixes: d1992255bb29 ("meson: Add build Intel "anv" vulkan driver") > > Reported-by: Marc Dietrich <marvi...@

Re: [Mesa-dev] [PATCH] meson: correctly set SYSCONFDIR for loading dirrc

Quoting Jon Turney (2018-01-24 10:29:03) > On 24/01/2018 18:19, Dylan Baker wrote: > > Quoting Emil Velikov (2018-01-24 03:53:35) > >> On 24 January 2018 at 10:39, Marc Dietrich <marvi...@gmx.de> wrote: > >>> Hi Dylan, > >>> > >>> Am

Re: [Mesa-dev] [PATCH] meson: Fix define for USE_SSE41

Matt and I talked about whether we needed the compile check, he didn't think we did because we required a GCC that has msse4.1 support, but the HAVE vs USE is a real bug (someone else noticed that too). CC'ing Matt in case I'm miss-remembering something. Quoting Scott D Phillips (2018-01-24

Re: [Mesa-dev] [PATCH] meson: Fix define for USE_SSE41

Quoting Scott D Phillips (2018-01-24 11:13:14) > Dylan Baker <dy...@pnwbakers.com> writes: > > > Matt and I talked about whether we needed the compile check, he didn't > > think we > > did because we required a GCC that has msse4.1 support, but the HAVE vs USE

Re: [Mesa-dev] [PATCH] meson: fix some more defines meson.build

gs += '-DDEBUG' > > > > > > +else > > > + pre_args += '-DNDEBUG' > > > > NAK on this hunk. > > > > In meson, asserts and other things depending on NDEBUG are controlled by > > `-D b_ndebug=true|false`, and shouldn't be overridden inside meson

Re: [Mesa-dev] [PATCH v3 01/12] meson: fix missing dependencies

Reviewed-by: Dylan Baker <dy...@pnwbakers.com> Quoting Greg V (2018-01-24 10:02:39) > Reviewed-by: Emil Velikov <emil.veli...@colalbora.com> > --- > src/gallium/drivers/radeonsi/meson.build | 2 +- > src/mesa/meson.build | 2 +- > 2 files changed, 2

[Mesa-dev] [PATCH v2] meson: correctly set sysconfdir for drirc

v2: - Also fix drirc install path Fixes: d1992255bb29 ("meson: Add build Intel "anv" vulkan driver") Reported-by: Marc Dietrich <marvi...@gmx.de> Signed-off-by: Dylan Baker <dylan.c.ba...@intel.com> Reviewed-by: Eric Engestrom <eric.engest...@imgtec.com&

Re: [Mesa-dev] [PATCH 2/2] meson: fix HAVE_LLVM version define in meson build

Someone else merged a similar patch to the first one already, but I've pushed this patch to master. Thanks! Quoting Marc Dietrich (2018-01-24 13:03:51) > LLVM patch level is not included in HAVE_LLVM. > > Fixes: e6418ab1566d ("meson: build "radv" vulkan driver for radeo

Re: [Mesa-dev] [PATCH 0/2] Small fixes for the meson build

ping Quoting Dylan Baker (2018-01-12 11:57:34) > Here's a few things I've caught as I've started trying to add the meson > build to our CI system. > > Dylan Baker (2): > meson: set proper pkg-config version for libdrm_freedreno > meson: set the minimum version correct

Re: [Mesa-dev] [PATCH v3 03/12] meson: glsl: add missing nir header dependency

I think this patch is no longer necessary, since libglsl has idep_nir, which includes a dependency on nir_opcodes_h. Although I did notice it still has inc_nir, which it doesn't need... Quoting Greg V (2018-01-24 10:02:41) > --- > src/compiler/glsl/meson.build | 2 +- > 1 file changed, 1

Re: [Mesa-dev] [PATCH v3 04/12] meson: fix getting cflags from pkg-config

Reviewed-by: Dylan Baker <dy...@pnwbakers.com> Quoting Greg V (2018-01-24 10:02:42) > get_pkgconfig_variable('cflags') always returns an empty list, it's a > function for getting *custom* variables. > > Meson does not yet support asking for cflags, so explicitly invoke &g

Re: [Mesa-dev] [PATCH] autotools: Don't redefine EXTRA_DIST for freedreno

I just noticed this too, thanks for fixing it (both of you) For whichever one, Reviewed-by: Dylan Baker <dy...@pnwbakers.com> Quoting Emil Velikov (2018-01-25 03:14:45) > On 25 January 2018 at 08:25, Daniel Stone <dani...@collabora.com> wrote: > > The EXTRA_DIST of mes

[Mesa-dev] [PATCH v4] meson: Don't confuse the install and search paths for dri drivers

: db9788420d4bc7b4 ("meson: Add support for configuring dri drivers directory.") Reported-by: Ilia Mirkin <imir...@alum.mit.edu> Signed-off-by: Dylan Baker <dylan.c.ba...@intel.com> Reviewed-by: Eric Anholt <e...@anholt.net> (v2) Reviewed-by: Eric Engestrom <e...@en

[Mesa-dev] [PATCH v2] meson: generate translations for driconf

of make or ninja. I think this can be fixed upstream, but in the mean time this adds support for using translations. Fixes: 3218056e0eb3 ("meson: Build i965 and dri stack") Signed-off-by: Dylan Baker <dylan.c.ba...@intel.com> --- I could have sworn that I've sent this out before,

[Mesa-dev] [PATCH libdrm] meson: fix libdrm_nouveau pkgconfig include directories

Signed-off-by: Dylan Baker <dylan.c.ba...@intel.com> --- I have tested building every mesa driver against this (with and without udev!) so I'm pretty sure that this is the last pkgbuild problem. I'm sure I'll be sad in a day or two... nouveau/meson.build | 2 +- 1 file changed, 1 ins

Re: [Mesa-dev] [PATCH 1/2] meson: set proper pkg-config version for libdrm_freedreno

Quoting Emil Velikov (2018-01-25 02:30:10) > Hi Dylan, > > To make it easier to spot these, do set the git subject prefix to PATCH > libdrm. > See autogen.sh for an example. > > On 12 January 2018 at 19:57, Dylan Baker <dy...@pnwbakers.com> wrote: > >

Re: [Mesa-dev] [PATCH] meson: libdrm shouldn't appear in Requires.private: if it wasn't found

Please add this to the commit message: Fixes: 3218056e0eb3 ("meson: Build i965 and dri stack") Reviewed-by: Dylan Baker <dy...@pnwbakers.com> Quoting Jon Turney (2018-01-26 04:42:50) > Otherwise, using pkg-config to retrieve flags will fail, e.g. > > $ pkg-config gl

[Mesa-dev] [PATCH 6/6] meson: fix xvmc target linkage

This needs to link the state tracker with whole-archive, it needs to link with libxvmc, and it needs a few extra window system dependencies. Signed-off-by: Dylan Baker <dylan.c.ba...@intel.com> --- meson.build | 5 - src/gallium/targets/xvmc/meson.buil

[Mesa-dev] [PATCH 1/6] meson: link dri3 xcb libs into vlwinsys instead of into each target

This makes the dependencies easier to manage, since each media target doesn't need to worry about linking to half a dozen libraries. Signed-off-by: Dylan Baker <dylan.c.ba...@intel.com> --- src/gallium/auxiliary/meson.build | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff

Re: [Mesa-dev] [Test Patch] Meson: ensure vdpau has proper symbols exposed

I dug into what autotools is doing. It's using -Wl,--whole-archive to link everything, in this target, not just the state tracker. I think I'm okay with this patch given that, so I'm going to apply the same change to the other media state trackers and send it out as a series. Quoting Dylan Baker

[Mesa-dev] [PATCH 4/6] meson: Fix omx-bellagio target linkage

-by: Dylan Baker <dylan.c.ba...@intel.com> --- meson.build | 5 - src/gallium/targets/omx-bellagio/meson.build | 18 -- 2 files changed, 12 insertions(+), 11 deletions(-) diff --git a/meson.build b/meson.build index ae31cdd..bd4afdf

[Mesa-dev] [PATCH 0/6] meson: fix gallium media target linkage

The linkage of all of the gallium media targets is broken in various ways in the meson build. This series should correct that by doing more what the autotools build does. Dylan Baker (6): meson: link dri3 xcb libs into vlwinsys instead of into each target meson: fix vdpau target linkage

[Mesa-dev] [PATCH 3/6] meson: fix va-api target linkage

The state tracker needs to be linked with whole-archive (like autotools), and we need a few window system deps. Signed-off-by: Dylan Baker <dylan.c.ba...@intel.com> --- src/gallium/targets/va/meson.build | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git

Re: [Mesa-dev] [PATCH] meson: Don't confuse the install and search paths for dri drivers

Quoting Eric Anholt (2018-01-17 12:32:32) > Dylan Baker <dy...@pnwbakers.com> writes: > > > Currently there is not a separate option for setting the search path of > > DRI drivers in meson, like there is in scons and autotools. This is an > > oversight and needs t

[Mesa-dev] [PATCH 5/6] meson: fix xa target linkage

This needs to link the state-tracker with whole archive, and needs a few extra window-system deps. Signed-off-by: Dylan Baker <dylan.c.ba...@intel.com> --- src/gallium/targets/xa/meson.build | 16 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/src/gallium/t

[Mesa-dev] [PATCH 2/6] meson: fix vdpau target linkage

The VDPAU state tracker needs to be linked with whole-archive (autotools does this), and a few dependeies can be cleaned up Signed-off-by: Dylan Baker <dylan.c.ba...@intel.com> --- src/gallium/targets/vdpau/meson.build | 16 1 file changed, 12 insertions(+), 4 deletions(-)

Re: [Mesa-dev] [PATCH 2/6] st/omx/tizonia: Add --enable-omx-tizonia flag and build files

The meson build for omx-bellagio has landed along with the other media state trackers that are in tree. Currently there is a known bug with at least vdpau and va-api (I suspect that the omx, va, and xvmc are affected as well) which causes required symbols to not be exported, I'm still trying to

[Mesa-dev] [PATCH 1/2] meson: set proper pkg-config version for libdrm_freedreno

Copy and paste error from exynos. Signed-off-by: Dylan Baker <dylan.c.ba...@intel.com> --- freedreno/meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/freedreno/meson.build b/freedreno/meson.build index b4035e1..de6a413 100644 --- a/freedreno/meson.build

Re: [Mesa-dev] [PATCH 4/7] report.py: Add option to only display the final summary

Quoting Ian Romanick (2018-01-12 12:06:58) > From: Ian Romanick > > This is useful for preparing data to go in a Mesa commit message. > > Signed-off-by: Ian Romanick > --- > report.py | 60

Re: [Mesa-dev] [PATCH 5/7] report.py: Add option to only display measurements that have changes

Quoting Ian Romanick (2018-01-12 12:06:59) > From: Ian Romanick > > This is useful for preparing data to go in a Mesa commit message. > > Signed-off-by: Ian Romanick > --- > report.py | 53

[Mesa-dev] [PATCH 0/2] Small fixes for the meson build

Here's a few things I've caught as I've started trying to add the meson build to our CI system. Dylan Baker (2): meson: set proper pkg-config version for libdrm_freedreno meson: set the minimum version correctly freedreno/meson.build | 2 +- meson.build | 2 +- 2 files changed, 2

Re: [Mesa-dev] [PATCH 1/2] meson: Fix configuring dri glx with only gallium drivers

meson considers classic swrast to be a dri driver, I know it's not exactly accurate, but, at least for me, it made the build system easier to reason about. Quoting Adam Jackson (2018-01-12 09:06:37) > On Fri, 2018-01-12 at 13:18 +, Jon Turney wrote: > > 'meson -Ddri-drivers=

Re: [Mesa-dev] [PATCH 1/2] meson: Fix configuring dri glx with only gallium drivers

Maybe this is correct, but it makes me nervous treating with_gallium as equivalent to with_dri, since gallium drivers can be built dri-less (gallium-xlib, and some other configurations on windows). I think something like: with_glx = get_option('glx') if with_glx == 'auto' if with_dri

[Mesa-dev] [PATCH 2/2] meson: set the minimum version correctly

Currently we ask for 0.42, but we actually require 0.43 because we pass file objects as arguments to tests. If someone needs version 0.42 it wouldn't be hard, just a lot of replacing files() with strings. Signed-off-by: Dylan Baker <dylan.c.ba...@intel.com> --- meson.build | 2 +- 1 file c

Re: [Mesa-dev] [PATCH] glx: fix non-dri build

I don't know enough about glx to know if this is correct, but you'll need to add the c files to the meson.build as well On January 13, 2018 3:36:30 AM PST, Samuel Thibault wrote: >glXGetDriverConfig parameters do not provide a context to dynamically >check for the

Re: [Mesa-dev] [PATCH v3 00/12] BSD portability (Meson, ANV, RADV, VC4/5, SWR)

I've gone ahead and added my rb to the remaining meson patches, added the relevant Fixes tags, and pushed them to master (except the one that I don't think is necessary now). Thanks for working on this. Dylan Quoting Greg V (2018-01-24 10:02:38) > meson: updated with suggestions from review. >

Re: [Mesa-dev] meson: vdpau broken on r600

can never remember). Running with 'strace -f' > can help figure this stuff out. > > -ilia > > On Thu, Jan 11, 2018 at 12:21 PM, Dylan Baker <dy...@pnwbakers.com> wrote: > > I couldn't reproduce with nouveau, vdpauinfo seems hardcoded to look for > > vdpau_nvidia, and

[Mesa-dev] [PATCH 09/10] meson: Build gallium trivial tests

Signed-off-by: Dylan Baker <dylan.c.ba...@intel.com> --- meson.build | 2 +-- src/gallium/meson.build | 6 -- src/gallium/tests/meson.build | 21 - src/gallium/tests/trivial/meson.build | 29 ++

[Mesa-dev] [PATCH 10/10] meson: build gallium unit tests

Signed-off-by: Dylan Baker <dylan.c.ba...@intel.com> --- src/gallium/tests/meson.build | 1 +- src/gallium/tests/unit/meson.build | 31 +++- 2 files changed, 32 insertions(+) create mode 100644 src/gallium/tests/unit/meson.build diff --git a/src/gallium

[Mesa-dev] [PATCH 02/10] meson: run glsl compiler warnings test

Signed-off-by: Dylan Baker <dylan.c.ba...@intel.com> --- src/compiler/glsl/tests/meson.build | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/src/compiler/glsl/tests/meson.build b/src/compiler/glsl/tests/meson.build index 27f3407..11fb4fb 100644 --- a/src/co

[Mesa-dev] [PATCH 08/10] meson: Remove TODO about mesa/main tests

They're already done. Signed-off-by: Dylan Baker <dylan.c.ba...@intel.com> --- src/mesa/meson.build | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/mesa/meson.build b/src/mesa/meson.build index ab6bc27..ce612fb 100644 --- a/src/mesa/meson.build +++ b/src/mesa/meson.build @@ -18,8

Re: [Mesa-dev] meson: vdpau broken on r600

-archive where autotools doesn't. Quoting Eric Engestrom (2018-01-11 08:58:32) > On Tuesday, 2018-01-09 10:09:16 -0800, Dylan Baker wrote: > > I'm not sure off the top of my head. I don't have an r600 anymore, but I > > have an > > SI and a nouveau machine, so I'll s

[Mesa-dev] [PATCH 05/10] glsl/tests: Remove unused compare_ir.py script

Signed-off-by: Dylan Baker <dylan.c.ba...@intel.com> --- src/compiler/glsl/tests/compare_ir.py | 58 + 1 file changed, 58 deletions(-) delete mode 100644 src/compiler/glsl/tests/compare_ir.py diff --git a/src/compiler/glsl/tests/compare_ir.py b/src/compile

[Mesa-dev] [PATCH 03/10] glsl/tests: Convert optimization-test.sh to pure python

This patch converts optimization-test.sh to python, in this process it removes external shell dependencies including diff. It replaces the python script that generates shell scripts with a python library that generates test cases and runs them using subprocess. Signed-off-by: Dylan Baker

[Mesa-dev] [PATCH 06/10] glcpp/tests: Convert shell scripts to a python script

This ports glcpp-test.sh and glcpp-test-cr-lf.sh to a python script that accepts arguments for each line ending type. This should allow for better reporting to users. Signed-off-by: Dylan Baker <dylan.c.ba...@intel.com> --- src/compiler/glsl/glcpp/tests/glcpp-test-cr-lf.sh | 148 +-

[Mesa-dev] [PATCH 01/10] glsl/tests: reimplement warnings-test in python

, no more diff, pwd or sh. It's also no longer tied to autotools implementation details, like the environment variables $srcdir and $abs_builddir, though the autotools shell wrapper still uses those, which makes it possible to run the test in meson. Signed-off-by: Dylan Baker <dylan.c.ba...@intel.

[Mesa-dev] [PATCH 04/10] meson: enable optimization-test

Signed-off-by: Dylan Baker <dylan.c.ba...@intel.com> --- src/compiler/glsl/tests/meson.build | 5 + 1 file changed, 5 insertions(+) diff --git a/src/compiler/glsl/tests/meson.build b/src/compiler/glsl/tests/meson.build index 11fb4fb..d5e6b5f 100644 --- a/src/compiler/glsl/tests/meson

Re: [Mesa-dev] [PATCH v2] r600: Allow egd_tables.py to run with python3 too

This is somewhat insufficient, it might run okay with python3, but the behavior will be different between the two. Please add `from __future__ import print_function`, so that the behavior will be the same, not just the syntax. Also, the StringTable, InteTable, Field, and Reg classes is also an

[Mesa-dev] [Test Patch] Meson: ensure vdpau has proper symbols exposed

Signed-off-by: Dylan Baker <dylan.c.ba...@intel.com> --- src/gallium/targets/vdpau/meson.build | 16 +--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git a/src/gallium/targets/vdpau/meson.build b/src/gallium/targets/vdpau/meson.build index 67f1469fb0f..432a32a7340

[Mesa-dev] [PATCH 07/10] meson: enable glcpp test

Signed-off-by: Dylan Baker <dylan.c.ba...@intel.com> --- src/compiler/glsl/glcpp/meson.build | 18 +- 1 file changed, 17 insertions(+), 1 deletion(-) diff --git a/src/compiler/glsl/glcpp/meson.build b/src/compiler/glsl/glcpp/meson.build index 17ee1a2..9f869da 100644 ---

[Mesa-dev] [PATCH 00/10] Finish unit tests for meson build

, they are not meant to be run directly, just to wrap the python scripts for autotools. Dylan Baker (10): glsl/tests: reimplement warnings-test in python meson: run glsl compiler warnings test glsl/tests: Convert optimization-test.sh to pure python meson: enable optimization-test glsl/tests: Remove

Re: [Mesa-dev] [PATCH mesa 1/2] meson: centralise the libdrm versions information

Quoting Eric Engestrom (2018-01-30 09:55:53) > > > On January 30, 2018 5:34:07 PM UTC, Dylan Baker <dy...@pnwbakers.com> wrote: > > Quoting Eric Engestrom (2018-01-29 10:15:50) > > > The big comment is taken from the equivalent block in configure.ac > > &g

Re: [Mesa-dev] [PATCH libdrm] meson: fix libdrm_nouveau pkgconfig include directories

ping Quoting Dylan Baker (2018-01-25 16:14:45) > Signed-off-by: Dylan Baker <dylan.c.ba...@intel.com> > --- > > I have tested building every mesa driver against this (with and without udev!) > so I'm pretty sure that this is the last pkgbuild problem. > > I'm sure

Re: [Mesa-dev] [PATCH v2] meson: generate translations for driconf

Quoting Marc Dietrich (2018-01-27 06:36:51) > Hi Dylan, > > Am Donnerstag, 25. Januar 2018, 20:32:23 CET schrieb Dylan Baker: > > Currently meson implements the same logic as SCons for translations, > > namely it doesn't do them. This patch changes meson to use logic mo

Re: [Mesa-dev] [PATCH mesa 1/2] meson: centralise the libdrm versions information

Quoting Eric Engestrom (2018-01-29 10:15:50) > The big comment is taken from the equivalent block in configure.ac > > Signed-off-by: Eric Engestrom > --- > meson.build | 30 > + >

Re: [Mesa-dev] [PATCH 3/6] meson: build src/glx/apple

Quoting Jon Turney (2018-01-28 06:24:10) > --- > src/glx/apple/meson.build | 62 > +++ > src/glx/meson.build | 4 +++ > 2 files changed, 66 insertions(+) > create mode 100644 src/glx/apple/meson.build > > diff --git a/src/glx/apple/meson.build

Re: [Mesa-dev] [PATCH 4/6] meson: osx doesn't have librt, so don't require it

Quoting Jon Turney (2018-01-28 06:24:11) > --- > meson.build | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/meson.build b/meson.build > index 7e194a9f10d..8fdbaa8b8d8 100644 > --- a/meson.build > +++ b/meson.build > @@ -935,7 +935,7 @@ elif with_dri_i965 and

Re: [Mesa-dev] [PATCH 0/6] meson: build src/glx/apple

Quoting Jon Turney (2018-01-28 06:24:07) > This also requires my "fix osx" series to actually build > > Dylan Baker (2): > meson: find python2 on macOS > meson: set apple glx defines > > Jon Turney (4): > meson: build src/glx/apple > meson: osx

Re: [Mesa-dev] [PATCH 4/6] meson: osx doesn't have librt, so don't require it

Quoting Emil Velikov (2018-01-30 10:56:42) > Hi Jon, > > On 28 January 2018 at 14:24, Jon Turney wrote: > > --- > > meson.build | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/meson.build b/meson.build > > index

Re: [Mesa-dev] [PATCH mesa 1/2] meson: centralise the libdrm versions information

Quoting Emil Velikov (2018-01-30 10:43:06) > On 29 January 2018 at 18:57, Dylan Baker <dy...@pnwbakers.com> wrote: > > Quoting Eric Engestrom (2018-01-29 10:15:50) > >> The big comment is taken from the equivalent block in configure.ac > >> > >>

Re: [Mesa-dev] [PATCH] radv: Don't expose VK_KHX_multiview on android.

Quoting Bas Nieuwenhuizen (2018-02-02 10:14:04) > On Fri, Feb 2, 2018 at 6:59 PM, Emil Velikov wrote: > > Hi Bas, > > > > On 31 January 2018 at 11:31, Bas Nieuwenhuizen wrote: > >> deqp does not allow any KHX extensions, and since deqp is included >

Re: [Mesa-dev] [PATCH] amd: remove support for LLVM 3.9

FYI: I sent out a patch a few minutes ago to set the minimum version more like autotools does, but I'm fine with this landing first. Reviewed-by: Dylan Baker <dy...@pnwbakers.com> Quoting Marek Olšák (2018-02-02 11:07:57) > Adding this: > > diff --git a/meson.build b/meson.build

[Mesa-dev] [PATCH] meson: Check for actual LLVM required versions

driver for radeon hardware") Signed-off-by: Dylan Baker <dylan.c.ba...@intel.com> --- meson.build | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/meson.build b/meson.build index 80ea60ffa7d..0a030b92d0a 100644 --- a/meson.build +++ b/m

Re: [Mesa-dev] [PATCH] amd: remove support for LLVM 3.9

too otherwise. > > Though either way: > > Reviewed-by: Bas Nieuwenhuizen <b...@basnieuwenhuizen.nl> > > On Fri, Feb 2, 2018 at 8:15 PM, Dylan Baker <dy...@pnwbakers.com> wrote: > > FYI: I sent out a patch a few minutes ago to set the minimum version more &g

<    8   9   10   11   12   13   14   15   16   17   >