Re: [Mesa-dev] [PATCH mesa] intel: various python cleanups

2018-08-16 Thread Dylan Baker
print(" %-36s %s%s;" % (type, self.name, dim)) > > prefix = "" > -if len(self.values) > 0 and self.default == None: > +if self.values and self.default == None: Since you changed the other instances to be correct, 'self.

Re: [Mesa-dev] [PATCH v2 3/5] configure: Enforce python 2.7.x

2018-08-16 Thread Dylan Baker
Quoting Emil Velikov (2018-08-16 09:19:06) > On 16 August 2018 at 14:27, Emil Velikov wrote: > > On 15 August 2018 at 17:18, Dylan Baker wrote: > >> We don't want to support older versions of python 2 anymore, and we > >> don't support python

[Mesa-dev] [PATCH v3 02/48] add a git ignore for subprojects

2018-08-06 Thread Dylan Baker
--- subprojects/.gitignore | 3 +++ 1 file changed, 3 insertions(+) create mode 100644 subprojects/.gitignore diff --git a/subprojects/.gitignore b/subprojects/.gitignore new file mode 100644 index 000..68a882edba6 --- /dev/null +++ b/subprojects/.gitignore @@ -0,0 +1,3 @@ +* +!*.wrap

Re: [Mesa-dev] [PATCH v3 02/13] nvc0/ir: return 0 in imageLoad on incomplete textures

2018-08-06 Thread Dylan Baker
Quoting Karol Herbst (2018-07-15 11:15:42) > We already guarded all OP_SULDP against out of bound accesses, but those > ended up just reusing whatever value was stored in the dest registers. > > fixes CTS test shader_image_load_store.incomplete_textures > > v2: fix for loads not ending up with

Re: [Mesa-dev] [PATCH 1/3] meson: use dependency()+find_program() for wayland-scanner

2018-08-06 Thread Dylan Baker
Quoting Emil Velikov (2018-06-28 07:35:44) > From: Emil Velikov > > Helps when the native wayland-scanner is located outside of PATH. > Inspired by the xserver code ;-) > > Cc: Dylan Baker > Cc: Eric Engestrom > Signed-off-by: Emil Velikov > --- > meson.buil

[Mesa-dev] [PATCH] main/tests: Add AMD_framebuffer_multisample_advanced

2018-08-06 Thread Dylan Baker
Add dispatch_sanity tests Fixes: 3d6900d76efaef1ff6e84b7b8785bbe3d8f5b29b ("glapi: define AMD_framebuffer_multisample_advanced and add its functions") Cc: Marek Olšák Cc: Brian Paul Signed-off-by: Dylan Baker --- Marek, the XML in mesa and the Khronos XML agree that

Re: [Mesa-dev] [PATCH 3/4] anv: Use central api generation scripts.

2018-08-13 Thread Dylan Baker
Quoting Emil Velikov (2018-08-13 03:38:13) > On 10 August 2018 at 00:57, Dylan Baker wrote: > > Quoting Chad Versace (2018-08-09 10:37:33) > >> On Tue 07 Aug 2018, Dylan Baker wrote: > >> > Quoting Bas Nieuwenhuizen (2018-08-07 16:14:33) > >> > &g

Re: [Mesa-dev] [PATCH 3/4] anv: Use central api generation scripts.

2018-08-09 Thread Dylan Baker
Quoting Chad Versace (2018-08-09 10:37:33) > On Tue 07 Aug 2018, Dylan Baker wrote: > > Quoting Bas Nieuwenhuizen (2018-08-07

Re: [Mesa-dev] [PATCH v3 08/48] meson: fix dl detection on non cygwin windows

2018-08-09 Thread Dylan Baker
Quoting Eric Engestrom (2018-08-09 08:36:55) > On Monday, 2018-08-06 17:50:48 -0700, Dylan Baker wrote: > > --- > > meson.build | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/meson.build b/meson.build > >

Re: [Mesa-dev] [PATCH v3 19/48] meson: build libgl-gdi target

2018-08-09 Thread Dylan Baker
Quoting Eric Anholt (2018-08-07 11:12:27) > Dylan Baker writes: > > > --- > > src/gallium/meson.build | 1 + > > src/gallium/targets/libgl-gdi/meson.build | 44 +++ > > 2 files changed, 45 insertions(+) > > create mode

Re: [Mesa-dev] [PATCH v3 20/48] meson: build graw-gdi target

2018-08-09 Thread Dylan Baker
Quoting Eric Anholt (2018-08-07 11:14:16) > Dylan Baker writes: > > > --- > > src/gallium/meson.build | 4 ++- > > src/gallium/targets/graw-gdi/meson.build | 36 > > 2 files changed, 39 insertions(+), 1 deletion(-) >

Re: [Mesa-dev] [Mesa-stable] [PATCH v4 1/2] wayland/egl: initialize window surface size to window size

2018-08-09 Thread Dylan Baker
Quoting Juan A. Suarez Romero (2018-08-07 08:49:36) > When creating a windows surface with eglCreateWindowSurface(), the > width and height returned by eglQuerySurface(EGL_{WIDTH,HEIGHT}) is > invalid until buffers are updated (like calling glClear()). > > But according to EGL 1.5 spec, section

Re: [Mesa-dev] [PATCH v2 8/9] python: Rework bytes/unicode string handling

2018-08-09 Thread Dylan Baker
ain, but assuming everything still looks good I'll be merging everything but this patch and the next patch today. For every patch up to this point: Reviewed-by: Dylan Baker Quoting Mathieu Bridon (2018-08-09 01:27:25) > In both Python 2 and 3, opening a file without specifying the mode will >

Re: [Mesa-dev] [PATCH v2 7/9] python: Simplify list sorting

2018-08-09 Thread Dylan Baker
All patches up to here (including this one) have been pushed to master. I had comments on patch 8, and I want to follow up with our CI team to make sure we have all the dependencies for python 3 in our CI. Dylan Quoting Mathieu Bridon (2018-08-09 01:27:24) > Instead of copying the list, then

Re: [Mesa-dev] [PATCH 3/4] anv: Use central api generation scripts.

2018-08-13 Thread Dylan Baker
Quoting Bas Nieuwenhuizen (2018-08-13 09:25:01) > On Mon, Aug 13, 2018 at 5:54 PM, Dylan Baker wrote: > > Quoting Emil Velikov (2018-08-13 03:38:13) > >> On 10 August 2018 at 00:57, Dylan Baker wrote: > >> > Quoting Chad Versace (2018-08-09 10:37:33) > >> &

[Mesa-dev] [ANNOUNCE] mesa 18.1.6

2018-08-13 Thread Dylan Baker
Hi list, I'm announcing the general availability of the 18.1.6 release. This is an 18.1 bugfix release. There are two more 18.1 bug fix releases planned at this time. We've had another busy cycle the last two weeks, there have been roughly 3 dozen fixes in this release. In brief: -

Re: [Mesa-dev] [PATCH v2] meson, install_megadrivers: Also remove stale symlinks

2018-08-06 Thread Dylan Baker
ing in the way of installing this file) > > > > v2: use only os.path.lexist and replace all instances > > of os.path.exist (Dylan Baker) > > > > Fixes: f7f1b30f81e842db6057591470ce3cb6d4fb2795 > > ("meson: extend install_megadrivers script to handle sy

Re: [Mesa-dev] [PATCH v3 14/48] meson: Make shader-cache a trillean instead of boolean

2018-08-08 Thread Dylan Baker
Quoting Eric Anholt (2018-08-07 10:58:52) > Dylan Baker writes: > > > So that it can be implicitly disabled on windows, where it doesn't > > compile. > > I don't see how this option successfully controls the shader cache being > built. The entire shader cache code

Re: [Mesa-dev] [PATCH] anv/lower_ycbcr: Use the binding array size for bounds checks

2018-08-20 Thread Dylan Baker
Quoting Lionel Landwerlin (2018-08-20 08:59:38) > From: Jason Ekstrand > > Because lower_ycbcr gets called before apply_pipeline_layout, the > indices are all logical and the binding layout HW size is actually too > big for the bounds check. We should just use the regular logical array > size

Re: [Mesa-dev] [PATCH 1/5] anv/lower_ycbcr: Use the binding array size for bounds checks

2018-08-20 Thread Dylan Baker
Quoting Jason Ekstrand (2018-08-08 01:12:49) > Because lower_ycbcr gets called before apply_pipeline_layout, the > indices are all logical and the binding layout HW size is actually too > big for the bounds check. We should just use the regular logical array > size instead. > > Fixes:

Re: [Mesa-dev] [PATCH] autotools: include git_sha1.h in dist tarball

2018-08-20 Thread Dylan Baker
Reviewed-by: Dylan Baker Quoting Juan A. Suarez Romero (2018-08-20 07:22:35) > This fixes `make distcheck`. > > Fixes: 471f708ed6 ("git_sha1: simplify logic") > CC: Eric Engestrom > --- > src/Makefile.am | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) &g

Re: [Mesa-dev] [PATCHv2 1/2] meson: Use python to run glsl tests

2018-08-17 Thread Dylan Baker
Quoting Emil Velikov (2018-08-17 04:11:32) > From: Dylan Baker > > There are multiple reasons why the python scripts are executed > explicitly via $PYTHON or equivalent. In random order: > > - env is rarely a thing on Windows windows does something completely diffe

Re: [Mesa-dev] [PATCH mesa] util/xmlpool: make indentation coherent

2018-08-17 Thread Dylan Baker
Reviewed-by: Dylan Baker Quoting Eric Engestrom (2018-08-16 08:03:23) > Signed-off-by: Eric Engestrom > --- > src/util/xmlpool/t_options.h | 26 +- > 1 file changed, 13 insertions(+), 13 deletions(-) > > diff --git a/src/util/xmlpool/t_options.h

Re: [Mesa-dev] [PATCH 1/2] compiler/glsl/tests: Make tests python3 safe

2018-08-17 Thread Dylan Baker
Quoting Mathieu Bridon (2018-08-16 15:00:39) > On Thu, 2018-08-16 at 14:21 -0700, Dylan Baker wrote: > > --- > > > > I didn't see any patches from anyone else, so I wrote some real > > quick. Please > > point to them if other patches already exist. > >

[Mesa-dev] [PATCH v2 1/2] compiler/glsl/tests: Make tests python3 safe

2018-08-17 Thread Dylan Baker
v2: - explicitly decode the output of subprocesses - handle bytes and string types consistently rather than relying on python 2's coercion for bytes and ignoring them in python 3 --- src/compiler/glsl/tests/lower_jump_cases.py | 2 +- src/compiler/glsl/tests/optimization_test.py | 6

[Mesa-dev] [PATCH v2 2/2] meson: Use python3 to run glsl tests

2018-08-17 Thread Dylan Baker
--- src/compiler/glsl/tests/meson.build | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/src/compiler/glsl/tests/meson.build b/src/compiler/glsl/tests/meson.build index fc7b863a278..2a41e30a28d 100644 --- a/src/compiler/glsl/tests/meson.build +++

Re: [Mesa-dev] [PATCH 1/2] configure: use AM_PATH_PYTHON to look for the python version

2018-08-17 Thread Dylan Baker
Quoting Emil Velikov (2018-08-17 03:12:56) > On 16 August 2018 at 21:28, Dylan Baker wrote: > > Quoting Eric Engestrom (2018-08-16 09:52:05) > >> On Thursday, 2018-08-16 17:18:56 +0100, Emil Velikov wrote: > >> > From: Emil Velikov > >> > >

Re: [Mesa-dev] [PATCH 1/2] compiler/glsl/tests: Make tests python3 safe

2018-08-17 Thread Dylan Baker
Quoting Mathieu Bridon (2018-08-16 15:00:39) > On Thu, 2018-08-16 at 14:21 -0700, Dylan Baker wrote: > > --- > > > > I didn't see any patches from anyone else, so I wrote some real > > quick. Please > > point to them if other patches already exist. > >

Re: [Mesa-dev] [PATCH 2/2] glsl: remove execute bit and shebang from python tests

2018-08-17 Thread Dylan Baker
a script is python2, python3, or both (using python is supposed to mean python 2 and 3 compatible.) You have my r-b, but please wait to push thisfor the other patches to land or you'll break the meson build and make Mark and Clayton grumpy: Reviewed-by: Dylan Baker Quoting Emil Velikov (2018-08-17 04

Re: [Mesa-dev] [PATCH 1/2] compiler/glsl/tests: Make tests python3 safe

2018-08-17 Thread Dylan Baker
Quoting Mathieu Bridon (2018-08-17 11:01:23) > On Fri, 2018-08-17 at 10:45 -0700, Dylan Baker wrote: > > Quoting Mathieu Bridon (2018-08-16 15:00:39) > > > On Thu, 2018-08-16 at 14:21 -0700, Dylan Baker wrote: > > > > --- > > > > > > > > I di

Re: [Mesa-dev] [PATCH] docs: update required mako version

2018-08-17 Thread Dylan Baker
Reviewed-by: Dylan Baker Quoting Emil Velikov (2018-08-16 09:58:53) > From: Emil Velikov > > The requirement was bumped a while back, but we forgot to update the > docs. > > Fixes: ed871af91c2 ("configure.ac: raise Mako required version to > 0.8.0") > Cc: Eri

[Mesa-dev] [PATCH v3 1/2] compiler/glsl/tests: Make tests python3 safe

2018-08-17 Thread Dylan Baker
v2: - explicitly decode the output of subprocesses - handle bytes and string types consistently rather than relying on python 2's coercion for bytes and ignoring them in python 3 v3: - explicitly set encode as well as decode - python 2.7 and 3.x `bytes` instead of defining an alias

[Mesa-dev] [PATCH v3 2/2] meson: Use python3 to run glsl tests

2018-08-17 Thread Dylan Baker
--- src/compiler/glsl/tests/meson.build | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/src/compiler/glsl/tests/meson.build b/src/compiler/glsl/tests/meson.build index fc7b863a278..2a41e30a28d 100644 --- a/src/compiler/glsl/tests/meson.build +++

Re: [Mesa-dev] [PATCH v2 1/2] compiler/glsl/tests: Make tests python3 safe

2018-08-17 Thread Dylan Baker
Quoting Mathieu Bridon (2018-08-17 10:58:38) > On Fri, 2018-08-17 at 10:51 -0700, Dylan Baker wrote: > > diff --git a/src/compiler/glsl/tests/optimization_test.py > > b/src/compiler/glsl/tests/optimization_test.py > > index 577d2dfc20f..65bac676963 100755 > > --

Re: [Mesa-dev] [PATCH 1/2] meson: fix egl build for surfaceless

2018-08-22 Thread Dylan Baker
nd >deps_for_egl += [dep_wayland_client, dep_wayland_server, > dep_wayland_egl_headers] > -- > 2.16.4 > For the series, Reviewed-by: Dylan Baker I'll go ahead and push these, thanks for fixing this. Dylan signature.asc Description: signature __

Re: [Mesa-dev] [PATCH v4 46/49] appveyor: use chocolatey (cinst) to install winflexbison

2018-08-23 Thread Dylan Baker
Quoting Jose Fonseca (2018-08-22 11:39:12) > On 22/08/18 18:05, Dylan Baker wrote: > > v2: - fix typos in commit message > > --- > > appveyor.yml | 6 +- > > 1 file changed, 1 insertion(+), 5 deletions(-) > > > > diff --git a/appveyor.yml b/appveyor

Re: [Mesa-dev] [PATCH v4 12/49] meson: don't build glx or dri by default on windows

2018-08-23 Thread Dylan Baker
Quoting Eric Engestrom (2018-08-23 10:13:17) > On Wednesday, 2018-08-22 10:04:35 -0700, Dylan Baker wrote: > > Signed-off-by: Dylan Baker > > Reviewed-by: Eric Anholt > > --- > > meson.build | 8 ++-- > > 1 file changed, 6 insertions(+), 2 deletions(-) &g

Re: [Mesa-dev] [PATCH 2/3] configure: allow building with python3

2018-08-24 Thread Dylan Baker
Quoting Emil Velikov (2018-08-24 02:34:04) > On Fri, 24 Aug 2018 at 04:23, Ilia Mirkin wrote: > > > > This breaks the build for me. It selects python3 instead of python2, > > and gen_xmlpool.py bails out when trying to print \xf3 to stdout with > > a LANG=C locale. Revert until scripts are fixed

[Mesa-dev] [PATCH 3/5] meson: add support for generating translation mo files

2018-08-24 Thread Dylan Baker
Meson has handy a handy built-in module for handling gettext called i18n, this module works a bit differently than our autotools build does, namely it doesn't automatically generate translations instead it creates 3 new top level targets to run. These are: xmlpool-pot xmlpool-update-po

[Mesa-dev] [PATCH 5/5] meson: use meson generated translation files

2018-08-24 Thread Dylan Baker
This is a change from the current status-quo, namely to get dri-conf translations you now *must* run the meson generation scripts, even if you're building from an autotools generated tarball (an official release). --- src/util/xmlpool/meson.build | 2 +- 1 file changed, 1 insertion(+), 1

[Mesa-dev] [PATCH 2/5] util/gen_xmlpool: use argparse for argument handling

2018-08-24 Thread Dylan Baker
This is a little cleaner than just looking at sys.argv, but it's also going to allow us to handle the differences in the way meson and autotools hand translations more cleanly. --- src/util/xmlpool/gen_xmlpool.py | 20 +--- 1 file changed, 9 insertions(+), 11 deletions(-) diff

[Mesa-dev] [PATCH 0/5] Meson support for gettext translations

2018-08-24 Thread Dylan Baker
This is the last thing I know of that's outstanding for meson (that's not related to windows). One patch in this series is a fix that needs to go into 18.1 and 18.2. Dylan Baker (5): meson: Actually load translation files util/gen_xmlpool: use argparse for argument handling meson: add

[Mesa-dev] [PATCH 4/5] util/gen_xmlpool: Add a --meson switch

2018-08-24 Thread Dylan Baker
Meson won't put the .gmo files in the layout that python's gettext.translation() expects, so we need to handle them differently, this switch allows the script to load the files as meson lays them out --- src/util/xmlpool/gen_xmlpool.py | 15 +++ 1 file changed, 11 insertions(+), 4

[Mesa-dev] [PATCH 1/5] meson: Actually load translation files

2018-08-24 Thread Dylan Baker
Currently we run the script but don't actually load any files, even in a tarball where they exist. Fixes: 3218056e0eb375eeda470058d06add1532acd6d4 ("meson: Build i965 and dri stack") --- src/util/xmlpool/meson.build | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git

Re: [Mesa-dev] [PATCH 2/3] configure: allow building with python3

2018-08-24 Thread Dylan Baker
Quoting Emil Velikov (2018-08-24 02:34:04) > On Fri, 24 Aug 2018 at 04:23, Ilia Mirkin wrote: > > > > This breaks the build for me. It selects python3 instead of python2, > > and gen_xmlpool.py bails out when trying to print \xf3 to stdout with > > a LANG=C locale. Revert until scripts are fixed

Re: [Mesa-dev] [PATCH 4/5] util/gen_xmlpool: Add a --meson switch

2018-08-24 Thread Dylan Baker
Quoting Emil Velikov (2018-08-24 08:57:29) > On Fri, 24 Aug 2018 at 15:16, Dylan Baker wrote: > > > > Meson won't put the .gmo files in the layout that python's > > gettext.translation() expects, so we need to handle them differently, > > this switch allows the script

[Mesa-dev] [ANNOUNCE] mesa 18.1.7

2018-08-24 Thread Dylan Baker
Hi List, Mesa 18.1.7 is now available for general consumption. This release has been rather small compared to the last few release, There's just a handful of fixes in total. Meson, radv, anv, gallium winsys, intel, i965, and r600 were the only recipients of fixs this go around. Dylan git tag:

Re: [Mesa-dev] [PATCH 2/3] configure: allow building with python3

2018-08-24 Thread Dylan Baker
Can we just change the script to write a file instead of sending it's output through the shell? That should fix any encoding problems since the shell wont touch it and the LANG settings (no matter what they are) shouldn't matter. Dylan Quoting Mathieu Bridon (2018-08-24 07:58:21) > Hi, > > On

Re: [Mesa-dev] [PATCH 2/2] meson: Enable readeon vulkan driver on arm, aarch64

2018-08-26 Thread Dylan Baker
Quoting Guido Günther (2018-08-24 05:22:06) > This is similar to what the Debian package does so it looks like a sane > default. > > Signed-off-by: Guido Günther > --- > meson.build | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/meson.build b/meson.build > index

Re: [Mesa-dev] [PATCH 1/5] meson: Actually load translation files

2018-08-28 Thread Dylan Baker
Quoting Eric Engestrom (2018-08-28 07:34:26) > On Friday, 2018-08-24 07:13:41 -0700, Dylan Baker wrote: > > Currently we run the script but don't actually load any files, even in a > > tarball where they exist. > > > > Fixes: 3218056e0eb375eeda470058d06add1532acd6d4 >

Re: [Mesa-dev] [Mesa-stable] [PATCH] intel: decoder: unify MI_BB_START field naming

2018-08-28 Thread Dylan Baker
Quoting Lionel Landwerlin (2018-08-28 02:39:58) > Yes, I think so. You asked on another commit too, both are related and > this depends on other commits from Jason. > > Here is a list in order of cherry picking : > > commit f430a37fa75f534c3a114b0ec546fa14f05f5da1 > Author: Lionel Landwerlin >

Re: [Mesa-dev] [PATCH mesa] meson: consolidate langs lists

2018-08-28 Thread Dylan Baker
, 'nl.po', 'sv.po', 'fr.po'), > + depend_files : _langs_po_files, > ) > -- > Cheers, > Eric > Reviewed-by: Dylan Baker signature.asc Description: signature ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 1/3] python: difflib prefers unicode strings

2018-08-17 Thread Dylan Baker
for the series: Reviewed-by: Dylan Baker Quoting Mathieu Bridon (2018-08-17 12:32:16) > Python 3 does not automatically convert from bytes to unicode strings > like Python 2 used to do. > > This commit makes sure we pass unicode strings to difflib.unified_diff, > so that t

Re: [Mesa-dev] [PATCH 3/3] meson: Run the test with Python 3

2018-08-17 Thread Dylan Baker
Quoting Mathieu Bridon (2018-08-17 12:32:18) > --- > src/compiler/glsl/glcpp/meson.build | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/src/compiler/glsl/glcpp/meson.build > b/src/compiler/glsl/glcpp/meson.build > index 09d44ddd687..769406f5331 100644 > ---

Re: [Mesa-dev] [PATCH v4 12/49] meson: don't build glx or dri by default on windows

2018-08-27 Thread Dylan Baker
Quoting Dylan Baker (2018-08-23 10:27:17) > Quoting Eric Engestrom (2018-08-23 10:13:17) > > On Wednesday, 2018-08-22 10:04:35 -0700, Dylan Baker wrote: > > > Signed-off-by: Dylan Baker > > > Reviewed-by: Eric Anholt > > > --- > > > meson.build | 8

Re: [Mesa-dev] [PATCH 1/2] meson: Be a bit more helpful when arch or OS is unknown

2018-08-27 Thread Dylan Baker
Quoting Guido Günther (2018-08-27 09:32:54) > Hi, > On Mon, Aug 27, 2018 at 09:23:44AM -0700, Dylan Baker wrote: > > Quoting Guido Günther (2018-08-26 13:23:59) > > > V2: Add one missing @0@ > > > > > > Signed-off-by: Guido Günther > > > --- > &

Re: [Mesa-dev] [PATCH] amd/addrlib: Fix include path for c99_compat.h

2018-08-22 Thread Dylan Baker
mark returnCode as MAYBE_UNUSED in) > and you can have my > Acked-by: Kai Wasserbäch > > No R-b from me, because I have never used meson to build Mesa and don't plan > to > do so before Debian's packaging switches to it. > > Cheers, > Kai I've added the relevant Fix

Re: [Mesa-dev] [PATCH v3 1/2] compiler/glsl/tests: Make tests python3 safe

2018-08-22 Thread Dylan Baker
Thanks! I was going to push these today if someone didn't give me an r-b, but I wanted to give people proper time. Dylan Quoting Mathieu Bridon (2018-08-22 07:35:39) > I just learned I was supposed to send this :) > > Reviewed-by: Mathieu Bridon > > On Fri, 2018-08-17 at 11:

[Mesa-dev] [PATCH v4 43/49] tests/vma: fix build with MSVC

2018-08-22 Thread Dylan Baker
--- src/util/tests/vma/vma_random_test.cpp | 8 1 file changed, 8 insertions(+) diff --git a/src/util/tests/vma/vma_random_test.cpp b/src/util/tests/vma/vma_random_test.cpp index 1f194fcdf92..9246176cbf2 100644 --- a/src/util/tests/vma/vma_random_test.cpp +++

[Mesa-dev] [PATCH v4 18/49] meson: build gallium gdi winsys

2018-08-22 Thread Dylan Baker
Reviewed-by: Eric Anholt --- src/gallium/meson.build | 6 ++ src/gallium/winsys/sw/gdi/meson.build | 27 +++ 2 files changed, 33 insertions(+) create mode 100644 src/gallium/winsys/sw/gdi/meson.build diff --git a/src/gallium/meson.build

[Mesa-dev] [PATCH v4 11/49] meson: Add a platform for windows

2018-08-22 Thread Dylan Baker
This mirrors the haiku build which uses a platform. v2: - Fix some rebase problems Signed-off-by: Dylan Baker Reviewed-by: Eric Anholt --- meson.build | 8 ++-- meson_options.txt | 1 + 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/meson.build b/meson.build index

[Mesa-dev] [PATCH v4 30/49] meson: for incluse of inttypes.h for glcpp with msvc

2018-08-22 Thread Dylan Baker
Because we provide a copy if MSVC doesn't, and we need it to make flex do what we want. --- src/compiler/glsl/glcpp/meson.build | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/src/compiler/glsl/glcpp/meson.build b/src/compiler/glsl/glcpp/meson.build index

[Mesa-dev] [PATCH v4 06/49] meson: add a expat subproject

2018-08-22 Thread Dylan Baker
For Windows Signed-off-by: Dylan Baker Reviewed-by: Eric Anholt --- meson.build| 2 +- subprojects/expat.wrap | 10 ++ 2 files changed, 11 insertions(+), 1 deletion(-) create mode 100644 subprojects/expat.wrap diff --git a/meson.build b/meson.build index d75762295ac

[Mesa-dev] [PATCH v4 05/49] meson: add a zlib subproject

2018-08-22 Thread Dylan Baker
To help windows build Signed-off-by: Dylan Baker Reviewed-by: Eric Anholt --- meson.build | 2 +- subprojects/zlib.wrap | 10 ++ 2 files changed, 11 insertions(+), 1 deletion(-) create mode 100644 subprojects/zlib.wrap diff --git a/meson.build b/meson.build index

[Mesa-dev] [PATCH v4 07/49] glapi: export glapi_destroy_multithread when building shared-glapi on windows

2018-08-22 Thread Dylan Baker
Which will allow meson to build a shared glapi build with mingw. Signed-off-by: Dylan Baker Reviewed-by: Eric Anholt --- src/mapi/glapi/glapi.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mapi/glapi/glapi.h b/src/mapi/glapi/glapi.h index d5d4e0a03a6..cbdef2e4c5a

[Mesa-dev] [PATCH v4 49/49] appveyor: cache pip packages

2018-08-22 Thread Dylan Baker
--- appveyor.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/appveyor.yml b/appveyor.yml index 2c45f534ec3..2cb520b9604 100644 --- a/appveyor.yml +++ b/appveyor.yml @@ -36,6 +36,7 @@ clone_depth: 100 cache: - llvm-5.0.1-msvc2015-mtd.7z - subprojects\packagecache +-

[Mesa-dev] [PATCH v4 32/49] meson: add switches for SWR with MSVC

2018-08-22 Thread Dylan Baker
--- src/gallium/drivers/swr/meson.build | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/swr/meson.build b/src/gallium/drivers/swr/meson.build index b95c8bc1bf8..ec4d80e4bb2 100644 --- a/src/gallium/drivers/swr/meson.build +++

[Mesa-dev] [PATCH v4 22/49] meson: fix gallium-osmesa to build for windows

2018-08-22 Thread Dylan Baker
v2: - set so_version to '' (only affects windows) - always set lib prefix to 'lib', even on msvc --- src/gallium/state_trackers/osmesa/meson.build | 12 ++-- src/gallium/targets/osmesa/meson.build| 11 ++- 2 files changed, 20 insertions(+), 3 deletions(-) diff --git

[Mesa-dev] [PATCH v4 44/49] meson: maintain names of shared API libraries

2018-08-22 Thread Dylan Baker
Mesa uses the lib prefix, and doesn't use a version for it's dynamic libraries, which meson defaults to. v2: - this patch --- src/mapi/es1api/meson.build | 2 ++ src/mapi/es2api/meson.build | 2 ++ src/mapi/shared-glapi/meson.build | 2 ++ 3 files changed, 6 insertions(+) diff --git

[Mesa-dev] [PATCH v4 01/49] move u_math to src/util

2018-08-22 Thread Dylan Baker
Currently we have two sets of functions for bit counts, one in gallium and one in core mesa. The ones in core mesa are header only in many cases, since they reduce to "#define _mesa_bitcount popcount", but they provide a fallback implementation. This is important because 32bit msvc doesn't have

[Mesa-dev] [PATCH v4 14/49] meson: add windows compiler checks and libraries

2018-08-22 Thread Dylan Baker
v4: - Fix typo in warning code (4246 -> 4267) - Copy comments from scons for what MSVC warnings codes do - Merge linker argument changes into this commit --- meson.build | 155 +++- 1 file changed, 106 insertions(+), 49 deletions(-) diff

[Mesa-dev] [PATCH v4 48/49] appveyor: Add a wrap for llvm

2018-08-22 Thread Dylan Baker
The appveyor build has a copy of llvm 5.0.1 that scons uses, meson can also use this to build llvm pipe (though not swr, which requires 6.0.0) as well. This requires a plain buildtype, since we need to compile single threaded to link with the provided LLVM, as well as a 32 bit build for the same

[Mesa-dev] [PATCH v4 21/49] meson: build graw-gdi target

2018-08-22 Thread Dylan Baker
--- src/gallium/meson.build | 4 ++- src/gallium/targets/graw-gdi/meson.build | 36 2 files changed, 39 insertions(+), 1 deletion(-) create mode 100644 src/gallium/targets/graw-gdi/meson.build diff --git a/src/gallium/meson.build

[Mesa-dev] [PATCH v4 09/49] meson: fix dl detection on non cygwin windows

2018-08-22 Thread Dylan Baker
v4: - Don't run checks on Windows that will always fail Signed-off-by: Dylan Baker Reviewed-by: Eric Anholt (v3) Reviewed-by: Eric Engestrom --- meson.build | 17 + 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/meson.build b/meson.build index 9298c5ecce6

[Mesa-dev] [PATCH v4 12/49] meson: don't build glx or dri by default on windows

2018-08-22 Thread Dylan Baker
Signed-off-by: Dylan Baker Reviewed-by: Eric Anholt --- meson.build | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/meson.build b/meson.build index 1af610573d5..5102ffe0c7c 100644 --- a/meson.build +++ b/meson.build @@ -264,8 +264,12 @@ if with_glx == 'auto' elif

[Mesa-dev] [PATCH v4 08/49] glsl: fix general_ir_test with mingw

2018-08-22 Thread Dylan Baker
Somewhere down in the depths of the mingw headers 'interface' is defined, change it to iface like a similar patch did. Signed-off-by: Dylan Baker Reviewed-by: Eric Anholt --- src/compiler/glsl/tests/general_ir_test.cpp | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff

[Mesa-dev] [PATCH v4 37/49] glsl/tests: define ssize_t on windows

2018-08-22 Thread Dylan Baker
--- src/compiler/glsl/tests/blob_test.c | 4 1 file changed, 4 insertions(+) diff --git a/src/compiler/glsl/tests/blob_test.c b/src/compiler/glsl/tests/blob_test.c index 1cc97236e7e..21b8b1efdc1 100644 --- a/src/compiler/glsl/tests/blob_test.c +++ b/src/compiler/glsl/tests/blob_test.c @@

[Mesa-dev] [PATCH v4 46/49] appveyor: use chocolatey (cinst) to install winflexbison

2018-08-22 Thread Dylan Baker
v2: - fix typos in commit message --- appveyor.yml | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/appveyor.yml b/appveyor.yml index 15a31da9411..b26a3c624e8 100644 --- a/appveyor.yml +++ b/appveyor.yml @@ -34,7 +34,6 @@ branches: clone_depth: 100 cache: --

[Mesa-dev] [PATCH v4 35/49] util/tests: Use define instead of VLA

2018-08-22 Thread Dylan Baker
To allow the this test to be built with MSVC, which doesn't support VLAs. --- src/util/tests/hash_table/clear.c | 13 +++-- src/util/tests/hash_table/delete_management.c | 13 +++-- src/util/tests/hash_table/insert_many.c | 11 ++-

[Mesa-dev] [PATCH v4 41/49] meson: disable graw tests on mingw

2018-08-22 Thread Dylan Baker
I can't figure out why symbols are being exposed that shouldn't. --- src/gallium/tests/meson.build | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/gallium/tests/meson.build b/src/gallium/tests/meson.build index 15b9f549647..1d08da2ac10 100644 ---

[Mesa-dev] [PATCH v4 10/49] meson: build getopt when using msvc

2018-08-22 Thread Dylan Baker
v4: - Don't wrap a single file in a list to match mesa style - Use null_dep instead of empty list Signed-off-by: Dylan Baker Reviewed-by: Eric Anholt (v3) Reviewed-by: Eric Engestrom --- src/getopt/meson.build | 29 + src/meson.build| 5 + 2 files

[Mesa-dev] [PATCH v4 45/49] appveyor: Add support for meson as well as scons

2018-08-22 Thread Dylan Baker
v4: - Rebase on python3 generators - Cache meson wraps - Build x86 instead of x86_64, since that's what the pre-build LLVM is --- appveyor.yml | 36 1 file changed, 24 insertions(+), 12 deletions(-) diff --git a/appveyor.yml b/appveyor.yml index

[Mesa-dev] [PATCH v4 40/49] meson: Fix gtest linkage on msvc

2018-08-22 Thread Dylan Baker
We need to add an extra flag (/SUBSYSTEM:CONSOLE) to get the msvc linker to find main() in a static library. --- src/gtest/meson.build | 7 +++ 1 file changed, 7 insertions(+) diff --git a/src/gtest/meson.build b/src/gtest/meson.build index 91a49240416..ed0d6974bd3 100644 ---

[Mesa-dev] mesa 18.1.7 Notice

2018-08-22 Thread Dylan Baker
Hi everyone, Just a friendly reminder that the plan is to have the mesa 18.1.7 release this Friday (the 24th) at or around 10am PDT. The patches currently in the staging/18.1 branch represent what will be in the release, barring any critical nominations between then and now. Dylan

[Mesa-dev] [PATCH v4 00/49] Meson for Windows

2018-08-22 Thread Dylan Baker
are here for this exact set of patches: https://ci.appveyor.com/project/dcbaker/mesa/build/87 Dylan Baker (49): move u_math to src/util Replace uses of _mesa_bitcount with util_bitcount meson: always define libglapi add a git ignore for subprojects meson: add a zlib subproject meson: add

[Mesa-dev] [PATCH v4 03/49] meson: always define libglapi

2018-08-22 Thread Dylan Baker
This allows the identifier to be used even if shared-glapi isn't build, which simplifies a bunch of things. Signed-off-by: Dylan Baker Reviewed-by: Eric Anholt --- src/mapi/meson.build | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/mapi/meson.build b/src/mapi/meson.build index

[Mesa-dev] [PATCH v4 02/49] Replace uses of _mesa_bitcount with util_bitcount

2018-08-22 Thread Dylan Baker
and _mesa_bitcount_64 with util_bitcount_64. This fixes a build problem in nir for platforms that don't have popcount or popcountll, such as 32bit msvc. v4: - add this patch --- src/compiler/glsl/ir_constant_expression.cpp | 2 +- src/compiler/glsl/ir_expression_operation.py | 2 +-

[Mesa-dev] [PATCH v4 20/49] meson: build libgl-gdi target

2018-08-22 Thread Dylan Baker
v4: - Fix check for broken mingw (should be for x86 not x86_64) - Add comment about why check is needed --- src/gallium/meson.build | 1 + src/gallium/targets/libgl-gdi/meson.build | 46 +++ 2 files changed, 47 insertions(+) create mode 100644

[Mesa-dev] [PATCH v4 19/49] meson: build wgl state tracker

2018-08-22 Thread Dylan Baker
v4: - Handle enable gles properly - Add comments about what various #defines do Reviewed-by: Eric Anholt --- src/gallium/meson.build| 3 ++ src/gallium/state_trackers/wgl/meson.build | 57 ++ 2 files changed, 60 insertions(+) create mode 100644

[Mesa-dev] [PATCH v4 24/49] meson: Add support for wrapping llvm

2018-08-22 Thread Dylan Baker
For building on Windows (when not using cygwin), the assumption is that LLVM will have to be handled via a binary wrap. In this case the user wanting to use LLVM is this way will need to create a directory in subprojects (any name is fine), and pass that name via the -Dllvm-wrap option (for

[Mesa-dev] [PATCH v4 16/49] meson: Add windows defines to glapi

2018-08-22 Thread Dylan Baker
These are needed to control the export or symbols due to differences between the way windows and *nix handle symbol exports. Reviewed-by: Eric Anholt --- src/mapi/es1api/meson.build | 10 +- src/mapi/es2api/meson.build | 10 +- src/mapi/glapi/meson.build| 13

[Mesa-dev] [PATCH v4 13/49] meson: don't allow glvnd on windows

2018-08-22 Thread Dylan Baker
Signed-off-by: Dylan Baker Reviewed-by: Eric Anholt --- meson.build | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/meson.build b/meson.build index 5102ffe0c7c..32a731e2024 100644 --- a/meson.build +++ b/meson.build @@ -356,7 +356,9 @@ endif with_glvnd = get_option

[Mesa-dev] [PATCH v4 39/49] meson: don't build gallium trivial tests on windows

2018-08-22 Thread Dylan Baker
They require the pipe-loaders, which require xmlconfig, which doesn't build with msvc. --- src/gallium/tests/meson.build | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/gallium/tests/meson.build b/src/gallium/tests/meson.build index 0ee04350c87..15b9f549647 100644 ---

[Mesa-dev] [PATCH v4 34/49] meson: Add idep_getopt for tests

2018-08-22 Thread Dylan Baker
There are quite a few tests that require getopt, when using MSVC we need to use the bundled version of getopt since there isn't a system version. --- src/compiler/glsl/glcpp/meson.build | 2 +- src/compiler/glsl/meson.build | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff

[Mesa-dev] [PATCH v4 23/49] meson: Don't check for posix_memalign on windows

2018-08-22 Thread Dylan Baker
There's a mingw bug for this, it exports __builtin_posix_memalign but not posix_memalign, so the check will succeed, but compiling will fail. --- meson.build | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/meson.build b/meson.build index 0f37117e3fc..c89b805e71f

[Mesa-dev] [PATCH v4 26/49] meson: fix pipe-loader compilation for windows

2018-08-22 Thread Dylan Baker
v2: - Add missing D to pound define - Simply define the variable rather than set it to 1 (mirrors android.mk not scons) --- src/gallium/auxiliary/pipe-loader/meson.build | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git

[Mesa-dev] [PATCH v4 15/49] meson: Make shader-cache a trillean instead of boolean

2018-08-22 Thread Dylan Baker
So that it can be implicitly disabled on windows, where it doesn't compile. v2: - Use an auto-option rather than automagic. - fix shader_cache check (== -> !=) v4: - Use new with_shader_cache instead of get_option('shader-cache') elsewhere in the meson build --- meson.build | 18

[Mesa-dev] [PATCH v4 04/49] add a git ignore for subprojects

2018-08-22 Thread Dylan Baker
Signed-off-by: Dylan Baker Reviewed-by: Eric Anholt --- subprojects/.gitignore | 3 +++ 1 file changed, 3 insertions(+) create mode 100644 subprojects/.gitignore diff --git a/subprojects/.gitignore b/subprojects/.gitignore new file mode 100644 index 000..68a882edba6 --- /dev/null

[Mesa-dev] [PATCH v4 25/49] util/xmlconfig: include strndup.h for windows

2018-08-22 Thread Dylan Baker
--- src/util/xmlconfig.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/util/xmlconfig.c b/src/util/xmlconfig.c index 5264f2598b4..51cc5f3dd87 100644 --- a/src/util/xmlconfig.c +++ b/src/util/xmlconfig.c @@ -39,6 +39,7 @@ #include #include #include +#include "strndup.h" #include

[Mesa-dev] [PATCH v4 28/49] meson: Add support for using win_flex and win_bison on windows

2018-08-22 Thread Dylan Baker
--- meson.build | 27 +-- 1 file changed, 25 insertions(+), 2 deletions(-) diff --git a/meson.build b/meson.build index 9de29b832a0..c5baaf60c68 100644 --- a/meson.build +++ b/meson.build @@ -1364,8 +1364,31 @@ endif # pthread stubs. Lets not and say we didn't

<    11   12   13   14   15   16   17   18   19   20   >