Re: [Mesa-dev] [PATCH 2/2] freedreno: a2xx: fix crash when freeing context

On Tue, Jun 26, 2018, 14:00 Rob Clark wrote: > On Tue, Jun 26, 2018 at 3:32 AM, Erik Faye-Lund > wrote: > > On Wed, Jun 20, 2018 at 3:03 AM Jonathan Marek > wrote: > >> > >> Signed-off-by: Jonathan Marek > >> --- > >> src/gallium/drive

Re: [Mesa-dev] [PATCH] meson: do not search for needless deps

On Thu, Oct 26, 2017 at 11:49 AM, Gert Wollny <gw.foss...@gmail.com> wrote: > > Am Mittwoch, den 25.10.2017, 10:24 +0200 schrieb Erik Faye-Lund: >> If we don't want to use these deps, there's no good reason to search >> for them in the first place. This sh

[Mesa-dev] [PATCH] meson: drop vulkan if no drivers are built

This avoids the following build-error when building with emtpy vulkan-drivers and without glx=dri: Meson encountered an error in file src/vulkan/wsi/meson.build, line 30, column 2: Unknown variable "dep_xcb". Signed-off-by: Erik Faye-Lund <kusmab...@gmail.com> --- src/meson.b

Re: [Mesa-dev] [PATCH] meson: drop vulkan if no drivers are built

Yeah, I kinda got that feeling. Your approach seems better. On Oct 27, 2017 19:22, "Dylan Baker" <dy...@pnwbakers.com> wrote: This just papers over the actual problem, that dep_xcb isn't declared as an empty list with the other glx dependencies. Dylan Quoting Erik Faye-Lund (

Re: [Mesa-dev] [PATCH] meson: declare an empty xcb dependency

On Fri, Oct 27, 2017 at 7:25 PM, Dylan Baker <dy...@pnwbakers.com> wrote: > This is needed in cases where xcb isn't actually needed as a dependency, > but may still be included somewhere. > > cc: Erik Faye-Lund <kusmab...@gmail.com> > cc: Eric Engestrom <eric.enge

Re: [Mesa-dev] [PATCH 3/9] glsl/lower_64bit: extract non-64bit sources from vectors.

On Feb 1, 2018 04:35, "Dave Airlie" wrote: From: Dave Airlie In order to deal with conversions properly we need to extract non-64bit sources from vectors instead of expanding them as the 64-bit code does. We need non-64bit sources for the 32->64

Re: [Mesa-dev] [PATCH 5/5] tegra: Initial support

On Thu, Feb 22, 2018 at 2:23 PM, Thierry Reding wrote: > On Wed, Feb 21, 2018 at 05:01:02PM +, Emil Velikov wrote: >> Hi Thierry, >> >> On 21 February 2018 at 15:30, Thierry Reding >> wrote: >> > +static const char * >> >

Re: [Mesa-dev] [PATCH] meson: use correct keyword to fix a meson warning

On 02. aug. 2018 15:58, Jon Turney wrote: With a sufficently recent meson, the following warning is produced: WARNING: Passed invalid keyword argument "extra_args". WARNING: This will become a hard error in the future. It seems that compiler.links(args:) is meant here. Signed-off-by: Jon

[Mesa-dev] [PATCH v2 1/2] virgl: rename msaa_sample_positions -> sample_locations

This matches what this field is called in virglrenderer's copy of this. While we're at it, fixup the indentation. This reduces the diff between the two different versions of virgl_hw.h, and should make it easier to upgrade the file in the future. --- src/gallium/drivers/virgl/virgl_context.c |

[Mesa-dev] [PATCH v2 0/2] virgl: synchronize virgl_hw.h with virglrenderer

on master - Dropped "virgl: move bind-flags to virgl_winsys.h" as discussed in review. - Updated "virgl: update virgl_hw.h from virglrenderer" to the latest master from virglrenderer. Erik Faye-Lund (2): virgl: rename msaa_sample_positions -> sample_locations virgl:

[Mesa-dev] [PATCH v2 2/2] virgl: update virgl_hw.h from virglrenderer

This just makes sure we're currently up-to-date with what virglrenderer has. --- src/gallium/drivers/virgl/virgl_hw.h | 27 ++- 1 file changed, 26 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/virgl/virgl_hw.h b/src/gallium/drivers/virgl/virgl_hw.h index

Re: [Mesa-dev] [PATCH v2 0/2] virgl: synchronize virgl_hw.h with virglrenderer

Ping? On 27. juli 2018 09:18, Erik Faye-Lund wrote: Here's a few patches to get the delta between our copy of virgl_hw.h and the copy in the virglrenderer repository as small as possible. The goal is to make it easier to track this file in the future by simply copying the new version

Re: [Mesa-dev] [PATCH] virgl: add ARB_shader_clock support

Reviewed-by: Erik Faye-Lund On 06. aug. 2018 22:23, Dave Airlie wrote: From: Dave Airlie --- src/gallium/drivers/virgl/virgl_hw.h | 1 + src/gallium/drivers/virgl/virgl_screen.c | 3 ++- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/virgl

[Mesa-dev] [PATCH v2] i965: do not emit empty surface state

If called with an empty size, brw_emit_buffer_surface_state asserts. We already have a dedicated helper for uploading nothing, so let's use that instead. Signed-off-by: Erik Faye-Lund --- Here's an updated patch. v2: call emit_null_surface_state to ensure out_offset is initialized properly

Re: [Mesa-dev] [PATCH 1/2] virgl: do not use SP_MAX_TEXTURE_*_LEVELS defines

, 2018, 11:57 AM Erik Faye-Lund wrote: What are you referring to, exactly? In OpenGL, texture size-limits are per axis, not in total... On Tue, Aug 14, 2018 at 5:43 PM, Marek Olšák wrote: You could have a 3d or cube texture where 1 or 2 dimensions are 16k. Marek On Tue, Aug 14, 2018, 9:02

[Mesa-dev] [PATCH] mesa/st/glsl_to_tgsi: fixup copy-paste mistake

rrays whose elements are only accessed directly") Signed-off-by: Erik Faye-Lund --- src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/state_tracker/st_glsl_to_tgsi.cpp b/src/mesa/state_tracker/st_glsl_to_tgsi.cpp index

Re: [Mesa-dev] [PATCH] virgl: bump 3D texture limit to 2048, as GL4.1 requires

On Tue, Aug 14, 2018 at 5:47 AM, Gurchetan Singh wrote: This is virgl analogue to cf6dad. Fixes: dEQP-GLES31.functional.image_load_store.3d.atomic.* Example test cases: dEQP-GLES31.functional.image_load_store.3d.atomic.add_r32ui_return_value

Re: [Mesa-dev] [PATCH v2] i965: do not emit empty surface state

Lionel Landwerlin wrote: Hey Erik, Out of curiosity, what app/test managed to run into this assert? We could have some test added :) Thanks, - Lionel On 08/08/18 09:34, Lionel Landwerlin wrote: On 07/08/18 20:31, Erik Faye-Lund wrote: If called with an empty size, brw_emit_buffer_surface_state asser

[Mesa-dev] [PATCH] i965: do not emit empty sampler state

If called with an empty size, brw_emit_buffer_surface_state asserts. And since doing a zero-size upload is really just a lot of work for no gain, let's just avoid the call in the first place. Signed-off-by: Erik Faye-Lund --- This fixes an assert that triggers for me when running dEQP-GLES31

Re: [Mesa-dev] [PATCH] i965: do not emit empty sampler state

On 06. aug. 2018 16:15, Lionel Landwerlin wrote: Hey Erik, I don't think this is right, because by not filling out_offset, you're leaving it at 0 which makes the entry in the binding table point to a dynamic state base address. I would emit the null surface instead. Hmm, good point. I'll

[Mesa-dev] [PATCH 1/2] virgl: do not use SP_MAX_TEXTURE_*_LEVELS defines

max-size by doing by 2^(n-1), which means this should be 256 cubed, not 512 cubed. The other comments are correct. Signed-off-by: Erik Faye-Lund --- src/gallium/drivers/virgl/virgl_screen.c | 10 +++--- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/src/gallium/drivers/virgl

[Mesa-dev] [PATCH 2/2] virgl: report actual max-texture sizes

Instead of doing conservative guesses, we should report the max levels based on the max sizes we get from GL on the host. Signed-off-by: Erik Faye-Lund --- src/gallium/drivers/virgl/virgl_hw.h | 3 +++ src/gallium/drivers/virgl/virgl_screen.c | 7 +++ 2 files changed, 10 insertions

Re: [Mesa-dev] [PATCH 2/2] virgl: report actual max-texture sizes

I forgot to mention, this patch depends on a virglrenderer MR that hasn't been merged yet. So it shouldn't be merged before the MR has landed. https://gitlab.freedesktop.org/virgl/virglrenderer/merge_requests/25 On Tue, Aug 14, 2018 at 3:02 PM, Erik Faye-Lund wrote: Instead of doing

Re: [Mesa-dev] [PATCH 1/2] virgl: do not use SP_MAX_TEXTURE_*_LEVELS defines

What are you referring to, exactly? In OpenGL, texture size-limits are per axis, not in total... On Tue, Aug 14, 2018 at 5:43 PM, Marek Olšák wrote: You could have a 3d or cube texture where 1 or 2 dimensions are 16k. Marek On Tue, Aug 14, 2018, 9:02 AM Erik Faye-Lund wrote: These macro

[Mesa-dev] [PATCH] glsl_to_tgsi: plumb image writable through to driver

. Signed-off-by: Erik Faye-Lund --- This patch is needed for this patch-series in virglrenderer to work properly: https://patchwork.freedesktop.org/series/47775/ src/mesa/state_tracker/st_glsl_to_tgsi.cpp| 19 ++- .../state_tracker/st_glsl_to_tgsi_private.h | 1 + 2 files

Re: [Mesa-dev] [PATCH] virgl: don't send a shader create with no data.

, hdr_len); ...instead. Otherwise we'll get spewing on stderr, which has been known to cause issues for some test-suite runners. With that fixed: Reviewed-by: Erik Faye-Lund ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 3/4] virgl: introduce $VIRGL_DEBUG=verbose

Sorry, made a mistake when sending this series out. I'll resend properly soon. On Mon, Aug 20, 2018 at 2:03 PM, Erik Faye-Lund wrote: This adds an environment-varaible that can be used for driver-specific flags, as well as a flag for it to enable verbose output. While we're at it, quiet

[Mesa-dev] [PATCH 2/4] virgl: replace fprintf-call with debug_printf

This is the only direct call-site for fprintf in virgl; all other call-sites call debug_printf instead. So let's follow in style here. Signed-off-by: Erik Faye-Lund --- src/gallium/drivers/virgl/virgl_encode.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium

[Mesa-dev] [PATCH 0/4] virgl: debug printing cleanups

. Erik Faye-Lund (4): virgl: delete commented out fprintf-call virgl: replace fprintf-call with debug_printf virgl: introduce $VIRGL_DEBUG=verbose virgl: add debug-switch to output TGSI src/gallium/drivers/virgl/virgl_context.c | 6 -- src/gallium/drivers/virgl/virgl_encode.c | 6

[Mesa-dev] [PATCH 1/4] virgl: delete commented out fprintf-call

This is just debug-cruft left over. Let's just get rid of it. Signed-off-by: Erik Faye-Lund --- src/gallium/drivers/virgl/virgl_encode.h | 1 - 1 file changed, 1 deletion(-) diff --git a/src/gallium/drivers/virgl/virgl_encode.h b/src/gallium/drivers/virgl/virgl_encode.h index 749cd33012

[Mesa-dev] [PATCH 3/4] virgl: introduce $VIRGL_DEBUG=verbose

This adds an environment-varaible that can be used for driver-specific flags, as well as a flag for it to enable verbose output. While we're at it, quiet some overly chatty debug-output by default. Signed-off-by: Erik Faye-Lund --- src/gallium/drivers/virgl/virgl_context.c | 6 -- src

[Mesa-dev] [PATCH 1/4] virgl: delete commented out fprintf-call

This is just debug-cruft left over. Let's just get rid of it. Signed-off-by: Erik Faye-Lund --- src/gallium/drivers/virgl/virgl_encode.h | 1 - 1 file changed, 1 deletion(-) diff --git a/src/gallium/drivers/virgl/virgl_encode.h b/src/gallium/drivers/virgl/virgl_encode.h index 749cd33012

[Mesa-dev] [PATCH 2/4] virgl: replace fprintf-call with debug_printf

This is the only direct call-site for fprintf in virgl; all other call-sites call debug_printf instead. So let's follow in style here. Signed-off-by: Erik Faye-Lund --- src/gallium/drivers/virgl/virgl_encode.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium

[Mesa-dev] [PATCH 4/4] virgl: add debug-switch to output TGSI

This is quite useful for debugging shader-transpiling issues in virglrenderer. Signed-off-by: Erik Faye-Lund --- src/gallium/drivers/virgl/virgl_encode.c | 3 +++ src/gallium/drivers/virgl/virgl_screen.c | 1 + src/gallium/drivers/virgl/virgl_screen.h | 1 + 3 files changed, 5 insertions

[Mesa-dev] [PATCH 3/4] virgl: introduce $VIRGL_DEBUG=verbose

This adds an environment-varaible that can be used for driver-specific flags, as well as a flag for it to enable verbose output. While we're at it, quiet some overly chatty debug-output by default. Signed-off-by: Erik Faye-Lund --- src/gallium/drivers/virgl/virgl_context.c | 6 -- src

Re: [Mesa-dev] [PATCH 4/4] virgl: add debug-switch to output TGSI

On ma., aug. 27, 2018 at 9:49 AM, Gert Wollny wrote: Am Montag, den 20.08.2018, 14:10 +0200 schrieb Erik Faye-Lund: This is quite useful for debugging shader-transpiling issues in virglrenderer. Isn't this coverted by ST_DEBUG=tgsi? Ah, I wasn't even aware of this. There's one minor

[Mesa-dev] [PATCH/RFC] glsl: allow redeclaring variables as 'precise invariant'

of qualifiers here, and it does not include an option with both. So let's factor out the precise/invariant handling from the type_qualifier rule so we can reuse it, as there's some intricate subtleties here. For reference: glslangValidator already allows this. Signed-off-by: Erik Faye-Lund --- My

Re: [Mesa-dev] [PATCH/RFC] glsl: allow redeclaring variables as 'precise invariant'

Ping? On on., aug. 22, 2018 at 7:34 PM, Erik Faye-Lund wrote: There's seems to be nothing in the GLSL (ES) specifications that diallow redeclaring a variable as both 'precise' and 'invariant' in the same statement. But the way the parse-rules are structured this fails to parse, because

[Mesa-dev] [PATCH] virgl: implement set_min_samples

This allows us to implement glMinSampleShading correctly, which up until now just got ignored. Signed-off-by: Erik Faye-Lund --- This implements the mesa-side of VIRGL_CCMD_SET_MIN_SAMPLES, which is already in the master-branch of virglre... src/gallium/drivers/virgl/virgl_context.c | 12

[Mesa-dev] [PATCH 0/3] virgl: synchronize virgl_hw.h with virglrenderer

that currently exists in master (VIRGL_CAP_SET_MIN_SAMPLES), for two reasons: reasons: 1. It wasn't yet in master when I generated this patch-set 2. I'm about to send out a patch-set that adds it (and respects it) separately. Erik Faye-Lund (3): virgl: move bind-flags to virgl_winsys.h virgl

[Mesa-dev] [PATCH 3/3] virgl: update virgl_hw.h from virglrenderer

This just makes sure we're currently up-to-date with what virglrenderer has. Signed-off-by: Erik Faye-Lund --- src/gallium/drivers/virgl/virgl_hw.h | 19 ++- 1 file changed, 18 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/virgl/virgl_hw.h b/src/gallium/drivers

[Mesa-dev] [PATCH 1/3] virgl: move bind-flags to virgl_winsys.h

virglrenderer's virgl_hw.h doesn't contain these, and it's the virgl winsys that cares about these, so let's move them there. This reduces the diff between the two different versions of virgl_hw.h, and should make it easier to upgrade the file in the future. Signed-off-by: Erik Faye-Lund

[Mesa-dev] [PATCH 2/3] virgl: rename msaa_sample_positions -> sample_locations

This matches what this field is called in virglrenderer's copy of this. While we're at it, fixup the indentation. This reduces the diff between the two different versions of virgl_hw.h, and should make it easier to upgrade the file in the future. Signed-off-by: Erik Faye-Lund --- src/gallium

Re: [Mesa-dev] [PATCH] mesa/virgl: Fix off-by-one and copy-paste error in multisample position evaluation

Just a heads-up, this patch conflicts with this one: https://patchwork.freedesktop.org/patch/239169/ Your were sent out first, so I'll be happy to rebase mine when this has landed... On 13. juli 2018 14:46, Gert Wollny wrote: Fixes: 91f48cdfe5c817158c533a8f67c60e9aabbe4479 virgl:

Re: [Mesa-dev] [PATCH] mesa/virgl: Fix off-by-one and copy-paste error in multisample position evaluation

off-by-one... perhaps adjust the commit message a bit? bits = vs->caps.caps.v2.msaa_sample_positions[4 + (index >> 2)] >> (8 * (index & 3)); } out_value[0] = ((bits >> 4) & 0xf) / 16.0f; Reviewed-by: Erik Faye-Lund __

Re: [Mesa-dev] [PATCH] virgl: remove unused stride-arguments

On Jul 23, 2018 22:05, Dave Airlie wrote:On 20 July 2018 at 13:39, Gurchetan Singh wrote: > Reviewed-by: Gurchetan Singh > On Wed, Jul 18, 2018 at 4:06 AM Erik Faye-Lund > wrote: >> >> The IOCTLs doesn't pass this along, so computing them in the first >&g

[Mesa-dev] [PATCH] forward precise-flag if supported

.functional.tessellation.common_edge.triangles_fractional_odd_spacing_precise Signed-off-by: Erik Faye-Lund --- This matches this virglrenderer-series, which has been merged upstrea: https://patchwork.freedesktop.org/series/46361/ src/gallium/drivers/virgl/virgl_hw.h | 1 + src/gallium/drivers/virgl

[Mesa-dev] [PATCH] gles: report maximum vertex-attrib stride to guest

Similar to e387116, we also need to report this for GLES hosts. Signed-off-by: Erik Faye-Lund --- Without this, there's no chance for GLES hosts to get GLES3.1 support. src/vrend_renderer.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/vrend_renderer.c b/src/vrend_renderer.c

Re: [Mesa-dev] [PATCH] gles: report maximum vertex-attrib stride to guest

Sorry, send wrong. Please ignore. On 19. juli 2018 17:58, Erik Faye-Lund wrote: Similar to e387116, we also need to report this for GLES hosts. Signed-off-by: Erik Faye-Lund --- Without this, there's no chance for GLES hosts to get GLES3.1 support. src/vrend_renderer.c | 3 +++ 1 file

Re: [Mesa-dev] [PATCH 1/3] virgl: move bind-flags to virgl_winsys.h

On 16. juli 2018 13:34, Gert Wollny wrote: Am Montag, den 16.07.2018, 12:23 +0200 schrieb Erik Faye-Lund: virglrenderer's virgl_hw.h doesn't contain these, and it's the virgl winsys that cares about these, so let's move them there. This reduces the diff between the two different versions

[Mesa-dev] [PATCH] gallium: initialize ureg_dst::Invariant bit

When this bit was added, it seems the some initialization code was omitted by mistake. Since stack-variables have kinda random contents, and we don't zero initialize the whole struct in these code-paths, we end up getting random-ish values for this bit. Spotted by Coverity in the following CIDs:

[Mesa-dev] [PATCH] virgl: remove unused stride-arguments

The IOCTLs doesn't pass this along, so computing them in the first place is kinda pointless. Signed-off-by: Erik Faye-Lund --- This is just a cleanup I noticed based on some discussion with Gert. A question is, what code here expects this stride to be respected? The call-sites in virgl_

[Mesa-dev] [PATCH 2/4] virgl: drop needless return-code

We always return TRUE, and we never check the return-value. Let's just drop the return value instead. Signed-off-by: Erik Faye-Lund --- src/gallium/drivers/virgl/virgl_texture.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/gallium/drivers/virgl/virgl_texture.c b

[Mesa-dev] [PATCH 0/4] virgil: fix crash when mapping ms-texture

this inconsistency in the very first commit to virgl. Was there some expectation of some third, non-depth handling case here that just didn't get noticed until now? Erik Faye-Lund (4): virgl: free trans on map-error virgl: drop needless return-code virgl: remove dead code virgl: do not map

[Mesa-dev] [PATCH 3/4] virgl: remove dead code

We don't use the size we calculate in this function, so let's just drop the calculation Signed-off-by: Erik Faye-Lund --- src/gallium/drivers/virgl/virgl_texture.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/src/gallium/drivers/virgl/virgl_texture.c b/src/gallium

[Mesa-dev] [PATCH 4/4] virgl: do not map zero-sized resource

(although it still fails): bin/copyteximage 2D -samples=2 -auto Signed-off-by: Erik Faye-Lund --- This is the patch that I'm a bit unsure about. More details in the cover letter. src/gallium/drivers/virgl/virgl_texture.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src

[Mesa-dev] [PATCH 1/4] virgl: free trans on map-error

When we fail to map memory, we should also free trans to avoid leaking memory. Noticed while reading code. Signed-off-by: Erik Faye-Lund --- src/gallium/drivers/virgl/virgl_texture.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/drivers/virgl/virgl_texture.c b/src/gallium

[Mesa-dev] [PATCH] winsys/virgl: avoid unintended behavior

: st_api_create_context (st_manager.c:896) by 0xB981E76: dri_create_context (dri_context.c:155) by 0xB97BDCE: driCreateContextAttribs (dri_util.c:473) by 0x5288331: dri3_create_context_attribs (dri3_glx.c:309) by 0x5264D64: glXCreateContextAttribsARB (create_context.c:78) Signed-off-by: Erik Faye-Lund

Re: [Mesa-dev] [PATCH] winsys/virgl: avoid unintended behavior

On to., sep. 6, 2018 at 3:00 PM, Emil Velikov wrote: Hi Erik, On 6 September 2018 at 11:48, Erik Faye-Lund wrote: If we end up never taking the loop that writes ret, we can end up with an uninitialized value, and if we're *really* unlucky, that value can be -1, causing us to go down

Re: [Mesa-dev] [PATCH] virgl: Add command and flags to initiate debugging on the host

On to., sep. 6, 2018 at 3:25 PM, Emil Velikov wrote: On 5 September 2018 at 16:34, Gert Wollny wrote: + +enum virgl_debug_flags { + debug_shader_tgsi = 1 << 0, + debug_shader_glsl = 1 << 1, + debug_shader_streamout = 1 << 2, + debug_shader = debug_shader_tgsi |

Re: [Mesa-dev] [PATCH] virgl: Add command and flags to initiate debugging on the host

"}, + { "glsl", debug_shader_glsl, "Print GLSL shaders created from TGSI"}, + { "glsl", debug_shader_streamout, "Print GLSL shaders created from TGSI"}, Typo? Shouldn't the string be "streamout", and the description be something

[Mesa-dev] [PATCH 0/3] verify max vertex attrib stride

spec version in virgl and then get dEQP failures when running on old hardware. The virgl specific bits are being sent separately, because they depend on some other not-yet-upstream things ATM. Thoughts? Erik Faye-Lund (3): r600: report incorrect max-vertex-attrib for GL 4.4 mesa: verify

[Mesa-dev] [PATCH 3/3] mesa: verify MaxVertexAttribStride for GLES 3.1

The OpenGL 3.1 specification, table Table 20.41 ("Implementation Dependent Values"), defines the minimum-maximum value for MAX_VERTEX_ATTRIB_STRIDE to be 2048. So we shouldn't enable OpenGL ES 3.1 on implementations where this isn't the case. Let's add a check for this Signed-off-by:

[Mesa-dev] [PATCH 1/3] r600: report incorrect max-vertex-attrib for GL 4.4

applications using 2048 are already broken anyway. Signed-off-by: Erik Faye-Lund --- src/gallium/drivers/r600/r600_pipe.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/r600/r600_pipe.c b/src/gallium/drivers/r600/r600_pipe.c index bc5660d6d1..2518032145 100644

[Mesa-dev] [PATCH 2/3] mesa: verify MaxVertexAttribStride for GL 4.4

The OpenGL 4.4 specification, table Table 23.55 ("Implementation Dependent Values"), defines the minimum-maximum value for MAX_VERTEX_ATTRIB_STRIDE to be 2048. So we shouldn't enable OpenGL 4.4 on implementations where this isn't the case. Let's add a check for this. Signed-off-by:

Re: [Mesa-dev] [RFC PATCH] mesa/st: don't prematurely optimize for render targets when on virgl

On 10. juli 2018 15:42, Gert Wollny wrote: For three component textures virgl faces the problem that the host driver may report that these can not be used as a render target, and when the client requests such a texture a four-componet texture will be choosen even if only a sampler view was

Re: [Mesa-dev] [RFC PATCH] mesa/st: don't prematurely optimize for render targets when on virgl

On 10. juli 2018 16:23, Gert Wollny wrote: Am Dienstag, den 10.07.2018, 16:01 +0200 schrieb Erik Faye-Lund: On 10. juli 2018 15:42, Gert Wollny wrote: For three component textures virgl faces the problem that the host driver may report that these can not be used as a render target, and when

Re: [Mesa-dev] How to apply patches to upstream mesa 9.0.3

On 11. juli 2018 10:22, Thella Shyam Kumar wrote: Hi All, We are using an x86 based platform and we are needing changes in mesa 9.0.3 which is coming with AOSP 7.1.2r36 If we want the changes in mesa in AOSP, our understanding is that these changes should be upstreamed in freedesktop.org

Re: [Mesa-dev] [PATCH v2 25/49] docs/meson.html: fix numerous issues spotted by xmllint

On 11. juli 2018 01:17, Dylan Baker wrote: --- docs/meson.html | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) This is a HTML-document, not an XML document or XHTML. What xmllint thinks should be irrelevant. diff --git a/docs/meson.html b/docs/meson.html index

Re: [Mesa-dev] [PATCH v2 41/49] meosn: don't build gallium trivial tests on windows

Typo in the subject, "meosn" -> "meson". On 11. juli 2018 01:18, Dylan Baker wrote: They require the pipe-loaders, which require xmlconfig, which doesn't build with msvc. --- src/gallium/tests/meson.build | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git

Re: [Mesa-dev] [PATCH 0/3] verify max vertex attrib stride

On 06. juli 2018 18:43, Roland Scheidegger wrote: Am 06.07.2018 um 12:03 schrieb Erik Faye-Lund: OpenGL 4.4 and OpenGL ES 3.1 both require the maximum vertex attrib stride to be at least 2048. If this isn't the case, we shouldn't expose these API versions. Unfortunately, the r600 driver only

Re: [Mesa-dev] [PATCH V2] Check if the window is non-NULL before setting swap interval.

On Thu, Jul 5, 2018 at 7:02 PM Emil Velikov wrote: > > On 5 July 2018 at 17:17, Eric Engestrom wrote: > > On Thursday, 2018-07-05 14:43:02 +0100, Emil Velikov wrote: > >> On 5 July 2018 at 10:53, Eric Engestrom wrote: > >> > On Monday, 2018-07-02 14:12:44 +0530, samiuddi wrote: > >> >> This

[Mesa-dev] [PATCH] virgl: adjust strides when mapping temp-resources

Signed-off-by: Erik Faye-Lund Fixes: a8987b88ff1 "virgl: add driver for virtio-gpu 3D (v2)" --- I noticed this crash while testing this patch: https://patchwork.freedesktop.org/patch/248805/ src/gallium/drivers/virgl/virgl_texture.c | 2 ++ 1 file changed, 2 insertions(+) diff -

Re: [Mesa-dev] [PATCH 00/18] [RFC] Pointer specific data structures

On Wed, Apr 11, 2018 at 8:48 PM, Thomas Helland wrote: > This series came about when I saw a talk online, while simultaneously > being annoyd about the needless waste of memory in our set as reported > by pahole. I have previously made some patches that changed our hash

Re: [Mesa-dev] [PATCH v3] virgl: Add support for glGetMultisample

On Thu, Jun 28, 2018 at 5:54 PM Gert Wollny wrote: > > Am Donnerstag, den 28.06.2018, 17:40 +0200 schrieb Erik Faye-Lund: > > On Thu, Jun 28, 2018 at 5:31 PM Gert Wollny > m> wrote: > > > > > > There are two aspects: > > > > > > For each n

Re: [Mesa-dev] [PATCH v3] virgl: Add support for glGetMultisample

On Thu, Jun 28, 2018 at 7:49 PM Gert Wollny wrote: > > Am Donnerstag, den 28.06.2018, 18:09 +0200 schrieb Erik Faye-Lund: > > It still seems kinda strange (and fragile) to me to try to enumerate > > all possible sample locations up-front instead of querying a given > >

Re: [Mesa-dev] [PATCH 1/2] mesa: MESA_framebuffer_flip_y extension [v2]

On Thu, Jun 28, 2018 at 11:12 PM Fritz Koenig wrote: > > Adds an extension to glFramebufferParameteri > that will specify if the framebuffer is vertically > flipped. Historically system framebuffers are > vertically flipped and user framebuffers are not. > Checking to see the state was done by

[Mesa-dev] [PATCH] gallium/u_vbuf: drop min/max-scanning for empty indirect draws

-GLES31.functional.draw_indirect.random.0 on VirGL for me. Signed-off-by: Erik Faye-Lund --- I noticed this while debugging something else, so I thought I'd send a patch upstream, as the problem doesn't seem unique to my usecase. src/gallium/auxiliary/util/u_vbuf.c | 3 +++ 1 file changed, 3

[Mesa-dev] [PATCH] gallium/u_vbuf: drop min/max-scanning for empty indirect draws

-GLES31.functional.draw_indirect.random.0 on VirGL for me. Signed-off-by: Erik Faye-Lund --- This is a resend of a mail that didn't reach the mailing-list yet. Sorry if it appears twice for someone! src/gallium/auxiliary/util/u_vbuf.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src

Re: [Mesa-dev] [PATCH v3] virgl: Add support for glGetMultisample

On Thu, Jun 28, 2018 at 5:31 PM Gert Wollny wrote: > > Am Donnerstag, den 28.06.2018, 17:09 +0200 schrieb Erik Faye-Lund: > > Unless I'm misunderstanding, this seems to indicate that the hardware > > has a fixed set of sample positions, which I don't think is true for > >

Re: [Mesa-dev] [PATCH v3] virgl: Add support for glGetMultisample

Unless I'm misunderstanding, this seems to indicate that the hardware has a fixed set of sample positions, which I don't think is true for most hardware. Instead, the sample locations is a function of the multisampling mode for a given surface... On Thu, Jun 28, 2018 at 3:45 PM Gert Wollny

Re: [Mesa-dev] [PATCH v4] virgl: Add support for glGetMultisample

On Fri, Jun 29, 2018 at 12:52 PM Erik Faye-Lund wrote: > > On Fri, Jun 29, 2018 at 12:39 PM Gert Wollny > wrote: > > > > Use caps to obtain the multisample sample positions for up to 16 > > positions and implement the according Gallium interface. > > > > T

Re: [Mesa-dev] [PATCH v4] virgl: Add support for glGetMultisample

itions for intermediate sample counts > - fix unused varible warning > - update description > v4: explain better what this patch assumes and how it handles sample numbers > that are not directly advertised (thanks go to Erik Faye-Lund for making > me aware that thi

[Mesa-dev] [PATCH] mesa: allow EXT_texture_compression_s3tc on ES2

The extension is written against both GL 1.2 and GLES 2.0, so let's also enable it on GLES 2.0. Signed-off-by: Erik Faye-Lund --- src/mesa/main/extensions_table.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/main/extensions_table.h b/src/mesa/main

Re: [Mesa-dev] [PATCH] mesa: allow EXT_texture_compression_s3tc on ES2

, it doesn't enable online compression on gles2. And from testing, it seems like mesa does the right thing. I'll double check, though...   -ilia On Thu, Oct 18, 2018 at 11:05 AM Erik Faye-Lund wrote: > > The extension is written against both GL 1.2 and GLES 2.0, so let's > also enable it on

Re: [Mesa-dev] [PATCH] mesa: allow EXT_texture_compression_s3tc on ES2

On Thu, 2018-10-18 at 14:31 -0400, Ilia Mirkin wrote: > On Thu, Oct 18, 2018 at 2:26 PM Erik Faye-Lund > wrote: > > On Oct 18, 2018 18:21, Ilia Mirkin wrote: > > > > Have you verified that this works OK on GLES2? This extension > > enables > > online compres

Re: [Mesa-dev] [PATCH] mesa: allow EXT_texture_compression_s3tc on ES2

commit/?h=amd-extension-pack=c9c0ffc2d40f0119fb31bf0515f321cd877090dd > bptc: > https://cgit.freedesktop.org/~mareko/mesa/commit/?h=amd-extension-pack=111255b6f8b85119da2c5d29dc19abc422fd7a12 > > and no time to test them. > > Marek > > On Thu, Oct 18, 2018 at 11:05 AM Erik Faye-Lund < &

Re: [Mesa-dev] [PATCH 3/5] glsl: fall back to inexact function-match

On Wed, 2018-10-31 at 15:46 +0200, Tapani Pälli wrote: > > On 10/30/18 7:11 PM, Erik Faye-Lund wrote: > > In GLES, we currently either need an exact match with a local > > function, > > or an exact match with a builtin. > > > > However, if we add suppo

Re: [Mesa-dev] [PATCH 3/5] glsl: fall back to inexact function-match

thought I mentioneded this in the commit message, but perhaps you want that to be more explicit than the "In GLES, "-introduction? How about I simply add something like "This fallback should only affect GLES." at the end of the commit message? > On Wed, Oct 31, 2018 at

Re: [Mesa-dev] [PATCH 3/5] glsl: fall back to inexact function-match

On Thu, 2018-11-01 at 07:49 +0200, Tapani Pälli wrote: > > On 10/31/18 7:03 PM, Ilia Mirkin wrote: > > On Wed, Oct 31, 2018 at 12:37 PM Erik Faye-Lund > > wrote: > > > > > > On Wed, 2018-10-31 at 12:01 -0400, Ilia Mirkin wrote: > > > > I had to do

Re: [Mesa-dev] [PATCH] mesa: expose EXT_texture_compression_s3tc on GLES

On Tue, 2018-10-30 at 08:20 -0400, Ilia Mirkin wrote: > On Tue, Oct 30, 2018 at 7:59 AM Erik Faye-Lund > wrote: > > > > On Tue, 2018-10-30 at 07:44 -0400, Ilia Mirkin wrote: > > > On Thu, Oct 25, 2018 at 6:59 AM Erik Faye-Lund > > > wrote

Re: [Mesa-dev] [PATCH] mesa: expose EXT_texture_compression_s3tc on GLES

On Tue, 2018-10-30 at 07:44 -0400, Ilia Mirkin wrote: > On Thu, Oct 25, 2018 at 6:59 AM Erik Faye-Lund > wrote: > > > > From: Marek Olšák > > > > The spec was modified to support GLES. > > > > Tested-by: Erik Faye-Lund >

[Mesa-dev] [PATCH 2/5] glsl: add has_implicit_uint_to_int_conversion()-helper

This makes the code a bit easier to read, as well as reduces repetition, especially when we add support for EXT_shader_implicit_conversions. Signed-off-by: Erik Faye-Lund --- src/compiler/glsl/ast_to_hir.cpp | 3 +-- src/compiler/glsl/glsl_parser_extras.h | 7 +++ src/compiler

[Mesa-dev] [PATCH 3/5] glsl: fall back to inexact function-match

have a variable ready with this, so let's just return it if the builtin-search failed. Signed-off-by: Erik Faye-Lund --- src/compiler/glsl/ast_function.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/compiler/glsl/ast_function.cpp b/src/compiler/glsl/ast_function.cpp

[Mesa-dev] [PATCH 4/5] mesa/glsl: add support for EXT_shader_implicit_conversions

EXT_shader_implicit_conversions adds support for implicit conversions for GLES 3.1 and above. This is essentially a subset of ARB_gpu_shader5, and augments OES_gpu_shader5. Signed-off-by: Erik Faye-Lund --- src/compiler/glsl/glsl_parser_extras.cpp | 1 + src/compiler/glsl/glsl_parser_extras.h

[Mesa-dev] [PATCH 5/5] glsl: do not allow implicit casts of unsized array initializers

uint_to_float_vertex - dEQP-GLES31.functional.shaders.implicit_conversions.es32.invalid.arrays.uint_to_float_fragment Signed-off-by: Erik Faye-Lund --- src/compiler/glsl/ast_to_hir.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/compiler/glsl/ast_to_hir.cpp

[Mesa-dev] [PATCH 1/5] glsl: add has_implicit_conversions()-helper

This makes the code a bit easier to read, as well as will reduce repetition when we add support for EXT_shader_implicit_conversions. Signed-off-by: Erik Faye-Lund --- src/compiler/glsl/ast_to_hir.cpp | 2 +- src/compiler/glsl/glsl_parser_extras.h | 5 + src/compiler/glsl_types.cpp

[Mesa-dev] [PATCH 0/5] add support for EXT_shader_implicit_conversions

enabling this, one bug was discorvered due to a failing dEQP test (see the last patch). This makes 2068 dEQP-GLE31 tests go from NotSupported to Pass on i965. No piglit regressions observed. Erik Faye-Lund (5): glsl: add has_implicit_conversions()-helper glsl: add

Re: [Mesa-dev] [PATCH] egl_dri2: check if driver_name is NULL before releasing it

On Tue, 2018-10-30 at 18:28 +0800, Zhaowei YUan wrote: > I don't think it's fine, usually, freeing an NULL pointer will cause > unexpected errors. It's better to check this for the robustness. > From http://pubs.opengroup.org/onlinepubs/009695399/functions/free.html : "If ptr is a null

Re: [Mesa-dev] [PATCH] mesa: expose EXT_texture_compression_s3tc on GLES

On Fri, 2018-10-26 at 13:14 +0200, Erik Faye-Lund wrote: > On Thu, 2018-10-25 at 10:45 -0400, Ilia Mirkin wrote: > > Please confirm that this passes the piglit tests you sent to the > > list > > when run with ES2 forced, i.e. not ES3. > > (MESA_GLES_VERSION_OVERRI

<    1   2   3   4   5   6   7   8   >