[Mesa-dev] [PATCH] radeon/uvd: remove unused variables

Recent commits introduced new unused variable warnings, fix them. --- src/gallium/drivers/radeon/radeon_uvd.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/src/gallium/drivers/radeon/radeon_uvd.c b/src/gallium/drivers/radeon/radeon_uvd.c index 16ee541..81f3f45 100644

[Mesa-dev] [PATCH] radeonsi: mark unreachable paths to avoid warnings

Otherwise we get: warning: 'num_user_sgprs' may be used uninitialized in this function ... --- src/gallium/drivers/radeonsi/si_shader.c| 2 +- src/gallium/drivers/radeonsi/si_state_shaders.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git

Re: [Mesa-dev] [PATCH] radeon/uvd: remove unused variables

On Tue, Aug 18, 2015 at 11:30 AM, Christian König deathsim...@vodafone.de wrote: On 18.08.2015 01:51, Grazvydas Ignotas wrote: Recent commits introduced new unused variable warnings, fix them. Reviewed-by: Christian König christian.koe...@amd.com Do you have commit access? No, it's only

[Mesa-dev] [PATCH 2/4] r600g: make all viewport states use single atom

Similarly to scissor states, we can use single atom to track all viewport states. This will allow to simplify dirty atom handling later. --- src/gallium/drivers/r600/evergreen_state.c | 7 ++--- src/gallium/drivers/r600/r600_blit.c | 2 +- src/gallium/drivers/r600/r600_hw_context.c

[Mesa-dev] [PATCH 3/4] r600g: start numbering atoms from 1

There doesn't seem any reason to start from 4. Start from 1 instead (0 is left reserved to catch uninitialized atoms). --- src/gallium/drivers/r600/evergreen_state.c | 2 +- src/gallium/drivers/r600/r600_pipe.h | 2 +- src/gallium/drivers/r600/r600_state.c | 2 +- 3 files changed, 3

[Mesa-dev] [PATCH 1/4] r600g: make all scissor states use single atom

As suggested by Marek Olšák, we can use single atom to track all scissor states. This will allow to simplify dirty atom handling later. --- src/gallium/drivers/r600/evergreen_state.c | 33 ++--- src/gallium/drivers/r600/r600_blit.c | 2 +-

[Mesa-dev] [PATCH 4/4] r600g: simplify dirty atom tracking

Now that R600_NUM_ATOMS is below 64, dirty atom tracking can be simplified. --- src/gallium/drivers/r600/r600_pipe.h | 41 ++-- 1 file changed, 11 insertions(+), 30 deletions(-) diff --git a/src/gallium/drivers/r600/r600_pipe.h

[Mesa-dev] [PATCH 4/4] r600g: use a bitfield to track dirty atoms

r600 currently has 73 atoms and looping through their dirty flags has become costly because checking each flag requires a pointer dereference before the read. To avoid having to do that add additional bitfield which can be checked really quickly thanks to tzcnt instruction. id field was added to

[Mesa-dev] [PATCH 1/4] gallium/radeon: use helper functions to mark atoms dirty

This is analogous to r300_mark_atom_dirty() used by r300, and will be used by later patches. For common radeon code, appropriate helper is called through a function pointer. No functional changes. --- src/gallium/drivers/r600/evergreen_compute.c| 2 +-

[Mesa-dev] [PATCH 3/4] r600g: don't mark unused atom dirty

On evergreen config_state is not used, so don't mark it dirty. --- src/gallium/drivers/r600/r600_hw_context.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/r600/r600_hw_context.c b/src/gallium/drivers/r600/r600_hw_context.c index d67fdfd..c048a71

[Mesa-dev] [PATCH 2/4] r600g: use a helper to add an initialized atom

Instead of writing to rctx-atoms directly use a helper to take advantage of assert checks. --- src/gallium/drivers/r600/evergreen_state.c | 4 ++-- src/gallium/drivers/r600/r600_pipe.h | 1 + src/gallium/drivers/r600/r600_state.c| 4 ++--

Re: [Mesa-dev] [PATCH 4/4] r600g: use a bitfield to track dirty atoms

marek.ol...@amd.com Marek On Sun, Aug 9, 2015 at 11:42 PM, Grazvydas Ignotas nota...@gmail.com wrote: r600 currently has 73 atoms and looping through their dirty flags has become costly because checking each flag requires a pointer dereference before the read. To avoid having to do that add

Re: [Mesa-dev] [PATCH] gbm.h: Add a missing stddef.h include for size_t.

Hi, On Thu, Oct 29, 2015 at 6:21 PM, Emil Velikov wrote: > On 29 October 2015 at 15:22, Emmanuel Gil Peyrot > wrote: >> This was causing compilation issues when one of its providers wasn’t >> already included before gbm.h. > Cc: "11.0"

Re: [Mesa-dev] [PATCH 13/42] radeonsi: use a bitmask for tracking dirty atoms

On Sun, Aug 30, 2015 at 10:11 PM, Marek Olšák mar...@gmail.com wrote: ... diff --git a/src/gallium/drivers/radeonsi/si_state_draw.c b/src/gallium/drivers/radeonsi/si_state_draw.c index 2ff58d1..81575b5 100644 --- a/src/gallium/drivers/radeonsi/si_state_draw.c +++

Re: [Mesa-dev] [PATCH 40/42] winsys/radeon: add a flag telling how gfx IBs should be padded

On Sun, Aug 30, 2015 at 10:12 PM, Marek Olšák mar...@gmail.com wrote: From: Marek Olšák marek.ol...@amd.com This is always false on amdgpu (set by calloc). --- src/gallium/drivers/radeon/radeon_winsys.h| 1 + src/gallium/winsys/radeon/drm/radeon_drm_cs.c | 4 +---

Re: [Mesa-dev] [PATCH 00/42] RadeonSI cleaning up states

Hi, On Sun, Aug 30, 2015 at 10:11 PM, Marek Olšák mar...@gmail.com wrote: The viewport and scissor states are optimized. The main thing is that setting non-zero viewports and scissors is delayed until a shader that writes VIEWPORT_INDEX appears (which is typically never). ... Radeonsi no

[Mesa-dev] [PATCHv2 3/6] r600g: make all viewport states use single atom

Similarly to scissor states, we can use single atom to track all viewport states. This will allow to simplify dirty atom handling later. --- v2: rebased, moved dirty_mask set out of the loop src/gallium/drivers/r600/evergreen_state.c | 7 ++--- src/gallium/drivers/r600/r600_blit.c |

[Mesa-dev] [PATCH 6/6] gallium/radeon: remove 'dirty' member from r600_atom

It's no longer used by both r600 and radeonsi now. --- src/gallium/drivers/r600/r600_pipe.h | 2 -- src/gallium/drivers/r600/r600_state_common.c | 1 - src/gallium/drivers/radeon/r600_pipe_common.h | 3 +-- src/gallium/drivers/radeonsi/si_state.c | 1 - 4 files changed, 1

[Mesa-dev] [PATCH 4/6] r600g: start numbering atoms from 1

There doesn't seem any reason to start from 4. Start from 1 instead (0 is left reserved to catch uninitialized atoms). --- src/gallium/drivers/r600/evergreen_state.c | 2 +- src/gallium/drivers/r600/r600_pipe.h | 2 +- src/gallium/drivers/r600/r600_state.c | 2 +- 3 files changed, 3

[Mesa-dev] [PATCHv2 1/6] r600g: make all scissor states use single atom

As suggested by Marek Olšák, we can use single atom to track all scissor states. This will allow to simplify dirty atom handling later. --- v2: rebased, moved dirty_mask set out of the loop src/gallium/drivers/r600/evergreen_state.c | 36 ++

[Mesa-dev] [PATCH 5/6] r600g: simplify dirty atom tracking

Now that R600_NUM_ATOMS is below 64, dirty atom tracking can be simplified. --- src/gallium/drivers/r600/r600_hw_context.c | 9 +++--- src/gallium/drivers/r600/r600_pipe.h | 45 src/gallium/drivers/r600/r600_state_common.c | 9 +++--- 3 files changed, 14

[Mesa-dev] [PATCH 2/6] r600g: apply disable workaround on all scissors

During review of the "r600g: make all scissor states use single atom" patch Marek Olšák noticed that scissor disable workaround should be applied on all scissor states and not just first one, so let's do so. --- src/gallium/drivers/r600/r600_state.c| 22 +-

Re: [Mesa-dev] [PATCH 1/4] r600g: make all scissor states use single atom

to all scissors, not just 0. That is, if scissor.enable is changed, all scissors must be marked as dirty. Marek On Mon, Aug 24, 2015 at 2:24 AM, Grazvydas Ignotas nota...@gmail.com wrote: As suggested by Marek Olšák, we can use single atom to track all scissor states. This will allow to simplify

Re: [Mesa-dev] [PATCH] r600g: update num_dw in scissor_enable workaround

On Thu, Sep 10, 2015 at 5:35 AM, Michel Dänzer <mic...@daenzer.net> wrote: > On 10.09.2015 01:33, Grazvydas Ignotas wrote: >> "r600g: apply disable workaround on all scissors" forgot to update >> num_dw, fix it. >> >> Fixes: fbb423b433 "r600g: apply

[Mesa-dev] [PATCH] r600g: update num_dw in scissor_enable workaround

"r600g: apply disable workaround on all scissors" forgot to update num_dw, fix it. Fixes: fbb423b433 "r600g: apply disable workaround on all scissors" Reported-and-tested-by: Markus Trippelsdorf Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=91921 ---

[Mesa-dev] [PATCH resend] r600g: update num_dw in scissor_enable workaround

"r600g: apply disable workaround on all scissors" forgot to update num_dw, fix it. Fixes: fbb423b433 "r600g: apply disable workaround on all scissors" Reported-and-tested-by: Markus Trippelsdorf <mar...@trippelsdorf.de> Signed-off-by: Grazvydas Ignotas <nota...@gmail.

Re: [Mesa-dev] r600 tess branches updated

Hi, On Fri, Dec 4, 2015 at 6:19 AM, Dave Airlie <airl...@gmail.com> wrote: > Hey all, > > I've pushed an updated version of the r600g tess support to my > r600g-tess-submit branch. FWIW: Tested-by: Grazvydas Ignotas <nota...@gmail.com> on JUNIPER XT with heaven and p

[Mesa-dev] [PATCH] r600: fix constant buffer size programming

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=92229 Signed-off-by: Grazvydas Ignotas <nota...@gmail.com> --- Only tested on Juniper, but I guess others will need this too. src/gallium/drivers/r600/evergreen_state.c | 2 +- src/gallium/drivers/r600/r600_state.c | 2 +- 2 files chang

Re: [Mesa-dev] [PATCH] r600: fix constant buffer size programming

On Tue, Dec 22, 2015 at 5:37 PM, Nicolai Hähnle <nhaeh...@gmail.com> wrote: > On 21.12.2015 21:12, Grazvydas Ignotas wrote: >> >> When buffer size is less than 16, zero ends up being programmed as >> size, which prevents the hardware from fetching the correct values. &

Re: [Mesa-dev] [PATCH 0/3] r600g removal of unnecessary cache flushes

I've tried it on AMD JUNIPER (DRM 2.43.0 / 4.6.0) and it does not pass the kernel CS validator with [drm:evergreen_packet3_check.isra.14 [radeon]] *ERROR* Packet3 opcode 42 not supported printed many times. I guess it needs some kernel patch? I haven't found anything relevant in Alex's kernel

Re: [Mesa-dev] [PATCH 0/3] r600g removal of unnecessary cache flushes

On Tue, May 31, 2016 at 2:58 AM, Grazvydas Ignotas <nota...@gmail.com> wrote: > I've patched the CS validator and there seem to be some regressions: > > arb_map_buffer_range 11/11 5/11 > copybuffersubdata decrement-offset > copybuffersubdata increment-offset > co

Re: [Mesa-dev] [PATCH 0/3] r600g removal of unnecessary cache flushes

h is based on, don't know if it has any effect. Should I attempt to bisect? Gražvydas On Tue, May 31, 2016 at 1:30 AM, Marek Olšák <mar...@gmail.com> wrote: > On Tue, May 31, 2016 at 12:17 AM, Grazvydas Ignotas <nota...@gmail.com> wrote: >> I've tried it on AMD JUNIPER (DRM 2.43.

Re: [Mesa-dev] [PATCH 2/2] automake: bring back the .PHONY git_sha1.h.tmp rule

HONY rule and the > temporary file. > > The former is used to ensure that the header is regenerated when on each > make invocation, while the latter helps us avoid the unneeded rebuild(s) > when the SHA1 hasn't changed. > > Cc: Grazvydas Ignotas <nota...@gmail.com> >

Re: [Mesa-dev] [PATCH 2/2] i965: Add norbc debug option

On Tue, May 31, 2016 at 5:16 PM, Topi Pohjolainen wrote: > This INTEL_DEBUG option disables lossless compression (also known > as render buffer compression). > > Suggested-by: Eero Tamminen > Signed-off-by: Topi Pohjolainen

Re: [Mesa-dev] [PATCH 7/9] anv/pipeline: Silently pass tests if depth or stencil is missing

On Thu, Jun 2, 2016 at 12:44 AM, Jason Ekstrand wrote: > Signed-off-by: Jason Ekstrand > Cc: "12.0" > Cc: Ian Romanick > --- > src/intel/vulkan/gen7_pipeline.c | 12 ++-- >

Re: [Mesa-dev] [PATCH 00/10] R600: Cache flush fixes and cleanup v2

On Wed, Jun 1, 2016 at 9:57 PM, Marek Olšák <mar...@gmail.com> wrote: > Hi, > > This is version 2 of the previous series. This time it's been tested!! > > Tested cards: > - RV670 > - RV730 > - EG/REDWOOD > - CAYMAN All good on JUNIPER now (piglit and a few ra

Re: [Mesa-dev] [PATCH 2/4] automake: rework the git_sha1.h rule, include in tarball

On Mon, May 30, 2016 at 3:46 PM, Emil Velikov wrote: > From: Emil Velikov > > As we'll need the file in the release tarball, rework the rule so that > the file is regenerated _only_ if we're in a git repository. > > With this in place we can

[Mesa-dev] [PATCH] doc: improve INTEL_DEBUG documentation

Remove 'reg' option that does not actually exist, elaborate more about 'sync' and add the missing options. Signed-off-by: Grazvydas Ignotas <nota...@gmail.com> --- no commit access, if this is ok please somebody push docs/envvars.html | 12 ++-- 1 file changed, 10 insertions

Re: [Mesa-dev] V3 On disk shader cache for i965 (Now with real world results!)

Tried this while playing with apitrace and am getting segfaults when running any trace with a cached (second) run. Not sure if it's "wrong" traces I've chosen or what, you can take one example from this bug: https://bugs.freedesktop.org/show_bug.cgi?id=96425 It would also be good idea to hide the

[Mesa-dev] [PATCH] r600g: don't leak driver const buffers

The buffers are referenced from r600_update_driver_const_buffers() -> r600_set_constant_buffer() -> u_upload_data(), but nothing ever releases the reference. Similar case with driver_consts. Found using valgrind. Signed-off-by: Grazvydas Ignotas <nota...@gmail.com> --- No c

Re: [Mesa-dev] [PATCH] [v2] i965/skl: Add two missing device IDs

On Wed, Feb 17, 2016 at 1:45 AM, Ben Widawsky wrote: > The Iris part is left unbranded because we did not have these with original > SKL. > > v2: 0x192d is gt3, not gt4 The name and description still don't agree. > > Cc: "11.0 11.1"

Re: [Mesa-dev] [PATCH 2/3] st/mesa: set TGSI property NEXT_SHADER

On Thu, Mar 10, 2016 at 7:36 PM, Marek Olšák wrote: > From: Marek Olšák > > --- > src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 35 > ++ > 1 file changed, 35 insertions(+) > > diff --git

Re: [Mesa-dev] [PATCH 2/4] r600g: remove TGSI->LLVM translation

On Fri, Mar 11, 2016 at 7:48 PM, Marek Olšák wrote: > Can you paste the build failures please? In file included from compute_memory_pool.c:42:0: evergreen_compute_internal.h:43:2: error: unknown type name ‘LLVMContextRef’ LLVMContextRef llvm_ctx; ^ evergreen_compute.c: In

Re: [Mesa-dev] Merging the Vulkan driver

Hi, On Tue, Apr 5, 2016 at 10:30 PM, Jason Ekstrand wrote: > I know we don't usually do merges in this project, but > the Vulkan driver is big and has a lot of history that we would like to > preserve. If you're strongly opposed to doing a merge, please speak up now! I

Re: [Mesa-dev] [PATCH] st/nine: correctly fold guards around define WINAPI

On Fri, Apr 15, 2016 at 6:06 PM, Emil Velikov wrote: > From: Emil Velikov > > The __i386__ and __x86-64__ macros are gcc/clang specific, thus one does > not need the __GNUC__ at the top. > > Additionally, having _M_IX86 and _M_X64 in the same

[Mesa-dev] [PATCH 3/7] gallium: fix warnings in release build

Mark variables MAYBE_UNUSED to avoid unused-but-set-variable warnings in release build. Signed-off-by: Grazvydas Ignotas <nota...@gmail.com> --- I have no commit access, if this patch is ok, please someone push. src/gallium/auxiliary/pipebuffer/pb_buffer_fenced.c | 2 +- src/gallium/aux

[Mesa-dev] [PATCH 6/7] anv: fix warnings in release build

Mark variables MAYBE_UNUSED to avoid unused-but-set-variable warnings in release build. Signed-off-by: Grazvydas Ignotas <nota...@gmail.com> --- I have no commit access, if this patch is ok, please someone push. src/intel/vulkan/anv_dump.c | 2 +- src/intel/

[Mesa-dev] [PATCH 1/7] util: add MAYBE_UNUSED for config dependent variables

on both GCC 4.2 (oldest supported by mesa) and clang 3.0 (just some random old version, nut sure what's the minimum for mesa). Signed-off-by: Grazvydas Ignotas <nota...@gmail.com> --- I have no commit access, if this patch is ok, please someone push. src/util/macros.h | 2 ++ 1 file chan

[Mesa-dev] [PATCH 5/7] isl: fix warnings in release build

Mark variables MAYBE_UNUSED to avoid unused-but-set-variable warnings in release build. Signed-off-by: Grazvydas Ignotas <nota...@gmail.com> --- I have no commit access, if this patch is ok, please someone push. src/intel/isl/isl.c | 2 +- src/intel/isl/isl_gen7.c | 2 +- 2 files c

[Mesa-dev] [PATCH 0/7] release build warning fixes

I guess almost everyone here builds mesa with asserts enabled, but many forget asserts are off by default, so ordinary users get thrown at quite a lot of warnings. This tries to improve the situation somewhat. Grazvydas Ignotas (7): util: add MAYBE_UNUSED for config dependent variables glsl

[Mesa-dev] [PATCH 4/7] spirv: fix warning in release build

Mark variable MAYBE_UNUSED to avoid unused-but-set-variable warning in release build. Signed-off-by: Grazvydas Ignotas <nota...@gmail.com> --- I have no commit access, if this patch is ok, please someone push. src/compiler/spirv/vtn_cfg.c | 2 +- 1 file changed, 1 insertion(+), 1 de

[Mesa-dev] [PATCH 2/7] glsl: fix warning in release build

Mark variable MAYBE_UNUSED to avoid unused-but-set-variable warning in release build. Signed-off-by: Grazvydas Ignotas <nota...@gmail.com> --- I have no commit access, if this patch is ok, please someone push. src/compiler/glsl/lower_buffer_access.cpp | 2 +- 1 file changed, 1 insertion

[Mesa-dev] [PATCH 7/7] gallium: use unreachable instead of asserts

Avoids warnings in release builds. Signed-off-by: Grazvydas Ignotas <nota...@gmail.com> --- I have no commit access, if this patch is ok, please someone push. src/gallium/auxiliary/gallivm/lp_bld_intr.c | 2 +- src/gallium/drivers/radeon/radeon_llvm_emit.c | 2 +- 2 files chan

[Mesa-dev] [PATCH] mesa: add tags file to gitignore

For ctags users like me. Signed-off-by: Grazvydas Ignotas <nota...@gmail.com> --- I have no commit access, if this patch is ok, please someone push. .gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/.gitignore b/.gitignore index b4f88f7..7db5639 100644 --- a/.gitignore

Re: [Mesa-dev] [PATCH] st/nine: correctly fold guards around define WINAPI

On Fri, Apr 15, 2016 at 9:46 PM, Christian Schmidbauer wrote: > On 15/04/16 17:06, Emil Velikov wrote: >> From: Emil Velikov >> >> The __i386__ and __x86-64__ macros are gcc/clang specific, thus one does >> not need the __GNUC__ at the top.

Re: [Mesa-dev] [PATCH 1/7] util: add MAYBE_UNUSED for config dependent variables

On Sun, Apr 17, 2016 at 2:50 AM, Emil Velikov <emil.l.veli...@gmail.com> wrote: > On 16 April 2016 at 02:00, Grazvydas Ignotas <nota...@gmail.com> wrote: >> This is mostly for variables that are only used in asserts and cause >> unused-but-set-variable warnings in rel

Re: [Mesa-dev] [PATCH 1/3] gallium/os: add os_get_process_cmd_line

On Sat, Jul 30, 2016 at 6:22 PM, Marek Olšák wrote: > From: Marek Olšák > > for debugging > --- > src/gallium/auxiliary/os/os_process.c | 37 > +++ > src/gallium/auxiliary/os/os_process.h | 2 ++ > 2 files changed, 39

Re: [Mesa-dev] V3 On disk shader cache for i965 (Now with real world results!)

On Wed, Jul 13, 2016 at 2:56 AM, Timothy Arceri <timothy.arc...@collabora.com> wrote: > On Sat, 2016-07-09 at 20:21 +0300, Grazvydas Ignotas wrote: >> >> I think I still have some more: >> - running 32bit program after 64bit version of the same thing (or >>

Re: [Mesa-dev] [PATCH 5/5] radeonsi: add a workaround for a compute VGPR-usage LLVM bug

On Tue, Jul 12, 2016 at 11:52 PM, Marek Olšák wrote: > From: Marek Olšák > > This patch may be dropped depending on feedback. > > Cc: 12.0 > --- > src/gallium/drivers/radeonsi/si_shader.c | 33 >

Re: [Mesa-dev] [PATCH] gallium/os: use CLOCK_MONOTONIC for sleeps

On Mon, Jul 18, 2016 at 3:14 PM, Marek Olšák wrote: > From: Marek Olšák > > --- > src/gallium/auxiliary/os/os_time.c | 15 +-- > src/gallium/auxiliary/os/os_time.h | 4 > 2 files changed, 13 insertions(+), 6 deletions(-) > > diff --git

Re: [Mesa-dev] [PATCH 0/4] RadeonSI: Multithreaded shader compilation

On Sat, Jul 16, 2016 at 2:00 AM, Marek Olšák wrote: > On Wed, Jul 13, 2016 at 10:50 AM, Vedran Miletić wrote: >> On 07/13/2016 05:19 AM, Timothy Arceri wrote: >>> >>> So I finally got around to setting up my new polaris card on fedora. I >>> was curious to

Re: [Mesa-dev] V3 On disk shader cache for i965 (Now with real world results!)

On Tue, Jun 28, 2016 at 10:53 AM, Timothy Arceri <timothy.arc...@collabora.com> wrote: > On Mon, 2016-06-27 at 00:46 +1000, Timothy Arceri wrote: >> On Sun, 2016-06-26 at 16:15 +0300, Grazvydas Ignotas wrote: >> > Tried this while playing with apitrace and am get

Re: [Mesa-dev] V3 On disk shader cache for i965 (Now with real world results!)

On Sat, Jul 9, 2016 at 10:02 AM, Timothy Arceri <timothy.arc...@collabora.com> wrote: > On Fri, 2016-07-01 at 14:12 +1000, Timothy Arceri wrote: >> On Thu, 2016-06-30 at 00:59 +0300, Grazvydas Ignotas wrote: >> > On Wed, Jun 29, 2016 at 3:11 PM, Timothy Arceri >> &

Re: [Mesa-dev] [PATCH 0/4] RadeonSI: Multithreaded shader compilation

On Sat, Jul 9, 2016 at 6:49 PM, Marek Olšák wrote: > On Fri, Jul 8, 2016 at 3:20 AM, Timothy Arceri > wrote: >> On Wed, 2016-06-29 at 18:32 +0200, Marek Olšák wrote: >>> Hi, >>> >>> This series implements basic multithreaded LLVM shader compilation

Re: [Mesa-dev] V3 On disk shader cache for i965 (Now with real world results!)

On Wed, Jun 29, 2016 at 3:11 PM, Timothy Arceri <timothy.arc...@collabora.com> wrote: > On Wed, 2016-06-29 at 03:47 +0300, Grazvydas Ignotas wrote: >> On Tue, Jun 28, 2016 at 10:53 AM, Timothy Arceri >> <timothy.arc...@collabora.com> wrote: >> > On Mon, 2016-

[Mesa-dev] [PATCH] radv: don't resubmit the same cs over and over while tracing

Fixes: 97dfff54 ("radv: Dump command buffer on hang.") Signed-off-by: Grazvydas Ignotas <nota...@gmail.com> --- no commit access src/amd/vulkan/radv_device.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/amd/vulkan/radv_device.c b/src/amd/vulkan/rad

Re: [Mesa-dev] [PATCH 1/8] util/disk_cache: fix bug with deleting old cache dirs

On Wed, Feb 22, 2017 at 5:45 AM, Timothy Arceri wrote: > If there was more than a single directory in the .cache/mesa dir > then it would only remove one (or none) of the directories. > > Apparently Valgrind was also reporting: > Conditional jump or move depends on

Re: [Mesa-dev] [PATCH] r300g: only allow byteswapped formats on big endian

So, as there are no better solutions in sight, can somebody please push this patch? Gražvydas On Wed, Feb 15, 2017 at 5:33 AM, Alex Deucher wrote: > On Tue, Feb 14, 2017 at 10:27 PM, Michel Dänzer wrote: >> On 14/02/17 08:25 PM, Marek Olšák wrote: >>>

Re: [Mesa-dev] [PATCH 3/4] gallium/radeon: add a HUD query for monitoring the CS thread activity

On Sat, Feb 11, 2017 at 9:58 PM, Marek Olšák wrote: > From: Marek Olšák > > --- > src/gallium/drivers/radeon/r600_query.c | 25 > ++- > src/gallium/drivers/radeon/r600_query.h | 1 + >

Re: [Mesa-dev] [PATCH] util/disk_cache: stop using ralloc_asprintf() unnecessarily

On Thu, Feb 9, 2017 at 12:06 AM, Timothy Arceri wrote: > --- > src/util/disk_cache.c | 25 - > 1 file changed, 12 insertions(+), 13 deletions(-) > > diff --git a/src/util/disk_cache.c b/src/util/disk_cache.c > index 7691621..edfff73 100644 > ---

[Mesa-dev] [PATCH] r300g: only allow byteswapped formats on big endian

They cause regressions on little endian. Fixes: 172bfdaa9e ("r300g: add support for PIPE_FORMAT_x8R8G8B8_*") Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=98869 Signed-off-by: Grazvydas Ignotas <nota...@gmail.com> --- no commit access src/gallium/drivers/r300/r3

Re: [Mesa-dev] Query with respect to support of x32

On Tue, Feb 14, 2017 at 3:12 PM, Haridasan, Sujith wrote: > I am using mesa 12.0.1 from yocto project > (http://git.yoctoproject.org/cgit/cgit.cgi/poky/tree/meta/recipes-graphics/mesa/mesa_12.0.1.bb?h=morty). > While building core-image-sato ( which is the graphical

Re: [Mesa-dev] [PATCH 1/2] util: Add helpers for iterating over Vulkan extension structs

On Wed, Feb 15, 2017 at 2:03 AM, Jason Ekstrand wrote: > --- > src/util/Makefile.sources | 3 ++- > src/util/vk_util.h| 43 +++ > 2 files changed, 45 insertions(+), 1 deletion(-) > create mode 100644 src/util/vk_util.h > >

Re: [Mesa-dev] [PATCH] r300g: only allow byteswapped formats on big endian

On Mon, Feb 13, 2017 at 10:22 AM, Michel Dänzer <mic...@daenzer.net> wrote: > On 13/02/17 05:17 PM, Michel Dänzer wrote: >> On 11/02/17 08:01 AM, Grazvydas Ignotas wrote: >>> They cause regressions on little endian. >>> >>> Fixes: 172bfdaa9e (&qu

[Mesa-dev] [PATCH 2/2] gallium/u_queue: set num_threads correctly if not all threads start

If i-th thread could not be created it means we have i threads, not i+1, because we start from 0. Fixes: 404d0d5 "gallium/u_queue: add an option to have multiple worker threads" Signed-off-by: Grazvydas Ignotas <nota...@gmail.com> --- no commit access src/gallium/auxiliary/ut

[Mesa-dev] [PATCH 1/2] gallium/u_queue: fix a crash with atexit handlers

ns. Fixes: 4aea8fe "gallium/u_queue: fix random crashes when the app calls exit()" Signed-off-by: Grazvydas Ignotas <nota...@gmail.com> --- no commit access src/gallium/auxiliary/util/u_queue.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/auxiliary/util/u_queue.

Re: [Mesa-dev] [PATCH 1/4] util/disk_cache: add support for detecting corrupt cache entries

On Wed, Mar 1, 2017 at 7:25 AM, Timothy Arceri wrote: > --- > src/util/disk_cache.c | 37 ++--- > 1 file changed, 34 insertions(+), 3 deletions(-) > > diff --git a/src/util/disk_cache.c b/src/util/disk_cache.c > index f5e1145..2a0edca 100644

Re: [Mesa-dev] [PATCH 2/4] util/disk_cache: compress individual cache entries

On Wed, Mar 1, 2017 at 7:25 AM, Timothy Arceri wrote: > ... > diff --git a/src/util/disk_cache.c b/src/util/disk_cache.c > index 2a0edca..03aae02 100644 > --- a/src/util/disk_cache.c > +++ b/src/util/disk_cache.c > @@ -30,20 +30,21 @@ > #include > #include > #include

Re: [Mesa-dev] [PATCH 1/2] util/disk_cache: support caches for multiple architectures

On Thu, Mar 2, 2017 at 8:36 AM, Timothy Arceri wrote: > > > On 02/03/17 17:17, Ilia Mirkin wrote: >> >> On Thu, Mar 2, 2017 at 1:08 AM, Timothy Arceri >> wrote: >>> >>> Previously we were deleting the entire cache if a user switched >>> between 32

Re: [Mesa-dev] [PATCH 1/4] amd/common: add nir->llvm translation.

On Tue, Oct 4, 2016 at 1:09 PM, Nicolai Hähnle wrote: > On 04.10.2016 03:48, Dave Airlie wrote: > > [snip] >> >> diff --git a/src/amd/common/ac_llvm_helper.cpp >> b/src/amd/common/ac_llvm_helper.cpp >> new file mode 100644 >> index 000..feafdaf >> --- /dev/null >> +++

Re: [Mesa-dev] [PATCH 1/5] i965: wrap assert param in #ifndef NDEBUG

On Tue, Oct 4, 2016 at 3:15 AM, Timothy Arceri wrote: > This fixes an unused variable warning on release builds. > --- > src/mesa/drivers/dri/i965/brw_fs.cpp | 4 > 1 file changed, 4 insertions(+) > > diff --git a/src/mesa/drivers/dri/i965/brw_fs.cpp >

Re: [Mesa-dev] [PATCH] radv: Suffix the intel_icd file with the host CPU

On Wed, Nov 9, 2016 at 8:11 PM, Emil Velikov wrote: > From: Emil Velikov > > Port of the anv commit d96345de989 ("anv: Suffix the intel_icd file with > the host CPU"). I guess the subject of this patch should say radeon_icd instead of

Re: [Mesa-dev] [PATCH] radeonsi: emit TA_CS_BC_BASE_ADDR on SI only if the kernel allows it

On Mon, Oct 10, 2016 at 2:25 PM, Marek Olšák wrote: > From: Marek Olšák > > The kernel patch has been sent to amd-gfx. > --- > src/gallium/drivers/radeonsi/si_compute.c | 7 ++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git

[Mesa-dev] [PATCH 1/3] radv: fix release build unused variable warnings

Just mark with MAYBE_UNUSED. Signed-off-by: Grazvydas Ignotas <nota...@gmail.com> --- no commit access, somebody please push src/amd/vulkan/radv_cmd_buffer.c | 34 ++ src/amd/vulkan/radv_query.c | 6 +++--- 2 files changed, 21 insertions(+), 19 del

[Mesa-dev] [PATCH 2/3] radv/meta: use VK_NULL_HANDLE for handles

Otherwise we get 32bit warnings because handle is plain uint64_t there and NULL is not suited to initialize that. Signed-off-by: Grazvydas Ignotas <nota...@gmail.com> --- no commit access, somebody please push src/amd/vulkan/radv_meta_blit2d.c | 2 +- src/amd/vulkan/radv_meta_bufi

[Mesa-dev] [PATCH] radeonsi: fix release build unused variable warnings

Signed-off-by: Grazvydas Ignotas <nota...@gmail.com> --- no commit access, somebody please push src/gallium/drivers/radeonsi/si_blit.c | 2 +- src/gallium/drivers/radeonsi/si_state.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_bli

[Mesa-dev] [PATCH] anv: fix release build unused variable warnings

Signed-off-by: Grazvydas Ignotas <nota...@gmail.com> --- no commit access, somebody please push src/intel/vulkan/anv_blorp.c | 3 ++- src/intel/vulkan/genX_cmd_buffer.c | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/src/intel/vulkan/anv_blorp.c b/src/intel/

[Mesa-dev] [PATCH] intel/aubinator: fix 32bit shift overflow warning

Doesn't look like this can work on 32bit, just rids of annoying warning. Signed-off-by: Grazvydas Ignotas <nota...@gmail.com> --- no commit access, somebody please push src/intel/tools/aubinator.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/intel/tools/aubinat

[Mesa-dev] [PATCH] i965: fix release build unused variable warning

Signed-off-by: Grazvydas Ignotas <nota...@gmail.com> --- src/mesa/drivers/dri/i965/brw_blorp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_blorp.c b/src/mesa/drivers/dri/i965/brw_blorp.c index 4c1d858..8b5750c 100644 --- a/sr

[Mesa-dev] [PATCH] softpipe: fix release build unused variable warning

Signed-off-by: Grazvydas Ignotas <nota...@gmail.com> --- no commit access, somebody please push src/gallium/drivers/softpipe/sp_state_shader.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/softpipe/sp_state_shader.c b/src/gallium/drivers/so

[Mesa-dev] [PATCH 3/3] radv/ac: some fix maybe-uninitialized warnings

Mark some paths unreachable so that compiler knows variables are initialized in all valid paths. Signed-off-by: Grazvydas Ignotas <nota...@gmail.com> --- no commit access, somebody please push src/amd/common/ac_nir_to_llvm.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff

[Mesa-dev] [PATCH 1/2] vulkan: deduplicate the util code

anv_util.c and radv_util.c are essentially duplicates, so create a new vk_util.c to be shared by both vulkan drivers. Some other content from anv_private.h and radv_private.h was moved to vk_util.h too. Signed-off-by: Grazvydas Ignotas <nota...@gmail.com> --- no commit access config

[Mesa-dev] [PATCH 2/2] vulkan: fix 'statement with no effect' warning

Emitted on release build in case vk_error() return is not used. Signed-off-by: Grazvydas Ignotas <nota...@gmail.com> --- no commit access src/vulkan/vk_util.c | 4 src/vulkan/vk_util.h | 13 - 2 files changed, 12 insertions(+), 5 deletions(-) diff --git a/src/vulkan/vk_

[Mesa-dev] [PATCH v2] i965: fix release build unused variable warning

Signed-off-by: Grazvydas Ignotas <nota...@gmail.com> --- v2: take Eduardo Lima's suggestion further - remove the variable completely no commit access src/mesa/drivers/dri/i965/brw_blorp.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_b

[Mesa-dev] [PATCH] anv: remove some unused macros and functions

VK_ICD_WSI_PLATFORM_MAX is used, but a duplicate from wsi_common.h . Signed-off-by: Grazvydas Ignotas <nota...@gmail.com> --- no commit access requested by Emil: https://lists.freedesktop.org/archives/mesa-dev/2017-January/140733.html src/intel/vulkan/anv_private.h | 15 --

Re: [Mesa-dev] [PATCH] gallium: add Tegra renderonly support

Hi, just out of the interest, can this be used on Tegra X1 right now? If so, what would I need to get it to work (kernel, firmware, something else)? I'd be interested to run mesa on the Shield TV. Gražvydas On Fri, Jan 13, 2017 at 9:47 AM, Alexandre Courbot wrote: > From:

[Mesa-dev] [PATCH] radv: remove some unused macros and functions

These seem unlikely to be used. Also remove irrelevant comment about SKL. Signed-off-by: Grazvydas Ignotas <nota...@gmail.com> --- no commit access src/amd/vulkan/radv_private.h | 15 +-- src/amd/vulkan/radv_util.c| 19 --- 2 files changed, 1 insertion(

Re: [Mesa-dev] [PATCH 06/10] amd/common: unify cube map coordinate handling between radeonsi and radv

Unfortunately this one breaks at least (surprise!) texturecubemap SaschaWillemsVulkan demo. I recommend you try it yourself, there are even precompiled binaries available (see README.md): https://github.com/SaschaWillems/Vulkan Gražvydas On Tue, Jan 10, 2017 at 5:12 PM, Nicolai Hähnle

[Mesa-dev] [PATCH v2] radv: remove some unused macros and functions

These seem unlikely to be used. Also remove irrelevant comment about SKL. v2: forgot to rebase on master Signed-off-by: Grazvydas Ignotas <nota...@gmail.com> --- no commit access src/amd/vulkan/radv_private.h | 15 +-- src/amd/vulkan/radv_util.c| 19 --- 2

Re: [Mesa-dev] [PATCH] ac/debug: move .gitignore for sid_tables.h too

On Thu, Jan 12, 2017 at 12:26 PM, Nicolai Hähnle <nhaeh...@gmail.com> wrote: > On 12.01.2017 00:58, Grazvydas Ignotas wrote: >> >> b838f642 "ac/debug: Move sid_tables.h generation to common code." moved >> sid_tables.h but forgot the corresponding .gitignore. &

  1   2   3   4   >