ust 2015 at 18:31, Christian König wrote:
> On 21.08.2015 18:30, Ilia Mirkin wrote:
>
>> On Fri, Aug 21, 2015 at 12:22 PM, Julien Isorce
>> wrote:
>>
>>> What is the purpose of checking PIPE_VIDEO_PROFILE_UNKNOWN :
>>>
>>> http://cgit.freedesktop.
https://bugs.freedesktop.org/show_bug.cgi?id=89969
Signed-off-by: Julien Isorce
---
src/gallium/drivers/nouveau/nouveau_vp3_video.h| 6 --
.../drivers/nouveau/nouveau_vp3_video_bsp.c| 79 --
src/gallium/drivers/nouveau/nv50/nv98_video_bsp.c | 5 +-
src/gallium
https://bugs.freedesktop.org/show_bug.cgi?id=89969
Signed-off-by: Julien Isorce
---
src/gallium/drivers/nouveau/nouveau_vp3_video_bsp.c | 4
1 file changed, 4 insertions(+)
diff --git a/src/gallium/drivers/nouveau/nouveau_vp3_video_bsp.c
b/src/gallium/drivers/nouveau
This patch add 3 functions to split nouveau_vp3_bsp:
nouveau_vp3_bsp_begin
nouveau_vp3_bsp_next
nouveau_vp3_bsp_end
https://bugs.freedesktop.org/show_bug.cgi?id=89969
Signed-off-by: Julien Isorce
---
src/gallium/drivers/nouveau/nouveau_vp3_video.h| 15 +++
.../drivers/nouveau
https://bugs.freedesktop.org/show_bug.cgi?id=89969
Signed-off-by: Julien Isorce
---
src/gallium/drivers/nouveau/nvc0/nvc0_video_bsp.c | 34 +++
1 file changed, 28 insertions(+), 6 deletions(-)
diff --git a/src/gallium/drivers/nouveau/nvc0/nvc0_video_bsp.c
b/src/gallium
begin/end.
TODO: apply same logic for nv98 but I do not have the
material to test it.
https://bugs.freedesktop.org/show_bug.cgi?id=89969
Julien Isorce (8):
nouveau: extract memcpy loop from nouveau_vp3_bsp
nouveau: remove nouveau_vp3_bsp to use begin/next/end
nouveau: split
It will allow to call nvc0_decoder_bsp_next's content
mutlitple times between one begin/end.
https://bugs.freedesktop.org/show_bug.cgi?id=89969
Signed-off-by: Julien Isorce
---
src/gallium/drivers/nouveau/nvc0/nvc0_video.h | 14 ++
src/gallium/drivers/nouveau/nvc0/nvc0_video_bsp.c
: VAEntrypointVLD
VAProfileVC1Main: VAEntrypointVLD
VAProfileVC1Advanced: VAEntrypointVLD
VAProfileH264Baseline : VAEntrypointVLD
VAProfileH264Main : VAEntrypointVLD
VAProfileH264High : VAEntrypointVLD
Signed-o
In order to add support for chunck decoding.
Required to support st/va.
https://bugs.freedesktop.org/show_bug.cgi?id=89969
Signed-off-by: Julien Isorce
---
src/gallium/drivers/nouveau/nvc0/nvc0_video.c | 48 +--
1 file changed, 37 insertions(+), 11 deletions(-)
diff
https://bugs.freedesktop.org/show_bug.cgi?id=89969
Signed-off-by: Julien Isorce
---
src/gallium/drivers/nouveau/nvc0/nvc0_video.c | 12 +-
src/gallium/drivers/nouveau/nvc0/nvc0_video.h | 8 --
src/gallium/drivers/nouveau/nvc0/nvc0_video_bsp.c | 167 --
3 files
t;> HI Julien,
> >>
> >> On 27 August 2015 at 15:15, Julien Isorce wrote:
> >>> Currently nouveau does not support chunk decoding
> >>> which is required to support st/va
> >>>
> >>> The following patches refactor nouveau_vp
On 15 September 2016 at 16:02, Leo Liu wrote:
>
>
> On 09/15/2016 10:43 AM, Andy Furniss wrote:
>
>> Since bf901a2
>> st/va: also honors interlaced preference when providing a video format
>> existing scripts and most use cases will need true.
>>
>> Signed-off-by: Andy Furniss
>> ---
>> src/gal
On 16 September 2016 at 08:43, Christian König
wrote:
> Am 15.09.2016 um 23:07 schrieb Julien Isorce:
>
>
>
> On 15 September 2016 at 16:02, Leo Liu wrote:
>
>>
>>
>> On 09/15/2016 10:43 AM, Andy Furniss wrote:
>>
>>> Since bf901a2
>>&g
This fixes a crash when using the prefered video format with vaapisink
on Nvidia hardwares.
Also caught by the following assert:
nouveau_vp3_video.c:91: Assertion `templat->interlaced' failed.
TEST= gst-launch-1.0 videotestsrc ! video/x-raw, format=NV12 ! vaapisink
Signed-off-by: Julie
Hi Mark,
Thx for the patch. I can see it has already landed.
I just tried it with gstreamer-vaapi and it causes problem since they
create the config like this for VPP:
va_status = vaCreateConfig (filter->va_display, VAProfileNone,
VAEntrypointVideoProc, NULL, 0, &filter->va_config);
As yo
sed if the VAConfigRTFormat attribute is not
> > provided by the user.
> > ---
> > On 17/10/16 15:21, Julien Isorce wrote:
> >> Hi Mark,
> >>
> >> Thx for the patch. I can see it has already landed.
> >>
> >> I just tried it with gstre
As specified in va.h, default value should be set on attributes
not present in the input list.
Signed-off-by: Julien Isorce
---
src/gallium/state_trackers/va/config.c | 9 +
src/gallium/state_trackers/va/surface.c | 5 +++--
2 files changed, 12 insertions(+), 2 deletions(-)
diff --git
On 17 October 2016 at 16:27, Mark Thompson wrote:
> On 17/10/16 16:13, Julien Isorce wrote:
> > Hi Mark,
> >
> > Yes I actually saw that too in the intel driver though I think it does
> not add
> > VA_RT_FORMAT_RGB32 ? Or I missed something ?
> > Maybe th
On Monday, 17 October 2016, Mark Thompson wrote:
> On 17/10/16 17:33, Julien Isorce wrote:
> > As specified in va.h, default value should be set on attributes
> > not present in the input list.
> >
> > Signed-off-by: Julien Isorce >
> > ---
> > s
Hi Christian,
I pushed it before already. I can try to add a git notes if you want.
In any case thx for the review.
Cheers
Julien
On 18 October 2016 at 10:09, Christian König
wrote:
> Am 17.10.2016 um 21:40 schrieb Julien Isorce:
>
>
>
> On Monday, 17 October 2016, Mark
It happens when trying to use omxh264enc with nouveau driver
because it does not provide any encoder at the moment.
It crashes on enc_ReleaseTasks(&priv->free_tasks) because
at this time the list is not initialized.
So this patch make sure the lists are initialized.
Another way to fix this would
No encoder with nouveau driver so I cannot do a tunneling test
but at least this does not break the decoder part so the 4 patches are:
Tested-by: Julien Isorce
Thx!
On 6 July 2016 at 19:03, Leo Liu wrote:
> The idea of encode tunneling is to use video buffer directly for encoder,
&g
- split nvc0_decoder_bsp in begin/next/end
- preserve content buffer when calling nvc0_decoder_bsp_next
- implement pipe_video_codec::begin_frame/end_frame
https://bugs.freedesktop.org/show_bug.cgi?id=89969
Signed-off-by: Julien Isorce
---
src/gallium/drivers/nouveau/nvc0/nvc0_video.c
https://bugs.freedesktop.org/show_bug.cgi?id=89969
Signed-off-by: Julien Isorce
---
src/gallium/drivers/nouveau/nouveau_vp3_video_bsp.c | 4
1 file changed, 4 insertions(+)
diff --git a/src/gallium/drivers/nouveau/nouveau_vp3_video_bsp.c
b/src/gallium/drivers/nouveau
: VAEntrypointVLD
VAProfileVC1Main: VAEntrypointVLD
VAProfileVC1Advanced: VAEntrypointVLD
VAProfileH264Baseline : VAEntrypointVLD
VAProfileH264Main : VAEntrypointVLD
VAProfileH264High : VAEntrypointVLD
Signed-o
It allows to call nouveau_vp3_bsp_next multiple times
between one begin/end.
It is required to support st/va.
https://bugs.freedesktop.org/show_bug.cgi?id=89969
Signed-off-by: Julien Isorce
---
src/gallium/drivers/nouveau/nouveau_vp3_video.h| 17 ++-
.../drivers/nouveau
could be a bug in st/va itself.
TODO: apply same logic for nv98 but I do not have the
material to test it.
https://bugs.freedesktop.org/show_bug.cgi?id=89969
Julien Isorce (4):
nouveau: split nouveau_vp3_bsp in begin/next/end
nvc0: add support for st/va
nouveau: fix chunk decoding by
It allows to call nouveau_vp3_bsp_next multiple times
between one begin/end.
It is required to support st/va.
https://bugs.freedesktop.org/show_bug.cgi?id=89969
Signed-off-by: Julien Isorce
---
src/gallium/drivers/nouveau/nouveau_vp3_video.h| 16 +++-
.../drivers/nouveau
could be a bug in st/va itself.
TODO: apply same logic for nv98 but I do not have the
material to test it.
https://bugs.freedesktop.org/show_bug.cgi?id=89969
Julien Isorce (4):
nouveau: split nouveau_vp3_bsp in begin/next/end
nvc0: add support for st/va
nouveau: fix chunk decoding by
: VAEntrypointVLD
VAProfileVC1Main: VAEntrypointVLD
VAProfileVC1Advanced: VAEntrypointVLD
VAProfileH264Baseline : VAEntrypointVLD
VAProfileH264Main : VAEntrypointVLD
VAProfileH264High : VAEntrypointVLD
Signed-o
- split nvc0_decoder_bsp in begin/next/end
- preserve content buffer when calling nvc0_decoder_bsp_next
- implement pipe_video_codec::begin_frame/end_frame
https://bugs.freedesktop.org/show_bug.cgi?id=89969
Signed-off-by: Julien Isorce
---
src/gallium/drivers/nouveau/nouveau_vp3_video.h
ug.cgi?id=89969
Julien Isorce (4):
nouveau: split nouveau_vp3_bsp in begin/next/end
nvc0: add support for st/va
nouveau: fix chunk decoding by updating number of slices
build: enable st/va with nouveau driver
src/gallium/drivers/nouveau/nouveau_vp3_video.h| 22 +++-
.../
https://bugs.freedesktop.org/show_bug.cgi?id=89969
Signed-off-by: Julien Isorce
---
src/gallium/drivers/nouveau/nouveau_vp3_video.h | 3 +++
src/gallium/drivers/nouveau/nouveau_vp3_video_bsp.c | 8
2 files changed, 11 insertions(+)
diff --git a/src/gallium/drivers/nouveau
*** BLURB HERE ***
Julien Isorce (6):
nouveau: split nouveau_vp3_bsp in begin/next/end
nvc0: add support for st/va
nouveau: fix chunk decoding by updating number of slices
st/va: properly set max number of ref frames
build: enable st/va with nouveau driver
WIP: implement vaapi export
ackend.
TODO:
Apply same logic for nv98 but I do not have the
material to test it. Ilia Mirkin suggested to do it after.
https://bugs.freedesktop.org/show_bug.cgi?id=89969
Julien Isorce (6):
nouveau: split nouveau_vp3_bsp in begin/next/end
nvc0: add support for st/va
nouveau: fix chunk decodin
https://bugs.freedesktop.org/show_bug.cgi?id=89969
Signed-off-by: Julien Isorce
---
src/gallium/drivers/nouveau/nouveau_vp3_video.h | 3 +++
src/gallium/drivers/nouveau/nouveau_vp3_video_bsp.c | 17 +++--
2 files changed, 18 insertions(+), 2 deletions(-)
diff --git a/src
: VAEntrypointVLD
VAProfileVC1Main: VAEntrypointVLD
VAProfileVC1Advanced: VAEntrypointVLD
VAProfileH264Baseline : VAEntrypointVLD
VAProfileH264Main : VAEntrypointVLD
VAProfileH264High : VAEntrypointVLD
Signed-o
It fixes asserts like assert(templ->max_references <= 2);
in nvc0_video.c::nvc0_create_decoder
Signed-off-by: Julien Isorce
---
src/gallium/state_trackers/va/context.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/src/gallium/state_trackers/va/context.c
- split nvc0_decoder_bsp in begin/next/end
- preserve content buffer when calling nvc0_decoder_bsp_next
- implement pipe_video_codec::begin_frame/end_frame
https://bugs.freedesktop.org/show_bug.cgi?id=89969
Signed-off-by: Julien Isorce
---
src/gallium/drivers/nouveau/nouveau_vp3_video.h
It allows to call nouveau_vp3_bsp_next multiple times
between one begin/end.
It is required to support st/va.
https://bugs.freedesktop.org/show_bug.cgi?id=89969
Signed-off-by: Julien Isorce
---
src/gallium/drivers/nouveau/nouveau_vp3_video.h| 16 +++-
.../drivers/nouveau
On 17 September 2015 at 17:52, Ilia Mirkin wrote:
> On Wed, Sep 16, 2015 at 8:22 AM, Julien Isorce
> wrote:
> > I added below version4 updates. It works for all codecs expect h264.
> > Video is visible but lot of blockiness.
> > Can someone with a Radeon confirm that &q
From: Julien Isorce
The counter was not set but used by the nouveau driver.
It is required otherwise visual output is garbage.
Signed-off-by: Julien Isorce
---
src/gallium/state_trackers/va/picture.c| 8
src/gallium/state_trackers/va/picture_h264.c | 2 ++
src/gallium
Hi Thomas and Emil, I tested it and pushed. Thx a lot.
On 6 April 2016 at 21:34, Thomas H.P. Andersen wrote:
>
>
> On Sun, Mar 6, 2016 at 10:08 AM, Thomas H.P. Andersen
> wrote:
>
>>
>>
>> On Sat, Mar 5, 2016 at 1:30 PM, Emil Velikov
>> wrote:
>>
>>> Hi Thomas,
>>>
>>> On 5 March 2016 at 12:07
On 11 April 2016 at 22:24, Iurie wrote:
> From d6a5bbd910dc19d4863dbac8eba5bdf07bd1c3ab Mon Sep 17 00:00:00 2001
> From: GreatMaster
>
Please put your real name and add signed-off stamp: *git config --global
user*.name "FirstName LastName"
Then run : git commit --amend --reset-author --no-edit
On 12 April 2016 at 14:27, iurie wrote:
It should be "Firstname Lastname" , click on any commit here
https://cgit.freedesktop.org/mesa/mesa/log/ to compare or just type: git log
It is a common practice for most open source projects and sometimes a
requirement. Not sure if this is strictly require
Reviewed-by: Julien Isorce
I'll push it shortly. Thx
On 12 April 2016 at 23:24, Iurie Salomov wrote:
> From: iurie salomov
>
> Signed-off-by: Iurie Salomov
> ---
> src/gallium/state_trackers/va/context.c | 4
> 1 file changed, 4 insertions(+)
>
> diff --git
Hi Lurie,
Thx for your interest.
In order to work on this project you would need either a AMD or NVIDIA
graphic hardware. Indeed current st/omx in Gallium, only work with these 2
hardwares and it would be out of scope of the project to add support for
another hardware.
In order to check that you
Hi,
Thx for looking at it but are you sure your diff compiles ?
Can you try this instead:
--- a/src/gallium/state_trackers/va/image.c
+++ b/src/gallium/state_trackers/va/image.c
@@ -471,19 +471,19 @@ vlVaPutImage(VADriverContextP ctx, VASurfaceID
surface, VAImageID image,
if (format != surf-
an.
> >
> > Am 31.05.2016 um 14:51 schrieb Christian König:
> > > Yeah, that solution looks more correct to me.
> > >
> > > Christian.
> > >
> > > Am 31.05.2016 um 14:44 schrieb Julien Isorce:
> > > > Hi,
> > > > Thx for lookin
set or not the flag:
VA_SURFACE_EXTBUF_DESC_ENABLE_TILING
Signed-off-by: Julien Isorce
---
src/gallium/state_trackers/va/surface.c | 60 -
1 file changed, 59 insertions(+), 1 deletion(-)
diff --git a/src/gallium/state_trackers/va/surface.c
b/src/gallium/st
Signed-off-by: Julien Isorce
---
src/gallium/state_trackers/va/buffer.c | 8 +---
1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/src/gallium/state_trackers/va/buffer.c
b/src/gallium/state_trackers/va/buffer.c
index 2fd8661..7d3167b 100644
--- a/src/gallium/state_trackers/va
Instead of changing the format on the existing template
which makes error handling not nice and confuses coverity.
CoverityID: 1337953
Signed-off-by: Julien Isorce
---
src/gallium/state_trackers/va/image.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/gallium
wrote:
> Am 02.06.2016 um 16:03 schrieb Julien Isorce:
>
>> Signed-off-by: Julien Isorce
>>
>
> Actually I'm not sure if that is correct.
>
> If you release the VABuffer of an exported resource you won't be able to
> properly close the handle with vlVaRelea
On 8 June 2016 at 09:16, Christian König wrote:
> Am 02.06.2016 um 16:00 schrieb Julien Isorce:
>
>> In order to do zero-copy between two different devices
>> the memory should not be tiled.
>>
>> This is currently no way to set pipe_resource template's flag
just replace the specific "bool disable_tiling" by a
generic bind flag ?
On 8 June 2016 at 14:07, Christian König wrote:
> Am 08.06.2016 um 14:20 schrieb Julien Isorce:
>
>
>
> On 8 June 2016 at 09:16, Christian König wrote:
>
>> Am 02.06.2016 um 16:00 schr
: DRI_PRIME=1 gst-launch vaapidecodebin ! glimagesink
Signed-off-by: Julien Isorce
---
src/gallium/auxiliary/vl/vl_video_buffer.c | 3 +++
src/gallium/include/pipe/p_video_codec.h | 1 +
src/gallium/state_trackers/va/surface.c| 8
3 files changed, 12 insertions(+)
diff --git a/src/gallium
Hi,
It seems this patch has been pushed recently. This is causing me problems
on a multi gpu configuration.
It is a laptop with intel and nvidia, graphic hardwares.
1: intel vaapi driver:
vainfo
2: st/va,nouveau:
DRI_PRIME=1 LIBVA_DRIVER_NAME=gallium vainfo
with that patch 0c0f841e5de27d01312f8
On 15 June 2016 at 14:07, Christian König wrote:
> Please split that up into multiple parts. E.g. adding the config
> structure, new image format support etc..
>
> Julien, can you take a look as well if you have time and work a bit with
> Boyuan to get this cleaned up?
>
Hi,
I'll be happy to do
Thx for the patch:
Reviewed-by: Julien Isorce
I'll push it today.
On 26 June 2016 at 08:02, Gurkirpal Singh wrote:
> Call to handle_table_get in vlVaDestroySurfaces can
> return NULL on failure.
>
> CID: 1243522
>
> Signed-off-by: Gurkirpal Singh
> ---
>
with Bellagio library on Desktop with gstomxh264dec plugin.
Julien Isorce (3):
st/omx: retrieve preferred interlaced and buffer_formats
st/omx: add support for nouveau / interlaced
st/omx: count number of slices
src/gallium/state_trackers/omx/vid_dec.c | 77
Signed-off-by: Julien Isorce
---
src/gallium/state_trackers/omx/vid_dec.c | 51
1 file changed, 26 insertions(+), 25 deletions(-)
diff --git a/src/gallium/state_trackers/omx/vid_dec.c
b/src/gallium/state_trackers/omx/vid_dec.c
index 564ca2f..85ffb88 100644
Used by nouveau driver.
Similar patch was done for st/va:
851e7e12aa628d6781b5a3af2f2fc16ee73f435f
Signed-off-by: Julien Isorce
---
src/gallium/state_trackers/omx/vid_dec_h264.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/src/gallium/state_trackers/omx/vid_dec_h264.c
b/src/gallium
Interlaced can be true for nouveau driver.
Signed-off-by: Julien Isorce
---
src/gallium/state_trackers/omx/vid_dec.c | 26 --
1 file changed, 24 insertions(+), 2 deletions(-)
diff --git a/src/gallium/state_trackers/omx/vid_dec.c
b/src/gallium/state_trackers/omx
it got seg fault. Will take look
> further.
>
> Regards,
> Leo
>
>
>
> On 06/27/2016 04:16 AM, Julien Isorce wrote:
>
>> Signed-off-by: Julien Isorce
>> ---
>> src/gallium/state_trackers/omx/vid_dec.c | 51
>> --
Thx Leo.
I confirm it works with nouveau driver so your fix is:
Tested-by: Julien Isorce
On 28 June 2016 at 02:27, Liu, Leo wrote:
> Hi Julien and Christian,
>
>
> I got a patch attached to fix the "fillout" problem, and please review.
>
>
> But we still nee
t sure for h265 case.
Note that for patch 4/4 I am not sure which solution
to take, 1 or 2. But both are working.
Tested on clips available here: http://www.h264info.com/clips.html
Julien Isorce (4):
nouveau: move interlaced assert down in
nouveau_vp3_video_buffer_create
st/va: add missing p
ut at least they will have enough space and
st/va will still write correct value for the number of reference
frames in the hw buffer.
Signed-off-by: Julien Isorce
---
src/gallium/state_trackers/va/context.c | 10 +++---
src/gallium/state_trackers/va/picture.c | 1 +
2 files changed, 8 inser
templat->interlaced is 0 if not NV12 which is the case currently
when using VPP.
Signed-off-by: Julien Isorce
---
src/gallium/drivers/nouveau/nouveau_vp3_video.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/gallium/drivers/nouveau/nouveau_vp3_video.c
b/src/gall
st/va was completely missing parsing of:
VAPictureParameterBufferH264.ReferenceFrames[16]
Signed-off-by: Julien Isorce
---
src/gallium/state_trackers/va/picture.c | 76 +
1 file changed, 76 insertions(+)
diff --git a/src/gallium/state_trackers/va/picture.c
b
Otherwise assert is raised from vlVaQueryConfigProfiles's for loop.
Signed-off-by: Julien Isorce
---
src/gallium/state_trackers/va/va_private.h | 7 +++
1 file changed, 7 insertions(+)
diff --git a/src/gallium/state_trackers/va/va_private.h
b/src/gallium/state_trackers/va/va_priv
PIPE_TEXTURE_2D_ARRAY)
From e47d127a891b1469f1255c11d0a2ed2a0b477c0e Mon Sep 17 00:00:00 2001
From: Julien Isorce
Date: Mon, 23 Nov 2015 09:20:14 +
Subject: [PATCH] WIP: force linear layout for RGBA/RGBX
Signed-off-by: Julien Isorce
---
src/gallium/auxiliary/vl/vl_video_buffer.c | 10 +-
Make sense it was a copy past I did from vlVdpPresentationQueueDisplay.
I tested this change and works fine.
Thx for catching this.
(feel free to set "clear_dirty" param of vl_compositor_render to false even
if it will be ignored anyway)
Reviewed-by: Julien Isorce
On 23 November 201
Nice cleanups. I also tested these changes on "nouveau" driver with one
video per format (except HEVC) and works fine with mpv and gstreamer.
Patches "[PATCH 2/8] st/va: move post processing function into own file" to
"[PATCH 8/8] st/va: fix indentation"
are:
Revi
From: Julien Isorce
In general max_references cannot be based on num_render_targets.
This patch allow to allocate accurate sizes for buffers.
For other codecs it is a fixed value to 2.
This is similar behaviour as vaapi/vdpau-driver.
XXX: do the same for HEVC
Signed-off-by: Julien Isorce
For commit message please read:
"HEVC case is left unchanged since delaying decoder creation is not needed
on AMD hardware."
instead of
"XXX: do the same for HEVC"
On 25 November 2015 at 09:07, Julien Isorce wrote:
> From: Julien Isorce
>
> In general max_
From: Julien Isorce
Other hardwares than AMD require to parse:
VAPictureParameterBufferH264.ReferenceFrames[16]
Signed-off-by: Julien Isorce
---
src/gallium/state_trackers/va/picture_h264.c | 53
1 file changed, 53 insertions(+)
diff --git a/src/gallium
Hi,
In EXT_texture_rg.txt it is mentioned of GL_RED_EXT on gles 2.0.
In glformats.c::_mesa_es_error_check_format_and_type returns
GL_INVALID_VALUE if GL_RED_EXT(as it reaches default case)
so glTexImage2D(..., GL_RED_EXT, GL_UNSIGNED_BYTE, data) fails.
Though GL_EXTENSIONS contains GL_EXT_text
On 25 November 2015 at 09:51, Christian König
wrote:
> On 25.11.2015 10:12, Julien Isorce wrote:
>
> For commit message please read:
>
> "HEVC case is left unchanged since delaying decoder creation is not needed
> on AMD hardware."
>
>
> In this case
On 25 November 2015 at 15:04, Emil Velikov wrote:
> Hi Julien,
>
> On 25 November 2015 at 09:07, Julien Isorce
> wrote:
> > From: Julien Isorce
> >
> > In general max_references cannot be based on num_render_targets.
> >
> > This patch allow to al
before.
But it could also benefits this change by setting a more
accurate max_references number in handlePictureParameterBuffer.
Signed-off-by: Julien Isorce
---
src/gallium/state_trackers/va/context.c | 48 +--
src/gallium/state_trackers/va/picture.c | 49
Signed-off-by: Julien Isorce
---
src/gallium/auxiliary/vl/vl_video_buffer.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/gallium/auxiliary/vl/vl_video_buffer.c
b/src/gallium/auxiliary/vl/vl_video_buffer.c
index 62f4aa9..b3f6ff5 100644
--- a/src/gallium/auxiliary/vl
set or not the flag:
VA_SURFACE_EXTBUF_DESC_ENABLE_TILING
Signed-off-by: Julien Isorce
---
src/gallium/auxiliary/vl/vl_video_buffer.c | 3 +++
src/gallium/include/pipe/p_video_codec.h | 1 +
src/gallium/state_trackers/va/surface.c| 5 +
3 files changed, 9 insertions(+)
diff --gi
On 29 November 2015 at 17:26, Emil Velikov wrote:
> On 27 November 2015 at 08:57, Julien Isorce wrote:
> > In order to do zero-copy between two different devices
> > the memory should not be tiled.
> >
> > This is currently no way to set pipe_resource template's
Hi Christian,
I can try to move the bind flags to pipe_video_buffer.
Thx
Julien
On 29 November 2015 at 19:04, Christian König
wrote:
> On 29.11.2015 18:26, Emil Velikov wrote:
>
>> On 27 November 2015 at 08:57, Julien Isorce wrote:
>>
>>> In order to do zero
On 30 November 2015 at 12:03, Emil Velikov wrote:
> On 26 November 2015 at 08:45, Julien Isorce
> wrote:
>
> > --- a/src/gallium/state_trackers/va/picture.c
> > +++ b/src/gallium/state_trackers/va/picture.c
>
> > @@ -113,12 +118,37 @@ handlePictureParameterBuffer(
On 1 December 2015 at 13:08, Tapani Pälli wrote:
> Which version of Mesa are you using to test this? Ilia fixed this bug:
>
> https://bugs.freedesktop.org/show_bug.cgi?id=93126
>
> which I believe should fix this issue, fix is available in current master
> and Mesa 11.1.
>
>
Hi,
It is me that ope
On 10 November 2015 at 09:28, Ilia Mirkin wrote:
> On Tue, Nov 10, 2015 at 4:09 AM, Julien Isorce
> wrote:
> > Hi,
> >
> > I found some difference in the content of dec->bsp_bo[i], for h264 when
> > using st/vdpau (ok) and st/vaapi (ko).
> >
> > I
Hi, shouldn't the check be the following condition instead:
hevc->ReferenceFrames[i].flags & VA_PICTURE_HEVC_INVALID ||
hevc->ReferenceFrames[i].picture_id == VA_INVALID_SURFACE
?
On 11 December 2015 at 12:33, Christian König
wrote:
> From: Christian König
>
> The picture id in this case is a V
Hi Christian,
I have tested this patch but then the displayed video is garbage (mostly
white and sometimes just garbage). It also stall the nouveau driver which
requires to reboot but I guess this is another issue.
I tested with:
GST_GL_WINDOW=x11 GST_GL_PLATFORM=egl GST_GL_API=gles2 GST_DEBUG=2
L
This patch is:
Reviewed-by: Julien Isorce
Tested-by: Julien Isorce
On 11 December 2015 at 12:33, Christian König
wrote:
> From: Christian König
>
> Signed-off-by: Christian König
> ---
> src/gallium/state_trackers/va/postproc.c | 6 --
> 1 file changed, 6 deletions(-
This patch is:
Reviewed-by: Julien Isorce
Tested-by: ulien Isorce
On 11 December 2015 at 12:33, Christian König
wrote:
> From: Christian König
>
> Signed-off-by: Christian König
> ---
> src/gallium/state_trackers/va/surface.c | 8
> 1 file changed, 4 insertio
This patch is:
Reviewed-by: Julien Isorce
On 11 December 2015 at 12:33, Christian König
wrote:
> From: Christian König
>
> Signed-off-by: Christian König
> ---
> src/gallium/state_trackers/va/picture.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/src/g
This patch is:
Reviewed-by: Julien Isorce
Tested-by: Julien Isorce
On 11 December 2015 at 12:33, Christian König
wrote:
> From: Christian König
>
> Avoid referencing NULL pointers.
>
> Signed-off-by: Christian König
> ---
> src/gallium/state_tracke
This patch is:
Reviewed-by: Julien Isorce
Tested-by: Julien Isorce
On 11 December 2015 at 12:33, Christian König
wrote:
> From: Christian König
>
> Usefull for mpv and GStreamer.
>
> Signed-off-by: Indrajit-kumar Das
> Signed-off-by: Christian König
> ---
> src/g
This patch is:
Reviewed-by: Julien Isorce
Tested-by: Julien Isorce
(tested with gstvaapipostproc from gstreamer-vaapi)
On 11 December 2015 at 12:33, Christian König
wrote:
> From: Christian König
>
> Tested with MPV.
>
> Signed-off-by: Christian König
> ---
> src/gall
s well if you just flush the
> pipeline without waiting for the commands to be finished?
>
> Regards,
> Christian.
>
>
> On 14.12.2015 10:14, Julien Isorce wrote:
>
> Hi Christian,
>
> I have tested this patch but then the displayed video is garbage (mostly
> white an
And the attachment :)
On 15 December 2015 at 09:06, Julien Isorce wrote:
> Hi Christian,
>
> I tried your v2.
>
> I had to apply attached change on top of your patch. (the one in buffer.c
> to avoid crashing, the one postproc.c otherwise same behavior as the v1 of
> thi
+ mesa-dev of course :)
Thx Sean
On 15 December 2015 at 17:46, Sean V Kelley wrote:
>
> > On Dec 15, 2015, at 1:01 AM, Julien Isorce
> wrote:
> >
> > "image" is not ready yet since it will be set at
> > the end of the function by: *image = *i
aBuffer, so not possible to do that.
But in any case I think you are right we should not need thsi flush at all
so I am ok that you remove this flush. The problem should be elsewhere.
So with your v2 + my change in vlVaAcquireBufferHandle,
This patch is:
Reviewed-by: Julien Isorce
Tested-by
test it.
Ilia Mirkin suggested to do it afterward.
https://bugs.freedesktop.org/show_bug.cgi?id=89969
Julien Isorce (4):
nouveau: split nouveau_vp3_bsp in begin/next/end
nvc0: add support for st/va
nouveau: fix chunk decoding by updating number of slices
build: enable st/va with nouveau
101 - 200 of 262 matches
Mail list logo
