On Thu, Jan 10, 2019 at 2:33 AM Ian Romanick wrote:
>
> On 1/8/19 9:57 PM, Kenneth Graunke wrote:
> > On Tuesday, December 4, 2018 10:26:43 AM PST Karol Herbst wrote:
> >> the naming is a bit confusing no matter how you look at it. Within SPIR-V
> >> "global&qu
On Thu, Jan 10, 2019 at 1:06 PM Karol Herbst wrote:
>
> On Thu, Jan 10, 2019 at 2:33 AM Ian Romanick wrote:
> >
> > On 1/8/19 9:57 PM, Kenneth Graunke wrote:
> > > On Tuesday, December 4, 2018 10:26:43 AM PST Karol Herbst wrote:
> > >> the naming is
"
On Fri, Jan 11, 2019 at 5:19 PM Kenneth Graunke wrote:
>
> On Wednesday, January 9, 2019 5:33:22 PM PST Ian Romanick wrote:
> > On 1/8/19 9:57 PM, Kenneth Graunke wrote:
> > > On Tuesday, December 4, 2018 10:26:43 AM PST Karol Herbst wrote:
> > >> the n
On Fri, Jan 11, 2019 at 8:50 PM Kenneth Graunke wrote:
>
> On Friday, January 11, 2019 9:32:20 AM PST Eric Anholt wrote:
> > Jason Ekstrand writes:
> >
> > > On Fri, Jan 11, 2019 at 11:11 AM Kenneth Graunke
> > > wrote:
> > >
> > >> On Friday, January 11, 2019 8:33:41 AM PST Jason Ekstrand
On Wed, Jan 9, 2019 at 6:57 AM Kenneth Graunke wrote:
>
> On Tuesday, December 4, 2018 10:26:43 AM PST Karol Herbst wrote:
> > the naming is a bit confusing no matter how you look at it. Within SPIR-V
> > "global" memory is memory accessible from all threads. glsl
Hi Dylan,
this patch only matters for debug builds (DEBUG set), but your merge
result looks correct nonetheless.
Thanks
On Fri, Sep 14, 2018 at 6:16 PM, Dylan Baker wrote:
> Quoting Pierre Moreau (2017-12-04 15:51:04)
>> Those operations do not map to actual hardware instructions, therefore
>>
some instructions can read from a const buffer but not long immediates, some
instructions can take an immediate and a const buffer, but not two immediates.
Put immediates we can't load propagate into the driver const buffer, so that
shaders can read from there instead doing some movs writing the
On Sun, Mar 17, 2019 at 10:52 PM Mauro Rossi wrote:
>
> Add the necessary build rules for android, to avoid building errors.
>
> Fixes: f014ae3 ("nouveau: add support for nir")
> Signed-off-by: Mauro Rossi
> ---
> src/gallium/drivers/nouveau/Android.mk | 7 ++-
> 1 file changed, 6
On Sun, Mar 17, 2019 at 11:56 PM Mauro Rossi wrote:
>
> Hi Karol,
>
> On Sun, Mar 17, 2019 at 11:25 PM Karol Herbst wrote:
> >
> > On Sun, Mar 17, 2019 at 10:52 PM Mauro Rossi wrote:
> > >
> > > Add the necessary build rules for android, to avoid b
Reviewed-by: Karol Herbst
On Wed, Mar 20, 2019 at 1:22 PM Lionel Landwerlin
wrote:
>
> Reviewed-by: Lionel Landwerlin
>
> On 19/03/2019 19:15, Jason Ekstrand wrote:
> > ---
> > src/compiler/nir/nir.h | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deleti
On Tue, Mar 12, 2019 at 1:09 AM Ilia Mirkin wrote:
>
> On Mon, Mar 11, 2019 at 8:05 PM Karol Herbst wrote:
> >
> > v9: convert to C++ style comments
> > Signed-off-by: Karol Herbst
> > ---
> > src/gallium/drivers/nouveau/codegen/nv50_ir_from_nir.cpp | 6
v4: use loadFrom helper
v5: support indirect buffer access
v8: don't require C++11 features
Signed-off-by: Karol Herbst
---
.../nouveau/codegen/nv50_ir_from_nir.cpp | 90 +++
1 file changed, 90 insertions(+)
diff --git a/src/gallium/drivers/nouveau/codegen
v8: don't require C++11 features
Signed-off-by: Karol Herbst
---
.../nouveau/codegen/nv50_ir_from_nir.cpp | 72 +++
1 file changed, 72 insertions(+)
diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_from_nir.cpp
b/src/gallium/drivers/nouveau/codegen
to make it easier to grep them
add handling for fpow
Signed-off-by: Karol Herbst
---
.../nouveau/codegen/nv50_ir_from_nir.cpp | 562 +-
1 file changed, 561 insertions(+), 1 deletion(-)
diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_from_nir.cpp
b/src/gallium
checking to slots
Signed-off-by: Karol Herbst
---
.../nouveau/codegen/nv50_ir_from_nir.cpp | 642 ++
1 file changed, 642 insertions(+)
diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_from_nir.cpp
b/src/gallium/drivers/nouveau/codegen/nv50_ir_from_nir.cpp
index
v8: fix loading 8/16 bit constants
Signed-off-by: Karol Herbst
Reviewed-by: Pierre Moreau
---
.../nouveau/codegen/nv50_ir_from_nir.cpp | 28 +++
1 file changed, 28 insertions(+)
diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_from_nir.cpp
b/src/gallium/drivers
txf with a uniform constant 0 lod
Signed-off-by: Karol Herbst
---
.../nouveau/codegen/nv50_ir_from_nir.cpp | 234 ++
1 file changed, 234 insertions(+)
diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_from_nir.cpp
b/src/gallium/drivers/nouveau/cod
v4: treat imul as unsigned
v5: remove pointless !!
v7: inot is unsigned as well
v8: don't require C++11 features
v9: convert to C++ style comments
improve formatting
print error in all cases where codegen doesn't support a given type
Signed-off-by: Karol Herbst
Acked-by: Pierre Moreau
v9: use getSSA instead of new_LValue
Signed-off-by: Karol Herbst
---
.../drivers/nouveau/codegen/nv50_ir_from_nir.cpp | 14 ++
1 file changed, 14 insertions(+)
diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_from_nir.cpp
b/src/gallium/drivers/nouveau/codegen
->prop.fp.readsSampleLocations for at_sample interpolation
don't require C++11 features
v9: convert to C++ style comments
Signed-off-by: Karol Herbst
---
.../nouveau/codegen/nv50_ir_from_nir.cpp | 135 ++
1 file changed, 135 insertions(+)
diff --git a/src/gallium/driv
v2: use new getIndirect helper
fixes symbols for 64 bit types
v4: use smarter getIndirect helper
simplify address calculation
use loadFrom helper
v8: don't require C++11 features
Signed-off-by: Karol Herbst
---
.../drivers/nouveau/codegen/nv50_ir_from_nir.cpp | 10
Signed-off-by: Karol Herbst
Reviewed-by: Pierre Moreau
---
.../nouveau/codegen/nv50_ir_from_nir.cpp| 17 +
1 file changed, 17 insertions(+)
diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_from_nir.cpp
b/src/gallium/drivers/nouveau/codegen/nv50_ir_from_nir.cpp
v2: remove TGSI related bits
Signed-off-by: Karol Herbst
Reviewed-by: Pierre Moreau
---
src/gallium/drivers/nouveau/Makefile.sources | 2 +
.../nouveau/codegen/nv50_ir_from_common.cpp | 107 ++
.../nouveau/codegen/nv50_ir_from_common.h | 58 ++
.../nouveau
by the
spoken of patch.
Can be enabled by setting NV50_PROG_USE_NIR=1
Chanelogs attached to the patches directly and nothing really new since the
last time I posted that series, mostly just fixing compatibility with master.
Have fun.
Karol Herbst (34):
prog_to_nir: fix write from vps to PSIZ
nvc0
fault"
fix memory leak when creating compute shaders
use debug_get_bool_option as it is available in non debug builds
return failure if unsupported IR is encountered
don't lower fpow in nir
Signed-off-by: Karol Herbst
Reviewed-by: Pierre Moreau
---
src/gallium/drivers/nouveau/Au
of NOT
v8: don't require C++11 features
Signed-off-by: Karol Herbst
Reviewed-by: Pierre Moreau
---
src/gallium/drivers/nouveau/Makefile.sources | 2 +
.../codegen/nv50_ir_lowering_helper.cpp | 275 ++
.../nouveau/codegen/nv50_ir_lowering_helper.h | 53
src/gallium
Point size is a single component value and drivers might write the full vec4
potentially overwriting other values.
Signed-off-by: Karol Herbst
---
src/mesa/program/prog_to_nir.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/src/mesa/program/prog_to_nir.c b/src/mesa
v9: rename variable to driver_flags
use constants for shader cache flags
Signed-off-by: Karol Herbst
Reviewed-by: Pierre Moreau
---
src/gallium/drivers/nouveau/nouveau_screen.c | 8 +++-
src/gallium/drivers/nouveau/nouveau_screen.h | 3 +++
2 files changed, 10 insertions(+), 1 deletion
v2: add constant_folding
v6: print non final NIR only for verbose debugging
v8: add passes we will need for OpenCL compute shaders
v9: move type_size into anonymous namespace
convert to C++ style comments
lower bools to int32
Signed-off-by: Karol Herbst
Acked-by: Pierre Moreau
this makes debugging the shader header a little easier
Acked-by: Pierre Moreau
Signed-off-by: Karol Herbst
---
src/gallium/drivers/nouveau/nvc0/nvc0_program.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/gallium/drivers/nouveau/nvc0/nvc0_program.c
b/src/gallium/drivers/nouveau/nvc0
stdlibs
replace '(*it).' with 'it->'
Signed-off-by: Karol Herbst
---
.../nouveau/codegen/nv50_ir_from_nir.cpp | 150 ++
1 file changed, 150 insertions(+)
diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_from_nir.cpp
b/src/gallium/drivers/nouveau/code
v4: use loadFrom helper
v8: don't require C++11 features
Signed-off-by: Karol Herbst
---
.../drivers/nouveau/codegen/nv50_ir_from_nir.cpp | 14 ++
1 file changed, 14 insertions(+)
diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_from_nir.cpp
b/src/gallium/drivers/nouveau
v4: use smarter getIndirect helper
use new getSlotAddress helper
v5: use loadFrom helper
v8: don't require C++11 features
Signed-off-by: Karol Herbst
---
.../nouveau/codegen/nv50_ir_from_nir.cpp | 23 +++
1 file changed, 23 insertions(+)
diff --git a/src/gallium
v5: add more barrier intrinsics
Signed-off-by: Karol Herbst
---
.../nouveau/codegen/nv50_ir_from_nir.cpp | 21 +++
1 file changed, 21 insertions(+)
diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_from_nir.cpp
b/src/gallium/drivers/nouveau/codegen
v9: convert to C++ style comments
Signed-off-by: Karol Herbst
---
src/gallium/drivers/nouveau/codegen/nv50_ir_from_nir.cpp | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_from_nir.cpp
b/src/gallium/drivers/nouveau/codegen
v5: use loadFrom helper
v8: don't require C++11 features
v9: convert to C++ style comments
Signed-off-by: Karol Herbst
---
.../nouveau/codegen/nv50_ir_from_nir.cpp | 58 +++
1 file changed, 58 insertions(+)
diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_from_nir.cpp
-by: Karol Herbst
---
.../nouveau/codegen/nv50_ir_from_nir.cpp | 48 +++
1 file changed, 48 insertions(+)
diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_from_nir.cpp
b/src/gallium/drivers/nouveau/codegen/nv50_ir_from_nir.cpp
index ab3bf7f843a..7a10a408b70 100644
Signed-off-by: Karol Herbst
---
.../nouveau/codegen/nv50_ir_from_nir.cpp | 57 ++-
1 file changed, 56 insertions(+), 1 deletion(-)
diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_from_nir.cpp
b/src/gallium/drivers/nouveau/codegen/nv50_ir_from_nir.cpp
index dc8dbcfb48b
v7: don't assert in default case for getSubOp
Signed-off-by: Karol Herbst
Reviewed-by: Pierre Moreau
---
.../nouveau/codegen/nv50_ir_from_nir.cpp | 22 +++
1 file changed, 22 insertions(+)
diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_from_nir.cpp
b/src
-by: Karol Herbst
---
.../nouveau/codegen/nv50_ir_from_nir.cpp | 122 ++
1 file changed, 122 insertions(+)
diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_from_nir.cpp
b/src/gallium/drivers/nouveau/codegen/nv50_ir_from_nir.cpp
index 5c372794e02..43c9a468f5a 100644
instructions
don't require C++11 features
v9: implement MS images
rebase on master (image modifiers)
fix regressions due to variable src compnents
replace '(*it).' with 'it->'
convert to C++ style comments
Signed-off-by: Karol Herbst
---
.../nouveau/codegen/nv50_ir_from_nir.
Signed-off-by: Karol Herbst
---
.../nouveau/codegen/nv50_ir_from_nir.cpp | 59 +--
1 file changed, 41 insertions(+), 18 deletions(-)
diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_from_nir.cpp
b/src/gallium/drivers/nouveau/codegen/nv50_ir_from_nir.cpp
index
v4: use smarter getIndirect helper
use new getSlotAddress helper
use loadFrom helper
v8: don't require C++11 features
Signed-off-by: Karol Herbst
---
.../nouveau/codegen/nv50_ir_from_nir.cpp | 27 +++
1 file changed, 27 insertions(+)
diff --git a/src/gallium
v2: use mkOp
v8: don't require C++11 features
Signed-off-by: Karol Herbst
Reviewed-by: Pierre Moreau
---
.../drivers/nouveau/codegen/nv50_ir_from_nir.cpp| 13 +
1 file changed, 13 insertions(+)
diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_from_nir.cpp
b/src
v2: parse a few more fields
v3: add special handling for GL_ISOLINES
v8: set info->prop.fp.readsSampleLocations
don't require C++11 features
v9: replace '(*it).' with 'it->'
convert to C++ style comments
Signed-off-by: Karol Herbst
---
.../nouveau/codegen/nv50_ir_from_nir.cpp
v9: mark as fixed
Signed-off-by: Karol Herbst
---
src/gallium/drivers/nouveau/codegen/nv50_ir_from_nir.cpp | 8
1 file changed, 8 insertions(+)
diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_from_nir.cpp
b/src/gallium/drivers/nouveau/codegen/nv50_ir_from_nir.cpp
index
Reviewed-by: Karol Herbst
On Thu, Feb 7, 2019 at 11:55 PM Eric Anholt wrote:
>
> Alyssa Rosenzweig writes:
>
> > Regardless of whether the build uses kmsro, kmsro is the default driver
> > descriptor when the static loader is used. Thus, in an edge case where
> >
for registers and const memory
rework if clauses
merge isCvt into this patch
Signed-off-by: Karol Herbst
---
src/gallium/drivers/nouveau/codegen/nv50_ir.h | 1 +
.../drivers/nouveau/codegen/nv50_ir_inlines.h | 17 +
.../nouveau/codegen/nv50_ir_lowering_nvc0.cpp | 64
for registers and const memory
rework if clauses
merge isCvt into this patch
v4: merge isCvt into its use
Signed-off-by: Karol Herbst
---
.../nouveau/codegen/nv50_ir_lowering_nvc0.cpp | 64 +++
.../nouveau/codegen/nv50_ir_lowering_nvc0.h | 1 +
2 files changed, 65 insertions
Reviewed-by: Karol Herbst
On Sun, Feb 3, 2019 at 4:10 PM Ilia Mirkin wrote:
>
> Atomic operations don't update the local cache, which means that we
> would have to issue CCTL operations in order to get the updated values.
> When we know that a buffer is primarily used for atomi
ohhh, yeah.. I think we can actually just remove that code, as it
shouldn't have any affect on the constants value.
On Fri, May 17, 2019 at 4:07 AM Jason Ekstrand wrote:
>
> I think it's fine but I'm not at my computer right now.
>
> --Jason
>
> On May 16, 2019 20:58:03 Dave Airlie wrote:
>
> >
ts
> out, it probably is safe to just delete. However, I'd feel slightly better
> about it if we figured out the right bit size and just called
> nir_eval_const_opcode to do a u2u32 on the value.
>
> --Jason
>
> On Fri, May 17, 2019 at 1:24 AM Karol Herbst wrote:
>>
>>
ohh, nvm... I already know...
On Tue, Jun 18, 2019 at 11:18 PM Karol Herbst wrote:
>
> On Tue, Jun 18, 2019 at 11:14 PM Dave Airlie wrote:
> >
> > From: Dave Airlie
> >
> > This is pointless in that we won't ever hit those paths in real life,
> > but c
On Tue, Jun 18, 2019 at 11:14 PM Dave Airlie wrote:
>
> From: Dave Airlie
>
> This is pointless in that we won't ever hit those paths in real life,
> but coverity complains.
>
what does it actually complain about?
> Fixes: f014ae3c7cce ("nouveau: add support for nir")
> ---
>
From: Pierre Moreau
Reviewed-by: Karol Herbst
---
.../state_trackers/clover/llvm/invocation.cpp | 100 +++---
.../state_trackers/clover/llvm/invocation.hpp | 8 ++
src/gallium/state_trackers/clover/meson.build | 2 +-
3 files changed, 92 insertions(+), 18 deletions(-)
diff
From: Pierre Moreau
v2 (Karol Herbst):
silence warnings about unhandled enum values
---
.../clover/spirv/invocation.cpp | 598 ++
.../clover/spirv/invocation.hpp | 12 +
2 files changed, 610 insertions(+)
diff --git a/src/gallium/state_trackers
From: Pierre Moreau
Changes since:
* v12: remove autotools (Karol Herbst)
* v11: Fix compilation error introduced in v11.
* v10:
- Reuse format_validation_msg in is_valid_spirv.
- Remove LVL2STR macro in format_validation_msg.
* v9: Add `clover_cpp_std` to the overrides of the `libclspirv
From: Pierre Moreau
Changes since:
* v11 (Karol Herbst):
- only set new defines for clover to speed up recompilation
- remove autotools
* v10:
- Add a new flag (`--enable-opencl-spirv` for autotools, and
`-Dopencl-spirv=true` for meson) for enabling SPIR-V support in
clover
makes it easier to consume a IR_NATIVE binary
Signed-off-by: Karol Herbst
Reviewed-by: Francisco Jerez
---
src/gallium/drivers/r600/evergreen_compute.c | 4 +---
src/gallium/drivers/radeonsi/si_compute.c | 4 +---
src/gallium/include/pipe/p_state.h
required for OpenCL
Signed-off-by: Karol Herbst
Reviewed-by: Pierre Moreau
---
src/gallium/drivers/nouveau/codegen/nv50_ir_from_nir.cpp | 2 --
1 file changed, 2 deletions(-)
diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_from_nir.cpp
b/src/gallium/drivers/nouveau/codegen
required by OpenCL
Signed-off-by: Karol Herbst
Reviewed-by: Pierre Moreau
---
.../nouveau/codegen/nv50_ir_from_nir.cpp | 61 ++-
1 file changed, 32 insertions(+), 29 deletions(-)
diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_from_nir.cpp
b/src/gallium/drivers
required by OpenCL
v2: fix setting globalAccess
Signed-off-by: Karol Herbst
Reviewed-by: Pierre Moreau
---
.../nouveau/codegen/nv50_ir_from_nir.cpp | 36 +++
1 file changed, 36 insertions(+)
diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_from_nir.cpp
b/src
v2: rework arguments to compiler::compile_program
add assert to device::ir_format
Signed-off-by: Karol Herbst
Reviewed-by: Francisco Jerez
---
src/gallium/include/pipe/p_defines.h | 1 +
.../state_trackers/clover/core/compiler.hpp | 68 +++
.../state_trackers
We want to use it for other formats as well, so give it a more generic name
Signed-off-by: Karol Herbst
Reviewed-by: Francisco Jerez
---
src/gallium/drivers/r600/evergreen_compute.c | 2 +-
src/gallium/drivers/radeonsi/si_compute.c | 2 +-
src/gallium/include/pipe
required for OpenCL
Signed-off-by: Karol Herbst
---
src/gallium/drivers/nouveau/nouveau_screen.c | 1 +
src/gallium/drivers/nouveau/nouveau_screen.h | 1 +
src/gallium/drivers/nouveau/nvc0/nvc0_screen.c | 14 +-
src/gallium/drivers/nouveau/nvc0/nvc0_screen.h | 2 ++
src
.
Signed-off-by: Karol Herbst
---
src/gallium/include/pipe/p_state.h| 1 +
src/gallium/state_trackers/clover/core/kernel.cpp | 1 +
2 files changed, 2 insertions(+)
diff --git a/src/gallium/include/pipe/p_state.h
b/src/gallium/include/pipe/p_state.h
index c94dfb0ba78..d043f0d19af 100644
From: Pierre Moreau
Reviewed-by: Karol Herbst
---
.../state_trackers/clover/llvm/util.hpp | 4 ++-
.../clover/spirv/invocation.cpp | 30 +++
.../clover/spirv/invocation.hpp | 4 +++
3 files changed, 37 insertions(+), 1 deletion(-)
diff --git
required by OpenCL
Signed-off-by: Karol Herbst
Reviewed-by: Pierre Moreau
---
.../nouveau/codegen/nv50_ir_from_nir.cpp | 21 ---
1 file changed, 18 insertions(+), 3 deletions(-)
diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_from_nir.cpp
b/src/gallium/drivers
library to convert llvm to spirv.
Karol Herbst (10):
nv50/ir/nir: parse system values first and stop for compute shaders
nv50/ir/nir: don't assert on !main
nv50/ir/nir: handle kernel inputs
nv50/ir/nir: implement load/store_global
gallium: add blob field to pipe_llvm_program_header
Signed-off-by: Karol Herbst
---
src/compiler/Makefile.sources| 1 +
src/compiler/nir/meson.build | 1 +
src/compiler/spirv/nir_spirv.h | 4 +
src/compiler/spirv/spirv_to_nir_cl.c | 124 +++
4 files changed, 130 insertions(+)
create mode 100644
Signed-off-by: Karol Herbst
Suggested-by: Ilia Mirkin
---
src/gallium/drivers/nouveau/codegen/nv50_ir_from_nir.cpp | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_from_nir.cpp
b/src/gallium/drivers/nouveau/codegen
Signed-off-by: Karol Herbst
---
src/gallium/drivers/nouveau/codegen/nv50_ir_from_nir.cpp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_from_nir.cpp
b/src/gallium/drivers/nouveau/codegen/nv50_ir_from_nir.cpp
index 7e59b83e8fc
Signed-off-by: Karol Herbst
---
src/gallium/drivers/nouveau/nv50/nv50_screen.c | 13 +
src/gallium/drivers/nouveau/nvc0/nvc0_screen.c | 13 +
2 files changed, 26 insertions(+)
diff --git a/src/gallium/drivers/nouveau/nv50/nv50_screen.c
b/src/gallium/drivers/nouveau/nv50
right now that's dead code
Signed-off-by: Karol Herbst
---
src/gallium/drivers/nouveau/codegen/nv50_ir_driver.h | 1 -
src/gallium/drivers/nouveau/nvc0/nvc0_program.c | 4
src/gallium/drivers/nouveau/nvc0/nvc0_program.h | 1 -
3 files changed, 6 deletions(-)
diff --git a/src
VATIVES one,
but I could add another one for CS_DERIVED_SYSTEM_VALUES
> On Tue, Jul 2, 2019 at 11:49 AM Karol Herbst wrote:
> >
> > Signed-off-by: Karol Herbst
> > ---
> > src/gallium/drivers/nouveau/nv50/nv50_screen.c | 13 +
> > src/gallium/drivers/nouveau/
On Tue, Jul 23, 2019 at 4:50 PM Ilia Mirkin wrote:
>
> You handle 1/n but not 1%n? TBH, the 1/n code isn't 100% obvious to
> me... 1/n = |n|-1 > 0 ? i forget how SLCT works, but I can't
> think of a way to finish that expression in terms of |n|-1 and n. And
> what about n == 0. I'd just as
yeah.. I am not quite sure myself about it. But skipping on the div
emulation seems like a good idea in general. But it's also not common
enough to actually care all that much about it.
On Tue, Jul 23, 2019 at 5:18 PM Ilia Mirkin wrote:
>
> On Tue, Jul 23, 2019 at 11:15 AM Karol Herbst
it's only fixing a crash in a build with asserts enabled, but if
somebody wants to apply those to stable, then go ahead.
On Wed, Jul 24, 2019 at 12:48 PM Juan A. Suarez Romero
wrote:
>
> On Fri, 2019-07-19 at 13:56 +0200, Mark Menzynski wrote:
> > Fixes:
Reviewed-by: Karol Herbst
On Fri, Jul 26, 2019 at 5:31 AM Ilia Mirkin wrote:
>
> Apparently vl (or vdpau) wants to pass that in now. Handle it.
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=111213
> Signed-off-by: Ilia Mirkin
> Cc: mesa-sta...@lists.freedeskto
Reviewed-by: Karol Herbst
On Fri, Jul 26, 2019 at 5:31 AM Ilia Mirkin wrote:
>
> Previously the code only handled it for positions 1 and up (as would be
> for UBO's in GL). It's not a lot of trouble to handle this, and vl or
> vdpau want this.
>
> Bugzilla: https://bu
Reviewed-by: Karol Herbst
On Fri, Jul 26, 2019 at 5:31 AM Ilia Mirkin wrote:
>
> The meson conversion chose to change the meaning of DEBUG to "used for
> debugging" to be "used for expensive things for debugging", primarily
> for nir_validate. Flip things
Reviewed-by: Karol Herbst
On Fri, Jul 26, 2019 at 7:03 AM Ilia Mirkin wrote:
>
> This can happen if it's e.g. a uniform or a function argument.
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=111217
> Signed-off-by: Ilia Mirkin
> Cc: mesa-sta...@lists.freedeskto
OpenCL nir path and that
works out quite nicely as now you can just call different entry points
without having to deal with this "if this function is the entry point,
args get passed differently than being a called function" situation.
Anyway, the for the patch itself:
Reviewed-by: Karol
t;data" pointer)
>
> Let me know if you want me to resend.
>
no, that's fine..
> On Fri, Jul 26, 2019 at 5:51 AM Karol Herbst wrote:
> >
> > Reviewed-by: Karol Herbst
> >
> > On Fri, Jul 26, 2019 at 5:31 AM Ilia Mirkin wrote:
> > >
> > > Pr
Signed-off-by: Karol Herbst
---
src/gallium/drivers/nouveau/codegen/nv50_ir.cpp| 4 +---
src/gallium/drivers/nouveau/codegen/nv50_ir.h | 2 +-
src/gallium/drivers/nouveau/codegen/nv50_ir_target.cpp | 2 +-
3 files changed, 3 insertions(+), 5 deletions(-)
diff --git a/src
Signed-off-by: Karol Herbst
---
src/gallium/drivers/nouveau/codegen/nv50_ir_util.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_util.h
b/src/gallium/drivers/nouveau/codegen/nv50_ir_util.h
index 307c23d5e03..b1766f48205 100644
Signed-off-by: Karol Herbst
---
src/gallium/drivers/nouveau/codegen/nv50_ir_from_nir.cpp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_from_nir.cpp
b/src/gallium/drivers/nouveau/codegen/nv50_ir_from_nir.cpp
index 4e86ab8f8cc
Signed-off-by: Karol Herbst
---
src/gallium/drivers/nouveau/nv50/nv50_state.c | 10 +++---
src/gallium/drivers/nouveau/nvc0/nvc0_state.c | 10 +++---
2 files changed, 14 insertions(+), 6 deletions(-)
diff --git a/src/gallium/drivers/nouveau/nv50/nv50_state.c
b/src/gallium/drivers
I think you only need to recompile the translator with -fPIC enabled.
At least that's what the error is saying.
On Thu, Sep 26, 2019 at 6:53 AM Aaron Watry wrote:
>
> Pretty sure I'm running into the same thing trying to build clover
> with llvm-spirv enabled. If it's a known solution, I
Signed-off-by: Karol Herbst
---
src/gallium/drivers/nouveau/codegen/nv50_ir.cpp | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir.cpp
b/src/gallium/drivers/nouveau/codegen/nv50_ir.cpp
index a181a13a3b1..ae07d967221 100644
--- a/src/gallium/drivers
Poisoned by user:f7
Container overflow: fc
Array cookie:ac
Intra object redzone:bb
ASan internal: fe
Left alloca redzone: ca
Right alloca redzone:cb
Shadow gap: cc
==612087==ABORTING
Signed-off-by: Karol Herbs
might be that those definitions moved elsewhere or the headers were
never directly included.
In llvm 9 there are in llvm/InitializePasses.h, but maybe that's
changed? And if not, maybe that file needs to be included in
SPIRVLowerSPIRBlocks.cpp?
On Fri, Nov 15, 2019 at 2:34 AM Dieter Nützel
Otherwise applications (like the OpenCL CTS) will try to allocate more memory
than what the GPU is actually able to provide.
Signed-off-by: Karol Herbst
---
src/gallium/drivers/nouveau/nv50/nv50_screen.c | 7 +--
src/gallium/drivers/nouveau/nvc0/nvc0_screen.c | 7 +--
2 files changed
On Thu, Dec 5, 2019 at 11:57 AM Karol Herbst wrote:
>
> TGSI doesn't have any concept of global memory right now.
>
> Signed-off-by: Karol Herbst
> ---
> .../nouveau/codegen/nv50_ir_from_nir.cpp | 43 +--
> .../nouveau/codegen/nv50_ir_lowering_nvc0.
it was never used
Signed-off-by: Karol Herbst
---
src/gallium/drivers/nouveau/codegen/nv50_ir_bb.cpp| 3 ---
src/gallium/drivers/nouveau/codegen/nv50_ir_graph.cpp | 8 +---
src/gallium/drivers/nouveau/codegen/nv50_ir_graph.h | 1 -
src/gallium/drivers/nouveau/codegen/nv50_ir_ra.cpp
On Mon, Oct 14, 2019 at 5:10 PM Karol Herbst wrote:
> >
> > it was never used
> >
> > Signed-off-by: Karol Herbst
> > ---
> > src/gallium/drivers/nouveau/codegen/nv50_ir_bb.cpp| 3 ---
> > src/gallium/drivers/nouveau/codegen/nv50_ir_graph.cpp | 8 +
Reviewed-by: Karol Herbst
On Mon, Oct 14, 2019 at 8:47 AM Ilia Mirkin wrote:
>
> Observed an issue when looking at the code generatedy by the
> image-vertex-attrib-input-output piglit test. Even though the test
> itself worked fine (due to TIC 0 being used for the image)
I don't think this is a good idea overall.
The way simpler solution would be to disable tiling on the z axis for
3d images so that we don't hurt the most common case, 2d images. And
that's what I was seeing nvidia doing anyway.
So with that we would end up adding a bunch of instructions hurting
TGSI doesn't have any concept of global memory right now.
Signed-off-by: Karol Herbst
---
.../nouveau/codegen/nv50_ir_from_nir.cpp | 43 +--
.../nouveau/codegen/nv50_ir_lowering_nvc0.cpp | 2 +
2 files changed, 41 insertions(+), 4 deletions(-)
diff --git a/src/gallium
On Wed, Mar 4, 2020 at 6:37 PM Emil Velikov wrote:
>
> Hi Mark,
>
> On Fri, 21 Feb 2020 at 12:20, Mark Menzynski wrote:
>
> > - ret = nv50_ir_generate_code(info);
> > + /* these fields might be overwritten by the compiler */
> > + info_out.bin.smemSize = prog->cp.smem_size;
> > +
801 - 900 of 925 matches
Mail list logo
